feat(forge): pr create allows edits from maintainers #905

Merged

HumanBean merged 1 commit from HumanBean/Longshot:feat/forge-maintainer-edits into main 2026-11-15 20:19:57 +00:00

Conversation 0 Commits 1 Files changed 1 +2 -2

HumanBean commented 2026-11-15 19:59:47 +00:00

Owner

• Copy link
• Copy Markdown

Type: feat · Risk: low · Tested on: Linux (forge.py run only; no game change) · Needs: none

Why

A maintainer can't push a small fix to a contributor's PR branch unless the author ticked "Allow edits from maintainers". PRs opened with forge.py pr create left it off, so every fix-up needed a round trip.

What changed

pr create now turns on allow_maintainer_edit for the PR it opens. The create call has no field for it, so it is set in the edit that already follows (the one that fills the description), which now always runs.

• scripts/forge.py: cmd_pr create branch, edit_pr(..., allow_maintainer_edit=True).

Measurements

Verdict: nothing to measure: a forge script, no game code.

Flags and settings

None.

Testing

Tested: this PR was opened with the changed script; its allow_maintainer_edit is checked after creation (see the comment).

Not tested: the game-free checks (tests/run_all.py): they run on CI, not on this PC.

Must be tested: None.

Risks

What could break: pr create makes one extra API call when the description needs no change.

Turning it off: revert the commit.

Compatibility: Nothing changes.

Checklist

Everyone

• One topic.
• The title is a Conventional Commit (type(scope): description) of the status line's type.
• Why gives the reason plainly and links the issues that fit (the tracker searched).
• Measurements has a verdict, or one line saying why there is nothing to measure.
• Testing names what was tested, what wasn't, and what must still be tested, where and how.
• Rebased on current main.
• python -I -B tests/run_all.py passes (any failure that also fails on main is named).
• No game files, dumps, build output or generated files.
• third_party/ untouched (a new folder with a PROVENANCE.md instead).
• The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

• AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

**Type:** feat · **Risk:** low · **Tested on:** Linux (forge.py run only; no game change) · **Needs:** none ## Why A maintainer can't push a small fix to a contributor's PR branch unless the author ticked "Allow edits from maintainers". PRs opened with `forge.py pr create` left it off, so every fix-up needed a round trip. ## What changed `pr create` now turns on `allow_maintainer_edit` for the PR it opens. The create call has no field for it, so it is set in the edit that already follows (the one that fills the description), which now always runs. - scripts/forge.py: `cmd_pr` create branch, `edit_pr(..., allow_maintainer_edit=True)`. ## Measurements **Verdict:** nothing to measure: a forge script, no game code. ### Flags and settings None. ## Testing **Tested:** this PR was opened with the changed script; its `allow_maintainer_edit` is checked after creation (see the comment). **Not tested:** the game-free checks (`tests/run_all.py`): they run on CI, not on this PC. **Must be tested:** None. ## Risks **What could break:** `pr create` makes one extra API call when the description needs no change. **Turning it off:** revert the commit. **Compatibility:** Nothing changes. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [ ] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers.

HumanBean added 1 commit 2026-11-15 19:59:47 +00:00

feat(forge): pr create allows edits from maintainers, so a maintainer can push a fix to the PR's branch ... 5023fe1231

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

BeanIssues added the

area/tooling

kind

feature

labels 2026-11-15 19:59:51 +00:00

HumanBean changed title from WIP: feat(forge): pr create allows edits from maintainers to feat(forge): pr create allows edits from maintainers 2026-11-15 20:19:53 +00:00

HumanBean merged commit 237a94b80d into main 2026-11-15 20:19:57 +00:00

HumanBean deleted branch feat/forge-maintainer-edits 2026-11-15 20:19:57 +00:00

HumanBean referenced this pull request from a commit 2026-11-15 20:19:58 +00:00

feat(forge): pr create allows edits from maintainers (#905)

HumanBean referenced this pull request 2026-11-15 20:26:31 +00:00

chore(agents): the shared sign-in, forge.py, team chat and shared skills move to MagicBeanDev/Tooling, and a game change opens only once it has run in the game #915

HumanBean referenced this pull request from MagicBeanDev/Tooling 2026-11-15 20:28:32 +00:00

feat: the team's shared tooling: one sign-in, forge.py for every repository, the team chat, test requests and the agents' skills #1

HumanBean referenced this pull request from a commit 2026-11-15 20:44:04 +00:00

feat: the team's shared tooling: one sign-in, forge.py for every repository, the team chat, test requests and the agents' skills (#1)

HumanBean referenced this pull request from MagicBeanDev/Tooling 2026-11-15 20:45:37 +00:00

fix(forge): pr create allows edits from maintainers, as Longshot's did #2

HumanBean referenced this pull request 2026-11-15 20:45:50 +00:00

chore(agents): the shared sign-in, forge.py, team chat and shared skills move to MagicBeanDev/Tooling, and a game change opens only once it has run in the game #915

HumanBean referenced this pull request from a commit 2026-11-15 20:45:59 +00:00

chore(agents): the shared sign-in, forge.py, team chat and shared skills move to MagicBeanDev/Tooling, and a game change opens only once it has run in the game (#915)

zeldaootr referenced this pull request 2026-11-15 20:51:22 +00:00

chore(forge): search pull requests and issues, pr close and reopen, pr view --body and --json #831

zeldaootr referenced this pull request 2026-11-15 20:51:23 +00:00

chore(forge): search pull requests and issues, pr close and reopen, pr view --body and --json #831

zeldaootr referenced this pull request 2026-11-15 20:54:43 +00:00

WIP: test(forge): the pr create check expects the edit that allows maintainer edits #926

HumanBean referenced this pull request from a commit 2026-11-15 21:08:30 +00:00

fix(forge): pr create allows edits from maintainers, as Longshot's did (#2)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/accessibility

Barriers for people with disabilities

  

area/audio

Sound and music

  

area/input

Controllers, keyboard, mouse

  

area/install

Installing, updating, building from your game

  

area/menu

In-game menu and settings

  

area/renderer

Vulkan renderer, shaders, effects

  

area/saves

Save files

  

area/tooling

Developer tools: scripts, CI, build and release tooling

  

area/upscaling

DLSS, FSR, frame generation

  

ci: approved

A maintainer approved CircleCI for this fork PR (sticky; removed after 14 quiet days)

  

good first issue

A good start for a new contributor

  

gpu/amd

AMD GPUs

  

gpu/igpu

Integrated GPUs

  

gpu/intel

Intel GPUs

  

gpu/nvidia

NVIDIA GPUs

  

help wanted

Extra hands or knowledge wanted

  

kind

bug

Something doesn't work as it should

  

kind

chore

Build, CI, dependencies, tidying

  

kind

docs

Documentation

  

kind

feature

A new feature or an improvement

  

kind

performance

Frame rate, frame time, loading, memory

  

kind

question

A question rather than a change

  

needs measurements

Waiting for before/after measurements

  

platform/linux

Affects Linux (a change for every system carries both Windows and Linux)

  

platform/macos

macOS (Apple silicon or Intel Macs)

  

platform/steam-deck

Steam Deck

  

platform/windows

Affects Windows (a change for every system carries both Windows and Linux)

  

preview

Maintainers: deploy a preview of this PR's website (read its changes first). Removed after the run.

  

priority

critical

Crashes, data loss, or blocks most players

  

priority

high

Important: next in line

  

priority

low

Nice to have

  

regression

Worked in an earlier build, broken in a newer one: highest priority, above other bugs

  

risk

high

Broad or core change: the renderer, defaults on many systems, saves, installs, security

  

risk

low

Small, contained change: little can break

  

risk

medium

Changes behaviour in one area, or a default on some systems

  

status

blocked

Waits on something else first

  

status

confirmed

Reproduced or agreed on

  

status

duplicate

Already reported or proposed

  

status

invalid

Not a problem in this project

  

status

needs-info

Waiting for more information from the reporter

  

status

wontfix

Will not be worked on

  

testing wanted

Wanted: a test on other hardware (posts a test request in #test-requests)

  

ci: approved

No labels

area/accessibility

area/audio

area/input

area/install

area/menu

area/renderer

area/saves

area/tooling

area/upscaling

ci: approved

good first issue

gpu/amd

gpu/igpu

gpu/intel

gpu/nvidia

help wanted

kind

bug

kind

chore

kind

docs

kind

feature

kind

performance

kind

question

needs measurements

platform/linux

platform/macos

platform/steam-deck

platform/windows

preview

priority

critical

priority

high

priority

low

regression

risk

high

risk

low

risk

medium

status

blocked

status

confirmed

status

duplicate

status

invalid

status

needs-info

status

wontfix

testing wanted

ci: approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/Longshot!905

No description provided.