ci: the release and deploy jobs run only on the server's runner, their secrets sealed with a key only it has #2123
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!2123
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:ci/sealed-deploy-secrets"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
A runner reports its own labels, so a label only routes a job, it doesn't keep anyone out. Until now a runner lent by someone else (one is registered now, with
ubuntu-latestandubuntu-24.04) could:quickto its config and take the release's Sign and publish job, which holdsRELEASE_SIGNING_KEY;ubuntu-latestas it is today, which holdsCLOUDFLARE_API_TOKENandPREVIEW_COMMENT_TOKEN.This change:
deployfor the jobs that sign, publish or deploy:release.yml's version and publish, andwebsite.yml's job. Only the server's quick runner carries it (MagicBeanDev/Infra,runner/quick/config.yml).RELEASE_SIGNING_KEY_SEALED,CLOUDFLARE_API_TOKEN_SEALEDandPREVIEW_COMMENT_TOKEN_SEALED, sealed by the newscripts/ci_secret.sh(AES-256, PBKDF2). The key that opens them,seal.key, is a file on the server. Only the quick runner lets a job mount it (container.valid_volumes), and onlydeployjobs mount it. A runner without it that takes such a job gets text it can't open, so the job fails and signs or deploys nothing. A fork's run can mount the file but gets no secrets to open.docs/dev/reference/ci.mdgets a new section, Secrets only our runners can open, covering the runners table, the secrets and what sealing doesn't cover.releases.mdgets the new secret name in signing, rotation, setup and troubleshooting.Read first:
scripts/ci_secret.sh, then the publish job inrelease.ymland the website job's steps.The launcher reads the same organization secret, and LongshotLauncher #241 makes the same change there. The old secrets can be deleted only once both PRs are merged.
Testing
Tested: on the server, 2026-11-21. A one-off job on a temporary branch (deleted since) asked for
runs-on: deploywith this PR's container and volume lines. It ran onunraid-quick-1(runner 3), mounted/run/magicbean-secrets/seal.keythroughvalid_volumes, and sealed the three secrets with the sameopensslsettings asscripts/ci_secret.shin thecatthehacker/ubuntu:act-24.04image. Each opened again byte for byte. Those sealed values are the_SEALEDorganization secrets, now set; the plain ones in Longshot, the launcher and the organization are deleted. CI's Python checks, dispatched on this branch: results below when they finish. Website build and checks and Guide screenshots fail onmain(971f77f5) the same way:graphics-settings.tsand the guide's review hashes, not this change.Still to test:
feat:/fix:merge signs onunraid-quick-1and passesverify(by hand, in the run's log).Measurements
Nothing to measure: CI workflows and docs only, nothing the game runs.
Risks
scripts/ci_secret.sh, so its preview fails until it is rebased. Its comment step falls back to the job token.Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named). (not run on this PC; CI runs it)main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
Assisted-by:/Co-Authored-By:trailers.Ready to merge
main, measured again or a comment says why the numbers still hold.🤖 Generated with Claude Code
WIP: ci: the release and deploy jobs run only on the server's runner, their secrets sealed with a key only it hasto ci: the release and deploy jobs run only on the server's runner, their secrets sealed with a key only it has