fix(vk): the compute fallback's records area holds the floor grass at 4x #2121

Merged
HumanBean merged 2 commits from Jiro113/Longshot:fix/fallback-white-grass into main 2026-11-21 22:36:37 +00:00
Contributor

Summary

On the compute fallback of mesh shaders (RADV, so the Steam Deck and RX 6000-9000 on Linux; RX 6000 on Windows), the
floor grass at #1877's Grass distance 4x is drawn with white blades. The fallback's mesh programs take their records from
one fixed area of 16M words, so a program fits 16M / its record's words. The grass draws through two programs on the
same workgroups: its blades' records are 22 words (fit 762600), its partner's 7 words (fit 2.4M). At 4x both draw ~1.02M
records a frame: the partner's all fit, the blades' past 762600 are dropped (MeshFallbackEpilogue drops a workgroup that
doesn't fit, silently). The white is where the partner drew and the blades did not: that link is inferred, the counts and
the white are measured.

The area is now 32M words (128 MB), which fits 1.52M records of 22 words, above the ~1.29M #1877's blade cap lets
through (extrapolated from the measured load, not measured). fallback_buffers_of refused a records buffer past 128 MB, which every layout now passes (the plain one by its
32-byte header, the one with the attribute pool, Intel Mesa's default, at ~160 MB): the limit is a named constant,
MESH_FALLBACK_RECORDS_LIMIT (192 MB), with a static_assert that the largest layout fits it and one that a word's byte
offset still fits BufferWordAt's 32 bits.

On main alone the bug doesn't show: on 9dd41326e at the game's load, of the mesh programs with a draw-stats line (39
of 49), none goes past a quarter of its fit at Hyrule Field, Kokiri or Kakariko; on 971f77f52 with #1382's own Grass
distance 4x (merged as d2f0e8dc4), the most is 38 % (Kokiri's short blades, 43ec86f35fd937b9) and there is no white. It
shows with #1877 (on #1382), which this unblocks on the fallback. It doesn't explain #1710, #1934, #1799 or #1760
(white or flickering foliage on AMD and the Deck at the game's own Grass distance), and doesn't claim them.

To see it: #1877 on main, RX_VK_FORCE_MESH_FALLBACK=1 RX_VK_GRASS_DISTANCE=4, Hyrule Field: white blades across the
field, moving from frame to frame.

Read first: gpu/vk/eden/shader_recompiler/backend/spirv/emit_spirv.h (MESH_FALLBACK_RECORD_WORDS,
MESH_FALLBACK_RECORDS_LIMIT), gpu/vk/vk_draw.cpp fallback_buffers_of, then tests/mesh_fallback_capacity_test.cpp.

See #1877. Touches the same constants as #1561 (packed record layout, #1477 BC-1a): whichever merges second rebases on the
other's fit.

Testing

Tested: Windows 11, RTX 4090, NVIDIA 621.24, the fallback forced (RX_VK_FORCE_MESH_FALLBACK=1) and native, from
the same Hyrule Field save, standing still, 6 screenshots and the RX_VK_DRAW_STATS vertex counts per run:

  • with #1877 at 4x on the fallback, the white blades are gone, and the blades' program draws as many records as its
    partner in every frame (1.00-1.02M, 67 % of the new fit at most);
  • this PR alone (no #1877), fallback and native, at Hyrule Field, Kokiri and Kakariko: the picture is as on main;
  • the above at f6058b234 on main 9dd41326e; rebased since onto 971f77f52 without a conflict (main's changes
    don't touch the records area or fallback_buffers_of's limit);
  • at 2194d263b on 971f77f52 against main 971f77f52, the fallback forced, main's own Grass distance 4x (#1382): the
    field save and Kokiri Forest twice a side, the field save at the game's load once a side. No white either side
    (near-white 0.00-0.12 %), the same counts for every grass program (739a ~169k at Hyrule Field, 43ec ~290k at
    Kokiri), no vk: fallback refusal; other buffers 217-219 MB on main, 271-281 MB here;
  • the game-free check test_mesh_fallback_capacity fails on main (the 22-word program draws 762336 of 1023009
    records) and passes here; test_mesh_fallback_global_attrs, test_fallback_buffer_cleanup,
    test_mesh_fallback_shared_warp and the mesh_fallback_layout model (62 cases) pass.

run_all.py on this PC: 771 passed, 96 failed here; 770 passed, 96 failed on main 9dd41326e. 95 of the failing checks
fail on both, the same list on main (cause not looked into for each: among them test_mesh_conv stops on a
-Wunused-const-variable in mesh_conv_real_test.cpp under llvm-mingw, and source-reading checks that no longer match
main); test_longshot_ctl failed here only and test_work_lock on
main only, and both pass when run again alone on this branch.

The whole suite above ran at f6058b234 on 9dd41326e. At the head, 167aa2de3 on main 8aa749834 (rebased from
2194d263b; of main's four newer commits only #2103 touches the fallback, its stages' global loads through the guest
page table, not their outputs, which make the records, nor the records area or fallback_buffers_of, so the in-game
runs above at 2194d263b hold; not run in the game at the head): run_all.py --strict --changed (the checks that read
a file this PR changes) on Windows: 148 passed, 19 failed, 5 skipped (at 2194d263b: 147, 19, 5, the same failures).
14 of the failures are in the list below; the other 5 (test_device_policy, test_framegen_preset,
test_intel_prepare_side_by_side, test_prepare_stall, test_rumble_menu) came with main's newer commits and fail
on main 971f77f52 and 8aa749834 too (grass_distance_now undeclared in the menu cut-outs, IntelPrepareLane
unknown, acquire_ahead on RADV). The mesh_fallback_layout model (62 cases, built with llvm-mingw's clang) passes
at the head. Linux, at the head (Ubuntu 22.04 in WSL, g++ 13.4, Python 3.10): test_mesh_fallback_capacity (its 6
cases), test_fallback_buffer_cleanup, test_mesh_fallback_global_attrs, test_mesh_fallback_shared_warp and
test_grass_distance pass; test_mesh_fallback_layout skipped there (no SPIR-V headers or spirv-val in that
install). CI runs only the light checks on a pull request (the suite is Actions > CI > Run workflow), so it doesn't
check this.

Failing on both main and this PR on this PC

test_appimage_player_build test_auto_handheld test_bug_report test_bug_report_defaults test_capture_read_once
test_capture_readback_visibility test_compile_retry_jobs test_compile_stops_on_exception test_crash_dialog
test_crash_record test_crt_options test_damage_debug_menu test_dev_ab test_dev_build test_dev_migrate test_dev_packs
test_device_lost_exit test_display_startup_failure test_dlss_feature_size test_draw_binds test_draw_stream_visibility
test_failed_compile_keeps_objects test_fastfp_fma test_flush_nothing_held test_fma_soft test_fpx_sticky test_fpxkeep
test_frame_overlap test_fsr3fi_hud_layer test_fsr3fi_hudless_colour test_fsr_image_retirement test_fsr_uniform_ownership
test_game_menu_mouse_buttons test_gpu_wait_stats test_guest_imported test_high_fps_fixes test_host_guest_writes
test_input_background test_job_queue test_libc_hooks test_lift_cache test_lift_cleanup_error test_linux_preflight
test_linux_pressure test_low_vram_texture_mips test_make_game_ngx test_menu_i18n test_menu_keys test_menu_text_field
test_mesh_conv test_mise_build test_missing_nup test_mods_list test_ngx_sdk test_oot_shadow_fit test_pads_after_menu
test_pass_barrier test_pending_guest_import test_perf_report test_pipeline_play_cache test_portable_builder_home
test_portable_builder_startup test_prepare_cache_save test_present_queue_default test_present_source_crop
test_profiling_mode test_psychov35_fsr3_fg test_readback_timeout_source test_recorder_own_idle test_recorder_sync
test_recording_admission test_reflex_swapchain_lifetime test_renderer_new_handler test_renhdrum test_replay_write_order
test_run_all_mingw test_run_all_output test_sampler_admission test_sdiv_overflow test_slow_frames test_song_note_cue
test_sparse_mirror test_spawn_emit test_staging_burst test_target_reuse_memory test_texel_buffer_ownership
test_ub_update_batch test_ui_record test_upscaler_rows test_vbytes test_vcore_escape test_vcore_mask0 test_vecfp
test_vfpx_elem test_vk_occlusion_queries

Still to test:

  • Steam Deck (RADV, the fallback by default), at the game's load at Hyrule Field and Kokiri: no vk: fallback
    refusal in the log, the picture and fps as on main, vk: budget other buffers ~54-74 MB higher (Test Farm, Steam
    Deck: Hyrule Field and Kokiri Forest against main, fps, video memory, no fallback refusal in the log)
  • Linux, RX 6000-9000 on RADV: the same (Test Farm, RX 6000-9000 on Linux: Hyrule Field and Kokiri Forest against
    main, fps, video memory, no fallback refusal in the log)
  • The Deck with #1877 at 4x, once #1877 is on top of this: no white blades at Hyrule Field (on #1877, by hand or
    on the Test Farm there)
  • Intel Arc on Mesa (the attribute pool on, the ~160 MB records buffer): the fallback still used, no vk: fallback
    refusal (by hand, someone with the hardware)

Measurements

Verdict: the white blades are gone: near-white pixels 4.33-7.99 % of the frame with #1877 at 4x on the fallback,
0.03-0.12 % with this PR, as native (0.01-0.09 %); at the game's load nothing changes. Cost: +54 to +74 MB of video memory on
the fallback only.

Setup: Windows 11, RTX 4090, NVIDIA 621.24; the Hyrule Field save, standing still, fallback forced with
RX_VK_FORCE_MESH_FALLBACK=1; 6 screenshots a run, the share of near-white pixels and the change between frames;
RX_VK_DRAW_STATS vertex counts of the two grass programs over 5 frames; video memory from the vk: budget line.

Commits: on current main, main 971f77f52 against this PR at 2194d263b (first table); before the rebase, main
9dd41326e against this PR at f6058b234 (second table). Baseline for the #1877 rows: main 9dd41326e with #1877 at
defe02170 against this PR with the same #1877; the bug needs #1877 to show.

main's own Grass distance 4x (#1382), the fallback forced; the most a program draws of its fit, over 5 frames a run:

Before: main @ 971f77f52 After: this PR @ 2194d263b
Hyrule Field (the save), 4x: near-white % (2 runs a side) 0.01-0.12 0.01-0.10
Hyrule Field, 4x: change between frames % 2.9-4.5 3.3-4.6
Hyrule Field, 4x: 739a records a frame / share of fit 169k / 22.2 % 169k / 11.1 %
Kokiri Forest, 4x: near-white % (2 runs a side) 0.00-0.05 0.00-0.05
Kokiri Forest, 4x: 43ec records a frame / share of fit 290k / 38.1 % 290k / 19.0 %
Hyrule Field (the save), game's load: near-white % 0.05-0.12 0.00-0.09
Video memory, other buffers (MB): Hyrule Field / Kokiri 217 / 219 271-281 / 273

Before the rebase, the #1877 rows with #1877 on top:

Before: main @ 9dd41326e After: this PR @ f6058b234
#1877 4x, fallback: near-white % (1 run before, 2 after) 4.33-7.99 0.03-0.12
#1877 4x, fallback: blades' records / partner's a frame 762528 / 1.00-1.02M equal, 1.00-1.02M
#1877 4x, native: near-white % not run 0.01-0.09
Hyrule Field, fallback: near-white % / change between frames % 0.01-0.09 / 3.7-4.1 0.01-0.09 / 3.8-4.9
Kakariko, fallback 0.07-0.11 / 2.6-3.1 0.07-0.10 / 3.0-3.3
Kokiri, fallback (*) 0 / 0 0 / 0
Hyrule Field, native 0.04-0.11 / 4.4-5.0 0.05-0.11 / 3.9-4.5
Kakariko, native 0.08-0.10 / 3.3-3.9 0.07-0.08 / 2.8-3.1
Kokiri, native 0.00-0.05 / 0.1-0.5 0.01-0.05 / 0.2-0.6
Video memory, other buffers (MB), fallback: Hyrule Field / Kakariko / Kokiri / #1877 4x 207 / 209 / 209 / 252 271 / 273 / 283 / 316
Video memory, other buffers (MB), native: Hyrule Field / Kakariko 146 / 148 146 / 148
RX_VK_DRAW_STATS, #1877 4x, fallback, before (16M words):
  739acd678ae08655 words 22 fit 762600   vs/frame capped at 762528
  a6a688bae3c9b80c words 7  fit 2396745  vs/frame 1002492 .. 1023009
after (32M words), fix1877-fb:
  739acd678ae08655 words 22 fit 1525201  vs/frame [1003494, 1023981, 1003767, 1003881, 1004004]  max 67.1 % of fit
  a6a688bae3c9b80c words 7 fit 4793490  vs/frame [1003494, 1023981, 1003767, 1003881, 1004004]  max 21.4 % of fit
fix1877-fb2:
  739acd678ae08655 words 22 fit 1525201  vs/frame [1005060, 1004901, 1005243, 1005387, 1005426]  max 65.9 % of fit
  a6a688bae3c9b80c words 7 fit 4793490  vs/frame [1005060, 1004901, 1005243, 1005387, 1005426]  max 21.0 % of fit

(*) The scene and its grass are drawn, without white; the six frames of a run were identical on both sides (a still
picture on the fallback here, as on main: not looked into).

Frame rate not measured: per frame only the records' header is cleared, whatever the area's size; an fps A/B on the
fallback is still to run.

Risks

  • Video memory: +64 MB per recording thread that uses the fallback (inferred from the code; measured +54 to +74 MB
    in all above, so one thread here), nothing on the
    native path. On the Steam Deck's shared memory and 4 GB cards on the fallback that is the main cost; to be checked on
    the Deck (Still to test).
  • A buffer refused: if a driver refuses a 128-160 MB storage buffer, every program's fallback is left off, as when
    fallback_buffers_of refuses one today. Measured only on NVIDIA.
  • Still cut: a program with records over 26 words still fits fewer than #1877's ~1.29M cap; none draws near that
    today (the widest, 28 words, ~13.5k a frame). The overflow stays silent: a one-time log line when a workgroup is
    dropped would make the next case visible (a follow-up).
  • Off: a revert. Nothing changes for a player's saves, longshot_options.ini or caches.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named). (its command, run_all.py --strict: the whole
    suite at f6058b234 on main 9dd41326e, --changed at the head, as Testing says; every failure here also fails on
    main, named there)
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A fix: a game-free test that fails on main and passes here.
  • A check under tests/ that reads changed source is updated, not weakened.
  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Windows: the game built; Linux: the
    changed code compiled with g++ 13 in the new check, as Testing says)
  • Screenshots of the same spot on main and here, for a change that shows on screen. (in a comment: #1877 at 4x on
    the fallback, before and after)
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.

🤖 Generated with Claude Code

## Summary On the compute fallback of mesh shaders (RADV, so the Steam Deck and RX 6000-9000 on Linux; RX 6000 on Windows), the floor grass at #1877's Grass distance 4x is drawn with white blades. The fallback's mesh programs take their records from one fixed area of 16M words, so a program fits 16M / its record's words. The grass draws through two programs on the same workgroups: its blades' records are 22 words (fit 762600), its partner's 7 words (fit 2.4M). At 4x both draw ~1.02M records a frame: the partner's all fit, the blades' past 762600 are dropped (MeshFallbackEpilogue drops a workgroup that doesn't fit, silently). The white is where the partner drew and the blades did not: that link is inferred, the counts and the white are measured. The area is now 32M words (128 MB), which fits 1.52M records of 22 words, above the ~1.29M #1877's blade cap lets through (extrapolated from the measured load, not measured). `fallback_buffers_of` refused a records buffer past 128 MB, which every layout now passes (the plain one by its 32-byte header, the one with the attribute pool, Intel Mesa's default, at ~160 MB): the limit is a named constant, `MESH_FALLBACK_RECORDS_LIMIT` (192 MB), with a static_assert that the largest layout fits it and one that a word's byte offset still fits BufferWordAt's 32 bits. On `main` alone the bug doesn't show: on 9dd41326e at the game's load, of the mesh programs with a draw-stats line (39 of 49), none goes past a quarter of its fit at Hyrule Field, Kokiri or Kakariko; on 971f77f52 with #1382's own Grass distance 4x (merged as d2f0e8dc4), the most is 38 % (Kokiri's short blades, 43ec86f35fd937b9) and there is no white. It shows with #1877 (on #1382), which this unblocks on the fallback. It doesn't explain #1710, #1934, #1799 or #1760 (white or flickering foliage on AMD and the Deck at the game's own Grass distance), and doesn't claim them. To see it: #1877 on `main`, `RX_VK_FORCE_MESH_FALLBACK=1 RX_VK_GRASS_DISTANCE=4`, Hyrule Field: white blades across the field, moving from frame to frame. Read first: `gpu/vk/eden/shader_recompiler/backend/spirv/emit_spirv.h` (`MESH_FALLBACK_RECORD_WORDS`, `MESH_FALLBACK_RECORDS_LIMIT`), `gpu/vk/vk_draw.cpp` `fallback_buffers_of`, then `tests/mesh_fallback_capacity_test.cpp`. See #1877. Touches the same constants as #1561 (packed record layout, #1477 BC-1a): whichever merges second rebases on the other's fit. ## Testing **Tested:** Windows 11, RTX 4090, NVIDIA 621.24, the fallback forced (`RX_VK_FORCE_MESH_FALLBACK=1`) and native, from the same Hyrule Field save, standing still, 6 screenshots and the `RX_VK_DRAW_STATS` vertex counts per run: - with #1877 at 4x on the fallback, the white blades are gone, and the blades' program draws as many records as its partner in every frame (1.00-1.02M, 67 % of the new fit at most); - this PR alone (no #1877), fallback and native, at Hyrule Field, Kokiri and Kakariko: the picture is as on `main`; - the above at f6058b234 on `main` 9dd41326e; rebased since onto 971f77f52 without a conflict (`main`'s changes don't touch the records area or `fallback_buffers_of`'s limit); - at 2194d263b on 971f77f52 against `main` 971f77f52, the fallback forced, `main`'s own Grass distance 4x (#1382): the field save and Kokiri Forest twice a side, the field save at the game's load once a side. No white either side (near-white 0.00-0.12 %), the same counts for every grass program (739a ~169k at Hyrule Field, 43ec ~290k at Kokiri), no `vk: fallback` refusal; other buffers 217-219 MB on `main`, 271-281 MB here; - the game-free check `test_mesh_fallback_capacity` fails on `main` (the 22-word program draws 762336 of 1023009 records) and passes here; `test_mesh_fallback_global_attrs`, `test_fallback_buffer_cleanup`, `test_mesh_fallback_shared_warp` and the `mesh_fallback_layout` model (62 cases) pass. `run_all.py` on this PC: 771 passed, 96 failed here; 770 passed, 96 failed on `main` 9dd41326e. 95 of the failing checks fail on both, the same list on `main` (cause not looked into for each: among them `test_mesh_conv` stops on a `-Wunused-const-variable` in `mesh_conv_real_test.cpp` under llvm-mingw, and source-reading checks that no longer match `main`); `test_longshot_ctl` failed here only and `test_work_lock` on `main` only, and both pass when run again alone on this branch. The whole suite above ran at f6058b234 on 9dd41326e. At the head, 167aa2de3 on `main` 8aa749834 (rebased from 2194d263b; of `main`'s four newer commits only #2103 touches the fallback, its stages' global loads through the guest page table, not their outputs, which make the records, nor the records area or `fallback_buffers_of`, so the in-game runs above at 2194d263b hold; not run in the game at the head): `run_all.py --strict --changed` (the checks that read a file this PR changes) on Windows: 148 passed, 19 failed, 5 skipped (at 2194d263b: 147, 19, 5, the same failures). 14 of the failures are in the list below; the other 5 (`test_device_policy`, `test_framegen_preset`, `test_intel_prepare_side_by_side`, `test_prepare_stall`, `test_rumble_menu`) came with `main`'s newer commits and fail on `main` 971f77f52 and 8aa749834 too (`grass_distance_now` undeclared in the menu cut-outs, `IntelPrepareLane` unknown, `acquire_ahead` on RADV). The `mesh_fallback_layout` model (62 cases, built with llvm-mingw's clang) passes at the head. Linux, at the head (Ubuntu 22.04 in WSL, g++ 13.4, Python 3.10): `test_mesh_fallback_capacity` (its 6 cases), `test_fallback_buffer_cleanup`, `test_mesh_fallback_global_attrs`, `test_mesh_fallback_shared_warp` and `test_grass_distance` pass; `test_mesh_fallback_layout` skipped there (no SPIR-V headers or spirv-val in that install). CI runs only the light checks on a pull request (the suite is Actions > CI > Run workflow), so it doesn't check this. <details><summary>Failing on both main and this PR on this PC</summary> test_appimage_player_build test_auto_handheld test_bug_report test_bug_report_defaults test_capture_read_once test_capture_readback_visibility test_compile_retry_jobs test_compile_stops_on_exception test_crash_dialog test_crash_record test_crt_options test_damage_debug_menu test_dev_ab test_dev_build test_dev_migrate test_dev_packs test_device_lost_exit test_display_startup_failure test_dlss_feature_size test_draw_binds test_draw_stream_visibility test_failed_compile_keeps_objects test_fastfp_fma test_flush_nothing_held test_fma_soft test_fpx_sticky test_fpxkeep test_frame_overlap test_fsr3fi_hud_layer test_fsr3fi_hudless_colour test_fsr_image_retirement test_fsr_uniform_ownership test_game_menu_mouse_buttons test_gpu_wait_stats test_guest_imported test_high_fps_fixes test_host_guest_writes test_input_background test_job_queue test_libc_hooks test_lift_cache test_lift_cleanup_error test_linux_preflight test_linux_pressure test_low_vram_texture_mips test_make_game_ngx test_menu_i18n test_menu_keys test_menu_text_field test_mesh_conv test_mise_build test_missing_nup test_mods_list test_ngx_sdk test_oot_shadow_fit test_pads_after_menu test_pass_barrier test_pending_guest_import test_perf_report test_pipeline_play_cache test_portable_builder_home test_portable_builder_startup test_prepare_cache_save test_present_queue_default test_present_source_crop test_profiling_mode test_psychov35_fsr3_fg test_readback_timeout_source test_recorder_own_idle test_recorder_sync test_recording_admission test_reflex_swapchain_lifetime test_renderer_new_handler test_renhdrum test_replay_write_order test_run_all_mingw test_run_all_output test_sampler_admission test_sdiv_overflow test_slow_frames test_song_note_cue test_sparse_mirror test_spawn_emit test_staging_burst test_target_reuse_memory test_texel_buffer_ownership test_ub_update_batch test_ui_record test_upscaler_rows test_vbytes test_vcore_escape test_vcore_mask0 test_vecfp test_vfpx_elem test_vk_occlusion_queries </details> **Still to test:** - Steam Deck (RADV, the fallback by default), at the game's load at Hyrule Field and Kokiri: no `vk: fallback` refusal in the log, the picture and fps as on `main`, `vk: budget` other buffers ~54-74 MB higher (Test Farm, Steam Deck: Hyrule Field and Kokiri Forest against main, fps, video memory, no fallback refusal in the log) - Linux, RX 6000-9000 on RADV: the same (Test Farm, RX 6000-9000 on Linux: Hyrule Field and Kokiri Forest against main, fps, video memory, no fallback refusal in the log) - The Deck with #1877 at 4x, once #1877 is on top of this: no white blades at Hyrule Field (on #1877, by hand or on the Test Farm there) - Intel Arc on Mesa (the attribute pool on, the ~160 MB records buffer): the fallback still used, no `vk: fallback` refusal (by hand, someone with the hardware) ## Measurements **Verdict:** the white blades are gone: near-white pixels 4.33-7.99 % of the frame with #1877 at 4x on the fallback, 0.03-0.12 % with this PR, as native (0.01-0.09 %); at the game's load nothing changes. Cost: +54 to +74 MB of video memory on the fallback only. Setup: Windows 11, RTX 4090, NVIDIA 621.24; the Hyrule Field save, standing still, fallback forced with `RX_VK_FORCE_MESH_FALLBACK=1`; 6 screenshots a run, the share of near-white pixels and the change between frames; `RX_VK_DRAW_STATS` vertex counts of the two grass programs over 5 frames; video memory from the `vk: budget` line. Commits: on current `main`, `main` 971f77f52 against this PR at 2194d263b (first table); before the rebase, `main` 9dd41326e against this PR at f6058b234 (second table). Baseline for the #1877 rows: `main` 9dd41326e with #1877 at defe02170 against this PR with the same #1877; the bug needs #1877 to show. `main`'s own Grass distance 4x (#1382), the fallback forced; the most a program draws of its fit, over 5 frames a run: | | Before: main @ 971f77f52 | After: this PR @ 2194d263b | |---|---|---| | Hyrule Field (the save), 4x: near-white % (2 runs a side) | 0.01-0.12 | 0.01-0.10 | | Hyrule Field, 4x: change between frames % | 2.9-4.5 | 3.3-4.6 | | Hyrule Field, 4x: 739a records a frame / share of fit | 169k / 22.2 % | 169k / 11.1 % | | Kokiri Forest, 4x: near-white % (2 runs a side) | 0.00-0.05 | 0.00-0.05 | | Kokiri Forest, 4x: 43ec records a frame / share of fit | 290k / 38.1 % | 290k / 19.0 % | | Hyrule Field (the save), game's load: near-white % | 0.05-0.12 | 0.00-0.09 | | Video memory, other buffers (MB): Hyrule Field / Kokiri | 217 / 219 | 271-281 / 273 | Before the rebase, the #1877 rows with #1877 on top: | | Before: main @ 9dd41326e | After: this PR @ f6058b234 | |---|---|---| | #1877 4x, fallback: near-white % (1 run before, 2 after) | 4.33-7.99 | 0.03-0.12 | | #1877 4x, fallback: blades' records / partner's a frame | 762528 / 1.00-1.02M | equal, 1.00-1.02M | | #1877 4x, native: near-white % | not run | 0.01-0.09 | | Hyrule Field, fallback: near-white % / change between frames % | 0.01-0.09 / 3.7-4.1 | 0.01-0.09 / 3.8-4.9 | | Kakariko, fallback | 0.07-0.11 / 2.6-3.1 | 0.07-0.10 / 3.0-3.3 | | Kokiri, fallback (*) | 0 / 0 | 0 / 0 | | Hyrule Field, native | 0.04-0.11 / 4.4-5.0 | 0.05-0.11 / 3.9-4.5 | | Kakariko, native | 0.08-0.10 / 3.3-3.9 | 0.07-0.08 / 2.8-3.1 | | Kokiri, native | 0.00-0.05 / 0.1-0.5 | 0.01-0.05 / 0.2-0.6 | | Video memory, other buffers (MB), fallback: Hyrule Field / Kakariko / Kokiri / #1877 4x | 207 / 209 / 209 / 252 | 271 / 273 / 283 / 316 | | Video memory, other buffers (MB), native: Hyrule Field / Kakariko | 146 / 148 | 146 / 148 | ``` RX_VK_DRAW_STATS, #1877 4x, fallback, before (16M words): 739acd678ae08655 words 22 fit 762600 vs/frame capped at 762528 a6a688bae3c9b80c words 7 fit 2396745 vs/frame 1002492 .. 1023009 after (32M words), fix1877-fb: 739acd678ae08655 words 22 fit 1525201 vs/frame [1003494, 1023981, 1003767, 1003881, 1004004] max 67.1 % of fit a6a688bae3c9b80c words 7 fit 4793490 vs/frame [1003494, 1023981, 1003767, 1003881, 1004004] max 21.4 % of fit fix1877-fb2: 739acd678ae08655 words 22 fit 1525201 vs/frame [1005060, 1004901, 1005243, 1005387, 1005426] max 65.9 % of fit a6a688bae3c9b80c words 7 fit 4793490 vs/frame [1005060, 1004901, 1005243, 1005387, 1005426] max 21.0 % of fit ``` (*) The scene and its grass are drawn, without white; the six frames of a run were identical on both sides (a still picture on the fallback here, as on `main`: not looked into). Frame rate not measured: per frame only the records' header is cleared, whatever the area's size; an fps A/B on the fallback is still to run. ## Risks - **Video memory:** +64 MB per recording thread that uses the fallback (inferred from the code; measured +54 to +74 MB in all above, so one thread here), nothing on the native path. On the Steam Deck's shared memory and 4 GB cards on the fallback that is the main cost; to be checked on the Deck (Still to test). - **A buffer refused:** if a driver refuses a 128-160 MB storage buffer, every program's fallback is left off, as when `fallback_buffers_of` refuses one today. Measured only on NVIDIA. - **Still cut:** a program with records over 26 words still fits fewer than #1877's ~1.29M cap; none draws near that today (the widest, 28 words, ~13.5k a frame). The overflow stays silent: a one-time log line when a workgroup is dropped would make the next case visible (a follow-up). - Off: a revert. Nothing changes for a player's saves, `longshot_options.ini` or caches. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [x] `mise run test` passes (any failure that also fails on `main` is named). (its command, `run_all.py --strict`: the whole suite at f6058b234 on `main` 9dd41326e, `--changed` at the head, as Testing says; every failure here also fails on `main`, named there) - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] A fix: a game-free test that fails on `main` and passes here. - [x] A check under `tests/` that reads changed source is updated, not weakened. - [x] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Windows: the game built; Linux: the changed code compiled with g++ 13 in the new check, as Testing says) - [x] Screenshots of the same spot on `main` and here, for a change that shows on screen. (in a comment: #1877 at 4x on the fallback, before and after) - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
A game-free check, failing on main: every mesh program on the compute fallback takes its records from one fixed area, so the
grass's blades (records of 22 words, 739acd678ae08655) fit 762600 where their partner program (7 words, a6a688bae3c9b80c)
fits 2.4M. With the Grass distance at 4x (#1877) the partner draws ~1.02M records a frame and the blades are cut at 762528:
the blades left out are drawn white. The check gives both programs the same workgroups at that load and at the load
#1877's caps let through (~1.29M, extrapolated), with emit_spirv.h's real MeshFallbackFit, and wants the same records drawn.
It also calls vk_draw.cpp's real fallback_buffers_of with the attribute pool and the shared warp off and on: the records
buffer that area needs must be made, not refused.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
fix(vk): the compute fallback's records area holds the floor grass at 4x
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
2194d263b6
The fallback's mesh programs take their records from one fixed area of 16M words, so a program with records of 22 words fits
762600 of them. The floor grass at the Grass distance's 4x (#1877) draws ~1.02M records a frame in both its programs: its
partner's (7 words) all fit, its blades' did not, and the blades left out were drawn white. The area is now 32M words
(128 MB), 1.52M records of 22 words.

fallback_buffers_of refused a records buffer past 128 MB, and every layout now passes it: the plain buffer by its 32-byte
header (128 MB + 32 bytes), with the attribute pool (mma_layout.h mesh_fallback_global_attributes, on by default on Intel's
Mesa driver) ~160 MB. The limit is a named constant in emit_spirv.h, 192 MB, with a static_assert that the largest layout
fits, and another that a word's byte offset still fits the 32 bits BufferWordAt makes it in. +64 MB of video memory a
recording thread that uses the fallback.

tests/mesh_fallback_layout_model.cpp's "past the area" cases drew 2400 meshlets, past the old area only: they now draw a
fifth more than the area holds, whatever its size.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

Tested in game: Windows 11, RTX 4090, NVIDIA 621.24, fallback forced (RX_VK_FORCE_MESH_FALLBACK=1) and native, from a Hyrule Field save and at Kokiri and Kakariko, at f6058b234 on main 9dd41326e (rebased since onto 971f77f52 without a conflict). With #1877 at Grass distance 4x on the fallback the white blades are gone (near-white 4.33-7.99 % -> 0.03-0.12 % of the frame) and the blades' program draws as many records as its partner every frame. Without #1877 the picture is as on main on both paths. Other buffers +64 MB on the fallback, unchanged native.

Tested in game: Windows 11, RTX 4090, NVIDIA 621.24, fallback forced (RX_VK_FORCE_MESH_FALLBACK=1) and native, from a Hyrule Field save and at Kokiri and Kakariko, at f6058b234 on main 9dd41326e (rebased since onto 971f77f52 without a conflict). With #1877 at Grass distance 4x on the fallback the white blades are gone (near-white 4.33-7.99 % -> 0.03-0.12 % of the frame) and the blades' program draws as many records as its partner every frame. Without #1877 the picture is as on main on both paths. Other buffers +64 MB on the fallback, unchanged native.
Author
Contributor

Screenshots, the same spot (the Hyrule Field save, standing still), #1877 at Grass distance 4x, the fallback forced (RX_VK_FORCE_MESH_FALLBACK=1), RTX 4090, NVIDIA 621.24:

Before, main 9dd41326e with #1877 (near-white 4.3-8.0 % of the frame):

before: white blades

After, this PR at f6058b234 with the same #1877 (0.03-0.12 %, as native):

after: green blades

(Taken before the rebase onto 971f77f52; the run on current main is in Still to test.)

Screenshots, the same spot (the Hyrule Field save, standing still), #1877 at Grass distance 4x, the fallback forced (`RX_VK_FORCE_MESH_FALLBACK=1`), RTX 4090, NVIDIA 621.24: Before, `main` 9dd41326e with #1877 (near-white 4.3-8.0 % of the frame): ![before: white blades](https://git.magicbean.dev/attachments/743cb2b0-8a1f-4e27-a8fe-d592baa89665) After, this PR at f6058b234 with the same #1877 (0.03-0.12 %, as native): ![after: green blades](https://git.magicbean.dev/attachments/0ee017ef-5add-472f-8863-04d3a76e7931) (Taken before the rebase onto 971f77f52; the run on current `main` is in Still to test.)
Jiro113 force-pushed fix/fallback-white-grass from 2194d263b6
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 167aa2de30
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 5s
2026-11-21 22:12:58 +00:00
Compare
Author
Contributor

Rebased onto main 8aa749834 (167aa2de3), no conflict. The in-game numbers at 2194d263b on 971f77f52 still hold: main's four newer commits (#2123 CI, #2125 NVIDIA's shader cache file, #2103 global loads in shaders, #2124 XInput thread) don't touch the fallback's records area, its programs' record sizes or fallback_buffers_of. At the head, run_all.py --strict --changed: 148 passed, 19 failed, the same 19 as before the rebase, all failing on main too (named in Testing); the fallback and Grass distance checks pass.

Rebased onto main 8aa749834 (167aa2de3), no conflict. The in-game numbers at 2194d263b on 971f77f52 still hold: main's four newer commits (#2123 CI, #2125 NVIDIA's shader cache file, #2103 global loads in shaders, #2124 XInput thread) don't touch the fallback's records area, its programs' record sizes or fallback_buffers_of. At the head, run_all.py --strict --changed: 148 passed, 19 failed, the same 19 as before the rebase, all failing on main too (named in Testing); the fallback and Grass distance checks pass.
Jiro113 changed title from WIP: fix(vk): the compute fallback's records area holds the floor grass at 4x to fix(vk): the compute fallback's records area holds the floor grass at 4x 2026-11-21 22:16:42 +00:00
Owner
@review
BeanBot left a comment

Recommendation: Approve. The forced-fallback run shows that the larger area removes the reported white grass with #1877, but the change increases fallback memory use for players who do not have that change. Its effects on the Steam Deck and RADV, and the first-start cost of invalidating shader caches, still need measurement. Nothing blocking is left: what remains is for the author before merging (below). Recommend approval; not approved on the forge.

Doubles the compute fallback's records area and raises its allocation limit so the larger buffer can be created. This fixes the observed capacity shortfall in the tested #1877 scene at a cost of 64 MiB per fallback recording thread and a shader-cache rebuild.

@fix will do (2)

  1. L1 (its part an edit can do) gpu/vk/eden/shader_recompiler/backend/spirv/emit_spirv.h:69: Allocate the larger area only when the workload requires it, or otherwise reduce the permanent per-thread allocation.
  2. L3 (minor): Risks says nothing changes for caches, but the changed emitter header changes the translator stamp, invalidating the program cache and prepare record. Describe the rebuild and its player-visible first-start cost.

Before merging, for the author (2) (a run, a measurement or a decision; it doesn't hold the recommendation)

  • L1 (minor) gpu/vk/eden/shader_recompiler/backend/spirv/emit_spirv.h:69: The larger allocation applies to every fallback recording thread, including at the game's normal grass load where the reported runs show no visual benefit. (more on the line)
  • L2 (minor) gpu/vk/eden/shader_recompiler/backend/spirv/emit_spirv.h:69: This header is included in the translator stamp, so changing the constant invalidates the program cache and prepare record even on native-mesh systems. (more on the line)

Checks: Still running: CI / Conventional Commit title (pull_request), CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request), CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request), CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request), CI / Workflow lint (actionlint) (pull_request), CI / Website build and checks (pull_request), Guide screenshots / Guide images and local UI source review (pull_request), Third-party parts / As their notes say (pull_request), Third-party parts / The same as upstream (pull_request), Website / Website on Cloudflare (pull_request).

More: does it help, other systems, switches, what was read

Does it help: Yes, for the tested setup: with #1877 at 4x on a forced NVIDIA fallback, near-white pixels fell from 4.33–7.99% to 0.03–0.12%, and the two grass programs drew matching record counts. The before side had one run, the after side two; the head and the affected AMD hardware have not been tested in game.

Other systems: The native path does not allocate the larger fallback buffer, but all players receive a new translator stamp and must rebuild affected caches. RADV and the Steam Deck use the fallback by default; Intel Mesa also uses the attribute pool, producing a roughly 160 MiB records buffer. Allocation, image and performance behavior on those systems remain untested.

Switches: None added, changed or removed.

Reviewed: 167aa2de30 against 8aa7498345: Read AGENTS.md, CONTRIBUTING.md, the PR template, standards, the commits and all seven changed-file diffs; read the new capacity test and harness, changed constants, allocation function, layout model and global-attributes check with their surrounding code. Traced shader emission, buffer reuse and the translator cache stamp. Skimmed the reported runs and related callers. docs/review-checklist.md and the adjacent Tooling checkout were absent; screenshots and generated files were not independently inspected.; nothing run (a code review).

Checked and fine:

  • The largest records-plus-pool layout and counters fit the new limit, and the record byte offset remains within 32 bits.
  • The new capacity check exercises the real fit calculation and allocation function, including pool and counter combinations.
  • Both commits have AI-assistance trailers; no switches, API version or generated shader headers changed.
  • The emitter header is included in the translator stamp, so old translated layouts are not silently reused.

Testing: Read-only review; no builds, tests or project scripts were run. The author's reported game and test results are described above. CI is still running.

Overlaps and merge order: #1561 touches the same constants; whichever change lands second needs to reconcile the record fit.


Automated code review by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

**Recommendation: Approve.** The forced-fallback run shows that the larger area removes the reported white grass with #1877, but the change increases fallback memory use for players who do not have that change. Its effects on the Steam Deck and RADV, and the first-start cost of invalidating shader caches, still need measurement. Nothing blocking is left: what remains is for the author before merging (below). Recommend approval; not approved on the forge. Doubles the compute fallback's records area and raises its allocation limit so the larger buffer can be created. This fixes the observed capacity shortfall in the tested #1877 scene at a cost of 64 MiB per fallback recording thread and a shader-cache rebuild. **`@fix` will do (2)** 1. **L1** (its part an edit can do) `gpu/vk/eden/shader_recompiler/backend/spirv/emit_spirv.h:69`: Allocate the larger area only when the workload requires it, or otherwise reduce the permanent per-thread allocation. 2. **L3** (minor): Risks says nothing changes for caches, but the changed emitter header changes the translator stamp, invalidating the program cache and prepare record. Describe the rebuild and its player-visible first-start cost. **Before merging, for the author (2)** (a run, a measurement or a decision; it doesn't hold the recommendation) - **L1** (minor) `gpu/vk/eden/shader_recompiler/backend/spirv/emit_spirv.h:69`: The larger allocation applies to every fallback recording thread, including at the game's normal grass load where the reported runs show no visual benefit. (more on the line) - **L2** (minor) `gpu/vk/eden/shader_recompiler/backend/spirv/emit_spirv.h:69`: This header is included in the translator stamp, so changing the constant invalidates the program cache and prepare record even on native-mesh systems. (more on the line) **Checks:** Still running: `CI / Conventional Commit title (pull_request)`, `CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request)`, `CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request)`, `CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request)`, `CI / Workflow lint (actionlint) (pull_request)`, `CI / Website build and checks (pull_request)`, `Guide screenshots / Guide images and local UI source review (pull_request)`, `Third-party parts / As their notes say (pull_request)`, `Third-party parts / The same as upstream (pull_request)`, `Website / Website on Cloudflare (pull_request)`. <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Yes, for the tested setup: with #1877 at 4x on a forced NVIDIA fallback, near-white pixels fell from 4.33–7.99% to 0.03–0.12%, and the two grass programs drew matching record counts. The before side had one run, the after side two; the head and the affected AMD hardware have not been tested in game. **Other systems:** The native path does not allocate the larger fallback buffer, but all players receive a new translator stamp and must rebuild affected caches. RADV and the Steam Deck use the fallback by default; Intel Mesa also uses the attribute pool, producing a roughly 160 MiB records buffer. Allocation, image and performance behavior on those systems remain untested. **Switches:** None added, changed or removed. **Reviewed:** 167aa2de30be against 8aa7498345df: Read AGENTS.md, CONTRIBUTING.md, the PR template, standards, the commits and all seven changed-file diffs; read the new capacity test and harness, changed constants, allocation function, layout model and global-attributes check with their surrounding code. Traced shader emission, buffer reuse and the translator cache stamp. Skimmed the reported runs and related callers. docs/review-checklist.md and the adjacent Tooling checkout were absent; screenshots and generated files were not independently inspected.; nothing run (a code review). **Checked and fine:** - The largest records-plus-pool layout and counters fit the new limit, and the record byte offset remains within 32 bits. - The new capacity check exercises the real fit calculation and allocation function, including pool and counter combinations. - Both commits have AI-assistance trailers; no switches, API version or generated shader headers changed. - The emitter header is included in the translator stamp, so old translated layouts are not silently reused. **Testing:** Read-only review; no builds, tests or project scripts were run. The author's reported game and test results are described above. CI is still running. **Overlaps and merge order:** #1561 touches the same constants; whichever change lands second needs to reconcile the record fit. </details> --- <sub>Automated code review by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
@ -66,0 +66,4 @@
// the floor grass at the Grass distance's 4x (#1877) lost its blades: their program's records are 22 words and fit 762600,
// its partner's 7 words, and each drew ~1.02M records a frame, so the blades past the fit were left out and drawn white.
// 32M words fit 1.52M of 22 words)
constexpr u32 MESH_FALLBACK_RECORD_WORDS = 32u << 20;
Member

L1 (minor): The larger allocation applies to every fallback recording thread, including at the game's normal grass load where the reported runs show no visual benefit. Measure average and 1% low fps, frame times and memory against main on the Deck and RADV, and check that Intel Mesa accepts the pool layout; these are the systems that use or can use this path.

**L1** (minor): The larger allocation applies to every fallback recording thread, including at the game's normal grass load where the reported runs show no visual benefit. Measure average and 1% low fps, frame times and memory against main on the Deck and RADV, and check that Intel Mesa accepts the pool layout; these are the systems that use or can use this path.
Member

L2 (minor): This header is included in the translator stamp, so changing the constant invalidates the program cache and prepare record even on native-mesh systems. Measure the first-start or rebuild cost against main, including the native path, so players' one-time cost is known.

**L2** (minor): This header is included in the translator stamp, so changing the constant invalidates the program cache and prepare record even on native-mesh systems. Measure the first-start or rebuild cost against main, including the native path, so players' one-time cost is known.
HumanBean deleted branch fix/fallback-white-grass 2026-11-21 22:36:38 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 5s
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!2121
No description provided.