fix(vk): DLSS FG's multiplier stops at its runtime's most + 1: 6x on an RTX 50, 2x on an RTX 40 #1486

Merged
HumanBean merged 1 commit from pmwork-personal/Longshot:fix/dlss-fg-runtime-cap into main 2026-11-18 00:12:59 +00:00
Member

Type: fix · Risk: low · Tested on: Windows 11, RTX 5090 (NVIDIA 621.24) · Needs: Windows, an RTX 40 card

TL;DR

With NVIDIA DLSS Frame Generation chosen, a Frame generation setting above what NVIDIA's runtime makes (7x or 8x on an RTX 50, 3x and up on an RTX 40) was never made by DLSS FG: FSR 3.1 or the built-in generator made every frame, while the menu still showed the higher setting. Now, while DLSS FG makes the frames, the row stops at the runtime's limit (6x on an RTX 50, 2x on an RTX 40), and a higher saved value shows and runs as that limit. On an RTX 5090 with 8x saved, the row shows 6x and DLSS FG makes every frame (on main, none). A new check fails on main and passes here.

Breakdown

  • Who it helps: players with an RTX 40 or RTX 50 card who use DLSS Frame Generation at a high multiplier.
  • What was wrong: past the runtime's limit, NGX was not asked at all and the renderer's own or FSR 3.1 frame generation made the frames, with no sign in the menu.
  • What changes: while DLSS FG makes the frames, the multiplier that runs, the row's value and its arrows stop at the runtime's most made frames + 1; at Auto the row names who makes its frames (FSR 3.1 FG or Built-in FG).
  • What does not change: how Off and Auto run; FSR 3.1 FG, Built-in FG and DLSS FG without a temporal Upscaler (no limit); the saved value in longshot_options.ini; every GPU without DLSS FG.
  • How it was checked: a new check fails on main and passes here; the full suite fails only what main fails on this PC, and three checks that fail on main pass again; in the game on an RTX 5090, main and this PR with 8x saved.
  • What is still open: an RTX 40 run (the row at 2x, DLSS FG making the frames): Test Farm.
  • Risk: low: only the multiplier that runs with DLSS FG chosen changes; the worst case is a swapchain made once more when NGX answers.

Why

NGX tells the most frames its DLSS-G runtime makes between two of the game's (MultiFrameCountMax: 1 on an RTX 40, 5 on an RTX 50). For a multiplier past it, dlss_fg_frames skipped NGX (FG_SKIP_TOO_MANY) and the renderer's own or FSR 3.1 frame generation made the whole set, so "DLSS FG" in the row was not true. A player reported it today on an RTX 4070 Ti (driver 617.42, nightly-411) at 3x: their log says available, up to 1 made frames between two of the game's and 2 made frames asked, but its runtime makes 1 at most ...: the renderer's own makes them, and their FPS counter showed FSR 3.1 FG. The same happens at 7x and 8x on an RTX 50.

How to reproduce

Seen on: Windows, RTX 4070 Ti, 617.42 (a player's report); RTX 5090 here.
Settings and switches: Upscaler DLSS or DLAA, Frame generation by: DLSS FG, Frame generation 3x on an RTX 40 (8x on an RTX 50), FPS counter on.
Steps: play anywhere with a 3D scene.
Expected: DLSS FG makes the frames.
Actual: the FPS counter says FSR 3.1 FG (or Built-in FG), and the log has made frames asked, but its runtime makes ... at most.

What changed

The multiplier that runs is now framegen_now(): the row's value, capped at DLSS-G's runtime's most + 1 while DLSS-G is to make the frames. Every place that used the row's multiplier for the work (the sets, the swapchain's images and present mode) uses it, and the menu shows it.

  • vk_dlss: dlss_fg_most() (gpu/vk/vk_dlss.cpp): the runtime's most made frames while DLSS-G is asked for, DLSS runs on the device, a temporal Upscaler gives it inputs (temporal_wanted()), NGX said yes and it was not given up; 0 otherwise and before NGX answers (0 in a build without NVIDIA's SDK).
  • vk_framegen: framegen_capped() and framegen_now() (gpu/vk/vk_framegen.cpp, declared in vk_framegen.h); multiplier() runs at framegen_now().
  • swapchain: swapchain_framegen(), swapchain_dlssg() and create_swapchain's set_too_big (gpu/vk/vk_main.cpp), and present_image's swapchain key (gpu/vk/vk_replay.cpp) use framegen_now(): a saved 8x that DLSS FG makes at 6x is a set of 6, and the chain is made again when the multiplier that runs changes (NGX's answer, DLSS FG given up, another engine chosen).
  • menu (gpu/vk/vk_menu.cpp): tx_framegen and hn_framegen show the value that runs; set_row's arrows step from the value shown, past the top go round to Off and down from Off to the top (as at 8x); menu_setting_set (the control bridge) sets a value as asked. At Auto the row names who makes its frames, "Auto (FSR 3.1 FG)" or "Auto (Built-in FG)" (framegen_maker(); DLSS FG makes fixed multipliers only), and plain "Auto" while none are made. The row's help says the limit; the Frame generation by line for Auto says "a fixed 2x and up" instead of "2x to 8x". These texts in the 13 languages of gpu/vk/menu_i18n.h.
  • docs: the README's option table and DLSS FG text, docs/graphics-and-controls.md.
  • checks: tests/test_framegen_dlss_cap.py (new: the real framegen_capped compiled and run, the call sites by text); tests/test_vsync_row.py compiles the real dlss_fg_most, framegen_capped and framegen_now (4x on a runtime of 1 now runs as 2x by DLSS-G, FIFO under V-Sync Auto; dlss_fg_runs still refuses a set past the runtime's most); tests/test_framegen_preset.py runs the row's arrows at 6x, 2x and no limit (and gets the framegen_by_dlss_offered stand-in it lacked on main); stand-ins in test_framegen_auto.py, test_present_semaphores.py, test_rumble_menu.py, test_upscaler_round_trip.py and test_crt_options.py (the first two of those three pass again with the framegen_by_dlss_offered stand-in; test_crt_options still stops at its own cut, as on main), and in the guide's screenshot tool (scripts/screenshots/menu.cpp).

Since #1442, create_swapchain's set_too_big read the row's multiplier. It now reads framegen_now(), so a saved 8x that DLSS FG makes at 6x gets the chain of a 6x set (two sets' images under FIFO, as a saved 6x on main), and present_image's swapchain key changes when the multiplier as it runs changes. In dlss_fg_frames, a set without a temporal Upscaler now gives FG_SKIP_INPUTS before the too-many test: then the multiplier is not capped, and the missing inputs are the reason the row's line and the log give.

Measurements

Verdict: nothing to measure for speed: this changes which frame generator runs and what the menu shows, checked in the game and by the checks below.

Flags and settings

A menu row's range changes; no switch, ini key or build flag.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
Frame generation (framegen=) the Insert menu's multiplier 2x to 8x with any engine with DLSS FG making the frames: up to the runtime's most + 1 (6x RTX 50, 2x RTX 40); others 2x to 8x a saved value past it shows and runs as the top helps (RTX 5090 here); RTX 40 untested as shipped

Testing

Tested: In the game on Windows 11, RTX 5090 (NVIDIA 621.24), 5120x2160 at 165 Hz, my settings (DLSS, Frame generation by DLSS FG, FPS counter on) with Frame generation 8x saved; each runtime a dev pack on the same base (scripts/dev_packs.py). Main (415a8944): the row showed 8x, the FPS counter FSR 3.1 FG, the frames were FSR 3.1's (also over the HUD), and the log said 7 made frames asked, but its runtime makes 5 at most and of the last 600 presents 0 made by DLSS-G. This PR (6556a50d, before the rebases onto c7db6c02 and 6d949cf9, which touched none of these lines; since then only a log line's number and comments changed): the row showed 6x, the counter DLSS FG, the log feature made ... 5 made frame(s) a set and 600 made by DLSS-G of each 600 presents, and no too-many line; 8x stayed saved. Game-free: tests/test_framegen_dlss_cap.py fails on main and passes here; python -I -B tests/run_all.py fails only checks that fail on main on this PC (51 checks, all failing on main 6d949cf9 here too: compilers, headers and stand-ins this PC lacks), and test_framegen_preset, test_rumble_menu and test_upscaler_round_trip pass again. The row's arrows in the game (this PR, the start screen): Left from Auto gives Off, Left from Off 6x (the top), Right at 6x Off. At Auto on the start screen the row says plain "Auto": the game ran faster than the 165 Hz display there, so Auto made no frames; "Auto (FSR 3.1 FG)" while Auto makes frames in play is checked by the game-free checks only.

Screenshots (the Insert menu at Frame generation, 8x saved, the start screen; the FPS counter at the top right):

Before: main @ 415a8944 (8x saved: the row shows 8x; the counter, Built-in FG)

Before: main @ 415a8944, Frame generation 8x

After: this PR @ 6556a50d (8x saved: the row shows 6x, its help names the limit; the counter, DLSS FG paused, as on the start screen there is no 3D scene to make frames from)

After: this PR @ 6556a50d, Frame generation 6x

Not testable by hand: an RTX 40 card (this PC has an RTX 5090): the Test Farm run below stands in.

Not tested: Linux. With V-Sync Off, DLSS FG's 6x paced unevenly here; this PR leaves that path as it is (the same swapchain and multiplier as main with 6x saved), and the frame pacing work follows it up. With V-Sync On at 165 Hz, 6x holds the game at the refresh over 6.

Must be tested:

  • Windows, RTX 40 (gpu-rtx-40xx): Upscaler DLSS, Frame generation by DLSS FG, Frame generation 3x or 8x saved, then play; expecting the row to show 2x, the FPS counter to say DLSS FG, and no made frames asked, but its runtime makes line in longshot_log.txt (Test Farm: @Beanstalk windows nvidia gpu-rtx-40xx).

Risks

What could break: with DLSS FG chosen, the multiplier that runs can change once when NGX answers (before its answer the row's value runs); the swapchain is then made again, as it already was for NGX's no. If DLSS FG is given up later, the saved value runs again with the renderer's own.

Turning it off: revert the commit.

Compatibility: nothing changes in the options file: a saved 7x or 8x stays and runs as 8x again with another frame generator or GPU.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value.
  • Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen.
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Docs updated.

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Windows 11, RTX 5090 (NVIDIA 621.24) · **Needs:** Windows, an RTX 40 card ## TL;DR With NVIDIA DLSS Frame Generation chosen, a Frame generation setting above what NVIDIA's runtime makes (7x or 8x on an RTX 50, 3x and up on an RTX 40) was never made by DLSS FG: FSR 3.1 or the built-in generator made every frame, while the menu still showed the higher setting. Now, while DLSS FG makes the frames, the row stops at the runtime's limit (6x on an RTX 50, 2x on an RTX 40), and a higher saved value shows and runs as that limit. On an RTX 5090 with 8x saved, the row shows 6x and DLSS FG makes every frame (on main, none). A new check fails on main and passes here. ## Breakdown - **Who it helps:** players with an RTX 40 or RTX 50 card who use DLSS Frame Generation at a high multiplier. - **What was wrong:** past the runtime's limit, NGX was not asked at all and the renderer's own or FSR 3.1 frame generation made the frames, with no sign in the menu. - **What changes:** while DLSS FG makes the frames, the multiplier that runs, the row's value and its arrows stop at the runtime's most made frames + 1; at Auto the row names who makes its frames (FSR 3.1 FG or Built-in FG). - **What does not change:** how Off and Auto run; FSR 3.1 FG, Built-in FG and DLSS FG without a temporal Upscaler (no limit); the saved value in longshot_options.ini; every GPU without DLSS FG. - **How it was checked:** a new check fails on main and passes here; the full suite fails only what main fails on this PC, and three checks that fail on main pass again; in the game on an RTX 5090, main and this PR with 8x saved. - **What is still open:** an RTX 40 run (the row at 2x, DLSS FG making the frames): Test Farm. - **Risk:** low: only the multiplier that runs with DLSS FG chosen changes; the worst case is a swapchain made once more when NGX answers. ## Why NGX tells the most frames its DLSS-G runtime makes between two of the game's (MultiFrameCountMax: 1 on an RTX 40, 5 on an RTX 50). For a multiplier past it, `dlss_fg_frames` skipped NGX (`FG_SKIP_TOO_MANY`) and the renderer's own or FSR 3.1 frame generation made the whole set, so "DLSS FG" in the row was not true. A player reported it today on an RTX 4070 Ti (driver 617.42, nightly-411) at 3x: their log says `available, up to 1 made frames between two of the game's` and `2 made frames asked, but its runtime makes 1 at most ...: the renderer's own makes them`, and their FPS counter showed `FSR 3.1 FG`. The same happens at 7x and 8x on an RTX 50. ## How to reproduce **Seen on:** Windows, RTX 4070 Ti, 617.42 (a player's report); RTX 5090 here. **Settings and switches:** Upscaler DLSS or DLAA, Frame generation by: DLSS FG, Frame generation 3x on an RTX 40 (8x on an RTX 50), FPS counter on. **Steps:** play anywhere with a 3D scene. **Expected:** DLSS FG makes the frames. **Actual:** the FPS counter says FSR 3.1 FG (or Built-in FG), and the log has `made frames asked, but its runtime makes ... at most`. ## What changed The multiplier that runs is now `framegen_now()`: the row's value, capped at DLSS-G's runtime's most + 1 while DLSS-G is to make the frames. Every place that used the row's multiplier for the work (the sets, the swapchain's images and present mode) uses it, and the menu shows it. - vk_dlss: `dlss_fg_most()` (`gpu/vk/vk_dlss.cpp`): the runtime's most made frames while DLSS-G is asked for, DLSS runs on the device, a temporal Upscaler gives it inputs (`temporal_wanted()`), NGX said yes and it was not given up; 0 otherwise and before NGX answers (0 in a build without NVIDIA's SDK). - vk_framegen: `framegen_capped()` and `framegen_now()` (`gpu/vk/vk_framegen.cpp`, declared in `vk_framegen.h`); `multiplier()` runs at `framegen_now()`. - swapchain: `swapchain_framegen()`, `swapchain_dlssg()` and `create_swapchain`'s `set_too_big` (`gpu/vk/vk_main.cpp`), and `present_image`'s swapchain key (`gpu/vk/vk_replay.cpp`) use `framegen_now()`: a saved 8x that DLSS FG makes at 6x is a set of 6, and the chain is made again when the multiplier that runs changes (NGX's answer, DLSS FG given up, another engine chosen). - menu (`gpu/vk/vk_menu.cpp`): `tx_framegen` and `hn_framegen` show the value that runs; `set_row`'s arrows step from the value shown, past the top go round to Off and down from Off to the top (as at 8x); `menu_setting_set` (the control bridge) sets a value as asked. At Auto the row names who makes its frames, "Auto (FSR 3.1 FG)" or "Auto (Built-in FG)" (`framegen_maker()`; DLSS FG makes fixed multipliers only), and plain "Auto" while none are made. The row's help says the limit; the Frame generation by line for Auto says "a fixed 2x and up" instead of "2x to 8x". These texts in the 13 languages of `gpu/vk/menu_i18n.h`. - docs: the README's option table and DLSS FG text, `docs/graphics-and-controls.md`. - checks: `tests/test_framegen_dlss_cap.py` (new: the real `framegen_capped` compiled and run, the call sites by text); `tests/test_vsync_row.py` compiles the real `dlss_fg_most`, `framegen_capped` and `framegen_now` (4x on a runtime of 1 now runs as 2x by DLSS-G, FIFO under V-Sync Auto; `dlss_fg_runs` still refuses a set past the runtime's most); `tests/test_framegen_preset.py` runs the row's arrows at 6x, 2x and no limit (and gets the `framegen_by_dlss_offered` stand-in it lacked on main); stand-ins in `test_framegen_auto.py`, `test_present_semaphores.py`, `test_rumble_menu.py`, `test_upscaler_round_trip.py` and `test_crt_options.py` (the first two of those three pass again with the `framegen_by_dlss_offered` stand-in; `test_crt_options` still stops at its own cut, as on main), and in the guide's screenshot tool (`scripts/screenshots/menu.cpp`). Since #1442, `create_swapchain`'s `set_too_big` read the row's multiplier. It now reads `framegen_now()`, so a saved 8x that DLSS FG makes at 6x gets the chain of a 6x set (two sets' images under FIFO, as a saved 6x on main), and `present_image`'s swapchain key changes when the multiplier as it runs changes. In `dlss_fg_frames`, a set without a temporal Upscaler now gives `FG_SKIP_INPUTS` before the too-many test: then the multiplier is not capped, and the missing inputs are the reason the row's line and the log give. ## Measurements **Verdict:** nothing to measure for speed: this changes which frame generator runs and what the menu shows, checked in the game and by the checks below. ### Flags and settings A menu row's range changes; no switch, ini key or build flag. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | Frame generation (`framegen=`) | the Insert menu's multiplier | 2x to 8x with any engine | with DLSS FG making the frames: up to the runtime's most + 1 (6x RTX 50, 2x RTX 40); others 2x to 8x | a saved value past it shows and runs as the top | helps (RTX 5090 here); RTX 40 untested | as shipped | ## Testing **Tested:** In the game on Windows 11, RTX 5090 (NVIDIA 621.24), 5120x2160 at 165 Hz, my settings (DLSS, Frame generation by DLSS FG, FPS counter on) with Frame generation 8x saved; each runtime a dev pack on the same base (`scripts/dev_packs.py`). Main (415a8944): the row showed 8x, the FPS counter FSR 3.1 FG, the frames were FSR 3.1's (also over the HUD), and the log said `7 made frames asked, but its runtime makes 5 at most` and `of the last 600 presents 0 made by DLSS-G`. This PR (6556a50d, before the rebases onto c7db6c02 and 6d949cf9, which touched none of these lines; since then only a log line's number and comments changed): the row showed 6x, the counter DLSS FG, the log `feature made ... 5 made frame(s) a set` and `600 made by DLSS-G` of each 600 presents, and no too-many line; 8x stayed saved. Game-free: `tests/test_framegen_dlss_cap.py` fails on main and passes here; `python -I -B tests/run_all.py` fails only checks that fail on main on this PC (51 checks, all failing on main 6d949cf9 here too: compilers, headers and stand-ins this PC lacks), and `test_framegen_preset`, `test_rumble_menu` and `test_upscaler_round_trip` pass again. The row's arrows in the game (this PR, the start screen): Left from Auto gives Off, Left from Off 6x (the top), Right at 6x Off. At Auto on the start screen the row says plain "Auto": the game ran faster than the 165 Hz display there, so Auto made no frames; "Auto (FSR 3.1 FG)" while Auto makes frames in play is checked by the game-free checks only. Screenshots (the Insert menu at Frame generation, 8x saved, the start screen; the FPS counter at the top right): **Before: main @ 415a8944** (8x saved: the row shows 8x; the counter, Built-in FG) ![Before: main @ 415a8944, Frame generation 8x](https://git.magicbean.dev/attachments/51859eba-4c69-4acd-a854-fc056ba894cd) **After: this PR @ 6556a50d** (8x saved: the row shows 6x, its help names the limit; the counter, DLSS FG paused, as on the start screen there is no 3D scene to make frames from) ![After: this PR @ 6556a50d, Frame generation 6x](https://git.magicbean.dev/attachments/0fc3b62f-556d-49b7-8eca-cf2239917b01) **Not testable by hand:** an RTX 40 card (this PC has an RTX 5090): the Test Farm run below stands in. **Not tested:** Linux. With V-Sync Off, DLSS FG's 6x paced unevenly here; this PR leaves that path as it is (the same swapchain and multiplier as main with 6x saved), and the frame pacing work follows it up. With V-Sync On at 165 Hz, 6x holds the game at the refresh over 6. **Must be tested:** - Windows, RTX 40 (gpu-rtx-40xx): Upscaler DLSS, Frame generation by DLSS FG, Frame generation 3x or 8x saved, then play; expecting the row to show 2x, the FPS counter to say DLSS FG, and no `made frames asked, but its runtime makes` line in longshot_log.txt (Test Farm: @Beanstalk windows nvidia gpu-rtx-40xx). ## Risks **What could break:** with DLSS FG chosen, the multiplier that runs can change once when NGX answers (before its answer the row's value runs); the swapchain is then made again, as it already was for NGX's no. If DLSS FG is given up later, the saved value runs again with the renderer's own. **Turning it off:** revert the commit. **Compatibility:** nothing changes in the options file: a saved 7x or 8x stays and runs as 8x again with another frame generator or GPU. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. - [x] Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(vk): DLSS FG's multiplier stops at its runtime's most + 1: 6x on an RTX 50, 2x on an RTX 40
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 9s
Website / Website on Cloudflare (pull_request_target) Has been skipped
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 13s
CI / Workflow lint (actionlint) (pull_request) Successful in 14s
Third-party parts / As their notes say (pull_request) Successful in 16s
PR description / Description follows the template (pull_request_target) Successful in 5s
beanstalk/approval approved by pmwork-personal (reviewed)
beanstalk/windows+nvidia+gpu-rtx-40xx 0/1 pass, 0 running, 0 queued
0647e379a0
NGX tells the most frames DLSS Frame Generation's runtime makes between two of the game's (MultiFrameCountMax: 1 on an
RTX 40's runtime, 5 on an RTX 50's). For a multiplier past it NGX was not asked (dlss_fg_frames' FG_SKIP_TOO_MANY) and the
renderer's own or AMD FSR 3.1's frame generation made every frame, while the Frame generation row still said 3x or 8x with
DLSS FG chosen.

The multiplier that runs is now framegen_now (vk_framegen.cpp): the row's value, at most the runtime's most + 1 while
DLSS-G is to make the frames (vk_dlss.cpp dlss_fg_most: asked for, DLSS runs on the device, a temporal Upscaler for its
inputs, NGX's yes, not given up; 0 otherwise and before NGX answers: FSR 3.1 FG and Built-in FG keep 2x to 8x). multiplier(), swapchain_framegen(), swapchain_dlssg(), create_swapchain's set_too_big
and present_image's swapchain key use it. The menu shows it: a saved value past the top is kept in the options file and
shows and runs as the top; the row's arrows step from the value shown, past the top round to Off and down from Off to the
top, as at 8x; the control bridge sets a value as asked. At Auto the row names who makes its frames, "Auto (FSR 3.1 FG)" or
"Auto (Built-in FG)" (DLSS FG makes fixed multipliers only). The row's help says the limit, the Frame generation by line
for Auto says "a fixed 2x and up"; these texts in the 13 languages. README and the player guide say the limit.

Checks: test_framegen_dlss_cap (new; fails on main), test_vsync_row (the real dlss_fg_most, framegen_capped and
framegen_now: 4x on a runtime of 1 runs as 2x by DLSS-G; no cap without a temporal Upscaler), test_framegen_preset (the
row's arrows at 6x, 2x and no limit), stand-ins in test_framegen_auto, test_present_semaphores, test_rumble_menu,
test_upscaler_round_trip and test_crt_options. The framegen_by_dlss_offered stand-in that test_framegen_preset,
test_rumble_menu and test_upscaler_round_trip lacked on main is added too: the three pass again.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

Tested in game: RTX 5090, NVIDIA 621.24, Windows 11, 5120x2160 at 165 Hz, DLSS (DLAA), Frame generation by DLSS FG, 8x saved, the start screen and play: main 415a8944 showed 8x with FSR 3.1 or the built-in generator making the frames (log: 7 made frames asked, but its runtime makes 5 at most; 0 of 600 presents by DLSS-G). This PR showed 6x, the FPS counter DLSS FG, and DLSS-G made 600 of 600 presents (5 made frames a set); the row's arrows: Right at 6x goes to Off, Left from Off to 6x.

Tested in game: RTX 5090, NVIDIA 621.24, Windows 11, 5120x2160 at 165 Hz, DLSS (DLAA), Frame generation by DLSS FG, 8x saved, the start screen and play: main 415a8944 showed 8x with FSR 3.1 or the built-in generator making the frames (log: 7 made frames asked, but its runtime makes 5 at most; 0 of 600 presents by DLSS-G). This PR showed 6x, the FPS counter DLSS FG, and DLSS-G made 600 of 600 presents (5 made frames a set); the row's arrows: Right at 6x goes to Off, Left from Off to 6x.
Author
Member

Added the Before/After screenshots of the Insert menu (8x saved, the start screen, RTX 5090): main shows 8x, this PR 6x.

Added the Before/After screenshots of the Insert menu (8x saved, the start screen, RTX 5090): main shows 8x, this PR 6x.
Author
Member

@Beanstalk windows nvidia gpu-rtx-40xx: please run this PR on an RTX 40 card, 5 minutes.

Settings: Upscaler NVIDIA DLSS or DLAA, Frame generation by DLSS FG, FPS counter on, and frame_generation=8 in longshot_options.ini (8x saved, set before the start). Play about a minute in a 3D place (Kokiri Forest is fine), then open the Insert menu at Frame generation.

Expected with this PR:

  • The Frame generation row shows 2x (not 8x), and the FPS counter names DLSS FG.
  • longshot_log.txt has DLSS Frame Gen (NGX): available, up to 1 made frames, the of the last 600 presents ... made by DLSS-G lines count more than 0, and there is no made frames asked, but its runtime makes line.
  • Right at 2x turns the row to Off; Left from Off brings it back to 2x.

On main the same settings show 8x, the counter names FSR 3.1 FG or Built-in FG, and the log has the made frames asked line.

@Beanstalk windows nvidia gpu-rtx-40xx: please run this PR on an RTX 40 card, 5 minutes. Settings: Upscaler NVIDIA DLSS or DLAA, Frame generation by DLSS FG, FPS counter on, and `frame_generation=8` in longshot_options.ini (8x saved, set before the start). Play about a minute in a 3D place (Kokiri Forest is fine), then open the Insert menu at Frame generation. Expected with this PR: - The Frame generation row shows **2x** (not 8x), and the FPS counter names **DLSS FG**. - longshot_log.txt has `DLSS Frame Gen (NGX): available, up to 1 made frames`, the `of the last 600 presents ... made by DLSS-G` lines count more than 0, and there is no `made frames asked, but its runtime makes` line. - Right at 2x turns the row to Off; Left from Off brings it back to 2x. On main the same settings show 8x, the counter names FSR 3.1 FG or Built-in FG, and the log has the `made frames asked` line.
Member

Beanstalk test farm

Commit 0647e37 · tier reviewed · approved by pmwork-personal · dashboard

What will be tested · AI plan (gpt-6.1-terra)

The plan requests a Windows RTX 40 PC, but none is listed online, so it will wait for one. It runs about a minute in Kokiri Forest with 8x saved and DLSS settings, comparing main and the PR in roughly 12 minutes. DLSS is not built on the farm, so this cannot verify the requested DLSS FG cap, counter, logs, or menu arrows; only a crash fails the plan. No tester online now matches windows+nvidia+gpu-rtx-40xx: that target waits for one.

  • Where: windows+nvidia+gpu-rtx-40xx (GPU "rtx 40xx", 1-2 reports).
  • kokiri-saved-8x: from a new save (settings dlss=1, fps_counter=1, frame_generation=8, frame_generation_by=1), then measure forest for 60 s (after 5 s warm-up), take the picture forest-counter; 1 run on each side.
  • Measured: crashes.
  • The PR fails if: it crashes.
  • Time: about 15 min of game runs per tester (2 game starts), plus the two builds.

Done. Comment @Beanstalk to run it again.

Target Reports Crash Frame p99 (ms) vs main VRAM peak (MB) vs main Result
windows+nvidia+gpu-rtx-40xx 0/1 — — — queued
<!-- beanstalk:sticky --> ### Beanstalk test farm Commit `0647e37` · tier **reviewed** · approved by pmwork-personal · [dashboard](https://beanstalk.magicbean.dev/prs/1486) **What will be tested** · AI plan (`gpt-6.1-terra`) The plan requests a Windows RTX 40 PC, but none is listed online, so it will wait for one. It runs about a minute in Kokiri Forest with 8x saved and DLSS settings, comparing main and the PR in roughly 12 minutes. DLSS is not built on the farm, so this cannot verify the requested DLSS FG cap, counter, logs, or menu arrows; only a crash fails the plan. No tester online now matches windows+nvidia+gpu-rtx-40xx: that target waits for one. - **Where:** windows+nvidia+gpu-rtx-40xx (GPU "rtx 40xx", 1-2 reports). - **kokiri-saved-8x:** from a new save (settings dlss=1, fps_counter=1, frame_generation=8, frame_generation_by=1), then measure forest for 60 s (after 5 s warm-up), take the picture forest-counter; 1 run on each side. - **Measured:** crashes. - **The PR fails if:** it crashes. - **Time:** about 15 min of game runs per tester (2 game starts), plus the two builds. Done. Comment `@Beanstalk` to run it again. | Target | Reports | Crash | Frame p99 (ms) vs main | VRAM peak (MB) vs main | Result | | --- | --- | --- | --- | --- | --- | | windows+nvidia+gpu-rtx-40xx | 0/1 | — | — | — | queued |
HumanBean deleted branch fix/dlss-fg-runtime-cap 2026-11-18 00:13:00 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1486
No description provided.