fix(vk): the 2x hint names AMD FSR 3.1 only where FSR 3.1 makes the frame, not while DLSS FG makes it #1497
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1497
Loading…
Reference in a new issue
No description provided.
Delete branch "pmwork-personal/Longshot:fix/framegen-2x-hint-dlss"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Windows 11, RTX 5090 (NVIDIA 621.24) · Needs: none
TL;DR
With NVIDIA DLSS Frame Generation chosen, the Frame generation row's hint at 2x said the frame was made "by AMD FSR 3.1", while DLSS FG made it. Since #1486 every RTX 40 with DLSS FG runs at 2x, so every such player saw the wrong hint. Now the 2x hint names FSR 3.1 only where FSR 3.1 makes the frame. A new case in the check fails on main and passes here, and the menu showed the right hint in the game.
Breakdown
Why
The Frame generation row's hint at 2x read "One made frame between each two of the game's, by AMD FSR 3.1 from the scene's depth and motion." whenever
fsr3fi::frames_wanted()said yes. That is yes with Frame generation by at DLSS FG too, because FSR 3.1 is then asked for the sets DLSS-G does not make. So with DLSS FG making every frame, the hint named the wrong engine. Since #1486 a DLSS FG multiplier stops at the runtime's most + 1, which is 2x on an RTX 40, so every RTX 40 with DLSS FG shows this hint.How to reproduce
Seen on: Windows 11, RTX 5090, NVIDIA 621.24 (any DLSS FG card).
Settings and switches: Upscaler NVIDIA DLSS or DLAA, Frame generation by DLSS FG, Frame generation 2x.
Steps: open the Insert menu and select the Frame generation row.
Expected: "One made frame between each two of the game's."
Actual: "One made frame between each two of the game's, by AMD FSR 3.1 from the scene's depth and motion."
What changed
hn_framegennames FSR 3.1 at 2x only while DLSS-G does not make the frames.hn_framegen(gpu/vk/vk_menu.cpp) shows the FSR text at 2x only whendlss_fg_most()is 0 (FSR 3.1 FG chosen, DLSS FG that does not run here, no temporal Upscaler, or given up) andfsr3fi::frames_wanted()says yes. Its variants for the help box's height still include the FSR text.tests/test_framegen_dlss_cap.pycompiles and runs the realhn_framegenwith an RTX 40's and an RTX 50's DLSS FG, FSR 3.1 FG, the built-in one, and the measured variants.Measurements
Verdict: nothing to measure: a menu text, checked in the game and by the check.
Flags and settings
None: one hint text of the Frame generation row changes; no row, ini key or switch.
Testing
Tested: In the game on Windows 11, RTX 5090 (NVIDIA 621.24), 5120x2160, DLSS (DLAA), Frame generation by DLSS FG, Frame generation 2x, a dev pack of this branch on a shared base (
scripts/dev_packs.py): the Frame generation row at 2x shows "One made frame between each two of the game's." with no FSR 3.1. Before (the same code as main, from #1486's run): "... by AMD FSR 3.1 from the scene's depth and motion." Game-free:tests/test_framegen_dlss_cap.pyfails on main (the DLSS FG cases) and passes here;python -I -B tests/run_all.pyfails only checks that fail on main on this PC (53 checks, all failing on main310e7c9dhere too: compilers, headers and stand-ins this PC lacks).Before: main's code @ 6556a50d (#1486, merged as
ec76f696; 2x, DLSS FG chosen, the start screen)After: this PR @ 8469aedd (the condition's order changed since, not its result) (2x, DLSS FG chosen, the start screen)
Not tested: an RTX 40 card (this PC has an RTX 5090; the condition is the same on both, and the check runs an RTX 40's case); Linux.
Must be tested:
Risks
What could break: nothing outside the hint's text.
Turning it off: revert the commit.
Compatibility: nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.mainand passing here.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
Tested in game: RTX 5090, NVIDIA 621.24, Windows 11, 5120x2160, DLSS (DLAA), Frame generation by DLSS FG, Frame generation 2x, the start screen: the Frame generation row's hint shows 'One made frame between each two of the game's.' with no 'by AMD FSR 3.1' (on main it named FSR 3.1 while DLSS FG made the frame).
Added the Before/After screenshots of the Frame generation row at 2x with DLSS FG (RTX 5090).