fix(forge): show formal reviews and inline feedback in view #310
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!310
Loading…
Reference in a new issue
No description provided.
Delete branch "monsterlag/Longshot:fix/forge-review-feedback"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
Contributors following review feedback with
forge.py pr view --commentscannot see formal review summaries or inline comments. A requested-changes verdict can appear in status while its actual explanation is missing from the documented reading command.What changed
scripts/forge.py: include submitted review verdicts, summaries and inline feedback with the existing optional discussion output. Print the review commit and thread links, mark dismissed/stale reviews and resolved threads, and preserve the API's supplied file positions.tests/test_forge_pr.py: eight CLI regression methods cover the output, overlapping APIs and ID namespaces, state filtering, original/resolved locations, server caps of 20/50, ignored page parameters, unchanged default output and explicit API failure. Existing network guards remain active.docs/tested/files record the current CPU-only regression runs.docs/forge.md: document the added feedback and pagination behavior. Issue view and review posting are unchanged.Flags and settings
None. The existing
--commentsoption includes the additional feedback; default view output is unchanged.Measurements
main:
9c9d69ed09(2026-11-14)this PR: fix/forge-review-feedback @
4aa011a1e6Hardware: Ryzen 7 9800X3D, 96 GiB RAM, Windows 11 build 26300, native Python 3.14.7. No GPU used by this check.
Scene: authored, network-guarded CLI cases and live metadata from PR277. No game scene.
Method: focused check as warm-up; two sequential interleaved main/PR runs of the same eight new regression methods, then two interleaved live CLI pairs. Live calls now use ordinary Windows piped output without
-X utf8: main includes the separate stream fix from PR120. No performance improvement is claimed.How to reproduce: run the eight
PR.test_review_view_*methods intests/test_forge_pr.py; for main, load main'sscripts/forge.pywith the same new tests. Runpython -I -B scripts/forge.py pr view 277 --commentson both checkouts. All live calls are read-only API metadata requests; displayed HTML/attachment URLs are never opened.9c9d69ed4aa011a1The live summaries/positions were observed on 2026-11-14. The failing-assertion count includes pagination subtests, so it can exceed the number of methods.
Testing
Tested: native Windows focused CLI check; two fresh interleaved eight-method regression pairs on main9c9d69ed and the carried PR (9 assertion/subtest failures on main, zero here, errors/skips0); two live metadata-only PR277 pairs (main0/0 formal/inline, here2/2, all exits0); independent read-only review. Full
python -I -B tests/run_all.py --jobs 8ond00ff970: 533 passed, 3 failed, 34 skipped in 257s. The same three groups fail on untouched main9c9d69ed in fresh focused checks:test_oot_state_tap.py(Windows bridge connection race, issue481),test_tested_configurations.py(authored stream newline assumption, issue482), andtest_walk_key.py(missing stand-in after the Skip-title merge, already claimed by mooki). No assertion was weakened and no skip was added.The final head
4aa011a1adds only the four measured-run records after that suite; production/test files match the measured tree. The repository-fragment validation passes after those records, andgit diff --checkpasses. History was preserved by merging the frozen main rather than rewriting published commits.Not tested: live CLI on Linux/macOS, unpublished drafts on the server, concurrent API mutations or every Forgejo version. State/overlap fixtures remain guarded; live verification used submitted reviews. File positions are supplied by the API, not an inferred diff-side mapping. This change does not run in the game.
Needs other testers: None for this read-only CLI fix.
Screenshots
CLI output is shown in Measurements. Nothing in the game changes.
Risk and rollback
--commentsmakes additional read-only metadata requests and shows grouped review feedback after ordinary discussion. An API error is reported as a failed command rather than silently omitting reviews. Reverting this commit restores the old display. No review posting, authentication, game data or attachment handling changes.Reviewer notes
Start at
api_pagesandshow_pr_comments. Review IDs are distinct from issue-comment IDs; only inline IDs and supplied URLs suppress overlapping discussion entries. The pagination fixture exercises both real-world server behaviors: clamped page size and ignored page number. Main now includes PR120's output-stream setup; this change remains separate from the attachment listings in PR298/300.Issues
Fixes #301
Checklist
For everyone
type(scope): description).main.python -I -B tests/run_all.pyrun and passing (any failure that also fails onmainis named above).third_party/untouched (a new folder with aPROVENANCE.mdinstead).If applicable
docs/tested/for each new measured run (format indocs/tested-configurations.md; no appended row or assembled view).Assisted-by:/Co-Authored-By:trailers.mainand passing here.tests/that reads changed source updated in this PR, not weakened.WIP: fix(forge): show formal reviews and inline feedback in viewto fix(forge): show formal reviews and inline feedback in viewMerged main9c9d69ed without rewriting published history and refreshed two native regression/live pairs. Full suite533pass/3main-baseline-fail/34skip; the three Windows check failures are named with fresh main reproductions. Final record-only commit adds four CPU-only run files; fragment validation passes. Live output now works without the old UTF8 override because PR120 is on main.
The change to
scripts/forge.py,tests/test_forge_pr.pyanddocs/forge.mdhas moved to the team's new shared Tooling repo: MagicBeanDev/Tooling#5 (ported from this PR, credited to monsterlag). forge.py moved there in MagicBeanDev/Tooling#1, and #915 deletes those files from Longshot, so a change here would be lost or conflict.I added one commit on top of this branch (history untouched) restoring those three files to the base this branch was merged from. What is left here is the four
docs/tested/run records, which describe that forge change and may need rewording or moving.No tests were run here or for the port.
Update: #915 has merged, so those three files no longer exist as they were on main (a forwarding scripts/forge.py only). The commit I pushed restored them to the base this branch was merged from (
9c9d69ed), so this PR no longer touches them. Please rebase (or merge) onto current main so they resolve as deletions on your side. No tests were run here.Code-only review of
37a2cb0ab0; informational findings, with final approval left to another reviewer.No new defect found in the remaining four historical run records. The current diff adds 12 documentation lines and no executable changes; each record identifies its original measured commit, CPU-only scope and distinct run, without claiming gameplay or performance results.
I independently checked the migration noted in the earlier comment: Tooling PR 5 is now merged, and the shared CLI contains the review/inline-feedback display. This Longshot PR therefore preserves evidence only; it does not deliver another CLI fix. The existing decision about retaining or relocating those records remains with the author/maintainer.
Read the complete remaining diff, the run-fragment format, prior discussion and current forwarding/shared CLI paths. The reported Windows fixture results are historical author evidence, not rerun here. No tests, builds or game runs performed.
theguyser referenced this pull request2026-11-16 13:51:42 +00:00
The review display this pull request describes is already in the shared tooling, and what is left here is four run records. Please do not merge it as it stands.
Head
37a2cb0aadds onlydocs/tested/rows. It does not changescripts/forge.py,tests/test_forge_pr.pyordocs/forge.md. Those moved with the script, and MagicBeanDev/Tooling#5 is merged with the same fix. #301 is still open.The description still says this pull request changes
scripts/forge.pyand that it fixes #301. Merging it would close that issue from a documentation-only diff, and would record a Longshot script change that is no longer in this tree.Close this pull request, and close #301 against the merged Tooling pull request. If the four run records should stay in Longshot, rewrite the description so it does not claim the script change and does not say
Fixes #301.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.