Tool: pr view --comments omits formal review feedback #301

New issue

Open

opened 2026-11-13 20:41:48 +00:00 by monsterlag · 2 comments

monsterlag commented

2026-11-13 20:41:48 +00:00

Problem

python -I scripts/forge.py pr view N --comments prints ordinary issue comments but omits formal review summaries and inline review comments. pr status can say that changes were requested without showing what the reviewer asked for. This makes the documented CLI follow-up route incomplete for authors working through review feedback.

Reproduction

On main 514591a3, run python -X utf8 -I -B scripts/forge.py pr view 277 --comments. The issue-comments API currently returns one ordinary comment, which is shown. The review API used by pr status returns one formal review with a nonempty body and two inline comments. Neither the formal summary nor the inline feedback appears in view's output. The review is #277 (comment).

cmd_pr calls only show_comments, and that function reads /issues/N/comments. pr status separately reads /pulls/N/reviews but renders only verdicts. This is separate from attachment metadata visibility (#289 / PR300).

Expected behavior

With --comments, show the formal review verdict, summary and inline file/line feedback as well as ordinary discussion. Keep viewing read-only, avoid duplicate entries if the APIs overlap, and cover the additional GETs with the existing network-guarded fake API tests. This report does not propose changing the default view without --comments.

Priority

S3 contributor-workflow defect; confidence 1.0 from the CLI/API comparison and source. Reader reach is unmeasured, so no player-impact score is assigned. No fix is claimed yet.

## Problem `python -I scripts/forge.py pr view N --comments` prints ordinary issue comments but omits formal review summaries and inline review comments. `pr status` can say that changes were requested without showing what the reviewer asked for. This makes the documented CLI follow-up route incomplete for authors working through review feedback. ## Reproduction On main 514591a3, run `python -X utf8 -I -B scripts/forge.py pr view 277 --comments`. The issue-comments API currently returns one ordinary comment, which is shown. The review API used by `pr status` returns one formal review with a nonempty body and two inline comments. Neither the formal summary nor the inline feedback appears in view's output. The review is https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/277#issuecomment-14852. `cmd_pr` calls only `show_comments`, and that function reads `/issues/N/comments`. `pr status` separately reads `/pulls/N/reviews` but renders only verdicts. This is separate from attachment metadata visibility (#289 / PR300). ## Expected behavior With `--comments`, show the formal review verdict, summary and inline file/line feedback as well as ordinary discussion. Keep viewing read-only, avoid duplicate entries if the APIs overlap, and cover the additional GETs with the existing network-guarded fake API tests. This report does not propose changing the default view without `--comments`. ## Priority S3 contributor-workflow defect; confidence 1.0 from the CLI/API comparison and source. Reader reach is unmeasured, so no player-impact score is assigned. No fix is claimed yet.

monsterlag commented

2026-11-13 20:51:48 +00:00

Author

Claimed for a focused read-only CLI fix after checking current team claims. I will show submitted review summaries and inline file/line feedback under --comments, preserve the default view, and test request boundaries and overlap handling. The Matrix broadcast is queued for the next permitted hourly window; no --force post will be used.

monsterlag referenced this issue from a pull request that will close it,

2026-11-13 21:17:51 +00:00

fix(forge): show formal reviews and inline feedback in view #310

monsterlag commented

2026-11-13 21:21:11 +00:00

Author

Implementation is ready for review in PR310 at afc74a1f. Two interleaved live PR277 comparisons show 0 formal/0 inline on main versus 2/2 here, with all commands exiting0. Eight guarded regression methods pass; pagination covers both capped pages and repeated entries from endpoints that ignore page. Full suite497pass/3main-baseline-fail/33skip; all limits are in the PR description.

Implementation is ready for review in PR310 at afc74a1f. Two interleaved live PR277 comparisons show 0 formal/0 inline on main versus 2/2 here, with all commands exiting0. Eight guarded regression methods pass; pagination covers both capped pages and repeated entries from endpoints that ignore page. Full suite497pass/3main-baseline-fail/33skip; all limits are in the PR description.