Tool: forge.py issue view hides attached diagnostic logs #289

New issue

Open

opened 2026-11-13 19:28:52 +00:00 by monsterlag · 2 comments

monsterlag commented

2026-11-13 19:28:52 +00:00

Problem

python -I scripts/forge.py issue view N --comments omits the issue's attached files. For bug triage this makes a report appear to have no log even when it does.

Reproduction

At Longshot main 514591a3 (also present at d906c8f4), view issues 278, 261, 275 or 271 with that command. The body says the log is attached, but no attachment names or URLs are printed. The same issue GET that cmd_issue already performs returns an assets array: issue 278 has two text logs, issue 261 has a small diagnostic ZIP, and issues 275/271 also have log files. cmd_issue prints only title/state/body and optional comments, so it discards this metadata.

Expected behavior

Show the attachment names, sizes and browser_download_url links in issue view, without automatically downloading or executing anything. Keep ordinary issues with no assets working. Links remain subject to their normal access controls; showing a link must not try to bypass them.

Evidence and priority

Reproduced from the existing authenticated issue API response and the local CLI output; no game files were read or shared. This is a contributor-triage defect, not a demonstrated player crash. Confidence 1.0; affected-reader reach is unmeasured, so no player-impact score is assigned.

PR 254 adds uploading pictures to comments and PR 120 handles UTF-8 output; neither supplies issue-attachment listing. No implementation is claimed here yet.

## Problem `python -I scripts/forge.py issue view N --comments` omits the issue's attached files. For bug triage this makes a report appear to have no log even when it does. ## Reproduction At Longshot main 514591a3 (also present at d906c8f4), view issues 278, 261, 275 or 271 with that command. The body says the log is attached, but no attachment names or URLs are printed. The same issue GET that cmd_issue already performs returns an `assets` array: issue 278 has two text logs, issue 261 has a small diagnostic ZIP, and issues 275/271 also have log files. `cmd_issue` prints only title/state/body and optional comments, so it discards this metadata. ## Expected behavior Show the attachment names, sizes and `browser_download_url` links in issue view, without automatically downloading or executing anything. Keep ordinary issues with no assets working. Links remain subject to their normal access controls; showing a link must not try to bypass them. ## Evidence and priority Reproduced from the existing authenticated issue API response and the local CLI output; no game files were read or shared. This is a contributor-triage defect, not a demonstrated player crash. Confidence 1.0; affected-reader reach is unmeasured, so no player-impact score is assigned. PR 254 adds uploading pictures to comments and PR 120 handles UTF-8 output; neither supplies issue-attachment listing. No implementation is claimed here yet.

monsterlag commented

2026-11-13 20:15:36 +00:00

Author

Claimed for a focused CLI fix after checking current PRs and team claims. I will display existing API attachment metadata only, add no-attachment/comments/network-boundary regressions, and verify native Windows before/after output. Attachment access controls remain in place; no content download is part of this fix.

Amateurwizrd referenced this issue from a pull request that will close it,

2026-11-13 20:26:34 +00:00

fix(forge): issue view lists the files attached to an issue and its comments #298

monsterlag referenced this issue from a pull request that will close it,

2026-11-13 20:29:29 +00:00

WIP: fix(forge): show issue attachments in view #300

monsterlag commented

2026-11-13 20:29:56 +00:00

Author

Implemented in #300, now ready for review. Two native regression pairs reduce four non-passing cases to zero, and two live metadata-only pairs show both attached logs instead of zero rows. Full suite:497 passed,3 failures also reproduced on untouched main,33 skipped; details and limits are in the PR. No attachment content request was introduced.

Implemented in https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/300, now ready for review. Two native regression pairs reduce four non-passing cases to zero, and two live metadata-only pairs show both attached logs instead of zero rows. Full suite:497 passed,3 failures also reproduced on untouched main,33 skipped; details and limits are in the PR. No attachment content request was introduced.

monsterlag referenced this issue

2026-11-13 20:41:48 +00:00

Tool: pr view --comments omits formal review feedback #301