fix(forge): pr view --comments shows formal reviews and inline feedback #5

Open

HumanBean wants to merge 1 commit from HumanBean/Tooling:fix/pr-view-reviews into main

HumanBean commented

2026-11-15 20:51:06 +00:00

Owner

Why

forge.py pr view N --comments only showed the discussion thread. A reviewer's verdict (for example "request changes") and the inline comments explaining it were not shown, so someone following review feedback from the command line could see that a PR was blocked but not why.

What changed

scripts/forge.py: pr view N --comments now also prints each submitted review (verdict, summary, commit, marked dismissed/stale) and its inline comments (file and position, marked resolved, with links). Discussion, reviews and inline comments are all paged, overlapping entries are shown once, and paging stops when a page adds nothing new (the server repeats entries on some endpoints). Drafts and unanswered review requests are left out. issue view is unchanged.
tests/test_forge_pr.py: eight checks for the output, overlap, state filtering, locations, paging with server caps of 20 and 50, ignored page numbers, unchanged default output and API failure.
docs/forge.md: describes the added output and paging.

Ported from Longshot#310 by monsterlag, since forge.py now lives in Tooling (Tooling#1). The code is theirs; only the context lines were adapted to Tooling's layout.

Testing

No tests were run on this PC: not tests/run_all.py, not a single check. The ported tests were run by the original author against Longshot's copy of the file (see Longshot#310); they have not been run against Tooling's copy, so please run python -I -B tests/run_all.py before merging.

🤖 Generated with Claude Code

## Why `forge.py pr view N --comments` only showed the discussion thread. A reviewer's verdict (for example "request changes") and the inline comments explaining it were not shown, so someone following review feedback from the command line could see that a PR was blocked but not why. ## What changed - `scripts/forge.py`: `pr view N --comments` now also prints each submitted review (verdict, summary, commit, marked dismissed/stale) and its inline comments (file and position, marked resolved, with links). Discussion, reviews and inline comments are all paged, overlapping entries are shown once, and paging stops when a page adds nothing new (the server repeats entries on some endpoints). Drafts and unanswered review requests are left out. `issue view` is unchanged. - `tests/test_forge_pr.py`: eight checks for the output, overlap, state filtering, locations, paging with server caps of 20 and 50, ignored page numbers, unchanged default output and API failure. - `docs/forge.md`: describes the added output and paging. Ported from [Longshot#310](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/310) by monsterlag, since forge.py now lives in Tooling ([Tooling#1](https://git.magicbean.dev/MagicBeanDev/Tooling/pulls/1)). The code is theirs; only the context lines were adapted to Tooling's layout. ## Testing No tests were run on this PC: not `tests/run_all.py`, not a single check. The ported tests were run by the original author against Longshot's copy of the file (see Longshot#310); they have not been run against Tooling's copy, so please run `python -I -B tests/run_all.py` before merging. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

HumanBean added 1 commit

2026-11-15 20:51:06 +00:00

fix(forge): pr view --comments shows formal reviews and inline feedback ddc13d103a

`pr view N --comments` listed only the discussion comments, so a review's verdict and its inline comments were
missing. It now also prints the submitted reviews (verdict, summary, commit, dismissed/stale) and their inline
comments (file position, resolved), pages all three feeds and shows overlapping entries once.

Ported from Longshot#310 by monsterlag (MagicBeanDev/Longshot#310).

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

HumanBean referenced this pull request from a commit

2026-11-15 20:51:35 +00:00

chore: moved to MagicBeanDev/Tooling (https://git.magicbean.dev/MagicBeanDev/Tooling/pulls/5)

HumanBean referenced this pull request from MagicBeanDev/Longshot

2026-11-15 20:51:36 +00:00

fix(forge): show formal reviews and inline feedback in view #310

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

You are not authorized to merge this pull request.

View command line instructions