fix(cheats): a debug teleport the game dropped is sent once more, so the control bridge's teleport arrives #1046

Merged
HumanBean merged 6 commits from d4nkn3ss/Longshot:fix/teleport-resend-dropped into main 2026-11-20 22:52:12 +00:00
Contributor

Summary

The debug teleport (the Cheats page, and the control bridge's teleport, which scripted runs and testers use) sometimes doesn't happen. The game answers the request 0 and drops it: nothing reserved (Sequence_ReservedNextBanc ""), no event playing, Link where he was. The control bridge's teleport --arrive then times out, and a measured run stands in the wrong place. On this PC it was 6 of 159 scripted requests, 4 of them the first request a few frames after a save had loaded.

The follow-up 1.5 s after each request already read exactly this state, but it only logged it. Now it sends a dropped request once more, to the same destination, so the map changes and the bridge's wait sees it arrive. A request that is under way (a map reserved, an event playing, the map loading), or that has arrived, is left alone, and a resent one is never sent a third time. A press refused in between (the 8 s one-request guard) no longer cancels the resend: the follow-up checks the last request actually sent (teleport.pending), not the bridge's reply, which a refused call clears.

On main: load an adult save with HOS_OOT_CHEATS=1 and HOS_CONTROL, and as soon as it is in play python -I scripts/longshot_ctl.py --sock <pipe> teleport 3 --arrive 60; over several starts some time out, with the log's cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0.

Read first: host/oot_teleport_check.h (the decision, a pure function) and oot_teleport_followup() in host/hos_main.c; tests/test_teleport_check.py.

Testing

Tested:

  • In the game, Windows 11 Pro 26300, RTX 3080 10 GB (NVIDIA 621.14), on this head (74116b2f, the review fix): 10 starts, the first teleport (to the Market) the moment the save is in play. 9 arrived, the game reserving the Market at once, so none needed the resend. 1 did not, on the first start after the build (cold caches, 379 and 490 ms submits just after the request): result 0, then at the check reserved "", current "HyruleField_Adult", event playing 1, and no map change in the next 60 s. The follow-up leaves a request with an event playing alone, as main does, so this is unchanged here (see Risks). No device loss, VK_ERROR or FATAL line; every run closed normally.
  • In the game, same PC, on the head before the review fix (65987971): 27 starts. 25 arrived: 6 interleaved with main, 15 alone, and 4 of 6 in a first script that didn't retry a refusal (its other 2 were refused at once with "an event is playing": the game refusing, not a drop). One resend; no device loss, VK_ERROR or FATAL line; every run closed normally.
  • python -I -B tests/test_teleport_check.py: fails on main (the follow-up has no resend). On the review fix's test commit alone it fails for the review's case (FAIL: the follow-up still sends the dropped A again: 1, wanted 2), and it passes with the fix. With the follow-up's teleport.resent = 1 removed it fails too (4, wanted 2).
  • Linux (Debian 13 under WSL 2, gcc 14.2): host/hos_main.c compiles with the build's host flags (-fsyntax-only, the lifted headers of this PC's build), as on main, and python3 -I -B tests/test_teleport_check.py passes. The whole Linux host wasn't linked here.
  • python -I -B tests/run_all.py (Windows, llvm-mingw from the Longshot Builder; mise not installed here): 766 passed, 63 failed here, against 764 passed, 64 failed on main @ 89c3d21e (one more check here: test_teleport_check). The 63 are the same on both. The extra one on main, test_recording_admission, is flaky on this PC on both sides: its parallel case failed in 4 of 4 reruns here and 2 of 4 on main. test_job_queue was run from Git Bash, because started from this PowerShell it gets a Ctrl+C that ends the run: 20 of its 21 pass, Environment.test_ram_file_system fails.

Still to test:

  • Linux, any GPU: the whole host built and linked, and teleports from the Cheats page expecting each to arrive once (@Beanstalk, or by hand)

Measurements

Verdict: fixed: a dropped teleport is sent again and arrives. In 15 starts of this PR, the one request the game dropped arrived after the resend (result 0, then 0x1), and all 15 reached the Market. Main dropped 4 of 19 such first requests in that day's A/B runs, none of which arrived.

Setup: Windows 11 Pro 26300, RTX 3080 10 GB (NVIDIA 621.14), i9-12900K, 64 GB; an adult save in Hyrule Field, the first teleport (to the Market) the moment the save is in play, uncapped; one start per run, read from longshot_log.txt and the bridge's reply. Main's side is main @ 1764fed2's build; host/hos_main.c is the same at e4d035e9, which this PR was on then. Not measured again on current main (89c3d21e): between 1764fed2 and it, the teleport's request changed only in checking the guest buffers its strings are written to (hos_guest_range), and the follow-up not at all, so the numbers hold. This head's own 10 starts are in Tested.

first teleport after the save loads Before: main @ 1764fed2 After: this PR @ 47bb62b8
A/B runs (the Market first) 4 of 19 dropped, each a timeout not run
interleaved, 6 starts each 0 of 6 dropped, all arrived 0 of 6 dropped, all arrived
this PR alone, 15 starts not run 1 of 15 dropped, sent again, all 15 arrived
[hos host] control: teleport to destination 3 asked for
[hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1): request sent, result 0
[hos BaseProcExecutor1] cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0
[hos BaseProcExecutor1] cheats: teleport to Market_Adult dropped by the game (nothing reserved, no event): sent again
[hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1): request sent, result 0x1
[hos BaseProcExecutor2] cheats: teleport check: reserved "Market_Adult", current "Market_Adult", event playing 0
[hos BaseProcExecutor2] map: Market_Adult (adult)

Risks

A request the game takes more than 1.5 s to reserve, with no event playing, would be sent twice. In 159 requests every slow one had an event playing or a map reserved by then, and the six with neither never arrived until another request came. A request the game answers 0 while an event is playing, and that the event then swallows, is still not sent again: the follow-up can't tell that event from the teleport's own one under way. It happened once in this PR's last 10 starts (and is the same on main); the bridge's --arrive then times out as before. Turning it off: a revert. A player notices nothing beyond a teleport that now arrives; the log gains the sent again line when it happens.

When #823 (the expanded Teleport page) meets this, the resend has to send that request's whole target (map, spawn, boot event, carrier) rather than destination 0: whichever lands second carries that.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named).
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A fix: a game-free test that fails on main and passes here.
  • A check under tests/ that reads changed source is updated, not weakened.
  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.

🤖 Generated with Claude Code

## Summary The debug teleport (the Cheats page, and the control bridge's `teleport`, which scripted runs and testers use) sometimes doesn't happen. The game answers the request 0 and drops it: nothing reserved (`Sequence_ReservedNextBanc ""`), no event playing, Link where he was. The control bridge's `teleport --arrive` then times out, and a measured run stands in the wrong place. On this PC it was 6 of 159 scripted requests, 4 of them the first request a few frames after a save had loaded. The follow-up 1.5 s after each request already read exactly this state, but it only logged it. Now it sends a dropped request once more, to the same destination, so the map changes and the bridge's wait sees it arrive. A request that is under way (a map reserved, an event playing, the map loading), or that has arrived, is left alone, and a resent one is never sent a third time. A press refused in between (the 8 s one-request guard) no longer cancels the resend: the follow-up checks the last request actually sent (`teleport.pending`), not the bridge's reply, which a refused call clears. **On main:** load an adult save with `HOS_OOT_CHEATS=1` and `HOS_CONTROL`, and as soon as it is in play `python -I scripts/longshot_ctl.py --sock <pipe> teleport 3 --arrive 60`; over several starts some time out, with the log's `cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0`. Read first: `host/oot_teleport_check.h` (the decision, a pure function) and `oot_teleport_followup()` in `host/hos_main.c`; `tests/test_teleport_check.py`. ## Testing **Tested:** - In the game, Windows 11 Pro 26300, RTX 3080 10 GB (NVIDIA 621.14), on this head (74116b2f, the review fix): 10 starts, the first teleport (to the Market) the moment the save is in play. 9 arrived, the game reserving the Market at once, so none needed the resend. 1 did not, on the first start after the build (cold caches, 379 and 490 ms submits just after the request): `result 0`, then at the check `reserved "", current "HyruleField_Adult", event playing 1`, and no map change in the next 60 s. The follow-up leaves a request with an event playing alone, as main does, so this is unchanged here (see Risks). No device loss, `VK_ERROR` or FATAL line; every run closed normally. - In the game, same PC, on the head before the review fix (65987971): 27 starts. 25 arrived: 6 interleaved with main, 15 alone, and 4 of 6 in a first script that didn't retry a refusal (its other 2 were refused at once with "an event is playing": the game refusing, not a drop). One resend; no device loss, `VK_ERROR` or FATAL line; every run closed normally. - `python -I -B tests/test_teleport_check.py`: fails on main (the follow-up has no resend). On the review fix's test commit alone it fails for the review's case (`FAIL: the follow-up still sends the dropped A again: 1, wanted 2`), and it passes with the fix. With the follow-up's `teleport.resent = 1` removed it fails too (`4, wanted 2`). - Linux (Debian 13 under WSL 2, gcc 14.2): `host/hos_main.c` compiles with the build's host flags (`-fsyntax-only`, the lifted headers of this PC's build), as on main, and `python3 -I -B tests/test_teleport_check.py` passes. The whole Linux host wasn't linked here. - `python -I -B tests/run_all.py` (Windows, llvm-mingw from the Longshot Builder; `mise` not installed here): 766 passed, 63 failed here, against 764 passed, 64 failed on main @ 89c3d21e (one more check here: test_teleport_check). The 63 are the same on both. The extra one on main, `test_recording_admission`, is flaky on this PC on both sides: its parallel case failed in 4 of 4 reruns here and 2 of 4 on main. `test_job_queue` was run from Git Bash, because started from this PowerShell it gets a Ctrl+C that ends the run: 20 of its 21 pass, `Environment.test_ram_file_system` fails. **Still to test:** - Linux, any GPU: the whole host built and linked, and teleports from the Cheats page expecting each to arrive once (`@Beanstalk`, or by hand) ## Measurements **Verdict:** fixed: a dropped teleport is sent again and arrives. In 15 starts of this PR, the one request the game dropped arrived after the resend (`result 0`, then `0x1`), and all 15 reached the Market. Main dropped 4 of 19 such first requests in that day's A/B runs, none of which arrived. Setup: Windows 11 Pro 26300, RTX 3080 10 GB (NVIDIA 621.14), i9-12900K, 64 GB; an adult save in Hyrule Field, the first teleport (to the Market) the moment the save is in play, uncapped; one start per run, read from `longshot_log.txt` and the bridge's reply. Main's side is main @ 1764fed2's build; `host/hos_main.c` is the same at e4d035e9, which this PR was on then. Not measured again on current main (89c3d21e): between 1764fed2 and it, the teleport's request changed only in checking the guest buffers its strings are written to (`hos_guest_range`), and the follow-up not at all, so the numbers hold. This head's own 10 starts are in Tested. | first teleport after the save loads | Before: main @ 1764fed2 | After: this PR @ 47bb62b8 | |---|---|---| | A/B runs (the Market first) | 4 of 19 dropped, each a timeout | not run | | interleaved, 6 starts each | 0 of 6 dropped, all arrived | 0 of 6 dropped, all arrived | | this PR alone, 15 starts | not run | 1 of 15 dropped, sent again, all 15 arrived | ``` [hos host] control: teleport to destination 3 asked for [hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1): request sent, result 0 [hos BaseProcExecutor1] cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0 [hos BaseProcExecutor1] cheats: teleport to Market_Adult dropped by the game (nothing reserved, no event): sent again [hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1): request sent, result 0x1 [hos BaseProcExecutor2] cheats: teleport check: reserved "Market_Adult", current "Market_Adult", event playing 0 [hos BaseProcExecutor2] map: Market_Adult (adult) ``` ## Risks A request the game takes more than 1.5 s to reserve, with no event playing, would be sent twice. In 159 requests every slow one had an event playing or a map reserved by then, and the six with neither never arrived until another request came. A request the game answers 0 while an event is playing, and that the event then swallows, is still not sent again: the follow-up can't tell that event from the teleport's own one under way. It happened once in this PR's last 10 starts (and is the same on main); the bridge's `--arrive` then times out as before. Turning it off: a revert. A player notices nothing beyond a teleport that now arrives; the log gains the `sent again` line when it happens. When https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/823 (the expanded Teleport page) meets this, the resend has to send that request's whole target (map, spawn, boot event, carrier) rather than destination 0: whichever lands second carries that. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [x] `mise run test` passes (any failure that also fails on `main` is named). - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] A fix: a game-free test that fails on `main` and passes here. - [x] A check under `tests/` that reads changed source is updated, not weakened. - [x] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The debug teleport's request, sent in the first frames after a save has
loaded, is answered 0 and then dropped by the game: nothing reserved, no
event, Link where he was, and the control bridge's teleport --arrive times
out. The follow-up 1.5 s later reads exactly that and only logs it. This
check compiles the decision (host/oot_teleport_check.h) with its cases and
reads the follow-up for the resend; it fails on main.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
The debug teleport's request (the Cheats page, the control bridge's
teleport) is sometimes answered 0 and then dropped by the game: nothing
reserved, no event playing, Link where he was. In scripted runs on an RTX
3080 that was 6 of 159 requests, 4 of them the first one a few frames after
a save had loaded; the bridge's teleport --arrive then timed out and a
measured run stood in the wrong place. The follow-up 1.5 s after a request
read exactly that and only logged it.

It now sends that request once more (oot_teleport_dropped in
host/oot_teleport_check.h decides: nothing reserved, no event, the map not
loading, not there yet, not resent already), the 8 s guard set aside for it,
and logs "dropped by the game ...: sent again". A request under way or
arrived is left alone, and a resent one is not sent a third time.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
test(cheats): test_teleport_check names gcc for run_all, which has no {cc} placeholder
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
65987971ad
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

Tested in game: Windows 11, RTX 3080 (NVIDIA 621.14): 27 starts of this build, each loading a save and teleporting to the Market through the control bridge; one request dropped by the game was sent again and arrived, all 27 arrived, no device loss or errors

Tested in game: Windows 11, RTX 3080 (NVIDIA 621.14): 27 starts of this build, each loading a save and teleporting to the Market through the control bridge; one request dropped by the game was sent again and arrived, all 27 arrived, no device loss or errors
d4nkn3ss changed title from WIP: fix(cheats): a debug teleport the game dropped is sent once more, so the control bridge's teleport arrives to fix(cheats): a debug teleport the game dropped is sent once more, so the control bridge's teleport arrives 2026-11-16 04:42:28 +00:00
Author
Contributor

A correction to my in-game note above: not all 27 arrived. 25 did. The other 2 were in a first script that didn't retry a refusal, and the game refused both at once ("an event is playing"). That's the game refusing while the save's arrival plays, not a drop, and this PR doesn't change it. The 21 starts of the matching script (6 interleaved with main, then 15 alone) all arrived, one of them after the resend. The Testing section now says the same.

Posted by an AI agent (Claude Code) for d4nkn3ss.

A correction to my in-game note above: not all 27 arrived. 25 did. The other 2 were in a first script that didn't retry a refusal, and the game refused both at once ("an event is playing"). That's the game refusing while the save's arrival plays, not a drop, and this PR doesn't change it. The 21 starts of the matching script (6 interleaved with main, then 15 alone) all arrived, one of them after the resend. The Testing section now says the same. *Posted by an AI agent (Claude Code) for d4nkn3ss.*
Author
Contributor

Seen again while testing #434 (Windows 11, RTX 3080, NVIDIA 621.14), in a build of main @ 3e4e7cab with #434 merged (#434 touches only draw binding, not the teleport): a teleport to the Market (destination 3) asked for from Hyrule Field was dropped in one of about ten runs that day that teleported. The log shows the case this PR resends:

[hos host] control: teleport to destination 3 asked for
[hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1):
[hos BaseProcExecutor2] cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0

Nothing reserved, no event playing, still in Hyrule Field, and longshot_ctl teleport 3 --arrive timed out. That run's Market measurement was taken in the field and was thrown out.

Seen again while testing #434 (Windows 11, RTX 3080, NVIDIA 621.14), in a build of main @ 3e4e7cab with #434 merged (#434 touches only draw binding, not the teleport): a teleport to the Market (destination 3) asked for from Hyrule Field was dropped in one of about ten runs that day that teleported. The log shows the case this PR resends: ``` [hos host] control: teleport to destination 3 asked for [hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1): [hos BaseProcExecutor2] cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0 ``` Nothing reserved, no event playing, still in Hyrule Field, and `longshot_ctl teleport 3 --arrive` timed out. That run's Market measurement was taken in the field and was thrown out.
Member

Code-only review of 65987971ad; informational findings, with final approval left to another reviewer.

P2 — Keep the pending retry's destination separate from the last attempted request's reply (host/hos_main.c:1190). Send a teleport that the game drops, then press teleport again before its 1.5-second follow-up. The second call clears teleport.banc at line 1001 before rejecting the request under the 8-second guard. The original check_at remains armed, but the new follow-up passes NULL to oot_teleport_dropped(), which returns false, then clears the timer. The first request therefore never gets its promised retry. The clearing of the reply field is pre-existing; this PR introduces the dependency on that mutable field for retrying an earlier request. Store the pending target separately and replace it only when a new request is actually sent. Add a behavioral sequence test: sent-but-dropped A, rejected B, follow-up retries A exactly once. This is a source-derived case, not a reproduced game failure.

The predicate fixture covers individual decisions, but the follow-up check only searches source strings. It would still pass if the post-call teleport.resent = 1 were removed: oot_teleport() resets the flag, allowing repeated retries. Exercising the actual follow-up with a stubbed request would protect the once-only rule as well as the rejected-request case.

Merge coordination: the expanded Teleport page also changes this request path. Its oot_travel_place() temporarily sets place_target, calls oot_teleport(..., 0), and clears the override. Combining the branches unchanged would resend an arbitrary place as destination 0 after a drop. Preserve the complete original target (map, spawn, boot event and carrier mode) when integrating them; this is a combined-branches hazard, not a defect in this branch alone.

Existing evidence includes the author's corrected Windows report (25 arrivals in 27 starts; two immediate refusals), one successful resend and game-free checks. The declared Linux host/check and manual Cheats-page run remain outstanding. I read the full diff, request/follow-up and bridge callers, test, existing comments and relevant sibling changes. No tests, builds or game runs were performed.

Code-only review of 65987971ad175e9ae32d4b1d59dd2450d184a79a; informational findings, with final approval left to another reviewer. **P2 — Keep the pending retry's destination separate from the last attempted request's reply (`host/hos_main.c:1190`).** Send a teleport that the game drops, then press teleport again before its 1.5-second follow-up. The second call clears `teleport.banc` at line 1001 before rejecting the request under the 8-second guard. The original `check_at` remains armed, but the new follow-up passes NULL to `oot_teleport_dropped()`, which returns false, then clears the timer. The first request therefore never gets its promised retry. The clearing of the reply field is pre-existing; this PR introduces the dependency on that mutable field for retrying an earlier request. Store the pending target separately and replace it only when a new request is actually sent. Add a behavioral sequence test: sent-but-dropped A, rejected B, follow-up retries A exactly once. This is a source-derived case, not a reproduced game failure. The predicate fixture covers individual decisions, but the follow-up check only searches source strings. It would still pass if the post-call `teleport.resent = 1` were removed: `oot_teleport()` resets the flag, allowing repeated retries. Exercising the actual follow-up with a stubbed request would protect the once-only rule as well as the rejected-request case. **Merge coordination:** [the expanded Teleport page](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/823) also changes this request path. Its `oot_travel_place()` temporarily sets `place_target`, calls `oot_teleport(..., 0)`, and clears the override. Combining the branches unchanged would resend an arbitrary place as destination 0 after a drop. Preserve the complete original target (map, spawn, boot event and carrier mode) when integrating them; this is a combined-branches hazard, not a defect in this branch alone. Existing evidence includes the author's corrected Windows report (25 arrivals in 27 starts; two immediate refusals), one successful resend and game-free checks. The declared Linux host/check and manual Cheats-page run remain outstanding. I read the full diff, request/follow-up and bridge callers, test, existing comments and relevant sibling changes. No tests, builds or game runs were performed.
TrashPanda left a comment

A second press before the follow-up drops the resend. I read head 65987971. It applies onto current main. oot_teleport clears teleport.banc on entry, before the 8-second guard returns. A dropped request still has its follow-up armed. A press in that 1.5 seconds is ignored, and the follow-up then sees no destination, so it does not send the first request again. Keep the pending map and destination until a request is actually sent. The check that only searches the follow-up for teleport.resent = 1 still passes if the line after oot_teleport is removed, because the line before it remains. #823 also changes this request. Combined as they are, a dropped place would be sent again as destination 0. Keep the map, spawn, boot event and carrier when those two meet. The Linux Cheats-page teleports named in Must be tested are still open.

A second press before the follow-up drops the resend. I read head `65987971`. It applies onto current main. `oot_teleport` clears `teleport.banc` on entry, before the 8-second guard returns. A dropped request still has its follow-up armed. A press in that 1.5 seconds is ignored, and the follow-up then sees no destination, so it does not send the first request again. Keep the pending map and destination until a request is actually sent. The check that only searches the follow-up for `teleport.resent = 1` still passes if the line after `oot_teleport` is removed, because the line before it remains. https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/823 also changes this request. Combined as they are, a dropped place would be sent again as destination 0. Keep the map, spawn, boot event and carrier when those two meet. The Linux Cheats-page teleports named in Must be tested are still open.
Owner

Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).

  • Tested on my own PC: ticked: Testing's Tested and the author's Tested in game comment describe 27 starts in the game on Windows 11 with an RTX 3080.
  • Nothing gets worse that I know of: ticked: Measurements gives numbers and the possible double send is measured against 159 requests and explained in Risks.
Brought up to the [ready-for-review standard](https://git.magicbean.dev/MagicBeanDev/Longshot/src/branch/main/CONTRIBUTING.md#ready-for-review-out-of-wip) (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know). - *Tested on my own PC*: ticked: Testing's Tested and the author's Tested in game comment describe 27 starts in the game on Windows 11 with an RTX 3080. - *Nothing gets worse that I know of*: ticked: Measurements gives numbers and the possible double send is measured against 159 requests and explained in Risks.
d4nkn3ss changed title from fix(cheats): a debug teleport the game dropped is sent once more, so the control bridge's teleport arrives to WIP: fix(cheats): a debug teleport the game dropped is sent once more, so the control bridge's teleport arrives 2026-11-20 11:06:08 +00:00
Author
Contributor

Back to work in progress: the review's fix (keep the dropped request's target apart from the bridge's reply, and a sequence test of the follow-up) is done locally and goes up with the next push, then a run of it in the game before it is ready again.

Posted by an AI agent (Claude Code) for d4nkn3ss.

Back to work in progress: the review's fix (keep the dropped request's target apart from the bridge's reply, and a sequence test of the follow-up) is done locally and goes up with the next push, then a run of it in the game before it is ready again. *Posted by an AI agent (Claude Code) for d4nkn3ss.*
Co-Authored-By: Claude Opus 5.5 <[email protected]>
fix(cheats): the follow-up checks the last request sent, not the bridge's reply a refused call clears
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
74116b2f08
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

Pushed 3623460d and 74116b2f on main @ 89c3d21e (merged in, not rebased), for the review by @TrashPanda and @bibiburl:

  • A refused press no longer cancels the resend. The follow-up now checks teleport.pending, the map of the last request actually sent, set only when a request goes out. The bridge's reply, teleport.banc, which a refused call clears, is left as it was. teleport.destination was already set only for a request sent.
  • The test runs the real follow-up. tests/test_teleport_check.py has a sequence fixture now: teleport's state, the start of oot_teleport (its refusals, the 8 s guard among them), its bookkeeping of a request sent, and oot_teleport_followup, all cut from host/hos_main.c and run with the game's reads stubbed. Cases: A dropped is sent again once and not a third time; A dropped, then B refused 0.5 s later, and A is still sent again once, to A's destination; A arrived is not sent again; a refusal alone sends nothing. On the test commit alone it fails for the review's case (the follow-up still sends the dropped A again: 1, wanted 2). With the teleport.resent = 1 after the resend removed it fails as well (4, wanted 2).
  • #823: not changed here, as this branch doesn't have its place targets. When the two meet, the resend has to send the whole original target (map, spawn, boot event, carrier), not destination 0. That's now in Risks.

Back to WIP until I've run the fix in the game. The Linux build and the Cheats-page run are still in Still to test.

Posted by an AI agent (Claude Code) for d4nkn3ss.

Pushed 3623460d and 74116b2f on main @ 89c3d21e (merged in, not rebased), for the review by @TrashPanda and @bibiburl: - **A refused press no longer cancels the resend.** The follow-up now checks `teleport.pending`, the map of the last request actually sent, set only when a request goes out. The bridge's reply, `teleport.banc`, which a refused call clears, is left as it was. `teleport.destination` was already set only for a request sent. - **The test runs the real follow-up.** `tests/test_teleport_check.py` has a sequence fixture now: teleport's state, the start of `oot_teleport` (its refusals, the 8 s guard among them), its bookkeeping of a request sent, and `oot_teleport_followup`, all cut from `host/hos_main.c` and run with the game's reads stubbed. Cases: A dropped is sent again once and not a third time; A dropped, then B refused 0.5 s later, and A is still sent again once, to A's destination; A arrived is not sent again; a refusal alone sends nothing. On the test commit alone it fails for the review's case (`the follow-up still sends the dropped A again: 1, wanted 2`). With the `teleport.resent = 1` after the resend removed it fails as well (`4, wanted 2`). - **#823:** not changed here, as this branch doesn't have its place targets. When the two meet, the resend has to send the whole original target (map, spawn, boot event, carrier), not destination 0. That's now in Risks. Back to WIP until I've run the fix in the game. The Linux build and the Cheats-page run are still in Still to test. *Posted by an AI agent (Claude Code) for d4nkn3ss.*
Author
Contributor

The review fix (74116b2f) ran in the game: 10 starts on Windows 11 with an RTX 3080 (NVIDIA 621.14), the first teleport to the Market the moment the save is in play.

  • 9 of 10 arrived. The game reserved the Market at once each time, so none of them needed the resend.
  • 1 didn't arrive: the first start after the build, with cold caches. The game answered result 0, and at the check an event was playing with nothing reserved. The follow-up leaves that state alone, as main does, so it is unchanged here; Risks now says so.
  • No device loss, VK_ERROR or FATAL line, and every run closed normally.

On Linux (Debian under WSL, gcc 14.2), host/hos_main.c compiles with the build's host flags (syntax only) and tests/test_teleport_check.py passes. A full Linux build and Cheats-page teleports are left for the Test Farm.

The Measurements numbers were taken on main @ 1764fed2. They still hold on 89c3d21e: between the two, main changed only the guest-buffer bounds checks on the request's strings, and didn't touch the follow-up.

Marking it ready for review. @TrashPanda, both points from your review are in 74116b2f, as the earlier comment says.

Posted by an AI agent (Claude Code) for d4nkn3ss.

The review fix (74116b2f) ran in the game: 10 starts on Windows 11 with an RTX 3080 (NVIDIA 621.14), the first teleport to the Market the moment the save is in play. - 9 of 10 arrived. The game reserved the Market at once each time, so none of them needed the resend. - 1 didn't arrive: the first start after the build, with cold caches. The game answered `result 0`, and at the check an event was playing with nothing reserved. The follow-up leaves that state alone, as main does, so it is unchanged here; Risks now says so. - No device loss, `VK_ERROR` or FATAL line, and every run closed normally. On Linux (Debian under WSL, gcc 14.2), `host/hos_main.c` compiles with the build's host flags (syntax only) and `tests/test_teleport_check.py` passes. A full Linux build and Cheats-page teleports are left for the Test Farm. The Measurements numbers were taken on main @ 1764fed2. They still hold on 89c3d21e: between the two, main changed only the guest-buffer bounds checks on the request's strings, and didn't touch the follow-up. Marking it ready for review. @TrashPanda, both points from your review are in 74116b2f, as the earlier comment says. *Posted by an AI agent (Claude Code) for d4nkn3ss.*
d4nkn3ss changed title from WIP: fix(cheats): a debug teleport the game dropped is sent once more, so the control bridge's teleport arrives to fix(cheats): a debug teleport the game dropped is sent once more, so the control bridge's teleport arrives 2026-11-20 15:21:50 +00:00
HumanBean left a comment

Recommendation: Approve. It fixes the dropped debug teleport where it happens, in the host's follow-up, and it resolves both of TrashPanda's code points. A resend can't fire during an event, a load or an arrival, or go out a second time. Players never arm this path. Recommend approval; not approved on the forge.

For testers and scripted runs (the Cheats page, longshot_ctl teleport --arrive, the tours and dev.py ab), the game sometimes drops a teleport (result 0, nothing reserved, no event). The host now sends that request once more 1.5 s later, so it arrives and no longer times out. The code gets better: the follow-up already read this state and only logged it. The cost is 25 lines in a debug path and a pure, tested predicate.

Does it help: Yes, by the author's runs (Windows 11, RTX 3080, NVIDIA 621.14). The first teleport after a save loads: main dropped 4 of 19 in the day's A/B runs, and none of those arrived. This PR: 1 of 15 was dropped, sent again, and all 15 arrived. On the review-fix head 74116b2f there were 10 starts: 9 arrived without needing the resend, and 1 was the event-playing case the PR leaves alone, as main does (Risks). The counts are small, but the effect is binary (arrives or times out) and the log shows the resend working.
Other systems: This is debug-only. check_at is armed only by oot_teleport, and only the Cheats page, the control bridge and the age toggle call that, so a player without those never reaches the resend. Its state is touched only under cheats_lock (hos_oot_lift_player). The logic is OS- and GPU-independent C with no new game call beyond Sequence_IsLoadingBanc, which oot_teleport already reads. Linux was compiled syntax-only, not linked. The bridge's reply (accepted, map) is computed from the original call and is unchanged. The age toggle's resend goes through oot_teleport, not oot_toggle_age, so the age is not flipped twice.
Switches: none.

Reviewed: 74116b2f08 against 89c3d21ea1 (main's parent of the merge 7d49aef455; host/hos_main.c is unchanged on main since, up to 3df5c13ed2). I read in full host/oot_teleport_check.h, tests/test_teleport_check.py, and in host/hos_main.c: teleport, oot_teleport, oot_toggle_age, oot_teleport_followup, oot_bridge_teleport_done, oot_update_player_cheats up to the action dispatch, and hos_oot_lift_player's lock. I also read sibling #1922's diff and map_change in scripts/tours/drive.py. Nothing was run (a code review).
Fixed in this review: nothing.
Checked and fine:

  • TrashPanda's point 1 (a refused press cancels the resend): resolved. The follow-up reads teleport.pending, which is set only after a request goes out (ok ? banc : NULL). A refusal clears only banc/why, the bridge's reply. destination was already set only on a send.
  • TrashPanda's point 2 (the once-only check was text-only): resolved. The sequence fixture runs the real oot_teleport prelude, its bookkeeping and the follow-up. The author reports that it fails with the post-call teleport.resent = 1 removed (4, wanted 2) and for the refused-B case on the test commit alone.
  • Can it fire during a cutscene, a load or a save? It won't fire during a cutscene or a load. The predicate returns 0 when an event is playing (EventMgr+104) or a map is loading. If either begins between the check and the send, oot_teleport's own refusals (event playing, loading, no event manager) refuse the resend. The follow-up runs only from Link's update, i.e. in play. A save adds no new exposure: the resend is one request 1.5 s after the user's own, under the same refusals a manual press has.
  • Can it double-teleport? Not from the PR itself. pending is set only when a request is sent, and an arrived request (current == wanted) is left alone, as is one under way (map reserved). resent survives the resend's own oot_teleport (set again after the call), so there is never a third send. The resend restarts the 8 s guard at its own time, so a press right after it is refused as usual. A refused resend leaves check_at 0, so nothing loops. The only remaining double is the slow reserve (>1.5 s with no event and nothing reserved), which Risks states and measures as not seen in 159 requests.
  • pending points into the static oot_destinations strings, so its lifetime is fine. next/current are now initialised, so a failed read compares "", not stack garbage.
  • A same-map teleport (the tours' underwater reload) that the game drops is not resent, because current == wanted reads as arrived. That is unchanged from main.
  • It has a game-free test, failing on main and passing here per the author. One topic. Conventional Commit title.

Suggestions (the author may take or leave)

  • host/hos_main.c:1261: the predicate could also require teleport.result == 0. Every drop in the description was answered 0, and a request the event manager took (accepted: true) is the one most likely to be merely slow to reserve. That would narrow the only double-send case in Risks at no cost.
  • tests/test_teleport_check.py: the sequence fixture stubs the event-playing and loading reads to 0. So if the follow-up passed the wrong value into oot_teleport_dropped, the "no resend during a cutscene/load" rule would only be covered by the predicate's own cases, not end to end. One sequence case with an event playing at the check (expect 1 send) would close that.
  • host/hos_main.c:1263: the first teleport.resent = 1; before the call is redundant. A send resets it and the line after sets it again, and a refusal leaves check_at 0. It is harmless.

Testing: The author ran 27 + 10 starts in the game on Windows 11 with an RTX 3080 (above), and reports the test failing on main and passing here, plus a Linux syntax-only compile under WSL. Still missing are the full Linux build with Cheats-page teleports (in Still to test; @Beanstalk or by hand) and CI: its jobs show "Blocked by required conditions" on 74116b2f. Neither should change the result, since the logic is platform-independent, but CI must pass before merge.
Overlaps and merge order:

  • #1922 (the tours driver waits 5 s, not 60 s, after accepted: false). The two address the same symptom at different layers. This PR fixes the cause at the host, for every caller. The other one shortens the driver's wait. They are not duplicates, but they do not compose cleanly as they stand. With both merged, a dropped request (accepted false at t=0) is resent by the host at 1.5 s, and its arrival can land after 1922's 5 s wait. The driver then counts it unmoved, asks again, waits out the 8 s guard that the resend restarted, and teleports a second time into the map Link has just reached. Merge this one first. 1922 should then check the state before each re-ask (or treat the cooldown refusal and a load in progress as "in flight"), or keep NOT_TAKEN_S above the host's 1.5 s resend plus a load. Its own case (the event-swallowed drop this PR leaves alone) is still worth keeping.
  • #823 (the Teleport page's places): whichever merges second must resend the whole place target, not destination 0. This is already in Risks.
**Recommendation: Approve.** It fixes the dropped debug teleport where it happens, in the host's follow-up, and it resolves both of TrashPanda's code points. A resend can't fire during an event, a load or an arrival, or go out a second time. Players never arm this path. Recommend approval; not approved on the forge. For testers and scripted runs (the Cheats page, `longshot_ctl teleport --arrive`, the tours and `dev.py ab`), the game sometimes drops a teleport (result 0, nothing reserved, no event). The host now sends that request once more 1.5 s later, so it arrives and no longer times out. The code gets better: the follow-up already read this state and only logged it. The cost is 25 lines in a debug path and a pure, tested predicate. **Does it help:** Yes, by the author's runs (Windows 11, RTX 3080, NVIDIA 621.14). The first teleport after a save loads: main dropped 4 of 19 in the day's A/B runs, and none of those arrived. This PR: 1 of 15 was dropped, sent again, and all 15 arrived. On the review-fix head 74116b2f there were 10 starts: 9 arrived without needing the resend, and 1 was the event-playing case the PR leaves alone, as main does (Risks). The counts are small, but the effect is binary (arrives or times out) and the log shows the resend working. **Other systems:** This is debug-only. `check_at` is armed only by `oot_teleport`, and only the Cheats page, the control bridge and the age toggle call that, so a player without those never reaches the resend. Its state is touched only under `cheats_lock` (`hos_oot_lift_player`). The logic is OS- and GPU-independent C with no new game call beyond `Sequence_IsLoadingBanc`, which `oot_teleport` already reads. Linux was compiled syntax-only, not linked. The bridge's reply (`accepted`, `map`) is computed from the original call and is unchanged. The age toggle's resend goes through `oot_teleport`, not `oot_toggle_age`, so the age is not flipped twice. **Switches:** none. **Reviewed:** 74116b2f08 against 89c3d21ea1 (main's parent of the merge 7d49aef455; `host/hos_main.c` is unchanged on main since, up to 3df5c13ed2). I read in full `host/oot_teleport_check.h`, `tests/test_teleport_check.py`, and in `host/hos_main.c`: `teleport`, `oot_teleport`, `oot_toggle_age`, `oot_teleport_followup`, `oot_bridge_teleport_done`, `oot_update_player_cheats` up to the action dispatch, and `hos_oot_lift_player`'s lock. I also read sibling https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1922's diff and `map_change` in `scripts/tours/drive.py`. Nothing was run (a code review). **Fixed in this review:** nothing. **Checked and fine:** - **TrashPanda's point 1 (a refused press cancels the resend):** resolved. The follow-up reads `teleport.pending`, which is set only after a request goes out (`ok ? banc : NULL`). A refusal clears only `banc`/`why`, the bridge's reply. `destination` was already set only on a send. - **TrashPanda's point 2 (the once-only check was text-only):** resolved. The sequence fixture runs the real `oot_teleport` prelude, its bookkeeping and the follow-up. The author reports that it fails with the post-call `teleport.resent = 1` removed (4, wanted 2) and for the refused-B case on the test commit alone. - **Can it fire during a cutscene, a load or a save?** It won't fire during a cutscene or a load. The predicate returns 0 when an event is playing (`EventMgr+104`) or a map is loading. If either begins between the check and the send, `oot_teleport`'s own refusals (event playing, loading, no event manager) refuse the resend. The follow-up runs only from Link's update, i.e. in play. A save adds no new exposure: the resend is one request 1.5 s after the user's own, under the same refusals a manual press has. - **Can it double-teleport?** Not from the PR itself. `pending` is set only when a request is sent, and an arrived request (`current == wanted`) is left alone, as is one under way (map reserved). `resent` survives the resend's own `oot_teleport` (set again after the call), so there is never a third send. The resend restarts the 8 s guard at its own time, so a press right after it is refused as usual. A refused resend leaves `check_at` 0, so nothing loops. The only remaining double is the slow reserve (>1.5 s with no event and nothing reserved), which Risks states and measures as not seen in 159 requests. - `pending` points into the static `oot_destinations` strings, so its lifetime is fine. `next`/`current` are now initialised, so a failed read compares `""`, not stack garbage. - A same-map teleport (the tours' underwater reload) that the game drops is not resent, because `current == wanted` reads as arrived. That is unchanged from main. - It has a game-free test, failing on main and passing here per the author. One topic. Conventional Commit title. **Suggestions** (the author may take or leave) - `host/hos_main.c:1261`: the predicate could also require `teleport.result == 0`. Every drop in the description was answered 0, and a request the event manager took (`accepted: true`) is the one most likely to be merely slow to reserve. That would narrow the only double-send case in Risks at no cost. - `tests/test_teleport_check.py`: the sequence fixture stubs the event-playing and loading reads to 0. So if the follow-up passed the wrong value into `oot_teleport_dropped`, the "no resend during a cutscene/load" rule would only be covered by the predicate's own cases, not end to end. One sequence case with an event playing at the check (expect 1 send) would close that. - `host/hos_main.c:1263`: the first `teleport.resent = 1;` before the call is redundant. A send resets it and the line after sets it again, and a refusal leaves `check_at` 0. It is harmless. **Testing:** The author ran 27 + 10 starts in the game on Windows 11 with an RTX 3080 (above), and reports the test failing on main and passing here, plus a Linux syntax-only compile under WSL. Still missing are the full Linux build with Cheats-page teleports (in Still to test; `@Beanstalk` or by hand) and CI: its jobs show "Blocked by required conditions" on 74116b2f. Neither should change the result, since the logic is platform-independent, but CI must pass before merge. **Overlaps and merge order:** - https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1922 (the tours driver waits 5 s, not 60 s, after `accepted: false`). The two address the same symptom at different layers. This PR fixes the cause at the host, for every caller. The other one shortens the driver's wait. They are not duplicates, but they do not compose cleanly as they stand. With both merged, a dropped request (accepted false at t=0) is resent by the host at 1.5 s, and its arrival can land after 1922's 5 s wait. The driver then counts it unmoved, asks again, waits out the 8 s guard that the resend restarted, and teleports a second time into the map Link has just reached. Merge this one first. 1922 should then check the state before each re-ask (or treat the cooldown refusal and a load in progress as "in flight"), or keep `NOT_TAKEN_S` above the host's 1.5 s resend plus a load. Its own case (the event-swallowed drop this PR leaves alone) is still worth keeping. - https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/823 (the Teleport page's places): whichever merges second must resend the whole place target, not destination 0. This is already in Risks.
@ -1251,0 +1260,4 @@
the control bridge's wait for the map sees it arrive. oot_teleport_check.h) */
if (oot_teleport_dropped(next, current, teleport.pending, playing, loading, teleport.resent)) {
hos_log("cheats: teleport to %s dropped by the game (nothing reserved, no event): sent again", teleport.pending);
teleport.requested_at = 0;
Owner

Nit: this first resent = 1 is redundant. A send resets it and the line after the call sets it again, and a refused resend leaves check_at 0.

Nit: this first resent = 1 is redundant. A send resets it and the line after the call sets it again, and a refused resend leaves check_at 0.
@ -1251,0 +1258,4 @@
hos_log("cheats: teleport check: reserved \"%s\", current \"%s\", event playing %d", next, current, playing);
/* (dropped by the game, as a request a few frames after a save has loaded is: sent once more, the 8 s guard aside, so
the control bridge's wait for the map sees it arrive. oot_teleport_check.h) */
if (oot_teleport_dropped(next, current, teleport.pending, playing, loading, teleport.resent)) {
Owner

Suggestion: also require teleport.result == 0 here. Every drop in the description was answered 0, and a request the event manager took is the one most likely to be only slow to reserve, which is the double-send case in Risks.

Suggestion: also require teleport.result == 0 here. Every drop in the description was answered 0, and a request the event manager took is the one most likely to be only slow to reserve, which is the double-send case in Risks.
HumanBean deleted branch fix/teleport-resend-dropped 2026-11-20 22:52:13 +00:00
Author
Contributor

@HumanBean thank you for the review. All three suggestions are taken, but this merged at 74116b2f before they were in, so they're in a follow-up: #1950.

  • The follow-up also needs the request to have been answered 0.
  • The redundant resent = 1 is gone.
  • The sequence fixture now reads the event manager, the loading flag and the answer, so the follow-up's own reads are covered end to end.

It's mutation-checked, and it ran in the game: 6 first teleports, each answered 0x1 and none sent again; on this head with the same change, 10 starts with one drop resent and arrived.

On #1922 (merged too): arrivals take 7-9 s here, longer than its 5 s wait. After a host resend, the driver can ask again once the 8 s guard ends and reload the map Link just reached. I'm looking at that next.

Posted by an AI agent (Claude Code) for d4nkn3ss.

@HumanBean thank you for the review. All three suggestions are taken, but this merged at 74116b2f before they were in, so they're in a follow-up: #1950. - The follow-up also needs the request to have been answered 0. - The redundant `resent = 1` is gone. - The sequence fixture now reads the event manager, the loading flag and the answer, so the follow-up's own reads are covered end to end. It's mutation-checked, and it ran in the game: 6 first teleports, each answered 0x1 and none sent again; on this head with the same change, 10 starts with one drop resent and arrived. On #1922 (merged too): arrivals take 7-9 s here, longer than its 5 s wait. After a host resend, the driver can ask again once the 8 s guard ends and reload the map Link just reached. I'm looking at that next. *Posted by an AI agent (Claude Code) for d4nkn3ss.*
Author
Contributor

Correction to my comment above: arrivals take 3.0 to 3.9 s of wall time here (4 timed first teleports on the RTX 3080), not 7-9 s. I had counted frames at 60 a second, and these runs present at 100-200.

So a request the host resends at 1.5 s arrives at about 5 s, right at #1922's 5 s wait. The driver also reads the map when its wait runs out, so a second teleport needs the arrival to land just after that read: a narrow window, not the common case. Unless someone has seen it in a run, I'll leave #1922 as merged and not change the driver.

Posted by an AI agent (Claude Code) for d4nkn3ss.

Correction to my comment above: arrivals take 3.0 to 3.9 s of wall time here (4 timed first teleports on the RTX 3080), not 7-9 s. I had counted frames at 60 a second, and these runs present at 100-200. So a request the host resends at 1.5 s arrives at about 5 s, right at #1922's 5 s wait. The driver also reads the map when its wait runs out, so a second teleport needs the arrival to land just after that read: a narrow window, not the common case. Unless someone has seen it in a run, I'll leave #1922 as merged and not change the driver. *Posted by an AI agent (Claude Code) for d4nkn3ss.*
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1046
No description provided.