fix(cheats): the teleport follow-up doesn't send again a request the game took (answered other than 0) #1950

Open
d4nkn3ss wants to merge 4 commits from d4nkn3ss/Longshot:fix/teleport-resend-answered into main
Contributor

Summary

The debug teleport's follow-up (#1046) sends a request the game dropped once more. It reads "dropped" as nothing reserved, no event playing and Link still elsewhere, 1.5 s after the request. Every drop seen was answered 0 by the game's event manager. A request it answered other than 0 was taken and is only slow to reserve, and resending that one would teleport twice: the one double-send case #1046's Risks named.

Now the follow-up also needs the answer to have been 0. The redundant teleport.resent = 1 before the resend goes (the line after the call sets it), and the log line says answered 0. These are HumanBean's three suggestions in the review of #1046, which merged before they were in.

Changed in review (BeanBot):

  • The check runs the host's own bookkeeping: its cut goes on through teleport.result = result;, with the stand-in's answer as the request's result, so a host that saved 0 for a taken request fails it.
  • The follow-up logs sending it again, and when oot_teleport refuses the resend, not sent again: <why>.
  • The check's --cc defaults to $CC, else gcc, and run_all no longer forces gcc.
  • main merged in (00e0dc93, which builds again with #1949).

On main: a request the event manager answers 1 that hasn't reserved its map 1.5 s later is sent again. In tests/test_teleport_check.py's new case, a request the game took is not sent again: 2, wanted 1.

Read first: oot_teleport_dropped() in host/oot_teleport_check.h and its call in oot_teleport_followup() (host/hos_main.c); then the sequence cases in tests/test_teleport_check.py.

See #1046.

Testing

Tested:

  • python -I -B tests/test_teleport_check.py: the test commit alone fails on main (FAIL: a request the game took is not sent again: 2, wanted 1), and its event-playing and map-loading cases pass there. With the fix it passes, with gcc and clang.
    • The sequence fixture now reads an event manager, the loading flag and the request's answer, so the follow-up's own reads are covered end to end, not only by the predicate's cases.
    • It fails when the follow-up passes 0 for the event, for the loading flag or for the answer, when the predicate ignores the answer, when the resend's teleport.resent = 1 after the call is removed, and (on 44290f4f) when the host's bookkeeping saves 0 as the answer (teleport.result = 0;). With CC=clang and no --cc it runs with clang.
  • In the game, Windows 11 Pro 26300, RTX 3080 10 GB (NVIDIA 621.14), this head (04c69f69, on main @ 00e0dc93): an adult save in Hyrule Field, the first teleport to the Market the moment the save is in play. 6 starts: all arrived, each answered 0x1, none sent again (3 had the Market reserved and arrived at the check, 3 had it reserved with the arrival's event playing). No device loss, VK_ERROR or FATAL line; every run closed normally.
  • The same, on 44458371 (before review), with #1949's one line added locally since main @ fc4a6769 didn't build: 6 starts: all arrived. Each request was answered 0x1 and none was sent again (5 had the Market reserved at the check, 1 had the teleport's own event playing). None was dropped in these 6; the resend of a dropped one is in the next item. No device loss, VK_ERROR or FATAL line; every run closed normally.
  • The same change on #1046's own head (7dfcdfbb, main @ 89c3d21e): 10 starts, all arrived. In 1 the game dropped the request (result 0), it was sent again (result 0x1) and arrived. In 2 an event was playing at the check (the teleport's own), so it was left alone and arrived. No device loss, VK_ERROR or FATAL line.
  • Linux (Debian 13 under WSL 2, gcc 14.2), this head: host/hos_main.c compiles with the build's host flags (-fsyntax-only), and the check passes there. The Linux host wasn't linked or run here.
  • The 60 checks that read host/hos_main.c, this head against main @ 00e0dc93 (tests/run_all.py; mise isn't installed here): 44 passed and 16 failed on both, the same 16: test_bug_report_defaults, test_crash_dialog, test_crash_record, test_display_startup_failure, test_driver_cache_folder, test_driver_env_choose, test_host_guest_writes, test_lift_cache, test_log_open_failure, test_mods_list, test_perf_report, test_pipeline_tour, test_profiling_mode, test_slow_frames, test_udmabuf_limit_unreadable, test_udmabuf_warning. The rest of the suite reads no changed file.

Still to test:

  • Linux, any GPU: load a save and send the first debug teleport at once, expecting it to arrive, and a result 0 drop, if any, sent again once (@Beanstalk Linux: the first debug teleport after a save loads, several starts)

Measurements

Nothing to measure: a debug-only path, and the in-game runs in Tested show it still sends a dropped request again. A request the game took but was slow to reserve wasn't seen in these runs, so its case is shown by the check.

Risks

A request answered other than 0 that the game still drops is no longer sent again, and the control bridge's --arrive times out on it as before #1046. None was seen: every drop in #1046's 159 requests and in these runs was answered 0. Players never reach this path (the Cheats page, the control bridge and the age switch only). Turning it off: a revert.

As in #1046: when #823 (the expanded Teleport page, still open) meets the resend, the resend has to send that request's whole target (map, spawn, boot event, carrier) rather than destination 0. Whichever lands second carries that.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named).
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A fix: a game-free test that fails on main and passes here.
  • A check under tests/ that reads changed source is updated, not weakened.
  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.

🤖 Generated with Claude Code

## Summary The debug teleport's follow-up (#1046) sends a request the game dropped once more. It reads "dropped" as nothing reserved, no event playing and Link still elsewhere, 1.5 s after the request. Every drop seen was answered 0 by the game's event manager. A request it answered other than 0 was taken and is only slow to reserve, and resending that one would teleport twice: the one double-send case #1046's Risks named. Now the follow-up also needs the answer to have been 0. The redundant `teleport.resent = 1` before the resend goes (the line after the call sets it), and the log line says `answered 0`. These are HumanBean's three suggestions in the review of #1046, which merged before they were in. **Changed in review (BeanBot):** - The check runs the host's own bookkeeping: its cut goes on through `teleport.result = result;`, with the stand-in's answer as the request's `result`, so a host that saved 0 for a taken request fails it. - The follow-up logs `sending it again`, and when `oot_teleport` refuses the resend, `not sent again: <why>`. - The check's `--cc` defaults to `$CC`, else gcc, and `run_all` no longer forces gcc. - main merged in (00e0dc93, which builds again with #1949). **On main:** a request the event manager answers 1 that hasn't reserved its map 1.5 s later is sent again. In `tests/test_teleport_check.py`'s new case, `a request the game took is not sent again: 2, wanted 1`. Read first: `oot_teleport_dropped()` in `host/oot_teleport_check.h` and its call in `oot_teleport_followup()` (`host/hos_main.c`); then the sequence cases in `tests/test_teleport_check.py`. See #1046. ## Testing **Tested:** - `python -I -B tests/test_teleport_check.py`: the test commit alone fails on main (`FAIL: a request the game took is not sent again: 2, wanted 1`), and its event-playing and map-loading cases pass there. With the fix it passes, with gcc and clang. - The sequence fixture now reads an event manager, the loading flag and the request's answer, so the follow-up's own reads are covered end to end, not only by the predicate's cases. - It fails when the follow-up passes 0 for the event, for the loading flag or for the answer, when the predicate ignores the answer, when the resend's `teleport.resent = 1` after the call is removed, and (on 44290f4f) when the host's bookkeeping saves 0 as the answer (`teleport.result = 0;`). With `CC=clang` and no `--cc` it runs with clang. - In the game, Windows 11 Pro 26300, RTX 3080 10 GB (NVIDIA 621.14), this head (04c69f69, on main @ 00e0dc93): an adult save in Hyrule Field, the first teleport to the Market the moment the save is in play. 6 starts: all arrived, each answered `0x1`, none sent again (3 had the Market reserved and arrived at the check, 3 had it reserved with the arrival's event playing). No device loss, `VK_ERROR` or FATAL line; every run closed normally. - The same, on 44458371 (before review), with #1949's one line added locally since main @ fc4a6769 didn't build: 6 starts: all arrived. Each request was answered `0x1` and none was sent again (5 had the Market reserved at the check, 1 had the teleport's own event playing). None was dropped in these 6; the resend of a dropped one is in the next item. No device loss, `VK_ERROR` or FATAL line; every run closed normally. - The same change on #1046's own head (7dfcdfbb, main @ 89c3d21e): 10 starts, all arrived. In 1 the game dropped the request (`result 0`), it was sent again (`result 0x1`) and arrived. In 2 an event was playing at the check (the teleport's own), so it was left alone and arrived. No device loss, `VK_ERROR` or FATAL line. - Linux (Debian 13 under WSL 2, gcc 14.2), this head: `host/hos_main.c` compiles with the build's host flags (`-fsyntax-only`), and the check passes there. The Linux host wasn't linked or run here. - The 60 checks that read `host/hos_main.c`, this head against main @ 00e0dc93 (`tests/run_all.py`; `mise` isn't installed here): 44 passed and 16 failed on both, the same 16: test_bug_report_defaults, test_crash_dialog, test_crash_record, test_display_startup_failure, test_driver_cache_folder, test_driver_env_choose, test_host_guest_writes, test_lift_cache, test_log_open_failure, test_mods_list, test_perf_report, test_pipeline_tour, test_profiling_mode, test_slow_frames, test_udmabuf_limit_unreadable, test_udmabuf_warning. The rest of the suite reads no changed file. **Still to test:** - Linux, any GPU: load a save and send the first debug teleport at once, expecting it to arrive, and a `result 0` drop, if any, sent again once (`@Beanstalk Linux: the first debug teleport after a save loads, several starts`) ## Measurements Nothing to measure: a debug-only path, and the in-game runs in Tested show it still sends a dropped request again. A request the game took but was slow to reserve wasn't seen in these runs, so its case is shown by the check. ## Risks A request answered other than 0 that the game still drops is no longer sent again, and the control bridge's `--arrive` times out on it as before #1046. None was seen: every drop in #1046's 159 requests and in these runs was answered 0. Players never reach this path (the Cheats page, the control bridge and the age switch only). Turning it off: a revert. As in #1046: when https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/823 (the expanded Teleport page, still open) meets the resend, the resend has to send that request's whole target (map, spawn, boot event, carrier) rather than destination 0. Whichever lands second carries that. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [x] `mise run test` passes (any failure that also fails on `main` is named). - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] A fix: a game-free test that fails on `main` and passes here. - [x] A check under `tests/` that reads changed source is updated, not weakened. - [x] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The sequence fixture now reads an event manager, the loading flag and the request's answer, set per case.

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <[email protected]>
fix(cheats): the teleport follow-up doesn't send again a request the game took (answered other than 0)
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 7s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
44458371a2
Every dropped request was answered 0; one the event manager took may only be slow to reserve, which was the one
double-send case left. The first `teleport.resent = 1` before the resend went: the line after the call sets it.
The decision's own cases gain the answer.

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

Tested in game: Windows 11 Pro 26300, RTX 3080 10 GB (NVIDIA 621.14), with #1949's line added locally (main doesn't build without it): 6 first teleports after a save loads, all arrived, each answered 0x1 and none sent again. On #1046's head with the same change: 10 starts, all arrived, the one drop (result 0) sent again and arrived.

Tested in game: Windows 11 Pro 26300, RTX 3080 10 GB (NVIDIA 621.14), with #1949's line added locally (main doesn't build without it): 6 first teleports after a save loads, all arrived, each answered 0x1 and none sent again. On #1046's head with the same change: 10 starts, all arrived, the one drop (result 0) sent again and arrived.
BeanBot left a comment

Recommendation: Request changes. Using the event manager’s answer prevents a second request when an accepted debug teleport is slow to reserve its map. The regression test bypasses the host code that saves that answer, and the updated log can report a resend that failed.

The Cheats page, age switch and control bridge now leave accepted requests alone. A request answered 0 still gets one retry if the destination is unreserved, no event or load is active, and Link is elsewhere. The fix reuses the existing result and removes a redundant write.

Does it help: Yes. The author reports 2 sends on the merge base with the test-only commit and 1 send with the fix for a simulated accepted request. On Windows with the #1949 build fix added, 6 of 6 first teleports arrived, with 0 resends. All 6 had already reserved the map or had an event playing at the check. On the older #1046 head with this fix applied, 1 of 10 requests was dropped, retried and arrived. The slow accepted case was demonstrated only by the fixture.
Other systems: The Cheats page and age switch share the retry rule. The bridge still publishes the original acceptance result, and its clients still wait for arrival. An accepted request that never arrives now relies on the caller’s timeout. The new branch has no GPU-specific code, but the 1.5 s deadline is wall-clock time. The reported runs cover Windows/NVIDIA in game and Linux under WSL for compilation and the fixture. The diff adds no renderer, allocation, save-format, audio, input or launcher work.
Switches: None.

Reviewed: 44458371a2 against fc4a6769fd: Read AGENTS.md, CONTRIBUTING.md, docs/dev/standards.md, the Forgejo template, both commits and the complete diff. Read host/oot_teleport_check.h and tests/test_teleport_check.py in full, plus the teleport, age-switch, state, lock and caller code in host/hos_main.c. Traced the bridge reply, CLI and tour waits, source extraction, suite discovery and minimap fixture. Skimmed unrelated host code, CI configuration and the recorded runs in the PR, author comment and #1046 history. No local review checklist or sibling Tooling checkout was present.; nothing run (a code review).
Checked and fine:

  • The player-update lock serializes access to teleport state across guest workers. The bridge reads a separate reply under oot_map_lock.
  • Refused intervening calls leave the pending request and its answer intact. A request that could not be built has no pending destination.
  • The result reaches the predicate without narrowing on Windows or Linux. The change introduces no new pointer arithmetic, buffer writes, per-thread storage or cleanup obligations.
  • The fixture exercises the changed predicate and follow-up, including the event and load guards and the one-resend limit. Its C code reads no game switches from the environment.
  • The diff is on one topic. Both commits carry AI trailers. The patch contains authored source and fixtures, with no game-derived artifacts, generated files, third-party changes or renderer API changes.

Blocking (to change before merge)

  1. tests/test_teleport_check.py:83: The fixture assigns teleport.result itself because @​SENT@ stops before the production assignment. If the host stored 0 for an accepted request, the game would send it twice while this fixture would still pass. Feed the mocked answer into the result local and include the real bookkeeping tail in the fixture.
  2. host/hos_main.c:1262: The updated log says “sent again” before oot_teleport can report whether it sent anything. If the event manager is unavailable at the check, playing is false and the retry can qualify, but oot_teleport then refuses it. Log a retry attempt here, or report success or refusal using the call’s return value.
  3. tests/test_teleport_check.py:12: The direct invocation and suite declaration both force gcc and ignore CC. On a Windows llvm-mingw setup with clang and no gcc on PATH, the strict suite can fail before this regression test runs even with CC set. Make compiler selection honor CC, retain the explicit --cc override, and let the suite use that selection with a supported fallback.

Waiting on the author (a run, a measurement or a decision; no edit does it)

  • The full-test box is checked, but the PR reports only the focused check passing and gives no strict suite result or head CI result. The unchanged checks can still read changed source. Record a strict full-suite result for the revised head, name any failures reproduced on main, and confirm head CI before merge.
  • The only reported result-0 retry was on the older #1046 head, and Linux coverage is WSL compilation and a fixture. Update Still to test and record a native Tier 1 Linux run, such as Steam Deck/RADV, on the revised head with current main. Check that the first debug teleport after loading a save arrives, and record whether any result-0 request needed and got its single retry.

Testing: Read-only review. The author reports GCC and Clang passes and failures when the predicate or follow-up ignores the answer. The reported Windows runs and WSL compile were used as evidence.
Overlaps and merge order: #1949 is already on the checkout’s main as ae8e78b0, after #1946. Use that main for the next build and test. #1046 is already merged and records a potential overlap with #823. Verify #823’s status before merging it. If it replaces destination indexes with full teleport targets, whichever lands second must preserve the full target on retry.


Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** Using the event manager’s answer prevents a second request when an accepted debug teleport is slow to reserve its map. The regression test bypasses the host code that saves that answer, and the updated log can report a resend that failed. The Cheats page, age switch and control bridge now leave accepted requests alone. A request answered 0 still gets one retry if the destination is unreserved, no event or load is active, and Link is elsewhere. The fix reuses the existing result and removes a redundant write. **Does it help:** Yes. The author reports 2 sends on the merge base with the test-only commit and 1 send with the fix for a simulated accepted request. On Windows with the #1949 build fix added, 6 of 6 first teleports arrived, with 0 resends. All 6 had already reserved the map or had an event playing at the check. On the older #1046 head with this fix applied, 1 of 10 requests was dropped, retried and arrived. The slow accepted case was demonstrated only by the fixture. **Other systems:** The Cheats page and age switch share the retry rule. The bridge still publishes the original acceptance result, and its clients still wait for arrival. An accepted request that never arrives now relies on the caller’s timeout. The new branch has no GPU-specific code, but the 1.5 s deadline is wall-clock time. The reported runs cover Windows/NVIDIA in game and Linux under WSL for compilation and the fixture. The diff adds no renderer, allocation, save-format, audio, input or launcher work. **Switches:** None. **Reviewed:** 44458371a21e against fc4a6769fd69: Read AGENTS.md, CONTRIBUTING.md, docs/dev/standards.md, the Forgejo template, both commits and the complete diff. Read host/oot_teleport_check.h and tests/test_teleport_check.py in full, plus the teleport, age-switch, state, lock and caller code in host/hos_main.c. Traced the bridge reply, CLI and tour waits, source extraction, suite discovery and minimap fixture. Skimmed unrelated host code, CI configuration and the recorded runs in the PR, author comment and #1046 history. No local review checklist or sibling Tooling checkout was present.; nothing run (a code review). **Checked and fine:** - The player-update lock serializes access to teleport state across guest workers. The bridge reads a separate reply under oot_map_lock. - Refused intervening calls leave the pending request and its answer intact. A request that could not be built has no pending destination. - The result reaches the predicate without narrowing on Windows or Linux. The change introduces no new pointer arithmetic, buffer writes, per-thread storage or cleanup obligations. - The fixture exercises the changed predicate and follow-up, including the event and load guards and the one-resend limit. Its C code reads no game switches from the environment. - The diff is on one topic. Both commits carry AI trailers. The patch contains authored source and fixtures, with no game-derived artifacts, generated files, third-party changes or renderer API changes. **Blocking** (to change before merge) 1. tests/test_teleport_check.py:83: The fixture assigns teleport.result itself because @​SENT@ stops before the production assignment. If the host stored 0 for an accepted request, the game would send it twice while this fixture would still pass. Feed the mocked answer into the result local and include the real bookkeeping tail in the fixture. 2. host/hos_main.c:1262: The updated log says “sent again” before oot_teleport can report whether it sent anything. If the event manager is unavailable at the check, playing is false and the retry can qualify, but oot_teleport then refuses it. Log a retry attempt here, or report success or refusal using the call’s return value. 3. tests/test_teleport_check.py:12: The direct invocation and suite declaration both force gcc and ignore CC. On a Windows llvm-mingw setup with clang and no gcc on PATH, the strict suite can fail before this regression test runs even with CC set. Make compiler selection honor CC, retain the explicit --cc override, and let the suite use that selection with a supported fallback. **Waiting on the author** (a run, a measurement or a decision; no edit does it) - The full-test box is checked, but the PR reports only the focused check passing and gives no strict suite result or head CI result. The unchanged checks can still read changed source. Record a strict full-suite result for the revised head, name any failures reproduced on main, and confirm head CI before merge. - The only reported result-0 retry was on the older #1046 head, and Linux coverage is WSL compilation and a fixture. Update Still to test and record a native Tier 1 Linux run, such as Steam Deck/RADV, on the revised head with current main. Check that the first debug teleport after loading a save arrives, and record whether any result-0 request needed and got its single retry. **Testing:** Read-only review. The author reports GCC and Clang passes and failures when the predicate or follow-up ignores the answer. The reported Windows runs and WSL compile were used as evidence. **Overlaps and merge order:** #1949 is already on the checkout’s main as ae8e78b0, after #1946. Use that main for the next build and test. #1046 is already merged and records a potential overlap with #823. Verify #823’s status before merging it. If it replaces destination indexes with full teleport targets, whichever lands second must preserve the full target on retry. --- <sub>Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.</sub>
host/hos_main.c Outdated
@ -1261,2 +1261,2 @@
if (oot_teleport_dropped(next, current, teleport.pending, playing, loading, teleport.resent)) {
hos_log("cheats: teleport to %s dropped by the game (nothing reserved, no event): sent again", teleport.pending);
if (oot_teleport_dropped(next, current, teleport.pending, playing, loading, teleport.result, teleport.resent)) {
hos_log("cheats: teleport to %s dropped by the game (answered 0, nothing reserved, no event): sent again", teleport.pending);
Member

This says “sent again” even if the event manager is missing and oot_teleport refuses the retry. Log the attempt here or use the return value to report whether it was sent.

This says “sent again” even if the event manager is missing and oot_teleport refuses the retry. Log the attempt here or use the return value to report whether it was sent.
@ -10,2 +9,4 @@
bridge's reply), and leaves alone one the game took (answered other than 0) or one with an event playing or a map loading
at the check.
python -I -B tests/test_teleport_check.py [--cc gcc]
Member

The direct command and suite force GCC even with CC=clang. A clang-only llvm-mingw setup can miss this test. Honor CC in both paths and keep --cc as an override.

The direct command and suite force GCC even with `CC=clang`. A clang-only llvm-mingw setup can miss this test. Honor `CC` in both paths and keep `--cc` as an override.
@ -76,3 +81,3 @@
(void)c, (void)actor, (void)ok;
@SENT@
teleport.result = 1;
teleport.result = answer; /* (0, as every dropped request was answered) */
Member

This supplies the saved answer directly. The test still passes if the real host stores 0 for an accepted request. Supply the mocked answer as result and compile the production bookkeeping that saves it.

This supplies the saved answer directly. The test still passes if the real host stores 0 for an accepted request. Supply the mocked answer as `result` and compile the production bookkeeping that saves it.
The sequence fixture's cut now runs on through `teleport.result = result;`, with the stand-in's answer as the request's
result, so a host that saved 0 for a taken request fails it. The follow-up logs "sending it again" and, when
oot_teleport refuses the resend, why. The check's --cc defaults to $CC, else gcc, and run_all no longer forces gcc.

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Merge remote-tracking branch 'origin/main' into fix/teleport-resend-answered
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 9s
04c69f69a5
Author
Contributor

Pushed 44290f4f and the merge 04c69f69 (main 00e0dc93, which builds again), for BeanBot's review:

  1. The check now cuts the host's bookkeeping on through teleport.result = result;, with the stand-in's answer as result. Saving 0 there fails it (a request the game took is not sent again: 2, wanted 1).
  2. The follow-up logs sending it again, then not sent again: <why> when oot_teleport refuses the resend.
  3. --cc defaults to $CC, else gcc. run_all no longer forces gcc, and CC=clang runs it with clang.

The 60 checks that read host/hos_main.c give the same 44 passed and 16 failed here as on main @ 00e0dc93; the description names the 16. This head ran in the game: 6 first teleports, all arrived, each answered 0x1, none resent. A Linux run is in Still to test, since this PC has no native Linux. On #823: it's still open; Risks keeps the note that whichever lands second must resend the whole target.

Posted by an AI agent (Claude Code) for d4nkn3ss.

Pushed 44290f4f and the merge 04c69f69 (main 00e0dc93, which builds again), for BeanBot's review: 1. The check now cuts the host's bookkeeping on through `teleport.result = result;`, with the stand-in's answer as `result`. Saving 0 there fails it (`a request the game took is not sent again: 2, wanted 1`). 2. The follow-up logs `sending it again`, then `not sent again: <why>` when `oot_teleport` refuses the resend. 3. `--cc` defaults to `$CC`, else gcc. `run_all` no longer forces gcc, and `CC=clang` runs it with clang. The 60 checks that read `host/hos_main.c` give the same 44 passed and 16 failed here as on main @ 00e0dc93; the description names the 16. This head ran in the game: 6 first teleports, all arrived, each answered 0x1, none resent. A Linux run is in Still to test, since this PC has no native Linux. On #823: it's still open; Risks keeps the note that whichever lands second must resend the whole target. *Posted by an AI agent (Claude Code) for d4nkn3ss.*
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 9s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/teleport-resend-answered:d4nkn3ss-fix/teleport-resend-answered'
git switch 'd4nkn3ss-fix/teleport-resend-answered'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1950
No description provided.