test(build): XeSS needs its script, and Longshot's make_game.py is held to it #219

Merged
llun merged 1 commit from madebyjordan/LongshotLauncher:test/xess-script-contract into main 2026-11-20 18:39:08 +00:00
Member

Follow-up to #218 (XeSS switchable again for nightly-611 and later). These checks came from a cold review of #218. They were pushed a few minutes after it merged, so they missed it. No launcher behaviour changes: tests and the README only.

  • The fix can't be too loose (tests/launcher_core/Program.cs, CommandChecks): tools with every other file but neither scripts/xess_sdk.py nor scripts/fetch.py, like those from before XeSS, get no XeSS. A XessBuilds that accepted any file, such as one also taking make_game.py, passed #218's checks. This check catches it.
  • Longshot is held to what the launcher looks for (tests/test_launcher_core.py --longshot, new check_xess_fetch): if Longshot's make_game.py takes --fetch-xess-runtime, its tools must carry xess_sdk.py or fetch.py. That would have flagged Longshot #1802's move when it happened, instead of players finding the XeSS switch greyed out.
  • check_licences names the missing pin when a script lacks one (fetch.py without XESS_COMMIT, say), instead of raising a bare StopIteration.
  • README: the --longshot paragraph names scripts/fetch.py and the new check.

How it was tested

Windows 11 Home 10.0.26200, .NET SDK 10.0.404, on main 0843b61.

  • The too-loose check: it passes with #218's XessBuilds. With || exists(tools.MakeGame) added to XessBuilds, it fails: "XeSS: tools with every other file but neither script (from before XeSS) are no XeSS tools." #218's checks pass that mutant.
  • check_licences and check_xess_fetch against Longshot's scripts and make_game.py at three commits all pass: the pin 514591a3, 461da1bb (the old *_sdk.py scripts), and main (fetch.py). These are caught with their messages: Longshot main without fetch.py, and a fetch.py without XESS_COMMIT.
  • The core suite, each check group run on past a failure (a local wrapper, not committed): the same 8 Windows-only groups fail as on main, and nothing else. dotnet build -warnaserror is clean.

🤖 Generated with Claude Code

Follow-up to #218 (XeSS switchable again for nightly-611 and later). These checks came from a cold review of #218. They were pushed a few minutes after it merged, so they missed it. No launcher behaviour changes: tests and the README only. - **The fix can't be too loose** (`tests/launcher_core/Program.cs`, `CommandChecks`): tools with every other file but neither `scripts/xess_sdk.py` nor `scripts/fetch.py`, like those from before XeSS, get no XeSS. A `XessBuilds` that accepted any file, such as one also taking `make_game.py`, passed #218's checks. This check catches it. - **Longshot is held to what the launcher looks for** (`tests/test_launcher_core.py --longshot`, new `check_xess_fetch`): if Longshot's `make_game.py` takes `--fetch-xess-runtime`, its tools must carry `xess_sdk.py` or `fetch.py`. That would have flagged Longshot #1802's move when it happened, instead of players finding the XeSS switch greyed out. - `check_licences` names the missing pin when a script lacks one (`fetch.py` without `XESS_COMMIT`, say), instead of raising a bare `StopIteration`. - **README:** the `--longshot` paragraph names `scripts/fetch.py` and the new check. ## How it was tested Windows 11 Home 10.0.26200, .NET SDK 10.0.404, on main `0843b61`. - **The too-loose check:** it passes with #218's `XessBuilds`. With `|| exists(tools.MakeGame)` added to `XessBuilds`, it fails: *"XeSS: tools with every other file but neither script (from before XeSS) are no XeSS tools."* #218's checks pass that mutant. - **`check_licences` and `check_xess_fetch`** against Longshot's scripts and `make_game.py` at three commits all pass: the pin `514591a3`, `461da1bb` (the old `*_sdk.py` scripts), and main (`fetch.py`). These are caught with their messages: Longshot main without `fetch.py`, and a `fetch.py` without `XESS_COMMIT`. - **The core suite**, each check group run on past a failure (a local wrapper, not committed): the same 8 Windows-only groups fail as on main, and nothing else. `dotnet build -warnaserror` is clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
test(build): XeSS needs its script, and Longshot's make_game.py is held to it
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 18s
2f22e441f7
From a cold review of the XeSS fix:
- The command checks gain tools with every other file but neither script
  (from before XeSS): no XeSS. A XessBuilds that took any file passed before.
- --longshot checks that a Longshot whose make_game.py takes
  --fetch-xess-runtime carries scripts/xess_sdk.py or scripts/fetch.py,
  which would have caught nightly-611's move.
- check_licences says which pin a Longshot script lacks instead of
  raising StopIteration.
- The README names fetch.py as what the licence check reads.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Member

Possibly related, for context:

  • PR MagicBeanDev/Longshot#459 feat(vk): Intel XeSS Super Resolution as a temporal upscaler (Vulkan, the player's libxess.dll) — Original XeSS runtime-fetch support tested against
Possibly related, for context: - PR MagicBeanDev/Longshot#459 feat(vk): Intel XeSS Super Resolution as a temporal upscaler (Vulkan, the player's libxess.dll) — Original XeSS runtime-fetch support tested against
BeanBot left a comment

Recommendation: Wait. The added checks cover the overly permissive XeSS detection and the known script rename without changing launcher behaviour. The required core and release-test results are not yet shown for this head; the reported Windows core run had eight pre-existing failures.

This adds regression coverage for older tools and a cross-repository source check, plus a clearer missing-pin diagnostic. The author reports that the new C# check catches a deliberately over-permissive implementation and that the Python checks pass against three Longshot layouts; it does not change a player's build.

Does it help: Yes, as regression coverage: the reported mutant fails the new C# assertion while the earlier checks pass. This is not a performance change.
Other systems: Only test and documentation paths change; Windows, Linux and Steam Deck launcher behaviour is unchanged. The cross-check examines a Longshot checkout, not the contents of packaged builder tools.
Switches: None added, changed or removed.

Reviewed: 2f22e441f7 against 0843b6195d: Read AGENTS.md, CONTRIBUTING.md, the complete diff, tests/test_launcher_core.py and Core/MakeGameCommand.cs. Read the relevant XeSS test hunk and surrounding search results; the full Program.cs and README responses were truncated, so the remainder was only skimmed. No review checklist or Forgejo pull request template was present. No earlier reviews or comments.; nothing run (a code review).
Checked and fine:

  • The negative C# case presents every other file as existing and checks both capability detection and emitted arguments.
  • Missing SDK pins now name the script and constant rather than producing a bare StopIteration.
  • No game files, keys, saves, package pins or shared release-format files are changed.

Suggestions (the author may take or leave)

  • Consider checking the actual packaged tools as well: the checkout can contain fetch.py even if a future packaging change omits it, leaving the source cross-check passing while the launcher greys out XeSS.

Testing: Wait for the required CI/core suite and Tooling release test results on this head. The author reports a clean warnings-as-errors build and the same eight Windows-only group failures as base using an uncommitted wrapper; no Tooling release-test or ci:smoke result is reported. I did not run tests.
Overlaps and merge order: #218 is already merged and is this PR's base. Open #202 changes the build settings UI but no direct overlap with these test changes was established; no merge ordering needed.


Automated code review by BeanBot (gpt-6.1-terra), on the pull request's opening. Nothing was run; a maintainer decides.

**Recommendation: Wait.** The added checks cover the overly permissive XeSS detection and the known script rename without changing launcher behaviour. The required core and release-test results are not yet shown for this head; the reported Windows core run had eight pre-existing failures. This adds regression coverage for older tools and a cross-repository source check, plus a clearer missing-pin diagnostic. The author reports that the new C# check catches a deliberately over-permissive implementation and that the Python checks pass against three Longshot layouts; it does not change a player's build. **Does it help:** Yes, as regression coverage: the reported mutant fails the new C# assertion while the earlier checks pass. This is not a performance change. **Other systems:** Only test and documentation paths change; Windows, Linux and Steam Deck launcher behaviour is unchanged. The cross-check examines a Longshot checkout, not the contents of packaged builder tools. **Switches:** None added, changed or removed. **Reviewed:** 2f22e441f72d against 0843b6195d59: Read AGENTS.md, CONTRIBUTING.md, the complete diff, tests/test_launcher_core.py and Core/MakeGameCommand.cs. Read the relevant XeSS test hunk and surrounding search results; the full Program.cs and README responses were truncated, so the remainder was only skimmed. No review checklist or Forgejo pull request template was present. No earlier reviews or comments.; nothing run (a code review). **Checked and fine:** - The negative C# case presents every other file as existing and checks both capability detection and emitted arguments. - Missing SDK pins now name the script and constant rather than producing a bare StopIteration. - No game files, keys, saves, package pins or shared release-format files are changed. **Suggestions** (the author may take or leave) - Consider checking the actual packaged tools as well: the checkout can contain fetch.py even if a future packaging change omits it, leaving the source cross-check passing while the launcher greys out XeSS. **Testing:** Wait for the required CI/core suite and Tooling release test results on this head. The author reports a clean warnings-as-errors build and the same eight Windows-only group failures as base using an uncommitted wrapper; no Tooling release-test or ci:smoke result is reported. I did not run tests. **Overlaps and merge order:** #218 is already merged and is this PR's base. Open #202 changes the build settings UI but no direct overlap with these test changes was established; no merge ordering needed. --- <sub>Automated code review by BeanBot (gpt-6.1-terra), on the pull request's opening. Nothing was run; a maintainer decides.</sub>
llun approved these changes 2026-11-20 18:37:07 +00:00
llun merged commit 415358bbcd into main 2026-11-20 18:39:08 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!219
No description provided.