test(build): XeSS needs its script, and Longshot's make_game.py is held to it #219
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!219
Loading…
Reference in a new issue
No description provided.
Delete branch "madebyjordan/LongshotLauncher:test/xess-script-contract"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up to #218 (XeSS switchable again for nightly-611 and later). These checks came from a cold review of #218. They were pushed a few minutes after it merged, so they missed it. No launcher behaviour changes: tests and the README only.
tests/launcher_core/Program.cs,CommandChecks): tools with every other file but neitherscripts/xess_sdk.pynorscripts/fetch.py, like those from before XeSS, get no XeSS. AXessBuildsthat accepted any file, such as one also takingmake_game.py, passed #218's checks. This check catches it.tests/test_launcher_core.py --longshot, newcheck_xess_fetch): if Longshot'smake_game.pytakes--fetch-xess-runtime, its tools must carryxess_sdk.pyorfetch.py. That would have flagged Longshot #1802's move when it happened, instead of players finding the XeSS switch greyed out.check_licencesnames the missing pin when a script lacks one (fetch.pywithoutXESS_COMMIT, say), instead of raising a bareStopIteration.--longshotparagraph namesscripts/fetch.pyand the new check.How it was tested
Windows 11 Home 10.0.26200, .NET SDK 10.0.404, on main
0843b61.XessBuilds. With|| exists(tools.MakeGame)added toXessBuilds, it fails: "XeSS: tools with every other file but neither script (from before XeSS) are no XeSS tools." #218's checks pass that mutant.check_licencesandcheck_xess_fetchagainst Longshot's scripts andmake_game.pyat three commits all pass: the pin514591a3,461da1bb(the old*_sdk.pyscripts), and main (fetch.py). These are caught with their messages: Longshot main withoutfetch.py, and afetch.pywithoutXESS_COMMIT.dotnet build -warnaserroris clean.🤖 Generated with Claude Code
Possibly related, for context:
Recommendation: Wait. The added checks cover the overly permissive XeSS detection and the known script rename without changing launcher behaviour. The required core and release-test results are not yet shown for this head; the reported Windows core run had eight pre-existing failures.
This adds regression coverage for older tools and a cross-repository source check, plus a clearer missing-pin diagnostic. The author reports that the new C# check catches a deliberately over-permissive implementation and that the Python checks pass against three Longshot layouts; it does not change a player's build.
Does it help: Yes, as regression coverage: the reported mutant fails the new C# assertion while the earlier checks pass. This is not a performance change.
Other systems: Only test and documentation paths change; Windows, Linux and Steam Deck launcher behaviour is unchanged. The cross-check examines a Longshot checkout, not the contents of packaged builder tools.
Switches: None added, changed or removed.
Reviewed:
2f22e441f7against0843b6195d: Read AGENTS.md, CONTRIBUTING.md, the complete diff, tests/test_launcher_core.py and Core/MakeGameCommand.cs. Read the relevant XeSS test hunk and surrounding search results; the full Program.cs and README responses were truncated, so the remainder was only skimmed. No review checklist or Forgejo pull request template was present. No earlier reviews or comments.; nothing run (a code review).Checked and fine:
Suggestions (the author may take or leave)
Testing: Wait for the required CI/core suite and Tooling release test results on this head. The author reports a clean warnings-as-errors build and the same eight Windows-only group failures as base using an uncommitted wrapper; no Tooling release-test or ci:smoke result is reported. I did not run tests.
Overlaps and merge order: #218 is already merged and is this PR's base. Open #202 changes the build settings UI but no direct overlap with these test changes was established; no merge ordering needed.
Automated code review by BeanBot (gpt-6.1-terra), on the pull request's opening. Nothing was run; a maintainer decides.