fix(build): Intel XeSS can be switched on again for nightly-611 and later #218

Merged
llun merged 2 commits from madebyjordan/LongshotLauncher:fix/xess-after-fetch-py into main 2026-11-20 18:25:33 +00:00
Member

Since nightly-611, the New Build step won't let you turn on Intel XeSS. The switch is greyed out with "This version can't fetch it yet.", even though the game still supports it.

Why: the launcher decides whether a version's tools can fetch Intel's libxess.dll by looking for scripts/xess_sdk.py in them. Longshot MagicBeanDev/Longshot#1802 (the dev revamp, first in nightly-611) merged ngx_sdk.py, ffx_sdk.py and xess_sdk.py into one scripts/fetch.py. make_game.py still takes --fetch-xess-runtime and pins the same XeSS commit (de0fb9c1). The file the launcher looked for is gone, so every nightly since looks like tools from before XeSS. DLSS and FSR 4 aren't affected: their checks don't look for a script.

Fix (Core/MakeGameCommand.cs): XessBuilds accepts either scripts/xess_sdk.py or scripts/fetch.py. fetch.py was born in #1802 with XeSS in it, so no version that has it lacks XeSS.

The licence cross-check (tests/test_launcher_core.py --longshot, check_licences) read the same three old scripts. It now reads fetch.py's DLSS_COMMIT, FSR_COMMIT and XESS_COMMIT when fetch.py is there, and the old scripts otherwise. That keeps it working once the Longshot pin moves past #1802. A comment in SettingsStepViewModel.cs names the new script. No text the player sees changes.

How it was tested

Windows 11 Home 10.0.26200, .NET SDK 10.0.404, on main 985cc61.

  • New check, its own commit (b4ccb42, CommandChecks): tools that carry scripts/fetch.py alone get --fetch-xess-runtime --accept-intel-license and LONGSHOT_XESS_SDK. It fails on main with "XeSS: tools that carry scripts/fetch.py (Longshot from #1802 on) fetch Intel's library too" and passes with the fix.

  • The real tools on this PC, from a small program built against Core: XessBuilds is true for nightly-612's and nightly-622's tools, which have fetch.py and no xess_sdk.py. It's still true for v3.0.0's, which have xess_sdk.py. On main, the two nightlies give false.

  • check_licences against three Longshot layouts:

    • the pin 514591a3 (ngx_sdk.py and ffx_sdk.py, no XeSS yet);
    • 461da1bb (all three old scripts);
    • Longshot main (fetch.py).

    All three pass, and a fetch.py with a changed XESS_COMMIT is caught.

  • The core suite, run with each check group continuing past a failure (a local wrapper, not committed): the same 8 Windows-only groups fail on this branch and on main, each with the same message. CommandChecks passes. dotnet build -warnaserror is clean.

Not tested: a full build with XeSS ticked from a nightly.

Notes

  • Two more --longshot cross-checks still read the old layout, both the same #1802 move. Neither runs in CI until the pin moves, and they're left for their own PR:
    • check_shader_caches reads scripts/dev_packs.py, now scripts/devtools/packs.py.
    • Its CACHES gained longshot_textures_drawn.bin (#1122, RX_VK_TEX_AHEAD), which ShaderCaches.Names doesn't list yet.
  • Builds and updates made from nightly-611 to nightly-622 with XeSS ticked were run without --fetch-xess-runtime. A game folder that didn't already have libxess.dll from an earlier build has none. The next build or update after this lands fetches it.

🤖 Generated with Claude Code

Since nightly-611, the New Build step won't let you turn on Intel XeSS. The switch is greyed out with *"This version can't fetch it yet."*, even though the game still supports it. **Why:** the launcher decides whether a version's tools can fetch Intel's `libxess.dll` by looking for `scripts/xess_sdk.py` in them. Longshot https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1802 (the dev revamp, first in nightly-611) merged `ngx_sdk.py`, `ffx_sdk.py` and `xess_sdk.py` into one `scripts/fetch.py`. `make_game.py` still takes `--fetch-xess-runtime` and pins the same XeSS commit (`de0fb9c1`). The file the launcher looked for is gone, so every nightly since looks like tools from before XeSS. DLSS and FSR 4 aren't affected: their checks don't look for a script. **Fix** (`Core/MakeGameCommand.cs`): `XessBuilds` accepts either `scripts/xess_sdk.py` or `scripts/fetch.py`. `fetch.py` was born in #1802 with XeSS in it, so no version that has it lacks XeSS. The licence cross-check (`tests/test_launcher_core.py --longshot`, `check_licences`) read the same three old scripts. It now reads `fetch.py`'s `DLSS_COMMIT`, `FSR_COMMIT` and `XESS_COMMIT` when `fetch.py` is there, and the old scripts otherwise. That keeps it working once the Longshot pin moves past #1802. A comment in `SettingsStepViewModel.cs` names the new script. No text the player sees changes. ## How it was tested Windows 11 Home 10.0.26200, .NET SDK 10.0.404, on main `985cc61`. - **New check, its own commit** (`b4ccb42`, `CommandChecks`): tools that carry `scripts/fetch.py` alone get `--fetch-xess-runtime --accept-intel-license` and `LONGSHOT_XESS_SDK`. **It fails on main** with *"XeSS: tools that carry scripts/fetch.py (Longshot from #1802 on) fetch Intel's library too"* and passes with the fix. - **The real tools on this PC**, from a small program built against `Core`: `XessBuilds` is true for nightly-612's and nightly-622's tools, which have `fetch.py` and no `xess_sdk.py`. It's still true for v3.0.0's, which have `xess_sdk.py`. On main, the two nightlies give false. - **`check_licences`** against three Longshot layouts: - the pin `514591a3` (`ngx_sdk.py` and `ffx_sdk.py`, no XeSS yet); - `461da1bb` (all three old scripts); - Longshot main (`fetch.py`). All three pass, and a `fetch.py` with a changed `XESS_COMMIT` is caught. - **The core suite**, run with each check group continuing past a failure (a local wrapper, not committed): the same 8 Windows-only groups fail on this branch and on main, each with the same message. `CommandChecks` passes. `dotnet build -warnaserror` is clean. **Not tested:** a full build with XeSS ticked from a nightly. ## Notes - **Two more `--longshot` cross-checks still read the old layout**, both the same #1802 move. Neither runs in CI until the pin moves, and they're left for their own PR: - `check_shader_caches` reads `scripts/dev_packs.py`, now `scripts/devtools/packs.py`. - Its `CACHES` gained `longshot_textures_drawn.bin` (#1122, `RX_VK_TEX_AHEAD`), which `ShaderCaches.Names` doesn't list yet. - Builds and updates made from nightly-611 to nightly-622 with XeSS ticked were run without `--fetch-xess-runtime`. A game folder that didn't already have `libxess.dll` from an earlier build has none. The next build or update after this lands fetches it. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Longshot #1802 (first in nightly-611) folded scripts/xess_sdk.py into
scripts/fetch.py, and make_game.py still takes --fetch-xess-runtime. The
launcher looks for xess_sdk.py alone, so it takes every nightly from 611
on for tools that can't fetch XeSS and greys the switch out ("This
version can't fetch it yet."). This check fails on main for that reason.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
fix(build): Intel XeSS can be switched on again for nightly-611 and later
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 5s
efdb5ce67a
Longshot #1802 folded scripts/xess_sdk.py into scripts/fetch.py (first in
nightly-611). The launcher took the old file as the sign that a version's
tools fetch Intel's library, so every nightly since greyed the XeSS switch
out with "This version can't fetch it yet." while its make_game.py still
takes --fetch-xess-runtime. XessBuilds now takes either script.

The licence cross-check (tests/test_launcher_core.py --longshot) reads
fetch.py's DLSS_COMMIT, FSR_COMMIT and XESS_COMMIT too, so it keeps
checking the licence links once the Longshot pin moves past #1802.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Member

Possibly related, for context:

  • PR MagicBeanDev/Longshot#459 feat(vk): Intel XeSS Super Resolution as a temporal upscaler (Vulkan, the player's libxess.dll) — Original XeSS runtime-download support and pinned library
  • PR #202 feat(ui): Jordan's redesign: Forest, Fire and Water themes, New Build, and every page in the new look — Open redesign also changes New Build and build settings UI
Possibly related, for context: - PR MagicBeanDev/Longshot#459 feat(vk): Intel XeSS Super Resolution as a temporal upscaler (Vulkan, the player's libxess.dll) — Original XeSS runtime-download support and pinned library - PR #202 feat(ui): Jordan's redesign: Forest, Fire and Water themes, New Build, and every page in the new look — Open redesign also changes New Build and build settings UI
BeanBot left a comment

Recommendation: Wait. The capability check now recognizes the nightly tools and sends the existing licensed XeSS fetch arguments, but an actual nightly build with XeSS enabled has not yet been demonstrated.

This restores the XeSS choice for Windows builds using the consolidated fetch script without changing the Linux path or adding a player setting. The focused regression check and tests against real tool layouts support the fix; the remaining uncertainty is whether the complete launcher-to-builder path installs the DLL successfully.

Does it help: Unproven end to end. The author reports the new command check fails on main and passes with this change; nightly-612 and nightly-622 tools are recognized, while v3.0.0 remains recognized. No full nightly build with XeSS enabled was run.
Other systems: Windows builds and updates with XeSS and its licence enabled take the new path; Linux remains gated off. Old tools retain the original script check. DLSS and FSR command paths are unchanged. The separate shader-cache cross-check remains incompatible with newer Longshot layouts, as disclosed; it is not introduced here.
Switches: No new switches or defaults. The existing XeSS opt-in and licence gate now work with fetch.py; --fetch-xess-runtime, --accept-intel-license and LONGSHOT_XESS_SDK are passed only for opted-in Windows builds.

Reviewed: efdb5ce67a against 985cc61459: Read the repository rules, full diff, MakeGameCommand.cs, SettingsStepViewModel.cs and tests/test_launcher_core.py; Program.cs output was truncated, so its changed CommandChecks hunk was reviewed in the diff rather than the whole file. No review checklist or pull request template was present at the listed paths. Reviewed author-reported runs; no tests were run by this review.; nothing run (a code review).
Checked and fine:

  • The new regression check covers the new script alone and verifies both licence arguments and the SDK environment path.
  • The legacy script and unsupported-tools checks remain, and the licence cross-check retains the older layout.

Testing: Wait for a Windows nightly build with XeSS ticked and its licence accepted, confirming libxess.dll is installed; ideally also check an update of an affected game folder. The reported Windows core-suite failures also occur on main; the release suite and a full nightly build were not reported.
Overlaps and merge order: #202 redesigns the build settings and XeSS UI; coordinate its rebase so this capability fix survives either merge order. #50 also changes build settings and command handling for ANR; rebase whichever lands second.

-# Automated code review by IssueBot (gpt-6.1-terra), on the pull request's opening. Nothing was run; a maintainer decides.

**Recommendation: Wait.** The capability check now recognizes the nightly tools and sends the existing licensed XeSS fetch arguments, but an actual nightly build with XeSS enabled has not yet been demonstrated. This restores the XeSS choice for Windows builds using the consolidated fetch script without changing the Linux path or adding a player setting. The focused regression check and tests against real tool layouts support the fix; the remaining uncertainty is whether the complete launcher-to-builder path installs the DLL successfully. **Does it help:** Unproven end to end. The author reports the new command check fails on main and passes with this change; nightly-612 and nightly-622 tools are recognized, while v3.0.0 remains recognized. No full nightly build with XeSS enabled was run. **Other systems:** Windows builds and updates with XeSS and its licence enabled take the new path; Linux remains gated off. Old tools retain the original script check. DLSS and FSR command paths are unchanged. The separate shader-cache cross-check remains incompatible with newer Longshot layouts, as disclosed; it is not introduced here. **Switches:** No new switches or defaults. The existing XeSS opt-in and licence gate now work with fetch.py; --fetch-xess-runtime, --accept-intel-license and LONGSHOT_XESS_SDK are passed only for opted-in Windows builds. **Reviewed:** efdb5ce67a70 against 985cc6145974: Read the repository rules, full diff, MakeGameCommand.cs, SettingsStepViewModel.cs and tests/test_launcher_core.py; Program.cs output was truncated, so its changed CommandChecks hunk was reviewed in the diff rather than the whole file. No review checklist or pull request template was present at the listed paths. Reviewed author-reported runs; no tests were run by this review.; nothing run (a code review). **Checked and fine:** - The new regression check covers the new script alone and verifies both licence arguments and the SDK environment path. - The legacy script and unsupported-tools checks remain, and the licence cross-check retains the older layout. **Testing:** Wait for a Windows nightly build with XeSS ticked and its licence accepted, confirming libxess.dll is installed; ideally also check an update of an affected game folder. The reported Windows core-suite failures also occur on main; the release suite and a full nightly build were not reported. **Overlaps and merge order:** #202 redesigns the build settings and XeSS UI; coordinate its rebase so this capability fix survives either merge order. #50 also changes build settings and command handling for ANR; rebase whichever lands second. -# Automated code review by IssueBot (gpt-6.1-terra), on the pull request's opening. Nothing was run; a maintainer decides.
llun approved these changes 2026-11-20 18:25:23 +00:00
llun merged commit 0843b6195d into main 2026-11-20 18:25:33 +00:00
Author
Member

Merged at efdb5ce before my self-review's follow-ups landed. They're in #219 (tests and README only): a check that the fix isn't too loose, and a --longshot check that would have caught Longshot #1802's move. One correction to this PR's notes: the stale shader-cache cross-check doesn't fail CI because the required CircleCI job uses the pinned Longshot; the job against Longshot's main is advisory.

Merged at efdb5ce before my self-review's follow-ups landed. They're in https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/219 (tests and README only): a check that the fix isn't too loose, and a --longshot check that would have caught Longshot #1802's move. One correction to this PR's notes: the stale shader-cache cross-check doesn't fail CI because the required CircleCI job uses the pinned Longshot; the job against Longshot's main is advisory.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!218
No description provided.