test(build): the lift clean-up check stands in for the shared lift store #623
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!623
Loading…
Reference in a new issue
No description provided.
Delete branch "zeldaootr/Longshot:fix-lift-cleanup-check-lift-store"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Linux, no GPU (game-free check) · Needs: none
Why
tests/test_lift_cleanup_error.pyhas failed onmainsince the shared lift store merged (#372), somainis red before a release candidate. A review of #372 already noted the same five errors on its head. The build is right; the check runsmake_game.py's fresh-lift branch in a namespace of its own and lacked the name that branch now uses. No open pull request or claim covers it.How to reproduce
Seen on: Linux (Ubuntu 24.04), no GPU
Settings and switches: none
Steps: on
mainaa95d35f, runpython -I -B tests/test_lift_cleanup_error.pyExpected: 9 tests OK, as on
86c04034, the commit before #372Actual:
FAILED (errors=5):NameError: name '_lift_store' is not definedatlifts = _lift_store.root()(nx2/make_game.py)What changed
Test-only: the check's namespace gets a
_lift_storewhoseroot()isNone, the store unset (LONGSHOT_LIFT_STOREempty), which is the path every one of its cases is about. No product file changes.tests/test_lift_cleanup_error.py:setUpadds_lift_store=types.SimpleNamespace(root=lambda: None); every assertion stays as it was.Measurements
Verdict: passes: the check fails on
mainand passes on this branch in two interleaved rounds.Hardware: Linux (Ubuntu 24.04, kernel 6.8), x86-64, no GPU used; Python 3.15
Scene: no game: the game-free check
Method: the check run alone, round 1 on main then this branch, round 2 the same again; its unittest errors per run
How to reproduce:
python -I -B tests/test_lift_cleanup_error.pyon each commitaa95d35f1075bf13Flags and settings
None
Testing
Tested: on Linux, the check failing on main
aa95d35fand passing here in two interleaved rounds (before this rebase, the same on main6c9edffeatc64817af); it passes at86c04034and fails at2d37cb42(#372's merge), which is what turned it red. The full suite (python -I -B tests/run_all.py, Linux,LONGSHOT_VULKAN_HEADERSset) on main6c9edffewith this and the six other red-check repairs from the same sweep merged locally (1ba90202, not pushed): 525 passed, 4 failed, 51 skipped. Three of the failures fail on main too and have their own pull requests:tests/test_walk_key.py(#497),tests/test_cpm_discovery.py(#561),tests/test_make_game_cache.py(#592). The fourth,tests/test_crash_record.py, timed out waiting 10 s for a signalled child under load and passes alone, twice. Rebased since onto mainaa95d35f, the commit re-authored under the forge's noreply address: its change is identical to before bygit patch-id; onaa95d35fthe check also ran through the runner with g++ 13.3 and with clang 23.1.5, failing on main and passing here.Not tested: Windows: the change is a name in the check's Python namespace, the same on both systems. The shared-store path itself (
LONGSHOT_LIFT_STOREset) is not what this check covers.Must be tested: None
Risks
What could break: only this check.
Turning it off: revert the commit
Compatibility: Nothing changes
Checklist
Everyone
type(scope): description) of the status line's type.main. Onto main94abdd57(head876adabf) with no conflict, with the commit subjects made Conventional Commits, which CI's lint job now checks for every commit, on a base that has CI's config (#417); each commit's change is the same as before bygit patch-id. The commits named in this description are from before this rebase:1075bf13is now876adabf. Re-run on94abdd57:test_lift_cleanup_errorfail on main94abdd57and pass here, with g++ 13.3 and clang 23.1.5.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named). The full run is the one in Testing, on main6c9edffe; after the rebase ontoaa95d35f, the changed check through the runner with g++ and clang, as above.third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers._lift_storestand-inc64817af7a1075bf13ebRebased onto
mainaa95d35f(head1075bf13); the commits are re-authored with the forge's noreply address: no code change, the same patches bygit patch-id.Test re-run:
test_lift_cleanup_errorfails on mainaa95d35f(errors=5) and passes here, two interleaved rounds, and through the runner with g++ and clang; the description names the new commit.1075bf13eb876adabf2cRebased onto
main94abdd57(head876adabf), with no conflict; the commit subjects are now Conventional Commits, which CircleCI's lint job checks for every commit of a pull request (#417), and the base has the CI's config, which a fork's pull request needs at its own head. No other change: each commit's change is the same as before bygit patch-id.Re-run on
94abdd57:test_lift_cleanup_errorfail on main94abdd57and pass here, with g++ 13.3 and clang 23.1.5. The description names the new commits.Read the diff (code only, nothing run). The check execs make_game.py's fresh-lift branch in its own namespace; that branch now calls
_lift_store.root()(nx2/make_game.py, theimport lift_store as _lift_storeat module level isn't in the cut), so the five cases hit NameError. The stand-intypes.SimpleNamespace(root=lambda: None)is exactly the unset-store path (liftsfalsy, soshareis None andrestore/saveare never reached), which is what every case is about. No assertion is weakened, no product file changes, and the comment says why. Description, measurements and checklist match the diff.Siblings #359 and #28 also touch this test file; this is a one-hunk change in setUp, so any conflict should be trivial. Merge this first, since it turns main green.