feat(menu): the start-up screen's bar has rounded corners in Modern dark, around its fill's #2161
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!2161
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:feat/startup-bar-rounded"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
In the Modern dark theme (#2109) the start-up screen's progress bar had a square dark cell around a fill with rounded
corners, so the two did not match. Now the cell's corners are rounded too, following the fill's with the same gap all
round: radius
kRound(the fill's, 4 points) plus the 4-point inset. Classic keeps its square bar.Read:
draw_startupingpu/vk/vk_menu.cpp.Before and after, from the game-free capture (
scripts/screenshots/capture_menu.py --views startup), are in the firstcomment.
Testing
Tested: not yet in the game. The runtime for it is still building on this PC (Linux, NVIDIA); the run and what it
shows will follow in a comment. The start-up screen was drawn by the game-free menu capture on
mainand here, Moderndark and Classic: Modern dark's bar is rounded around its fill, Classic's is unchanged.
Still to test:
Measurements
Nothing to measure: the start-up screen's bar is drawn with rounded corners instead of square ones, the same two draw
calls.
Risks
Only how the start-up screen's bar looks in Modern dark. A revert is enough. Nothing changes after updating.
Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named). (CI)main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
mainand here, for a change that shows on screen.Assisted-by:/Co-Authored-By:trailers.Ready to merge
main, measured again or a comment says why the numbers still hold.🤖 Generated with Claude Code
The start-up screen in Modern dark, from the game-free menu capture (
scripts/screenshots/capture_menu.py --views startup, 1280×720, the bar enlarged 2×).Before (main @
cce3ded1a3):After (this PR @
a0abde23d4):The whole screen, after:
WIP: feat(menu): the start-up screen's bar has rounded corners in Modern dark, around its fill'sto feat(menu): the start-up screen's bar has rounded corners in Modern dark, around its fill'sRan in the game: Linux (CachyOS), RTX 3090, NVIDIA 620.70, Wayland, a 3840×2049 window, Modern dark. The start-up screen's bar while it loads pipelines, rounded around its fill: