feat(menu): the start-up screen's bar has rounded corners in Modern dark, around its fill's #2161

Merged
HumanBean merged 1 commit from HumanBean/Longshot:feat/startup-bar-rounded into main 2026-11-21 23:34:57 +00:00
Owner

Summary

In the Modern dark theme (#2109) the start-up screen's progress bar had a square dark cell around a fill with rounded
corners, so the two did not match. Now the cell's corners are rounded too, following the fill's with the same gap all
round: radius kRound (the fill's, 4 points) plus the 4-point inset. Classic keeps its square bar.

Read: draw_startup in gpu/vk/vk_menu.cpp.

Before and after, from the game-free capture (scripts/screenshots/capture_menu.py --views startup), are in the first
comment.

Testing

Tested: not yet in the game. The runtime for it is still building on this PC (Linux, NVIDIA); the run and what it
shows will follow in a comment. The start-up screen was drawn by the game-free menu capture on main and here, Modern
dark and Classic: Modern dark's bar is rounded around its fill, Classic's is unchanged.

Still to test:

  • Linux, this PC: start the game, expecting the start-up screen's bar rounded in Modern dark and square in Classic (by hand)

Measurements

Nothing to measure: the start-up screen's bar is drawn with rounded corners instead of square ones, the same two draw
calls.

Risks

Only how the start-up screen's bar looks in Modern dark. A revert is enough. Nothing changes after updating.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says. (the runtime is still building)
  • mise run test passes (any failure that also fails on main is named). (CI)
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • Screenshots of the same spot on main and here, for a change that shows on screen.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.

🤖 Generated with Claude Code

## Summary In the Modern dark theme (#2109) the start-up screen's progress bar had a square dark cell around a fill with rounded corners, so the two did not match. Now the cell's corners are rounded too, following the fill's with the same gap all round: radius `kRound` (the fill's, 4 points) plus the 4-point inset. Classic keeps its square bar. Read: `draw_startup` in `gpu/vk/vk_menu.cpp`. Before and after, from the game-free capture (`scripts/screenshots/capture_menu.py --views startup`), are in the first comment. ## Testing **Tested:** not yet in the game. The runtime for it is still building on this PC (Linux, NVIDIA); the run and what it shows will follow in a comment. The start-up screen was drawn by the game-free menu capture on `main` and here, Modern dark and Classic: Modern dark's bar is rounded around its fill, Classic's is unchanged. **Still to test:** - Linux, this PC: start the game, expecting the start-up screen's bar rounded in Modern dark and square in Classic (by hand) ## Measurements Nothing to measure: the start-up screen's bar is drawn with rounded corners instead of square ones, the same two draw calls. ## Risks Only how the start-up screen's bar looks in Modern dark. A revert is enough. Nothing changes after updating. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [ ] Tested on my own PC, in the game for a change the game runs, as Testing says. (the runtime is still building) - [ ] `mise run test` passes (any failure that also fails on `main` is named). (CI) - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] Screenshots of the same spot on `main` and here, for a change that shows on screen. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
feat(menu): the start-up screen's bar has rounded corners in Modern dark, around its fill's
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 11s
Website / Website on Cloudflare (pull_request_target) Has been skipped
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 17s
CI / Workflow lint (actionlint) (pull_request) Successful in 18s
Third-party parts / As their notes say (pull_request) Successful in 21s
CI / Website build and checks (pull_request) Failing after 24s
PR description / Description follows the template (pull_request_target) Failing after 6s
a0abde23d4
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Owner

The start-up screen in Modern dark, from the game-free menu capture (scripts/screenshots/capture_menu.py --views startup, 1280×720, the bar enlarged 2×).

Before (main @ cce3ded1a3):

before

After (this PR @ a0abde23d4):

after

The whole screen, after:

after, whole screen

The start-up screen in Modern dark, from the game-free menu capture (`scripts/screenshots/capture_menu.py --views startup`, 1280×720, the bar enlarged 2×). **Before** (main @ cce3ded1a326): ![before](https://git.magicbean.dev/attachments/23f39aef-ccab-4a0d-9f62-b413d5ca757b) **After** (this PR @ a0abde23d4f8): ![after](https://git.magicbean.dev/attachments/2dd4abd0-4e21-436c-84ff-421bd4f3aa06) The whole screen, after: ![after, whole screen](https://git.magicbean.dev/attachments/b79c5299-7f08-4d6e-9e06-ad40b3c54ac3)
HumanBean changed title from WIP: feat(menu): the start-up screen's bar has rounded corners in Modern dark, around its fill's to feat(menu): the start-up screen's bar has rounded corners in Modern dark, around its fill's 2026-11-21 23:34:50 +00:00
HumanBean deleted branch feat/startup-bar-rounded 2026-11-21 23:34:57 +00:00
Author
Owner

Ran in the game: Linux (CachyOS), RTX 3090, NVIDIA 620.70, Wayland, a 3840×2049 window, Modern dark. The start-up screen's bar while it loads pipelines, rounded around its fill:

in game

Ran in the game: Linux (CachyOS), RTX 3090, NVIDIA 620.70, Wayland, a 3840×2049 window, Modern dark. The start-up screen's bar while it loads pipelines, rounded around its fill: ![in game](https://git.magicbean.dev/attachments/da8f1f46-4a05-4714-942e-7f2cade66fe4)
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!2161
No description provided.