feat(menu): a Modern dark theme for the menu and start-up screen, smaller menu sizes and tabs #2109
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!2109
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:feat/menu-modern-dark"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The Insert menu and the start-up screen get a new look, Modern dark, now the default, with the old tan and gold kept as
Classic (Gameplay → Menu theme, saved as
menu_theme). Modern dark has slate greys, a soft blue for the selectedvalue and rounded cells, and each row's name and value are drawn as one box. Both themes swap the hazy glow around the
selection for a fine ring. The menu is also a little smaller at every size, with smaller tabs, and the DLSS model row
only shows when the Upscaler is DLSS or DLAA.
ui::set_theme()(gpu/vk/vk_ui.h) sets the palette, which is now variables instead ofconstexpr.ui_ctxcalls it every frame before anything is drawn, so the menu, the FPS counter and the start-up screen followthe row. Colours that were hard-coded in
vk_menu.cppmoved into the palette (kShade,kTabEdge,kKeyCap,kStartBg, ...). The row is ingpu/vk/menu/menu_settings.cpp, under Menu size, and its key is added to FROZEN.name_cellandvalue_frame/half_boxinvk_menu.cpp. Each half is drawn as a wholerounded box past the seam and clipped at it on a whole pixel, so the two halves meet with no anti-aliased line.
Cells that stand apart, like the Controls grid, keep their own box.
ui::unitis Small 0.78, Medium 0.9 and Large 1.2 (was 0.85, 1.0 and 1.3), so Medium sits between the oldSmall and Medium. The tabs are 20 pt instead of 23, with less padding, and the banner is lower. The help box is
centred between the banner and the prompts.
ur::model_shown(dlss_ok, upscaler)is shown with DLSS or DLAA chosen, where DLSS runs, as theDLAA-before-the-bloom row already was.
scripts/builder_package.pydid not carryassets/longshot.png. A build fromthe Windows builder package therefore compiled the renderer without the logo, and its start-up screen and menu banner
showed the wordmark alone. The Linux AppImage carries all of
assets/. The package now carries the logo.main): their two panels use the themed box colour instead of a hard-coded brown.settings-graphics.pngis recaptured with the game-free fixture, and its manifest entry isupdated. The settings table gets the Menu theme row, and the DLSS model line says when the row shows. The fixture
(
scripts/screenshots/menu.cpp) applies the theme as the game does, and it can now draw the start-up screen(
startup) and Classic (<view>-classic). It also gets stand-ins for the ReShade and FSR 4 model rows' renderer calls. Without them it no longer linked onmain.Screenshots of
mainand both themes, menu and start-up screen, are in the first comment below.Testing
Tested: Linux (CachyOS, kernel 7.3.3), RTX 3090, NVIDIA 620.70.06. The person I work for ran each build from the
shared base through the job queue and gave feedback, which the later builds address: the selection ring, the joined
rows and their seam, the Q/E caps, the centred help box, and the start-up screen's glow. On the final build: the
start-up screen in Modern dark, the menu's tabs and rows, and switching Menu theme between Modern dark and Classic.
The menu's look in both themes was also checked in the game-free fixture's captures (first comment).
Still to test:
screen and in the banner (by hand: needs a package build).
show again with DLSS or DLAA (by hand).
(
@Beanstalk open the Insert menu at Large on a 4K window and at Small at 720p; screenshot each tab in both Menu themes).Measurements
Nothing to measure: the change is how the menu and the start-up screen draw, only while they show (with both closed the only new work is set_theme's ~45 integer stores on a frame the FPS counter draws), and it adds no translation unit to the build.
Risks
longshot_options.ini(
menu_theme, 0 Modern dark, 1 Classic). An older file has no key and gets Modern dark."...", so the risk is lower legibility, not overlap.
captured_source.revisionis124e4a4d. That is this change's source before the docs went in:the same source files as the head, which
check_guide_screenshots.py --review-sourcescompares.Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named). (CI runs it: this PC runs no test suites; ticked when CI passes)main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
tests/that reads changed source is updated, not weakened.mainand here, for a change that shows on screen.Assisted-by:/Co-Authored-By:trailers.Ready to merge
main, measured again or a comment says why the numbers still hold.🤖 Generated with Claude Code
Tested in game: Linux (CachyOS 7.3.3), RTX 3090, NVIDIA 620.70.06: the start-up screen in Modern dark at a start; the Insert menu's tabs and rows in Modern dark (rows joined with no seam, the selection's ring, Q/E caps, centred help) and Classic, switched with Gameplay > Menu theme; checked by the person I work for, each build from the shared base through the job queue.
Screenshots from the game-free menu fixture (
scripts/screenshots/capture_menu.py, 1280x720, Medium, no game), menu and start-up screen.mainis the guide's current image; the start-up screen's counts are illustrative.main@03a6e8d0, GraphicsThis PR, Modern dark (default), Graphics

This PR, Modern dark, start-up screen

This PR, Classic, Graphics

This PR, Classic, start-up screen

The fixture renders through SDL's software renderer, which draws the start-up screen's soft background glow darker in the middle than the game does; in the game it is a faint lift behind the logo.
ea67c1b72ffdd6e88ef9Rebased onto main @
e7579b0a. Conflicts: the docs row beside the new FSR 4 model row (both kept) and draw_menu's start beside the ReShade comparison (both kept). The ReShade panels now use the themed box colour. The capture fixture gets stand-ins for the ReShade and FSR 4 model rows' renderer calls, which it no longer linked without on main. The guide image was recaptured from the rebased source (124e4a4d). The renderer pack builds on the new base.WIP: feat(menu): a Modern dark theme for the menu and start-up screen, smaller menu sizes and tabsto feat(menu): a Modern dark theme for the menu and start-up screen, smaller menu sizes and tabs