feat(menu): a Modern dark theme for the menu and start-up screen, smaller menu sizes and tabs #2109

Merged
HumanBean merged 1 commit from HumanBean/Longshot:feat/menu-modern-dark into main 2026-11-21 19:57:07 +00:00
Owner

Summary

The Insert menu and the start-up screen get a new look, Modern dark, now the default, with the old tan and gold kept as
Classic (Gameplay → Menu theme, saved as menu_theme). Modern dark has slate greys, a soft blue for the selected
value and rounded cells, and each row's name and value are drawn as one box. Both themes swap the hazy glow around the
selection for a fine ring. The menu is also a little smaller at every size, with smaller tabs, and the DLSS model row
only shows when the Upscaler is DLSS or DLAA.

  • Menu theme: ui::set_theme() (gpu/vk/vk_ui.h) sets the palette, which is now variables instead of constexpr.
    ui_ctx calls it every frame before anything is drawn, so the menu, the FPS counter and the start-up screen follow
    the row. Colours that were hard-coded in vk_menu.cpp moved into the palette (kShade, kTabEdge, kKeyCap,
    kStartBg, ...). The row is in gpu/vk/menu/menu_settings.cpp, under Menu size, and its key is added to FROZEN.
  • Modern dark rows: name_cell and value_frame / half_box in vk_menu.cpp. Each half is drawn as a whole
    rounded box past the seam and clipped at it on a whole pixel, so the two halves meet with no anti-aliased line.
    Cells that stand apart, like the Controls grid, keep their own box.
  • Sizes: ui::unit is Small 0.78, Medium 0.9 and Large 1.2 (was 0.85, 1.0 and 1.3), so Medium sits between the old
    Small and Medium. The tabs are 20 pt instead of 23, with less padding, and the banner is lower. The help box is
    centred between the banner and the prompts.
  • Start-up screen: it follows the theme, and the flourish under the wordmark is gone.
  • DLSS model row: ur::model_shown(dlss_ok, upscaler) is shown with DLSS or DLAA chosen, where DLSS runs, as the
    DLAA-before-the-bloom row already was.
  • Logo on Windows players' builds: scripts/builder_package.py did not carry assets/longshot.png. A build from
    the Windows builder package therefore compiled the renderer without the logo, and its start-up screen and menu banner
    showed the wordmark alone. The Linux AppImage carries all of assets/. The package now carries the logo.
  • ReShade rows (from main): their two panels use the themed box colour instead of a hard-coded brown.
  • Docs: the guide's settings-graphics.png is recaptured with the game-free fixture, and its manifest entry is
    updated. The settings table gets the Menu theme row, and the DLSS model line says when the row shows. The fixture
    (scripts/screenshots/menu.cpp) applies the theme as the game does, and it can now draw the start-up screen
    (startup) and Classic (<view>-classic). It also gets stand-ins for the ReShade and FSR 4 model rows' renderer calls. Without them it no longer linked on main.

Screenshots of main and both themes, menu and start-up screen, are in the first comment below.

Testing

Tested: Linux (CachyOS, kernel 7.3.3), RTX 3090, NVIDIA 620.70.06. The person I work for ran each build from the
shared base through the job queue and gave feedback, which the later builds address: the selection ring, the joined
rows and their seam, the Q/E caps, the centred help box, and the start-up screen's glow. On the final build: the
start-up screen in Modern dark, the menu's tabs and rows, and switching Menu theme between Modern dark and Classic.
The menu's look in both themes was also checked in the game-free fixture's captures (first comment).

Still to test:

  • Windows, a build from the builder package: start the game and open the menu, expecting the logo on the start-up
    screen and in the banner (by hand: needs a package build).
  • Any PC with DLSS: set the Upscaler to Off, the game's own, FSR or XeSS, expecting the DLSS model row to hide, and to
    show again with DLSS or DLAA (by hand).
  • A 4K window at Large and a 720p window at Small: open each tab, expecting no clipped labels or tabs in either theme
    (@Beanstalk open the Insert menu at Large on a 4K window and at Small at 720p; screenshot each tab in both Menu themes).

Measurements

Nothing to measure: the change is how the menu and the start-up screen draw, only while they show (with both closed the only new work is set_theme's ~45 integer stores on a frame the FPS counter draws), and it adds no translation unit to the build.

Risks

  • A player who liked the old look has to pick Classic once; the theme is saved in longshot_options.ini
    (menu_theme, 0 Modern dark, 1 Classic). An older file has no key and gets Modern dark.
  • The smaller sizes could clip a long translated label where it fitted before. Labels already shrink to fit or end in
    "...", so the risk is lower legibility, not overlap.
  • A revert is enough to undo all of it. Nothing touches saves or caches.
  • The guide manifest's captured_source.revision is 124e4a4d. That is this change's source before the docs went in:
    the same source files as the head, which check_guide_screenshots.py --review-sources compares.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named). (CI runs it: this PC runs no test suites; ticked when CI passes)
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Linux built here; Windows by CI: the menu changes are portable C++ with no paths or platform calls)
  • A check under tests/ that reads changed source is updated, not weakened.
  • Screenshots of the same spot on main and here, for a change that shows on screen.
  • Docs updated.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.

🤖 Generated with Claude Code

## Summary The Insert menu and the start-up screen get a new look, **Modern dark**, now the default, with the old tan and gold kept as **Classic** (Gameplay → **Menu theme**, saved as `menu_theme`). Modern dark has slate greys, a soft blue for the selected value and rounded cells, and each row's name and value are drawn as one box. Both themes swap the hazy glow around the selection for a fine ring. The menu is also a little smaller at every size, with smaller tabs, and the **DLSS model** row only shows when the Upscaler is DLSS or DLAA. - **Menu theme:** `ui::set_theme()` (`gpu/vk/vk_ui.h`) sets the palette, which is now variables instead of `constexpr`. `ui_ctx` calls it every frame before anything is drawn, so the menu, the FPS counter and the start-up screen follow the row. Colours that were hard-coded in `vk_menu.cpp` moved into the palette (`kShade`, `kTabEdge`, `kKeyCap`, `kStartBg`, ...). The row is in `gpu/vk/menu/menu_settings.cpp`, under Menu size, and its key is added to FROZEN. - **Modern dark rows:** `name_cell` and `value_frame` / `half_box` in `vk_menu.cpp`. Each half is drawn as a whole rounded box past the seam and clipped at it on a whole pixel, so the two halves meet with no anti-aliased line. Cells that stand apart, like the Controls grid, keep their own box. - **Sizes:** `ui::unit` is Small 0.78, Medium 0.9 and Large 1.2 (was 0.85, 1.0 and 1.3), so Medium sits between the old Small and Medium. The tabs are 20 pt instead of 23, with less padding, and the banner is lower. The help box is centred between the banner and the prompts. - **Start-up screen:** it follows the theme, and the flourish under the wordmark is gone. - **DLSS model row:** `ur::model_shown(dlss_ok, upscaler)` is shown with DLSS or DLAA chosen, where DLSS runs, as the DLAA-before-the-bloom row already was. - **Logo on Windows players' builds:** `scripts/builder_package.py` did not carry `assets/longshot.png`. A build from the Windows builder package therefore compiled the renderer without the logo, and its start-up screen and menu banner showed the wordmark alone. The Linux AppImage carries all of `assets/`. The package now carries the logo. - **ReShade rows (from `main`):** their two panels use the themed box colour instead of a hard-coded brown. - **Docs:** the guide's `settings-graphics.png` is recaptured with the game-free fixture, and its manifest entry is updated. The settings table gets the Menu theme row, and the DLSS model line says when the row shows. The fixture (`scripts/screenshots/menu.cpp`) applies the theme as the game does, and it can now draw the start-up screen (`startup`) and Classic (`<view>-classic`). It also gets stand-ins for the ReShade and FSR 4 model rows' renderer calls. Without them it no longer linked on `main`. Screenshots of `main` and both themes, menu and start-up screen, are in the first comment below. ## Testing **Tested:** Linux (CachyOS, kernel 7.3.3), RTX 3090, NVIDIA 620.70.06. The person I work for ran each build from the shared base through the job queue and gave feedback, which the later builds address: the selection ring, the joined rows and their seam, the Q/E caps, the centred help box, and the start-up screen's glow. On the final build: the start-up screen in Modern dark, the menu's tabs and rows, and switching Menu theme between Modern dark and Classic. The menu's look in both themes was also checked in the game-free fixture's captures (first comment). **Still to test:** - Windows, a build from the builder package: start the game and open the menu, expecting the logo on the start-up screen and in the banner (by hand: needs a package build). - Any PC with DLSS: set the Upscaler to Off, the game's own, FSR or XeSS, expecting the DLSS model row to hide, and to show again with DLSS or DLAA (by hand). - A 4K window at Large and a 720p window at Small: open each tab, expecting no clipped labels or tabs in either theme (`@Beanstalk open the Insert menu at Large on a 4K window and at Small at 720p; screenshot each tab in both Menu themes`). ## Measurements Nothing to measure: the change is how the menu and the start-up screen draw, only while they show (with both closed the only new work is set_theme's ~45 integer stores on a frame the FPS counter draws), and it adds no translation unit to the build. ## Risks - A player who liked the old look has to pick **Classic** once; the theme is saved in `longshot_options.ini` (`menu_theme`, 0 Modern dark, 1 Classic). An older file has no key and gets Modern dark. - The smaller sizes could clip a long translated label where it fitted before. Labels already shrink to fit or end in "...", so the risk is lower legibility, not overlap. - A revert is enough to undo all of it. Nothing touches saves or caches. - The guide manifest's `captured_source.revision` is `124e4a4d`. That is this change's source before the docs went in: the same source files as the head, which `check_guide_screenshots.py --review-sources` compares. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [ ] `mise run test` passes (any failure that also fails on `main` is named). (CI runs it: this PC runs no test suites; ticked when CI passes) - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [ ] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Linux built here; Windows by CI: the menu changes are portable C++ with no paths or platform calls) - [x] A check under `tests/` that reads changed source is updated, not weakened. - [x] Screenshots of the same spot on `main` and here, for a change that shows on screen. - [x] Docs updated. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
feat(menu): a Modern dark theme for the menu and start-up screen, smaller menu sizes and tabs
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 27s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Workflow lint (actionlint) (pull_request) Successful in 37s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 38s
Third-party parts / As their notes say (pull_request) Successful in 40s
PR description / Description follows the template (pull_request_target) Successful in 14s
CI / Website build and checks (pull_request) Has been cancelled
ea67c1b72f
- Menu theme row (Gameplay, saved as menu_theme): Modern dark (default) or Classic (the
  old tan and gold). The palette is set per frame (ui::set_theme); the menu, the FPS
  counter and the start-up screen follow it.
- Modern dark: slate greys, a soft blue selection, rounded cells, each row's name and
  value one box; the selection's haze replaced by a fine ring.
- Menu size: Small 0.78, Medium 0.9, Large 1.2 (was 0.85, 1.0, 1.3); smaller tabs and
  banner. The help box is centred between the banner and the prompts.
- Start-up screen: no flourish under the wordmark.
- DLSS model row shown only with DLSS or DLAA chosen as the Upscaler.
- Windows builder package carries assets/longshot.png, so players' builds there draw
  the logo.
- Guide screenshot recaptured; the capture fixture applies the theme and can draw the
  start-up screen and Classic.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Owner

Tested in game: Linux (CachyOS 7.3.3), RTX 3090, NVIDIA 620.70.06: the start-up screen in Modern dark at a start; the Insert menu's tabs and rows in Modern dark (rows joined with no seam, the selection's ring, Q/E caps, centred help) and Classic, switched with Gameplay > Menu theme; checked by the person I work for, each build from the shared base through the job queue.

Tested in game: Linux (CachyOS 7.3.3), RTX 3090, NVIDIA 620.70.06: the start-up screen in Modern dark at a start; the Insert menu's tabs and rows in Modern dark (rows joined with no seam, the selection's ring, Q/E caps, centred help) and Classic, switched with Gameplay > Menu theme; checked by the person I work for, each build from the shared base through the job queue.
Author
Owner

Screenshots from the game-free menu fixture (scripts/screenshots/capture_menu.py, 1280x720, Medium, no game), menu and start-up screen. main is the guide's current image; the start-up screen's counts are illustrative.

main @ 03a6e8d0, Graphics
main, Graphics

This PR, Modern dark (default), Graphics
Modern dark, Graphics

This PR, Modern dark, start-up screen
Modern dark, start-up

This PR, Classic, Graphics
Classic, Graphics

This PR, Classic, start-up screen
Classic, start-up

The fixture renders through SDL's software renderer, which draws the start-up screen's soft background glow darker in the middle than the game does; in the game it is a faint lift behind the logo.

Screenshots from the game-free menu fixture (`scripts/screenshots/capture_menu.py`, 1280x720, Medium, no game), menu and start-up screen. `main` is the guide's current image; the start-up screen's counts are illustrative. **`main` @ 03a6e8d0, Graphics** ![main, Graphics](https://git.magicbean.dev/attachments/283272d5-3134-41be-91ec-ea0432d82071) **This PR, Modern dark (default), Graphics** ![Modern dark, Graphics](https://git.magicbean.dev/attachments/d668374b-2192-4fc4-a07a-173f19b6822f) **This PR, Modern dark, start-up screen** ![Modern dark, start-up](https://git.magicbean.dev/attachments/b00a78c5-b14c-406b-873a-c9be36aa45fc) **This PR, Classic, Graphics** ![Classic, Graphics](https://git.magicbean.dev/attachments/0d125d76-44d8-46a6-8c51-172b25cb1983) **This PR, Classic, start-up screen** ![Classic, start-up](https://git.magicbean.dev/attachments/755f161a-79ba-4a60-8716-aeb01b14968c) The fixture renders through SDL's software renderer, which draws the start-up screen's soft background glow darker in the middle than the game does; in the game it is a faint lift behind the logo.
HumanBean force-pushed feat/menu-modern-dark from ea67c1b72f
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 27s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Workflow lint (actionlint) (pull_request) Successful in 37s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 38s
Third-party parts / As their notes say (pull_request) Successful in 40s
PR description / Description follows the template (pull_request_target) Successful in 14s
CI / Website build and checks (pull_request) Has been cancelled
to fdd6e88ef9
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 13s
CI / Workflow lint (actionlint) (pull_request) Successful in 25s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 27s
Third-party parts / As their notes say (pull_request) Successful in 32s
PR description / Description follows the template (pull_request_target) Failing after 14s
CI / Website build and checks (pull_request) Failing after 44s
2026-11-21 19:50:28 +00:00
Compare
Author
Owner

Rebased onto main @ e7579b0a. Conflicts: the docs row beside the new FSR 4 model row (both kept) and draw_menu's start beside the ReShade comparison (both kept). The ReShade panels now use the themed box colour. The capture fixture gets stand-ins for the ReShade and FSR 4 model rows' renderer calls, which it no longer linked without on main. The guide image was recaptured from the rebased source (124e4a4d). The renderer pack builds on the new base.

Rebased onto main @ e7579b0a. Conflicts: the docs row beside the new FSR 4 model row (both kept) and draw_menu's start beside the ReShade comparison (both kept). The ReShade panels now use the themed box colour. The capture fixture gets stand-ins for the ReShade and FSR 4 model rows' renderer calls, which it no longer linked without on main. The guide image was recaptured from the rebased source (124e4a4d). The renderer pack builds on the new base.
HumanBean changed title from WIP: feat(menu): a Modern dark theme for the menu and start-up screen, smaller menu sizes and tabs to feat(menu): a Modern dark theme for the menu and start-up screen, smaller menu sizes and tabs 2026-11-21 19:56:43 +00:00
HumanBean deleted branch feat/menu-modern-dark 2026-11-21 19:57:11 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!2109
No description provided.