feat(ui): add live gameplay HUD placement and shortcut #1855

Merged
HumanBean merged 6 commits from futondestroyer/Longshot:codex/gameplay-hud into main 2026-11-20 21:54:41 +00:00
Member

Summary

Graphics → Screen adds Custom alongside Screen's edges and Middle 16:9. It adjusts the position and size of hearts and magic, action and item buttons, and the minimap. The dungeon's live small-key count follows the minimap. Reset HUD placement restores the default positions and sizes.

The Controls page adds Toggle HUD, initially unbound. A fresh press hides or shows the gameplay HUD for the session. The shortcut takes priority over an overlapping gameplay binding and preserves the assignment for when the shortcut is cleared.

Start with hos_gameplay_hud_screen and classify in host/hos_wide_ui.c. The minimap and live small-key counter are siblings and share a transform. The full map has a separate small-key count and an icon for the owned Boss Key. The shared screen's IsMiniMap state follows #774. If #711 lands too, check both shortcuts with the same D-pad input.

Testing

Tested: Windows 11, RTX 4070, NVIDIA 621.01. The llvm-mingw builds of 9027e737 and f8cc8688 both ran from UTF-8 paths. At the same 21:9 Water Temple camera position on the same disposable one-key checkpoint, Custom moved and scaled the live key count with the minimap. At 16:9 and 21:9, a new W binding hid and restored hearts, magic, items and guides, the minimap, and the key count. The overlapping Move forward binding remained set. Holding W toggled once and Link stayed in place. Original and FSR 3.1 2× frames during camera pans preserved the visible and hidden state.

The full map opened while gameplay HUD was hidden and showed its own small-key count. It showed a gold Boss Key when owned, and the corresponding slot stayed empty in the separate no-Boss-Key run. The Kokiri check reached Saria's cutscene, drew its title and opened the pause map and Longshot settings with the HUD hidden. All completed runs exited normally. The source saves retained their hashes.

The before-fix fixture at abcd0724 failed the live-key transform assertion. The final fixture passes. Removing the key transform and removing the scoped hide each fails its own assertion. The Windows UTF-8 path check and the compiled HUD fixture passed under a non-ASCII temporary path.

All four strict Windows shards ran on each revision with llvm-mingw Clang. Main 9027e737 had 761 passes, 73 failures and 48 skips. Head f8cc8688 had 764 passes, 70 failures and the same 48 skips. Every check that failed on the head also failed on the pinned main. The HUD layout row, pad-after-menu and Walk key checks passed on the head. The local gcc driver resolves to Clang.

Windows checks that also fail on main

tests/test_appimage_player_build.py, tests/test_auto_handheld.py, tests/test_bug_report_defaults.py, tests/test_capture_read_once.py, tests/test_capture_readback_visibility.py, tests/test_crash_dialog.py, tests/test_crt_options.py

tests/test_damage_debug_menu.py, tests/test_dev_ab.py, tests/test_dev_build.py, tests/test_dev_migrate.py, tests/test_dev_packs.py, tests/test_display_startup_failure.py, tests/test_dlss_feature_size.py

tests/test_draw_binds.py, tests/test_draw_stream_visibility.py, tests/test_early_split_before_draw.py, tests/test_failed_compile_keeps_objects.py, tests/test_fastfp_fma.py, tests/test_fma_soft.py, tests/test_fpx_sticky.py

tests/test_frame_overlap.py, tests/test_fsr3fi_hud_layer.py, tests/test_fsr3fi_hudless_colour.py, tests/test_fsr_image_retirement.py, tests/test_fsr_uniform_ownership.py, tests/test_game_menu_mouse_buttons.py, tests/test_guest_imported.py

tests/test_high_fps_fixes.py, tests/test_hold_gpu.py, tests/test_host_guest_writes.py, tests/test_job_queue.py, tests/test_libc_hooks.py, tests/test_lift_cache.py, tests/test_linux_preflight.py

tests/test_linux_pressure.py, tests/test_low_vram_texture_mips.py, tests/test_make_game_ngx.py, tests/test_mise_build.py, tests/test_missing_nup.py, tests/test_mods_list.py, tests/test_ngx_sdk.py

tests/test_pass_barrier.py, tests/test_pending_guest_import.py, tests/test_pipeline_play_cache.py, tests/test_prepare_cache_save.py, tests/test_present_queue_default.py, tests/test_present_source_crop.py, tests/test_profiling_mode.py

tests/test_psychov35_fsr3_fg.py, tests/test_readback_early.py, tests/test_readback_late.py, tests/test_readback_timeout_source.py, tests/test_recording_admission.py, tests/test_replay_write_order.py, tests/test_sampler_admission.py

tests/test_sdiv_overflow.py, tests/test_slow_frames.py, tests/test_song_note_cue.py, tests/test_spawn_emit.py, tests/test_split_before_draw.py, tests/test_staging_burst.py, tests/test_texel_buffer_ownership.py

tests/test_ub_update_batch.py, tests/test_upscaler_rows.py, tests/test_vbytes.py, tests/test_vcore_escape.py, tests/test_vecfp.py, tests/test_vfpx_elem.py, tests/test_vk_occlusion_queries.py

Guide asset integrity passes for all seven images. Guide source review reports 33 mismatches on 9027e737 and 34 on f8cc8688. The added fingerprint is gpu/vk/menu_i18n.h for settings-graphics.png. It contains the updated Custom HUD help translation. The guide still needs review of its affected source records. The offline check ran without Launcher source.

Still to test:

  • Rebase on 2210931c and verify the Windows build and gameplay by hand. Main advanced during validation with packaging and host-cache changes.
  • Verify that the Linux host builds in a UTF-8 path and the focused UTF-8 path fixture passes. See the Beanstalk request on this head, or run the same checks by hand if a Linux worker is available. Run the focused HUD fixture with genuine GCC by hand when available.
  • Review the changed guide source records by hand against the settings graphics fixture.
  • During review, exercise dungeon HUD and FSR-generated frames by hand on Linux and alternate AMD and Intel GPUs.
  • Capture and clear a physical controller binding. Check the overlapping input priority, horse gauge and dive gauge by hand.

Measurements

Verdict: Water Temple -1.3% fps (median 78.3 against 79.3), within the runs' spread (A 78.9 to 79.8, B 76.7 to 80.0). Hyrule Field faster: +0.4% fps (median 117.2 against 116.7), every B run above every A run.

Setup: Windows 11, Core i7-13700F, RTX 4070, NVIDIA 621.01. The default HUD was used on both builds at 1920×1080 output in a 1280×720 window, frame cap lifted, V-Sync and frame generation off. Each scene used the same save and settings and two interleaved pairs. The individual runs measured 20 seconds after a minimum 12-second warm-up and after the scene stopped waiting for pipelines. Startup-wide shader preparation was disabled in both arms (RX_VK_PRECOMPILE=0). All eight runs had zero cold frames. The supervisor's per-run control pipe names were excluded from settings comparison.

Before: main @ 9027e737 After: this PR @ f8cc8688
Water Temple FPS 79.3 78.3
Water Temple 1% low FPS 60.8 57.3
Water Temple median frame time 12.48 ms 12.61 ms
Water Temple p99 frame time 16.47 ms 17.72 ms
Hyrule Field FPS 116.7 117.2
Hyrule Field 1% low FPS 97.3 96.8
Hyrule Field median frame time 8.53 ms 8.49 ms
Hyrule Field p99 frame time 10.28 ms 10.34 ms

Water Temple individual FPS, A1/A2 79.8 / 78.9 and B1/B2 76.7 / 80.0. Hyrule Field individual FPS, A1/A2 116.8 / 116.6 and B1/B2 116.8 / 117.5.

Risks

HUD placement uses known pane names and the shared dungeon map state. Screen's edges restores default placement. Leaving Toggle HUD unbound gives gameplay inputs their ordinary assignments. The full map stays available during HUD hide and restore.

Checklist

Ready for review

  • One topic, on current main. The tested rebase is on 9027e737. Main advanced to 2210931c.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named). Ran the equivalent strict runner in four supported shards.
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files. third_party/ untouched and the patch is GPL-compatible.

When it applies

  • The game-free regression check fails on the prior feature code and passes with the fix.
  • Source-reading checks are updated and retain their assertions.
  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. Windows verified. Linux pending.
  • Screenshots of the same spot on main and here, for a change that shows on screen. Matched Water Temple pair.
  • Docs updated.
  • AI assistance recorded with Assisted-by: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested.
  • Approved in review, every comment answered.
  • CI passes on the head and measurements are current.
## Summary Graphics → Screen adds **Custom** alongside Screen's edges and Middle 16:9. It adjusts the position and size of hearts and magic, action and item buttons, and the minimap. The dungeon's live small-key count follows the minimap. **Reset HUD placement** restores the default positions and sizes. The Controls page adds **Toggle HUD**, initially unbound. A fresh press hides or shows the gameplay HUD for the session. The shortcut takes priority over an overlapping gameplay binding and preserves the assignment for when the shortcut is cleared. Start with `hos_gameplay_hud_screen` and `classify` in `host/hos_wide_ui.c`. The minimap and live small-key counter are siblings and share a transform. The full map has a separate small-key count and an icon for the owned Boss Key. The shared screen's `IsMiniMap` state follows #774. If #711 lands too, check both shortcuts with the same D-pad input. ## Testing **Tested:** Windows 11, RTX 4070, NVIDIA 621.01. The llvm-mingw builds of `9027e737` and `f8cc8688` both ran from UTF-8 paths. At the same 21:9 Water Temple camera position on the same disposable one-key checkpoint, Custom moved and scaled the live key count with the minimap. At 16:9 and 21:9, a new W binding hid and restored hearts, magic, items and guides, the minimap, and the key count. The overlapping Move forward binding remained set. Holding W toggled once and Link stayed in place. Original and FSR 3.1 2× frames during camera pans preserved the visible and hidden state. The full map opened while gameplay HUD was hidden and showed its own small-key count. It showed a gold Boss Key when owned, and the corresponding slot stayed empty in the separate no-Boss-Key run. The Kokiri check reached Saria's cutscene, drew its title and opened the pause map and Longshot settings with the HUD hidden. All completed runs exited normally. The source saves retained their hashes. The before-fix fixture at `abcd0724` failed the live-key transform assertion. The final fixture passes. Removing the key transform and removing the scoped hide each fails its own assertion. The Windows UTF-8 path check and the compiled HUD fixture passed under a non-ASCII temporary path. All four strict Windows shards ran on each revision with llvm-mingw Clang. Main `9027e737` had 761 passes, 73 failures and 48 skips. Head `f8cc8688` had 764 passes, 70 failures and the same 48 skips. Every check that failed on the head also failed on the pinned main. The HUD layout row, pad-after-menu and Walk key checks passed on the head. The local `gcc` driver resolves to Clang. **Windows checks that also fail on main** `tests/test_appimage_player_build.py`, `tests/test_auto_handheld.py`, `tests/test_bug_report_defaults.py`, `tests/test_capture_read_once.py`, `tests/test_capture_readback_visibility.py`, `tests/test_crash_dialog.py`, `tests/test_crt_options.py` `tests/test_damage_debug_menu.py`, `tests/test_dev_ab.py`, `tests/test_dev_build.py`, `tests/test_dev_migrate.py`, `tests/test_dev_packs.py`, `tests/test_display_startup_failure.py`, `tests/test_dlss_feature_size.py` `tests/test_draw_binds.py`, `tests/test_draw_stream_visibility.py`, `tests/test_early_split_before_draw.py`, `tests/test_failed_compile_keeps_objects.py`, `tests/test_fastfp_fma.py`, `tests/test_fma_soft.py`, `tests/test_fpx_sticky.py` `tests/test_frame_overlap.py`, `tests/test_fsr3fi_hud_layer.py`, `tests/test_fsr3fi_hudless_colour.py`, `tests/test_fsr_image_retirement.py`, `tests/test_fsr_uniform_ownership.py`, `tests/test_game_menu_mouse_buttons.py`, `tests/test_guest_imported.py` `tests/test_high_fps_fixes.py`, `tests/test_hold_gpu.py`, `tests/test_host_guest_writes.py`, `tests/test_job_queue.py`, `tests/test_libc_hooks.py`, `tests/test_lift_cache.py`, `tests/test_linux_preflight.py` `tests/test_linux_pressure.py`, `tests/test_low_vram_texture_mips.py`, `tests/test_make_game_ngx.py`, `tests/test_mise_build.py`, `tests/test_missing_nup.py`, `tests/test_mods_list.py`, `tests/test_ngx_sdk.py` `tests/test_pass_barrier.py`, `tests/test_pending_guest_import.py`, `tests/test_pipeline_play_cache.py`, `tests/test_prepare_cache_save.py`, `tests/test_present_queue_default.py`, `tests/test_present_source_crop.py`, `tests/test_profiling_mode.py` `tests/test_psychov35_fsr3_fg.py`, `tests/test_readback_early.py`, `tests/test_readback_late.py`, `tests/test_readback_timeout_source.py`, `tests/test_recording_admission.py`, `tests/test_replay_write_order.py`, `tests/test_sampler_admission.py` `tests/test_sdiv_overflow.py`, `tests/test_slow_frames.py`, `tests/test_song_note_cue.py`, `tests/test_spawn_emit.py`, `tests/test_split_before_draw.py`, `tests/test_staging_burst.py`, `tests/test_texel_buffer_ownership.py` `tests/test_ub_update_batch.py`, `tests/test_upscaler_rows.py`, `tests/test_vbytes.py`, `tests/test_vcore_escape.py`, `tests/test_vecfp.py`, `tests/test_vfpx_elem.py`, `tests/test_vk_occlusion_queries.py` Guide asset integrity passes for all seven images. Guide source review reports 33 mismatches on `9027e737` and 34 on `f8cc8688`. The added fingerprint is `gpu/vk/menu_i18n.h` for `settings-graphics.png`. It contains the updated Custom HUD help translation. The guide still needs review of its affected source records. The offline check ran without Launcher source. **Still to test:** - Rebase on `2210931c` and verify the Windows build and gameplay by hand. Main advanced during validation with packaging and host-cache changes. - Verify that the Linux host builds in a UTF-8 path and the focused UTF-8 path fixture passes. See the [Beanstalk request on this head](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1855#issuecomment-59091), or run the same checks by hand if a Linux worker is available. Run the focused HUD fixture with genuine GCC by hand when available. - Review the changed guide source records by hand against the settings graphics fixture. - During review, exercise dungeon HUD and FSR-generated frames by hand on Linux and alternate AMD and Intel GPUs. - Capture and clear a physical controller binding. Check the overlapping input priority, horse gauge and dive gauge by hand. ## Measurements **Verdict:** Water Temple -1.3% fps (median 78.3 against 79.3), within the runs' spread (A 78.9 to 79.8, B 76.7 to 80.0). Hyrule Field faster: +0.4% fps (median 117.2 against 116.7), every B run above every A run. **Setup:** Windows 11, Core i7-13700F, RTX 4070, NVIDIA 621.01. The default HUD was used on both builds at 1920×1080 output in a 1280×720 window, frame cap lifted, V-Sync and frame generation off. Each scene used the same save and settings and two interleaved pairs. The individual runs measured 20 seconds after a minimum 12-second warm-up and after the scene stopped waiting for pipelines. Startup-wide shader preparation was disabled in both arms (`RX_VK_PRECOMPILE=0`). All eight runs had zero cold frames. The supervisor's per-run control pipe names were excluded from settings comparison. | | Before: main @ `9027e737` | After: this PR @ `f8cc8688` | |---|---|---| | Water Temple FPS | 79.3 | 78.3 | | Water Temple 1% low FPS | 60.8 | 57.3 | | Water Temple median frame time | 12.48 ms | 12.61 ms | | Water Temple p99 frame time | 16.47 ms | 17.72 ms | | Hyrule Field FPS | 116.7 | 117.2 | | Hyrule Field 1% low FPS | 97.3 | 96.8 | | Hyrule Field median frame time | 8.53 ms | 8.49 ms | | Hyrule Field p99 frame time | 10.28 ms | 10.34 ms | Water Temple individual FPS, A1/A2 79.8 / 78.9 and B1/B2 76.7 / 80.0. Hyrule Field individual FPS, A1/A2 116.8 / 116.6 and B1/B2 116.8 / 117.5. ## Risks HUD placement uses known pane names and the shared dungeon map state. **Screen's edges** restores default placement. Leaving **Toggle HUD** unbound gives gameplay inputs their ordinary assignments. The full map stays available during HUD hide and restore. ## Checklist ### Ready for review - [ ] One topic, on current `main`. The tested rebase is on `9027e737`. Main advanced to `2210931c`. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [x] `mise run test` passes (any failure that also fails on `main` is named). Ran the equivalent strict runner in four supported shards. - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files. `third_party/` untouched and the patch is GPL-compatible. ### When it applies - [x] The game-free regression check fails on the prior feature code and passes with the fix. - [x] Source-reading checks are updated and retain their assertions. - [ ] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. Windows verified. Linux pending. - [x] Screenshots of the same spot on `main` and here, for a change that shows on screen. [Matched Water Temple pair](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1855#issuecomment-59081). - [x] Docs updated. - [x] AI assistance recorded with `Assisted-by:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested. - [ ] Approved in review, every comment answered. - [ ] CI passes on the head and measurements are current.
feat(ui): add live gameplay HUD placement and shortcut
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 10s
CI / Workflow lint (actionlint) (pull_request) Successful in 10s
Third-party parts / As their notes say (pull_request) Successful in 12s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 9s
CI / Website build and checks (pull_request) Has been cancelled
5c8ad1381e
Use the gameplay canvas identities and shared-map check established in Longshot #774. Credit Simon Jackson for the scoped map projection approach.

Assisted-by: Codex (GPT-6.2-Sol)
Author
Member

Tested in game: Windows 11 build 26300, RTX 4070 with NVIDIA 621.01. The disposable Kokiri checkpoint reached outdoor play at 16:9 and 21:9. Live W rebinding consumed Move forward, the relocated HUD drew in original and FSR 3.1 2x frames during a pan, and the full map opened while the gameplay HUD was hidden.

Tested in game: Windows 11 build 26300, RTX 4070 with NVIDIA 621.01. The disposable Kokiri checkpoint reached outdoor play at 16:9 and 21:9. Live W rebinding consumed Move forward, the relocated HUD drew in original and FSR 3.1 2x frames during a pan, and the full map opened while the gameplay HUD was hidden.
Member

Possibly related, for context:

  • PR #711 WIP: feat(input): a minimap toggle button, with the choice kept — Touches minimap visibility and shared map state; coordinate integration.
  • issue #1196 Idea: Add an option or hotkey to hide the UI — Implements the requested UI-hide shortcut.
Possibly related, for context: - PR #711 WIP: feat(input): a minimap toggle button, with the choice kept — Touches minimap visibility and shared map state; coordinate integration. - issue #1196 Idea: Add an option or hotkey to hide the UI — Implements the requested UI-hide shortcut.
Author
Member

Rebased the unchanged patch onto 89c3d21e and repeated the Windows 16:9 and 21:9 tests at 631bc464. Both preserved the full map and captured FSR 3.1 generated frames. The one-key Water Temple copy established that the small-key counter stays fixed when Custom moves the minimap. The shortcut hides the gameplay minimap and key counter, while hearts and other HUD elements can remain visible. The PR stays WIP with both findings.

Rebased the unchanged patch onto 89c3d21e and repeated the Windows 16:9 and 21:9 tests at 631bc464. Both preserved the full map and captured FSR 3.1 generated frames. The one-key Water Temple copy established that the small-key counter stays fixed when Custom moves the minimap. The shortcut hides the gameplay minimap and key counter, while hearts and other HUD elements can remain visible. The PR stays WIP with both findings.
futondestroyer force-pushed codex/gameplay-hud from 5c8ad1381e
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 10s
CI / Workflow lint (actionlint) (pull_request) Successful in 10s
Third-party parts / As their notes say (pull_request) Successful in 12s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 9s
CI / Website build and checks (pull_request) Has been cancelled
to 631bc46431
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
PR description / Description follows the template (pull_request_target) Successful in 10s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 12s
CI / Workflow lint (actionlint) (pull_request) Successful in 13s
Third-party parts / As their notes say (pull_request) Successful in 15s
CI / Website build and checks (pull_request) Has been cancelled
2026-11-20 13:40:55 +00:00
Compare
test(ui): exercise HUD shortcut in the background-input fixture
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 11s
CI / Conventional Commit title (pull_request) Successful in 11s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 17s
CI / Workflow lint (actionlint) (pull_request) Successful in 17s
Third-party parts / As their notes say (pull_request) Successful in 19s
CI / Website build and checks (pull_request) Has been cancelled
9076ab9225
Use the real shortcut helpers with an unbound input. Document where the
live small-key count and full-map key badges appear.

Assisted-by: Codex (GPT-6.2-Sol)
Update the existing translations for the Custom HUD description. Cover
the HUD placement sliders and unbound shortcut in menu fixtures.

Assisted-by: Codex (GPT-6.2-Sol)
test(ui): keep Alt-Enter and upscaler checks on the HUD branch
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 9s
PR description / Description follows the template (pull_request_target) Successful in 14s
CI / Workflow lint (actionlint) (pull_request) Successful in 15s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 16s
Third-party parts / As their notes say (pull_request) Successful in 18s
CI / Website build and checks (pull_request) Has been cancelled
591ab53134
Check bound keys through the new local key code. Add the unbound HUD
option symbol to the upscaler fixture's input stub.

Assisted-by: Codex (GPT-6.2-Sol)
Author
Member

The Water Temple small-key count now moves and scales with the minimap. Toggle HUD hides and restores the gameplay HUD and the full map keeps both key badges. Verified Windows gameplay at 16:9 and 21:9 with original and FSR 3.1 generated frames, plus Kokiri cutscene and menu behavior. All 22 focused checks pass on 591ab531. The five strict-suite failures specific to this PR now pass. The other 69 checks also failed on the tested main 89c3d21e. The description records the rebase and retest still needed for 70d22cf1.

The Water Temple small-key count now moves and scales with the minimap. Toggle HUD hides and restores the gameplay HUD and the full map keeps both key badges. Verified Windows gameplay at 16:9 and 21:9 with original and FSR 3.1 generated frames, plus Kokiri cutscene and menu behavior. All 22 focused checks pass on 591ab531. The five strict-suite failures specific to this PR now pass. The other 69 checks also failed on the tested main 89c3d21e. The description records the rebase and retest still needed for 70d22cf1.
First-time contributor

Hi, nice work on this: live HUD placement and a Toggle HUD key are great additions.

I've been working on something close in Hookshot (a per-element HUD editor, upstream PR https://git.notrexed.dev/Hookshot/Hookshot/pulls/3099), and I have it running in
a Longshot build too. I don't want to step on your PR, so I'd rather build on yours than open a competing one.

What mine has that this PR doesn't seem to cover yet, in case any of it is useful:

  • Opacity per element, and hide per element (Toggle HUD hides everything at once; this keeps, say, the hearts and hides the rest).
  • Finer elements: the hearts and the magic bar apart, the item buttons and the top-right buttons apart, the place name, and the dungeon minimap apart from the area
    minimap (they don't sit in the same spot).
  • Presets: Full and Minimal (hearts only), plus a size and an opacity for the whole HUD on top of each element's own.
  • Three slots to save and load whole layouts.
  • Placement in percent of the screen, clamped to the measured edges of each element, so nothing goes off screen on any aspect ratio.

Next on my list is an on-screen edit mode: drag the HUD elements with the mouse (or move them with the stick) and set them from a small floating panel, without going
through the menu rows. Since your PR already places the HUD live, is that something you were planning too? I'd rather not build the same thing twice.

Once this is merged, I'd be happy to send those as small follow-up PRs on top of your Custom layout (same rows and same placement code, nothing duplicated, and keeping
your small-key counter with the minimap). Or if you'd rather fold some of it in here, I can share the code. Which would you prefer?

Hi, nice work on this: live HUD placement and a Toggle HUD key are great additions. I've been working on something close in Hookshot (a per-element HUD editor, upstream PR https://git.notrexed.dev/Hookshot/Hookshot/pulls/3099), and I have it running in a Longshot build too. I don't want to step on your PR, so I'd rather build on yours than open a competing one. What mine has that this PR doesn't seem to cover yet, in case any of it is useful: - **Opacity per element**, and **hide per element** (Toggle HUD hides everything at once; this keeps, say, the hearts and hides the rest). - **Finer elements**: the hearts and the magic bar apart, the item buttons and the top-right buttons apart, the place name, and the dungeon minimap apart from the area minimap (they don't sit in the same spot). - **Presets**: Full and Minimal (hearts only), plus a size and an opacity for the whole HUD on top of each element's own. - **Three slots** to save and load whole layouts. - Placement in percent of the screen, clamped to the measured edges of each element, so nothing goes off screen on any aspect ratio. Next on my list is an on-screen edit mode: drag the HUD elements with the mouse (or move them with the stick) and set them from a small floating panel, without going through the menu rows. Since your PR already places the HUD live, is that something you were planning too? I'd rather not build the same thing twice. Once this is merged, I'd be happy to send those as small follow-up PRs on top of your Custom layout (same rows and same placement code, nothing duplicated, and keeping your small-key counter with the minimap). Or if you'd rather fold some of it in here, I can share the code. Which would you prefer?
futondestroyer force-pushed codex/gameplay-hud from 591ab53134
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 9s
PR description / Description follows the template (pull_request_target) Successful in 14s
CI / Workflow lint (actionlint) (pull_request) Successful in 15s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 16s
Third-party parts / As their notes say (pull_request) Successful in 18s
CI / Website build and checks (pull_request) Has been cancelled
to f8cc868845
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 15s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 21s
CI / Workflow lint (actionlint) (pull_request) Successful in 24s
Third-party parts / As their notes say (pull_request) Successful in 27s
Website / Website on Cloudflare (pull_request_target) Has been skipped
beanstalk/approval needs a second approval (sensitive paths)
PR description / Description follows the template (pull_request_target) Successful in 16s
CI / Website build and checks (pull_request) Has been cancelled
2026-11-20 16:34:46 +00:00
Compare
Author
Member

Rebased six identical patches onto main 9027e737. Exact head f8cc8688 passed Windows Water Temple gameplay at 16:9 and 21:9, including Custom placement, HUD hide and restore, both dungeon key indicators, and FSR 3.1 generated frames. All 70 strict-suite failures also failed on the tested main. The description records the two-scene timing, Guide source drift, and outstanding review gates. Main has since advanced to 2210931c.

Rebased six identical patches onto main `9027e737`. Exact head `f8cc8688` passed Windows Water Temple gameplay at 16:9 and 21:9, including Custom placement, HUD hide and restore, both dungeon key indicators, and FSR 3.1 generated frames. All 70 strict-suite failures also failed on the tested main. The description records the two-scene timing, Guide source drift, and outstanding review gates. Main has since advanced to `2210931c`.
Author
Member

The same Water Temple room and camera at 21:9, with one unspent small key.

Main 9027e737, Screen's edges

Default HUD in Water Temple

PR f8cc8688, Custom

Custom HUD in Water Temple

The same Water Temple room and camera at 21:9, with one unspent small key. **Main `9027e737`, Screen's edges** ![Default HUD in Water Temple](https://git.magicbean.dev/attachments/5a0d0f34-df0c-4bed-89f7-16457e0d2e14) **PR `f8cc8688`, Custom** ![Custom HUD in Water Temple](https://git.magicbean.dev/attachments/3e7091c0-b37c-450b-bb02-74885c748742)
Author
Member

@Beanstalk Please test the Linux host build and UTF-8 path handling on the current PR head f8cc86884592ac3f182230d20aea46c79a43b6b6. Use a Linux worker with the documented host toolchain, put the build workspace or output under a path containing a non-ASCII character, and run the repository's focused UTF-8 path fixture. Expected results are a successful host build and a passing fixture. Please report the tested commit, distro, compiler, and build and fixture results. This request covers those two Linux checks.

@Beanstalk Please test the Linux host build and UTF-8 path handling on the current PR head `f8cc86884592ac3f182230d20aea46c79a43b6b6`. Use a Linux worker with the documented host toolchain, put the build workspace or output under a path containing a non-ASCII character, and run the repository's focused UTF-8 path fixture. Expected results are a successful host build and a passing fixture. Please report the tested commit, distro, compiler, and build and fixture results. This request covers those two Linux checks.
Member

@futondestroyer approval of f8cc868 recorded. This diff touches sensitive paths, so a second member of BigBeans must approve it too.

@futondestroyer approval of `f8cc868` recorded. This diff touches sensitive paths, so a second member of `BigBeans` must approve it too.
Member

Beanstalk test farm

Commit 3d1941b · approved by nobody yet · dashboard

A member of BigBeans can review this commit and comment @Beanstalk to test it.

<!-- beanstalk:sticky --> ### Beanstalk test farm Commit `3d1941b` · approved by nobody yet · [dashboard](https://beanstalk.magicbean.dev/prs/1855) A member of `BigBeans` can review this commit and comment `@Beanstalk` to test it.
Owner
@rebase
Member

I rebased this pull request onto main (e0ef1b5721): the new head is 3d1941bd96.

Conflicts resolved:

  • gpu/vk/vk_api.h: Kept the HUD placement options and DualSense HD haptics option.
  • gpu/vk/vk_menu.cpp: Kept both colour vision initialization and HUD placement synchronization.

Nothing was built or run: read the resolution before merging.


Automated rebase by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

I rebased this pull request onto `main` (e0ef1b572108): the new head is 3d1941bd96bd. Conflicts resolved: - gpu/vk/vk_api.h: Kept the HUD placement options and DualSense HD haptics option. - gpu/vk/vk_menu.cpp: Kept both colour vision initialization and HUD placement synchronization. Nothing was built or run: read the resolution before merging. --- <sub>Automated rebase by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
BeanBot force-pushed codex/gameplay-hud from f8cc868845
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 15s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 21s
CI / Workflow lint (actionlint) (pull_request) Successful in 24s
Third-party parts / As their notes say (pull_request) Successful in 27s
Website / Website on Cloudflare (pull_request_target) Has been skipped
beanstalk/approval needs a second approval (sensitive paths)
PR description / Description follows the template (pull_request_target) Successful in 16s
CI / Website build and checks (pull_request) Has been cancelled
to 3d1941bd96
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 24s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 32s
CI / Workflow lint (actionlint) (pull_request) Successful in 33s
Third-party parts / As their notes say (pull_request) Successful in 36s
beanstalk/approval not approved yet
PR description / Description follows the template (pull_request_target) Failing after 18s
CI / Website build and checks (pull_request) Failing after 24s
2026-11-20 21:53:44 +00:00
Compare
HumanBean changed title from WIP: feat(ui): add live gameplay HUD placement and shortcut to feat(ui): add live gameplay HUD placement and shortcut 2026-11-20 21:54:21 +00:00
HumanBean deleted branch codex/gameplay-hud 2026-11-20 21:54:42 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1855
No description provided.