feat(saves): castle-gate, child Link in Hyrule Field at Castle Town's gate, by day #1722
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1722
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:feat/save-castle-gate"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: feat · Risk: low · Tested on: CachyOS Linux, RTX 3090 (NVIDIA 620.70.06) · Needs: none
TL;DR
The Test Farm can only start a run from Link's house in Kokiri Forest, so a test of the way from Castle Town's gate across the drawbridge into Hyrule Field had nowhere to begin. This adds a second repository save,
castle-gate: child Link in Hyrule Field at the town's gate, on the drawbridge's end, by day. It was made from a fresh profile and scrubbed likekokiri-start; it passescheck-repo-savesand loads there in the game.Breakdown
assets/saves/castle-gate, and its row in the saves' README.kokiri-start; nothing for a player.check-repo-savespasses; launched with--repo-save castle-gate, it loads in Hyrule Field at the gate (state play, child, no event).launch --repo-saveandcheck-repo-saves.Why
The Test Farm's planner asked for a start at Castle Town's gate for a gate-to-drawbridge route (for #916's kind of test), and
kokiri-startis the only repository save, so a run had to get there by a teleport and a walk of its own every time. With this save a run starts on the drawbridge, by day, in the same place on every PC. The tracker has no issue for it (searched: "repo save", "assets/saves").What changed
A new repository save,
castle-gate, made fresh from a new profile and scrubbed withlongshot_saves.py scrub, and its row in the saves' README.assets/saves/castle-gate/slot_00/:progress.sav(the game's save, unchanged) andcaption.sav(its picture mid-grey, its date 2026-01-01 00:00). Noaccount.savoroption.sav.assets/saves/castle-gate/README.md: where the save stands (its first line) and how it was made.assets/saves/README.md: the save's row in the table.How it was made, on this PC (CachyOS Linux, RTX 3090, NVIDIA 620.70.06; Longshot v3.0.0-rc.7-111-gda91e7702, main
da91e770): a new profile with onlykokiri-startin it (longshot_ctl.py launch <game> --profile test --repo-save kokiri-start --headless, an empty options file so every setting is at its default and the Autosave row On), Continue on the title, then through the control bridgeteleport Market_Child(Link arrives in the Market's gate facing the town; that arrival writes no save: the save trace logged the requests and no slot changed) and the left stick held back for 240 frames, which walks him out through the gate into Hyrule Field. The game's own transition autosave as he arrived (slot_01: scene HyruleField, map HyruleField/HyruleField_Child, 3 hearts, by day) is this save. Nothing else was done in the game; the story is a new game's, as inkokiri-start. Scrubbed on this PC, so the original picture never left it:The save holds no game data:
check-repo-savespasses, andprogress.sav's readable strings are only the game's own names (HyruleField_Child,Goto_HyruleCastle,Item_Wallet_Smalland the like), with no paths or names from the PC.Measurements
Nothing to measure: this adds a save and a README row, no code; it is checked by
check-repo-saves, the saves' tests and a load in the game (Testing).Flags and settings
None
Testing
Tested:
python -I scripts/longshot_saves.py check-repo-saves: passes.tests/test_longshot_saves.py(77 tests, OK, 1 skipped) andtests/test_longshot_ctl.py(51 tests, OK), on Linux.python -I -B tests/run_all.pyon this PC (Linux, a jj workspace of this branch onmain@9b82abf6, before the rebase onto99a7e249, which touched nothing here): 692 passed, 37 failed, 97 skipped. 36 of the failures also fail onmain@9b82abf6in a clean workspace (run_all.py --exacton them: 36 of 36 fail; they need tools or files that workspace lacks):test_bug_report,test_bug_report_defaults,test_capture_read_once,test_crash_groups,test_crt_options,test_damage_debug_menu,test_dev_packs,test_display_startup_failure,test_dlss_feature_size,test_failed_compile_keeps_objects,test_guest_imported,test_hardware_report,test_high_fps_fixes,test_host_guest_writes,test_hud_layout_row,test_invalidate_quick,test_libc_hooks,test_linux_preflight,test_linux_pressure,test_linux_update,test_log_open_failure,test_missing_nup,test_mods_size_table,test_pending_guest_import,test_pipeline_play_cache,test_prepare_cache_save,test_present_thread,test_profiling_mode,test_psychov35_fsr3_fg,test_readback_timeout_source,test_slow_frames,test_song_note_cue,test_switch_table,test_upscaler_rows,test_vcore_escape,test_walk_key. The 37th,test_vbytes, hit the runner's 600 s timeout on a busy PC (a timed run beside it); it reads none of the saves (a lift check); onmain@9b82abf6alone, with--timeout 1800, it passed in 1,399 s, past the default 600 s, so it times out onmaintoo with the default (this branch changes no code it builds).longshot_ctl.py launch <game> --profile test --repo-save castle-gate --headlessinto a new run folder copied onlyslot_00/in; A on the title loaded it, andstatusread stateplay, mapHyruleField_Child, agechild, no event, no load, 3 hearts, Link at [-0.04, 150.61, 32.78] facing 0 (out of the gate). The shot below is that load.Not tested: Windows (the save is the game's own files, the same on both;
launch --repo-saveis covered by #543's tests).Must be tested: None
Risks
What could break: Nothing in the game or the build: two save files and README text, read only by
launch --repo-saveandcheck-repo-saves. The saves' README table gains a row, so a sibling save PR (market-entrance) touches the same table and the second one merged takes a one-line rebase.Turning it off: revert the commit.
Compatibility: Nothing changes for a player.
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.🤖 Generated with Claude Code
Tested in game: CachyOS Linux, RTX 3090, NVIDIA 620.70.06, headless: launch --profile test --repo-save castle-gate, A on the title: state play, map HyruleField_Child, age child, no event, 3 hearts, Link on the drawbridge's town end facing the Field, by day
The full run_all's one timeout, test_vbytes, ran on main alone with a longer timeout: it passes in 1,399 s, past the default 600 s, so it times out on main too. Testing updated; marking ready.
WIP: feat(saves): castle-gate, child Link in Hyrule Field at Castle Town's gate, by dayto feat(saves): castle-gate, child Link in Hyrule Field at Castle Town's gate, by dayRecommendation: Wait on current-main save validation and the red Guide screenshots check. The submitted save has documented fresh-profile provenance and the permitted one-slot layout.
Does it help: This gives the Test Farm a repeatable castle-gate starting point. Performance measurement does not apply.
Other systems: This adds a save and catalog entry. There is no runtime code change.
Switches: None.
Reviewed:
35d9d877against99a7e249. Checked the tree layout, catalog, and provenance README, and read the author's validation report. Nothing run.Fixed in this review: Nothing.
Checked and fine: The patch adds only the README and regular progress/caption files in slot_00, plus the catalog entry. No profile settings or links. HumanBean documents an isolated profile seeded with the approved Kokiri save, the transition autosave after leaving the gate, and a child/day reload facing Hyrule Field with no active event. The reported scrub and check-repo-saves passed, and the author smoke-loaded it on CachyOS with an RTX 3090.
Testing: The description check passed. The Guide screenshots check failed, and the source checks were skipped. Please establish whether the failure reproduces on the exact control and clear the merge gate. Current main changed the save launch tooling. On the rebased pair, refresh check-repo-saves and smoke-load castle-gate through the current documented repo-save path. Each save requires two distinct eligible maintainer approvals before merge.
Overlaps and merge order: #1723 adds its own save and touches the same catalog. Either can go first. The second rebase should keep both rows and the current documentation link.
@rebase
I rebased this pull request onto
main(2b3de5b27a): the new head isde1242c7df.Conflicts resolved
Nothing was built or run: read the resolution before merging.
Automated rebase by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
35d9d877b9de1242c7dfRecommendation: Request changes. The save gives the Test Farm the intended drawbridge start, and its two files match the Linux smoke-tested revision. The PR description fails the current review template and needs to record validation through the rebased launch path.
Adds an opt-in daytime start at the town end of the drawbridge, with child Link facing Hyrule Field. It removes the setup walk for that Test Farm route and adds about 123 KiB of save data without changing runtime code or defaults.
@fixwill do (5)## Summary,Still to test, and### Ready for review, all absent from this body. Move the evidence into the current template, use its merge checklist, and keep Measurements to the single line explaining why no performance measurement applies.kokiri-startthe only repository save and predicts a future rebase withmarket-entrance. Base2b3de5b2already contains #1723 and its catalog row. Explain thatmarket-entrancestarts inside the Market facing inward, while this save starts on the Field side facing out, and remove the pending-overlap claim.launch --repo-saveandcheck-repo-saves.saves --reporeads the new README, andmemtouranddev.py abcan load the slot through the shared launcher. Describe the effect as an additional selectable repository save across these tools.Goto_HyruleCastleas a readable string in the submitted progress file. It appears inmarket-entrance, while this slot hasMeet_DekuTree. Correct the example and describecheck-repo-savesas a layout and scrub check. Forprogress.sav, it checks file type and size rather than provenance.assets/saves/castle-gate/README.md:9: The README says the stick was held for four seconds, while the PR records 240 game frames. (more on the line)For the author (1) (a run, a measurement or a decision)
longshot_bridge.pysupervisor. Runcheck-repo-savesand smoke-loadcastle-gatefrom a fresh test profile atde1242c7. Confirm the map, age, daylight, and outward facing, and record the required lint and strict suite results for the rebased branch.More: does it help, other systems, switches, what was read
Does it help: Not a perf change. The author's CachyOS Linux smoke test at
35d9d877loaded into HyruleField_Child in play as child Link, with three hearts and no active event. Both save blobs are identical atde1242c7.Other systems:
saves --repolists the new entry. Test Farm launches,memtour, anddev.py abcan select it through the shared save-copy path. The diff changes no player save migration, renderer, build, audio, or input code. Windows and Steam Deck loads were not reported.Switches: None.
Reviewed:
de1242c7dfagainst2b3de5b27a: Read AGENTS.md, CONTRIBUTING.md, the current Forgejo template, developer standards, both changed READMEs, the full diff, the commit and its trailers, and the supplied comments, review, and CI summary. Read the relevant validator, scrubber, launch and listing paths, save-copy code, tests, and downstream callers. Inspected the two binary files by size, blob identity, header, thumbnail comparison, and readable strings. Used the author's report for game behavior. The linked screenshot and external CI logs were unavailable in the checkout. No review-checklist file was present.; nothing run (a code review).Checked and fine:
Testing: Read-only review. The author reports a validator pass, 77 save tests with one skip, 51 control-client tests, and a successful Linux smoke load before the rebase. The older full run reported 692 passed, 37 failed, and 97 skipped. The author reproduced 36 failures on its old base, and
test_vbytestook 1,399 seconds there with an extended timeout. Current CI data lists no failures or running checks and includes no passing result. The Guide screenshots failure belongs to the stale review. Merge requires two maintainer approvals.Overlaps and merge order: #1723 (
market-entrance) is already in base2b3de5b2. The rebase kept both catalog entries and the current documentation link. No remaining merge-order dependency found.Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its rebase. Nothing was run; a maintainer decides.
@ -0,0 +6,4 @@profile with only `kokiri-start` in it (`longshot_ctl.py launch <game> --profile test --repo-save kokiri-start--headless`, the options file empty, so every setting at its default and the Autosave row On), Continue on the title,then through the control bridge `teleport Market_Child` (Link arrives in the Market's gate, facing the town; theteleport's arrival writes no save) and the left stick held back for 4 seconds, which walks him out of the gate intoL5 (minor): The README says the stick was held for four seconds, while the PR records 240 game frames. A four-second wall-clock hold at 30 fps supplies only about half that input. Record the 240-frame hold so someone recreating the save can repeat it.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.