feat(saves): castle-gate, child Link in Hyrule Field at Castle Town's gate, by day #1722

Open
HumanBean wants to merge 1 commit from HumanBean/Longshot:feat/save-castle-gate into main
Owner

Type: feat · Risk: low · Tested on: CachyOS Linux, RTX 3090 (NVIDIA 620.70.06) · Needs: none

TL;DR

The Test Farm can only start a run from Link's house in Kokiri Forest, so a test of the way from Castle Town's gate across the drawbridge into Hyrule Field had nowhere to begin. This adds a second repository save, castle-gate: child Link in Hyrule Field at the town's gate, on the drawbridge's end, by day. It was made from a fresh profile and scrubbed like kokiri-start; it passes check-repo-saves and loads there in the game.

Breakdown

  • Who it helps: the Test Farm and anyone testing a change on the way between Castle Town and Hyrule Field.
  • What was wrong: the only repository save is in Kokiri Forest, and a teleport to Hyrule Field arrives at the Lost Woods bridge, far from the town.
  • What changes: a new save, assets/saves/castle-gate, and its row in the saves' README.
  • What does not change: the game, the scripts, kokiri-start; nothing for a player.
  • How it was checked: check-repo-saves passes; launched with --repo-save castle-gate, it loads in Hyrule Field at the gate (state play, child, no event).
  • What is still open: nothing.
  • Risk: low: two save files and README text, read only by launch --repo-save and check-repo-saves.

Why

The Test Farm's planner asked for a start at Castle Town's gate for a gate-to-drawbridge route (for #916's kind of test), and kokiri-start is the only repository save, so a run had to get there by a teleport and a walk of its own every time. With this save a run starts on the drawbridge, by day, in the same place on every PC. The tracker has no issue for it (searched: "repo save", "assets/saves").

What changed

A new repository save, castle-gate, made fresh from a new profile and scrubbed with longshot_saves.py scrub, and its row in the saves' README.

  • assets/saves/castle-gate/slot_00/: progress.sav (the game's save, unchanged) and caption.sav (its picture mid-grey, its date 2026-01-01 00:00). No account.sav or option.sav.
  • assets/saves/castle-gate/README.md: where the save stands (its first line) and how it was made.
  • assets/saves/README.md: the save's row in the table.

How it was made, on this PC (CachyOS Linux, RTX 3090, NVIDIA 620.70.06; Longshot v3.0.0-rc.7-111-gda91e7702, main da91e770): a new profile with only kokiri-start in it (longshot_ctl.py launch <game> --profile test --repo-save kokiri-start --headless, an empty options file so every setting is at its default and the Autosave row On), Continue on the title, then through the control bridge teleport Market_Child (Link arrives in the Market's gate facing the town; that arrival writes no save: the save trace logged the requests and no slot changed) and the left stick held back for 240 frames, which walks him out through the gate into Hyrule Field. The game's own transition autosave as he arrived (slot_01: scene HyruleField, map HyruleField/HyruleField_Child, 3 hearts, by day) is this save. Nothing else was done in the game; the story is a new game's, as in kokiri-start. Scrubbed on this PC, so the original picture never left it:

caption.sav: the save date (month at 280): 11 -> 1
caption.sav: the save date (day at 312): 19 -> 1
caption.sav: the save date (hour at 328): 2 -> 0
caption.sav: the save date (minute at 304): 16 -> 0
caption.sav: the save date (second at 288): 1 -> 0
caption.sav: the picture at 1396 (JPEG 543x306, 38398 bytes) replaced by a mid-grey JPEG 543x306 of 3345 bytes
caption.sav: 39794 -> 4741 bytes; the rest of its header kept as it was (scene HyruleField, map HyruleField/HyruleField_Child)
progress.sav: copied unchanged

The save holds no game data: check-repo-saves passes, and progress.sav's readable strings are only the game's own names (HyruleField_Child, Goto_HyruleCastle, Item_Wallet_Small and the like), with no paths or names from the PC.

Measurements

Nothing to measure: this adds a save and a README row, no code; it is checked by check-repo-saves, the saves' tests and a load in the game (Testing).

Flags and settings

None

Testing

Tested:

  • python -I scripts/longshot_saves.py check-repo-saves: passes.
  • tests/test_longshot_saves.py (77 tests, OK, 1 skipped) and tests/test_longshot_ctl.py (51 tests, OK), on Linux.
  • python -I -B tests/run_all.py on this PC (Linux, a jj workspace of this branch on main @ 9b82abf6, before the rebase onto 99a7e249, which touched nothing here): 692 passed, 37 failed, 97 skipped. 36 of the failures also fail on main @ 9b82abf6 in a clean workspace (run_all.py --exact on them: 36 of 36 fail; they need tools or files that workspace lacks): test_bug_report, test_bug_report_defaults, test_capture_read_once, test_crash_groups, test_crt_options, test_damage_debug_menu, test_dev_packs, test_display_startup_failure, test_dlss_feature_size, test_failed_compile_keeps_objects, test_guest_imported, test_hardware_report, test_high_fps_fixes, test_host_guest_writes, test_hud_layout_row, test_invalidate_quick, test_libc_hooks, test_linux_preflight, test_linux_pressure, test_linux_update, test_log_open_failure, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_pipeline_play_cache, test_prepare_cache_save, test_present_thread, test_profiling_mode, test_psychov35_fsr3_fg, test_readback_timeout_source, test_slow_frames, test_song_note_cue, test_switch_table, test_upscaler_rows, test_vcore_escape, test_walk_key. The 37th, test_vbytes, hit the runner's 600 s timeout on a busy PC (a timed run beside it); it reads none of the saves (a lift check); on main @ 9b82abf6 alone, with --timeout 1800, it passed in 1,399 s, past the default 600 s, so it times out on main too with the default (this branch changes no code it builds).
  • In the game, on this PC (headless): longshot_ctl.py launch <game> --profile test --repo-save castle-gate --headless into a new run folder copied only slot_00/ in; A on the title loaded it, and status read state play, map HyruleField_Child, age child, no event, no load, 3 hearts, Link at [-0.04, 150.61, 32.78] facing 0 (out of the gate). The shot below is that load.

castle-gate, loaded with --repo-save: this PR @ 35d9d877

Not tested: Windows (the save is the game's own files, the same on both; launch --repo-save is covered by #543's tests).

Must be tested: None

Risks

What could break: Nothing in the game or the build: two save files and README text, read only by launch --repo-save and check-repo-saves. The saves' README table gains a row, so a sibling save PR (market-entrance) touches the same table and the second one merged takes a one-line rebase.

Turning it off: revert the commit.

Compatibility: Nothing changes for a player.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen.
  • Docs updated.

🤖 Generated with Claude Code

**Type:** feat · **Risk:** low · **Tested on:** CachyOS Linux, RTX 3090 (NVIDIA 620.70.06) · **Needs:** none ## TL;DR The Test Farm can only start a run from Link's house in Kokiri Forest, so a test of the way from Castle Town's gate across the drawbridge into Hyrule Field had nowhere to begin. This adds a second repository save, `castle-gate`: child Link in Hyrule Field at the town's gate, on the drawbridge's end, by day. It was made from a fresh profile and scrubbed like `kokiri-start`; it passes `check-repo-saves` and loads there in the game. ## Breakdown - **Who it helps:** the Test Farm and anyone testing a change on the way between Castle Town and Hyrule Field. - **What was wrong:** the only repository save is in Kokiri Forest, and a teleport to Hyrule Field arrives at the Lost Woods bridge, far from the town. - **What changes:** a new save, `assets/saves/castle-gate`, and its row in the saves' README. - **What does not change:** the game, the scripts, `kokiri-start`; nothing for a player. - **How it was checked:** `check-repo-saves` passes; launched with `--repo-save castle-gate`, it loads in Hyrule Field at the gate (state play, child, no event). - **What is still open:** nothing. - **Risk:** low: two save files and README text, read only by `launch --repo-save` and `check-repo-saves`. ## Why The Test Farm's planner asked for a start at Castle Town's gate for a gate-to-drawbridge route (for #916's kind of test), and `kokiri-start` is the only repository save, so a run had to get there by a teleport and a walk of its own every time. With this save a run starts on the drawbridge, by day, in the same place on every PC. The tracker has no issue for it (searched: "repo save", "assets/saves"). ## What changed A new repository save, `castle-gate`, made fresh from a new profile and scrubbed with `longshot_saves.py scrub`, and its row in the saves' README. - `assets/saves/castle-gate/slot_00/`: `progress.sav` (the game's save, unchanged) and `caption.sav` (its picture mid-grey, its date 2026-01-01 00:00). No `account.sav` or `option.sav`. - `assets/saves/castle-gate/README.md`: where the save stands (its first line) and how it was made. - `assets/saves/README.md`: the save's row in the table. How it was made, on this PC (CachyOS Linux, RTX 3090, NVIDIA 620.70.06; Longshot v3.0.0-rc.7-111-gda91e7702, main da91e770): a new profile with only `kokiri-start` in it (`longshot_ctl.py launch <game> --profile test --repo-save kokiri-start --headless`, an empty options file so every setting is at its default and the Autosave row On), Continue on the title, then through the control bridge `teleport Market_Child` (Link arrives in the Market's gate facing the town; that arrival writes no save: the save trace logged the requests and no slot changed) and the left stick held back for 240 frames, which walks him out through the gate into Hyrule Field. The game's own transition autosave as he arrived (slot_01: scene HyruleField, map HyruleField/HyruleField_Child, 3 hearts, by day) is this save. Nothing else was done in the game; the story is a new game's, as in `kokiri-start`. Scrubbed on this PC, so the original picture never left it: ``` caption.sav: the save date (month at 280): 11 -> 1 caption.sav: the save date (day at 312): 19 -> 1 caption.sav: the save date (hour at 328): 2 -> 0 caption.sav: the save date (minute at 304): 16 -> 0 caption.sav: the save date (second at 288): 1 -> 0 caption.sav: the picture at 1396 (JPEG 543x306, 38398 bytes) replaced by a mid-grey JPEG 543x306 of 3345 bytes caption.sav: 39794 -> 4741 bytes; the rest of its header kept as it was (scene HyruleField, map HyruleField/HyruleField_Child) progress.sav: copied unchanged ``` The save holds no game data: `check-repo-saves` passes, and `progress.sav`'s readable strings are only the game's own names (`HyruleField_Child`, `Goto_HyruleCastle`, `Item_Wallet_Small` and the like), with no paths or names from the PC. ## Measurements Nothing to measure: this adds a save and a README row, no code; it is checked by `check-repo-saves`, the saves' tests and a load in the game (Testing). ### Flags and settings None ## Testing **Tested:** - `python -I scripts/longshot_saves.py check-repo-saves`: passes. - `tests/test_longshot_saves.py` (77 tests, OK, 1 skipped) and `tests/test_longshot_ctl.py` (51 tests, OK), on Linux. - `python -I -B tests/run_all.py` on this PC (Linux, a jj workspace of this branch on `main` @ 9b82abf6, before the rebase onto 99a7e249, which touched nothing here): 692 passed, 37 failed, 97 skipped. 36 of the failures also fail on `main` @ 9b82abf6 in a clean workspace (`run_all.py --exact` on them: 36 of 36 fail; they need tools or files that workspace lacks): `test_bug_report`, `test_bug_report_defaults`, `test_capture_read_once`, `test_crash_groups`, `test_crt_options`, `test_damage_debug_menu`, `test_dev_packs`, `test_display_startup_failure`, `test_dlss_feature_size`, `test_failed_compile_keeps_objects`, `test_guest_imported`, `test_hardware_report`, `test_high_fps_fixes`, `test_host_guest_writes`, `test_hud_layout_row`, `test_invalidate_quick`, `test_libc_hooks`, `test_linux_preflight`, `test_linux_pressure`, `test_linux_update`, `test_log_open_failure`, `test_missing_nup`, `test_mods_size_table`, `test_pending_guest_import`, `test_pipeline_play_cache`, `test_prepare_cache_save`, `test_present_thread`, `test_profiling_mode`, `test_psychov35_fsr3_fg`, `test_readback_timeout_source`, `test_slow_frames`, `test_song_note_cue`, `test_switch_table`, `test_upscaler_rows`, `test_vcore_escape`, `test_walk_key`. The 37th, `test_vbytes`, hit the runner's 600 s timeout on a busy PC (a timed run beside it); it reads none of the saves (a lift check); on `main` @ 9b82abf6 alone, with `--timeout 1800`, it passed in 1,399 s, past the default 600 s, so it times out on `main` too with the default (this branch changes no code it builds). - In the game, on this PC (headless): `longshot_ctl.py launch <game> --profile test --repo-save castle-gate --headless` into a new run folder copied only `slot_00/` in; A on the title loaded it, and `status` read state `play`, map `HyruleField_Child`, age `child`, no event, no load, 3 hearts, Link at [-0.04, 150.61, 32.78] facing 0 (out of the gate). The shot below is that load. ![castle-gate, loaded with --repo-save: this PR @ 35d9d877](https://git.magicbean.dev/attachments/bba8efd1-49ec-4c51-8458-da55801a28dd) **Not tested:** Windows (the save is the game's own files, the same on both; `launch --repo-save` is covered by #543's tests). **Must be tested:** None ## Risks **What could break:** Nothing in the game or the build: two save files and README text, read only by `launch --repo-save` and `check-repo-saves`. The saves' README table gains a row, so a sibling save PR (`market-entrance`) touches the same table and the second one merged takes a one-line rebase. **Turning it off:** revert the commit. **Compatibility:** Nothing changes for a player. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
feat(saves): castle-gate, child Link in Hyrule Field at Castle Town's gate, by day
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 10s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 16s
CI / Workflow lint (actionlint) (pull_request) Successful in 19s
Third-party parts / As their notes say (pull_request) Successful in 22s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 5s
35d9d877b9
A repository save for the Test Farm: made fresh from a profile holding only
kokiri-start (Continue, teleport Market_Child, then a walk out through the
gate into Hyrule Field), the game's own transition autosave as Link arrived,
scrubbed with longshot_saves.py scrub. Its README says how it was made.

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Owner

Tested in game: CachyOS Linux, RTX 3090, NVIDIA 620.70.06, headless: launch --profile test --repo-save castle-gate, A on the title: state play, map HyruleField_Child, age child, no event, 3 hearts, Link on the drawbridge's town end facing the Field, by day

Tested in game: CachyOS Linux, RTX 3090, NVIDIA 620.70.06, headless: launch --profile test --repo-save castle-gate, A on the title: state play, map HyruleField_Child, age child, no event, 3 hearts, Link on the drawbridge's town end facing the Field, by day
Author
Owner

The full run_all's one timeout, test_vbytes, ran on main alone with a longer timeout: it passes in 1,399 s, past the default 600 s, so it times out on main too. Testing updated; marking ready.

The full run_all's one timeout, test_vbytes, ran on main alone with a longer timeout: it passes in 1,399 s, past the default 600 s, so it times out on main too. Testing updated; marking ready.
HumanBean changed title from WIP: feat(saves): castle-gate, child Link in Hyrule Field at Castle Town's gate, by day to feat(saves): castle-gate, child Link in Hyrule Field at Castle Town's gate, by day 2026-11-19 07:59:41 +00:00
futondestroyer left a comment

Recommendation: Wait on current-main save validation and the red Guide screenshots check. The submitted save has documented fresh-profile provenance and the permitted one-slot layout.

Does it help: This gives the Test Farm a repeatable castle-gate starting point. Performance measurement does not apply.
Other systems: This adds a save and catalog entry. There is no runtime code change.
Switches: None.
Reviewed: 35d9d877 against 99a7e249. Checked the tree layout, catalog, and provenance README, and read the author's validation report. Nothing run.
Fixed in this review: Nothing.
Checked and fine: The patch adds only the README and regular progress/caption files in slot_00, plus the catalog entry. No profile settings or links. HumanBean documents an isolated profile seeded with the approved Kokiri save, the transition autosave after leaving the gate, and a child/day reload facing Hyrule Field with no active event. The reported scrub and check-repo-saves passed, and the author smoke-loaded it on CachyOS with an RTX 3090.

Testing: The description check passed. The Guide screenshots check failed, and the source checks were skipped. Please establish whether the failure reproduces on the exact control and clear the merge gate. Current main changed the save launch tooling. On the rebased pair, refresh check-repo-saves and smoke-load castle-gate through the current documented repo-save path. Each save requires two distinct eligible maintainer approvals before merge.
Overlaps and merge order: #1723 adds its own save and touches the same catalog. Either can go first. The second rebase should keep both rows and the current documentation link.

**Recommendation: Wait on current-main save validation and the red Guide screenshots check.** The submitted save has documented fresh-profile provenance and the permitted one-slot layout. **Does it help:** This gives the Test Farm a repeatable castle-gate starting point. Performance measurement does not apply. **Other systems:** This adds a save and catalog entry. There is no runtime code change. **Switches:** None. **Reviewed:** 35d9d877 against 99a7e249. Checked the tree layout, catalog, and provenance README, and read the author's validation report. Nothing run. **Fixed in this review:** Nothing. **Checked and fine:** The patch adds only the README and regular progress/caption files in slot_00, plus the catalog entry. No profile settings or links. HumanBean documents an isolated profile seeded with the approved Kokiri save, the transition autosave after leaving the gate, and a child/day reload facing Hyrule Field with no active event. The reported scrub and check-repo-saves passed, and the author smoke-loaded it on CachyOS with an RTX 3090. **Testing:** The description check passed. The [Guide screenshots check](https://git.magicbean.dev/MagicBeanDev/Longshot/actions/runs/39606/jobs/0) failed, and the source checks were skipped. Please establish whether the failure reproduces on the exact control and clear the merge gate. Current main changed the save launch tooling. On the rebased pair, refresh check-repo-saves and smoke-load castle-gate through the current documented repo-save path. Each save requires two distinct eligible maintainer approvals before merge. **Overlaps and merge order:** https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1723 adds its own save and touches the same catalog. Either can go first. The second rebase should keep both rows and the current documentation link.
Author
Owner
@rebase
Member

I rebased this pull request onto main (2b3de5b27a): the new head is de1242c7df.

Conflicts resolved

  • assets/saves/README.md: Kept both save entries and the base branch’s updated documentation link.

Nothing was built or run: read the resolution before merging.


Automated rebase by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

I rebased this pull request onto `main` (2b3de5b27a77): the new head is de1242c7dfe9. **Conflicts resolved** - assets/saves/README.md: Kept both save entries and the base branch’s updated documentation link. Nothing was built or run: read the resolution before merging. --- <sub>Automated rebase by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
BeanBot force-pushed feat/save-castle-gate from 35d9d877b9
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 10s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 16s
CI / Workflow lint (actionlint) (pull_request) Successful in 19s
Third-party parts / As their notes say (pull_request) Successful in 22s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 5s
to de1242c7df
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 9s
PR description / Description follows the template (pull_request_target) Failing after 11s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 12s
CI / Workflow lint (actionlint) (pull_request) Successful in 13s
Third-party parts / As their notes say (pull_request) Successful in 13s
CI / Website build and checks (pull_request) Failing after 22s
2026-11-21 05:36:03 +00:00
Compare
BeanBot left a comment

Recommendation: Request changes. The save gives the Test Farm the intended drawbridge start, and its two files match the Linux smoke-tested revision. The PR description fails the current review template and needs to record validation through the rebased launch path.

Adds an opt-in daytime start at the town end of the drawbridge, with child Link facing Hyrule Field. It removes the setup walk for that Test Farm route and adds about 123 KiB of save data without changing runtime code or defaults.

@fix will do (5)

  1. L1: The submitted body uses the old template. The current description checker requires ## Summary, Still to test, and ### Ready for review, all absent from this body. Move the evidence into the current template, use its merge checklist, and keep Measurements to the single line explaining why no performance measurement applies.
  2. L2 (minor): The rationale still calls kokiri-start the only repository save and predicts a future rebase with market-entrance. Base 2b3de5b2 already contains #1723 and its catalog row. Explain that market-entrance starts inside the Market facing inward, while this save starts on the Field side facing out, and remove the pending-overlap claim.
  3. L3 (minor): The risk section limits consumers to launch --repo-save and check-repo-saves. saves --repo reads the new README, and memtour and dev.py ab can load the slot through the shared launcher. Describe the effect as an additional selectable repository save across these tools.
  4. L4 (minor): The provenance paragraph cites Goto_HyruleCastle as a readable string in the submitted progress file. It appears in market-entrance, while this slot has Meet_DekuTree. Correct the example and describe check-repo-saves as a layout and scrub check. For progress.sav, it checks file type and size rather than provenance.
  5. L5 (minor) assets/saves/castle-gate/README.md:9: The README says the stick was held for four seconds, while the PR records 240 game frames. (more on the line)

For the author (1) (a run, a measurement or a decision)

  • L6 (minor): The reported validation predates the launcher refactor. The copy logic is unchanged, but launch now starts a separate longshot_bridge.py supervisor. Run check-repo-saves and smoke-load castle-gate from a fresh test profile at de1242c7. Confirm the map, age, daylight, and outward facing, and record the required lint and strict suite results for the rebased branch.
More: does it help, other systems, switches, what was read

Does it help: Not a perf change. The author's CachyOS Linux smoke test at 35d9d877 loaded into HyruleField_Child in play as child Link, with three hearts and no active event. Both save blobs are identical at de1242c7.

Other systems: saves --repo lists the new entry. Test Farm launches, memtour, and dev.py ab can select it through the shared save-copy path. The diff changes no player save migration, renderer, build, audio, or input code. Windows and Steam Deck loads were not reported.

Switches: None.

Reviewed: de1242c7df against 2b3de5b27a: Read AGENTS.md, CONTRIBUTING.md, the current Forgejo template, developer standards, both changed READMEs, the full diff, the commit and its trailers, and the supplied comments, review, and CI summary. Read the relevant validator, scrubber, launch and listing paths, save-copy code, tests, and downstream callers. Inspected the two binary files by size, blob identity, header, thumbnail comparison, and readable strings. Used the author's report for game behavior. The linked screenshot and external CI logs were unavailable in the checkout. No review-checklist file was present.; nothing run (a code review).

Checked and fine:

  • The diff adds one fresh-profile save in the permitted one-slot layout with regular files, no account or options data, and a provenance README.
  • The caption has the reset date, matching Field scene and map, and a JPEG byte-identical to the two existing grey thumbnails. Both save files are under the documented size caps.
  • The catalog preserves both existing rows and the current saves documentation link.
  • The commit has both AI-assistance trailers. No switches, API versions, generated code, third-party files, or executable scripts change.
  • The existing checkout-wide validator test includes newly added saves, and the copy tests exercise isolation from the source and refusal of an occupied destination.

Testing: Read-only review. The author reports a validator pass, 77 save tests with one skip, 51 control-client tests, and a successful Linux smoke load before the rebase. The older full run reported 692 passed, 37 failed, and 97 skipped. The author reproduced 36 failures on its old base, and test_vbytes took 1,399 seconds there with an extended timeout. Current CI data lists no failures or running checks and includes no passing result. The Guide screenshots failure belongs to the stale review. Merge requires two maintainer approvals.

Overlaps and merge order: #1723 (market-entrance) is already in base 2b3de5b2. The rebase kept both catalog entries and the current documentation link. No remaining merge-order dependency found.


Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its rebase. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** The save gives the Test Farm the intended drawbridge start, and its two files match the Linux smoke-tested revision. The PR description fails the current review template and needs to record validation through the rebased launch path. Adds an opt-in daytime start at the town end of the drawbridge, with child Link facing Hyrule Field. It removes the setup walk for that Test Farm route and adds about 123 KiB of save data without changing runtime code or defaults. **`@fix` will do (5)** 1. **L1**: The submitted body uses the old template. The current description checker requires `## Summary`, `Still to test`, and `### Ready for review`, all absent from this body. Move the evidence into the current template, use its merge checklist, and keep Measurements to the single line explaining why no performance measurement applies. 2. **L2** (minor): The rationale still calls `kokiri-start` the only repository save and predicts a future rebase with `market-entrance`. Base 2b3de5b2 already contains #1723 and its catalog row. Explain that `market-entrance` starts inside the Market facing inward, while this save starts on the Field side facing out, and remove the pending-overlap claim. 3. **L3** (minor): The risk section limits consumers to `launch --repo-save` and `check-repo-saves`. `saves --repo` reads the new README, and `memtour` and `dev.py ab` can load the slot through the shared launcher. Describe the effect as an additional selectable repository save across these tools. 4. **L4** (minor): The provenance paragraph cites `Goto_HyruleCastle` as a readable string in the submitted progress file. It appears in `market-entrance`, while this slot has `Meet_DekuTree`. Correct the example and describe `check-repo-saves` as a layout and scrub check. For `progress.sav`, it checks file type and size rather than provenance. 5. **L5** (minor) `assets/saves/castle-gate/README.md:9`: The README says the stick was held for four seconds, while the PR records 240 game frames. (more on the line) **For the author (1)** (a run, a measurement or a decision) - **L6** (minor): The reported validation predates the launcher refactor. The copy logic is unchanged, but launch now starts a separate `longshot_bridge.py` supervisor. Run `check-repo-saves` and smoke-load `castle-gate` from a fresh test profile at de1242c7. Confirm the map, age, daylight, and outward facing, and record the required lint and strict suite results for the rebased branch. <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Not a perf change. The author's CachyOS Linux smoke test at 35d9d877 loaded into HyruleField_Child in play as child Link, with three hearts and no active event. Both save blobs are identical at de1242c7. **Other systems:** `saves --repo` lists the new entry. Test Farm launches, `memtour`, and `dev.py ab` can select it through the shared save-copy path. The diff changes no player save migration, renderer, build, audio, or input code. Windows and Steam Deck loads were not reported. **Switches:** None. **Reviewed:** de1242c7dfe9 against 2b3de5b27a77: Read AGENTS.md, CONTRIBUTING.md, the current Forgejo template, developer standards, both changed READMEs, the full diff, the commit and its trailers, and the supplied comments, review, and CI summary. Read the relevant validator, scrubber, launch and listing paths, save-copy code, tests, and downstream callers. Inspected the two binary files by size, blob identity, header, thumbnail comparison, and readable strings. Used the author's report for game behavior. The linked screenshot and external CI logs were unavailable in the checkout. No review-checklist file was present.; nothing run (a code review). **Checked and fine:** - The diff adds one fresh-profile save in the permitted one-slot layout with regular files, no account or options data, and a provenance README. - The caption has the reset date, matching Field scene and map, and a JPEG byte-identical to the two existing grey thumbnails. Both save files are under the documented size caps. - The catalog preserves both existing rows and the current saves documentation link. - The commit has both AI-assistance trailers. No switches, API versions, generated code, third-party files, or executable scripts change. - The existing checkout-wide validator test includes newly added saves, and the copy tests exercise isolation from the source and refusal of an occupied destination. **Testing:** Read-only review. The author reports a validator pass, 77 save tests with one skip, 51 control-client tests, and a successful Linux smoke load before the rebase. The older full run reported 692 passed, 37 failed, and 97 skipped. The author reproduced 36 failures on its old base, and `test_vbytes` took 1,399 seconds there with an extended timeout. Current CI data lists no failures or running checks and includes no passing result. The Guide screenshots failure belongs to the stale review. Merge requires two maintainer approvals. **Overlaps and merge order:** #1723 (`market-entrance`) is already in base 2b3de5b2. The rebase kept both catalog entries and the current documentation link. No remaining merge-order dependency found. </details> --- <sub>Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its rebase. Nothing was run; a maintainer decides.</sub>
@ -0,0 +6,4 @@
profile with only `kokiri-start` in it (`longshot_ctl.py launch <game> --profile test --repo-save kokiri-start
--headless`, the options file empty, so every setting at its default and the Autosave row On), Continue on the title,
then through the control bridge `teleport Market_Child` (Link arrives in the Market's gate, facing the town; the
teleport's arrival writes no save) and the left stick held back for 4 seconds, which walks him out of the gate into
Member

L5 (minor): The README says the stick was held for four seconds, while the PR records 240 game frames. A four-second wall-clock hold at 30 fps supplies only about half that input. Record the 240-frame hold so someone recreating the save can repeat it.

**L5** (minor): The README says the stick was held for four seconds, while the PR records 240 game frames. A four-second wall-clock hold at 30 fps supplies only about half that input. Record the 240-frame hold so someone recreating the save can repeat it.
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 9s
PR description / Description follows the template (pull_request_target) Failing after 11s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 12s
CI / Workflow lint (actionlint) (pull_request) Successful in 13s
Third-party parts / As their notes say (pull_request) Successful in 13s
CI / Website build and checks (pull_request) Failing after 22s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'feat/save-castle-gate:HumanBean-feat/save-castle-gate'
git switch 'HumanBean-feat/save-castle-gate'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1722
No description provided.