feat(saves): market-entrance, child Link in Castle Town Market's gate, by day #1723
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1723
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:feat/save-market-entrance"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: feat · Risk: low · Tested on: CachyOS Linux, RTX 3090 (NVIDIA 620.70.06) · Needs: none
TL;DR
The Test Farm can only start a run from Link's house in Kokiri Forest, so a test that walks into Castle Town's market had to teleport and walk there first. This adds a repository save,
market-entrance: child Link in the Market's gate, the town ahead of him, by day, its first-visit scene already seen. It was made from a fresh profile and scrubbed likekokiri-start; it passescheck-repo-savesand loads there in the game.Breakdown
assets/saves/market-entrance, and its row in the saves' README.kokiri-start; nothing for a player.check-repo-savespasses; launched with--repo-save market-entrance, it loads in the Market's gate (state play, child, no event).launch --repo-saveandcheck-repo-saves.Why
The Test Farm's planner asked for a town-entry save for tests of the render targets in the Market (#1255, #1256):
kokiri-startis the only repository save, so a run had to teleport there itself, and the first walk in plays the Market's first-visit scene. With this save a run starts in the Market's gate, by day, the scene already seen, in the same place on every PC. The tracker has no issue for it (searched: "repo save", "assets/saves").What changed
A new repository save,
market-entrance, made fresh from a new profile and scrubbed withlongshot_saves.py scrub, and its row in the saves' README.assets/saves/market-entrance/slot_00/:progress.sav(the game's save, unchanged) andcaption.sav(its picture mid-grey, its date 2026-01-01 00:00). Noaccount.savoroption.sav.assets/saves/market-entrance/README.md: where the save stands (its first line) and how it was made.assets/saves/README.md: the save's row in the table.How it was made, on this PC (CachyOS Linux, RTX 3090, NVIDIA 620.70.06; Longshot v3.0.0-rc.7-111-gda91e7702, main
da91e770): a new profile with onlykokiri-startin it (longshot_ctl.py launch <game> --profile test --repo-save kokiri-start --headless, an empty options file so every setting is at its default and the Autosave row On), Continue on the title, then through the control bridgeteleport Market_Child(Link arrives in the Market's gate facing the town; that arrival writes no save: the save trace logged the requests and no slot changed), the left stick held back for 240 frames (out through the gate into Hyrule Field: an autosave, slot_01, thecastle-gatesave of its own PR), then back for 120 frames (through the gate into the Market again). The Market's first-visit scene played by itself, and the game's own autosave written after it (slot_02: scene Market, map Market/Market_Child, 3 hearts, by day) is this save; loading it puts Link where the teleport does, the scene already seen. Nothing else was done in the game; the story is a new game's, as inkokiri-start. Scrubbed on this PC, so the original picture never left it:The save holds no game data:
check-repo-savespasses, andprogress.sav's readable strings are only the game's own names (Market_Child,Goto_HyruleCastle,Item_Wallet_Smalland the like), with no paths or names from the PC.Measurements
Nothing to measure: this adds a save and a README row, no code; it is checked by
check-repo-saves, the saves' tests and a load in the game (Testing).Flags and settings
None
Testing
Tested:
python -I scripts/longshot_saves.py check-repo-saves: passes.tests/test_longshot_saves.py(77 tests, OK, 1 skipped) andtests/test_longshot_ctl.py(51 tests, OK), on Linux.python -I -B tests/run_all.pyon this PC (Linux, a jj workspace of this branch onmain@9b82abf6, before the rebase onto99a7e249, which touched nothing here): 692 passed, 37 failed, 97 skipped. 36 of the failures also fail onmain@9b82abf6in a clean workspace (run_all.py --exacton them: 36 of 36 fail; they need tools or files that workspace lacks):test_bug_report,test_bug_report_defaults,test_capture_read_once,test_crash_groups,test_crt_options,test_damage_debug_menu,test_dev_packs,test_display_startup_failure,test_dlss_feature_size,test_failed_compile_keeps_objects,test_guest_imported,test_hardware_report,test_high_fps_fixes,test_host_guest_writes,test_hud_layout_row,test_invalidate_quick,test_libc_hooks,test_linux_preflight,test_linux_pressure,test_linux_update,test_log_open_failure,test_missing_nup,test_mods_size_table,test_pending_guest_import,test_pipeline_play_cache,test_prepare_cache_save,test_present_thread,test_profiling_mode,test_psychov35_fsr3_fg,test_readback_timeout_source,test_slow_frames,test_song_note_cue,test_switch_table,test_upscaler_rows,test_vcore_escape,test_walk_key. The 37th,test_vbytes, hit the runner's 600 s timeout on a busy PC (a timed run beside it); it reads none of the saves (a lift check); onmain@9b82abf6alone, with--timeout 1800, it passed in 1,399 s, past the default 600 s, so it times out onmaintoo with the default (this branch changes no code it builds).longshot_ctl.py launch <game> --profile test --repo-save market-entrance --repo <a folder holding only this save's assets/saves/market-entrance> --headlessinto a new run folder copied onlyslot_00/in; A on the title loaded it, andstatusread stateplay, mapMarket_Child, agechild, no event, no load, 3 hearts, music BGM_Market, Link at [-1.74, 102.12, 64.0] facing -180 (into the Market); no scene played on the load. The committed files are byte for byte the ones loaded (a second scrub of the same slot gives the same bytes). The shot below is that load.Not tested: Windows (the save is the game's own files, the same on both;
launch --repo-saveis covered by #543's tests).Must be tested: None
Risks
What could break: Nothing in the game or the build: two save files and README text, read only by
launch --repo-saveandcheck-repo-saves. The saves' README table gains a row, so a sibling save PR (castle-gate) touches the same table and the second one merged takes a one-line rebase.Turning it off: revert the commit.
Compatibility: Nothing changes for a player.
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.🤖 Generated with Claude Code
Tested in game: CachyOS Linux, RTX 3090, NVIDIA 620.70.06, headless: launch --profile test --repo-save market-entrance, A on the title: state play, map Market_Child, age child, no event, 3 hearts, Link in the Market's gate facing the town, by day, no scene on the load
The full run_all's one timeout, test_vbytes, ran on main alone with a longer timeout: it passes in 1,399 s, past the default 600 s, so it times out on main too. Testing updated; marking ready.
WIP: feat(saves): market-entrance, child Link in Castle Town Market's gate, by dayto feat(saves): market-entrance, child Link in Castle Town Market's gate, by dayRecommendation: Wait on current-main save validation and the red Guide screenshots check. The submitted save has documented fresh-profile provenance and the permitted one-slot layout.
Does it help: This gives the Test Farm a repeatable market-entrance starting point. Performance measurement does not apply.
Other systems: This adds a save and catalog entry. There is no runtime code change.
Switches: None.
Reviewed:
553b4a52against99a7e249. Checked the tree layout, catalog, and provenance README, and read the author's validation report. Nothing run.Fixed in this review: Nothing.
Checked and fine: The patch adds only the README and regular progress/caption files in slot_00, plus the catalog entry. No profile settings or links. HumanBean documents an isolated profile seeded with the approved Kokiri save, the transition autosave after the first Market scene, and a child/day reload facing the Market with no replayed scene. The reported scrub and check-repo-saves passed, and the author smoke-loaded it on CachyOS with an RTX 3090.
Testing: The description check passed. The Guide screenshots check failed, and the source checks were skipped. Please establish whether the failure reproduces on the exact control and clear the merge gate. Current main changed the save launch tooling. On the rebased pair, refresh check-repo-saves and smoke-load market-entrance through the current documented repo-save path. Each save requires two distinct eligible maintainer approvals before merge.
Overlaps and merge order: #1722 adds its own save and touches the same catalog. Either can go first. The second rebase should keep both rows and the current documentation link.