fix(crash): the crash report's graphics card has its driver, and a start-up crash has a renderer #1714

Merged
HumanBean merged 1 commit from jabbaxipil/Longshot:crash-report-gpu-driver into main 2026-11-19 07:13:10 +00:00
Contributor

Type: fix · Risk: low · Tested on: Linux (Ubuntu 26.04.1), RTX 4070 · Needs: Windows, any GPU (a build)

TL;DR

A crash report sent with Report automatically named the graphics card without its driver, and said the renderer was "not known" when the crash happened while the shaders were being loaded at the start. This PR sends the card together with its driver and makes sure a start-up crash names its renderer. A check that fails on main passes here, and a start of the game built from this branch logs the lines in the new order.

Breakdown

  • Who it helps: the people who read crash reports: a GPU crash can be split by driver again, and start-up crashes stop arriving with an unknown renderer.
  • What was wrong: the report took the card's name alone, never the line that carries the driver, and the renderer was logged only after the renderer had finished starting.
  • What changes: the report's graphics card reads "name, driver", and the renderer is logged before the renderer starts.
  • What does not change: the manual report (Report manually), the crash window's pages other than the Graphics card line, the report's field names, settings and saves.
  • How it was checked: the crash window's game-free check asserts the posted value and the order (it fails on main, passes here); the whole check run has the same failures as main; a build of this branch started in the game logs the renderer before the shaders load.
  • What is still open: a Windows build of the host, and a real crash sent from the crash window in the game.
  • Risk: low: a few lines in the crash helper's reading of the log, and one log line moved earlier.

Why

Two fields of the automatic crash report did not hold what the description and the docs say they hold. gpu had no driver, so the same card became two values (older reports had "name, driver") and a GPU crash could not be split by driver. renderer was "not known" for a crash during the start-up shader preparation, a common place to crash. Fixes #1263.

How to reproduce

Seen on: any; read from the code and the check's helper, as #1263 describes.
Settings and switches: defaults.
Steps: on main, feed the crash window's test helper a log with vk: NVIDIA GeForce RTX 3090, Vulkan 1.4, ...; mesh shaders yes, vk: driver: NVIDIA 580.95.05 and report: gpu NVIDIA GeForce RTX 3090, NVIDIA 580.95.05, and press Report automatically, Send.
Expected: "gpu": "NVIDIA GeForce RTX 3090, NVIDIA 580.95.05".
Actual: "gpu": "NVIDIA GeForce RTX 3090". For the renderer: in a log of main, report: renderer Vulkan comes after the renderer's start, so a log that ends during the shader preparation has none.

What changed

The helper now reads the renderer's own report: gpu line, which it never read, and the report uses it. The host logs report: renderer once the Vulkan back end is loaded instead of after it has started.

  • crash helper: hos_crash_log_line() in host/hos_crash_dialog.h keeps the report: gpu line (gpu_report); the new hos_crash_gpu() gives that line, else the device chosen and its vk: driver: line joined the same way ("name, driver"), else the name alone.
  • report: build_report() in host/hos_crash_dialog.c uses it for the JSON's gpu and the page's "Graphics card" line. report_facts() (the manual report) is unchanged.
  • host: rx_start() in host/rx_backend.c logs report: renderer Vulkan before r->start(hwnd), which prepares the shaders.
  • docs: docs/crash-report-window.md says where both lines come from.
  • test: tests/test_crash_dialog.py asserts the posted gpu, the page's line, the three fallbacks and the last-line rule, and that rx_start logs the renderer before the start.

Measurements

Verdict: nothing to measure: the change is to what the crash helper reads from a log after the game has ended, and to where one log line is written.

Flags and settings

None.

Testing

Tested: Linux (Ubuntu 26.04.1, kernel 7.0), RTX 4070, NVIDIA 615.71.09, Ryzen 7 5800X3D. The game run and the whole check run were at 6dec62c7 on main 47430e81; the branch was then rebased onto main 4fc22424 (two commits later, neither touching these files; the patch is unchanged by git range-diff) and is 2bc52134.

  • In the game: a build of this branch (nx2/make_game.py, tools.lock's Linux tools), started without a window and left on the title screen for 75 s (no save loaded, no play), 19,559 frames, no crash, no fatal line, no driver error. I looked at its last picture: the title with Continue, New Game and Options. Its log, in order:
    34: report: gpu NVIDIA GeForce RTX 4070, NVIDIA 615.71.09
    37: report: renderer Vulkan
    46: vk: pipeline cache ... (the shaders' loading starts)
    70: vk: precompile: 38140 noted pipelines of 23763 programs ... built into the pipeline cache
    74: rx: renderer: Vulkan (longshot_vk.dll)
    
    Line 74 is where report: renderer was written on main. The timed run was ended by the test harness, not by the game.
  • That log through the changed reader: the whole log, and its first 60 lines alone (a log that ends while the shaders load), both give gpu "NVIDIA GeForce RTX 4070, NVIDIA 615.71.09" and renderer "Vulkan".
  • python -I -B tests/test_crash_dialog.py: passes, at 6dec62c7 and again at 2bc52134 after the rebase (with test_no_webgpu, test_doc_anchors, test_crash_groups and main's new test_translator_stamp_text: 5 passed). With the hos_crash_dialog.c change taken out it fails (the card with its driver: 'NVIDIA GeForce RTX 3090'); with the rx_backend.c change taken out it fails on the order.
  • python -I -B tests/run_all.py --jobs 8: 678 passed, 38 failed, 109 skipped, at 6dec62c7 and on main 47430e81, the same 38 (not run again after the rebase): test_bug_report_defaults, test_bug_report, test_capture_read_once, test_crash_groups, test_crt_options, test_damage_debug_menu, test_dev_packs, test_display_startup_failure, test_dlss_feature_size, test_failed_compile_keeps_objects, test_guest_imported, test_hardware_report, test_high_fps_fixes, test_host_guest_writes, test_hud_layout_row, test_invalidate_quick, test_libc_hooks, test_linux_preflight, test_linux_pressure, test_linux_update, test_log_open_failure, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_pipeline_play_cache, test_prepare_cache_save, test_present_thread, test_profiling_mode, test_psychov35_fsr3_fg, test_readback_timeout_source, test_run_all_changed, test_slow_frames, test_song_note_cue, test_switch_table, test_upscaler_rows, test_vcore_escape, test_walk_key, and test_vbytes (timeout at 600 s).

Not tested:

  • Play. The game run stopped at the title screen; the change is in the start and in the crash helper, which play does not reach.
  • A real crash sent from the crash window in the game. The check runs the real helper against a stand-in for curl and reads what it posts; no report was sent to the team's server.
  • Windows. The changed code is plain C with nothing per platform, but I have no Windows compiler here: not built there.
  • --prepare-shaders. rx_prepare_shaders() (the build's own step) logs no report: renderer; unchanged.

Must be tested:

  • Windows, any GPU: build the host (llvm-mingw), expecting it to compile and python -I -B tests/test_crash_dialog.py to pass (by hand: the build's output and the check's last lines).

Risks

What could break: a report's gpu is longer than before (it is cut at the same 200 characters). If a log's report: gpu line and its chosen device ever disagreed, the report would carry the report: gpu line. A start in which the Vulkan back end loads but does not start now has report: renderer Vulkan in its log; the lines that say it did not start are unchanged.

Turning it off: revert the commit.

Compatibility: Nothing changes for a player. For whoever reads the reports: gpu values gain the driver again, as the earlier reporter sent them.

Issues

Fixes #1263

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Docs updated.
**Type:** fix · **Risk:** low · **Tested on:** Linux (Ubuntu 26.04.1), RTX 4070 · **Needs:** Windows, any GPU (a build) ## TL;DR A crash report sent with Report automatically named the graphics card without its driver, and said the renderer was "not known" when the crash happened while the shaders were being loaded at the start. This PR sends the card together with its driver and makes sure a start-up crash names its renderer. A check that fails on main passes here, and a start of the game built from this branch logs the lines in the new order. ## Breakdown - **Who it helps:** the people who read crash reports: a GPU crash can be split by driver again, and start-up crashes stop arriving with an unknown renderer. - **What was wrong:** the report took the card's name alone, never the line that carries the driver, and the renderer was logged only after the renderer had finished starting. - **What changes:** the report's graphics card reads "name, driver", and the renderer is logged before the renderer starts. - **What does not change:** the manual report (Report manually), the crash window's pages other than the Graphics card line, the report's field names, settings and saves. - **How it was checked:** the crash window's game-free check asserts the posted value and the order (it fails on main, passes here); the whole check run has the same failures as main; a build of this branch started in the game logs the renderer before the shaders load. - **What is still open:** a Windows build of the host, and a real crash sent from the crash window in the game. - **Risk:** low: a few lines in the crash helper's reading of the log, and one log line moved earlier. ## Why Two fields of the automatic crash report did not hold what the description and the docs say they hold. `gpu` had no driver, so the same card became two values (older reports had "name, driver") and a GPU crash could not be split by driver. `renderer` was "not known" for a crash during the start-up shader preparation, a common place to crash. Fixes #1263. ## How to reproduce **Seen on:** any; read from the code and the check's helper, as #1263 describes. **Settings and switches:** defaults. **Steps:** on main, feed the crash window's test helper a log with `vk: NVIDIA GeForce RTX 3090, Vulkan 1.4, ...; mesh shaders yes`, `vk: driver: NVIDIA 580.95.05` and `report: gpu NVIDIA GeForce RTX 3090, NVIDIA 580.95.05`, and press Report automatically, Send. **Expected:** `"gpu": "NVIDIA GeForce RTX 3090, NVIDIA 580.95.05"`. **Actual:** `"gpu": "NVIDIA GeForce RTX 3090"`. For the renderer: in a log of main, `report: renderer Vulkan` comes after the renderer's start, so a log that ends during the shader preparation has none. ## What changed The helper now reads the renderer's own `report: gpu` line, which it never read, and the report uses it. The host logs `report: renderer` once the Vulkan back end is loaded instead of after it has started. - crash helper: `hos_crash_log_line()` in `host/hos_crash_dialog.h` keeps the `report: gpu` line (`gpu_report`); the new `hos_crash_gpu()` gives that line, else the device chosen and its `vk: driver:` line joined the same way ("name, driver"), else the name alone. - report: `build_report()` in `host/hos_crash_dialog.c` uses it for the JSON's `gpu` and the page's "Graphics card" line. `report_facts()` (the manual report) is unchanged. - host: `rx_start()` in `host/rx_backend.c` logs `report: renderer Vulkan` before `r->start(hwnd)`, which prepares the shaders. - docs: `docs/crash-report-window.md` says where both lines come from. - test: `tests/test_crash_dialog.py` asserts the posted `gpu`, the page's line, the three fallbacks and the last-line rule, and that `rx_start` logs the renderer before the start. ## Measurements **Verdict:** nothing to measure: the change is to what the crash helper reads from a log after the game has ended, and to where one log line is written. ### Flags and settings None. ## Testing **Tested:** Linux (Ubuntu 26.04.1, kernel 7.0), RTX 4070, NVIDIA 615.71.09, Ryzen 7 5800X3D. The game run and the whole check run were at 6dec62c7 on main 47430e81; the branch was then rebased onto main 4fc22424 (two commits later, neither touching these files; the patch is unchanged by `git range-diff`) and is 2bc52134. - In the game: a build of this branch (`nx2/make_game.py`, tools.lock's Linux tools), started without a window and left on the title screen for 75 s (no save loaded, no play), 19,559 frames, no crash, no fatal line, no driver error. I looked at its last picture: the title with Continue, New Game and Options. Its log, in order: ``` 34: report: gpu NVIDIA GeForce RTX 4070, NVIDIA 615.71.09 37: report: renderer Vulkan 46: vk: pipeline cache ... (the shaders' loading starts) 70: vk: precompile: 38140 noted pipelines of 23763 programs ... built into the pipeline cache 74: rx: renderer: Vulkan (longshot_vk.dll) ``` Line 74 is where `report: renderer` was written on main. The timed run was ended by the test harness, not by the game. - That log through the changed reader: the whole log, and its first 60 lines alone (a log that ends while the shaders load), both give `gpu` "NVIDIA GeForce RTX 4070, NVIDIA 615.71.09" and `renderer` "Vulkan". - `python -I -B tests/test_crash_dialog.py`: passes, at 6dec62c7 and again at 2bc52134 after the rebase (with `test_no_webgpu`, `test_doc_anchors`, `test_crash_groups` and main's new `test_translator_stamp_text`: 5 passed). With the `hos_crash_dialog.c` change taken out it fails (`the card with its driver: 'NVIDIA GeForce RTX 3090'`); with the `rx_backend.c` change taken out it fails on the order. - `python -I -B tests/run_all.py --jobs 8`: 678 passed, 38 failed, 109 skipped, at 6dec62c7 and on main 47430e81, the same 38 (not run again after the rebase): `test_bug_report_defaults`, `test_bug_report`, `test_capture_read_once`, `test_crash_groups`, `test_crt_options`, `test_damage_debug_menu`, `test_dev_packs`, `test_display_startup_failure`, `test_dlss_feature_size`, `test_failed_compile_keeps_objects`, `test_guest_imported`, `test_hardware_report`, `test_high_fps_fixes`, `test_host_guest_writes`, `test_hud_layout_row`, `test_invalidate_quick`, `test_libc_hooks`, `test_linux_preflight`, `test_linux_pressure`, `test_linux_update`, `test_log_open_failure`, `test_missing_nup`, `test_mods_size_table`, `test_pending_guest_import`, `test_pipeline_play_cache`, `test_prepare_cache_save`, `test_present_thread`, `test_profiling_mode`, `test_psychov35_fsr3_fg`, `test_readback_timeout_source`, `test_run_all_changed`, `test_slow_frames`, `test_song_note_cue`, `test_switch_table`, `test_upscaler_rows`, `test_vcore_escape`, `test_walk_key`, and `test_vbytes` (timeout at 600 s). **Not tested:** - **Play.** The game run stopped at the title screen; the change is in the start and in the crash helper, which play does not reach. - **A real crash sent from the crash window in the game.** The check runs the real helper against a stand-in for curl and reads what it posts; no report was sent to the team's server. - **Windows.** The changed code is plain C with nothing per platform, but I have no Windows compiler here: not built there. - **`--prepare-shaders`.** `rx_prepare_shaders()` (the build's own step) logs no `report: renderer`; unchanged. **Must be tested:** - Windows, any GPU: build the host (llvm-mingw), expecting it to compile and `python -I -B tests/test_crash_dialog.py` to pass (by hand: the build's output and the check's last lines). ## Risks **What could break:** a report's `gpu` is longer than before (it is cut at the same 200 characters). If a log's `report: gpu` line and its chosen device ever disagreed, the report would carry the `report: gpu` line. A start in which the Vulkan back end loads but does not start now has `report: renderer Vulkan` in its log; the lines that say it did not start are unchanged. **Turning it off:** revert the commit. **Compatibility:** Nothing changes for a player. For whoever reads the reports: `gpu` values gain the driver again, as the earlier reporter sent them. ## Issues Fixes #1263 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Docs updated.
fix(crash): the crash report's graphics card has its driver, and a start-up crash has a renderer
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 7s
Website / Website on Cloudflare (pull_request_target) Has been skipped
2bc5213475
Report automatically sent the device's name alone as `gpu` (the driver was joined only for the manual report), so
one card was two values and a GPU crash could not be split by driver. It now sends the renderer's own `report: gpu`
line (name, driver), which the helper never read, else the device chosen and its `vk: driver:` line joined the same way.

`report: renderer Vulkan` was logged after the back end's start(), which prepares the shaders, so a crash in the
start-up preparation had renderer "not known". It is logged once the back end is loaded, before start().

tests/test_crash_dialog.py asserts the posted `gpu`, the page's Graphics card line, the fallbacks, and that
rx_start logs the renderer before r->start().

Fixes #1263

Assisted-by: Claude Fable 5.2
Co-Authored-By: Claude Fable 5.2 <[email protected]>
Author
Contributor

Tested in game: Linux (Ubuntu 26.04.1), RTX 4070, NVIDIA 615.71.09: a build of this branch at 6dec62c7 (before the rebase onto 4fc22424; the patch is unchanged) started without a window and left on the title screen for 75 s, 19,559 frames, no crash and no driver error. Its log has report: gpu NVIDIA GeForce RTX 4070, NVIDIA 615.71.09 at line 34 and report: renderer Vulkan at line 37, before the pipeline cache is read (line 46) and the precompile line (70); rx: renderer: Vulkan, where the report line was written before, is at line 74. No save was loaded and nothing was played.

Tested in game: Linux (Ubuntu 26.04.1), RTX 4070, NVIDIA 615.71.09: a build of this branch at 6dec62c7 (before the rebase onto 4fc22424; the patch is unchanged) started without a window and left on the title screen for 75 s, 19,559 frames, no crash and no driver error. Its log has `report: gpu NVIDIA GeForce RTX 4070, NVIDIA 615.71.09` at line 34 and `report: renderer Vulkan` at line 37, before the pipeline cache is read (line 46) and the precompile line (70); `rx: renderer: Vulkan`, where the report line was written before, is at line 74. No save was loaded and nothing was played.
HumanBean left a comment

Looks ready from the code and the evidence. Two small suggestions are in the line comments. Neither blocks.

The parsing. The new report: gpu line is read the same way as the report: os, cpu and renderer lines next to it. It is a strstr on "] ", then hos_crash_take, which stops at the buffer's size and at \r/\n, so a Windows log with CRLF endings reads the same as a Linux one. A missing line, an empty one or a cut-off one gives "" or a shorter value, and the helper does not crash. hos_crash_gpu cannot overflow. gpu_report[328] holds gpu[160] + ", " + driver[160], and build_report's buffer is the same size. The sent value is still cut at HOS_CRASH_MAX_GPU by put_field. The four cases (the line, the device and its driver, the name alone, nothing) are all covered by the new asserts.

Privacy. Nothing new leaves the PC. The value is the card's name and its driver's name and version from VkPhysicalDeviceDriverProperties. It is the same data the manual report already sends, and older automatic reports sent it too. It goes through the same clean-up as before: the log line is redacted before parsing, and put_field/hos_crash_clean removes the home folder, the user name and the microphone names.

The renderer line. Moving report: renderer Vulkan before r->start(hwnd) is right for a crash during the shader preparation. When the Vulkan back end loads but fails to start, the report now says "Vulkan" instead of "not known". The log's "could not start" line still sets f->vulkan, so the stage and the verdict don't change. The Risks section says this. rx_start can run more than once (HOS_HEADLESS), which only writes the same line again, and the last line is the one that counts.

Measurements: "nothing to measure" is fine here. The change is in what the crash helper reads after the game has ended, plus one log line moved earlier in the start, with no per-frame cost. The author ran a build of this branch in the game on Linux with an RTX 4070, and the log shows the new order (renderer at line 37, the shaders loading from line 46). The new check fails on main with each half of the fix taken out. Still open, as the PR says: a Windows (llvm-mingw) build. The C is the same on both platforms, so I see little risk there.

Looks ready from the code and the evidence. Two small suggestions are in the line comments. Neither blocks. **The parsing.** The new `report: gpu` line is read the same way as the `report: os`, `cpu` and `renderer` lines next to it. It is a `strstr` on `"] "`, then `hos_crash_take`, which stops at the buffer's size and at `\r`/`\n`, so a Windows log with CRLF endings reads the same as a Linux one. A missing line, an empty one or a cut-off one gives `""` or a shorter value, and the helper does not crash. `hos_crash_gpu` cannot overflow. `gpu_report[328]` holds `gpu[160] + ", " + driver[160]`, and `build_report`'s buffer is the same size. The sent value is still cut at `HOS_CRASH_MAX_GPU` by `put_field`. The four cases (the line, the device and its driver, the name alone, nothing) are all covered by the new asserts. **Privacy.** Nothing new leaves the PC. The value is the card's name and its driver's name and version from `VkPhysicalDeviceDriverProperties`. It is the same data the manual report already sends, and older automatic reports sent it too. It goes through the same clean-up as before: the log line is redacted before parsing, and `put_field`/`hos_crash_clean` removes the home folder, the user name and the microphone names. **The renderer line.** Moving `report: renderer Vulkan` before `r->start(hwnd)` is right for a crash during the shader preparation. When the Vulkan back end loads but fails to start, the report now says "Vulkan" instead of "not known". The log's "could not start" line still sets `f->vulkan`, so the stage and the verdict don't change. The Risks section says this. `rx_start` can run more than once (`HOS_HEADLESS`), which only writes the same line again, and the last line is the one that counts. Measurements: "nothing to measure" is fine here. The change is in what the crash helper reads after the game has ended, plus one log line moved earlier in the start, with no per-frame cost. The author ran a build of this branch in the game on Linux with an RTX 4070, and the log shows the new order (renderer at line 37, the shaders loading from line 46). The new check fails on main with each half of the fix taken out. Still open, as the PR says: a Windows (llvm-mingw) build. The C is the same on both platforms, so I see little risk there.
@ -414,1 +414,4 @@
const MkwVkRenderer *r = load_vulkan(dll);
/* (the crash report's renderer: host/hos_crash_dialog.h. Before start(), which prepares the shaders: a crash in there
is a crash of this renderer too) */
if (r) hos_log("report: renderer Vulkan");
Owner

Fine as it is. One note: a start where the Vulkan back end loads but start() fails now reports "Vulkan" as the renderer (the one that was tried). The stage still comes from the "could not start" line, so this only changes the field's value. If you'd like the docs to say so, one clause in docs/crash-report-window.md would cover it ("the back end chosen, whether or not it started").

Fine as it is. One note: a start where the Vulkan back end loads but `start()` fails now reports "Vulkan" as the renderer (the one that was tried). The stage still comes from the "could not start" line, so this only changes the field's value. If you'd like the docs to say so, one clause in `docs/crash-report-window.md` would cover it ("the back end chosen, whether or not it started").
@ -384,2 +387,4 @@
dialog = (ROOT / "host/hos_crash_dialog.c").read_text(encoding="utf-8")
backend = (ROOT / "host/rx_backend.c").read_text(encoding="utf-8")
# (the crash report's renderer is logged before the back end's start(), which prepares the shaders: a crash in there has one)
start = backend[backend.index("int rx_start(void *hwnd) {"):]
Owner

Nit: a new check cuts with tests/srccut.py (AGENTS.md), which names the source and the marker if rx_start is renamed or reshaped. For example start = between(backend, "int rx_start(void *hwnd) {", "\n}\n") (or block(backend, "int rx_start(void *hwnd) {")), with sys.path.insert(0, str(Path(__file__).resolve().parent)); from srccut import block, between at the top.

Nit: a new check cuts with `tests/srccut.py` (AGENTS.md), which names the source and the marker if `rx_start` is renamed or reshaped. For example `start = between(backend, "int rx_start(void *hwnd) {", "\n}\n")` (or `block(backend, "int rx_start(void *hwnd) {")`), with `sys.path.insert(0, str(Path(__file__).resolve().parent)); from srccut import block, between` at the top.
HumanBean deleted branch crash-report-gpu-driver 2026-11-19 07:13:10 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 7s
Website / Website on Cloudflare (pull_request_target) Has been skipped
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1714
No description provided.