test(crash): the crash window's renderer-order check cuts rx_start with srccut #1756
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1756
Loading…
Reference in a new issue
No description provided.
Delete branch "jabbaxipil/Longshot:fix/crash-dialog-check-srccut"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Linux (Ubuntu 26.04.1), RTX 4070 · Needs: none
TL;DR
A follow-up to #1714, which is merged: its review left two small notes that did not block it, and this PR takes both. The check added there now reads the game's source with the project's own cutting helper, so if that code is renamed later the check says what is missing instead of stopping with a bare error. The crash report's documentation gains one clause. Nothing in the game changes; the check passes, and still fails when the fix from #1714 is taken out.
Breakdown
tests/srccut.py; the docs say the renderer reported is the one chosen, whether or not it then started.rx_startis renamed; the whole test run fails only where main does.Why
HumanBean's review of #1714 (merged) left two notes, neither blocking:
tests/srccut.py, which stops with one message naming the source and the marker. The new check intests/test_crash_dialog.pyusedstr.index, so a renamedrx_startwould stop it with a bareValueError.start()fails reports "Vulkan" as the renderer (the one that was tried). The review suggested one clause indocs/crash-report-window.mdto say so.See #1714, #1263.
What changed
The renderer-order check cuts
rx_startwithbetween()fromtests/srccut.py; the documentation gains the clause. No game code changes.source_checks()intests/test_crash_dialog.pyusesbetween(backend, "int rx_start(void *hwnd) {", "\n}\n")in place of twoindexslices. The assertion after it is unchanged. The file importssysandsrccutat the top, as the other checks that use it do.docs/crash-report-window.md:report: rendereris "the back end chosen, whether or not it then started".Measurements
Verdict: nothing to measure: a game-free check and one clause of documentation; no game code changes.
Flags and settings
None.
Testing
Tested: on my own PC: Linux (Ubuntu 26.04.1, kernel 7.0.0-43), RTX 4070 (NVIDIA 615.71.09), Ryzen 7 5800X3D, 64 GB. Nothing here runs in the game, so no game run was made.
python3 -I -B tests/test_crash_dialog.pyat this PR's head (after the rebase onto main @9ea65c7b): exit 0, 19 PASS lines.host/rx_backend.c(thereport: renderer Vulkanline moved back afterr->start(hwnd)), before the rebase, on main @d30b9479: the check fails withAssertionError: report: renderer is logged before the Vulkan back end starts, so a crash while it prepares the shaders names it, as it did before this change.rx_startrenamed torx_begininhost/rx_backend.c, same base: the check stops withsrccut: 'int rx_start(void *hwnd) {' is not in host/rx_backend.c (cut by tests/test_crash_dialog.py) (renamed or reshaped? update the check with the source).python3 -I -B tests/test_doc_anchors.pyat the head:doc anchors: 15, each resolves; the 13 rules' functions keep theirs.python3 -I -B tests/run_all.py --jobs 8, before the rebase, on main @d30b9479: 709 passed, 32 failed, 111 skipped. The same 32 fail on main @d30b9479in the same sitting: test_bug_report_defaults, test_capture_read_once, test_crt_options, test_damage_debug_menu, test_dev_packs, test_display_startup_failure, test_dlss_feature_size, test_failed_compile_keeps_objects, test_guest_imported, test_high_fps_fixes, test_host_guest_writes, test_hud_layout_row, test_libc_hooks, test_linux_preflight, test_linux_pressure, test_linux_update, test_log_open_failure, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_pipeline_play_cache, test_prepare_cache_save, test_present_thread, test_profiling_mode, test_psychov35_fsr3_fg, test_readback_timeout_source, test_slow_frames, test_song_note_cue, test_upscaler_rows, test_vbytes, test_vcore_escape, test_walk_key (test_vbytesby timeout). On main three more failed (test_bug_report, test_crash_groups, test_hardware_report) only because that checkout had no Tooling folder beside it; withMAGICBEAN_TOOLINGset all three pass there.Not tested: the whole
run_all.pyafter the rebase onto main @9ea65c7b(git range-diffshows the patch unchanged, and main's three new commits touch neither file of this PR norhost/rx_backend.cortests/srccut.py). Windows: the changed check is plain Python, but I did not run it there.Must be tested: None.
Risks
What could break: only this check:
between()stops when the marker appears twice inhost/rx_backend.c, whereindextook the first. It appears once today.Turning it off: revert the commit.
Compatibility: Nothing changes.
Issues
See #1714
See #1263
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.