fix(hid): the sticks' direction pseudo-buttons (StickLLeft .. StickRDown) #1684

Merged
HumanBean merged 1 commit from rainy/Longshot:fix/hid-stick-pseudo-buttons into main 2026-11-19 07:15:31 +00:00
Contributor

Type: fix · Risk: low · Tested on: Linux (Omarchy, kernel 7.2.15; Intel Core Ultra 7 270K Plus; RTX 4090, driver 615.78.08) · Needs: a run on Windows, any GPU, a controller

TL;DR

On a console, pushing a stick past halfway also counts as a direction button, and programs can read those buttons. Longshot never set them, so anything that reads a stick direction as a button saw nothing. This PR sets them from the stick positions. A new game-free test fails on main and passes here. The full check suite on this branch has the same 40 failures as main, and one more pass. It also ran in the game on Linux.

Breakdown

  • Who it helps: mods and menus that read a stick direction as a button, for example a menu opened with R and the right stick pushed down.
  • What was wrong: the controller state Longshot gives the game had button bits 0 to 15 only, and never the stick direction bits 16 to 23.
  • What changes: each stick sets its left, up, right and down bit once it is past half its travel.
  • What does not change: the stick axes, the other buttons, and the game's own controls. The game reads the axes, not these bits.
  • How it was checked: a new game-free test that fails on main and passes here, and python -I -B tests/run_all.py --jobs 8, which has the same 40 failures as main and one more pass.
  • What is still open: a run in the game on this branch.
  • Risk: low. Code that ignored these bits still ignores them.

Why

A code mod, sloperinaGZ 0.0.8, on snaildev99's mods/module-gaps branch is what showed this. The console's controller service sets the stick direction buttons from the stick axes. libnx names them HidNpadButton_StickLLeft = BITL(16) to HidNpadButton_StickRDown = BITL(23) in nx/include/switch/services/hid.h. Longshot set none of them, so a button combo that uses a stick direction never fires. yuzu sets them past half the travel, in TransformToStick in input_converter.cpp, with the threshold's default 0.5 in input_poller.cpp. This PR uses the same threshold. The tracker has no issue or PR for stick or npad.

How to reproduce

Seen on: Linux (Omarchy, kernel 7.2.15; Intel Core Ultra 7 270K Plus; RTX 4090, driver 615.78.08), any controller. The bits themselves do not depend on the GPU or driver.
Settings and switches: defaults
Steps: read the Npad state's buttons while the right stick is pushed all the way down, from mod code or from the game-free test below run against main.
Expected: bit 23, StickRDown, set.
Actual: bits 16 to 23 are never set.

What changed

npad_states adds the stick direction bits to the buttons of every state it writes.

  • hid: new stick_buttons in host/nn_hid.c turns the final stick axes into bits 16 to 23. The threshold is half the travel, 16384, and y is up. npad_states ORs the result into buttons.
  • tests: tests/test_stick_buttons.py cuts stick_buttons out of the source with tests/srccut.py and compiles it. It checks each direction of each stick, the threshold, diagonals, that no bit outside 16 to 23 is set, and that npad_states uses it.

Measurements

Nothing to measure. Four comparisons per controller read, with no effect a timing could show.

Flags and settings

None

Testing

Tested: python -I -B tests/run_all.py --jobs 8 on Linux (Omarchy, kernel 7.2.15; Intel Core Ultra 7 270K Plus; RTX 4090, driver 615.78.08). main @ 2f1c0c9c: 685 passed, 40 failed, 97 skipped. this branch @ e670ad6c: 686 passed, 40 failed, 97 skipped, 0 new failures compared by test name. The 40 failures also fail on main. They are:

Tests that also fail on main @ 2f1c0c9c in this environment
  • tests/test_bug_report_defaults.py
  • tests/test_bug_report.py
  • tests/test_capture_read_once.py
  • tests/test_crash_groups.py
  • tests/test_crash_record.py
  • tests/test_crt_options.py
  • tests/test_damage_debug_menu.py
  • tests/test_dev_packs.py
  • tests/test_display_startup_failure.py
  • tests/test_dlss_feature_size.py
  • tests/test_failed_compile_keeps_objects.py
  • tests/test_guest_imported.py
  • tests/test_hardware_report.py
  • tests/test_high_fps_fixes.py
  • tests/test_host_guest_writes.py
  • tests/test_hud_layout_row.py
  • tests/test_invalidate_quick.py
  • tests/test_libc_hooks.py
  • tests/test_link_path_comma.py
  • tests/test_linux_preflight.py
  • tests/test_linux_pressure.py
  • tests/test_linux_update.py
  • tests/test_log_open_failure.py
  • tests/test_missing_nup.py
  • tests/test_mods_size_table.py
  • tests/test_pending_guest_import.py
  • tests/test_pipeline_play_cache.py
  • tests/test_prepare_cache_save.py
  • tests/test_present_thread.py
  • tests/test_profiling_mode.py
  • tests/test_psychov35_fsr3_fg.py
  • tests/test_readback_timeout_source.py
  • tests/test_run_all_changed.py
  • tests/test_slow_frames.py
  • tests/test_song_note_cue.py
  • tests/test_switch_table.py
  • tests/test_upscaler_rows.py
  • tests/test_vcore_escape.py
  • tests/test_walk_key.py
  • tests/test_vbytes.py (timed out at 600 s)

With the fix's source file reverted to main, python -I -B tests/test_stick_buttons.py fails (stick_buttons() is not in host/nn_hid.c). It passes on this branch. In the game, built from this branch on Linux with an RTX 4090: the sticks move Link and the menus as on main.

Not testable by hand: the console case can only be reached by a code mod. The game reads the stick axes, not these bits, so a run of the unmodified game cannot show the fix. The game-free test stands in for it. The in-game run shows that the menus and Link still move as on main.

Not tested: Windows (no build or run there) and other GPUs. The same change also ran in the game on snaildev99's mods/module-gaps branch, where a mod's menu opened with R and the right stick down.

Must be tested:

  • Linux, any GPU, a controller: start the game on this branch, play with the sticks in the menus and in the field, expecting the menus and Link to move as on main (by hand: the author, before this PR leaves WIP)
  • Windows, any GPU, a controller: the same steps, expecting the same result (Test Farm: @Beanstalk windows, a controller, move through the menus and walk in the field)

Risks

What could break: code that reads bits 16 to 23 and expected them to stay 0. The game reads the axes, and a console sets these bits too.

Turning it off: revert the commit

Compatibility: Nothing changes

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
**Type:** fix · **Risk:** low · **Tested on:** Linux (Omarchy, kernel 7.2.15; Intel Core Ultra 7 270K Plus; RTX 4090, driver 615.78.08) · **Needs:** a run on Windows, any GPU, a controller ## TL;DR On a console, pushing a stick past halfway also counts as a direction button, and programs can read those buttons. Longshot never set them, so anything that reads a stick direction as a button saw nothing. This PR sets them from the stick positions. A new game-free test fails on main and passes here. The full check suite on this branch has the same 40 failures as main, and one more pass. It also ran in the game on Linux. ## Breakdown - **Who it helps:** mods and menus that read a stick direction as a button, for example a menu opened with R and the right stick pushed down. - **What was wrong:** the controller state Longshot gives the game had button bits 0 to 15 only, and never the stick direction bits 16 to 23. - **What changes:** each stick sets its left, up, right and down bit once it is past half its travel. - **What does not change:** the stick axes, the other buttons, and the game's own controls. The game reads the axes, not these bits. - **How it was checked:** a new game-free test that fails on main and passes here, and `python -I -B tests/run_all.py --jobs 8`, which has the same 40 failures as main and one more pass. - **What is still open:** a run in the game on this branch. - **Risk:** low. Code that ignored these bits still ignores them. ## Why A code mod, sloperinaGZ 0.0.8, on snaildev99's mods/module-gaps branch is what showed this. The console's controller service sets the stick direction buttons from the stick axes. libnx names them `HidNpadButton_StickLLeft = BITL(16)` to `HidNpadButton_StickRDown = BITL(23)` in `nx/include/switch/services/hid.h`. Longshot set none of them, so a button combo that uses a stick direction never fires. yuzu sets them past half the travel, in `TransformToStick` in `input_converter.cpp`, with the threshold's default 0.5 in `input_poller.cpp`. This PR uses the same threshold. The tracker has no issue or PR for stick or npad. ## How to reproduce **Seen on:** Linux (Omarchy, kernel 7.2.15; Intel Core Ultra 7 270K Plus; RTX 4090, driver 615.78.08), any controller. The bits themselves do not depend on the GPU or driver. **Settings and switches:** defaults **Steps:** read the Npad state's buttons while the right stick is pushed all the way down, from mod code or from the game-free test below run against main. **Expected:** bit 23, StickRDown, set. **Actual:** bits 16 to 23 are never set. ## What changed `npad_states` adds the stick direction bits to the buttons of every state it writes. - hid: new `stick_buttons` in `host/nn_hid.c` turns the final stick axes into bits 16 to 23. The threshold is half the travel, 16384, and y is up. `npad_states` ORs the result into `buttons`. - tests: `tests/test_stick_buttons.py` cuts `stick_buttons` out of the source with `tests/srccut.py` and compiles it. It checks each direction of each stick, the threshold, diagonals, that no bit outside 16 to 23 is set, and that `npad_states` uses it. ## Measurements Nothing to measure. Four comparisons per controller read, with no effect a timing could show. ### Flags and settings None ## Testing **Tested:** `python -I -B tests/run_all.py --jobs 8` on Linux (Omarchy, kernel 7.2.15; Intel Core Ultra 7 270K Plus; RTX 4090, driver 615.78.08). main @ 2f1c0c9c: 685 passed, 40 failed, 97 skipped. this branch @ e670ad6c: 686 passed, 40 failed, 97 skipped, 0 new failures compared by test name. The 40 failures also fail on main. They are: <details> <summary>Tests that also fail on main @ 2f1c0c9c in this environment</summary> - `tests/test_bug_report_defaults.py` - `tests/test_bug_report.py` - `tests/test_capture_read_once.py` - `tests/test_crash_groups.py` - `tests/test_crash_record.py` - `tests/test_crt_options.py` - `tests/test_damage_debug_menu.py` - `tests/test_dev_packs.py` - `tests/test_display_startup_failure.py` - `tests/test_dlss_feature_size.py` - `tests/test_failed_compile_keeps_objects.py` - `tests/test_guest_imported.py` - `tests/test_hardware_report.py` - `tests/test_high_fps_fixes.py` - `tests/test_host_guest_writes.py` - `tests/test_hud_layout_row.py` - `tests/test_invalidate_quick.py` - `tests/test_libc_hooks.py` - `tests/test_link_path_comma.py` - `tests/test_linux_preflight.py` - `tests/test_linux_pressure.py` - `tests/test_linux_update.py` - `tests/test_log_open_failure.py` - `tests/test_missing_nup.py` - `tests/test_mods_size_table.py` - `tests/test_pending_guest_import.py` - `tests/test_pipeline_play_cache.py` - `tests/test_prepare_cache_save.py` - `tests/test_present_thread.py` - `tests/test_profiling_mode.py` - `tests/test_psychov35_fsr3_fg.py` - `tests/test_readback_timeout_source.py` - `tests/test_run_all_changed.py` - `tests/test_slow_frames.py` - `tests/test_song_note_cue.py` - `tests/test_switch_table.py` - `tests/test_upscaler_rows.py` - `tests/test_vcore_escape.py` - `tests/test_walk_key.py` - `tests/test_vbytes.py` (timed out at 600 s) </details> With the fix's source file reverted to main, `python -I -B tests/test_stick_buttons.py` fails (`stick_buttons()` is not in `host/nn_hid.c`). It passes on this branch. In the game, built from this branch on Linux with an RTX 4090: the sticks move Link and the menus as on main. **Not testable by hand:** the console case can only be reached by a code mod. The game reads the stick axes, not these bits, so a run of the unmodified game cannot show the fix. The game-free test stands in for it. The in-game run shows that the menus and Link still move as on main. **Not tested:** Windows (no build or run there) and other GPUs. The same change also ran in the game on snaildev99's mods/module-gaps branch, where a mod's menu opened with R and the right stick down. **Must be tested:** - Linux, any GPU, a controller: start the game on this branch, play with the sticks in the menus and in the field, expecting the menus and Link to move as on main (by hand: the author, before this PR leaves WIP) - Windows, any GPU, a controller: the same steps, expecting the same result (Test Farm: @Beanstalk windows, a controller, move through the menus and walk in the field) ## Risks **What could break:** code that reads bits 16 to 23 and expected them to stay 0. The game reads the axes, and a console sets these bits too. **Turning it off:** revert the commit **Compatibility:** Nothing changes ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened.
fix(hid): the sticks' direction pseudo-buttons (StickLLeft .. StickRDown)
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 6s
Website / Website on Cloudflare (pull_request_target) Has been skipped
e670ad6c15
Real hid sets HidNpadButton bits 16-23 from the stick axes (libnx hid.h:
HidNpadButton_StickLLeft = BITL(16) .. HidNpadButton_StickRDown = BITL(23));
npad_states gave bits 0-15 only, so code that reads the stick directions as
buttons (a mod's menu combo, for one) never saw them. Set them past half the
travel, as yuzu's TransformToStick does (threshold 0.5), from the final axes.

tests/test_stick_buttons.py compiles stick_buttons from host/nn_hid.c and
checks every direction, the threshold, diagonals and that npad_states ORs
the bits in; it fails on main.

Assisted-by: Grok Bot
Author
Contributor

Tested in game: Linux (Omarchy, kernel 7.2.15), Intel Core Ultra 7 270K Plus, RTX 4090 driver 615.78.08, a build of this branch on v3.0.0-rc.8: the sticks move Link and the menus as on main.

Tested in game: Linux (Omarchy, kernel 7.2.15), Intel Core Ultra 7 270K Plus, RTX 4090 driver 615.78.08, a build of this branch on v3.0.0-rc.8: the sticks move Link and the menus as on main.
HumanBean left a comment

From the code and the evidence this looks ready to merge. There are a few nits and a note on merge order below. Nothing blocks it.

What I checked

  • Thresholds. A bit is set when an axis is past 16383, half of 32767. y is up and the axes are checked one at a time, so a diagonal sets both of its bits. That is yuzu's TransformToStick with its default threshold of 0.5, with no hysteresis, the same as yuzu. The bit order 16-19 (L: left, up, right, down) and 20-23 (R) matches libnx's HidNpadButton_StickLLeft .. StickRDown. Horizon's exact threshold isn't documented, and following yuzu is the sensible choice.
  • Which values the bits come from. host/nn_hid.c:1228 runs after read_input and after the free-camera and flight branches, which zero stick. So the bits follow the axes the game actually gets: no StickL bits while flying, and none while the free camera holds the sticks. The other things that change buttons (hold toggles, oc_pad_word's note remap, the title and frame-step filters) only touch bits 0-15, so nothing overwrites or clears 16-23. When the pad is not connected stick is zero, so no bits are set.
  • Dead zone, SDL and XInput. Both pad paths go through hos_filter_stick, a radial cut with no rescale whose largest cut is 9830, then stick_max into the same stick. The dead zone can never hide a push past half, and both paths get the same bits. The keyboard's move and camera keys (32767), the mouse as stick and the right-stick invert rows all feed the same final values, so they set the bits the way a pad would. The Walk key tilts the stick to 45% by default, which sets no bit. Walk speed 55-90% sets one, as a real stick at that tilt would. The change is plain integer code, so there's no Windows/Linux difference to worry about. A Windows run is still welcome, but the code itself doesn't need one.
  • Behaviour in play. Nothing in Longshot reads bits 16-23 today. Whether the game reads them can't be seen from the source. A console sets them, though, so if the game does read them, this makes its behaviour match the console rather than invent something new. The author's in-game run (menus and Link move as on main) covers the obvious place this would show up.

Merge order with #1349

  • Both PRs edit the same line of tests/test_input_background.py: the block(hid, "static int flight_jump_shortcut("), read, block(hid, "static void npad_states("))) list. Whichever merges second has a small text conflict. To resolve it, keep both new blocks before npad_states, in this order: read, then 1349's "#include <math.h>\nstatic volatile LONG pad_left_raw[2];" and stick_witness block, then this PR's block(hid, "static uint64_t stick_buttons("), then block(hid, "static void npad_states(").
  • The two PRs' host/nn_hid.c hunks don't touch each other.
  • 1349's Stick range scales the axes before npad_states, so with it merged the direction bits fire at half of the scaled travel. That is also how yuzu applies its threshold, so it's the right interaction.

Nits (also as line comments)

  • The description's "What is still open: a run in the game on this branch" is stale. The comment from 2026-11-19 reports that run. Worth moving it into Testing.
  • The fix and its test are in one commit. The fix-with-test flow asks for the failing test first and then the fix. The description says how the test was shown to fail on main, so this is fine as it is.
  • tests/input_background_test.c:146 computes the expected bits with the function under test. Every existing case there passes ±32767 or 0, so this is right. A literal for the non-zero cases would keep this check independent of stick_buttons.

Measurements: none, and none needed. The change adds four comparisons per stick on each controller read, and the default is the console's own behaviour. The evidence is a game-free test that fails on main and passes here, the full suite with no new failures by name (40 failures that also fail on main), and an in-game run on Linux with an RTX 4090.

Testing still missing: Windows with a controller, through XInput and through SDL. It's asked of the Test Farm in the description. It is low value for this code.

From the code and the evidence this looks ready to merge. There are a few nits and a note on merge order below. Nothing blocks it. **What I checked** - **Thresholds.** A bit is set when an axis is past 16383, half of 32767. y is up and the axes are checked one at a time, so a diagonal sets both of its bits. That is yuzu's `TransformToStick` with its default threshold of 0.5, with no hysteresis, the same as yuzu. The bit order 16-19 (L: left, up, right, down) and 20-23 (R) matches libnx's `HidNpadButton_StickLLeft` .. `StickRDown`. Horizon's exact threshold isn't documented, and following yuzu is the sensible choice. - **Which values the bits come from.** `host/nn_hid.c:1228` runs after `read_input` and after the free-camera and flight branches, which zero `stick`. So the bits follow the axes the game actually gets: no StickL bits while flying, and none while the free camera holds the sticks. The other things that change `buttons` (hold toggles, `oc_pad_word`'s note remap, the title and frame-step filters) only touch bits 0-15, so nothing overwrites or clears 16-23. When the pad is not connected `stick` is zero, so no bits are set. - **Dead zone, SDL and XInput.** Both pad paths go through `hos_filter_stick`, a radial cut with no rescale whose largest cut is 9830, then `stick_max` into the same `stick`. The dead zone can never hide a push past half, and both paths get the same bits. The keyboard's move and camera keys (32767), the mouse as stick and the right-stick invert rows all feed the same final values, so they set the bits the way a pad would. The Walk key tilts the stick to 45% by default, which sets no bit. Walk speed 55-90% sets one, as a real stick at that tilt would. The change is plain integer code, so there's no Windows/Linux difference to worry about. A Windows run is still welcome, but the code itself doesn't need one. - **Behaviour in play.** Nothing in Longshot reads bits 16-23 today. Whether the game reads them can't be seen from the source. A console sets them, though, so if the game does read them, this makes its behaviour match the console rather than invent something new. The author's in-game run (menus and Link move as on main) covers the obvious place this would show up. **Merge order with https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1349** - Both PRs edit the same line of `tests/test_input_background.py`: the `block(hid, "static int flight_jump_shortcut("), read, block(hid, "static void npad_states(")))` list. Whichever merges second has a small text conflict. To resolve it, keep both new blocks before `npad_states`, in this order: `read`, then 1349's `"#include <math.h>\nstatic volatile LONG pad_left_raw[2];"` and `stick_witness` block, then this PR's `block(hid, "static uint64_t stick_buttons(")`, then `block(hid, "static void npad_states(")`. - The two PRs' `host/nn_hid.c` hunks don't touch each other. - 1349's Stick range scales the axes before `npad_states`, so with it merged the direction bits fire at half of the *scaled* travel. That is also how yuzu applies its threshold, so it's the right interaction. **Nits** (also as line comments) - The description's "What is still open: a run in the game on this branch" is stale. The comment from 2026-11-19 reports that run. Worth moving it into Testing. - The fix and its test are in one commit. The fix-with-test flow asks for the failing test first and then the fix. The description says how the test was shown to fail on main, so this is fine as it is. - `tests/input_background_test.c:146` computes the expected bits with the function under test. Every existing case there passes ±32767 or 0, so this is right. A literal for the non-zero cases would keep this check independent of `stick_buttons`. **Measurements:** none, and none needed. The change adds four comparisons per stick on each controller read, and the default is the console's own behaviour. The evidence is a game-free test that fails on main and passes here, the full suite with no new failures by name (40 failures that also fail on main), and an in-game run on Linux with an RTX 4090. **Testing still missing:** Windows with a controller, through XInput and through SDL. It's asked of the Test Farm in the description. It is low value for this code.
@ -1211,6 +1225,7 @@ static void npad_states(Ctx *c) {
if (connected) buttons = hos_title_input(buttons);
uint64_t hos_frame_step_buttons(uint64_t buttons); /* nn_vi.c: the frame step of the wheel and quick menus */
if (connected) buttons = hos_frame_step_buttons(buttons);
buttons |= stick_buttons(stick);
Owner

Good placement: after the free-camera and flight branches zero stick, so the bits follow the axes the game actually gets, and nothing after this line touches bits 16-23.

Good placement: after the free-camera and flight branches zero `stick`, so the bits follow the axes the game actually gets, and nothing after this line touches bits 16-23.
@ -143,6 +143,8 @@ static void packet(uint64_t buttons, int32_t lx, int32_t ly, int32_t rx) {
npad_states(&context);
CHECK(context.x[0] == 2);
expected_sampling++;
const int32_t sticks[4] = {lx, ly, rx, 0};
Owner

Nit: this computes the expected bits with stick_buttons itself, so this check can't catch a regression in it (test_stick_buttons.py does). Every packet here is 0 or ±32767, so a literal mask for the non-zero cases would keep the check independent. Fine as it is.

Nit: this computes the expected bits with `stick_buttons` itself, so this check can't catch a regression in it (`test_stick_buttons.py` does). Every packet here is 0 or ±32767, so a literal mask for the non-zero cases would keep the check independent. Fine as it is.
HumanBean deleted branch fix/hid-stick-pseudo-buttons 2026-11-19 07:15:32 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 6s
Website / Website on Cloudflare (pull_request_target) Has been skipped
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1684
No description provided.