fix(input): Stick range row so a controller's full push counts as full tilt #1349

Open
donkeykong wants to merge 1 commit from donkeykong/Longshot:fix/stick-range into main
First-time contributor

Type: fix · Risk: low · Tested on: Windows 11, RTX 5090, Switch Pro Controller over Bluetooth · Needs: a DualShock 4 or DualSense (the pad of #88), an Xbox pad, Linux

Why

With a controller, Link sometimes runs when he should roll: the stick is held all the way forward, Action is pressed, and he keeps running. Changing the Stick dead zone does not help.

The game rolls only from a (nearly) full tilt. The keyboard and scripted input always send exactly full tilt, which is why #88's scripted checks never failed. A real pad often reads a few percent short on an ordinary full push, and the port passed that on unchanged.

See #88 (reported there for diagonals on a PS4 pad; this is the same failure on another pad, straight forward).

How to reproduce

Seen on: Windows 11 (build 26200), RTX 5090, NVIDIA 617.42; Switch Pro Controller over Bluetooth through SDL (SDL 3.4.20 behind sdl2-compat)
Settings and switches: Stick dead zone 15% (also at Default), HOS_STICK_LOG=1 for the log lines
Steps: on flat ground, hold the left stick straight forward to its rim and press Action, a few dozen times
Expected: Link rolls every time
Actual: he often keeps running. The log shows the stick at 94% to 98% on those presses, never 100%

What changed

A new Controls row, Stick range (70% to 100%, default 90%): the share of a pad's own range at which a stick counts as fully tilted. Pad sticks are scaled by it once, after the dead zone.

  • host: hos_stick_range() in host/nn_hid.c, called once per pad for SDL (host/pad_sdl.c) and XInput. It scales along the stick's own direction, so the angle is kept. Keyboard, mouse and scripted input are not touched.
  • host: stick_witness() behind HOS_STICK_LOG=1 logs the stick on each press of Action, for reports like #88.
  • menu: the row (gpu/vk/vk_menu.cpp, vk_menu.h), option 72 HOS_OPT_STICK_RANGE in gpu/vk/vk_api.h, answered by the existing option callback. No new member, no ABI change. Texts in all 13 languages.
  • docs: README option table and Controls notes; HOS_STICK_LOG in docs/development.md.
  • tests: tests/test_stick_range.py (new); two fixtures that cut nn_hid.c updated.

Why the pad reads short is not confirmed. The ceiling of a full push sank during one session (about 31,800 to 30,800 of 32,767), which would fit a driver that calibrates to the largest value seen. The console also counts a stick as full before its rim.

Measurements

Verdict: it helped. At 90% the roll never failed in two rounds of play; at 100% (the behaviour on main) it failed again in the same session.

Hardware: Windows 11 (build 26200), RTX 5090, NVIDIA 617.42, Ryzen 7 9800X3D, 31 GB; Switch Pro Controller over Bluetooth
Scene: Forest Temple (adult); 5120x2880, DLSS (DLAA)
Method: Action pressed lines of longshot_log.txt, 259 presses in one run, the row changed in the menu between rounds (90%, 100%, 90%). Whether Link rolled was judged by the player.
How to reproduce: HOS_STICK_LOG=1, hold forward and press Action repeatedly at 100% and at 90%

Baseline: measured on v3.0.0-rc.5 with an earlier version of this change applied by hand; the row at 100% is the "before". The branch's final host and menu code was then built into rc.5 and played without the log: rolls worked every time at 90%. The branch built from main has not been run.

Before, Stick range 100% (as main): v3.0.0-rc.5 with this change by hand @ e4d035e After, Stick range 90%: v3.0.0-rc.5 with this change by hand @ e4d035e
Straight forward at the rim, as the game got it 29,049 to 32,148 of 32,767 (89% to 98%), 63 presses 32,767 on every full push, 49 presses
Rolls failed often never failed
hid: Action pressed with the left stick at -805, 31693 (97% of the way); the pad gave -805, 31693 (97%), Stick range 100%
hid: Action pressed with the left stick at -726, -32767 (100% of the way); the pad gave -718, -32353 (99%), Stick range 90%

Flags and settings

One menu row with its ini key, and one logging switch.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
Stick range (stick_range) Controls row, 70% to 100% in steps of 5 not there (same as 100%) 90% A stick counts as fully tilted at that share of its range Helps: Switch Pro Controller. Untested: other pads, Linux. A 50% push reads as 56% 90%
HOS_STICK_LOG switch not there off Logs the stick on each press of Action, first 300 For reports like #88 off

Testing

Tested: python -I -B tests/run_all.py on Windows: 581 passed, 48 failed; main @ 6d72ca9 on the same PC: 580 passed, 48 failed. 47 fail in both; the one that differs on each side passes when run alone. The new test fails on main. In the game, by the player, with a Switch Pro Controller: rolls forward and on diagonals at 90%, 100%, then 90% again (earlier build), and a couple of minutes of rolls at 90% on the final code. Screenshot of the row in the first comment.

Not tested: the branch built from main (the game here is v3.0.0-rc.5 with this change's host and menu files, without the translations). XInput pads. The right stick's camera feel. Linux. Two pads at once.

Must be tested:

  • Any OS, a DualShock 4 or DualSense: with HOS_STICK_LOG=1, hold a full diagonal and press Action at 100% and at 90%, expecting a roll every time at 90% (by hand, and the Action pressed lines)
  • Windows, an Xbox pad with no SDL pad open (the XInput path): walk, run, roll and turn the camera at 90%, expecting no change beyond full tilt arriving a little earlier (by hand)

Risks

What could break: the feel of analog walking and the camera, slightly, on every pad: full tilt arrives at 90% of the stick's way and partial tilts are a ninth larger.

Turning it off: Stick range 100% in the Insert menu (stick_range=100).

Compatibility: longshot_options.ini gains stick_range; a file without it gets 90%. Saves, shader and pipeline caches and the vk ABI are unchanged (MkwVkHost and MkwVkRenderer untouched).

Issues

See #88

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks. Not ticked yet: Risks says analog walking and camera feel change on every pad, and Testing says the camera feel is not tested.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named). (47 fail on this PC on main and here alike; named in the first comment.)
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value.
  • Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. (the new row, in the first comment; there is no "before")
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (built on Windows only; I have no Linux)
  • Docs updated.
**Type:** fix · **Risk:** low · **Tested on:** Windows 11, RTX 5090, Switch Pro Controller over Bluetooth · **Needs:** a DualShock 4 or DualSense (the pad of #88), an Xbox pad, Linux ## Why With a controller, Link sometimes runs when he should roll: the stick is held all the way forward, Action is pressed, and he keeps running. Changing the Stick dead zone does not help. The game rolls only from a (nearly) full tilt. The keyboard and scripted input always send exactly full tilt, which is why #88's scripted checks never failed. A real pad often reads a few percent short on an ordinary full push, and the port passed that on unchanged. See #88 (reported there for diagonals on a PS4 pad; this is the same failure on another pad, straight forward). ## How to reproduce **Seen on:** Windows 11 (build 26200), RTX 5090, NVIDIA 617.42; Switch Pro Controller over Bluetooth through SDL (SDL 3.4.20 behind sdl2-compat) **Settings and switches:** Stick dead zone 15% (also at Default), `HOS_STICK_LOG=1` for the log lines **Steps:** on flat ground, hold the left stick straight forward to its rim and press Action, a few dozen times **Expected:** Link rolls every time **Actual:** he often keeps running. The log shows the stick at 94% to 98% on those presses, never 100% ## What changed A new Controls row, **Stick range** (70% to 100%, default 90%): the share of a pad's own range at which a stick counts as fully tilted. Pad sticks are scaled by it once, after the dead zone. - host: `hos_stick_range()` in `host/nn_hid.c`, called once per pad for SDL (`host/pad_sdl.c`) and XInput. It scales along the stick's own direction, so the angle is kept. Keyboard, mouse and scripted input are not touched. - host: `stick_witness()` behind `HOS_STICK_LOG=1` logs the stick on each press of Action, for reports like #88. - menu: the row (`gpu/vk/vk_menu.cpp`, `vk_menu.h`), option 72 `HOS_OPT_STICK_RANGE` in `gpu/vk/vk_api.h`, answered by the existing option callback. No new member, no ABI change. Texts in all 13 languages. - docs: README option table and Controls notes; `HOS_STICK_LOG` in docs/development.md. - tests: `tests/test_stick_range.py` (new); two fixtures that cut `nn_hid.c` updated. Why the pad reads short is not confirmed. The ceiling of a full push sank during one session (about 31,800 to 30,800 of 32,767), which would fit a driver that calibrates to the largest value seen. The console also counts a stick as full before its rim. ## Measurements **Verdict:** it helped. At 90% the roll never failed in two rounds of play; at 100% (the behaviour on `main`) it failed again in the same session. Hardware: Windows 11 (build 26200), RTX 5090, NVIDIA 617.42, Ryzen 7 9800X3D, 31 GB; Switch Pro Controller over Bluetooth Scene: Forest Temple (adult); 5120x2880, DLSS (DLAA) Method: `Action pressed` lines of longshot_log.txt, 259 presses in one run, the row changed in the menu between rounds (90%, 100%, 90%). Whether Link rolled was judged by the player. How to reproduce: `HOS_STICK_LOG=1`, hold forward and press Action repeatedly at 100% and at 90% Baseline: measured on v3.0.0-rc.5 with an earlier version of this change applied by hand; the row at 100% is the "before". The branch's final host and menu code was then built into rc.5 and played without the log: rolls worked every time at 90%. The branch built from `main` has not been run. | | Before, Stick range 100% (as `main`): v3.0.0-rc.5 with this change by hand @ e4d035e | After, Stick range 90%: v3.0.0-rc.5 with this change by hand @ e4d035e | |---|---|---| | Straight forward at the rim, as the game got it | 29,049 to 32,148 of 32,767 (89% to 98%), 63 presses | 32,767 on every full push, 49 presses | | Rolls | failed often | never failed | ``` hid: Action pressed with the left stick at -805, 31693 (97% of the way); the pad gave -805, 31693 (97%), Stick range 100% hid: Action pressed with the left stick at -726, -32767 (100% of the way); the pad gave -718, -32353 (99%), Stick range 90% ``` ### Flags and settings One menu row with its ini key, and one logging switch. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | Stick range (`stick_range`) | Controls row, 70% to 100% in steps of 5 | not there (same as 100%) | 90% | A stick counts as fully tilted at that share of its range | Helps: Switch Pro Controller. Untested: other pads, Linux. A 50% push reads as 56% | 90% | | `HOS_STICK_LOG` | switch | not there | off | Logs the stick on each press of Action, first 300 | For reports like #88 | off | ## Testing **Tested:** `python -I -B tests/run_all.py` on Windows: 581 passed, 48 failed; `main` @ 6d72ca9 on the same PC: 580 passed, 48 failed. 47 fail in both; the one that differs on each side passes when run alone. The new test fails on `main`. In the game, by the player, with a Switch Pro Controller: rolls forward and on diagonals at 90%, 100%, then 90% again (earlier build), and a couple of minutes of rolls at 90% on the final code. Screenshot of the row in the first comment. **Not tested:** the branch built from `main` (the game here is v3.0.0-rc.5 with this change's host and menu files, without the translations). XInput pads. The right stick's camera feel. Linux. Two pads at once. **Must be tested:** - Any OS, a DualShock 4 or DualSense: with `HOS_STICK_LOG=1`, hold a full diagonal and press Action at 100% and at 90%, expecting a roll every time at 90% (by hand, and the `Action pressed` lines) - Windows, an Xbox pad with no SDL pad open (the XInput path): walk, run, roll and turn the camera at 90%, expecting no change beyond full tilt arriving a little earlier (by hand) ## Risks **What could break:** the feel of analog walking and the camera, slightly, on every pad: full tilt arrives at 90% of the stick's way and partial tilts are a ninth larger. **Turning it off:** Stick range 100% in the Insert menu (`stick_range=100`). **Compatibility:** longshot_options.ini gains `stick_range`; a file without it gets 90%. Saves, shader and pipeline caches and the vk ABI are unchanged (`MkwVkHost` and `MkwVkRenderer` untouched). ## Issues See #88 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [ ] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. Not ticked yet: Risks says analog walking and camera feel change on every pad, and Testing says the camera feel is not tested. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). (47 fail on this PC on `main` and here alike; named in the first comment.) - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. - [x] Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. (the new row, in the first comment; there is no "before") - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [ ] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (built on Windows only; I have no Linux) - [x] Docs updated.
fix(input): Stick range row so a controller's full push counts as full tilt
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 9s
a466a40f32
The game rolls Link only from a (nearly) full tilt of the left stick, and
a pad's values were passed on as its driver reports them, with an inner
dead zone only. A Switch Pro Controller over Bluetooth through SDL read
94% to 98% of the way on an ordinary full push straight forward, so
Action kept him running (#88).

- host: hos_stick_range() scales each pad's sticks once, after the dead
  zone, for SDL and XInput: full tilt at the row's share of the pad's own
  range, direction kept, never past an axis's end. Keyboard, mouse and
  scripted input are not touched.
- host: HOS_STICK_LOG=1 logs each press of Action with the left stick
  held, as the game got it and as the pad gave it.
- menu: Controls row "Stick range", 70% to 100%, default 90%
  (stick_range, option 72), with its texts in all 13 languages.
- docs: README option table and Controls notes, the switch.
- tests: tests/test_stick_range.py; the fixtures of
  test_stick_inversion_rest.py and test_input_background.py.

See #88

Co-Authored-By: Claude Fable 5.2 <[email protected]>
Author
First-time contributor

Tested in game: Windows 11 (26200), RTX 5090, NVIDIA 617.42, Switch Pro Controller over Bluetooth: this branch's host and menu code built into v3.0.0-rc.5 with llvm-mingw; a couple of minutes of rolls straight forward and on diagonals at Stick range 90%, every one rolled; the new row shows in the Controls tab and keeps its value. Earlier build of the same change: fails at 100%, never at 90% (log in the description).

Tested in game: Windows 11 (26200), RTX 5090, NVIDIA 617.42, Switch Pro Controller over Bluetooth: this branch's host and menu code built into v3.0.0-rc.5 with llvm-mingw; a couple of minutes of rolls straight forward and on diagonals at Stick range 90%, every one rolled; the new row shows in the Controls tab and keeps its value. Earlier build of the same change: fails at 100%, never at 90% (log in the description).
Author
First-time contributor

The new row (Insert menu, Controls tab, v3.0.0-rc.5 with this change, Stick range 90%, the default). There is no "before": the row is new.

Stick range 90%: the new Controls row and its help text

Tested in the game: Windows 11 (26200), RTX 5090, NVIDIA 617.42, Switch Pro Controller over Bluetooth. This branch's host and menu code built into v3.0.0-rc.5 with llvm-mingw: a couple of minutes of rolls straight forward and on diagonals at 90%, every one rolled. The branch built from main has not been run.

The game-free checks that fail on this PC on main (@ 6d72ca9) and on this branch alike (47; none reads the files this change touches, except where the description says a fixture was updated, and those pass):

the list
tests/test_auto_handheld.py
tests/test_bug_report.py
tests/test_bug_report_defaults.py
tests/test_coverage_run.py
tests/test_cpu_report.py
tests/test_crash_dialog.py
tests/test_crash_groups.py
tests/test_crt_options.py
tests/test_damage_debug_menu.py
tests/test_display_startup_failure.py
tests/test_dlss_feature_size.py
tests/test_failed_compile_keeps_objects.py
tests/test_fastfp_fma.py
tests/test_fpx_sticky.py
tests/test_framegen_preset.py
tests/test_guest_imported.py
tests/test_hardware_report.py
tests/test_hud_layout_row.py
tests/test_invalidate_vcore.py
tests/test_job_queue.py
tests/test_linux_preflight.py
tests/test_linux_pressure.py
tests/test_longshot_ctl.py
tests/test_mirror_budget.py
tests/test_missing_nup.py
tests/test_oot_state_tap.py
tests/test_pads_after_menu.py
tests/test_pending_guest_import.py
tests/test_perf_report.py
tests/test_pipeline_cache_file.py
tests/test_pipeline_play_cache.py
tests/test_prepare_stall.py
tests/test_present_thread.py
tests/test_profiling_mode.py
tests/test_readback_timeout_source.py
tests/test_rumble_menu.py
tests/test_run_all_changed.py
tests/test_slow_frames.py
tests/test_spawn_emit.py
tests/test_switch_table.py
tests/test_target_image_pool.py
tests/test_tested_configurations.py
tests/test_upscaler_round_trip.py
tests/test_upscaler_rows.py
tests/test_vcore_escape.py
tests/test_vk_occlusion_queries.py
tests/test_vk_swapchain_compat.py
tests/test_walk_key.py
**The new row** (Insert menu, Controls tab, v3.0.0-rc.5 with this change, Stick range 90%, the default). There is no "before": the row is new. ![Stick range 90%: the new Controls row and its help text](https://git.magicbean.dev/attachments/65acf5bd-e3cf-4541-9683-e1e0ff4c8b9b) **Tested in the game:** Windows 11 (26200), RTX 5090, NVIDIA 617.42, Switch Pro Controller over Bluetooth. This branch's host and menu code built into v3.0.0-rc.5 with llvm-mingw: a couple of minutes of rolls straight forward and on diagonals at 90%, every one rolled. The branch built from `main` has not been run. **The game-free checks that fail on this PC on `main` (@ 6d72ca9) and on this branch alike** (47; none reads the files this change touches, except where the description says a fixture was updated, and those pass): <details><summary>the list</summary> ``` tests/test_auto_handheld.py tests/test_bug_report.py tests/test_bug_report_defaults.py tests/test_coverage_run.py tests/test_cpu_report.py tests/test_crash_dialog.py tests/test_crash_groups.py tests/test_crt_options.py tests/test_damage_debug_menu.py tests/test_display_startup_failure.py tests/test_dlss_feature_size.py tests/test_failed_compile_keeps_objects.py tests/test_fastfp_fma.py tests/test_fpx_sticky.py tests/test_framegen_preset.py tests/test_guest_imported.py tests/test_hardware_report.py tests/test_hud_layout_row.py tests/test_invalidate_vcore.py tests/test_job_queue.py tests/test_linux_preflight.py tests/test_linux_pressure.py tests/test_longshot_ctl.py tests/test_mirror_budget.py tests/test_missing_nup.py tests/test_oot_state_tap.py tests/test_pads_after_menu.py tests/test_pending_guest_import.py tests/test_perf_report.py tests/test_pipeline_cache_file.py tests/test_pipeline_play_cache.py tests/test_prepare_stall.py tests/test_present_thread.py tests/test_profiling_mode.py tests/test_readback_timeout_source.py tests/test_rumble_menu.py tests/test_run_all_changed.py tests/test_slow_frames.py tests/test_spawn_emit.py tests/test_switch_table.py tests/test_target_image_pool.py tests/test_tested_configurations.py tests/test_upscaler_round_trip.py tests/test_upscaler_rows.py tests/test_vcore_escape.py tests/test_vk_occlusion_queries.py tests/test_vk_swapchain_compat.py tests/test_walk_key.py ``` </details>
donkeykong changed title from WIP: fix(input): Stick range row so a controller's full push counts as full tilt to fix(input): Stick range row so a controller's full push counts as full tilt 2026-11-17 05:09:45 +00:00
TrashPanda left a comment

A pad's full push counts as a full tilt from 90% of its own range. I read head a466a40f. It applies onto current main, and this stays a comment.

hos_stick_range scales each stick along its own direction, once, after the dead zone, for SDL and for XInput. At 90%, a push at 29,491 on one axis becomes 32,767. A push already at the rim stays there. A diagonal grows in the same proportion and is brought back along that direction if an axis would pass its end. 100%, and any value outside 70 to 100, leaves the stick as the pad reported it. The keyboard and scripted input are not scaled. The row defaults to 90%. The check walks the axes, the diagonal and a grid of angles, and the new strings are in all 13 languages with the counts raised. On a Switch Pro Controller the rolls that failed at 100% landed at 90%. That play was this change built into v3.0.0-rc.5, not a build of this branch from current main.

The two runs this asks for are still open: a DualShock 4 or DualSense, full diagonal, at 100% and at 90%; and an Xbox pad on the XInput path at 90%. If #1318 lands first, keep its lang() rows and these two strings.

A pad's full push counts as a full tilt from 90% of its own range. I read head `a466a40f`. It applies onto current main, and this stays a comment. `hos_stick_range` scales each stick along its own direction, once, after the dead zone, for SDL and for XInput. At 90%, a push at 29,491 on one axis becomes 32,767. A push already at the rim stays there. A diagonal grows in the same proportion and is brought back along that direction if an axis would pass its end. 100%, and any value outside 70 to 100, leaves the stick as the pad reported it. The keyboard and scripted input are not scaled. The row defaults to 90%. The check walks the axes, the diagonal and a grid of angles, and the new strings are in all 13 languages with the counts raised. On a Switch Pro Controller the rolls that failed at 100% landed at 90%. That play was this change built into v3.0.0-rc.5, not a build of this branch from current main. The two runs this asks for are still open: a DualShock 4 or DualSense, full diagonal, at 100% and at 90%; and an Xbox pad on the XInput path at 90%. If #1318 lands first, keep its `lang()` rows and these two strings.
Owner

Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).

  • Tested on my own PC: ticked: Author's Tested in game comment: the branch's host and menu code built into rc.5 and run on Windows 11, RTX 5090.
  • Nothing gets worse that I know of: not ticked: Risks says analog walking and camera feel change on every pad, and Testing says the camera feel is not tested. Measure that cost and state it in Risks, then tick it.
Brought up to the [ready-for-review standard](https://git.magicbean.dev/MagicBeanDev/Longshot/src/branch/main/CONTRIBUTING.md#ready-for-review-out-of-wip) (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know). - *Tested on my own PC*: ticked: Author's Tested in game comment: the branch's host and menu code built into rc.5 and run on Windows 11, RTX 5090. - *Nothing gets worse that I know of*: not ticked: Risks says analog walking and camera feel change on every pad, and Testing says the camera feel is not tested. Measure that cost and state it in Risks, then tick it.
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 9s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/stick-range:donkeykong-fix/stick-range'
git switch 'donkeykong-fix/stick-range'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1349
No description provided.