feat(gameplay): a story-safe New Game+, off by default #1654

Open
TrashPanda wants to merge 2 commits from TrashPanda/Longshot:feat/new-game-plus into main
Contributor

Summary

Longshot has no New Game+: a second playthrough starts from three hearts and an empty wallet. This adds one that
leaves the story untouched, off by default. Turning it on warns that it can't be undone, backs the save up, and makes
that save New Game+ for good. After the credits, the next new file starts with the hearts, wallet and rupees you
finished with; bigger bags arrive when the story hands you the bag, and enemies hit harder each cycle. Each run is
timed, split at every dungeon. No story item, song or flag is ever given or written, since the story gates on items
(ocarinas, songs, the Master Sword, each dungeon's item). No issue asks for it (searched "New Game+" and "ngplus"); the
design is in docs/dev/reference/new-game-plus.md.

Read first:

  • host/oot_ngplus.c / .h: hos_ngplus_tick runs from Link's update under cheats_lock; it records a clear, makes
    the once-only grant on a fresh file, gives deferred bag sizes on the story bag's 0-to-1 change, and times the run.
    ngplus_carry is the only list of names it may give and ng_give refuses anything else; NgOps has no flag writer.
    Everything is given through the game's own item event, as a chest or boss does, so the game saves it as a pickup.
  • host/hos_main.c oot_ngplus fills NgOps (oot_pouch_count / oot_pouch_change, the GameData readers,
    hos_atomic_write; oot_gamedata_int is new, read only). host/oot_damage.c: while the Debug tab's Damage taken is
    Normal, a New Game+ file's step applies (Double at New Game+ 1, Quadruple from 2, or the difficulty row's); heart
    protection still wins.
  • gpu/vk/menu/ngplus.cpp: the Gameplay rows New Game+, New Game+ difficulty and Record New Game+ gear,
    after Skip opening, with a status line (clears, cycle, this run's time, best run, latest split). The row's locked
    hook refuses Off once the save is New Game+; vk_menu.cpp shows the warning for Off to On (the Debug tools' dialog,
    reused). Saved keys new_game+ and new_game+_difficulty are frozen in tests/test_menu_ini_keys.py; option ids
    HOS_OPT_NGPLUS* 72 to 74 go through the existing option callback, so no API version bump.
  • The clear is found from the save the ending returns to (IsGameClear), the ending's flag
    Sequence_ToTitleFromGameClear, or by hand (Record, on a file with Ganon's Castle's barriers cleared). The record
    is user/ngplus.json; the backup is user/ngplus-backup/<date>_<time>/, and a failed backup grants nothing.

Testing

Tested: in the game on Linux (Ubuntu 26.04, kernel 7.0), RTX 4070 Ti, NVIDIA 595.99.02, main @ 9dff58e6 with this
branch, each run in its own --user folder on copies of saves, driven through the control bridge:

  • Loading a finished 100% save recorded cycle 1: max life 80, wallet 2, rupees 1000, bags 3 3 3, backed it up and
    locked it ("locked":1), nothing given; turning it Off was refused (new_game+ 1 -> 1 (On, for good)).
  • A new file (assets/saves/kokiri-start) then got 17 Obj_Heart_Container (20 in all), Item_Wallet_Large and five
    Obj_Rupee_Gold once, after the backup; the bridge read life 80 of 80 and 1000 rupees, and the autosave kept
    MaxLife 80, CurrentRupee 1000 and the wallet's IsGet. A restart gave nothing twice. Leaving the house played
    Saria's meeting as usual. Two debug teleports kept it all; a teleport into Dodongo's Cavern logged its split.
  • A record not yet locked, On with a file in play: locked, and its gear given once ("granted":1). No record, On: no
    ngplus.json, no backup, the row back to Off.
  • An earlier design wrote MaxLife and CurrentRupee directly; the game put hearts back and saved rupees as 0, which
    is why this gives pickups instead.

Since then the branch was rebased onto main @ 0de25c3e (#1774's menu modules: the rows moved into
gpu/vk/menu/ngplus.cpp unchanged, checked by compiling and the game-free checks, not in the game) and now onto
068fb8eb (the design page moved to docs/dev/reference/, no code change). tests/test_ngplus.py compiles the module
against a pretend game over eight restarts: no story item in the list, no flag writable, the grant once and not when
the marker can't be written, deferred bags, clamps, the ending's flag, Record, a corrupt ngplus.json left byte for
byte, backup first, splits, and the lock, each also shown failing on a broken copy. It and the full suite haven't been
run on this head yet; CI runs them on this push.

Still to test:

  • Linux, any GPU: the Gameplay tab after the menu-module rebase. With a finished save loaded, turn New Game+ on,
    expecting the warning, then "On, for good" after Make it New Game+, and Off refused (by hand).
  • Linux or Windows, any GPU: on copies of saves with New Game+ on after a recorded clear, play the gated events on a
    granted file (the Kokiri Sword then the Deku Tree, Saria's ocarina, Zelda and the Ocarina of Time, the Door of Time,
    the Skulltula House's wallet reward, Dodongo's Cavern's Bomb Bag for the deferred size), expecting every chest to
    open, every character to speak and nothing given twice or locked out (by hand).
  • The damage step, the best split at a clear and the status line, in the game (by hand).
  • Windows, any GPU: load kokiri-start with New Game+ on and a recorded clear, expecting 20 hearts, the Giant's Wallet
    and 1000 rupees, and ngplus: lines in longshot_log.txt (@Beanstalk windows: New Game+ on kokiri-start with a
    recorded clear).

Measurements

Nothing to measure for speed: off by default, and on it costs a few flag reads twice a second at Link's update; what it gives is in Testing.

Risks

An item given early could in theory change a story event: the Giant's Wallet sets IsGet.Item_Wallet_Large as a
pickup does, and the Skulltula House's reward may check it. The list is fixed and small, and the story pass in Still to
test is there to move anything that fails to "never". The row is Off by default; once a save is New Game+ the row
can't turn it off (the warning says so), and going back is restoring user/ngplus-backup/<date>_<time>/ by hand. What
was given stays as ordinary inventory. After updating nothing changes unless a player turns it on: user/ngplus.json
appears only then, saves are untouched until a granted file is played, and the caches and the vk interface don't
change.

After: this PR, kokiri-start with a recorded clear, at first control in Link's house: 20 heart containers, given empty as a boss's are (main: 3)

After: this PR, once Link leaves his house: all 20 hearts full

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named). (Not run on this head yet; CI's run on the push.)
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A check under tests/ that reads changed source is updated, not weakened.
  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Linux built and ran; Windows not built yet.)
  • Screenshots of the same spot on main and here, for a change that shows on screen. (The game's are attached; the menu rows' and the warning's are still to take.)
  • Docs updated.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
## Summary Longshot has no New Game+: a second playthrough starts from three hearts and an empty wallet. This adds one that leaves the story untouched, off by default. Turning it on warns that it can't be undone, backs the save up, and makes that save New Game+ for good. After the credits, the next new file starts with the hearts, wallet and rupees you finished with; bigger bags arrive when the story hands you the bag, and enemies hit harder each cycle. Each run is timed, split at every dungeon. No story item, song or flag is ever given or written, since the story gates on items (ocarinas, songs, the Master Sword, each dungeon's item). No issue asks for it (searched "New Game+" and "ngplus"); the design is in `docs/dev/reference/new-game-plus.md`. Read first: - `host/oot_ngplus.c` / `.h`: `hos_ngplus_tick` runs from Link's update under `cheats_lock`; it records a clear, makes the once-only grant on a fresh file, gives deferred bag sizes on the story bag's 0-to-1 change, and times the run. `ngplus_carry` is the only list of names it may give and `ng_give` refuses anything else; `NgOps` has no flag writer. Everything is given through the game's own item event, as a chest or boss does, so the game saves it as a pickup. - `host/hos_main.c` `oot_ngplus` fills `NgOps` (`oot_pouch_count` / `oot_pouch_change`, the GameData readers, `hos_atomic_write`; `oot_gamedata_int` is new, read only). `host/oot_damage.c`: while the Debug tab's Damage taken is Normal, a New Game+ file's step applies (Double at New Game+ 1, Quadruple from 2, or the difficulty row's); heart protection still wins. - `gpu/vk/menu/ngplus.cpp`: the Gameplay rows **New Game+**, **New Game+ difficulty** and **Record New Game+ gear**, after Skip opening, with a status line (clears, cycle, this run's time, best run, latest split). The row's `locked` hook refuses Off once the save is New Game+; `vk_menu.cpp` shows the warning for Off to On (the Debug tools' dialog, reused). Saved keys `new_game+` and `new_game+_difficulty` are frozen in `tests/test_menu_ini_keys.py`; option ids `HOS_OPT_NGPLUS*` 72 to 74 go through the existing option callback, so no API version bump. - The clear is found from the save the ending returns to (`IsGameClear`), the ending's flag `Sequence_ToTitleFromGameClear`, or by hand (Record, on a file with Ganon's Castle's barriers cleared). The record is `user/ngplus.json`; the backup is `user/ngplus-backup/<date>_<time>/`, and a failed backup grants nothing. ## Testing **Tested:** in the game on Linux (Ubuntu 26.04, kernel 7.0), RTX 4070 Ti, NVIDIA 595.99.02, `main` @ 9dff58e6 with this branch, each run in its own `--user` folder on copies of saves, driven through the control bridge: - Loading a finished 100% save recorded `cycle 1: max life 80, wallet 2, rupees 1000, bags 3 3 3`, backed it up and locked it (`"locked":1`), nothing given; turning it Off was refused (`new_game+ 1 -> 1 (On, for good)`). - A new file (`assets/saves/kokiri-start`) then got 17 `Obj_Heart_Container` (20 in all), `Item_Wallet_Large` and five `Obj_Rupee_Gold` once, after the backup; the bridge read life 80 of 80 and 1000 rupees, and the autosave kept `MaxLife` 80, `CurrentRupee` 1000 and the wallet's `IsGet`. A restart gave nothing twice. Leaving the house played Saria's meeting as usual. Two debug teleports kept it all; a teleport into Dodongo's Cavern logged its split. - A record not yet locked, On with a file in play: locked, and its gear given once (`"granted":1`). No record, On: no `ngplus.json`, no backup, the row back to Off. - An earlier design wrote `MaxLife` and `CurrentRupee` directly; the game put hearts back and saved rupees as 0, which is why this gives pickups instead. Since then the branch was rebased onto `main` @ 0de25c3e (#1774's menu modules: the rows moved into `gpu/vk/menu/ngplus.cpp` unchanged, checked by compiling and the game-free checks, not in the game) and now onto 068fb8eb (the design page moved to `docs/dev/reference/`, no code change). `tests/test_ngplus.py` compiles the module against a pretend game over eight restarts: no story item in the list, no flag writable, the grant once and not when the marker can't be written, deferred bags, clamps, the ending's flag, Record, a corrupt `ngplus.json` left byte for byte, backup first, splits, and the lock, each also shown failing on a broken copy. It and the full suite haven't been run on this head yet; CI runs them on this push. **Still to test:** - Linux, any GPU: the Gameplay tab after the menu-module rebase. With a finished save loaded, turn New Game+ on, expecting the warning, then "On, for good" after Make it New Game+, and Off refused (by hand). - Linux or Windows, any GPU: on copies of saves with New Game+ on after a recorded clear, play the gated events on a granted file (the Kokiri Sword then the Deku Tree, Saria's ocarina, Zelda and the Ocarina of Time, the Door of Time, the Skulltula House's wallet reward, Dodongo's Cavern's Bomb Bag for the deferred size), expecting every chest to open, every character to speak and nothing given twice or locked out (by hand). - The damage step, the best split at a clear and the status line, in the game (by hand). - Windows, any GPU: load `kokiri-start` with New Game+ on and a recorded clear, expecting 20 hearts, the Giant's Wallet and 1000 rupees, and `ngplus:` lines in `longshot_log.txt` (@Beanstalk windows: New Game+ on kokiri-start with a recorded clear). ## Measurements Nothing to measure for speed: off by default, and on it costs a few flag reads twice a second at Link's update; what it gives is in Testing. ## Risks An item given early could in theory change a story event: the Giant's Wallet sets `IsGet.Item_Wallet_Large` as a pickup does, and the Skulltula House's reward may check it. The list is fixed and small, and the story pass in Still to test is there to move anything that fails to "never". The row is Off by default; once a save is New Game+ the row can't turn it off (the warning says so), and going back is restoring `user/ngplus-backup/<date>_<time>/` by hand. What was given stays as ordinary inventory. After updating nothing changes unless a player turns it on: `user/ngplus.json` appears only then, saves are untouched until a granted file is played, and the caches and the vk interface don't change. ![After: this PR, kokiri-start with a recorded clear, at first control in Link's house: 20 heart containers, given empty as a boss's are (main: 3)](https://git.magicbean.dev/attachments/d98b5671-aa11-4cea-a015-18855627990e) ![After: this PR, once Link leaves his house: all 20 hearts full](https://git.magicbean.dev/attachments/0bfa5736-a9bb-401c-9f7a-72bc8d81ffb6) ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [ ] `mise run test` passes (any failure that also fails on `main` is named). (Not run on this head yet; CI's run on the push.) - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] A check under `tests/` that reads changed source is updated, not weakened. - [ ] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Linux built and ran; Windows not built yet.) - [ ] Screenshots of the same spot on `main` and here, for a change that shows on screen. (The game's are attached; the menu rows' and the warning's are still to take.) - [x] Docs updated. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers.
Author
Contributor

Tested in game: RTX 4070 Ti, NVIDIA 595.99.02, Ubuntu 26.04 (kernel 7.0), main @ 9dff58e6 + this branch as a pack: a 100% save's slot recorded cycle 1 (20 hearts, Giant's Wallet, 1000 rupees, biggest bags); kokiri-start then got 17 heart containers, the Giant's Wallet and 5 gold rupees through the item event (life 80/80, 1000 rupees); all 20 hearts full on the HUD after leaving Link's house, Saria's meeting played normally; the autosave kept 80 hearts and the wallet; a restart granted nothing twice. Not yet seen: rupees in an autosave, the credits live, the bags and the damage step in play.

Tested in game: RTX 4070 Ti, NVIDIA 595.99.02, Ubuntu 26.04 (kernel 7.0), main @ 9dff58e6 + this branch as a pack: a 100% save's slot recorded cycle 1 (20 hearts, Giant's Wallet, 1000 rupees, biggest bags); kokiri-start then got 17 heart containers, the Giant's Wallet and 5 gold rupees through the item event (life 80/80, 1000 rupees); all 20 hearts full on the HUD after leaving Link's house, Saria's meeting played normally; the autosave kept 80 hearts and the wallet; a restart granted nothing twice. Not yet seen: rupees in an autosave, the credits live, the bags and the damage step in play.
Author
Contributor

New commit 38b381f8: the saves are copied to user/ngplus-backup/_

New commit 38b381f8: the saves are copied to user/ngplus-backup/<date>_<time>/ before the grant (a failed copy grants nothing), and the run timer splits at each of the 12 dungeons with a best kept. In the game (RTX 4070 Ti, NVIDIA 595.99.02, Linux): the backup was made before the grant; an autosave after a map change kept 1000 rupees given as pickups, with 80 hearts and the Giant's Wallet (the last open save question); a teleport into Dodongo's Cavern split at 124 s. Boss Rush is dropped from the plan: the game has its own in the Dream World, with best times. Note: main at 10de79fb doesn't build (vk_draw.cpp, cur_program); these runs had that one-line fix applied, which is its own PR.
TrashPanda force-pushed feat/new-game-plus from 38b381f8da
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 8s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 01714c2bb1
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-18 21:59:42 +00:00
Compare
feat(gameplay): New Game+ is a switch on the save, backed up first and kept for good
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
bba77f43b2
Turning the New Game+ row On now asks first ("Make this save New Game+?"),
then backs the save up to user/ngplus-backup and marks it New Game+ for
good ("locked" in user/ngplus.json). After that the row reads "On, for
good" and Off is refused, also when the options file is set back by hand.

- A finished save is recorded and locked; its next new game gets the gear.
- Any other save is topped up at once to what it lacks (wallet, hearts,
  rupees), never taken from.
- With no finished game recorded, or a backup that fails, nothing is
  written and the row goes back to Off.

Tested in the game (Linux, RTX 4070 Ti): a finished 100% save locked with
its backup and Off refused; a new game on it given the Giant's Wallet, 20
hearts and 1000 rupees once; an older unlocked record locked and its gear
given in play; no record left the row Off and wrote nothing.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

Pushed bba77f43: New Game+ is now a switch on the save. Turning it on asks first, backs the save up to user/ngplus-backup, and marks the save New Game+ for good ("locked":1); Off is refused after that. A save in play gets what it lacks at once; a finished save gets its grant on the next new game. With no clear recorded or a failed backup, nothing is written and the row goes back to Off.

Tested in the game on Linux, RTX 4070 Ti: the five cases are in Testing. tests/test_ngplus.py covers the lock and catches five broken copies; run_all.py --changed has no new failures. Still to do: the rebase on main, and a screenshot of the warning.

Pushed bba77f43: New Game+ is now a switch on the save. Turning it on asks first, backs the save up to `user/ngplus-backup`, and marks the save New Game+ for good (`"locked":1`); Off is refused after that. A save in play gets what it lacks at once; a finished save gets its grant on the next new game. With no clear recorded or a failed backup, nothing is written and the row goes back to Off. Tested in the game on Linux, RTX 4070 Ti: the five cases are in Testing. `tests/test_ngplus.py` covers the lock and catches five broken copies; `run_all.py --changed` has no new failures. Still to do: the rebase on `main`, and a screenshot of the warning.
TrashPanda force-pushed feat/new-game-plus from bba77f43b2
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 6654ebcb04
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 5s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-20 01:33:36 +00:00
Compare
Author
Contributor

Rebased on main @ 0de25c3e and squashed to one commit (6654ebcb). #1774 moved every Insert menu row into a feature module, so New Game+'s three rows are now gpu/vk/menu/ngplus.cpp, with the same texts and saved keys (new_game+, new_game+_difficulty, now in test_menu_ini_keys.py's FROZEN). Off on a New Game+ save is refused through the model's locked hook (row_fixed), so the control bridge refuses it too; the warning and the reports stay in vk_menu.cpp.

Checked: vk_menu.cpp and the module compile with the build's flags; python -I -B tests/run_all.py: 726 passed, 43 failed, every failure also failing on main @ 0de25c3e. Not run in the game again after the port; the in-game runs in Testing are from before it.

Rebased on `main` @ 0de25c3e and squashed to one commit (6654ebcb). #1774 moved every Insert menu row into a feature module, so New Game+'s three rows are now `gpu/vk/menu/ngplus.cpp`, with the same texts and saved keys (`new_game+`, `new_game+_difficulty`, now in `test_menu_ini_keys.py`'s FROZEN). Off on a New Game+ save is refused through the model's `locked` hook (`row_fixed`), so the control bridge refuses it too; the warning and the reports stay in `vk_menu.cpp`. Checked: `vk_menu.cpp` and the module compile with the build's flags; `python -I -B tests/run_all.py`: 726 passed, 43 failed, every failure also failing on `main` @ 0de25c3e. Not run in the game again after the port; the in-game runs in Testing are from before it.
TrashPanda changed title from WIP: feat(gameplay): a story-safe New Game+, off by default to feat(gameplay): a story-safe New Game+, off by default 2026-11-20 01:45:26 +00:00
TrashPanda force-pushed feat/new-game-plus from 6654ebcb04
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 5s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 553f25b59e
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Failing after 15s
2026-11-20 02:18:56 +00:00
Compare
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Failing after 15s
This pull request has changes conflicting with the target branch.
  • gpu/vk/vk_api.h
  • host/hos_main.c
Some workflows are waiting to be reviewed.
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'feat/new-game-plus:TrashPanda-feat/new-game-plus'
git switch 'TrashPanda-feat/new-game-plus'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1654
No description provided.