fix(vk): use the mesh fallback for mesh-only draws on Windows RDNA 2 #1650
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1650
Loading…
Reference in a new issue
No description provided.
Delete branch "futondestroyer/Longshot:fix/rdna2-mesh-only-1239"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: medium · Tested on: Windows 11, RTX 4070 and game-free LLVM-MinGW routing test · Needs: Windows, Radeon RX 6800 XT
TL;DR
RC7 can lose the GPU near Saria on a Windows RX 6800 XT. This is a stable-release blocker, so we're putting the targeted fix up for review and affected-hardware testing as soon as possible. The default now takes the compute path for mesh-only draws on Windows Navi 21–23, and the game-free regression fails on main and passes here.
Breakdown
Why
Stable-release blocker. RC7 hung twice on a Windows RX 6800 XT in ordinary Kokiri Forest gameplay. This is a targeted change so the next candidate can get the affected-hardware retest promptly.
Credit to GrimVisage for the diagnosis and validation that made this fix possible. GrimVisage reproduced the device loss twice, used GPU checkpoints to isolate the exact mesh-only draw, ruled out removing that draw as a viable workaround because it dropped foliage, and then ran the same scene for 20 minutes with the compute fallback and the foliage intact. This patch implements the policy change GrimVisage proposed. Reproduction and diagnosis
How to reproduce
Seen on: Windows, Radeon RX 6800 XT (Navi 21), Longshot v3.0.0-rc.7.
Settings and switches: Default mesh settings. The reporter used checkpoints for diagnosis and forced compute only for the workaround control.
Steps: Reach Kokiri Forest and hold the camera on Saria on her stump for several minutes.
Expected: The game continues drawing the scene, including foliage.
Actual: The driver hangs during the mesh-only draw and the game loses the device.
What changed
Measurements
Verdict: The game-free check now routes the repro's mesh-only program to compute on the affected policy. Affected-GPU stability and performance are pending.
da91e770e89db34eFlags and settings
RX_VK_TASK_MESH_FALLBACKretains its existing default device set and opt-out.RX_VK_TASK_MESH_FALLBACKTesting
Tested: Windows 11, NVIDIA RTX 4070, driver 621.01. The patched renderer built and linked with LLVM-MinGW. With a compatible existing host (
49089983, renderer API 33), a disposable Kokiri save and full startup precompile disabled, it reached Kokiri Forest, rendered 180 presents and exited cleanly. The RTX 4070 kept native mesh routing. The focused device-policy test passed with Vulkan headers. The switch-table check reported the same nine pre-existing findings on exact main and the patch. The new game-free fixture failed on main withRDNA 2 mesh-only draw: expected 1, got 0and passed on the patch with LLVM-MinGW.Not testable by hand: Local PC has an RTX 4070, so it cannot reproduce the AMD driver timeout. The source-based fixture checks the exact routing decision and cache separation.
Not tested: RX 6800 XT runtime behavior, affected-GPU frame time and VRAM, and Linux gameplay on this branch.
Must be tested:
Risks
What could break: Extra compute-path draws can affect visuals, frame time or VRAM on the affected AMD devices. The regression fixture covers the choice of route. The linked hardware test is needed for driver and image behavior.
Turning it off: Set
RX_VK_TASK_MESH_FALLBACK=0or select Native viaRX_VK_MESH_SHADERS=native.Compatibility: The renderer's updated translator stamp can refresh existing program caches once. The mesh route also has its own cache-key bit. The host-renderer interface and save format are unchanged.
Issues
See #1239. Leave the issue open for the exact-head retest.
Checklist
Everyone
type(scope): description) of the status line's type.main. Pinned baseda91e770; check for newer main before ready.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named). Full suite pending.third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.mainand passing here.Tested in game: Windows 11, NVIDIA RTX 4070, driver 621.01: renderer from
e89db34eon a compatible host, disposable Kokiri save, on-demand shader loading; 180 presents in Kokiri Forest with native mesh routing and a clean exit. Windows RX 6800 XT verification is required.Possibly related, for context:
WIP: fix(vk): use the mesh fallback for mesh-only draws on Windows RDNA 2to fix(vk): use the mesh fallback for mesh-only draws on Windows RDNA 2zeldaootr referenced this pull request2026-11-19 01:08:52 +00:00
Retest of the Must be tested item: Windows RX 6800 XT, v3.0.0 from the launcher (tag
09cbdd97, which contains this PR as3228cb5f; the log's first line islongshot v3.0.0 (source 87cb36aa), where source is the source fingerprint fromnx2/version.py, not a commit).PC: RX 6800 XT 16 GB, AMD proprietary driver 26.10.1, Ryzen 5 5600X, 16 GB, Windows 11 build 26300. No
RX_switches set (the oldlongshot_env.txtwas deleted), no mesh setting in the options file, no overlays. Output 2048x1152, FSR 4, Quality preset 0. Stood still facing Saria on her stump in Kokiri Forest, the camera position where rc.7 hung 2-4 minutes in.Startup log, both runs:
Both runs closed cleanly (
display: window closed, exiting). fps and GPU time are from the last 107 log samples of each run (vk: <n> presents, <fps> fpsandvk: GPU timelines). The log has no frame-time median or p99 line.Not as asked: run 1 was about 10 minutes at Saria, not 20 (the tester shortened both runs). That is still well past the 2-4 minutes the hang took on rc.7. There's no before/after on the same build here: on rc.7 the default hung, and forcing
RX_VK_MESH_SHADERS=computeran 20 minutes clean.Run 1 at Saria, near its start and near its end (leaf cards drawn):
The full logs are kept here; I can send any part of them. #1239's reporter has a different PC, so I've asked them there to check v3.0.0.