Game: Longshot closed unexpectedly while you were playing #1239
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot#1239
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Longshot version
nightly-189-aa95d35f (source 719431ac)
Channel
Nightly
What kind of problem
Crash, freeze or black screen
What happened
Longshot closed unexpectedly while you were playing. The graphics driver failed. Update your graphics driver, and turn off overlays and tools hooked into the game. (The report from the crash window is pasted below.)
Where in the game
kokiri forest walking up to the girl on top of the building in the middle of the village
How often
Once so far
Graphics card and driver version
AMD Radeon RX 6800 XT, AMD proprietary driver 26.10.1 (AMD proprietary shader compiler)
CPU, RAM and operating system
AMD Ryzen 7 5800X3D 8-Core Processor (16 threads), 32 GB, Windows 11 (build 26300)
Changes from the defaults
No response
longshot_log.txt
log attached
Screenshots or video
No response
Before you send it
Possibly related, for context:
I'm taking this one; a fix PR will follow. Same crash reproduced on an RX 6800 XT (Navi 21) on Windows, rc.7, twice: Kokiri Forest, with the camera on Saria on her stump, a few minutes in.
The cause, narrowed down one run at a time:
RX_VK_CHECKPOINTS=1: the GPU hangs in the draw of program89ca750f9852b7ca. It has a mesh stage and no task stage.task_mesh_fallback_defaultin gpu/vk/mesh_mode.h) only sends task + mesh programs to the compute fallback (uses_mesh_fallback, gpu/vk/vk_internal.h). So this mesh-only program still runs on the driver's native mesh path, the one Hookshot issue 996 found hanging on RDNA 2.RX_VK_SKIP_PROG=89ca750f9852b7ca: no hang in 6.5 minutes there, but the foliage's leaf cards are missing.RX_VK_MESH_SHADERS=compute(every mesh program on the fallback): 20 minutes at Saria, no crash, foliage drawn.Workaround until the fix lands:
RX_VK_MESH_SHADERS=compute.The fix: on Navi 21-23 on Windows, mesh-only programs take the fallback too;
RX_VK_TASK_MESH_FALLBACK=0still turns the whole rule off. Probably also #1237 (RX 6750 XT, Navi 22, Kokiri).@GrimVisage Do you have a branch or PR for the RX 6800 XT mesh-only fallback fix that we can test? We'd like to help with an independent check before the stable cut. We can review the fallback and cache paths and help coordinate a Windows RX 6800 XT retest on the exact patched build, using default mesh settings at Saria's stump in Kokiri Forest. If you've already run that retest, could you link the build and result here?
@futondestroyer Thanks, and thanks for the credit in #1650. I had the same change on a local branch (mesh-only programs added to the Windows Navi 21–23 rule, with a routing test that fails on main), but I hadn't pushed it before #1650 landed, so there's nothing separate to review. #1650 covers it.
The retest on the patched build hasn't been run yet. The 20 minutes at Saria with the foliage intact was on rc.7 with
RX_VK_MESH_SHADERS=computeforced, not on a build with the fix.I'm running it on the RX 6800 XT (Windows 11, AMD proprietary driver) on v3.0.0 from the launcher, with no
RX_switches and default mesh settings:vk: mesh-only and task + mesh programs use the compute fallback ...)I'll post the result and log lines here and on #1650 when it's done.
Retested on v3.0.0, which has the fix (#1650). On an RX 6800 XT, AMD driver 26.10.1, Windows 11 build 26300, with default mesh settings and no
RX_switches: two runs of about 10 minutes each, facing Saria on her stump. No device loss and no hang, and the foliage drew. The startup log showsvk: mesh-only and task + mesh programs use the compute fallback. Details, numbers and logs: #1650 (comment).That PC isn't the one in this report (it has a Ryzen 5 5600X and 16 GB). @jsc0, could you check whether it still happens for you on v3.0.0? Closing is the team's call.
Closing this as fixed: #1650 is merged and addresses it. If that's wrong, or it still happens on a current build, feel free to re-open it.