fix(vk): precompile the Hyrule drawbridge scene pipelines #1615

Merged
HumanBean merged 2 commits from SonnikBoom/Longshot:fix/715-drawbridge-pipelines into main 2026-11-19 07:43:44 +00:00
Contributor

Type: fix · Risk: low · Tested on: CachyOS Linux, RX 9070 XT · Needs: Windows 11, AMD Radeon

TL;DR

This PR adds recorded Hyrule Castle drawbridge pipelines to normal Most shader preparation for #715. In four Linux cold starts, both stock runs skipped 17 draws in the scene and both PR runs skipped zero. Preparation times overlapped and the two caches grew by 0.60 MiB combined. Validation of Ganondorf's white first appearance on Windows remains open.

Breakdown

  • Who it helps: Players reaching the Hyrule Castle drawbridge cutscene with a fresh cache.
  • What was wrong: Some draws were skipped while their pipelines or programs were pending during the cutscene on Linux.
  • What changes: The normal Most shader preparation picks up 109 additional pipeline states recorded on the route.
  • What does not change: The existing shader preparation setting and the save format stay the same.
  • How it was checked: Two interleaved cold starts per variant on the same Linux PC, with the same save and settings. Both stock runs skipped 17 draws and both PR runs skipped zero.
  • What is still open: Repeat the comparison on Windows and check the white first appearance reported in #715.
  • Risk: Low. The measured caches grew by 0.60 MiB combined and the preparation times overlapped.

Why

When the drawbridge scene requests a pipeline that is still being created, its draw can be skipped. The shipped preparation list can cover more of this route by including its recorded states. See #715.

How to reproduce

Seen on: CachyOS Linux, RX 9070 XT, Mesa RADV 26.2.6-arch3.1 for the skipped draws. The white first appearance was reported separately in #715 on Windows.
Settings and switches: Fresh game and Mesa shader caches, normal --prepare-shaders --compile-shaders most, 2560 × 1440, in-game upscaler, SDR, frame generation off.
Steps: Load a child Link save near the Hyrule Castle drawbridge. Approach the drawbridge, watch Zelda and Impa ride past, then watch behind Link when Ganondorf first comes into view.
Expected: Ganondorf appears fully textured from the first visible frame and draws have their pipelines ready.
Actual: On Linux, the frame trace counted 17 skipped draws across the scene on each stock run. Ganondorf was fully textured at first appearance in both earlier Linux visual checks.

What changed

Add a contribution to the shipped pipeline state list. The existing Most preparation imports its 98 graphics and 11 mesh pipeline states.

  • assets/pipeline_states/contrib/sonnikboom-hyrule-drawbridge.bin.xz contains the recorded pipeline states.
  • assets/pipeline_states/contrib/sonnikboom-hyrule-drawbridge.md describes the capture route and provenance.

Measurements

Verdict: The drawbridge scene went from 17 skipped draws on each stock run to zero on each PR run. Most preparation times overlapped. The two on-disk caches grew by 0.60 MiB combined.

Hardware: CachyOS Linux, Radeon RX 9070 XT, Mesa RADV 26.2.6-arch3.1, Ryzen 7 9800X3D, approximately 62 GiB RAM.
Scene: Child Link at the Hyrule Castle drawbridge, headless at 2560 × 1440, in-game upscaler, SDR, frame generation off.
Method: Two interleaved pairs (main, PR, main, PR) with independent empty Longshot and Mesa shader caches. Both variants used the same 38990574 runtime, save, settings and scripted inputs. The PR variant substituted the shipped list generated at 4a5961e2. Measure the wall time of Most preparation, then sum the file sizes in each cache directory immediately after preparation exits. Sum left_out for the first 2,901 presents from the cutscene event in the frame trace.
How to reproduce: In each fresh directory run --prepare-shaders --compile-shaders most. Record time and cache sizes before launching the game. Follow the drawbridge route above with the same save and frame tracing enabled.

Before: main @ 38990574 After: this PR @ 4a5961e2
Most preparation, runs 1 and 2 347.825 s / 324.535 s 326.089 s / 320.848 s
Most preparation, median 336.2 s 323.5 s
Longshot cache, immediately after preparation 9,132,470,743 B 9,133,025,407 B
Mesa cache, immediately after preparation 192,461,273 B 192,532,732 B
Combined cache size 9,324,932,016 B 9,325,558,139 B
Skipped draws, runs 1 and 2 (median) 17 / 17 (17) 0 / 0 (0)
Presents with skipped draws, runs 1 and 2 8 / 8 0 / 0
Graphics and mesh pipelines prepared 32,655 32,678
Compute pipelines prepared 3,619 3,619

The cache sizes and pipeline counts agreed across both runs of each variant. The on-disk differences were 554,664 B in the Longshot cache and 71,459 B in the Mesa cache. The preparation-time ranges overlapped.

Main 1: precompile: 32655 noted pipelines of 20411 programs and 3619 compute pipelines of 2186 compute programs built into the pipeline cache and let go (0 and 0 not made, 0 whose program variant is not kept), on 16 threads in 277.3 s
PR 1:   precompile: 32678 noted pipelines of 20417 programs and 3619 compute pipelines of 2186 compute programs built into the pipeline cache and let go (0 and 0 not made, 0 whose program variant is not kept), on 16 threads in 258.0 s
Main 2: precompile: 32655 noted pipelines of 20411 programs and 3619 compute pipelines of 2186 compute programs built into the pipeline cache and let go (0 and 0 not made, 0 whose program variant is not kept), on 16 threads in 255.8 s
PR 2:   precompile: 32678 noted pipelines of 20417 programs and 3619 compute pipelines of 2186 compute programs built into the pipeline cache and let go (0 and 0 not made, 0 whose program variant is not kept), on 16 threads in 253.1 s
Frame trace totals, 2,901 presents each: Main 1 left_out=17, PR 1 left_out=0, Main 2 left_out=17, PR 2 left_out=0

The PR was rebased onto 2f1c0c9c after these runs. The shipped lists and shader/pipeline preparation code are identical to the measured comparison. The intervening changes adjust guest scheduling and how Auto picks the render and recorder threads. Auto picks both threads on this machine under either rule. The exact in-game draw counts above are for the measured runtime.

In the earlier Linux pair on the 876dc360 baseline, Ganondorf was fully textured from his first appearance on both cold starts, and skipped draws across the scene went from 13 to zero.

Flags and settings

None.

Testing

Tested: Four fresh-cache runs through the drawbridge scene on CachyOS Linux, RX 9070 XT and RADV. The shipped-list check found all 109 scene records with the PR and zero on stock. The preparation logs show 23 more graphics or mesh pipelines built and no failed pipeline builds in either variant.

The game-free suite on the measured PR snapshot reported 672 passes and 107 skips. Its 40 failing checks also failed on the unchanged baseline. The deferred tests/test_vbytes.py check was rerun and reached the 600-second timeout on both revisions. On the rebased head, the six focused checks for pipeline-state sources, prepared stamps, tested configurations, threaded rendering, frame traces and the guest barrier all passed.

Game-free failures and timeout also reproduced on main
tests/test_bug_report.py
tests/test_bug_report_defaults.py
tests/test_capture_read_once.py
tests/test_crash_groups.py
tests/test_crt_options.py
tests/test_damage_debug_menu.py
tests/test_dev_packs.py
tests/test_discover.py
tests/test_display_startup_failure.py
tests/test_dlss_feature_size.py
tests/test_failed_compile_keeps_objects.py
tests/test_guest_imported.py
tests/test_hardware_report.py
tests/test_high_fps_fixes.py
tests/test_host_guest_writes.py
tests/test_hud_layout_row.py
tests/test_invalidate_quick.py
tests/test_libc_hooks.py
tests/test_lift_lookups.py
tests/test_linux_preflight.py
tests/test_linux_pressure.py
tests/test_linux_update.py
tests/test_log_open_failure.py
tests/test_missing_nup.py
tests/test_mods_size_table.py
tests/test_pending_guest_import.py
tests/test_pipeline_play_cache.py
tests/test_prepare_cache_save.py
tests/test_present_thread.py
tests/test_profiling_mode.py
tests/test_psychov35_fsr3_fg.py
tests/test_readback_timeout_source.py
tests/test_run_all_changed.py
tests/test_slow_frames.py
tests/test_song_note_cue.py
tests/test_switch_table.py
tests/test_upscaler_rows.py
tests/test_vbytes.py
tests/test_vcore_escape.py
tests/test_walk.py
tests/test_walk_key.py

Not tested: Windows. Validation of the original white first appearance from #715 remains open.

Must be tested:

  • Windows 11, AMD Radeon with the affected Adrenalin driver: run the same route after Most preparation from fresh caches on stock and PR builds, expecting Ganondorf to be fully textured on his first visible frame with fewer or zero pending draws (by hand: watch the first appearance and compare the frame trace totals).

Risks

What could break: The contribution added 0.60 MiB to the combined prepared caches on this Linux setup. Most prepared 23 extra graphics or mesh pipelines. The measured preparation-time ranges overlapped.
Turning it off: Revert the commit.
Compatibility: The added states use the existing state-list format and shader preparation path.

Issues

See #715.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported.
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md).
  • Docs updated.
**Type:** fix · **Risk:** low · **Tested on:** CachyOS Linux, RX 9070 XT · **Needs:** Windows 11, AMD Radeon ## TL;DR This PR adds recorded Hyrule Castle drawbridge pipelines to normal Most shader preparation for #715. In four Linux cold starts, both stock runs skipped 17 draws in the scene and both PR runs skipped zero. Preparation times overlapped and the two caches grew by 0.60 MiB combined. Validation of Ganondorf's white first appearance on Windows remains open. ## Breakdown - **Who it helps:** Players reaching the Hyrule Castle drawbridge cutscene with a fresh cache. - **What was wrong:** Some draws were skipped while their pipelines or programs were pending during the cutscene on Linux. - **What changes:** The normal Most shader preparation picks up 109 additional pipeline states recorded on the route. - **What does not change:** The existing shader preparation setting and the save format stay the same. - **How it was checked:** Two interleaved cold starts per variant on the same Linux PC, with the same save and settings. Both stock runs skipped 17 draws and both PR runs skipped zero. - **What is still open:** Repeat the comparison on Windows and check the white first appearance reported in #715. - **Risk:** Low. The measured caches grew by 0.60 MiB combined and the preparation times overlapped. ## Why When the drawbridge scene requests a pipeline that is still being created, its draw can be skipped. The shipped preparation list can cover more of this route by including its recorded states. See #715. ## How to reproduce **Seen on:** CachyOS Linux, RX 9070 XT, Mesa RADV 26.2.6-arch3.1 for the skipped draws. The white first appearance was reported separately in #715 on Windows. **Settings and switches:** Fresh game and Mesa shader caches, normal `--prepare-shaders --compile-shaders most`, 2560 × 1440, in-game upscaler, SDR, frame generation off. **Steps:** Load a child Link save near the Hyrule Castle drawbridge. Approach the drawbridge, watch Zelda and Impa ride past, then watch behind Link when Ganondorf first comes into view. **Expected:** Ganondorf appears fully textured from the first visible frame and draws have their pipelines ready. **Actual:** On Linux, the frame trace counted 17 skipped draws across the scene on each stock run. Ganondorf was fully textured at first appearance in both earlier Linux visual checks. ## What changed Add a contribution to the shipped pipeline state list. The existing Most preparation imports its 98 graphics and 11 mesh pipeline states. - `assets/pipeline_states/contrib/sonnikboom-hyrule-drawbridge.bin.xz` contains the recorded pipeline states. - `assets/pipeline_states/contrib/sonnikboom-hyrule-drawbridge.md` describes the capture route and provenance. ## Measurements **Verdict:** The drawbridge scene went from 17 skipped draws on each stock run to zero on each PR run. Most preparation times overlapped. The two on-disk caches grew by 0.60 MiB combined. Hardware: CachyOS Linux, Radeon RX 9070 XT, Mesa RADV 26.2.6-arch3.1, Ryzen 7 9800X3D, approximately 62 GiB RAM. Scene: Child Link at the Hyrule Castle drawbridge, headless at 2560 × 1440, in-game upscaler, SDR, frame generation off. Method: Two interleaved pairs (main, PR, main, PR) with independent empty Longshot and Mesa shader caches. Both variants used the same `38990574` runtime, save, settings and scripted inputs. The PR variant substituted the shipped list generated at `4a5961e2`. Measure the wall time of Most preparation, then sum the file sizes in each cache directory immediately after preparation exits. Sum `left_out` for the first 2,901 presents from the cutscene event in the frame trace. How to reproduce: In each fresh directory run `--prepare-shaders --compile-shaders most`. Record time and cache sizes before launching the game. Follow the drawbridge route above with the same save and frame tracing enabled. | | Before: main @ 38990574 | After: this PR @ 4a5961e2 | |---|---:|---:| | Most preparation, runs 1 and 2 | 347.825 s / 324.535 s | 326.089 s / 320.848 s | | Most preparation, median | 336.2 s | 323.5 s | | Longshot cache, immediately after preparation | 9,132,470,743 B | 9,133,025,407 B | | Mesa cache, immediately after preparation | 192,461,273 B | 192,532,732 B | | Combined cache size | 9,324,932,016 B | 9,325,558,139 B | | Skipped draws, runs 1 and 2 (median) | 17 / 17 (17) | 0 / 0 (0) | | Presents with skipped draws, runs 1 and 2 | 8 / 8 | 0 / 0 | | Graphics and mesh pipelines prepared | 32,655 | 32,678 | | Compute pipelines prepared | 3,619 | 3,619 | The cache sizes and pipeline counts agreed across both runs of each variant. The on-disk differences were 554,664 B in the Longshot cache and 71,459 B in the Mesa cache. The preparation-time ranges overlapped. ```text Main 1: precompile: 32655 noted pipelines of 20411 programs and 3619 compute pipelines of 2186 compute programs built into the pipeline cache and let go (0 and 0 not made, 0 whose program variant is not kept), on 16 threads in 277.3 s PR 1: precompile: 32678 noted pipelines of 20417 programs and 3619 compute pipelines of 2186 compute programs built into the pipeline cache and let go (0 and 0 not made, 0 whose program variant is not kept), on 16 threads in 258.0 s Main 2: precompile: 32655 noted pipelines of 20411 programs and 3619 compute pipelines of 2186 compute programs built into the pipeline cache and let go (0 and 0 not made, 0 whose program variant is not kept), on 16 threads in 255.8 s PR 2: precompile: 32678 noted pipelines of 20417 programs and 3619 compute pipelines of 2186 compute programs built into the pipeline cache and let go (0 and 0 not made, 0 whose program variant is not kept), on 16 threads in 253.1 s Frame trace totals, 2,901 presents each: Main 1 left_out=17, PR 1 left_out=0, Main 2 left_out=17, PR 2 left_out=0 ``` The PR was rebased onto `2f1c0c9c` after these runs. The shipped lists and shader/pipeline preparation code are identical to the measured comparison. The intervening changes adjust guest scheduling and how Auto picks the render and recorder threads. Auto picks both threads on this machine under either rule. The exact in-game draw counts above are for the measured runtime. In the earlier Linux pair on the `876dc360` baseline, Ganondorf was fully textured from his first appearance on both cold starts, and skipped draws across the scene went from 13 to zero. ### Flags and settings None. ## Testing **Tested:** Four fresh-cache runs through the drawbridge scene on CachyOS Linux, RX 9070 XT and RADV. The shipped-list check found all 109 scene records with the PR and zero on stock. The preparation logs show 23 more graphics or mesh pipelines built and no failed pipeline builds in either variant. The game-free suite on the measured PR snapshot reported 672 passes and 107 skips. Its 40 failing checks also failed on the unchanged baseline. The deferred `tests/test_vbytes.py` check was rerun and reached the 600-second timeout on both revisions. On the rebased head, the six focused checks for pipeline-state sources, prepared stamps, tested configurations, threaded rendering, frame traces and the guest barrier all passed. <details> <summary>Game-free failures and timeout also reproduced on main</summary> ```text tests/test_bug_report.py tests/test_bug_report_defaults.py tests/test_capture_read_once.py tests/test_crash_groups.py tests/test_crt_options.py tests/test_damage_debug_menu.py tests/test_dev_packs.py tests/test_discover.py tests/test_display_startup_failure.py tests/test_dlss_feature_size.py tests/test_failed_compile_keeps_objects.py tests/test_guest_imported.py tests/test_hardware_report.py tests/test_high_fps_fixes.py tests/test_host_guest_writes.py tests/test_hud_layout_row.py tests/test_invalidate_quick.py tests/test_libc_hooks.py tests/test_lift_lookups.py tests/test_linux_preflight.py tests/test_linux_pressure.py tests/test_linux_update.py tests/test_log_open_failure.py tests/test_missing_nup.py tests/test_mods_size_table.py tests/test_pending_guest_import.py tests/test_pipeline_play_cache.py tests/test_prepare_cache_save.py tests/test_present_thread.py tests/test_profiling_mode.py tests/test_psychov35_fsr3_fg.py tests/test_readback_timeout_source.py tests/test_run_all_changed.py tests/test_slow_frames.py tests/test_song_note_cue.py tests/test_switch_table.py tests/test_upscaler_rows.py tests/test_vbytes.py tests/test_vcore_escape.py tests/test_walk.py tests/test_walk_key.py ``` </details> **Not tested:** Windows. Validation of the original white first appearance from #715 remains open. **Must be tested:** - Windows 11, AMD Radeon with the affected Adrenalin driver: run the same route after Most preparation from fresh caches on stock and PR builds, expecting Ganondorf to be fully textured on his first visible frame with fewer or zero pending draws (by hand: watch the first appearance and compare the frame trace totals). ## Risks **What could break:** The contribution added 0.60 MiB to the combined prepared caches on this Linux setup. Most prepared 23 extra graphics or mesh pipelines. The measured preparation-time ranges overlapped. **Turning it off:** Revert the commit. **Compatibility:** The added states use the existing state-list format and shader preparation path. ## Issues See #715. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported. - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). - [x] Docs updated.
Author
Contributor

Tested in game: CachyOS Linux, Radeon RX 9070 XT, Mesa RADV 26.2.6-arch3.1. At the Hyrule Castle drawbridge, Ganondorf was fully textured from his first appearance on both cold starts after Most shader preparation. The frame trace counted 13 skipped draws across the scene on the baseline and 0 with the added pipeline states. Windows validation is pending.

Tested in game: CachyOS Linux, Radeon RX 9070 XT, Mesa RADV 26.2.6-arch3.1. At the Hyrule Castle drawbridge, Ganondorf was fully textured from his first appearance on both cold starts after Most shader preparation. The frame trace counted 13 skipped draws across the scene on the baseline and 0 with the added pipeline states. Windows validation is pending.
SonnikBoom force-pushed fix/715-drawbridge-pipelines from 3ca5a6adfc
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 6s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to a6f0e53b5e
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
2026-11-18 22:57:45 +00:00
Compare
Author
Contributor

Repeated the fresh-cache Linux comparison in two interleaved pairs. Both stock runs had 17 skipped draws at the drawbridge and both PR runs had zero. Median Most preparation was 336.2 s on stock and 323.5 s with the PR, with overlapping run times. The Longshot and Mesa caches grew by 0.60 MiB combined. The rebase leaves the shipped lists and preparation code from the comparison intact. Windows validation of Ganondorf's first appearance remains open.

Repeated the fresh-cache Linux comparison in two interleaved pairs. Both stock runs had 17 skipped draws at the drawbridge and both PR runs had zero. Median Most preparation was 336.2 s on stock and 323.5 s with the PR, with overlapping run times. The Longshot and Mesa caches grew by 0.60 MiB combined. The rebase leaves the shipped lists and preparation code from the comparison intact. Windows validation of Ganondorf's first appearance remains open.
SonnikBoom changed title from WIP: fix(vk): precompile the Hyrule drawbridge scene pipelines to fix(vk): precompile the Hyrule drawbridge scene pipelines 2026-11-18 22:58:06 +00:00
HumanBean left a comment

From the code and the evidence this looks right. I'm leaving it as a comment rather than an approval until the Windows AMD run that its own Must be tested names has been posted.

What I checked

  • The list belongs where it is and is the tool's output. assets/pipeline_states/contrib/ is the place for one contributor's list. tour.bin.xz is written only by the pipeline tour, and this PR leaves it alone. The file is a single xz block holding HKSTATE2 with 109 whole 552-byte records and nothing after them (12 + 109 × 552 = 60,180 B). The note has exactly the lines write_note writes, and its Pipelines: 109 matches the list.
  • No game data. The records hold shader hashes, NVN formats and draw state only, as assets/pipeline_states/README.md describes. They contain no shader code, assets or saves.
  • It applies to other GPUs. This is a version 2 list, so it records the game's own NVN formats, and each GPU maps them to its own formats. NVIDIA and Windows AMD players will build these pipelines too. Their records match what NVIDIA play records: 18 of the 109 are already in lists from NVIDIA play on current main (11 in treverflume-rtx-3060-laptop) and in one list from an RX 9070 (veridor-rx-9070). Whether the white first appearance from #715 is gone on Windows is still open, as the description says.
  • Cost to players. Most, the default, builds every shipped list, so every player's first preparation pays for this. That cost is 23 more graphics or mesh pipelines out of 32,655 (0.07 %), six programs and 0.60 MiB of cache. No compute records are added: compute stays at 3,619, so the PR uses none of the COMPUTE_MOST budget and no memory kept at each start. A preparation-time difference that small cannot show in two runs, and the measured ranges overlap.

Suggestion (not blocking)

Since the fork point, main has merged #1688, which adds 38 contributed lists with 12,001 pipelines. 18 of this list's 109 records are now in those lists. The merge keeps each pipeline once, so this costs nothing at build or run time. It does go against the README's rule that a contributed list holds only what no other list holds when it is added. It also means the stock side of the measurement (17 skipped draws) is from a main without #1688, so on today's main the stock count may be lower. To fix both, rebase, run nx2/pipeline_states.py add sonnikboom-hyrule-drawbridge ... again with the same name and your longshot_pipeline_states.bin, and update the note's count. If you can, also repeat one stock run on current main so the PR says what it still adds there.

Measurements

Two interleaved pairs on one PC (RX 9070 XT, RADV), from empty Longshot and Mesa caches, with the same save, settings and scripted route on both sides. Skipped draws went from 17/17 to 0/0 over 2,901 presents (13 → 0 in the earlier pair). The counts are identical within each variant, so the spread doesn't come into it. Preparation time was 347.8/324.5 s on main against 326.1/320.8 s here. That is within run-to-run spread, and the description correctly claims no gain. Caches grew by 554,664 B (Longshot) and 71,459 B (Mesa). The measurement is valid and goes the right way for a fix. It was measured before the rebase, but the description shows that the lists and preparation code are unchanged since then. Still needed: the Windows 11 AMD (Adrenalin) run named in Must be tested. An NVIDIA run of the same route would also confirm Ganondorf's first frame there, though nothing in the change is vendor-specific.

From the code and the evidence this looks right. I'm leaving it as a comment rather than an approval until the Windows AMD run that its own *Must be tested* names has been posted. **What I checked** - **The list belongs where it is and is the tool's output.** `assets/pipeline_states/contrib/` is the place for one contributor's list. `tour.bin.xz` is written only by the pipeline tour, and this PR leaves it alone. The file is a single xz block holding `HKSTATE2` with 109 whole 552-byte records and nothing after them (12 + 109 × 552 = 60,180 B). The note has exactly the lines `write_note` writes, and its `Pipelines: 109` matches the list. - **No game data.** The records hold shader hashes, NVN formats and draw state only, as `assets/pipeline_states/README.md` describes. They contain no shader code, assets or saves. - **It applies to other GPUs.** This is a version 2 list, so it records the game's own NVN formats, and each GPU maps them to its own formats. NVIDIA and Windows AMD players will build these pipelines too. Their records match what NVIDIA play records: 18 of the 109 are already in lists from NVIDIA play on current main (11 in `treverflume-rtx-3060-laptop`) and in one list from an RX 9070 (`veridor-rx-9070`). Whether the white first appearance from [#715](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/715) is gone on Windows is still open, as the description says. - **Cost to players.** Most, the default, builds every shipped list, so every player's first preparation pays for this. That cost is 23 more graphics or mesh pipelines out of 32,655 (0.07 %), six programs and 0.60 MiB of cache. No compute records are added: compute stays at 3,619, so the PR uses none of the `COMPUTE_MOST` budget and no memory kept at each start. A preparation-time difference that small cannot show in two runs, and the measured ranges overlap. **Suggestion (not blocking)** Since the fork point, main has merged [#1688](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1688), which adds 38 contributed lists with 12,001 pipelines. 18 of this list's 109 records are now in those lists. The merge keeps each pipeline once, so this costs nothing at build or run time. It does go against the README's rule that a contributed list holds only what no other list holds when it is added. It also means the stock side of the measurement (17 skipped draws) is from a main without [#1688](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1688), so on today's main the stock count may be lower. To fix both, rebase, run `nx2/pipeline_states.py add sonnikboom-hyrule-drawbridge ...` again with the same name and your `longshot_pipeline_states.bin`, and update the note's count. If you can, also repeat one stock run on current main so the PR says what it still adds there. **Measurements** Two interleaved pairs on one PC (RX 9070 XT, RADV), from empty Longshot and Mesa caches, with the same save, settings and scripted route on both sides. Skipped draws went from 17/17 to 0/0 over 2,901 presents (13 → 0 in the earlier pair). The counts are identical within each variant, so the spread doesn't come into it. Preparation time was 347.8/324.5 s on main against 326.1/320.8 s here. That is within run-to-run spread, and the description correctly claims no gain. Caches grew by 554,664 B (Longshot) and 71,459 B (Mesa). The measurement is valid and goes the right way for a fix. It was measured before the rebase, but the description shows that the lists and preparation code are unchanged since then. Still needed: the Windows 11 AMD (Adrenalin) run named in *Must be tested*. An NVIDIA run of the same route would also confirm Ganondorf's first frame there, though nothing in the change is vendor-specific.
@ -0,0 +7,4 @@
- Build: main at 430eef4f (runtime source b9daf11e)
- Settings: SDR, 16:9, game upscaler, frame generation off, no mods; headless and windowed
- Route: Issue #715: approach the Hyrule Castle Town drawbridge as child Link before the Door of Time, then watch Zelda and Impa escape and Ganondorf ride into view.
- Pipelines: 109
Owner

After rebasing onto current main, 18 of these 109 are already in lists merged by #1688 (treverflume-rtx-3060-laptop, haruhiro88-rtx-5070 and others). Running add again with the same name would drop them, and this count would change with it.

After rebasing onto current main, 18 of these 109 are already in lists merged by https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1688 (treverflume-rtx-3060-laptop, haruhiro88-rtx-5070 and others). Running `add` again with the same name would drop them, and this count would change with it.
HumanBean deleted branch fix/715-drawbridge-pipelines 2026-11-19 07:43:44 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1615
No description provided.