docs(worklist): the Windows signing row is Joey-Magnus's, not NotRexed's #1427
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1427
Loading…
Reference in a new issue
No description provided.
Delete branch "TrashPanda/Longshot:docs/worklist-signing-owner"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: docs · Risk: low · Tested on: Linux · Needs: none
Why
The worklist row for the antivirus warnings on the unsigned Windows builder still names NotRexed as owner of the SignPath signing application. NotRexed has left the project, so the row has no one to ask. Joey-Magnus now owns it.
What changed
The Owner cell of that row changes from NotRexed to Joey-Magnus. Nothing else in the row changes.
docs/worklist.md, the 2.0 row "Antivirus flags LongshotBuilder.exe": OwnerNotRexed (SignPath)becomesJoey-Magnus (SignPath). #127 also edits this row's problem and links, not its owner. Whichever merges second may need a one-line rebase.Measurements
Verdict: nothing to measure; one cell of the worklist.
Flags and settings
None.
Testing
Tested: Linux, this pull request at
170637econ main544229a2.python -I -B tests/run_all.py: 603 passed, 37 failed, 81 skipped, in 87 s. Main544229a2on the same PC fails the same 37 tests, none of which reads the worklist's owners:test_bug_report_defaults.py,test_cpu_report.py,test_crt_options.py,test_damage_debug_menu.py,test_discover.py,test_display_startup_failure.py,test_dlss_feature_size.py,test_failed_compile_keeps_objects.py,test_framegen_preset.py,test_guest_imported.py,test_hud_layout_row.py,test_invalidate_vcore.py,test_lift_lookups.py,test_linux_preflight.py,test_linux_pressure.py,test_linux_update.py,test_mirror_budget.py,test_missing_nup.py,test_mods_size_table.py,test_pending_guest_import.py,test_pipeline_play_cache.py,test_present_thread.py,test_profiling_mode.py,test_readback_timeout_source.py,test_rumble_menu.py,test_run_all_changed.py,test_slow_frames.py,test_switch_table.py,test_target_image_pool.py,test_tested_configurations.py,test_upscaler_round_trip.py,test_upscaler_rows.py,test_vcore_escape.py,test_vk_occlusion_queries.py,test_vk_swapchain_compat.py,test_walk.py,test_walk_key.py.Not tested: nothing else applies; no code changes.
Must be tested: None
Risks
What could break: nothing; one name in a table. It may conflict on one line with #127.
Turning it off: revert the commit.
Compatibility: Nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.