docs(worklist): the antivirus row reproduced from Defender's own history, and a row for the locally built exe #127
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!127
Loading…
Reference in a new issue
No description provided.
Delete branch "d4nkn3ss/Longshot:docs/worklist-antivirus-evidence"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: docs · Risk: low · Tested on: Windows 11, RTX 3080 · Needs: none
Why
Players keep getting Defender's "Trojan" warning on the Builder download, and the worklist row for it still waits on Hookshot's SignPath application, which doesn't carry over to Longshot. The row now has evidence from Defender itself. There is also a second problem the row didn't cover: the game exe that is built on the player's PC gets flagged too. See #46 (Authenticode signing) and #98 (optional signing in CI); I searched the tracker (
forge.py issue list --state all), and those are the two that fit.What changed
The antivirus row moves up the worklist from 2.0 to 2.9, because Defender's own history on one PC confirms it. It also names the fix that applies to Longshot. A new row covers Defender quarantining the game exe the Builder compiles locally, which signing the release files can't fix.
docs/worklist.mdProgram:Win32/Contebrew.A!ml). S0 8 × 0.57 × 0.4, one PC.Measurements
Verdict: nothing to measure: a worklist change only (docs).
python -I -B tests/run_all.pyis the same on this PR @f15bbd14as on main @aa95d35f(541 passed, 17 failed, the same 17).Flags and settings
None
Testing
Tested:
python -I -B tests/run_all.pyon Windows 11 on this PR @f15bbd14and on main @aa95d35f: 541 passed, 17 failed, 35 skipped on both, the same 17 failing on both (test_appimage_player_build,test_cpm_discovery,test_cpp_preflight,test_crash_dialog,test_env_on,test_lift_cleanup_error,test_linux_preflight,test_make_game_cache,test_make_game_prepare,test_missing_nup,test_oot_state_tap,test_options_budget_once,test_readback_late,test_release(no openssl on PATH, #144),test_tested_configurations,test_vk_pgo,test_walk_key). The rows' evidence comes from Defender's Protection history on one Windows 11 PC (Nov 7-10), linked from #46.Not tested: the new row's detection on a current Longshot build: the row's Next says to reproduce it.
Must be tested: None. The change is to docs only.
Risks
What could break: nothing in the game; only the worklist's order (the antivirus row moves above others).
Turning it off: revert the commit.
Compatibility: Nothing changes.
Issues
See #46
See #98
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.🤖 Generated with Claude Code
Full game-free suite run on this branch (Windows 11); the results and the failures that also fail on main are now under Testing. Marking ready.
WIP: docs(worklist): the antivirus row reproduced from Defender's own history, and a row for the locally built exeto docs(worklist): the antivirus row reproduced from Defender's own history, and a row for the locally built exe087480072bf15bbd147aRebased onto main
aa95d35f(f15bbd14); #46 and #98 are still open, so the rows hold as written. run_all is the same as main's. Description rewritten to the current template.Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.