fix(menu): the Save my pipeline list message is shown in the menu's language, and each language's count is its table's length #1318

Open
dukenheimer wants to merge 4 commits from dukenheimer/Longshot:fix/menu-pt-br-count into main
Contributor

Type: fix · Risk: low · Tested on: Windows 11, RTX 5090 (NVIDIA 621.14), in game (menu languages) and game-free checks; Linux (WSL Ubuntu 24.04, g++ 13; tools.lock's clang 23.1.5), the checks and a compile · Needs: none

Why

The help box's message after Save my pipeline list (Debug tab) is always in English, whatever the menu language.
It names the zip, how many pipelines it holds and where it went, then what to do next. The translation tables already
carry each piece of it (" pipelines) in ", "your home folder", "The report is in the zip. " ...), but vk_menu.cpp
joined the English pieces into one line first. The menu then looks the whole line up once, and no table has the whole
line, so every language shows it in English.

This started as the pt-BR count bug from the release check: #1103 added a text to all 13 tables without raising their
counts, so each language's last text, "your home folder", never loaded. #1277 already fixed those counts (thanks,
Phishinabowl): main's counts match their tables again. The in-game check of this branch then showed that loading
"your home folder" changes nothing on screen, because of the whole-line lookup above. So this PR fixes the message, and
takes the counts from the tables so they can't fall behind a third time.

Prior work: none found for the message (searched share_saved, share_finish, "Save my pipeline list", "pipeline
list", i18n::tr, "untranslated"; #1161 changes the pipeline list's contents, not its message, and touches neither
function). For the counts, #1277 above; #1257, #1246 and #1144 listed test_menu_i18n among main's failures before it.

How to reproduce

Seen on: Windows 11, RTX 5090 (NVIDIA 621.14), main 8e3dfde6; any OS and GPU
Settings and switches: Menu language: any but English (e.g. Português (Brasil))
Steps: Insert menu, Debug tab, Save my pipeline list; read the help box. Game-free: python -I -B tests/test_share_message_i18n.py from this PR's test commit
Expected: the message in the menu's language: "Salvo longshot-pipelines-....zip (N pipelines) na pasta Downloads. O relatório está no zip. Abra git.magicbean.dev/MagicBeanDev/Longshot/issues/14 e anexe o zip ..."
Actual: "Saved longshot-pipelines-....zip (N pipelines) in Downloads. The report is in the zip. Open git.magicbean.dev/MagicBeanDev/Longshot/issues/14 and attach the zip ...", in English, in every language

What changed

The pipeline-list message is now built from pieces that are each looked up in the menu's language as they go in, so it
shows translated in all 13 languages. Each language's count is now its table's length, so a new text can't be left
unloaded.

  • menu: gpu/vk/vk_menu.cpp: four new functions build the message: share_folder_name, share_saved_line, share_done_line and share_not_written_line. share_pipeline_list and share_finish call them (refactor commit, English unchanged). The fix commit looks up each piece with i18n::tr. That includes share_downloads' words for the folder ("your home folder", "the game folder") and "Opening the issue...". The zip's name, its count and a folder's own name (Downloads) stay as they are. The log line stays in English and still never names the user's home folder.
  • menu: gpu/vk/menu_i18n.h: a lang(code, name, table) helper takes the count from the table's size; kLangs' 13 translated rows use it. vk_menu_i18n.cpp table() is unchanged.
  • tests: tests/test_share_message_i18n.py (new) compiles the menu's lookup (vk_menu_i18n.cpp's tables, tr_text, tr) and the four message functions. It builds 210 lines (14 languages × 3 folders × 5 messages) and compares each with the tables' own pieces. It also checks that ui::para's whole-line lookup leaves the built line unchanged.
  • tests: tests/test_menu_i18n_count.py (new) compiles menu_i18n.h and checks each count against its table. tests/test_menu_i18n.py reads the lang() rows and fails on a count written by hand.

Measurements

Verdict: fixed. The message check fails on 195 of 210 lines before the fix (every line in the 12 other languages comes out English; English's 15 pass) and passes all 210 here. The count check passes on main (#1277) and here; before #1277 it failed 13 of 13.

Hardware: Windows 11, RTX 5090 (NVIDIA 621.14), clang 23.1.5 (llvm-mingw, the Builder's), Python 3.14; WSL Ubuntu 24.04, g++ 13.3, Python 3.12
Scene: none for the numbers: game-free checks (the in-game run is under Testing)
Method: python -I -B tests/test_share_message_i18n.py --cxx <compiler> on the test commit and on the fix; tests/test_menu_i18n_count.py and tests/test_menu_i18n.py on main and here
How to reproduce: the commands above. The test commit is main plus the refactor and the check, without the fix

Before: main @ 6d72ca93 (with the check: 2c1482e2) After: this PR @ 6c242520
test_share_message_i18n.py, Windows clang 195 of 210 lines failed (English in every other language) all 210 passed
test_share_message_i18n.py, Linux g++ not run all 210 passed
test_menu_i18n_count.py passed (counts fixed by #1277; 13 failed on 8e9cfc3a) passed
test_menu_i18n.py OK OK
Before: 2c1482e2 (main 6d72ca93 + the refactor + the check), Windows
FAIL pt-BR, Downloads, saved0: 'Saved longshot-pipelines-2026-11-16.zip (1234 pipelines) in Downloads. The report is in the zip. Open git.magicbean.dev/MagicBeanDev/Longshot/issues/14 and attach the zip to a comment, then paste the report and say where you played.', the tables' pieces make 'Salvo longshot-pipelines-2026-11-16.zip (1234 pipelines) na pasta Downloads. O relatório está no zip. Abra git.magicbean.dev/MagicBeanDev/Longshot/issues/14 e anexe o zip em um comentário, depois cole o relatório e diga por onde você jogou.'
FAIL pt-BR, Downloads, not written: 'The zip could not be written in Downloads.', the tables' pieces make 'Não foi possível gravar o zip na pasta Downloads.'
FAIL es-419, Downloads, not written: 'The zip could not be written in Downloads.', the tables' pieces make 'No se pudo escribir el zip en Downloads.'
...
195 failed of 210 lines

After: 6c242520, Windows (clang 23.1.5) and Linux (g++ 13.3)
all passed: 210 lines in 14 languages

The fix broken on purpose (Windows): the last piece not looked up: 156 failed of 210 lines; the folder's words not looked up: 130 failed of 210 lines

Count check, 8e9cfc3a (before #1277): FAIL pt-BR: count 582, table kpt_BR of 583 entries ... 13 failed
Count check, 6d72ca93 and this PR: ok   pt-BR: count 589, table kpt_BR of 589 entries ... all passed

Flags and settings

None: no menu row, switch or ini key is added or changed; only the text of a help message after Save my pipeline list.

Testing

Tested:

  • In game, by the PC's runner: Windows 11, RTX 5090 (NVIDIA 621.14): this branch's menu_i18n.h on main 8e3dfde6 (whose menu files are f88e6e3a's), its renderer built with dev_build.py vk, against main's built the same way. In the game, headless through the control bridge, the Insert menu in Português (Brasil) and Español (España): the same 85 rows (22 on Graphics), values and states on both; no errors in the logs. The menu's lookup (vk_menu_i18n.cpp tr_text, compiled from each side): "your home folder" English in all 13 languages on main, translated in all 13 here. Linux: tools.lock's clang 23.1.5 and sysroot compile gpu/vk/vk_menu_i18n.cpp with no warnings. That run was at 98fd6da3, the counts alone (the same menu_i18n.h as here), before the message fix.
  • tests/test_share_message_i18n.py both ways, and against two broken fixes (table above), on Windows (clang 23.1.5) and Linux (WSL, g++ 13.3).
  • gpu/vk/vk_menu.cpp compiled whole with -fsyntax-only -Wall -Wextra (clang 23.1.5, Windows, with the Builder's Vulkan, VMA and ImGui headers) on this PR and on main 54ef5ca3 (before #1302, which no compile here includes): the same 6 warnings on both, none on a changed line.
  • python -I -B tests/run_all.py --changed (90 checks read vk_menu.cpp): 78 passed, 2 skipped (POSIX only). 10 failed, and the same 10 fail on a clean main 54ef5ca3 (rebased since onto 6d72ca93, whose #1302 changes only gpu/vk/switches.def): test_bug_report_defaults, test_crt_options, test_damage_debug_menu, test_framegen_preset, test_hud_layout_row, test_recorder_sync, test_rumble_menu, test_upscaler_round_trip, test_upscaler_rows, test_walk_key.
  • The full python -I -B tests/run_all.py is waiting for one of the PC's build slots (both held by long jobs); its result, against main's, follows as a comment. Before the message fix, the full suite on this branch's count change (Windows, on 8e9cfc3a) failed only checks that fail on main too.

Not tested: The translated message on screen: the control bridge can't press the Debug tab's tools, so the in-game run didn't show it. The check builds the same lines from the menu's own lookup and functions; the PC's runner will try a headless trigger later and comment with the pt-BR line if it works. A Linux build of the renderer as a whole (Linux compiled vk_menu_i18n.cpp with tools.lock's clang, and the two checks with g++).

Must be tested:

  • None

Risks

What could break: Only the help box's message after Save my pipeline list changes, in languages other than English. English is byte for byte as before (the check builds it). A translated message can be longer than the English. The help box's room is measured from kShareSaidLongest, which the tables already translate whole, so it is measured in the menu's language. If the menu language changes while the message shows, it stays in the old language until the next save.

Turning it off: revert the commits

Compatibility: Nothing changes for a player's files: no save, options file, cache or vk ABI change (menu_i18n.h and these functions are internal to longshot_vk; MkwVkHost/MkwVkRenderer are untouched). The log line is unchanged. The user guide's settings-graphics.png records menu_i18n.h, vk_menu.cpp and vk_menu_i18n.cpp as sources. It is the English Graphics tab, and the in-game check found its 22 rows unchanged, so the image is kept. Its source review already reports the shared sources changed on main; the manifest is left for the guide's next review.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named). The 90 checks that read the changed files (--changed): 10 fail, all failing on main too (named under Testing); the full run follows as a comment.
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths.
**Type:** fix · **Risk:** low · **Tested on:** Windows 11, RTX 5090 (NVIDIA 621.14), in game (menu languages) and game-free checks; Linux (WSL Ubuntu 24.04, g++ 13; tools.lock's clang 23.1.5), the checks and a compile · **Needs:** none ## Why The help box's message after **Save my pipeline list** (Debug tab) is always in English, whatever the menu language. It names the zip, how many pipelines it holds and where it went, then what to do next. The translation tables already carry each piece of it (" pipelines) in ", "your home folder", "The report is in the zip. " ...), but `vk_menu.cpp` joined the English pieces into one line first. The menu then looks the whole line up once, and no table has the whole line, so every language shows it in English. This started as the pt-BR count bug from the release check: #1103 added a text to all 13 tables without raising their counts, so each language's last text, "your home folder", never loaded. **#1277 already fixed those counts** (thanks, Phishinabowl): main's counts match their tables again. The in-game check of this branch then showed that loading "your home folder" changes nothing on screen, because of the whole-line lookup above. So this PR fixes the message, and takes the counts from the tables so they can't fall behind a third time. Prior work: none found for the message (searched `share_saved`, `share_finish`, "Save my pipeline list", "pipeline list", `i18n::tr`, "untranslated"; #1161 changes the pipeline list's contents, not its message, and touches neither function). For the counts, #1277 above; #1257, #1246 and #1144 listed `test_menu_i18n` among main's failures before it. ## How to reproduce **Seen on:** Windows 11, RTX 5090 (NVIDIA 621.14), main 8e3dfde6; any OS and GPU **Settings and switches:** Menu language: any but English (e.g. Português (Brasil)) **Steps:** Insert menu, Debug tab, Save my pipeline list; read the help box. Game-free: `python -I -B tests/test_share_message_i18n.py` from this PR's test commit **Expected:** the message in the menu's language: "Salvo longshot-pipelines-....zip (N pipelines) na pasta Downloads. O relatório está no zip. Abra git.magicbean.dev/MagicBeanDev/Longshot/issues/14 e anexe o zip ..." **Actual:** "Saved longshot-pipelines-....zip (N pipelines) in Downloads. The report is in the zip. Open git.magicbean.dev/MagicBeanDev/Longshot/issues/14 and attach the zip ...", in English, in every language ## What changed The pipeline-list message is now built from pieces that are each looked up in the menu's language as they go in, so it shows translated in all 13 languages. Each language's count is now its table's length, so a new text can't be left unloaded. - menu: `gpu/vk/vk_menu.cpp`: four new functions build the message: `share_folder_name`, `share_saved_line`, `share_done_line` and `share_not_written_line`. `share_pipeline_list` and `share_finish` call them (refactor commit, English unchanged). The fix commit looks up each piece with `i18n::tr`. That includes share_downloads' words for the folder ("your home folder", "the game folder") and "Opening the issue...". The zip's name, its count and a folder's own name (Downloads) stay as they are. The log line stays in English and still never names the user's home folder. - menu: `gpu/vk/menu_i18n.h`: a `lang(code, name, table)` helper takes the count from the table's size; `kLangs`' 13 translated rows use it. `vk_menu_i18n.cpp` `table()` is unchanged. - tests: `tests/test_share_message_i18n.py` (new) compiles the menu's lookup (`vk_menu_i18n.cpp`'s tables, `tr_text`, `tr`) and the four message functions. It builds 210 lines (14 languages × 3 folders × 5 messages) and compares each with the tables' own pieces. It also checks that ui::para's whole-line lookup leaves the built line unchanged. - tests: `tests/test_menu_i18n_count.py` (new) compiles `menu_i18n.h` and checks each count against its table. `tests/test_menu_i18n.py` reads the `lang()` rows and fails on a count written by hand. ## Measurements **Verdict:** fixed. The message check fails on 195 of 210 lines before the fix (every line in the 12 other languages comes out English; English's 15 pass) and passes all 210 here. The count check passes on main (#1277) and here; before #1277 it failed 13 of 13. Hardware: Windows 11, RTX 5090 (NVIDIA 621.14), clang 23.1.5 (llvm-mingw, the Builder's), Python 3.14; WSL Ubuntu 24.04, g++ 13.3, Python 3.12 Scene: none for the numbers: game-free checks (the in-game run is under Testing) Method: `python -I -B tests/test_share_message_i18n.py --cxx <compiler>` on the test commit and on the fix; `tests/test_menu_i18n_count.py` and `tests/test_menu_i18n.py` on main and here How to reproduce: the commands above. The test commit is main plus the refactor and the check, without the fix | | Before: main @ 6d72ca93 (with the check: 2c1482e2) | After: this PR @ 6c242520 | |---|---|---| | `test_share_message_i18n.py`, Windows clang | 195 of 210 lines failed (English in every other language) | all 210 passed | | `test_share_message_i18n.py`, Linux g++ | not run | all 210 passed | | `test_menu_i18n_count.py` | passed (counts fixed by #1277; 13 failed on 8e9cfc3a) | passed | | `test_menu_i18n.py` | OK | OK | ``` Before: 2c1482e2 (main 6d72ca93 + the refactor + the check), Windows FAIL pt-BR, Downloads, saved0: 'Saved longshot-pipelines-2026-11-16.zip (1234 pipelines) in Downloads. The report is in the zip. Open git.magicbean.dev/MagicBeanDev/Longshot/issues/14 and attach the zip to a comment, then paste the report and say where you played.', the tables' pieces make 'Salvo longshot-pipelines-2026-11-16.zip (1234 pipelines) na pasta Downloads. O relatório está no zip. Abra git.magicbean.dev/MagicBeanDev/Longshot/issues/14 e anexe o zip em um comentário, depois cole o relatório e diga por onde você jogou.' FAIL pt-BR, Downloads, not written: 'The zip could not be written in Downloads.', the tables' pieces make 'Não foi possível gravar o zip na pasta Downloads.' FAIL es-419, Downloads, not written: 'The zip could not be written in Downloads.', the tables' pieces make 'No se pudo escribir el zip en Downloads.' ... 195 failed of 210 lines After: 6c242520, Windows (clang 23.1.5) and Linux (g++ 13.3) all passed: 210 lines in 14 languages The fix broken on purpose (Windows): the last piece not looked up: 156 failed of 210 lines; the folder's words not looked up: 130 failed of 210 lines Count check, 8e9cfc3a (before #1277): FAIL pt-BR: count 582, table kpt_BR of 583 entries ... 13 failed Count check, 6d72ca93 and this PR: ok pt-BR: count 589, table kpt_BR of 589 entries ... all passed ``` ### Flags and settings None: no menu row, switch or ini key is added or changed; only the text of a help message after Save my pipeline list. ## Testing **Tested:** - In game, by the PC's runner: Windows 11, RTX 5090 (NVIDIA 621.14): this branch's menu_i18n.h on main 8e3dfde6 (whose menu files are f88e6e3a's), its renderer built with dev_build.py vk, against main's built the same way. In the game, headless through the control bridge, the Insert menu in Português (Brasil) and Español (España): the same 85 rows (22 on Graphics), values and states on both; no errors in the logs. The menu's lookup (vk_menu_i18n.cpp tr_text, compiled from each side): "your home folder" English in all 13 languages on main, translated in all 13 here. Linux: tools.lock's clang 23.1.5 and sysroot compile gpu/vk/vk_menu_i18n.cpp with no warnings. That run was at 98fd6da3, the counts alone (the same `menu_i18n.h` as here), before the message fix. - `tests/test_share_message_i18n.py` both ways, and against two broken fixes (table above), on Windows (clang 23.1.5) and Linux (WSL, g++ 13.3). - `gpu/vk/vk_menu.cpp` compiled whole with `-fsyntax-only -Wall -Wextra` (clang 23.1.5, Windows, with the Builder's Vulkan, VMA and ImGui headers) on this PR and on main 54ef5ca3 (before #1302, which no compile here includes): the same 6 warnings on both, none on a changed line. - `python -I -B tests/run_all.py --changed` (90 checks read `vk_menu.cpp`): 78 passed, 2 skipped (POSIX only). 10 failed, and the same 10 fail on a clean main 54ef5ca3 (rebased since onto 6d72ca93, whose #1302 changes only `gpu/vk/switches.def`): `test_bug_report_defaults`, `test_crt_options`, `test_damage_debug_menu`, `test_framegen_preset`, `test_hud_layout_row`, `test_recorder_sync`, `test_rumble_menu`, `test_upscaler_round_trip`, `test_upscaler_rows`, `test_walk_key`. - The full `python -I -B tests/run_all.py` is waiting for one of the PC's build slots (both held by long jobs); its result, against main's, follows as a comment. Before the message fix, the full suite on this branch's count change (Windows, on 8e9cfc3a) failed only checks that fail on main too. **Not tested:** The translated message on screen: the control bridge can't press the Debug tab's tools, so the in-game run didn't show it. The check builds the same lines from the menu's own lookup and functions; the PC's runner will try a headless trigger later and comment with the pt-BR line if it works. A Linux build of the renderer as a whole (Linux compiled `vk_menu_i18n.cpp` with tools.lock's clang, and the two checks with g++). **Must be tested:** - None ## Risks **What could break:** Only the help box's message after Save my pipeline list changes, in languages other than English. English is byte for byte as before (the check builds it). A translated message can be longer than the English. The help box's room is measured from `kShareSaidLongest`, which the tables already translate whole, so it is measured in the menu's language. If the menu language changes while the message shows, it stays in the old language until the next save. **Turning it off:** revert the commits **Compatibility:** Nothing changes for a player's files: no save, options file, cache or vk ABI change (`menu_i18n.h` and these functions are internal to `longshot_vk`; `MkwVkHost`/`MkwVkRenderer` are untouched). The log line is unchanged. The user guide's `settings-graphics.png` records `menu_i18n.h`, `vk_menu.cpp` and `vk_menu_i18n.cpp` as sources. It is the English Graphics tab, and the in-game check found its 22 rows unchanged, so the image is kept. Its source review already reports the shared sources changed on main; the manifest is left for the guide's next review. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). The 90 checks that read the changed files (`--changed`): 10 fail, all failing on main too (named under Testing); the full run follows as a comment. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths.
kLangs' counts in gpu/vk/menu_i18n.h were written by hand, and vk_menu_i18n.cpp
table() loads that many entries of a table. #1103 added a text to all 13 tables
without raising them, so each language's last text went unloaded until #1277
recounted them. kLangs' rows are now lang(code, name, table), which takes the
count from the table's length, so an added text can't fall past it again.

tests/test_menu_i18n_count.py compiles the header and checks each language's
count against its table as the compiler sees them (13 of 13 failed on main
before #1277); test_menu_i18n.py reads the new rows and refuses a count written
by hand.

Assisted-by: GitHub Copilot (Claude Opus 5.5)
Co-authored-by: Copilot App <[email protected]>
share_folder_name, share_saved_line, share_done_line and
share_not_written_line build the help box's lines that share_pipeline_list and
share_finish put together inline. The texts are the same, in English; a check
can now build them.

Assisted-by: GitHub Copilot (Claude Opus 5.5)
Co-authored-by: Copilot App <[email protected]>
vk_menu.cpp builds the help box's line after a save from English pieces, and
ui::para looks the whole line up once, which no table has: in every language it
is shown in English, though menu_i18n.h's tables carry each piece. This
compiles the menu's lookup (vk_menu_i18n.cpp) and the line's functions
(vk_menu.cpp share_*_line, share_folder_name), builds the lines in each
language and compares them with the tables' pieces. Fails before the fix: 195
of 210 lines (all 12 other languages' lines English; English's pass).

Assisted-by: GitHub Copilot (Claude Opus 5.5)
Co-authored-by: Copilot App <[email protected]>
fix(menu): the Save my pipeline list message is shown in the menu's language
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
6c24252083
The help box's line after a save was put together from English pieces, and
ui::para looks the whole line up once, which no table has: in every language it
showed in English, though menu_i18n.h's tables carry each piece (" pipelines)
in ", "your home folder", "The report is in the zip. " ...). Each piece is now
looked up as it goes in (share_folder_name, share_saved_line, share_done_line,
share_not_written_line, and "Opening the issue..."). The zip's name, its count
and a folder's own name stay as they are, and the log line stays English.

Assisted-by: GitHub Copilot (Claude Opus 5.5)
Co-authored-by: Copilot App <[email protected]>
Author
Contributor

Tested in game: Windows 11, RTX 5090 (NVIDIA 621.14): this branch's menu_i18n.h on main 8e3dfde6 (whose menu files are f88e6e3a's), its renderer built with dev_build.py vk, against main's built the same way. In the game, headless through the control bridge, the Insert menu in Português (Brasil) and Español (España): the same 85 rows (22 on Graphics), values and states on both; no errors in the logs. The menu's lookup (vk_menu_i18n.cpp tr_text, compiled from each side): "your home folder" English in all 13 languages on main, translated in all 13 here. Linux: tools.lock's clang 23.1.5 and sysroot compile gpu/vk/vk_menu_i18n.cpp with no warnings. Then, for the message fix added after that run (game-free, the menu's own lookup and message functions compiled): tests/test_share_message_i18n.py builds the Save my pipeline list message in all 14 languages, 210 lines, matching the tables' pieces; 195 of 210 English before the fix (Windows clang 23.1.5; Linux g++ 13.3 passes too).

Tested in game: Windows 11, RTX 5090 (NVIDIA 621.14): this branch's menu_i18n.h on main 8e3dfde6 (whose menu files are f88e6e3a's), its renderer built with dev_build.py vk, against main's built the same way. In the game, headless through the control bridge, the Insert menu in Português (Brasil) and Español (España): the same 85 rows (22 on Graphics), values and states on both; no errors in the logs. The menu's lookup (vk_menu_i18n.cpp tr_text, compiled from each side): "your home folder" English in all 13 languages on main, translated in all 13 here. Linux: tools.lock's clang 23.1.5 and sysroot compile gpu/vk/vk_menu_i18n.cpp with no warnings. Then, for the message fix added after that run (game-free, the menu's own lookup and message functions compiled): tests/test_share_message_i18n.py builds the Save my pipeline list message in all 14 languages, 210 lines, matching the tables' pieces; 195 of 210 English before the fix (Windows clang 23.1.5; Linux g++ 13.3 passes too).
Author
Contributor

Full python -I -B tests/run_all.py, Windows 11, clang 23.1.5 (llvm-mingw), 12 jobs, MAGICBEAN_TOOLING set:

  • this PR @ 6c242520: 624 passed, 46 failed, 52 skipped in 209 s (windows, 12 at once)
  • main @ 6d72ca93, a clean checkout, the same run: 621 passed, 47 failed, 52 skipped in 189 s (windows, 12 at once)
  • failing here and not on main: none
  • failing on main and not here: tests/test_longshot_ctl.py

Every other failure fails on main alike on this PC.

Full `python -I -B tests/run_all.py`, Windows 11, clang 23.1.5 (llvm-mingw), 12 jobs, `MAGICBEAN_TOOLING` set: - this PR @ 6c242520: 624 passed, 46 failed, 52 skipped in 209 s (windows, 12 at once) - main @ 6d72ca93, a clean checkout, the same run: 621 passed, 47 failed, 52 skipped in 189 s (windows, 12 at once) - failing here and not on main: none - failing on main and not here: `tests/test_longshot_ctl.py` Every other failure fails on main alike on this PC.
Author
Contributor

Linux build check, for the "builds on both" box. gpu/vk/vk_menu.cpp and gpu/vk/vk_menu_i18n.cpp, at 6c242520 and at main 6d72ca93, each compiled on its own with tools.lock's linux-x64 clang 23.1.5 and its sysroot (ubuntu22.04-gcc13-20261113), on WSL Ubuntu 24.04. Flags: nx2/build.py's renderer flags (and its Dear ImGui flags for vk_menu.cpp), plus -Wall -Wextra.

  • vk_menu_i18n.cpp: compiles with no warnings, on both.
  • vk_menu.cpp: compiles on both, with the same 6 warnings on both, so none is new from this PR. They are: deprecated arithmetic between DlssWhy and FsrWhy (2), a string-literal concatenation in an array, an unused parameter, and two unused functions. The build itself compiles with -Wno-everything.

Not a run in the game: the message on screen still needs a windowed check.

Linux build check, for the "builds on both" box. `gpu/vk/vk_menu.cpp` and `gpu/vk/vk_menu_i18n.cpp`, at 6c242520 and at main 6d72ca93, each compiled on its own with tools.lock's linux-x64 clang 23.1.5 and its sysroot (ubuntu22.04-gcc13-20261113), on WSL Ubuntu 24.04. Flags: nx2/build.py's renderer flags (and its Dear ImGui flags for vk_menu.cpp), plus `-Wall -Wextra`. - `vk_menu_i18n.cpp`: compiles with no warnings, on both. - `vk_menu.cpp`: compiles on both, with the same 6 warnings on both, so none is new from this PR. They are: deprecated arithmetic between `DlssWhy` and `FsrWhy` (2), a string-literal concatenation in an array, an unused parameter, and two unused functions. The build itself compiles with `-Wno-everything`. Not a run in the game: the message on screen still needs a windowed check.
TrashPanda approved these changes 2026-11-17 06:56:25 +00:00
TrashPanda left a comment

The help box after Save my pipeline list is built from pieces the menu already translates, so it shows in the menu's language. I read head 6c242520. It applies onto current main.

Each piece is looked up as it goes in: the saved line, the folder's words ("your home folder", "the game folder"), the report, the issue line, and the line when the zip could not be written. The zip's name, its count and a folder's own name stay as they are. The log stays in English and still does not name the home folder. Each language's count is the length of its table. The check compiles those functions with the menu's own lookup and compares 210 lines, 14 languages, with the tables' pieces. A lookup of the whole line leaves it as it was built. English is the same text as before. On Windows, an RTX 5090, the Insert menu in Portuguese and Spanish still has the same rows.

Nothing further has to be run before this merges.

The help box after Save my pipeline list is built from pieces the menu already translates, so it shows in the menu's language. I read head `6c242520`. It applies onto current main. Each piece is looked up as it goes in: the saved line, the folder's words ("your home folder", "the game folder"), the report, the issue line, and the line when the zip could not be written. The zip's name, its count and a folder's own name stay as they are. The log stays in English and still does not name the home folder. Each language's count is the length of its table. The check compiles those functions with the menu's own lookup and compares 210 lines, 14 languages, with the tables' pieces. A lookup of the whole line leaves it as it was built. English is the same text as before. On Windows, an RTX 5090, the Insert menu in Portuguese and Spanish still has the same rows. Nothing further has to be run before this merges.
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/menu-pt-br-count:dukenheimer-fix/menu-pt-br-count'
git switch 'dukenheimer-fix/menu-pt-br-count'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1318
No description provided.