fix(input): a mouse button held when one of the game's menus takes the mouse stays pressed #1257

Open
cuecuemoar wants to merge 3 commits from cuecuemoar/Longshot:fix/songbook-rmb into main
Contributor

Type: fix · Risk: low · Tested on: Windows 10, RTX 4090 · Needs: none

Why

Playing the ocarina with a mouse, the song sheet ("Check songbook") can't be read: holding the right mouse button, which is ZL by default (shield and lock-on, beside the Z key), opens the sheet and closes it again at once. The Z key works. Fixes #1130.

How to reproduce

Seen on: Windows 10 22H2, RTX 4090, NVIDIA 617.42 (the report: Windows 11, RTX 4080, v3.0.0-rc.5)
Settings and switches: defaults: ZL on Z and the right mouse button, Mouse camera on
Steps: with the mouse captured, take out the ocarina and hold the right mouse button
Expected: the song sheet stays open while the button is held, as with Z
Actual: on main it opens and closes at once

What changed

The song sheet shows only while ZL is held, and it is one of the game's own menus, which take the mouse from the camera (host/oot_menu.c). A mouse button counted as its control only while the mouse was captured, so the moment the sheet opened the held button stopped counting: the game saw ZL let go and closed the sheet. Now a press made while the mouse is captured stays its control's until the button is let go, as a key's does.

  • The mouse's buttons (host/nn_hid.c): mouse_buttons_arm keeps, beside which buttons are armed, which count (mouse_counts): down, from a press the game got. While the mouse is captured that is an armed button held, as before; when the capture ends it stays so until the button is let go, and a capture that comes back with it still held keeps the same press. bound_down reads that, and read_input reads the mouse's buttons (and the keys-only controls a mouse button can be bound to) whether or not the mouse is captured.
  • Unchanged: the click that captures the mouse still never reaches the game; a press made while the mouse is free is the menu's click (host/display.c), never the game's; with the Insert menu open nothing counts (key()); Mouse camera Off never captures, so its buttons never count.
  • The checks: tests/test_bound_keys.py (its own commit before the fix) checks the press kept after the capture ends and when it comes back, dropped when let go, a press made while free not counted, the right button as ZL, and that read_input's loop is no longer under if (captured). tests/test_input_background.py cuts the buttons' declaration by its text: updated to the new line.
  • Docs: the README's line on mouse buttons as keys ("count from a press made while the mouse is captured, until it is let go").
  • Runs: docs/tested/2026-11-16-songbook-rmb-cuecuemoar-run01.md to run03.

Measurements

Verdict: fixed: with the right mouse button held, the song sheet stays open (by hand, a real mouse); the game-free check fails on main and passes here. Nothing to measure for speed: a few integer operations per input read.

Hardware: Windows 10 Pro 22H2 (19045), RTX 4090 24 GB, NVIDIA 617.42, Core i9-13900K, 32 GB
Scene: adult Link in the Lost Woods (a copied save), the ocarina out
Method: headless through the control bridge with HOS_MENU_TRACE=1 for the cause on main and a regression run of the fix (ZL pressed by the bridge: 300 frames held, and a 6-frame tap on main); the mouse itself by hand in the fix's build, since the bridge's presses do not go through the mouse's buttons
How to reproduce: as in How to reproduce

Before: main @ e090cc48 After: this PR @ 03ea172f (the code of 480d7df8, which adds only a comment's and the README's wording)
The song sheet's screen while ZL is held 300 frames (bridge) open 312 frames, the mouse is for screen ... open 312 frames
ZL tapped 6 frames (bridge) open 18 frames: it shows only while held not run
The right mouse button held (by hand) not run by hand (the report: opens and closes at once) the sheet stays open while it is held; the cursor shows, as in any of the game's menus
tests/test_bound_keys.py (main @ 177d6b22 with the test commit 7a4014bc; this PR @ 480d7df8) FAIL PASS

Baseline: main e090cc48 is the dev_packs.py base on this PC; the fix's build is main 31f8d8be plus this change, as a pack over it. The mouse's buttons' code (mouse_buttons_arm, bound_down) is the same on e090cc48, 31f8d8be and 177d6b22.

main @ e090cc48 (HOS_MENU_TRACE=1), ZL held 300 frames, then tapped 6:
menu: screen 0x107ec85198 has a focused button (2539 frames in)
menu: the mouse is for screen 0x107ec85198
menu: screen 0x107ec85198 no longer has a focused button (2851 frames in)
menu: screen 0x107ec85198 has a focused button (1459 frames in)
menu: screen 0x107ec85198 no longer has a focused button (1477 frames in)

main @ 177d6b22 + 7a4014bc (the test alone):
AssertionError: 'if (captured)' unexpectedly found in '    if (captured)\n        for (int i = 0; i < HOS_SW_N; i++)\n            if (' : read_input reads the mouse's buttons only while the mouse is captured: a press held as the capture ends is dropped
and, past that assertion, the compiled checks on main's functions:
FAIL line 304: bound_down(HOS_SW_Y, 1)
FAIL line 306: bound_down(HOS_SW_Y, 1) && !bound_down(HOS_SW_ZL, 1)
FAIL line 308: bound_down(HOS_SW_Y, 1)
FAIL line 318: bound_down(HOS_SW_ZL, 1)

this PR @ 480d7df8:
Ran 1 test ... OK

Flags and settings

None.

Testing

Tested:

  • By hand (cuecuemoar; Windows 10 22H2, RTX 4090, a real mouse), the fix's build: the ocarina out, the right mouse button held: the song sheet stays open.
  • Headless (the control bridge), the fix's build: the song sheet open for a 300-frame ZL hold and closed after it, the game closed normally; and the cause on main, as in Measurements.
  • tests/test_bound_keys.py against broken fixes, each failing: no carry after the capture ends, the press not kept when the capture comes back, presses made while the mouse is free counted, and read_input's loop under if (captured) again.
  • The 23 checks that read host/nn_hid.c: 22 pass; test_walk_key.py fails as on main (its stand-ins no longer match scripted_input and bound_pad_buttons, three compile errors, the same on main).
  • host/nn_hid.c compiled whole for Windows in the pack's build (llvm-mingw, no warning: in its log). Linux builds the same file through host/posix/windows.h (its GetAsyncKeyState): no full Linux build was made here, but the change is plain C on key() alone, and the two checks compile mouse_buttons_arm, bound_down and the whole of read_input with gcc on Linux.
  • python -I -B tests/run_all.py on Linux (WSL, Ubuntu 22.04): 564 passed, 33 failed (32 checks), 102 skipped on this branch over a413bf1c, before the comment's and the README's wording were added to the fix commit (the checks that read the README, the two changed checks and the tested-runs check were run again after: they pass, but for main's failures). Every one of the 32 fails on main too, the WSL machine lacking clang, the Vulkan headers and some Python modules for most: 25 failed on main @ ac778751 (the full suite there), and the seven others, the menu's checks, fail on main @ a413bf1c run alone: nx2/test_nup_zstd_heads, test_bug_report_defaults, test_check_third_party, test_cpp_preflight, test_crash_record, test_crt_options, test_crt_shaders, test_damage_debug_menu, test_dlss_feature_size, test_failed_compile_keeps_objects, test_framegen_preset, test_guest_imported, test_hud_layout_row, test_lift_lookups, test_link_skip, test_linux_update, test_longshot_saves, test_make_game_cache, test_menu_i18n, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_prof_clock, test_prompt_skip, test_rumble_menu, test_run_all_changed, test_scene_tonemap_pass, test_upscaler_round_trip, test_upscaler_rows, test_vk_occlusion_queries, test_walk, test_walk_key.

Not tested:

  • Linux, in the game: the same code runs there, not run by hand with a mouse on Linux.
  • By hand on main (the bug is from the report and from the cause shown in the log); a right click inside the game's menus after this change (the code path is unchanged: WM_RBUTTONDOWN while a menu has the mouse); other controls bound to mouse buttons while a menu opens (the same rule: held until let go).
  • The Test Farm: its input goes through the bridge, not the mouse.

Must be tested:

  • None.

Risks

What could break: a mouse button held while one of the game's menus opens now stays pressed until it is let go, as a key already does: the left button (Y, attack) held into a text box, say. Before, it was let go for the game as the menu took the mouse.

Turning it off: revert the commit.

Compatibility: Nothing changes: no save, option, cache or interface is touched.

Issues

Fixes #1130

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md).
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths.
  • Docs updated.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VxeaZib8ryJL5zYJuGgxcr

**Type:** fix · **Risk:** low · **Tested on:** Windows 10, RTX 4090 · **Needs:** none ## Why Playing the ocarina with a mouse, the song sheet ("Check songbook") can't be read: holding the right mouse button, which is ZL by default (shield and lock-on, beside the Z key), opens the sheet and closes it again at once. The Z key works. Fixes #1130. ## How to reproduce **Seen on:** Windows 10 22H2, RTX 4090, NVIDIA 617.42 (the report: Windows 11, RTX 4080, v3.0.0-rc.5) **Settings and switches:** defaults: ZL on Z and the right mouse button, Mouse camera on **Steps:** with the mouse captured, take out the ocarina and hold the right mouse button **Expected:** the song sheet stays open while the button is held, as with Z **Actual:** on main it opens and closes at once ## What changed The song sheet shows only while ZL is held, and it is one of the game's own menus, which take the mouse from the camera (`host/oot_menu.c`). A mouse button counted as its control only while the mouse was captured, so the moment the sheet opened the held button stopped counting: the game saw ZL let go and closed the sheet. Now a press made while the mouse is captured stays its control's until the button is let go, as a key's does. - **The mouse's buttons** (`host/nn_hid.c`): `mouse_buttons_arm` keeps, beside which buttons are armed, which count (`mouse_counts`): down, from a press the game got. While the mouse is captured that is an armed button held, as before; when the capture ends it stays so until the button is let go, and a capture that comes back with it still held keeps the same press. `bound_down` reads that, and `read_input` reads the mouse's buttons (and the keys-only controls a mouse button can be bound to) whether or not the mouse is captured. - **Unchanged:** the click that captures the mouse still never reaches the game; a press made while the mouse is free is the menu's click (`host/display.c`), never the game's; with the Insert menu open nothing counts (`key()`); Mouse camera Off never captures, so its buttons never count. - **The checks:** `tests/test_bound_keys.py` (its own commit before the fix) checks the press kept after the capture ends and when it comes back, dropped when let go, a press made while free not counted, the right button as ZL, and that `read_input`'s loop is no longer under `if (captured)`. `tests/test_input_background.py` cuts the buttons' declaration by its text: updated to the new line. - **Docs:** the README's line on mouse buttons as keys ("count from a press made while the mouse is captured, until it is let go"). - **Runs:** `docs/tested/2026-11-16-songbook-rmb-cuecuemoar-run01.md` to `run03`. ## Measurements **Verdict:** fixed: with the right mouse button held, the song sheet stays open (by hand, a real mouse); the game-free check fails on main and passes here. Nothing to measure for speed: a few integer operations per input read. Hardware: Windows 10 Pro 22H2 (19045), RTX 4090 24 GB, NVIDIA 617.42, Core i9-13900K, 32 GB Scene: adult Link in the Lost Woods (a copied save), the ocarina out Method: headless through the control bridge with `HOS_MENU_TRACE=1` for the cause on main and a regression run of the fix (ZL pressed by the bridge: 300 frames held, and a 6-frame tap on main); the mouse itself by hand in the fix's build, since the bridge's presses do not go through the mouse's buttons How to reproduce: as in How to reproduce | | Before: main @ e090cc48 | After: this PR @ 03ea172f (the code of 480d7df8, which adds only a comment's and the README's wording) | |---|---|---| | The song sheet's screen while ZL is held 300 frames (bridge) | open 312 frames, `the mouse is for screen ...` | open 312 frames | | ZL tapped 6 frames (bridge) | open 18 frames: it shows only while held | not run | | The right mouse button held (by hand) | not run by hand (the report: opens and closes at once) | the sheet stays open while it is held; the cursor shows, as in any of the game's menus | | `tests/test_bound_keys.py` (main @ 177d6b22 with the test commit 7a4014bc; this PR @ 480d7df8) | FAIL | PASS | Baseline: main e090cc48 is the `dev_packs.py` base on this PC; the fix's build is main 31f8d8be plus this change, as a pack over it. The mouse's buttons' code (`mouse_buttons_arm`, `bound_down`) is the same on e090cc48, 31f8d8be and 177d6b22. ``` main @ e090cc48 (HOS_MENU_TRACE=1), ZL held 300 frames, then tapped 6: menu: screen 0x107ec85198 has a focused button (2539 frames in) menu: the mouse is for screen 0x107ec85198 menu: screen 0x107ec85198 no longer has a focused button (2851 frames in) menu: screen 0x107ec85198 has a focused button (1459 frames in) menu: screen 0x107ec85198 no longer has a focused button (1477 frames in) main @ 177d6b22 + 7a4014bc (the test alone): AssertionError: 'if (captured)' unexpectedly found in ' if (captured)\n for (int i = 0; i < HOS_SW_N; i++)\n if (' : read_input reads the mouse's buttons only while the mouse is captured: a press held as the capture ends is dropped and, past that assertion, the compiled checks on main's functions: FAIL line 304: bound_down(HOS_SW_Y, 1) FAIL line 306: bound_down(HOS_SW_Y, 1) && !bound_down(HOS_SW_ZL, 1) FAIL line 308: bound_down(HOS_SW_Y, 1) FAIL line 318: bound_down(HOS_SW_ZL, 1) this PR @ 480d7df8: Ran 1 test ... OK ``` ### Flags and settings None. ## Testing **Tested:** - By hand (cuecuemoar; Windows 10 22H2, RTX 4090, a real mouse), the fix's build: the ocarina out, the right mouse button held: the song sheet stays open. - Headless (the control bridge), the fix's build: the song sheet open for a 300-frame ZL hold and closed after it, the game closed normally; and the cause on main, as in Measurements. - `tests/test_bound_keys.py` against broken fixes, each failing: no carry after the capture ends, the press not kept when the capture comes back, presses made while the mouse is free counted, and `read_input`'s loop under `if (captured)` again. - The 23 checks that read `host/nn_hid.c`: 22 pass; `test_walk_key.py` fails as on main (its stand-ins no longer match `scripted_input` and `bound_pad_buttons`, three compile errors, the same on main). - `host/nn_hid.c` compiled whole for Windows in the pack's build (llvm-mingw, no `warning:` in its log). Linux builds the same file through `host/posix/windows.h` (its `GetAsyncKeyState`): no full Linux build was made here, but the change is plain C on `key()` alone, and the two checks compile `mouse_buttons_arm`, `bound_down` and the whole of `read_input` with gcc on Linux. - `python -I -B tests/run_all.py` on Linux (WSL, Ubuntu 22.04): 564 passed, 33 failed (32 checks), 102 skipped on this branch over a413bf1c, before the comment's and the README's wording were added to the fix commit (the checks that read the README, the two changed checks and the tested-runs check were run again after: they pass, but for main's failures). Every one of the 32 fails on main too, the WSL machine lacking clang, the Vulkan headers and some Python modules for most: 25 failed on main @ ac778751 (the full suite there), and the seven others, the menu's checks, fail on main @ a413bf1c run alone: `nx2/test_nup_zstd_heads`, `test_bug_report_defaults`, `test_check_third_party`, `test_cpp_preflight`, `test_crash_record`, `test_crt_options`, `test_crt_shaders`, `test_damage_debug_menu`, `test_dlss_feature_size`, `test_failed_compile_keeps_objects`, `test_framegen_preset`, `test_guest_imported`, `test_hud_layout_row`, `test_lift_lookups`, `test_link_skip`, `test_linux_update`, `test_longshot_saves`, `test_make_game_cache`, `test_menu_i18n`, `test_missing_nup`, `test_mods_size_table`, `test_pending_guest_import`, `test_prof_clock`, `test_prompt_skip`, `test_rumble_menu`, `test_run_all_changed`, `test_scene_tonemap_pass`, `test_upscaler_round_trip`, `test_upscaler_rows`, `test_vk_occlusion_queries`, `test_walk`, `test_walk_key`. **Not tested:** - Linux, in the game: the same code runs there, not run by hand with a mouse on Linux. - By hand on main (the bug is from the report and from the cause shown in the log); a right click inside the game's menus after this change (the code path is unchanged: `WM_RBUTTONDOWN` while a menu has the mouse); other controls bound to mouse buttons while a menu opens (the same rule: held until let go). - The Test Farm: its input goes through the bridge, not the mouse. **Must be tested:** - None. ## Risks **What could break:** a mouse button held while one of the game's menus opens now stays pressed until it is let go, as a key already does: the left button (Y, attack) held into a text box, say. Before, it was let go for the game as the menu took the mouse. **Turning it off:** revert the commit. **Compatibility:** Nothing changes: no save, option, cache or interface is touched. ## Issues Fixes #1130 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01VxeaZib8ryJL5zYJuGgxcr
tests/test_bound_keys.py checks that a press made while the mouse is captured stays the game's until the button is
let go, also after the capture ended and when it comes back, that a press made while the mouse is free is not the
game's, and that read_input reads the mouse's buttons whether or not the mouse is captured.

On main the press is dropped as the capture ends: the ocarina's song sheet, shown while ZL is held, takes the mouse,
so the right button (ZL) that opened it closed it again (Longshot #1130).

Assisted-by: Claude Code
Co-Authored-By: Claude Fable 5.2 <[email protected]>
Claude-Session: https://claude.ai/code/session_01VxeaZib8ryJL5zYJuGgxcr
A mouse button counted as its control only while the mouse was captured. The ocarina's song sheet shows while ZL is
held, and it is one of the game's menus that take the mouse: with ZL on the right mouse button (the default, beside
Z), the capture ended as the sheet opened, the button stopped counting, the game saw ZL let go and closed the sheet
again at once.

A press made while the mouse is captured now stays its control's until the button is let go, as a key's does, also
when the capture ends meanwhile, and when it comes back with the button still held. A press made while the mouse is
free is still that menu's click and never the game's, and the click that captures the mouse still does not reach the
game. tests/test_input_background.py cuts the buttons' new declaration.

Fixes #1130

Assisted-by: Claude Code
Co-Authored-By: Claude Fable 5.2 <[email protected]>
Claude-Session: https://claude.ai/code/session_01VxeaZib8ryJL5zYJuGgxcr
docs(tested): the ocarina's song sheet with ZL held, main and the fix, and the right mouse button by hand
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
9c29fecea1
Assisted-by: Claude Code
Co-Authored-By: Claude Fable 5.2 <[email protected]>
Claude-Session: https://claude.ai/code/session_01VxeaZib8ryJL5zYJuGgxcr
Author
Contributor

Tested in game: Windows 10 22H2, RTX 4090, NVIDIA 617.42. By hand with a mouse, the fix's build: the ocarina out in the Lost Woods, the right mouse button (ZL) held: the song sheet stays open; the cursor shows while it is open, as in any of the game's menus. Headless through the control bridge: the sheet open for a 300-frame ZL hold and closed after it; on main the menu trace shows the sheet takes the mouse and shows only while ZL is held.

Tested in game: Windows 10 22H2, RTX 4090, NVIDIA 617.42. By hand with a mouse, the fix's build: the ocarina out in the Lost Woods, the right mouse button (ZL) held: the song sheet stays open; the cursor shows while it is open, as in any of the game's menus. Headless through the control bridge: the sheet open for a 300-frame ZL hold and closed after it; on main the menu trace shows the sheet takes the mouse and shows only while ZL is held.
Author
Contributor

Description corrected: host/nn_hid.c is built on Linux too (through host/posix/windows.h), so the fix applies there; it was not run on Linux by hand. The Host code box added; the README's line named.

Description corrected: host/nn_hid.c is built on Linux too (through host/posix/windows.h), so the fix applies there; it was not run on Linux by hand. The Host code box added; the README's line named.
cuecuemoar changed title from WIP: fix(input): a mouse button held when one of the game's menus takes the mouse stays pressed to fix(input): a mouse button held when one of the game's menus takes the mouse stays pressed 2026-11-16 22:36:25 +00:00
TrashPanda approved these changes 2026-11-17 00:21:11 +00:00
Dismissed
TrashPanda left a comment

Holding the right mouse button keeps the ocarina's song sheet open. I read head 9c29fece. Approved.

A mouse button counted only while the mouse was captured. The song sheet is one of the game's menus, and opening it takes the mouse, so the held right button stopped counting as ZL and the sheet closed. mouse_counts stays set from a press made while the mouse was captured until that button comes up, including after the capture ends, and a capture that returns with it still held keeps the same press. A press that starts while the mouse is free does not count, and the click that begins a capture still does not. The Z key already reached the game from the earlier bound_down loop, which does not look at the mouse, so that key was never dropped.

The check compiles bound_down and runs the hold, the release, a press made while the mouse is free, and the right button as ZL. The hand play was on Windows 10 with an RTX 4090: the sheet stayed open and the cursor showed. Linux was not played. The measured base is older than the current main; mouse_buttons_arm is the same function on both. #1130

Holding the right mouse button keeps the ocarina's song sheet open. I read head `9c29fece`. Approved. A mouse button counted only while the mouse was captured. The song sheet is one of the game's menus, and opening it takes the mouse, so the held right button stopped counting as ZL and the sheet closed. `mouse_counts` stays set from a press made while the mouse was captured until that button comes up, including after the capture ends, and a capture that returns with it still held keeps the same press. A press that starts while the mouse is free does not count, and the click that begins a capture still does not. The Z key already reached the game from the earlier `bound_down` loop, which does not look at the mouse, so that key was never dropped. The check compiles `bound_down` and runs the hold, the release, a press made while the mouse is free, and the right button as ZL. The hand play was on Windows 10 with an RTX 4090: the sheet stayed open and the cursor showed. Linux was not played. The measured base is older than the current main; `mouse_buttons_arm` is the same function on both. https://git.magicbean.dev/MagicBeanDev/Longshot/issues/1130
cuecuemoar force-pushed fix/songbook-rmb from 9c29fecea1
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to b9a472efb0
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
2026-11-17 02:17:03 +00:00
Compare
cuecuemoar dismissed TrashPanda's review 2026-11-17 02:17:03 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/songbook-rmb:cuecuemoar-fix/songbook-rmb'
git switch 'cuecuemoar-fix/songbook-rmb'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1257
No description provided.