feat(graphics): choose the monitor used for fullscreen #1277

Merged
llun merged 11 commits from Phishinabowl/Longshot:feat/fullscreen-monitor-selector into main 2026-11-17 01:33:42 +00:00
Member

Type: feat · Risk: medium · Tested on: Windows 10, RTX 3080 (four displays); Ubuntu 26.04.1 Wayland, RTX 5090 Laptop GPU (one display); rebased native fixtures on both · Needs: Linux SDL2 multi-display retarget confirmation; other coverage limits below

Why

Players with multiple screens need to choose where Longshot enters fullscreen without changing their system's primary display. Add a saved monitor choice in the Graphics menu, with Auto preserving the current-screen behavior.

The tracker was searched for fullscreen and monitor work. No matching fullscreen monitor-selector PR was identified in the returned titles/descriptions. Related existing behavior: #176 selects a primary screen for Auto sizing before a window exists; this feature chooses the fullscreen destination. No issue is claimed fixed without a confirmed matching report.

What changed

Graphics → Screen gains a Fullscreen monitor selector. Choosing a screen while windowed sets the next fullscreen destination; choosing one while fullscreen requests an immediate move. Auto uses the current screen, and an unavailable choice is retained while a connected screen is used temporarily.

  • Host policy: host/fullscreen_monitor.c and .h publish copied metadata and queue saved identity preferences. Window operations remain on the host/window thread.
  • Windows: host/display.c targets the selected native monitor, restores saved window placement, and refreshes cursor clipping. Friendly labels come from DisplayConfigGetDeviceInfo, matched by interface path, with the monitor-driver description as fallback.
  • Linux: host/hos_sdl.c and host/posix/display_sdl.c use existing SDL2/SDL3 display enumeration and fullscreen targeting. SDL2 retargeting leaves fullscreen before positioning/re-entry, because repeated identical fullscreen flags are a no-op. Original windowed placement survives transitions and failures. SDL already supplies friendly descriptions/model names; ambiguous identities are not offered as named choices.
  • Menu/settings: gpu/vk/vk_menu.cpp, menu_i18n.h and monitor_choice.h implement translated choices, unavailable labels and identity persistence. Native-size/mode information follows the observed display, including same-size display changes.
  • Interface: gpu/vk/vk_api.h preserves perf_info, upstream main_thread_times and out_of_memory, appends monitor enumeration/selection callbacks, and bumps the host/renderer ABI from 28 to 29. Backend initializer and compiled offset/slot checks match.
  • Checks/docs: add production-cut monitor policy/menu/platform/naming fixtures, update affected source-reading fixtures, document the option and add scoped test records.
  • Guide integration: recognize the explicitly registered identity-backed monitor selector in the settings catalogue while rejecting unsupported rows; include the existing documented frame-generation/CRT visibility conditions. Add focused positive/negative regressions. Extend the UI-only helper with a settled Screen view and refresh the canonical Graphics illustration, caption and compiler-discovered provenance.

Measurements

Verdict: the Auto-monitor rendering comparison is within observed repeat variation on both hosts. No performance improvement, regression or zero-cost claim is established by these runs. Functional selection checks passed on the scoped Windows and Linux setups.

PR head c0dfffe730dddef169277794a0e5d79ac145026b is rebased onto main f88e6e3a4a403cc75a150eae31bccd624d9a4842, with ABI 29. The three conflicts in the API header, backend initializer and audio interface test are resolved. Current affected native checks ran on this exact committed source. Assistance attribution is retained. The earlier runtime and eight measurement records retain their actual source snapshots.

Record cleanup: docs/tested/ retains only the eight measured-run summaries added by this PR, as required by the contribution guide. Eleven ancillary functional, suite and rebase-history records were preserved in private evidence and removed from the diff. Their results remain summarized below. Regression tests, game code and the eight measured-run files are unchanged; this documentation cleanup required no rebuild or game interaction.

The UI-only capture support, guide images/provenance and website catalogue integration do not change the measured game code. The normal catalogue failure is caused by multiple data rows in files whose format requires one row; those upstream records are preserved.

Measurement retention after rebase: the figures below remain evidence for their original instrumented e335bd5c base, not fresh FPS measurements of current main. The ABI reconciliation preserves slot order; SDL2's correction acts only during explicit named-display transitions, outside the measured steady Auto path. No steady Auto-path work was added by that fix. New upstream profiling/VRAM code can affect absolute FPS, so no current-base rate or zero-cost claim is inferred. Per the scoped validation decision, the rebase uses affected game-free checks without another game rebuild or performance run.

Baseline: measurement builds use common Dev screenshot instrumentation in both columns: baseline 03ba344e82d77cabd2e8315cc11f416036034df4 over e335bd5c (ABI 27) and monitor topic 08b4a0a82648ce62fe76196975009fa034aab358 (ABI 28). These are instrumented comparison binaries, separate from the pure PR source. Both revisions built, passed static inspection and completed normal shader/pipeline preparation on both hosts.

Host / run Before: main @ 03ba344e (common capture) After: this PR @ 08b4a0a8 (common capture)
Windows, run 1 48.60 FPS 48.30 FPS
Windows, run 2 47.00 FPS 46.35 FPS
Windows, median of run medians 47.800 FPS 47.325 FPS
Linux, run 1 59.35 FPS 59.70 FPS
Linux, run 2 59.00 FPS 59.10 FPS
Linux, median of run medians 59.175 FPS 59.400 FPS

Repeat spreads: Windows 1.60 / 1.95 FPS, Linux 0.35 / 0.60 FPS (main / monitor). The differences, -0.99% and +0.38%, are smaller than those spreads; per-variant ranges overlap. Each measured process reports zero in-play compilations, no known compilation/error markers and a closing census. All twelve warmup/measured sessions closed normally, with no forced termination. Dev captures were acknowledged at each host's output dimensions and the hardware footer was visually reviewed. These are logged native-FPS medians, not p95/p99 frametimes or screenshot-counter readings.

Completed-run output (native-FPS intervals bounded by each recorded start/end frame; warmup and capture excluded):

Windows main-01  median_native_fps=48.60 seconds=60.010646
Windows topic-01 median_native_fps=48.30 seconds=60.018869
Windows main-02  median_native_fps=47.00 seconds=60.010960
Windows topic-02 median_native_fps=46.35 seconds=60.006069
Linux   main-01  median_native_fps=59.35 seconds=60.008806
Linux   topic-01 median_native_fps=59.70 seconds=60.020894
Linux   main-02  median_native_fps=59.00 seconds=60.004701
Linux   topic-02 median_native_fps=59.10 seconds=60.016673

Selected raw retained timed-window log lines, Windows main-01 then topic-01; all retained intervals, rather than these two examples, supply the medians:

[hos host] vk: 2640 presents, 48.5 fps; a frame: 2394 draws (0 skipped), 195 dispatches, 193 passes, 163 barriers, 6 submits, 0.0 uploads (0.0 MB), 84 ub updates (58 overlays), GPU-bound wait 0.1 ms (recording slots only); 7067 pipelines (2437 ms), 0 programs (0 failed), 1565 textures (3519 MB)
[hos host] vk: 1440 presents, 44.3 fps; a frame: 2401 draws (0 skipped), 212 dispatches, 193 passes, 164 barriers, 6 submits, 0.1 uploads (0.0 MB), 84 ub updates (58 overlays), GPU-bound wait 0.1 ms (recording slots only); 7067 pipelines (2389 ms), 0 programs (0 failed), 1590 textures (3528 MB)

Hardware: Windows 10, RTX 3080, Vulkan-reported driver 0x9b460000, Ryzen 9 5900XT, 64 GB; Ubuntu 26.04.1 Wayland, RTX 5090 Laptop GPU, recorded NVIDIA driver 595.99.02, Core Ultra 9 275HX, about 61 GB.
Scene: stationary child Kakariko, matching frozen save, position and camera. Auto monitor selects the same physical screen for both variants. Output/window 2560x1440 on Windows and 2560x1600 on Linux; SDR fullscreen, FG Off, Auto (this PC) preset, game's own upscaler, configured 100% render resolution, VSync Auto, HOS_FPS_MAX=1000 overriding the menu's console-60 cap. Actual guest render-target dimensions were not independently established; Linux screen/compositor coordinates are not the output-window dimensions. The Windows High performance and Linux balanced/AC power profiles remained unchanged.
Method: two 45-second warmups, then 60-second main/topic/main/topic samples through the native control bridge and timing job queue, using independent copied data/INIs. Fast scene readiness replaces fixed menu sleeps. Breakdown is used consistently during timing; Dev PNG capture occurs afterward, outside timing. Build/preparation durations and screenshot counter values are not the measurements.
How to reproduce: use identically instrumented main/topic packs on one base, independent prepared host-local runtimes, one frozen child-Kakariko save and the stated settings; verify matching scene/output and FG Off, warm both variants, then run two interleaved 60-second pairs. Retain frame-bounded native-FPS log intervals, zero-compilation census, scene/options and normal-shutdown receipts. For functional behavior, choose Auto or a named monitor in Graphics → Screen, enter/exit fullscreen, and choose another monitor while fullscreen.

Baseline: historical full-suite and game-build evidence used the uncommitted feature over ac778751, with full-suite controls against main 623a0ca3. Complete later suites used 17394b71. Measurements used the disclosed e335bd5c-based instrumentation, while current affected checks use clean exact f88e6e3a controls. Captions retain the actual measured/captured inputs; they are not relabeled as the current ABI-29 PR head.

Historical pre-commit functional comparison (not a current performance result):

Evidence Before: main @ 623a0ca3 (historical control) After: uncommitted monitor snapshot over ac778751
Fullscreen destination selector No named selector Four-display Windows targeting and Linux single-display selection/fullscreen confirmed
Windows naming regression Not an upstream-main control; main lacks this selector Exact pre-fix topic fails label assertion; updated topic passes 12 synthetic scenarios
Historical evidence scope Functional comparison only Current fixed-scene performance results are reported above
Windows friendly monitor name: 12 scenarios passed; identity and ownership preserved
Friendly-name helper: real Windows header syntax passed
SDL2/3 friendly UTF-8 labels, backend-qualified IDs and ambiguous-name safety passed
fullscreen monitor policy passed
fullscreen monitor Windows placement passed
fullscreen monitor SDL call order passed

Flags and settings

One visible selector and two saved settings keys are added; no new environment switch or build flag is introduced.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
Fullscreen monitor Graphics → Screen menu row Absent Auto (current monitor) by default Chooses the fullscreen destination now or on next fullscreen entry Windows four displays passed; Linux one display passed; Linux external-display targeting pending Keep Auto as the default; choose a display when wanted
fullscreen_monitor_id Opaque saved destination identity Absent Empty for Auto Retains a choice independently of list order Windows interface identity; Linux unique SDL backend-qualified name; hotplug/restart pending Save through the menu
fullscreen_monitor_name Saved display label Absent Empty for Auto Describes a saved unavailable choice; does not determine Windows targeting Friendly Windows labels passed; missing-display runtime coverage pending Save through the menu

Testing

Tested:

  • Latest rebase source c0dfffe7 on exact main f88e6e3a: 46 affected monitor/menu/audio/ABI/allocation/guide checks selected. Windows 37 pass / 7 fail, with two declared POSIX exclusions; laptop Linux 41 pass / 5 fail. All failures reproduce on exact main with matching primary diagnostics; no branch-only failure. Shared failures: test_display_startup_failure.py (profiling stand-in absent), test_framegen_preset.py, test_rumble_menu.py and test_upscaler_round_trip.py (missing frame-generation stand-in), and test_hud_layout_row.py (placing fixture). Windows additionally: test_perf_report.py (reconnect) and test_recorder_sync.py (exit fixture missing upstream vk_new.h); both pass on Linux. Controls: Windows 0 pass/7 fail, Linux 2 pass/5 fail. Source hashes remained unchanged. These are affected selections, not full suites or game builds.

  • ABI-29 compiled callback offsets/initializer order, monitor policy/platform/friendly names, audio output/recovery/Mono, mic controls and upstream renderer allocation-handler checks pass on both platforms. Longshot guide source/asset checks and the 14 screenshot regressions pass. Preprocessing adds only vk_new.h, with no removed dependency; the changed allocation/interface inputs do not alter the pictured controls. Original image/capture identities are retained; unchanged Launcher source reviews remain explicitly not checked. No game rebuild, shader preparation, launch, gameplay or fresh measurement was performed for this rebase.

  • Current rebase/fix source 0aa01320 on main 8e9cfc3a: 60 affected monitor/menu/audio/profiling checks selected. Windows 50 pass / 8 fail, with two declared POSIX exclusions; laptop Linux 53 pass / 7 fail. Every failure reproduces on exact clean main with matching primary diagnostics; no branch-only failure. Shared failures are test_display_startup_failure.py (new profiling stand-in absent), test_framegen_preset.py, test_hud_layout_row.py, test_rumble_menu.py, test_slow_frames.py (ambiguous source-cut marker), test_target_image_pool.py (old pool expectations) and test_upscaler_round_trip.py; Windows additionally test_perf_report.py (reconnect). These are affected selections, not another full-suite run.

  • ABI/header/backend slot alignment, compiled offsets, monitor policy/naming/placement, audio output and microphone fixtures pass on both hosts. Independent read-only code review found SDL2's unchanged-flags retarget no-op; the corrected regression failed before the fix and passes after it, including failed leave, failed re-entry/retry and restoration with changing observed positions. Static follow-up found no remaining concrete blocker; that is not new physical-display runtime proof.

  • Independent format review checked template structure, settings, captions, prior evidence and remaining gates. Raw retained FPS excerpts were added, stale ABI/head/conflict prose was refreshed, and unrelated data failures/backend-matrix suggestions are distinguished from actual acceptance requirements. Source/asset review and all 14 guide-image tests pass after rebase; no new capture or website layout run is claimed.

  • Full Windows and Linux native host/renderer builds, static module inspection and Most shader preparation. Paired module hashes verified; normal cache validation retained.

  • Windows: four connected monitors display Acer UT220HQL, Dell U2414H, Dell SE2426HGS and AORUS FI27Q-P. The owner confirmed correct names and fullscreen targeting. Updated naming binaries reused prepared caches; final log scan found no tagged shader/Vulkan/device-loss/display-transition errors.

  • Linux: the owner confirmed Auto/named selection and entering/exiting fullscreen on the laptop's single-display Wayland setup. Startup/preparation logs were checked; this is not multi-display evidence.

  • Monitor menu/platform fixtures passed on both hosts in the earlier suite work. New Windows naming and SDL2/3 naming fixtures pass on both hosts. The Windows helper also compiles against real Windows headers. The friendly-name regression fails on the exact pre-fix monitor source, not on upstream main.

  • Historical full suites against 623a0ca3: Windows initially 612 pass/39 fail/44 skip; Linux 646 pass/32 fail/17 skip. All failures received main controls. Selector fixture corrections passed 21 applicable Windows and 23 Linux focused reruns. An unchanged Windows portable-setup failure passed its rerun. The remaining 29 Windows and 21 Linux failures also failed on that pinned main. These older results are superseded for current game-free readiness by the complete 17394b71 runs below; older native build/runtime acceptance remains separate.

  • Test-record validation during drafting: all five new fragments pass direct format validation; the repository-fragment test passes. The 25-test documentation suite has one existing Windows ASCII-pipe CRLF/LF failure, already present in the historical main controls.

  • After replay onto 17394b71: Windows affected selection 30 pass/five failures, with two declared POSIX-only exclusions; Linux 33 pass/four failures. All applicable failures reproduce on clean matching main. Both platforms: test_framegen_preset.py, test_rumble_menu.py and test_upscaler_round_trip.py lack the frame-generation helper in their stand-ins; test_hud_layout_row.py fails its placing fixture. Windows additionally fails the same reconnect scenario in test_perf_report.py. Monitor/naming/ABI/translation/atomic-settings/core audio checks pass. These controls supersede the older failure lists for the affected checks only.

  • Subsequent full suites on 17394b71: Windows 626 pass / 37 fail / 45 skip, 433.71 s; Linux 663 pass / 28 fail / 17 skip, 374.32 s. All 37/28 failures reproduce on clean matching main. Two Tooling-discovery failures per platform pass topic/main when the existing path is supplied; the remaining 35 Windows and 26 Linux failures are named below. These are separate setup reruns, not replacement full-suite counts. No topic-only failure was found. All monitor/naming/ABI/audio/mic/translation checks passed.

  • Current affected checks after bringing in the eight commits through e335bd5c: Windows 45 pass / 5 fail, with two declared POSIX-only exclusions; Linux 48 pass / 4 fail. All applicable failures reproduce on clean e335bd5c. Shared failures: test_framegen_preset.py, test_hud_layout_row.py, test_rumble_menu.py, test_upscaler_round_trip.py; Windows additionally test_perf_report.py. These are affected selections, not another full-suite run.

  • Current measurement-only native packs: common capture main 03ba344e and monitor capture topic 08b4a0a8 both build, pass static inspection and complete Most preparation on Windows and laptop Linux. Both hosts completed two warmups and four interleaved timed samples, as detailed above. All owned sessions closed normally, every Dev capture was acknowledged, and frozen save/options inputs retained their recorded hashes. This does not establish expanded monitor edge-case runtime coverage.

Historical complete-suite remaining shared failures against main 17394b71, under tests/ (after the two successful Tooling-path reruns; current e335bd5c affected failures are named separately above):

  • Both platforms: test_bug_report_defaults.py, test_crt_options.py, test_damage_debug_menu.py, test_dlss_feature_size.py, test_failed_compile_keeps_objects.py, test_framegen_preset.py, test_fsr_uniform_ownership.py, test_guest_imported.py, test_hud_layout_row.py, test_import_reach.py, test_linux_preflight.py, test_make_game_cache.py, test_missing_nup.py, test_parallel_init_order.py, test_pending_guest_import.py, test_pipeline_play_cache.py, test_replay_write_order.py, test_rumble_menu.py, test_run_all_changed.py, test_upscaler_round_trip.py, test_upscaler_rows.py, test_vk_occlusion_queries.py, test_walk_key.py.
  • Windows additionally: test_auto_handheld.py, test_crash_dialog.py, test_fastfp_fma.py, test_fpx_sticky.py, test_job_queue.py, test_longshot_ctl.py, test_pads_after_menu.py, test_perf_report.py, test_release.py, test_spawn_emit.py, test_tested_configurations.py, test_work_lock.py.
  • Linux additionally: test_linux_update.py, test_mods_size_table.py, test_nonuniform_image_arrays.py.

Not tested: fresh game binaries/performance after the 8e9cfc3a rebase and SDL2 correction; real hotplug/reconnect, changed-choice restart persistence, mixed-DPI corner cases, and Linux multi-display/X11/independent SDL3 runtime targeting. Synthetic fixtures do not establish compositor/device behavior. These are explicit coverage limits; a complete backend matrix is not claimed or imposed as a universal policy requirement. Normal website catalogue/progress-feed failures are retained as unrelated baseline limits, not new monitor-specific repair requirements.

Must be tested:

  • Linux SDL2, multiple connected displays: select another monitor while already fullscreen, then return to windowed; repeat with a refused/removed target if available, expecting a real display move or safe refusal/retry and restoration of the original windowed placement (by hand, author or tester; this specifically confirms the corrected SDL2 transition against a real backend). No new game build or launch was included in the affected-check increment; other untested topologies remain coverage limits for review.

Screenshots and guide review

Both views render the maintained menu at 1280×720, English, Medium scale, with identical synthetic defaults and Fullscreen selected. The helper from 54d25c79 is used on both sides; no game assets, saved configuration, real monitor probe or named monitor simulation is involved. These illustrate the new row; runtime behavior is tested separately.

Before: main @ e335bd5cb3.

Before: main @ e335bd5c, Screen section

After: this PR @ 54d25c79ea.

After: this PR @ 54d25c79, Screen section

The canonical first-view Graphics guide image is independently refreshed from 54d25c79; its manifest records exact source/fixture dependencies, including monitor_choice.h, and actual compiler/SDL/libpng versions. Asset/source review passes for Longshot and all 14 screenshot regression tests pass. Unchanged Launcher source reviews are explicitly not checked. Focused website selector/visibility regressions pass (9/9); the complete Graphics test file is 17 pass/two existing baseline failures (HDR negative fixture and stale Threaded rendering restart expectation), retained unchanged.

A source-only catalogue-fixture preview of 29267466 retained 486 valid records and excluded exactly four malformed baseline fragments: shadow-map-slots on/off and dead-targets-every-present old/new. Production source guards and the actual guide/menu/README/PNG were unchanged. That private preview built 20 pages and passed six desktop/mobile light/dark states (1440, 390 and 360 px), eight native 100/125/150/200-percent zoom states, and six expanded monitor-card captures. Image hash/load, captions, overflow, keyboard full-image navigation and the actual monitor card were checked; sample screenshots were visually inspected. Owned headless browsers exited normally with no console errors or HTTP 404s. This is layout evidence, not a successful normal production build. Its npm run check remains blocked at the existing invalid progress feed before the complete Node suite runs. The original records and production guards are unchanged.

Risks

What could break: monitor topology changes, native window restoration, cursor clipping or compositor-specific fullscreen requests. Linux names are backend-qualified, not universal hardware serial numbers; renamed or indistinguishable outputs can make a saved preference unavailable.

Turning it off: choose Auto (current monitor) to restore the default targeting preference. Revert the change to remove the selector and its host callbacks.

Compatibility: saves and existing audio controls are unchanged. The new settings keys are owned by the menu. ABI 29 preserves main's version-27 main-thread timing and version-28 out-of-memory callbacks and appends the three monitor callbacks; a later game build must use matching host and renderer modules. Current native fixtures check the version, offsets and initializer slots. Existing playable installs are not replaced. The monitor feature itself does not change shader translation or invalidate caches; unrelated upstream changes can still require normal preparation. No optional SDK or third-party source is added.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure. Interleaved main/topic native-FPS results are within observed repeat variation on both hosts.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main. Pinned f88e6e3a, all three conflicts reconciled, ABI 29 preserves upstream slot order. Current affected checks and matching-main controls are recorded above; no moving-base claim beyond this pin.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named). Complete suites/controls against 17394b71 plus current e335bd5c affected selections/controls are recorded separately; all observed failures reproduce on their matching main. Overall suites are not green.
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers. Verified on pure-feature and test-record commits.
  • Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported. Two 45-second warmups and four 60-second interleaved samples per host; common instrumentation disclosed.
  • Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. README/spec and canonical fullscreen_monitor_id/name entries are present; Auto remains the default.
  • Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. Matched maintained UI-only Screen views below; actual runtime testing is separate.
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md). Eight individual measurement records are retained unchanged, each previously passing the production fragment parser. Ancillary functional/game-free history is preserved privately, with results summarized in this description.
  • MKWVK_API_VERSION bumped (gpu/vk/vk_api.h's MkwVkHost or MkwVkRenderer changed).
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. Earlier full host builds are documented at their actual e335bd5c-based instrumented revisions; current affected native fixtures pass on both, including ABI and SDL transitions. No full current-base game rebuild is claimed.
  • Docs updated. Feature spec/README/canonical settings, records, guide image/provenance and selector catalogue are updated. Rebased source retention review and 14 image tests pass; previous desktop/mobile/theme/zoom fixture-preview evidence is retained accurately. Unrelated production-data failures are disclosed.
**Type:** feat · **Risk:** medium · **Tested on:** Windows 10, RTX 3080 (four displays); Ubuntu 26.04.1 Wayland, RTX 5090 Laptop GPU (one display); rebased native fixtures on both · **Needs:** Linux SDL2 multi-display retarget confirmation; other coverage limits below ## Why Players with multiple screens need to choose where Longshot enters fullscreen without changing their system's primary display. Add a saved monitor choice in the Graphics menu, with Auto preserving the current-screen behavior. The tracker was searched for fullscreen and monitor work. No matching fullscreen monitor-selector PR was identified in the returned titles/descriptions. Related existing behavior: [#176](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/176) selects a primary screen for Auto sizing before a window exists; this feature chooses the fullscreen destination. No issue is claimed fixed without a confirmed matching report. ## What changed Graphics → Screen gains a Fullscreen monitor selector. Choosing a screen while windowed sets the next fullscreen destination; choosing one while fullscreen requests an immediate move. Auto uses the current screen, and an unavailable choice is retained while a connected screen is used temporarily. - **Host policy:** `host/fullscreen_monitor.c` and `.h` publish copied metadata and queue saved identity preferences. Window operations remain on the host/window thread. - **Windows:** `host/display.c` targets the selected native monitor, restores saved window placement, and refreshes cursor clipping. Friendly labels come from `DisplayConfigGetDeviceInfo`, matched by interface path, with the monitor-driver description as fallback. - **Linux:** `host/hos_sdl.c` and `host/posix/display_sdl.c` use existing SDL2/SDL3 display enumeration and fullscreen targeting. SDL2 retargeting leaves fullscreen before positioning/re-entry, because repeated identical fullscreen flags are a no-op. Original windowed placement survives transitions and failures. SDL already supplies friendly descriptions/model names; ambiguous identities are not offered as named choices. - **Menu/settings:** `gpu/vk/vk_menu.cpp`, `menu_i18n.h` and `monitor_choice.h` implement translated choices, unavailable labels and identity persistence. Native-size/mode information follows the observed display, including same-size display changes. - **Interface:** `gpu/vk/vk_api.h` preserves `perf_info`, upstream `main_thread_times` and `out_of_memory`, appends monitor enumeration/selection callbacks, and bumps the host/renderer ABI from 28 to 29. Backend initializer and compiled offset/slot checks match. - **Checks/docs:** add production-cut monitor policy/menu/platform/naming fixtures, update affected source-reading fixtures, document the option and add scoped test records. - **Guide integration:** recognize the explicitly registered identity-backed monitor selector in the settings catalogue while rejecting unsupported rows; include the existing documented frame-generation/CRT visibility conditions. Add focused positive/negative regressions. Extend the UI-only helper with a settled Screen view and refresh the canonical Graphics illustration, caption and compiler-discovered provenance. ## Measurements **Verdict:** the Auto-monitor rendering comparison is within observed repeat variation on both hosts. No performance improvement, regression or zero-cost claim is established by these runs. Functional selection checks passed on the scoped Windows and Linux setups. PR head `c0dfffe730dddef169277794a0e5d79ac145026b` is rebased onto main `f88e6e3a4a403cc75a150eae31bccd624d9a4842`, with ABI 29. The three conflicts in the API header, backend initializer and audio interface test are resolved. Current affected native checks ran on this exact committed source. Assistance attribution is retained. The earlier runtime and eight measurement records retain their actual source snapshots. Record cleanup: `docs/tested/` retains only the eight measured-run summaries added by this PR, as required by the contribution guide. Eleven ancillary functional, suite and rebase-history records were preserved in private evidence and removed from the diff. Their results remain summarized below. Regression tests, game code and the eight measured-run files are unchanged; this documentation cleanup required no rebuild or game interaction. The UI-only capture support, guide images/provenance and website catalogue integration do not change the measured game code. The normal catalogue failure is caused by multiple data rows in files whose format requires one row; those upstream records are preserved. **Measurement retention after rebase:** the figures below remain evidence for their original instrumented e335bd5c base, not fresh FPS measurements of current main. The ABI reconciliation preserves slot order; SDL2's correction acts only during explicit named-display transitions, outside the measured steady Auto path. No steady Auto-path work was added by that fix. New upstream profiling/VRAM code can affect absolute FPS, so no current-base rate or zero-cost claim is inferred. Per the scoped validation decision, the rebase uses affected game-free checks without another game rebuild or performance run. **Baseline:** measurement builds use common Dev screenshot instrumentation in both columns: baseline `03ba344e82d77cabd2e8315cc11f416036034df4` over e335bd5c (ABI 27) and monitor topic `08b4a0a82648ce62fe76196975009fa034aab358` (ABI 28). These are instrumented comparison binaries, separate from the pure PR source. Both revisions built, passed static inspection and completed normal shader/pipeline preparation on both hosts. | Host / run | Before: main @ 03ba344e (common capture) | After: this PR @ 08b4a0a8 (common capture) | |---|---:|---:| | Windows, run 1 | 48.60 FPS | 48.30 FPS | | Windows, run 2 | 47.00 FPS | 46.35 FPS | | Windows, median of run medians | 47.800 FPS | 47.325 FPS | | Linux, run 1 | 59.35 FPS | 59.70 FPS | | Linux, run 2 | 59.00 FPS | 59.10 FPS | | Linux, median of run medians | 59.175 FPS | 59.400 FPS | Repeat spreads: Windows 1.60 / 1.95 FPS, Linux 0.35 / 0.60 FPS (main / monitor). The differences, -0.99% and +0.38%, are smaller than those spreads; per-variant ranges overlap. Each measured process reports zero in-play compilations, no known compilation/error markers and a closing census. All twelve warmup/measured sessions closed normally, with no forced termination. Dev captures were acknowledged at each host's output dimensions and the hardware footer was visually reviewed. These are logged native-FPS medians, not p95/p99 frametimes or screenshot-counter readings. Completed-run output (native-FPS intervals bounded by each recorded start/end frame; warmup and capture excluded): ```text Windows main-01 median_native_fps=48.60 seconds=60.010646 Windows topic-01 median_native_fps=48.30 seconds=60.018869 Windows main-02 median_native_fps=47.00 seconds=60.010960 Windows topic-02 median_native_fps=46.35 seconds=60.006069 Linux main-01 median_native_fps=59.35 seconds=60.008806 Linux topic-01 median_native_fps=59.70 seconds=60.020894 Linux main-02 median_native_fps=59.00 seconds=60.004701 Linux topic-02 median_native_fps=59.10 seconds=60.016673 ``` Selected **raw retained timed-window log lines**, Windows main-01 then topic-01; all retained intervals, rather than these two examples, supply the medians: ```text [hos host] vk: 2640 presents, 48.5 fps; a frame: 2394 draws (0 skipped), 195 dispatches, 193 passes, 163 barriers, 6 submits, 0.0 uploads (0.0 MB), 84 ub updates (58 overlays), GPU-bound wait 0.1 ms (recording slots only); 7067 pipelines (2437 ms), 0 programs (0 failed), 1565 textures (3519 MB) [hos host] vk: 1440 presents, 44.3 fps; a frame: 2401 draws (0 skipped), 212 dispatches, 193 passes, 164 barriers, 6 submits, 0.1 uploads (0.0 MB), 84 ub updates (58 overlays), GPU-bound wait 0.1 ms (recording slots only); 7067 pipelines (2389 ms), 0 programs (0 failed), 1590 textures (3528 MB) ``` Hardware: Windows 10, RTX 3080, Vulkan-reported driver 0x9b460000, Ryzen 9 5900XT, 64 GB; Ubuntu 26.04.1 Wayland, RTX 5090 Laptop GPU, recorded NVIDIA driver 595.99.02, Core Ultra 9 275HX, about 61 GB. Scene: stationary child Kakariko, matching frozen save, position and camera. Auto monitor selects the same physical screen for both variants. Output/window 2560x1440 on Windows and 2560x1600 on Linux; SDR fullscreen, FG Off, Auto (this PC) preset, game's own upscaler, configured 100% render resolution, VSync Auto, HOS_FPS_MAX=1000 overriding the menu's console-60 cap. Actual guest render-target dimensions were not independently established; Linux screen/compositor coordinates are not the output-window dimensions. The Windows High performance and Linux balanced/AC power profiles remained unchanged. Method: two 45-second warmups, then 60-second main/topic/main/topic samples through the native control bridge and timing job queue, using independent copied data/INIs. Fast scene readiness replaces fixed menu sleeps. Breakdown is used consistently during timing; Dev PNG capture occurs afterward, outside timing. Build/preparation durations and screenshot counter values are not the measurements. How to reproduce: use identically instrumented main/topic packs on one base, independent prepared host-local runtimes, one frozen child-Kakariko save and the stated settings; verify matching scene/output and FG Off, warm both variants, then run two interleaved 60-second pairs. Retain frame-bounded native-FPS log intervals, zero-compilation census, scene/options and normal-shutdown receipts. For functional behavior, choose Auto or a named monitor in Graphics → Screen, enter/exit fullscreen, and choose another monitor while fullscreen. Baseline: historical full-suite and game-build evidence used the uncommitted feature over `ac778751`, with full-suite controls against main `623a0ca3`. Complete later suites used `17394b71`. Measurements used the disclosed e335bd5c-based instrumentation, while current affected checks use clean exact f88e6e3a controls. Captions retain the actual measured/captured inputs; they are not relabeled as the current ABI-29 PR head. Historical pre-commit functional comparison (not a current performance result): | Evidence | Before: main @ 623a0ca3 (historical control) | After: uncommitted monitor snapshot over ac778751 | |---|---|---| | Fullscreen destination selector | No named selector | Four-display Windows targeting and Linux single-display selection/fullscreen confirmed | | Windows naming regression | Not an upstream-main control; main lacks this selector | Exact pre-fix topic fails label assertion; updated topic passes 12 synthetic scenarios | | Historical evidence scope | Functional comparison only | Current fixed-scene performance results are reported above | ```text Windows friendly monitor name: 12 scenarios passed; identity and ownership preserved Friendly-name helper: real Windows header syntax passed SDL2/3 friendly UTF-8 labels, backend-qualified IDs and ambiguous-name safety passed fullscreen monitor policy passed fullscreen monitor Windows placement passed fullscreen monitor SDL call order passed ``` ### Flags and settings One visible selector and two saved settings keys are added; no new environment switch or build flag is introduced. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | Fullscreen monitor | Graphics → Screen menu row | Absent | Auto (current monitor) by default | Chooses the fullscreen destination now or on next fullscreen entry | Windows four displays passed; Linux one display passed; Linux external-display targeting pending | Keep Auto as the default; choose a display when wanted | | fullscreen_monitor_id | Opaque saved destination identity | Absent | Empty for Auto | Retains a choice independently of list order | Windows interface identity; Linux unique SDL backend-qualified name; hotplug/restart pending | Save through the menu | | fullscreen_monitor_name | Saved display label | Absent | Empty for Auto | Describes a saved unavailable choice; does not determine Windows targeting | Friendly Windows labels passed; missing-display runtime coverage pending | Save through the menu | ## Testing **Tested:** - Latest rebase source `c0dfffe7` on exact main `f88e6e3a`: 46 affected monitor/menu/audio/ABI/allocation/guide checks selected. Windows **37 pass / 7 fail**, with two declared POSIX exclusions; laptop Linux **41 pass / 5 fail**. All failures reproduce on exact main with matching primary diagnostics; no branch-only failure. Shared failures: `test_display_startup_failure.py` (profiling stand-in absent), `test_framegen_preset.py`, `test_rumble_menu.py` and `test_upscaler_round_trip.py` (missing frame-generation stand-in), and `test_hud_layout_row.py` (placing fixture). Windows additionally: `test_perf_report.py` (reconnect) and `test_recorder_sync.py` (exit fixture missing upstream `vk_new.h`); both pass on Linux. Controls: Windows 0 pass/7 fail, Linux 2 pass/5 fail. Source hashes remained unchanged. These are affected selections, not full suites or game builds. - ABI-29 compiled callback offsets/initializer order, monitor policy/platform/friendly names, audio output/recovery/Mono, mic controls and upstream renderer allocation-handler checks pass on both platforms. Longshot guide source/asset checks and the 14 screenshot regressions pass. Preprocessing adds only `vk_new.h`, with no removed dependency; the changed allocation/interface inputs do not alter the pictured controls. Original image/capture identities are retained; unchanged Launcher source reviews remain explicitly not checked. No game rebuild, shader preparation, launch, gameplay or fresh measurement was performed for this rebase. - Current rebase/fix source `0aa01320` on main `8e9cfc3a`: 60 affected monitor/menu/audio/profiling checks selected. Windows **50 pass / 8 fail**, with two declared POSIX exclusions; laptop Linux **53 pass / 7 fail**. Every failure reproduces on exact clean main with matching primary diagnostics; no branch-only failure. Shared failures are `test_display_startup_failure.py` (new profiling stand-in absent), `test_framegen_preset.py`, `test_hud_layout_row.py`, `test_rumble_menu.py`, `test_slow_frames.py` (ambiguous source-cut marker), `test_target_image_pool.py` (old pool expectations) and `test_upscaler_round_trip.py`; Windows additionally `test_perf_report.py` (reconnect). These are affected selections, not another full-suite run. - ABI/header/backend slot alignment, compiled offsets, monitor policy/naming/placement, audio output and microphone fixtures pass on both hosts. Independent read-only code review found SDL2's unchanged-flags retarget no-op; the corrected regression failed before the fix and passes after it, including failed leave, failed re-entry/retry and restoration with changing observed positions. Static follow-up found no remaining concrete blocker; that is not new physical-display runtime proof. - Independent format review checked template structure, settings, captions, prior evidence and remaining gates. Raw retained FPS excerpts were added, stale ABI/head/conflict prose was refreshed, and unrelated data failures/backend-matrix suggestions are distinguished from actual acceptance requirements. Source/asset review and all 14 guide-image tests pass after rebase; no new capture or website layout run is claimed. - Full Windows and Linux native host/renderer builds, static module inspection and Most shader preparation. Paired module hashes verified; normal cache validation retained. - Windows: four connected monitors display Acer UT220HQL, Dell U2414H, Dell SE2426HGS and AORUS FI27Q-P. The owner confirmed correct names and fullscreen targeting. Updated naming binaries reused prepared caches; final log scan found no tagged shader/Vulkan/device-loss/display-transition errors. - Linux: the owner confirmed Auto/named selection and entering/exiting fullscreen on the laptop's single-display Wayland setup. Startup/preparation logs were checked; this is not multi-display evidence. - Monitor menu/platform fixtures passed on both hosts in the earlier suite work. New Windows naming and SDL2/3 naming fixtures pass on both hosts. The Windows helper also compiles against real Windows headers. The friendly-name regression fails on the exact pre-fix monitor source, not on upstream main. - Historical full suites against `623a0ca3`: Windows initially 612 pass/39 fail/44 skip; Linux 646 pass/32 fail/17 skip. All failures received main controls. Selector fixture corrections passed 21 applicable Windows and 23 Linux focused reruns. An unchanged Windows portable-setup failure passed its rerun. The remaining 29 Windows and 21 Linux failures also failed on that pinned main. These older results are superseded for current game-free readiness by the complete `17394b71` runs below; older native build/runtime acceptance remains separate. - Test-record validation during drafting: all five new fragments pass direct format validation; the repository-fragment test passes. The 25-test documentation suite has one existing Windows ASCII-pipe CRLF/LF failure, already present in the historical main controls. - After replay onto `17394b71`: Windows affected selection 30 pass/five failures, with two declared POSIX-only exclusions; Linux 33 pass/four failures. All applicable failures reproduce on clean matching main. Both platforms: `test_framegen_preset.py`, `test_rumble_menu.py` and `test_upscaler_round_trip.py` lack the frame-generation helper in their stand-ins; `test_hud_layout_row.py` fails its placing fixture. Windows additionally fails the same reconnect scenario in `test_perf_report.py`. Monitor/naming/ABI/translation/atomic-settings/core audio checks pass. These controls supersede the older failure lists for the affected checks only. - Subsequent full suites on `17394b71`: Windows **626 pass / 37 fail / 45 skip**, 433.71 s; Linux **663 pass / 28 fail / 17 skip**, 374.32 s. All 37/28 failures reproduce on clean matching main. Two Tooling-discovery failures per platform pass topic/main when the existing path is supplied; the remaining 35 Windows and 26 Linux failures are named below. These are separate setup reruns, not replacement full-suite counts. No topic-only failure was found. All monitor/naming/ABI/audio/mic/translation checks passed. - Current affected checks after bringing in the eight commits through `e335bd5c`: Windows **45 pass / 5 fail**, with two declared POSIX-only exclusions; Linux **48 pass / 4 fail**. All applicable failures reproduce on clean e335bd5c. Shared failures: `test_framegen_preset.py`, `test_hud_layout_row.py`, `test_rumble_menu.py`, `test_upscaler_round_trip.py`; Windows additionally `test_perf_report.py`. These are affected selections, not another full-suite run. - Current measurement-only native packs: common capture main `03ba344e` and monitor capture topic `08b4a0a8` both build, pass static inspection and complete Most preparation on Windows and laptop Linux. Both hosts completed two warmups and four interleaved timed samples, as detailed above. All owned sessions closed normally, every Dev capture was acknowledged, and frozen save/options inputs retained their recorded hashes. This does not establish expanded monitor edge-case runtime coverage. Historical complete-suite remaining shared failures against main `17394b71`, under `tests/` (after the two successful Tooling-path reruns; current e335bd5c affected failures are named separately above): - **Both platforms:** `test_bug_report_defaults.py`, `test_crt_options.py`, `test_damage_debug_menu.py`, `test_dlss_feature_size.py`, `test_failed_compile_keeps_objects.py`, `test_framegen_preset.py`, `test_fsr_uniform_ownership.py`, `test_guest_imported.py`, `test_hud_layout_row.py`, `test_import_reach.py`, `test_linux_preflight.py`, `test_make_game_cache.py`, `test_missing_nup.py`, `test_parallel_init_order.py`, `test_pending_guest_import.py`, `test_pipeline_play_cache.py`, `test_replay_write_order.py`, `test_rumble_menu.py`, `test_run_all_changed.py`, `test_upscaler_round_trip.py`, `test_upscaler_rows.py`, `test_vk_occlusion_queries.py`, `test_walk_key.py`. - **Windows additionally:** `test_auto_handheld.py`, `test_crash_dialog.py`, `test_fastfp_fma.py`, `test_fpx_sticky.py`, `test_job_queue.py`, `test_longshot_ctl.py`, `test_pads_after_menu.py`, `test_perf_report.py`, `test_release.py`, `test_spawn_emit.py`, `test_tested_configurations.py`, `test_work_lock.py`. - **Linux additionally:** `test_linux_update.py`, `test_mods_size_table.py`, `test_nonuniform_image_arrays.py`. **Not tested:** fresh game binaries/performance after the 8e9cfc3a rebase and SDL2 correction; real hotplug/reconnect, changed-choice restart persistence, mixed-DPI corner cases, and Linux multi-display/X11/independent SDL3 runtime targeting. Synthetic fixtures do not establish compositor/device behavior. These are explicit coverage limits; a complete backend matrix is not claimed or imposed as a universal policy requirement. Normal website catalogue/progress-feed failures are retained as unrelated baseline limits, not new monitor-specific repair requirements. **Must be tested:** - Linux SDL2, multiple connected displays: select another monitor while already fullscreen, then return to windowed; repeat with a refused/removed target if available, expecting a real display move or safe refusal/retry and restoration of the original windowed placement (by hand, author or tester; this specifically confirms the corrected SDL2 transition against a real backend). No new game build or launch was included in the affected-check increment; other untested topologies remain coverage limits for review. ### Screenshots and guide review Both views render the maintained menu at 1280×720, English, Medium scale, with identical synthetic defaults and Fullscreen selected. The helper from 54d25c79 is used on both sides; no game assets, saved configuration, real monitor probe or named monitor simulation is involved. These illustrate the new row; runtime behavior is tested separately. Before: main @ e335bd5cb3f0b95cedbfa00ccc407621d333fabb. ![Before: main @ e335bd5c, Screen section](https://git.magicbean.dev/attachments/d34d184b-6b04-4e33-ba2c-63e069986989) After: this PR @ 54d25c79ead4d07e22cdcf5f07e481e19f90f78c. ![After: this PR @ 54d25c79, Screen section](https://git.magicbean.dev/attachments/15ad9938-ea48-45bf-8db7-c521b9bc0d61) The canonical first-view Graphics guide image is independently refreshed from 54d25c79; its manifest records exact source/fixture dependencies, including monitor_choice.h, and actual compiler/SDL/libpng versions. Asset/source review passes for Longshot and all 14 screenshot regression tests pass. Unchanged Launcher source reviews are explicitly not checked. Focused website selector/visibility regressions pass (9/9); the complete Graphics test file is 17 pass/two existing baseline failures (HDR negative fixture and stale Threaded rendering restart expectation), retained unchanged. A source-only **catalogue-fixture preview** of 29267466 retained 486 valid records and excluded exactly four malformed baseline fragments: shadow-map-slots on/off and dead-targets-every-present old/new. Production source guards and the actual guide/menu/README/PNG were unchanged. That private preview built 20 pages and passed six desktop/mobile light/dark states (1440, 390 and 360 px), eight native 100/125/150/200-percent zoom states, and six expanded monitor-card captures. Image hash/load, captions, overflow, keyboard full-image navigation and the actual monitor card were checked; sample screenshots were visually inspected. Owned headless browsers exited normally with no console errors or HTTP 404s. This is layout evidence, **not** a successful normal production build. Its `npm run check` remains blocked at the existing invalid progress feed before the complete Node suite runs. The original records and production guards are unchanged. ## Risks **What could break:** monitor topology changes, native window restoration, cursor clipping or compositor-specific fullscreen requests. Linux names are backend-qualified, not universal hardware serial numbers; renamed or indistinguishable outputs can make a saved preference unavailable. **Turning it off:** choose Auto (current monitor) to restore the default targeting preference. Revert the change to remove the selector and its host callbacks. **Compatibility:** saves and existing audio controls are unchanged. The new settings keys are owned by the menu. ABI 29 preserves main's version-27 main-thread timing and version-28 out-of-memory callbacks and appends the three monitor callbacks; a later game build must use matching host and renderer modules. Current native fixtures check the version, offsets and initializer slots. Existing playable installs are not replaced. The monitor feature itself does not change shader translation or invalidate caches; unrelated upstream changes can still require normal preparation. No optional SDK or third-party source is added. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. Interleaved main/topic native-FPS results are within observed repeat variation on both hosts. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. Pinned f88e6e3a, all three conflicts reconciled, ABI 29 preserves upstream slot order. Current affected checks and matching-main controls are recorded above; no moving-base claim beyond this pin. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). Complete suites/controls against 17394b71 plus current e335bd5c affected selections/controls are recorded separately; all observed failures reproduce on their matching main. Overall suites are not green. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. Verified on pure-feature and test-record commits. - [x] Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported. Two 45-second warmups and four 60-second interleaved samples per host; common instrumentation disclosed. - [x] Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. README/spec and canonical fullscreen_monitor_id/name entries are present; Auto remains the default. - [x] Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. Matched maintained UI-only Screen views below; actual runtime testing is separate. - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). Eight individual measurement records are retained unchanged, each previously passing the production fragment parser. Ancillary functional/game-free history is preserved privately, with results summarized in this description. - [x] `MKWVK_API_VERSION` bumped (`gpu/vk/vk_api.h`'s `MkwVkHost` or `MkwVkRenderer` changed). - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. Earlier full host builds are documented at their actual e335bd5c-based instrumented revisions; current affected native fixtures pass on both, including ABI and SDL transitions. No full current-base game rebuild is claimed. - [x] Docs updated. Feature spec/README/canonical settings, records, guide image/provenance and selector catalogue are updated. Rebased source retention review and 14 image tests pass; previous desktop/mobile/theme/zoom fixture-preview evidence is retained accurately. Unrelated production-data failures are disclosed.
Assisted-by: OpenAI Codex
Assisted-by: OpenAI Codex
docs(tested): record fullscreen monitor comparisons
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 7s
PR description / Description follows the template (pull_request_target) Successful in 10s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 10s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Workflow lint (actionlint) (pull_request) Successful in 12s
Third-party parts / As their notes say (pull_request) Successful in 15s
27dc5ce874
Assisted-by: OpenAI Codex
Author
Member

Tested in game: Windows 10, RTX 3080/NVIDIA 621.24: owner confirmed four friendly monitor names and correct fullscreen targeting on the earlier feature build. Ubuntu 26.04.1 Wayland, RTX 5090 Laptop/NVIDIA 595.99.02: owner confirmed single-display Auto/named selection and fullscreen entry/exit. Refreshed e335bd5c-based monitor plus common Dev capture instrumentation (08b4a0a8) ran two warmups and two measured Kakariko samples per host; no known runtime/compile error markers, normal quits, Dev captures verified. Current multi-display hotplug/restart/backend edge cases remain pending as listed; measurements are not claimed for raw upstream or pure ABI-27 binaries.

Tested in game: Windows 10, RTX 3080/NVIDIA 621.24: owner confirmed four friendly monitor names and correct fullscreen targeting on the earlier feature build. Ubuntu 26.04.1 Wayland, RTX 5090 Laptop/NVIDIA 595.99.02: owner confirmed single-display Auto/named selection and fullscreen entry/exit. Refreshed e335bd5c-based monitor plus common Dev capture instrumentation (08b4a0a8) ran two warmups and two measured Kakariko samples per host; no known runtime/compile error markers, normal quits, Dev captures verified. Current multi-display hotplug/restart/backend edge cases remain pending as listed; measurements are not claimed for raw upstream or pure ABI-27 binaries.
Assisted-by: OpenAI Codex
Assisted-by: OpenAI Codex
docs(graphics): document and illustrate fullscreen monitor selection
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
CI / Workflow lint (actionlint) (pull_request) Successful in 13s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 13s
Third-party parts / As their notes say (pull_request) Successful in 16s
PR description / Description follows the template (pull_request_target) Successful in 5s
29267466cd
Recognize the identity-backed selector in the guide catalogue, retain strict visibility metadata checks, and refresh the canonical UI-only capture and provenance.

Assisted-by: OpenAI Codex
Author
Member

Matched UI-only Screen views, rendered by the maintained menu/ImGui/Libertinus helper at 1280×720 with identical synthetic display/defaults and Fullscreen selected. No game assets, saved settings, real monitor probe or named monitor simulation is involved. These demonstrate the new visible row; runtime targeting evidence remains separate.

Before: main @ e335bd5cb3, with the committed helper from 54d25c79 for the same settled view.

Before: main @ e335bd5c, Screen section

After: this PR @ 54d25c79ea. Fullscreen monitor appears below Fullscreen and defaults to Auto (current monitor).

After: this PR @ 54d25c79, Screen section

The canonical first-view Graphics guide image, caption and compiler-discovered provenance are refreshed separately in 29267466. Asset/source review and 14 screenshot regression tests pass; unchanged Launcher source reviews are explicitly not checked. The PR remains WIP while the listed rebase/runtime/backend coverage and website-build limits are outstanding.

Matched UI-only Screen views, rendered by the maintained menu/ImGui/Libertinus helper at 1280×720 with identical synthetic display/defaults and Fullscreen selected. No game assets, saved settings, real monitor probe or named monitor simulation is involved. These demonstrate the new visible row; runtime targeting evidence remains separate. Before: main @ e335bd5cb3f0b95cedbfa00ccc407621d333fabb, with the committed helper from 54d25c79 for the same settled view. ![Before: main @ e335bd5c, Screen section](https://git.magicbean.dev/attachments/d34d184b-6b04-4e33-ba2c-63e069986989) After: this PR @ 54d25c79ead4d07e22cdcf5f07e481e19f90f78c. Fullscreen monitor appears below Fullscreen and defaults to Auto (current monitor). ![After: this PR @ 54d25c79, Screen section](https://git.magicbean.dev/attachments/15ad9938-ea48-45bf-8db7-c521b9bc0d61) The canonical first-view Graphics guide image, caption and compiler-discovered provenance are refreshed separately in 29267466. Asset/source review and 14 screenshot regression tests pass; unchanged Launcher source reviews are explicitly not checked. The PR remains WIP while the listed rebase/runtime/backend coverage and website-build limits are outstanding.
Author
Member

Added the matched source-pinned Screen screenshots to the description and refreshed the canonical Graphics image/caption/provenance. Pushed UI-only capture support and the scoped identity-backed selector catalogue integration through 29267466; no game code or measured settings changed. Longshot image/source checks and 14 screenshot tests pass; focused new guide regressions pass. The normal site build remains blocked by existing malformed multi-row catalogue entries, so an explicitly labelled isolated catalogue-fixture preview is checking layout separately. Keeping WIP for current-main reconciliation and listed runtime/backend coverage.

Added the matched source-pinned Screen screenshots to the description and refreshed the canonical Graphics image/caption/provenance. Pushed UI-only capture support and the scoped identity-backed selector catalogue integration through 29267466; no game code or measured settings changed. Longshot image/source checks and 14 screenshot tests pass; focused new guide regressions pass. The normal site build remains blocked by existing malformed multi-row catalogue entries, so an explicitly labelled isolated catalogue-fixture preview is checking layout separately. Keeping WIP for current-main reconciliation and listed runtime/backend coverage.
docs(tested): record fullscreen guide preview coverage
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 10s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 13s
PR description / Description follows the template (pull_request_target) Successful in 4s
1f287fab38
Distinguish catalogue-fixture layout checks from the existing production build and progress-feed blockers.

Assisted-by: OpenAI Codex
Author
Member

Guide review is complete within the stated limits: Longshot image/source checks and 14 screenshot tests pass; the isolated catalogue-fixture preview built 20 pages and passed six desktop/mobile/theme and eight native-zoom states, with expanded monitor-card checks. Normal production build/catalogue and progress-feed blockers are explicitly retained, not bypassed. Final documentation evidence is pushed at 1f287fab. A separate read-only live-main audit found main now at 8e9cfc3a (eight commits after our tested base), with four conflicts in the API, backend initializer and two audio/mic fixtures. Both sides independently use ABI 27, so reconciliation must preserve upstream main_thread_times after perf_info and use a fresh ABI with aligned callbacks/fixtures. No conflicts were resolved, no rebase or new game runs occurred. Keeping WIP for that reconciliation and listed runtime/backend coverage.

Guide review is complete within the stated limits: Longshot image/source checks and 14 screenshot tests pass; the isolated catalogue-fixture preview built 20 pages and passed six desktop/mobile/theme and eight native-zoom states, with expanded monitor-card checks. Normal production build/catalogue and progress-feed blockers are explicitly retained, not bypassed. Final documentation evidence is pushed at 1f287fab. A separate read-only live-main audit found main now at 8e9cfc3a (eight commits after our tested base), with four conflicts in the API, backend initializer and two audio/mic fixtures. Both sides independently use ABI 27, so reconciliation must preserve upstream main_thread_times after perf_info and use a fresh ABI with aligned callbacks/fixtures. No conflicts were resolved, no rebase or new game runs occurred. Keeping WIP for that reconciliation and listed runtime/backend coverage.
Phishinabowl force-pushed feat/fullscreen-monitor-selector from 1f287fab38
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 10s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 13s
PR description / Description follows the template (pull_request_target) Successful in 4s
to cf63f66f88
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 9s
CI / Workflow lint (actionlint) (pull_request) Successful in 14s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 14s
Third-party parts / As their notes say (pull_request) Successful in 19s
PR description / Description follows the template (pull_request_target) Successful in 6s
2026-11-17 01:03:02 +00:00
Compare
Author
Member

Rebased onto pinned main 8e9cfc3a and resolved all four conflicts. ABI 28 keeps perf_info then upstream main_thread_times before the appended monitor callbacks; initializer/compiled offsets agree. Independent read-only code review found an SDL2 already-fullscreen retarget no-op: fixed via leave/position/re-enter, with a corrected fake that fails before the fix and passes afterward, including failure/retry and changing-position restoration. Final source checks: Windows 50 pass/8 failures (2 declared POSIX exclusions); laptop Linux 53 pass/7 failures. Every failure reproduces with matching primary diagnostics on clean exact main; no branch-only failure. Independent format review is addressed: added raw retained timed FPS lines, refreshed head/ABI/conflict wording, and separated optional coverage/baseline site data limits from new gates. Guide dependencies were reprocessed/reviewed and original images retained accurately; source/asset checks and 14 image tests pass. No game rebuild, shader preparation, gameplay or new measurement run. Earlier FPS figures remain explicitly tied to the original instrumented base; the steady Auto path was not changed by the SDL2 transition fix. Pushed cf63f66f with an exact lease. The remaining Linux SDL2 multi-display runtime confirmation is named in Testing; keeping this draft status unchanged.

Rebased onto pinned main 8e9cfc3a and resolved all four conflicts. ABI 28 keeps perf_info then upstream main_thread_times before the appended monitor callbacks; initializer/compiled offsets agree. Independent read-only code review found an SDL2 already-fullscreen retarget no-op: fixed via leave/position/re-enter, with a corrected fake that fails before the fix and passes afterward, including failure/retry and changing-position restoration. Final source checks: Windows 50 pass/8 failures (2 declared POSIX exclusions); laptop Linux 53 pass/7 failures. Every failure reproduces with matching primary diagnostics on clean exact main; no branch-only failure. Independent format review is addressed: added raw retained timed FPS lines, refreshed head/ABI/conflict wording, and separated optional coverage/baseline site data limits from new gates. Guide dependencies were reprocessed/reviewed and original images retained accurately; source/asset checks and 14 image tests pass. No game rebuild, shader preparation, gameplay or new measurement run. Earlier FPS figures remain explicitly tied to the original instrumented base; the steady Auto path was not changed by the SDL2 transition fix. Pushed cf63f66f with an exact lease. The remaining Linux SDL2 multi-display runtime confirmation is named in Testing; keeping this draft status unchanged.
Phishinabowl changed title from WIP: feat(graphics): choose the monitor used for fullscreen to feat(graphics): choose the monitor used for fullscreen 2026-11-17 01:07:10 +00:00
Owner

Screenshot in the diff?

Screenshot in the diff?
docs(tested): retain only measured monitor run records
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 12s
CI / Workflow lint (actionlint) (pull_request) Successful in 32s
PR description / Description follows the template (pull_request_target) Successful in 6s
d32a662399
Move ancillary validation history to private evidence. Preserve the eight measured run summaries and all regression tests.

Assisted-by: OpenAI Codex
Author
Member

Trimmed the diff in d32a6623: moved eleven ancillary functional/suite/rebase records to private evidence, preserving their results in the description. The eight required measured-run summaries and all regression tests remain unchanged. Hash verification and git diff --check passed; no rebuild, launch or game interaction was performed.

Trimmed the diff in d32a6623: moved eleven ancillary functional/suite/rebase records to private evidence, preserving their results in the description. The eight required measured-run summaries and all regression tests remain unchanged. Hash verification and git diff --check passed; no rebuild, launch or game interaction was performed.
Author
Member

@HumanBean wrote in #1277 (comment):

Screenshot in the diff?

should be all set now on this. trimmed the diff by removing extra run testing evidence that wasn't needed but left the required ones from the contributing guide.

@HumanBean wrote in https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1277#issuecomment-39641: > Screenshot in the diff? should be all set now on this. trimmed the diff by removing extra run testing evidence that wasn't needed but left the required ones from the contributing guide.
Author
Member

Sorry one sec. Few more conflicts to fix here quick.

Sorry one sec. Few more conflicts to fix here quick.
Phishinabowl force-pushed feat/fullscreen-monitor-selector from d32a662399
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 12s
CI / Workflow lint (actionlint) (pull_request) Successful in 32s
PR description / Description follows the template (pull_request_target) Successful in 6s
to c0dfffe730
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 10s
PR description / Description follows the template (pull_request_target) Successful in 11s
CI / Workflow lint (actionlint) (pull_request) Successful in 15s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 16s
Third-party parts / As their notes say (pull_request) Successful in 22s
2026-11-17 01:32:34 +00:00
Compare
Author
Member

Rebased onto latest main f88e6e3a; resolved the three API/backend/test conflicts. ABI 29 preserves upstream out_of_memory and appends monitor callbacks, with compiled offset/initializer regression checks. Affected selection: Windows 37 pass/7 failures (two declared POSIX exclusions), Linux 41 pass/5 failures; every failure reproduces on exact main with matching primary diagnostics. No branch-only failure. Guide dependency/source review and screenshot regressions pass with original capture identities retained. Independent final main check found no further movement. No game rebuild, shader prep, launch or fresh performance run; historical runtime/measurement evidence retains its actual revisions.

Rebased onto latest main f88e6e3a; resolved the three API/backend/test conflicts. ABI 29 preserves upstream out_of_memory and appends monitor callbacks, with compiled offset/initializer regression checks. Affected selection: Windows 37 pass/7 failures (two declared POSIX exclusions), Linux 41 pass/5 failures; every failure reproduces on exact main with matching primary diagnostics. No branch-only failure. Guide dependency/source review and screenshot regressions pass with original capture identities retained. Independent final main check found no further movement. No game rebuild, shader prep, launch or fresh performance run; historical runtime/measurement evidence retains its actual revisions.
llun approved these changes 2026-11-17 01:33:36 +00:00
llun merged commit 7fd3e2acea into main 2026-11-17 01:33:42 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1277
No description provided.