fix(build): the compiler check names a folder Windows lets no program list, and never says "no message" #1238
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1238
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:fix/compiler-check-blocked-folder"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux (game-free checks) · Needs: Windows, any GPU
Why
A player couldn't check or build because the builder said "The builder's own compiler (tools/llvm-mingw) could not build a test program: no message", and pointed at their antivirus, which was already off. Their Desktop sits inside
C:\Users\<name>\Cookies, a junction Windows keeps for old programs that lets no program list it, and LLVM's clang stops as it starts there (…\clang.exe: permission denied, exit 1). That line has no "error" in it, so the check said "no message". Fixes #1010.How to reproduce
Seen on: Windows 10.0.26300, x64 (the reporter's PC), launcher nightly-100, tools nightly-358
Settings and switches: defaults
Steps: unzip the portable launcher into a folder under
C:\Users\<name>\Cookies(there, a Desktop moved into it), then check a.nupExpected: a message that says what is wrong and what to do
Actual: "could not build a test program: no message. Unpack the zip again into a folder your antivirus allows."
What changed
check_mingwnow says what stopped the compiler. Under a folder Windows lets no program list, it names that folder and says to move Longshot out of it. Otherwise it gives the compiler's first error, or its last line and exit code (an NTSTATUS in hex on Windows), never "no message".unlistable_above()andcompiler_failure()innx2/make_game.py, used bycheck_mingw()only when the test compile has already failed.tests/test_compiler_check.py, game-free: the first error, the last line with the exit code, no output, Linux, and the highest folder that denies listing.Measurements
Nothing to measure: a message in the builder's compiler check, which runs only once the test compile has failed.
Flags and settings
None
Testing
Tested: on Linux,
tests/test_compiler_check.py(5 tests, the Windows listing refusal simulated) andpython -I -B tests/run_all.py: 593 passed, 18 failed, and the same 18 fail onmain@31f8d8beon this PC (test_bug_report_defaults, test_crt_options, test_damage_debug_menu, test_dlss_feature_size, test_failed_compile_keeps_objects, test_guest_imported, test_lift_lookups, test_linux_preflight, test_linux_update, test_make_game_cache, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_run_all_changed, test_upscaler_rows, test_vk_occlusion_queries, test_walk, test_walk_key). The reporter's own run showed the cause on Windows: clang underC:\Users\<name>\Cookies\Desktop\…printedpermission deniedand exited 1.Not tested: this builder on Windows, and no run in the game: the change is only in the compiler check's failure path, which the game doesn't run.
Must be tested:
mkdir C:\LsTest\Launcher, unzip there,icacls C:\LsTest /deny "Everyone:(RD)"; undo withicacls C:\LsTest /remove:d Everyone), then check a.nup, expecting "Windows doesn't let programs look inside C:\LsTest…" (by hand: the check's message)Risks
What could break: nothing on a working PC. Both new functions run only after the test compile failed, and a listing error other than a refusal is ignored.
Turning it off: revert the commit
Compatibility: Nothing changes
Issues
Fixes #1010
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.mainand passing here.🤖 Generated with Claude Code
WIP: fix(build): the compiler check names a folder Windows lets no program list, and never says "no message"to fix(build): the compiler check names a folder Windows lets no program list, and never says "no message"