fix(windows): a launcher in a folder Windows lets no program list, such as Cookies, says to move it #154
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!154
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix/blocked-folder-1010"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
A player whose Desktop sits inside
C:\Users\<name>\Cookiescouldn't check or build: every check said "The builder's own compiler (tools/llvm-mingw) could not build a test program: no message", and the launcher told them to look at their antivirus, which they had already turned off.Cookiesis one of the junctions Windows keeps for old programs, and it lets no program list it; the build tools' clang stops at start there (…\clang.exe: permission denied, exit 1), before it compiles anything. See MagicBeanDev/Longshot#1010.What changed
Before a game-file check or a build on Windows, the launcher looks at each folder above its build tools. If one can't be listed, it doesn't run the builder and says which folder is in the way and to move Longshot's folder out of it.
Core/Disk.cs:Disk.Unlistable(path), the highest folder at or abovepaththat refuses listing (only an access refusal counts).Core/MakeGameRun.cs:MakeGameRun.Blocked(command, windows), the message (Windows only);CheckAsyncanswers with it as a CheckFailed of this PC's, without running make_game.py.App/ViewModels/BuildStepViewModel.cs: a build stops with it before make_game.py starts.Core/Problems.cs:ProblemKind.BlockedFolder, matched before Antivirus, so the build's problem screen says to move the folder, not to look at the antivirus. It also matches the builder's own words for this from MagicBeanDev/Longshot#1238.The two new texts aren't translated yet; they show in English until the catalogs are filled.
Testing
Tested:
python -I tests/test_launcher_core.py(1378 checks, with new ones for a folder underCookies, Linux, every folder listable and the builder's words) andpython -I tests/test_release.pypass on Linux; the app builds.Not tested: on Windows. The listing check is the same call clang makes fail (the reporter's PowerShell run:
C:\Users\Sanok\Cookies\Desktop\…\clang.exe: permission denied), but nobody has run this launcher from a folder underCookiesyet.Must be tested: Windows: unzip a portable launcher into
C:\LsTest\Launcher, then deny listing the folder above it asCookiesdoes (icacls C:\LsTest /deny "Everyone:(RD)"; undo withicacls C:\LsTest /remove:d Everyone), start the launcher fromC:\LsTest\Launcherand check a game file, expecting "Windows doesn't let programs look inside C:\LsTest…" instead of "could not build a test program: no message".🤖 Generated with Claude Code
Possibly related, for context:
WIP: fix(windows): a launcher in a folder Windows lets no program list, such as Cookies, says to move itto fix(windows): a launcher in a folder Windows lets no program list, such as Cookies, says to move it