WIP: fix(hle): sizes and names the game passes are checked to lie in guest memory in more host functions #1179
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1179
Loading…
Reference in a new issue
No description provided.
Delete branch "TrashPanda/Longshot:fix/hle-guest-ranges"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux, RTX 4070 Ti (game-free checks) · Needs: none
Why
Several host functions copied or read through a pointer and size the game gave them without checking they stay inside the game's memory, so a bad value could read or write the host's own memory (wrong sound, a crash in the mixer). This is the guest-memory part of #218, split out so it can be reviewed and merged on its own.
What changed
nn::audio wave buffers and coefficients,
GenerateRandomBytes, the HID state copies (at most 16 states, as the console keeps), the socket Poll stand-in, the debug log lines, the event-name copies, the item key and NVN's proc names go throughhos_guest_rangeor the newguest_name.Commits, each with its original author and message:
d2f82d90fix(hle): spans the game names are checked to lie in guest memory in more host functions (hckrman101)GP() turns a guest address into a host pointer without a check, so a
size from the game walks a copy past the guest window into the host's
own memory. nn::fs and the libc copy hooks were moved onto
hos_guest_range before; these were not:
as given, and the mixer read them for as long as the voice played
(the host's memory into the sound, or a fault in the mixer); a buffer
outside guest memory is now refused. AcquireVoiceSlot's coefficients
likewise;
the console keeps) and GetSixAxisSensorStates its states unchecked;
log from an unchecked pointer;
own bound could wrap) wrote through pointers read from game objects.
New tests/test_hle_guest_ranges.py runs wb_in_guest and checks the
functions' text; the wave-buffer and input fixtures have hos_guest_range
over their own guest memory.
Co-Authored-By: Claude Opus 5.5 [email protected]
5a0cf75ffix(nvn): read the proc names the game asks for only inside guest memory (hckrman101)nvnDeviceGetProcAddress and nvnBootstrapLoader read the name the game
passes in place, to its end: a pointer near the guest window's end, or
a name with no end, read past the guest's memory into the host's. A new
guest_name copies at most 255 characters, only from inside the window,
and gives "" when there is no string there (which asks for no proc).
tests/test_hle_guest_ranges.py checks both callers and runs guest_name.
Co-Authored-By: Claude Opus 5.5 [email protected]
62d066f0test: the oot_menu mouse fixture's stand-in hos.h has hos_guest_range (Joey Magnus)6263697btest: the biquad and teleport fixtures have a hos_guest_range over their own guest memory (Joey Magnus)Measurements
Verdict: nothing to measure: a correctness fix off the frame path, covered by game-free checks.
Flags and settings
None.
Testing
Tested: On Linux (kernel 7.0), RTX 4070 Ti,
main@71b1edd8, this PR @6263697b:tests/test_hle_guest_ranges.py,tests/test_audio_wave_buffer_release.py,tests/test_oot_menu_mouse.pypass. The full suite (tests/run_all.py) has not been run on this branch yet; a comment will follow when it has.Not tested: A play session with this build. Opened as work in progress until it runs in the game.
Must be tested:
Risks
What could break: audio, input and NVN calls if a check refused a valid span.
Turning it off: revert the commit.
Compatibility: Nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.third_party/untouched (a new folder with aPROVENANCE.mdinstead).python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).When it applies
mainand passing here.Assisted-by:/Co-Authored-By:trailers.Tested in game: Linux (Ubuntu 26.04.1, kernel 7.0.0-43), RTX 4070 Ti 12 GB, NVIDIA 595.99.02, Ryzen 7 9800X3D: this branch built together with the other 18 split from #218 and #284-#288, merged onto main @
71b1edd8(make_game.py --update, build v3.0.0-rc.5-82-g5952bb3d), then played by a scripted tour through the control bridge (scripts/memtour.py: a save loaded, Zora's Domain, the Market, Hyrule Field and Death Mountain Trail, 40 s each with walking and camera swings). All 4 stops reached, a clean quit, and no device loss or Vulkan error in the log. The HLE calls the checks guard ran through the tour (audio renderer, applet, hid) with valid ranges, and nothing was refused.Possibly related, for context:
Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.