WIP: fix(input): the native mouse camera leaves the view to the game while the mouse is released #1173
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1173
Loading…
Reference in a new issue
No description provided.
Delete branch "TrashPanda/Longshot:fix/released-mouse-camera"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux, RTX 4070 Ti (game-free checks) · Needs: any
Why
With the native mouse camera, releasing the mouse (Esc, a menu, another window) froze the camera at its last angle: the game's own camera moves, such as swinging behind Link, were undone every frame until the mouse was captured again.
Restored from Hookshot 2947, by jarynclouatre, and split out of #286 so it can be reviewed and merged on its own.
How to reproduce
Seen on: any OS
Settings and switches: native mouse camera on
Steps: release the mouse with Esc and walk with the stick or keys
Expected: the game's camera follows Link
Actual: the camera stays where the mouse left it
What changed
hos_mouse_camerainhost/mouse_native.caskshos_mouse_takefirst; with the mouse released it forgets its angles and leaves the camera to the game, and the next captured frame starts from the game's angles.Commits, each with its original author and message:
d1e04562fix(input): the native mouse camera leaves the view to the game while the mouse is released (jarynclouatre)With the native mouse camera,
hos_mouse_cameraskipped the mouse'smotion while the mouse was released (Esc, a menu open, or the window
losing focus), but it still wrote its last yaw and pitch back into the
camera every frame. The game's own camera work, such as swinging behind
Link, was undone until the mouse was captured again or the stick moved.
Change
In
host/mouse_native.c,hos_mouse_cameraaskshos_mouse_takefirst. With the mouse released it forgets its angles and leaves the
camera alone, so the next captured frame starts from the game's angles,
the same way it already does after the stick turns the camera.
Testing
tests/test_mouse_native.py, new case: with capture off the game'syaw (10) is kept, and once the mouse is captured again a turn starts
from it (11). It fails on main and passes here.
(
test_bake_portability:zstandardis not installed on this machine;it fails the same on main).
Restored-from: https://github.com/NotRexed/Hookshot/pull/2947
Measurements
Verdict: nothing to measure: a correctness fix off the frame path, covered by game-free checks.
Flags and settings
None.
Testing
Tested: On Linux (kernel 7.0), RTX 4070 Ti,
main@71b1edd8, this PR @d1e04562:tests/test_mouse_native.pypass. The full suite (tests/run_all.py) has not been run on this branch yet; a comment will follow when it has.Not tested: The game with the mouse released. Opened as work in progress until it runs in the game.
Must be tested:
Risks
What could break: the native mouse camera.
Turning it off: revert the commit.
Compatibility: Nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.third_party/untouched (a new folder with aPROVENANCE.mdinstead).python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).When it applies
mainand passing here.Tested in game: Linux (Ubuntu 26.04.1, kernel 7.0.0-43), RTX 4070 Ti 12 GB, NVIDIA 595.99.02, Ryzen 7 9800X3D: this branch built together with the other 18 split from #218 and #284-#288, merged onto main @
71b1edd8(make_game.py --update, build v3.0.0-rc.5-82-g5952bb3d), then played by a scripted tour through the control bridge (scripts/memtour.py: a save loaded, Zora's Domain, the Market, Hyrule Field and Death Mountain Trail, 40 s each with walking and camera swings). All 4 stops reached, a clean quit, and no device loss or Vulkan error in the log. Only scripted input ran; the native mouse camera with the mouse released was not tried by hand.Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.