WIP: fix(vk): Frame generation by and CRT lines shown only when they apply; Frame pacing and Threaded rendering on the Debug tab #1106
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1106
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:menu-fg-crt-debug-rows"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: not yet in the game (Linux build only) · Needs: any OS, any GPU: a look at the Insert menu
Why
The Insert menu's Graphics tab shows rows that mean nothing in the state the player has chosen, and two rows that are for
testing, not a player's choice:
only once frame generation runs (since #1041). With
Frame generation Off the row means nothing anyway.
What changed
Frame generation by shows only with Frame generation on, CRT lines only with a CRT filter on, and Frame pacing and
Threaded rendering move to the Debug tab's Developer section.
row_showningpu/vk/vk_menu.cpphidesopts.framegen_bywhileopts.framegenis 0 andopts.crt_lineswhile
opts.crt_filteris 0, as it hides HDR's levels with HDR off. The Frame pacing and Threaded rendering rows movefrom
TAB_GRAPHICStoTAB_DEBUG, after Save my pipeline list (the Quality presets still set Frame pacing; the optionsfile keys are unchanged).
test_menu_sections.py(the Graphics sections' rows),test_threaded_rendering.py(the row's tab, the READMEline),
test_damage_debug_menu.py(two more Developer rows).Measurements
Nothing to measure: which menu rows show, and on which tab.
Flags and settings
None: no option, key or switch changes; two rows change tab and two show only when they apply.
Testing
Tested: the renderer builds and links on Linux (
dev_build.py packover base02903b04;vk_menu.cppcompiled).No game-free checks were run on this PC (its owner's rule); no run in the game yet.
Not tested: the menu in the game; the updated checks.
Must be tested:
and back on, expecting it; set CRT filter Off, expecting no CRT lines row. Frame pacing and Threaded rendering are
under Debug → Developer and change as before (Threaded rendering asks for a restart) (by hand).
python -I -B tests/run_all.py(CI).Risks
What could break: the keys and the pad stepping over the rows that come and go (
row_shownis what every tab walkasks, as for HDR's rows); a launcher or bridge setting Frame generation by or CRT lines while they are hidden (the
bridge lists the rows
row_shownshows).Turning it off: revert the commit.
Compatibility: nothing changes: the options file keeps every key and value.
Issues
See #1041
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named). (not run on this PC: CI)third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.