fix(vk): Frame generation by offers DLSS FG, not Auto #1041

Merged
HumanBean merged 5 commits from pmwork-personal/Longshot:fix/fg-provider-row into main 2026-11-16 09:50:30 +00:00
Contributor

Type: fix · Risk: low · Tested on: Windows 11, game-free checks; in game: two runs each (RTX 5090) · Needs: Windows RTX 40/50 by hand; an AMD or Intel GPU; Linux with an NVIDIA GPU

Why

The Insert menu's Frame generation by row offered only Auto and Built-in FG, and Auto's text named whoever made
the last frames. The game's own menus (the title screen, the file select, movies) give NVIDIA DLSS Frame Generation no
Upscaler picture to make frames from, so the built-in one made theirs. A player who opens the Insert menu there reads
"Auto: Built-in FG" and thinks Auto chose the built-in one, with no way to choose DLSS FG: the report on Discord (an RTX
4080 Super on v3.0.0-rc.4) saw exactly that after several restarts, while the FPS counter in play said DLSS FG. Players
asked for DLSS FG as a choice of its own, in place of Auto, and for no silent fall back to the built-in one.

A second report on Discord (an RTX 5080 on nightly-287) found that the row offered DLSS FG only once play started. NGX is
asked about frame generation only by dlss_fg_frames() (at the first frame-generation set, Frame generation 2x or more)
and dlss_fg_inputs() (at the first frame with DLSS inputs, in play, whatever Frame generation is). So a player who
starts with Frame generation Off gets NGX's answer only once play starts: in that log, "DLSS Frame Gen (NGX): available,
up to 5 made frames" comes right after the first DLSS feature is made, in play, at frame 1230. With Frame generation on
from the start, main asks at the start-up screen too (in the author's run at 3x, before the title screen), but its row
still named the built-in one until DLSS-G had inputs in play. At the end of that run, of the last 600
presents 528 were made by DLSS-G and 64 by the built-in one without new inputs (the game's own menus, the case this PR
now shows as the game's frames alone).

Addresses #408: on an RTX 4090 the FPS counter changed from "DLSS FG" to the built-in one each time the game's pause or inventory menu opened, and back when it closed. DLSS-G has no Upscaler picture to make frames from there, so it cannot stay on; with this PR it no longer falls back without a word: those screens show the game's own frames, and the row and the counter say "DLSS FG paused".

Another player's log shows the same on main @ e4d035e9 (nightly-325), RTX 5060 Ti, NVIDIA 621.24, Frame generation 3x.
In play, DLSS drew 600 of each 600 frames and DLSS-G made 600 of each 600 presents, for about 4 minutes. In the pause menu,
DLSS drew nothing, and the renderer's own made 600 of each 600 presents "without new inputs (no DLSS/DLAA this frame)",
at 3x: once for about 70 s, then for the last 4.5 minutes of the log. The player read this as frame generation that works
in the menus and in play. With this PR, play does not change, and those menu screens show the game's own 60 fps.

How to reproduce

Seen on: Windows 11, RTX 4080 Super, newest driver, v3.0.0-rc.4 (a player's report); main @ 53f96d78 on Windows 11, RTX 5090
Settings and switches: Upscaler NVIDIA DLSS or DLAA, Frame generation 2x to 4x, Frame generation by at its default (Auto)
Steps: start the game; at the title screen, open the Insert menu, Graphics tab, Frame generation by. Then load a save and open it again in play.
Expected: the row names the choice, DLSS Frame Generation, which makes the frames in play, and says what happens where it cannot make them
Actual: the row reads "Auto: Built-in FG" at the title screen and "Auto: DLSS FG" in play; its only other value is Built-in FG, and the built-in one makes the title screen's frames. The log at the title screen:

vk: DLSS Frame Gen (NGX): of the last 600 presents 0 made by DLSS-G (0 told to reset, 0 with the camera still, 0 NGX said not to show); the renderer's own made the rest: 598 without new inputs (no DLSS/DLAA this frame), 1 after a gap, 0 asked more than 5 frames, 0 refused

What changed

The row is now the choice itself: DLSS FG (the default) and Built-in FG, with no Auto. DLSS FG is offered only
where it runs: NGX is asked once a run, at the start-up screen and when the menu opens, and where it cannot run the row
has Built-in FG alone and its line says why. At DLSS FG, the game's own menus, movies and loading screens now show the
game's own frames only, not the built-in one's, and the row's line and the FPS counter say "DLSS FG paused"; play is as
before.

  • menu: tx_framegen_by() in gpu/vk/vk_menu.cpp names the choice (DLSS FG or Built-in FG), not who made the last
    frames; framegen_by_fixed() and a row_fixed() clause keep the row at Built-in FG where DLSS FG cannot run (the saved
    value is kept) and at DLSS FG with RX_VK_DLSS_FG=1; hn_framegen_by() says "DLSS FG cannot run: " (DLSS's own
    reason, shared with the Upscaler row through the new dlss_why_text()), "DLSS FG paused: ..." where the sets are the
    game's alone, and "Not DLSS FG now: " when another makes the frames, every line among the variants
    measure_help() makes room for; framegen_maker_name() gives the FPS counter "DLSS FG paused". The menu's open and
    probe_upscalers_soon() call dlss_fg_probe() after dlss_probe().
  • dlss: dlss_fg_unavailable() in gpu/vk/vk_dlss.cpp says, without a lock, why DLSS-G cannot run for the rest of the
    run; dlss_fg_probe() asks NGX once under the Fg lock, as dlss_fg_frames() does; fg_start() marks answered at
    each return, so the menu never reads its "until NGX says yes" state as a no; dlss_fg_holds() is true at DLSS FG, on a
    temporal Upscaler (temporal_wanted()), where the game asked for no gameplay upscale in this frame or the two before
    (the new temporal_scene_now() in gpu/vk/vk_temporal.cpp, a frame number temporal_upscale() stamps before any
    engine runs), for a set skipped for no Upscaler picture: the game's own menus, movies and loading screens. In play the
    game asks every frame, so an Upscaler that draws nothing there (failed, refused, not this frame) leaves the sets to the
    built-in one, as before; dlss_fg_forced() tells the row
    about RX_VK_DLSS_FG=1.
  • frame generation: framegen_record() in gpu/vk/vk_framegen.cpp leaves such a set the game's frame alone (neither
    FSR 3.1's frames nor the built-in one's), noted as the new FgMaker::DlssPaused.
  • bug report: report_default() loses its "Auto" name for this row; with nothing to choose the row is never a change.
  • translations: the changed and new texts in all 13 tables of gpu/vk/menu_i18n.h.
  • README: the row's line and the bug report's defaults. scripts/screenshots/menu.cpp: stand-ins for the new calls.
  • tests: tests/test_framegen_by_row.py (new); tests/present_source_crop_test.cpp runs a held set through the real
    framegen_record(); test_bug_report_defaults.py, test_upscaler_rows.py, test_menu_keys.py and test_crt_options.py follow the code.

Measurements

Verdict: two runs each, interleaved (main, this PR, main, this PR). The title screen is as designed in both pairs: main shows about 54.6 of the game's frames a second with 2 built-in frames each, this PR the game's own alone at about 164.8 a second (V-Sync's 165 Hz), with the row and the counter as the test expects (the author's reading of the first pair: "As expected"). In play DLSS-G makes 600 of 600 frames on both builds in both pairs. The game's frame rate in play is not shown to differ: 47.0 against 47.2 in the first pair; 45.3 against 42.1 in the second, where this PR's run stood at another spot of the same map with 11% more draws a frame (3167 against 2860), so that pair's play numbers do not compare. The change acts only where DLSS-G has no Upscaler picture (the title screen, the game's menus, movies and loading); in play it changes nothing by design, and DLSS-G made all the frames in all four runs.

Measured at 6863feb4 on main 1764fed2. The PR was then rebased onto main e4d035e9 (5 commits: an audio output device row, the mouse inversion, the render thread's core, docs, CI) with no change to its own code; the numbers hold, as none of those commits touches frame generation, the Upscaler or this row, and the render thread's change acts on both columns alike. After the measurements a self-review made the pause stricter (76f1d3c8: only where the game asks for no gameplay upscale, in place of "the Upscaler did not fail for good"); for the measured title screen and play it changes nothing (the title screen asks for none; in play DLSS-G had its inputs on every set), and the game's pause screen was not measured again with it.

Hardware: Windows 11, RTX 5090, driver 621.24, Ryzen 7 9800X3D; a 5120x2160 display at 165 Hz
Scene: the title screen, then the same save in play in Market_Child; 5120x2160, Upscaler NVIDIA DLAA (preset M, 5120x2160), Frame generation 3x, Frame generation by at its default, V-Sync On, NVIDIA Reflex as set
Method: one options file for every run (the author's own); the game's frame rate from longshot_log.txt's N presents, X fps lines (the game's own frames, about every 2 seconds; the title screen's windows before play, the play windows with more than 2500 draws a frame); DLSS-G's 600-present lines; the row's text read with the control bridge (option get frame_generation_by). First pair by hand: the author's run of each build. Second pair driven by the control bridge (scripts/longshot_ctl.py): the title screen for 10 s, A until play, 60 s standing still, the game's pause screen for 5 s, quit
How to reproduce: a dev runtime of each commit on one base with the same options file and save (scripts/dev_packs.py); the second pair's route as in Method

Before: main @ 1764fed2 After: this PR @ 6863feb4 (on 1764fed2)
NGX's frame generation answer before the title screen (log line 281 and 251), as Frame generation was 3x from the start at the start-up screen (log line 108 and 145)
Frame generation by at the title screen "Auto: Built-in FG" (bridge, run 2; the author: "As expected", run 1) "DLSS FG" (bridge, run 2), its line "DLSS FG paused: ..." (the author: "As expected", run 1)
FPS counter at the title screen "Base N, Built-in FG" (the author: "As expected", run 1) "Base N, DLSS FG paused" (the author: "As expected", run 1)
The game's frame rate at the title screen, run 1 / run 2 (median) 54.5 / 54.6 (54.6); 0 of 600 by DLSS-G, the built-in one made the rest 164.8 / 164.8 (164.8); 0 of 600 by DLSS-G, no made frames
Frame generation by in play "Auto: DLSS FG" (bridge, run 2) "DLSS FG" (bridge, run 2)
DLSS-G in play 600 of 600, both runs 600 of 600, both runs
The game's frame rate in play, run 1 / run 2 (median) 47.0 (7 windows, about 17 s) / 45.3 (22 windows, 60 s still, 2860 draws a frame) (46.2) 47.2 (25 windows, about 60 s) / 42.1 (22 windows, 60 s still, another spot, 3167 draws a frame) (44.7)
The game's pause screen, run 2 not reached: PLUS came while a game event played (880 draws a frame, 52 a second) the game's own about 160 a second, 264 draws a frame, 0 to 32 of 600 by DLSS-G (DLSS FG paused)
main, title screen:     vk: 600 presents, 53.5 fps
                        vk: DLSS Frame Gen (NGX): of the last 600 presents 0 made by DLSS-G (...); the renderer's own made the rest: 598 without new inputs (no DLSS/DLAA this frame), 1 after a gap, ...
this PR, title screen:  vk: 600 presents, 164.7 fps
                        vk: DLSS Frame Gen (NGX): of the last 600 presents 0 made by DLSS-G (...); the renderer's own made the rest: 600 without new inputs (no DLSS/DLAA this frame), 0 after a gap, ...
main, in play:          vk: DLSS Frame Gen (NGX): of the last 600 presents 600 made by DLSS-G (0 told to reset, 130 with the camera still, 0 NGX said not to show); ...
this PR, in play:       vk: DLSS Frame Gen (NGX): of the last 600 presents 600 made by DLSS-G (0 told to reset, 0 with the camera still, 0 NGX said not to show); ...

(The 600-present line's "the renderer's own made the rest" is main's text; in this PR, at DLSS FG on a temporal Upscaler, those "without new inputs" sets are the game's frames alone, as the presents' rate shows.)

In the second pair this PR's run went from the title screen into play by itself, 23 s after the start, with no input from the bridge (the log shows none) and at another spot of the save's map than main's run, which needed 5 presses of A. Why is not proven: it was not the game's Skip title screen (off in this options file) and not the bridge (its first press came after play began); the intro movie stopped after 9 s where main's ran 28 s, as a button press stops it, while two controllers were connected and the game's window was in front.

Screenshots

From headless runs (HOS_HEADLESS, RX_VK_SHOT_MENU=1, the menu walked by RX_VK_MENU_SCRIPT) with the same options file: no window, so no V-Sync and no frame generation. The counter's numbers in them are not a player's, and the row's line is the choice's own, not the title screen's "DLSS FG paused" or main's "Auto: Built-in FG" (those were read on screen: Testing). The menu was opened during the game's intro.

The pictures are in this comment (two pairs, captioned like the Measurements columns, each marked headless): the row and its line, Auto | Built-in FG before and DLSS FG | Built-in FG after, and the title screen with the counter.

Flags and settings

A menu row's values and what DLSS FG does in the game's own menus change.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
Frame generation by (frame_generation_by=) who makes the frames at 2x and up Auto (0, the default: DLSS FG where it runs, else the built-in one), Built-in FG (1) DLSS FG (0, the default), Built-in FG (1); DLSS FG only where it runs, else Built-in FG alone the row names the choice and says why when it is not DLSS FG; at DLSS FG the game's own menus show the game's frames alone untested in game yet DLSS FG where it runs
RX_VK_DLSS_FG=1 DLSS-G for a run whatever the row says the row offered Built-in FG, which did nothing the row is fixed at DLSS FG and says the switch chooses the row shows what runs game-free checks for testing only, as before

Testing

Tested: game-free checks on Windows 11 (llvm-mingw): tests/test_framegen_by_row.py (fails on main, passes here), tests/test_present_source_crop.py (a held set: the game's frame alone, no FSR 3.1 or built-in passes), tests/test_bug_report_defaults.py (its two cases for this row pass; its auto-profile case, "Auto-controlled shadow_res missing", fails on main too), test_menu_i18n.py, test_dlssg_runtime.py, test_vsync_row.py, test_upscaler_rows.py, test_menu_keys.py, test_readme_menu_rows.py, test_menu_sections.py, test_framegen_preset.py; tests/run_all.py on this head (76f1d3c8, on main e4d035e9): 598 passed, 22 failed, 44 skipped; main @ e4d035e9 on the same PC: 592 passed, 27 failed, 44 skipped. Every failure here fails on main too (test_auto_handheld, test_bug_report, test_bug_report_defaults, test_crash_dialog, test_crt_options, test_finish_output, test_fsr_uniform_ownership, test_guest_imported, test_hardware_report, test_import_reach, test_linux_preflight, test_make_game_cache, test_missing_nup, test_pads_after_menu, test_parallel_init_order, test_pending_guest_import, test_portable_builder_startup, test_replay_write_order, test_run_all_changed, test_tested_configurations, test_vk_occlusion_queries, test_walk_key); main's others failed only under the full run's load. test_crt_options.py fails on main at its own kVramBudgets cut; it gets the stand-in for this PR's framegen_by_fixed() so it compiles once that is fixed. The game and the renderer build with NVIDIA DLSS on Windows (dev packs of this change on 1764fed2 (measured) and of this head on e4d035e9).

In game: two runs of main @ 1764fed2 and two of this PR @ 6863feb4, interleaved, on Windows 11, RTX 5090, driver 621.24, from one base with the same options file and save; the first pair by hand, the second driven by the control bridge (Measurements). The bridge read the row: main "Auto: Built-in FG" at the title screen and "Auto: DLSS FG" in play, this PR "DLSS FG" at the first screen, the title screen and in play. The author's reading of the title screen on both builds (the row, its line and the FPS counter, steps 0 and 1 of the test), asked "At the title screen, did the row and FPS counter show what the test file said?": "As expected". The test expects main's "Auto: Built-in FG" with "Base N, Built-in FG", and this PR's "DLSS FG" with "DLSS FG paused: ..." and "Base N, DLSS FG paused". In play, on the game's pause screen and with Built-in FG chosen (steps 2 to 5) there are no separate readings: the logs and the bridge only (Measurements). Pictures of the row and its line on each build come from headless runs (RX_VK_SHOT_MENU), without frame generation.

Not tested: play at the same spot on both builds (the second pair's runs stood at different spots); Built-in FG chosen in the menu, in a run; an AMD or Intel GPU (the row with Built-in FG alone and "DLSS FG cannot run: DLSS and DLAA: need an NVIDIA RTX GPU."); an RTX 20 or 30 (DLSS yes, frame generation no); Linux. docs/images/guide/settings-graphics.png still shows the row as "Auto | Built-in FG": its capture tool runs on Linux only (to do, see Risks).

Must be tested:

  • Windows, an RTX 40 or 50: in play, choose Built-in FG on Frame generation by, expecting the FPS counter to read Built-in FG at the multiplier, and DLSS FG again to bring "DLSS FG" back (by hand, any RTX 40 or 50)
  • Windows, an AMD or Intel GPU: open the Insert menu's Graphics tab, expecting Frame generation by to read Built-in FG with no arrows and its line "DLSS FG cannot run: DLSS and DLAA: need an NVIDIA RTX GPU." (Test Farm: @Beanstalk windows amd, read the Insert menu's Frame generation by row)
  • Linux, an NVIDIA RTX 40 or 50: build this branch, start the game, and open the Insert menu's Graphics tab at the title screen and in play, expecting Frame generation by to read DLSS FG with its arrows, its line at the title screen "DLSS FG paused: ..." with the FPS counter "DLSS FG paused", and "DLSS FG" in play (by hand: a tester with Linux, or the Test Farm: @Beanstalk linux nvidia)
  • Linux: recapture the Guide's docs/images/guide/settings-graphics.png with scripts/screenshots/capture_menu.py (Linux only), expecting the row to read "DLSS FG | Built-in FG" where it now shows "Auto | Built-in FG" (by hand: a tester with Linux)

Risks

What could break: NGX is now asked about frame generation at the start-up screen on every NVIDIA GPU DLSS runs on, also with Frame generation Off (before: at the first frame-generation set at 2x or more, or, with Frame generation Off, at the first frame with DLSS inputs in play, as in the RTX 5080 report); a driver whose NGX misbehaves on that question would meet it at the start. At DLSS FG, any frame where the game asks for no gameplay upscale (its menus, movies and loading screens, in play too) is now shown without made frames, at the game's own rate; a frame where it asks for one but the Upscaler draws nothing keeps the built-in one, as on main. The Guide's Graphics image goes stale (scripts/check_guide_screenshots.py --review-sources already asks for a review on main; this adds the fixture and vk_dlss.h).

Turning it off: RX_VK_DLSS_FG=0 (no DLSS-G for the run, and no question), Built-in FG on the row (the built-in one everywhere, as before), or revert the commit.

Compatibility: longshot_options.ini keeps its key and numbers: a 0 from before (Auto) is DLSS FG where it runs, else Built-in FG, as before; 1 stays Built-in FG. An older build reads this one's 0 as Auto. No change to saves, the caches or the vk ABI (gpu/vk/vk_api.h untouched). The changed texts were translated by the author with AI help in all 13 languages: a native speaker's look is welcome.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported. (the title screen, where the change acts; play is reported, not compared at one spot)
  • Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value.
  • Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. (headless: see their caption)
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md).
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (Windows built; Linux: a tester with Linux, Must be tested)
  • Docs updated. (the README yes; the Guide's Graphics image: a tester with Linux, Must be tested)

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Windows 11, game-free checks; in game: two runs each (RTX 5090) · **Needs:** Windows RTX 40/50 by hand; an AMD or Intel GPU; Linux with an NVIDIA GPU ## Why The Insert menu's **Frame generation by** row offered only **Auto** and **Built-in FG**, and Auto's text named whoever made the last frames. The game's own menus (the title screen, the file select, movies) give NVIDIA DLSS Frame Generation no Upscaler picture to make frames from, so the built-in one made theirs. A player who opens the Insert menu there reads "Auto: Built-in FG" and thinks Auto chose the built-in one, with no way to choose DLSS FG: the report on Discord (an RTX 4080 Super on v3.0.0-rc.4) saw exactly that after several restarts, while the FPS counter in play said DLSS FG. Players asked for DLSS FG as a choice of its own, in place of Auto, and for no silent fall back to the built-in one. A second report on Discord (an RTX 5080 on nightly-287) found that the row offered DLSS FG only once play started. NGX is asked about frame generation only by `dlss_fg_frames()` (at the first frame-generation set, Frame generation 2x or more) and `dlss_fg_inputs()` (at the first frame with DLSS inputs, in play, whatever Frame generation is). So a player who starts with Frame generation Off gets NGX's answer only once play starts: in that log, "DLSS Frame Gen (NGX): available, up to 5 made frames" comes right after the first DLSS feature is made, in play, at frame 1230. With Frame generation on from the start, main asks at the start-up screen too (in the author's run at 3x, before the title screen), but its row still named the built-in one until DLSS-G had inputs in play. At the end of that run, of the last 600 presents 528 were made by DLSS-G and 64 by the built-in one without new inputs (the game's own menus, the case this PR now shows as the game's frames alone). Addresses #408: on an RTX 4090 the FPS counter changed from "DLSS FG" to the built-in one each time the game's pause or inventory menu opened, and back when it closed. DLSS-G has no Upscaler picture to make frames from there, so it cannot stay on; with this PR it no longer falls back without a word: those screens show the game's own frames, and the row and the counter say "DLSS FG paused". Another player's log shows the same on main @ `e4d035e9` (nightly-325), RTX 5060 Ti, NVIDIA 621.24, Frame generation 3x. In play, DLSS drew 600 of each 600 frames and DLSS-G made 600 of each 600 presents, for about 4 minutes. In the pause menu, DLSS drew nothing, and the renderer's own made 600 of each 600 presents "without new inputs (no DLSS/DLAA this frame)", at 3x: once for about 70 s, then for the last 4.5 minutes of the log. The player read this as frame generation that works in the menus and in play. With this PR, play does not change, and those menu screens show the game's own 60 fps. ## How to reproduce **Seen on:** Windows 11, RTX 4080 Super, newest driver, v3.0.0-rc.4 (a player's report); main @ `53f96d78` on Windows 11, RTX 5090 **Settings and switches:** Upscaler NVIDIA DLSS or DLAA, Frame generation 2x to 4x, Frame generation by at its default (Auto) **Steps:** start the game; at the title screen, open the Insert menu, Graphics tab, Frame generation by. Then load a save and open it again in play. **Expected:** the row names the choice, DLSS Frame Generation, which makes the frames in play, and says what happens where it cannot make them **Actual:** the row reads "Auto: Built-in FG" at the title screen and "Auto: DLSS FG" in play; its only other value is Built-in FG, and the built-in one makes the title screen's frames. The log at the title screen: ``` vk: DLSS Frame Gen (NGX): of the last 600 presents 0 made by DLSS-G (0 told to reset, 0 with the camera still, 0 NGX said not to show); the renderer's own made the rest: 598 without new inputs (no DLSS/DLAA this frame), 1 after a gap, 0 asked more than 5 frames, 0 refused ``` ## What changed The row is now the choice itself: **DLSS FG** (the default) and **Built-in FG**, with no Auto. DLSS FG is offered only where it runs: NGX is asked once a run, at the start-up screen and when the menu opens, and where it cannot run the row has Built-in FG alone and its line says why. At DLSS FG, the game's own menus, movies and loading screens now show the game's own frames only, not the built-in one's, and the row's line and the FPS counter say "DLSS FG paused"; play is as before. - menu: `tx_framegen_by()` in `gpu/vk/vk_menu.cpp` names the choice (DLSS FG or Built-in FG), not who made the last frames; `framegen_by_fixed()` and a `row_fixed()` clause keep the row at Built-in FG where DLSS FG cannot run (the saved value is kept) and at DLSS FG with `RX_VK_DLSS_FG=1`; `hn_framegen_by()` says "DLSS FG cannot run: <why>" (DLSS's own reason, shared with the Upscaler row through the new `dlss_why_text()`), "DLSS FG paused: ..." where the sets are the game's alone, and "Not DLSS FG now: <why>" when another makes the frames, every line among the variants `measure_help()` makes room for; `framegen_maker_name()` gives the FPS counter "DLSS FG paused". The menu's open and `probe_upscalers_soon()` call `dlss_fg_probe()` after `dlss_probe()`. - dlss: `dlss_fg_unavailable()` in `gpu/vk/vk_dlss.cpp` says, without a lock, why DLSS-G cannot run for the rest of the run; `dlss_fg_probe()` asks NGX once under the Fg lock, as `dlss_fg_frames()` does; `fg_start()` marks `answered` at each return, so the menu never reads its "until NGX says yes" state as a no; `dlss_fg_holds()` is true at DLSS FG, on a temporal Upscaler (`temporal_wanted()`), where the game asked for no gameplay upscale in this frame or the two before (the new `temporal_scene_now()` in `gpu/vk/vk_temporal.cpp`, a frame number `temporal_upscale()` stamps before any engine runs), for a set skipped for no Upscaler picture: the game's own menus, movies and loading screens. In play the game asks every frame, so an Upscaler that draws nothing there (failed, refused, not this frame) leaves the sets to the built-in one, as before; `dlss_fg_forced()` tells the row about `RX_VK_DLSS_FG=1`. - frame generation: `framegen_record()` in `gpu/vk/vk_framegen.cpp` leaves such a set the game's frame alone (neither FSR 3.1's frames nor the built-in one's), noted as the new `FgMaker::DlssPaused`. - bug report: `report_default()` loses its "Auto" name for this row; with nothing to choose the row is never a change. - translations: the changed and new texts in all 13 tables of `gpu/vk/menu_i18n.h`. - README: the row's line and the bug report's defaults. `scripts/screenshots/menu.cpp`: stand-ins for the new calls. - tests: `tests/test_framegen_by_row.py` (new); `tests/present_source_crop_test.cpp` runs a held set through the real `framegen_record()`; `test_bug_report_defaults.py`, `test_upscaler_rows.py`, `test_menu_keys.py` and `test_crt_options.py` follow the code. ## Measurements **Verdict:** two runs each, interleaved (main, this PR, main, this PR). The title screen is as designed in both pairs: main shows about 54.6 of the game's frames a second with 2 built-in frames each, this PR the game's own alone at about 164.8 a second (V-Sync's 165 Hz), with the row and the counter as the test expects (the author's reading of the first pair: "As expected"). In play DLSS-G makes 600 of 600 frames on both builds in both pairs. The game's frame rate in play is not shown to differ: 47.0 against 47.2 in the first pair; 45.3 against 42.1 in the second, where this PR's run stood at another spot of the same map with 11% more draws a frame (3167 against 2860), so that pair's play numbers do not compare. The change acts only where DLSS-G has no Upscaler picture (the title screen, the game's menus, movies and loading); in play it changes nothing by design, and DLSS-G made all the frames in all four runs. Measured at `6863feb4` on main `1764fed2`. The PR was then rebased onto main `e4d035e9` (5 commits: an audio output device row, the mouse inversion, the render thread's core, docs, CI) with no change to its own code; the numbers hold, as none of those commits touches frame generation, the Upscaler or this row, and the render thread's change acts on both columns alike. After the measurements a self-review made the pause stricter (`76f1d3c8`: only where the game asks for no gameplay upscale, in place of "the Upscaler did not fail for good"); for the measured title screen and play it changes nothing (the title screen asks for none; in play DLSS-G had its inputs on every set), and the game's pause screen was not measured again with it. Hardware: Windows 11, RTX 5090, driver 621.24, Ryzen 7 9800X3D; a 5120x2160 display at 165 Hz Scene: the title screen, then the same save in play in Market_Child; 5120x2160, Upscaler NVIDIA DLAA (preset M, 5120x2160), Frame generation 3x, Frame generation by at its default, V-Sync On, NVIDIA Reflex as set Method: one options file for every run (the author's own); the game's frame rate from longshot_log.txt's `N presents, X fps` lines (the game's own frames, about every 2 seconds; the title screen's windows before play, the play windows with more than 2500 draws a frame); DLSS-G's 600-present lines; the row's text read with the control bridge (`option get frame_generation_by`). First pair by hand: the author's run of each build. Second pair driven by the control bridge (`scripts/longshot_ctl.py`): the title screen for 10 s, A until play, 60 s standing still, the game's pause screen for 5 s, quit How to reproduce: a dev runtime of each commit on one base with the same options file and save (scripts/dev_packs.py); the second pair's route as in Method | | Before: main @ 1764fed2 | After: this PR @ 6863feb4 (on 1764fed2) | |---|---|---| | NGX's frame generation answer | before the title screen (log line 281 and 251), as Frame generation was 3x from the start | at the start-up screen (log line 108 and 145) | | Frame generation by at the title screen | "Auto: Built-in FG" (bridge, run 2; the author: "As expected", run 1) | "DLSS FG" (bridge, run 2), its line "DLSS FG paused: ..." (the author: "As expected", run 1) | | FPS counter at the title screen | "Base N, Built-in FG" (the author: "As expected", run 1) | "Base N, DLSS FG paused" (the author: "As expected", run 1) | | The game's frame rate at the title screen, run 1 / run 2 (median) | 54.5 / 54.6 (54.6); 0 of 600 by DLSS-G, the built-in one made the rest | 164.8 / 164.8 (164.8); 0 of 600 by DLSS-G, no made frames | | Frame generation by in play | "Auto: DLSS FG" (bridge, run 2) | "DLSS FG" (bridge, run 2) | | DLSS-G in play | 600 of 600, both runs | 600 of 600, both runs | | The game's frame rate in play, run 1 / run 2 (median) | 47.0 (7 windows, about 17 s) / 45.3 (22 windows, 60 s still, 2860 draws a frame) (46.2) | 47.2 (25 windows, about 60 s) / 42.1 (22 windows, 60 s still, another spot, 3167 draws a frame) (44.7) | | The game's pause screen, run 2 | not reached: PLUS came while a game event played (880 draws a frame, 52 a second) | the game's own about 160 a second, 264 draws a frame, 0 to 32 of 600 by DLSS-G (DLSS FG paused) | ``` main, title screen: vk: 600 presents, 53.5 fps vk: DLSS Frame Gen (NGX): of the last 600 presents 0 made by DLSS-G (...); the renderer's own made the rest: 598 without new inputs (no DLSS/DLAA this frame), 1 after a gap, ... this PR, title screen: vk: 600 presents, 164.7 fps vk: DLSS Frame Gen (NGX): of the last 600 presents 0 made by DLSS-G (...); the renderer's own made the rest: 600 without new inputs (no DLSS/DLAA this frame), 0 after a gap, ... main, in play: vk: DLSS Frame Gen (NGX): of the last 600 presents 600 made by DLSS-G (0 told to reset, 130 with the camera still, 0 NGX said not to show); ... this PR, in play: vk: DLSS Frame Gen (NGX): of the last 600 presents 600 made by DLSS-G (0 told to reset, 0 with the camera still, 0 NGX said not to show); ... ``` (The 600-present line's "the renderer's own made the rest" is main's text; in this PR, at DLSS FG on a temporal Upscaler, those "without new inputs" sets are the game's frames alone, as the presents' rate shows.) In the second pair this PR's run went from the title screen into play by itself, 23 s after the start, with no input from the bridge (the log shows none) and at another spot of the save's map than main's run, which needed 5 presses of A. Why is not proven: it was not the game's Skip title screen (off in this options file) and not the bridge (its first press came after play began); the intro movie stopped after 9 s where main's ran 28 s, as a button press stops it, while two controllers were connected and the game's window was in front. ### Screenshots From headless runs (`HOS_HEADLESS`, `RX_VK_SHOT_MENU=1`, the menu walked by `RX_VK_MENU_SCRIPT`) with the same options file: no window, so no V-Sync and no frame generation. The counter's numbers in them are not a player's, and the row's line is the choice's own, not the title screen's "DLSS FG paused" or main's "Auto: Built-in FG" (those were read on screen: Testing). The menu was opened during the game's intro. The pictures are in [this comment](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1041#issuecomment-33097) (two pairs, captioned like the Measurements columns, each marked headless): the row and its line, `Auto | Built-in FG` before and `DLSS FG | Built-in FG` after, and the title screen with the counter. ### Flags and settings A menu row's values and what DLSS FG does in the game's own menus change. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | Frame generation by (`frame_generation_by=`) | who makes the frames at 2x and up | Auto (0, the default: DLSS FG where it runs, else the built-in one), Built-in FG (1) | DLSS FG (0, the default), Built-in FG (1); DLSS FG only where it runs, else Built-in FG alone | the row names the choice and says why when it is not DLSS FG; at DLSS FG the game's own menus show the game's frames alone | untested in game yet | DLSS FG where it runs | | `RX_VK_DLSS_FG=1` | DLSS-G for a run whatever the row says | the row offered Built-in FG, which did nothing | the row is fixed at DLSS FG and says the switch chooses | the row shows what runs | game-free checks | for testing only, as before | ## Testing **Tested:** game-free checks on Windows 11 (llvm-mingw): `tests/test_framegen_by_row.py` (fails on main, passes here), `tests/test_present_source_crop.py` (a held set: the game's frame alone, no FSR 3.1 or built-in passes), `tests/test_bug_report_defaults.py` (its two cases for this row pass; its auto-profile case, "Auto-controlled shadow_res missing", fails on main too), `test_menu_i18n.py`, `test_dlssg_runtime.py`, `test_vsync_row.py`, `test_upscaler_rows.py`, `test_menu_keys.py`, `test_readme_menu_rows.py`, `test_menu_sections.py`, `test_framegen_preset.py`; `tests/run_all.py` on this head (`76f1d3c8`, on main `e4d035e9`): 598 passed, 22 failed, 44 skipped; main @ `e4d035e9` on the same PC: 592 passed, 27 failed, 44 skipped. Every failure here fails on main too (test_auto_handheld, test_bug_report, test_bug_report_defaults, test_crash_dialog, test_crt_options, test_finish_output, test_fsr_uniform_ownership, test_guest_imported, test_hardware_report, test_import_reach, test_linux_preflight, test_make_game_cache, test_missing_nup, test_pads_after_menu, test_parallel_init_order, test_pending_guest_import, test_portable_builder_startup, test_replay_write_order, test_run_all_changed, test_tested_configurations, test_vk_occlusion_queries, test_walk_key); main's others failed only under the full run's load. `test_crt_options.py` fails on main at its own `kVramBudgets` cut; it gets the stand-in for this PR's `framegen_by_fixed()` so it compiles once that is fixed. The game and the renderer build with NVIDIA DLSS on Windows (dev packs of this change on `1764fed2` (measured) and of this head on `e4d035e9`). In game: two runs of main @ `1764fed2` and two of this PR @ `6863feb4`, interleaved, on Windows 11, RTX 5090, driver 621.24, from one base with the same options file and save; the first pair by hand, the second driven by the control bridge (Measurements). The bridge read the row: main "Auto: Built-in FG" at the title screen and "Auto: DLSS FG" in play, this PR "DLSS FG" at the first screen, the title screen and in play. The author's reading of the title screen on both builds (the row, its line and the FPS counter, steps 0 and 1 of the test), asked "At the title screen, did the row and FPS counter show what the test file said?": "As expected". The test expects main's "Auto: Built-in FG" with "Base N, Built-in FG", and this PR's "DLSS FG" with "DLSS FG paused: ..." and "Base N, DLSS FG paused". In play, on the game's pause screen and with Built-in FG chosen (steps 2 to 5) there are no separate readings: the logs and the bridge only (Measurements). Pictures of the row and its line on each build come from headless runs (`RX_VK_SHOT_MENU`), without frame generation. **Not tested:** play at the same spot on both builds (the second pair's runs stood at different spots); Built-in FG chosen in the menu, in a run; an AMD or Intel GPU (the row with Built-in FG alone and "DLSS FG cannot run: DLSS and DLAA: need an NVIDIA RTX GPU."); an RTX 20 or 30 (DLSS yes, frame generation no); Linux. `docs/images/guide/settings-graphics.png` still shows the row as "Auto | Built-in FG": its capture tool runs on Linux only (to do, see Risks). **Must be tested:** - Windows, an RTX 40 or 50: in play, choose Built-in FG on Frame generation by, expecting the FPS counter to read Built-in FG at the multiplier, and DLSS FG again to bring "DLSS FG" back (by hand, any RTX 40 or 50) - Windows, an AMD or Intel GPU: open the Insert menu's Graphics tab, expecting Frame generation by to read Built-in FG with no arrows and its line "DLSS FG cannot run: DLSS and DLAA: need an NVIDIA RTX GPU." (Test Farm: @Beanstalk windows amd, read the Insert menu's Frame generation by row) - Linux, an NVIDIA RTX 40 or 50: build this branch, start the game, and open the Insert menu's Graphics tab at the title screen and in play, expecting Frame generation by to read DLSS FG with its arrows, its line at the title screen "DLSS FG paused: ..." with the FPS counter "DLSS FG paused", and "DLSS FG" in play (by hand: a tester with Linux, or the Test Farm: @Beanstalk linux nvidia) - Linux: recapture the Guide's `docs/images/guide/settings-graphics.png` with `scripts/screenshots/capture_menu.py` (Linux only), expecting the row to read "DLSS FG | Built-in FG" where it now shows "Auto | Built-in FG" (by hand: a tester with Linux) ## Risks **What could break:** NGX is now asked about frame generation at the start-up screen on every NVIDIA GPU DLSS runs on, also with Frame generation Off (before: at the first frame-generation set at 2x or more, or, with Frame generation Off, at the first frame with DLSS inputs in play, as in the RTX 5080 report); a driver whose NGX misbehaves on that question would meet it at the start. At DLSS FG, any frame where the game asks for no gameplay upscale (its menus, movies and loading screens, in play too) is now shown without made frames, at the game's own rate; a frame where it asks for one but the Upscaler draws nothing keeps the built-in one, as on main. The Guide's Graphics image goes stale (`scripts/check_guide_screenshots.py --review-sources` already asks for a review on main; this adds the fixture and `vk_dlss.h`). **Turning it off:** RX_VK_DLSS_FG=0 (no DLSS-G for the run, and no question), Built-in FG on the row (the built-in one everywhere, as before), or revert the commit. **Compatibility:** longshot_options.ini keeps its key and numbers: a 0 from before (Auto) is DLSS FG where it runs, else Built-in FG, as before; 1 stays Built-in FG. An older build reads this one's 0 as Auto. No change to saves, the caches or the vk ABI (`gpu/vk/vk_api.h` untouched). The changed texts were translated by the author with AI help in all 13 languages: a native speaker's look is welcome. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported. (the title screen, where the change acts; play is reported, not compared at one spot) - [x] Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. - [x] Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. (headless: see their caption) - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [ ] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (Windows built; Linux: a tester with Linux, Must be tested) - [ ] Docs updated. (the README yes; the Guide's Graphics image: a tester with Linux, Must be tested) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The row had two values, Auto and Built-in FG. Auto's text named who made the last frames ("Auto: Built-in FG"), and
the game's own menus (the title screen, the file select, movies) give DLSS Frame Generation no Upscaler picture, so the
built-in one made their frames. A player who opened the Insert menu there read that Auto had picked the built-in one,
and DLSS FG was in none of the row's choices.

Now the row is the choice itself: DLSS FG (0, the default, the old Auto's number, so an options file from before keeps
it) and Built-in FG (1). DLSS FG is offered only where it runs: NGX is asked once a run at the start-up screen and when
the menu opens (dlss_fg_probe), and dlss_fg_unavailable says why not for the run (no NVIDIA DLSS in the build, DLSS
not running here with dlss_why's reason, RX_VK_DLSS_FG=0, NGX's no, its feature given up). There the row has Built-in FG
alone (row_fixed, the saved value kept) and its line says "DLSS FG cannot run: <why>". RX_VK_DLSS_FG=1 fixes it at DLSS
FG for the run and says so.

At DLSS FG on a temporal Upscaler, a set with no picture from it (the game's own menus, movies, loading screens) is the
game's frame alone, not FSR 3.1's or the built-in one's (dlss_fg_holds): the row's line and the FPS counter say "DLSS FG
paused". Play is as before: its sets have the Upscaler's picture, and with an Upscaler that is not temporal the built-in
one still makes the frames ("Not DLSS FG now: <why>"). The bug report no longer names an Auto default.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
An Upscaler that failed for good (temporal_failed: the game's upscale from
then on) gives DLSS-G no inputs in play either. Those sets are the built-in
one's again, as before, not the game's frame alone with "DLSS FG paused".

test_crt_options.py: a framegen_by_fixed stand-in for row_fixed's new clause.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
fix(vk): DLSS FG pauses only where the game draws no 3D scene
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
beanstalk/approval waiting for a BigBean's 👍 on the request
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
76f1d3c8b3
The earlier check, an Upscaler that failed for good (temporal_failed), missed
the states where it gives no inputs in play without failing for good: a DLSS
feature NGX refused, no DLSS mode for the render size, a frame it skipped.
At DLSS FG those sets showed the game's frame alone in play.

The test is now whether the game asked for its gameplay upscale in this frame
or the two before (temporal_scene_now, a frame number temporal_upscale stamps
before any engine runs). The game's own menus, movies and loading screens ask
for none: their sets stay the game's frames alone ("DLSS FG paused"). In play
the game asks every frame, so an Upscaler that draws nothing leaves the sets
to the built-in frame generation, as on main.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

Tested in game: Windows 11, RTX 5090, NVIDIA 621.24, 5120x2160 at 165 Hz, DLAA, Frame generation 3x, V-Sync On: dev runtimes of main 1764fed2 and of this PR at 6863feb4 on one base, two runs each (by hand and through the control bridge). Title screen: Frame generation by reads DLSS FG with its line 'DLSS FG paused: ...', the FPS counter 'DLSS FG paused', the game's own frames only (about 165 a second, none made); main reads 'Auto: Built-in FG'. In play DLSS-G made 600 of 600 frames on both. The stricter pause check of 76f1d3c8 was built and checked game-free, not yet run in the game.

Tested in game: Windows 11, RTX 5090, NVIDIA 621.24, 5120x2160 at 165 Hz, DLAA, Frame generation 3x, V-Sync On: dev runtimes of main 1764fed2 and of this PR at 6863feb4 on one base, two runs each (by hand and through the control bridge). Title screen: Frame generation by reads DLSS FG with its line 'DLSS FG paused: ...', the FPS counter 'DLSS FG paused', the game's own frames only (about 165 a second, none made); main reads 'Auto: Built-in FG'. In play DLSS-G made 600 of 600 frames on both. The stricter pause check of 76f1d3c8 was built and checked game-free, not yet run in the game.
Author
Contributor

Screenshots for the description's Screenshots section, from headless runs (HOS_HEADLESS, RX_VK_SHOT_MENU=1, the Insert menu walked by RX_VK_MENU_SCRIPT) with the same options file as the measured runs.

Headless means no window, so no V-Sync and no frame generation: the FPS counter's numbers here are not a player's and name no frame maker, and the row's line is the choice's own, not the title screen's "DLSS FG paused" or main's "Auto: Built-in FG" (those were read on screen in a window: see Testing). The menu was opened during the game's intro.

Frame generation by, selected, with its line

Before: main @ 1764fed2 (headless) After: this PR @ 6863feb4 (headless)
Before: main @ 1764fed2, Frame generation by: Auto | Built-in FG After: this PR @ 6863feb4, Frame generation by: DLSS FG | Built-in FG

The title screen and the FPS counter

Before: main @ 1764fed2 (headless) After: this PR @ 6863feb4 (headless)
Before: main @ 1764fed2, the title screen and the FPS counter After: this PR @ 6863feb4, the title screen and the FPS counter
Screenshots for the description's Screenshots section, from headless runs (`HOS_HEADLESS`, `RX_VK_SHOT_MENU=1`, the Insert menu walked by `RX_VK_MENU_SCRIPT`) with the same options file as the measured runs. Headless means no window, so no V-Sync and no frame generation: the FPS counter's numbers here are not a player's and name no frame maker, and the row's line is the choice's own, not the title screen's "DLSS FG paused" or main's "Auto: Built-in FG" (those were read on screen in a window: see Testing). The menu was opened during the game's intro. **Frame generation by**, selected, with its line | Before: main @ 1764fed2 (headless) | After: this PR @ 6863feb4 (headless) | |---|---| | ![Before: main @ 1764fed2, Frame generation by: Auto \| Built-in FG](https://git.magicbean.dev/attachments/b3b33bd5-bdb0-4959-8e50-dcb5f57a41ef) | ![After: this PR @ 6863feb4, Frame generation by: DLSS FG \| Built-in FG](https://git.magicbean.dev/attachments/25a01199-0dde-432a-9a9e-e26485daedc5) | **The title screen and the FPS counter** | Before: main @ 1764fed2 (headless) | After: this PR @ 6863feb4 (headless) | |---|---| | ![Before: main @ 1764fed2, the title screen and the FPS counter](https://git.magicbean.dev/attachments/f6cbe203-1ec5-4f3d-9546-13054ae8ffaf) | ![After: this PR @ 6863feb4, the title screen and the FPS counter](https://git.magicbean.dev/attachments/8cc98bb3-8073-4f8a-907f-6f0c53af7a58) |
Collaborator

Possibly related, for context:

  • issue #408 Game: OTT — DLSS FG falling back to built-in in game menus
Possibly related, for context: - issue #408 Game: OTT — DLSS FG falling back to built-in in game menus
Author
Contributor

@Beanstalk Linux with an NVIDIA RTX 40 or 50 (DLSS Frame Generation): build this PR's branch and start the game with Upscaler NVIDIA DLSS or DLAA, Frame generation 2x or more, Frame generation by at its default, and the FPS counter on.

  1. At the title screen, before loading a save, open the Insert menu's Graphics tab: Frame generation by should read "DLSS FG" with its arrows, its line "DLSS FG paused: the game's own menus, movies and loading screens ...", and the FPS counter "Base N, DLSS FG paused".
  2. Load a save and play for about a minute: the FPS counter should read "Base N, DLSS FG", and the row's line "NVIDIA DLSS Frame Generation (RTX 40 and newer), made from the Upscaler's depth and motion."
    Please report the GPU, driver and distribution, a screenshot of the row at the title screen and one in play, and the log's "DLSS Frame Gen (NGX)" lines.
@Beanstalk Linux with an NVIDIA RTX 40 or 50 (DLSS Frame Generation): build this PR's branch and start the game with Upscaler NVIDIA DLSS or DLAA, Frame generation 2x or more, Frame generation by at its default, and the FPS counter on. 1. At the title screen, before loading a save, open the Insert menu's Graphics tab: Frame generation by should read "DLSS FG" with its arrows, its line "DLSS FG paused: the game's own menus, movies and loading screens ...", and the FPS counter "Base N, DLSS FG paused". 2. Load a save and play for about a minute: the FPS counter should read "Base N, DLSS FG", and the row's line "NVIDIA DLSS Frame Generation (RTX 40 and newer), made from the Upscaler's depth and motion." Please report the GPU, driver and distribution, a screenshot of the row at the title screen and one in play, and the log's "DLSS Frame Gen (NGX)" lines.
Member

@pmwork-personal only members of BigBeans can start the farm.

One of them can approve this request by reacting 👍 to it. This request was for 76f1d3c, and the PR has changed since (6c52fe5), so a 👍 no longer approves it. Comment @Beanstalk again to ask for the new commit.

@pmwork-personal only members of `BigBeans` can start the farm. ~~One of them can approve this request by reacting 👍 to it.~~ This request was for `76f1d3c`, and the PR has changed since (`6c52fe5`), so a 👍 no longer approves it. Comment `@Beanstalk` again to ask for the new commit.
HumanBean left a comment

Code review only (read at 76f1d3c8; nothing built or run here). The change does what Why and What changed say. The menu, the probe, the pause and the bug report's defaults read right. The lock order is new but consistent: menu_tick now takes g.mu under present_image_mu, and I found no path that takes g.mu or dev.present_mu first and then present_image_mu. The live line's buffers are sized for every variant. All 13 tables keep %s in the new texts.

Blocking

  • tests/test_framegen_by_row.py has a brace counter of its own (block(), line 44). AGENTS.md says a new check cuts with tests/srccut.py (block, between). That one names the source and marker when a marker is missing or appears twice, and here several markers would silently cut the wrong span if they appeared twice. Please move the check to srccut.block (and found where it cuts by regex).

Suggestions

  • dlss_fg_close() (vk_dlss.cpp:1161) returns at !fg_asked(), which the probe now reaches often. Before this PR, g.params was allocated only once DLSS-G was asked for. Now dlss_fg_probe() allocates it at the start-up screen on every NVIDIA GPU where DLSS-G is available, also with Built-in FG chosen or Frame generation Off. A player at Built-in FG then exits with g.params never destroyed and g.closed never set. A start-up probe still running at a fast exit is then not stopped by closed. Dropping that early return, or closing whenever g.params || g.feature, would cover both.
  • The menus now show 1x, a change every NVIDIA player at the default will see. At DLSS FG the title screen, the game's menus, movies and loading screens show the game's own frames only (60 in place of 180 at 3x). The PR means this, and it answers #408. But it is a visible change for everyone at the default, not only a text fix, so a maintainer should agree to it before this leaves WIP. The stricter pause of 76f1d3c8 (temporal_scene_now) has also not been run in the game, as Testing says. The pause screen and a movie are the cases worth a run, since a game frame that asks for no upscale in play would now pause too.
  • temporal_scene_now() allows 2 frames. Each time play gives way to a menu, the first 2-3 sets still go to the built-in one before the pause starts. That is fine, but the FPS counter's majority over 64 sets will show Built-in FG for a moment. Worth a word in the comment if it is meant.

Overlap

  • #244 (ANR frame generation, WIP) adds framegen_by == 2 to the same row, fg_asked and framegen_record. This PR's tx_framegen_by reads any non-0 as "Built-in FG", and framegen_by_fixed() would fix the row at Built-in FG over a saved 2. Whichever lands second has to rework the row. I'd take this one first, since it changes the row's meaning.

Not approved: the PR is WIP, and its Must be tested runs (Built-in FG chosen in play on RTX 40/50, AMD/Intel, Linux NVIDIA) aren't posted yet.

🤖 Generated with Claude Code

Code review only (read at `76f1d3c8`; nothing built or run here). The change does what Why and What changed say. The menu, the probe, the pause and the bug report's defaults read right. The lock order is new but consistent: `menu_tick` now takes `g.mu` under `present_image_mu`, and I found no path that takes `g.mu` or `dev.present_mu` first and then `present_image_mu`. The live line's buffers are sized for every variant. All 13 tables keep `%s` in the new texts. **Blocking** - **`tests/test_framegen_by_row.py` has a brace counter of its own** (`block()`, line 44). AGENTS.md says a new check cuts with `tests/srccut.py` (`block`, `between`). That one names the source and marker when a marker is missing or appears twice, and here several markers would silently cut the wrong span if they appeared twice. Please move the check to `srccut.block` (and `found` where it cuts by regex). **Suggestions** - **`dlss_fg_close()` (vk_dlss.cpp:1161) returns at `!fg_asked()`, which the probe now reaches often.** Before this PR, `g.params` was allocated only once DLSS-G was asked for. Now `dlss_fg_probe()` allocates it at the start-up screen on every NVIDIA GPU where DLSS-G is available, also with Built-in FG chosen or Frame generation Off. A player at Built-in FG then exits with `g.params` never destroyed and `g.closed` never set. A start-up probe still running at a fast exit is then not stopped by `closed`. Dropping that early return, or closing whenever `g.params || g.feature`, would cover both. - **The menus now show 1x, a change every NVIDIA player at the default will see.** At DLSS FG the title screen, the game's menus, movies and loading screens show the game's own frames only (60 in place of 180 at 3x). The PR means this, and it answers [#408](https://git.magicbean.dev/MagicBeanDev/Longshot/issues/408). But it is a visible change for everyone at the default, not only a text fix, so a maintainer should agree to it before this leaves WIP. The stricter pause of `76f1d3c8` (`temporal_scene_now`) has also not been run in the game, as Testing says. The pause screen and a movie are the cases worth a run, since a game frame that asks for no upscale in play would now pause too. - **`temporal_scene_now()` allows 2 frames.** Each time play gives way to a menu, the first 2-3 sets still go to the built-in one before the pause starts. That is fine, but the FPS counter's majority over 64 sets will show Built-in FG for a moment. Worth a word in the comment if it is meant. **Overlap** - https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/244 (ANR frame generation, WIP) adds `framegen_by == 2` to the same row, `fg_asked` and `framegen_record`. This PR's `tx_framegen_by` reads any non-0 as "Built-in FG", and `framegen_by_fixed()` would fix the row at Built-in FG over a saved 2. Whichever lands second has to rework the row. I'd take this one first, since it changes the row's meaning. Not approved: the PR is WIP, and its Must be tested runs (Built-in FG chosen in play on RTX 40/50, AMD/Intel, Linux NVIDIA) aren't posted yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
@ -0,0 +41,4 @@
raise SystemExit("FAIL: " + why)
def block(text, marker):
Owner

A brace counter of its own: AGENTS.md asks a new check to cut with tests/srccut.py (block, between), so a missing or doubled marker stops with one message naming it.

A brace counter of its own: AGENTS.md asks a new check to cut with tests/srccut.py (block, between), so a missing or doubled marker stops with one message naming it.
test(menu): the Frame generation by check cuts with srccut; DLSS-G's parameters let go at the exit at Built-in FG too
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 9s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 13s
CI / Workflow lint (actionlint) (pull_request) Successful in 13s
Third-party parts / As their notes say (pull_request) Successful in 18s
PR description / Description follows the template (pull_request_target) Failing after 12s
beanstalk/approval changed since the request: ask again
6c52fe54e7
tests/test_framegen_by_row.py had a brace counter of its own: it cuts with
tests/srccut.py now, as AGENTS.md asks of a new check, with the two markers
the no-SDK stubs also match ending at the line's brace.

dlss_fg_close returned where DLSS-G was not asked for now, but dlss_fg_probe
asks NGX (and allocates its parameter block) at the start-up screen at
Built-in FG too: close wherever DLSS-G is possible, so the block is let go
and closed stops a probe still running at the exit.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
HumanBean changed title from WIP: fix(vk): Frame generation by offers DLSS FG, not Auto to fix(vk): Frame generation by offers DLSS FG, not Auto 2026-11-16 09:50:14 +00:00
HumanBean deleted branch fix/fg-provider-row 2026-11-16 09:50:31 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1041
No description provided.