fix(oot): let Gohma reach her ceiling position above 60 fps #1098

Merged
HumanBean merged 1 commit from PirateKingIsh/Longshot:fix/gohma-saved-turn-rate into main 2026-11-16 22:36:28 +00:00
Contributor

Type: fix · Risk: medium · Tested on: Windows 11, RTX 5090 · Needs: one manual fight above 60 fps on another setup

All numerical results in this description are measured; caps, test inputs and hardware sizes are settings or configuration, and commits are identifiers.

Why

Above 60 fps, Gohma can keep circling the ceiling without reaching the next phase of the fight. Fixes #312. This corrects the saved steering rate without holding or lowering the frame rate.

PR #882 investigated the climb and proposed a frame-rate hold; it was closed unmerged in favor of a proper fix. A probe build recorded the climb's requested velocity: median 6.96627 game units/s at unit step and 6.77738 at median step 0.615338, over 164 and 532 updates respectively. Those climbs completed. The later ceiling circuits continued after the climb update had ended. The other update named there, f_827a87e0, did not log in these fights. This points to the saved-rate loss below, not a need to hold the climb at 60 fps.

How to reproduce

Seen on: Windows 11, RTX 5090, NVIDIA driver 621.24.
Settings and switches: Game frame rate cap 240 (setting; the room actually reached about 98-102 fps), Render resolution 100%, HOS_DYNRES=0, FPS counter on, frame generation off. Separate control at the 60 cap setting. No custom hot list or play profile.
Steps: On main at 903549ee, load a pre-boss Gohma save and play by hand. Let her complete several climbs without defeating her early. A normal first climb does not rule the problem out. Watch for prolonged perimeter circling without reaching the babies or vulnerable-eye phase; lowering the cap live to 60 rescued the reproduced state.
Expected: She gets into position and the fight advances at frame rates above 60.
Actual: She can keep moving around the perimeter without progressing.

What changed

The steering update saves a rate for the next frame. Its existing clamp multiplies a turn that has already been scaled by the frame step by that step again. For a rate-limited turn, the saved fraction becomes step squared. The change converts both clamp bounds back to a rate for positive steps below one.

  • nx2/oot_patches.py: an anchor replacement in f_8263e8e0, the saved steering-rate update, for every caller. Both signed bounds use the existing guest division helper only for 0 < step < 1; otherwise the original multiply and operands remain. Missing or ambiguous anchors keep the original code and warn.

  • tests/test_saved_turn_rate.py: an authored, game-free fixture through the real patch function. It covers both signs, rate- and target-limited turns, repeated updates, steps 0.25, 0.42, 0.5, 0.66, 1 and 2 (test inputs), and scoping/idempotence/warning behavior. It reuses only the six necessary arithmetic anchor lines, not a lifted function body.

  • README.md: remove the fixed Gohma fault from the high-cap warning, retain the intro-narration warning, and state the tested rates.

  • docs/tested/: a separate self-contained record for each of PirateKingIsh's three fights on 903549ee plus this change.

Measurements

Verdict: The reproduced ceiling-circling fault did not occur in the two complete fights on the patched build; the complete 60-cap control was normal. This is correctness evidence, not a performance improvement or a failure rate.

Hardware: Windows 11, RTX 5090, NVIDIA 621.24, Ryzen 7 9800X3D, 64 GB installed RAM (hardware configuration).
Scene: Gohma's room, same pre-boss save source, 100% render setting with HOS_DYNRES=0, 3416x1440 game picture, windowed, game's own upscaler, frame generation off, cap 240 or 60 as stated (settings).
Method: Human-played fights, not identical scripted combat or interleaved performance pairs. Actual FPS is native frame count divided by summed frame time over fresh active boss-play bridge samples, excluding loading, pauses and cutscenes. Climb counts are external read-only bridge observations. Diagnostic probe rows are explicitly separated from production rows.
How to reproduce: Repeat the fight by hand through later climbs, then defeat Gohma; use the actual FPS counter to confirm the game is above 60. Run python -I -B tests/test_saved_turn_rate.py for the game-free arithmetic reproduction.

Build identity: Before gameplay was main at 903549ee (the probe-build rows added diagnostics only). After gameplay was 903549ee plus this exact patch and test, before the rebase. The current PR commit e1023786044641fe17af5f4df49a595d13c1f77f is based on 7045ca7c; it was not built or played. Its source checks are reported separately below. The played patch and test are byte-identical to this commit's nx2/oot_patches.py and tests/test_saved_turn_rate.py.

Measurement Before: main @ 903549ee After: this PR @ e1023786 (change played on 903549ee)
Ceiling behavior; a probe build before / the patched build after Three instrumented fights reproduced later ceiling circuits; live drops to 60 recovered them Two complete higher-cap fights normal, Gohma defeated in both
Actual active FPS; same diagnostic/production distinction 102.2861, 99.1993, 101.0661 in those three probe fights 99.1491 and 98.1682 in the two fights on the patched build; 59.9991 in the complete control
Patched-build climb counts No production-patch build 2 and 4 at higher cap; 3 in the 60-cap control, all progressing normally
Game-free production regression test on the played source revision Compiles, then fails the short-step arithmetic Passes; a deliberately broken lower bound fails

Probe-build mechanism evidence follows. These rows are local diagnostic builds at 903549ee; the actor-limited experiment is not the production executable or this PR commit. Values are medians on selected rate-limited updates, not physical-angle measurements.

Probe-build selection Samples Step Saved fraction
Original arithmetic, higher-rate circuit 7031 0.553993 30.691%
Same original node after live cap drop 128 1.000000 100.000%
Actor-limited experimental correction 650 0.620212 100.000%

The probe-only experiment had five normal climbs at 97.4941 fps. The patched build has no actor registration or native probe. Its external reads cannot atomically measure an instruction's input and output, so no production saved-fraction measurement is claimed.

Game-free output excerpts (no game data):

Before, original arithmetic:
FAIL: saved rate step=0.25 rate=-0.0199999996 applied=-0.00499999989 saved=-0.00124999997 expected=-0.0199999996 div=0 mul=2
After, production patch:
PASS: saved turn rate (62 arithmetic checks and unrelated function)
PASS: original arithmetic compiles and fails the same short-step checks
PASS: scoped, idempotent, and missing or ambiguous anchor warns without a partial fix

Flags and settings

None

Testing

Tested: Windows 11 / RTX 5090 / NVIDIA 621.24. The played build was 903549ee plus this change: two complete fights at 99.1491 and 98.1682 fps, one complete control at 59.9991 fps, FPS counter on, fixed 100% rendering. The first higher-cap fight included post-boss dialogue; no repeated jump was observed once, and no fix for that separate report is claimed. All 31 teleport destinations arrived without device loss; their short windows ranged from 59.2753 to 109.0821 fps. Those windows are arrival checks, not sustained high-rate fight proof; Water Temple did not reach above 60.

The three fight records are:

  • docs/tested/2026-11-15-gohma-turn-rate-piratekingish-cap60.md
  • docs/tested/2026-11-15-gohma-turn-rate-piratekingish-high1.md
  • docs/tested/2026-11-15-gohma-turn-rate-piratekingish-high2.md

The catalogue renderer accepts all three records. tests/test_tested_configurations.py has the same single failure with and without them: test_cli_ascii_pipe_emits_the_arrow_containing_source_as_utf8 compares Windows CRLF output against LF bytes. Its other 24 checks pass. The full-suite controls retain the new documentation and test on both sides and remove only the production correction.

On current main 7045ca7c, rechecked without and with the production fix, with the new regression test present on both sides:

Check Without fix With fix
New regression Fails the saved-rate arithmetic after compiling Passes
Targeted checks 6 pass, 1 expected new-test failure, 0 skip 7 pass, 0 fail, 0 skip
Full suite 597 pass, 27 fail, 42 skip 598 pass, 26 fail, 42 skip

The only status difference is the new test becoming a pass; skip reasons also match. The 26 failures common to both sides are:

tests/test_auto_handheld.py
tests/test_bug_report.py
tests/test_bug_report_defaults.py
tests/test_crash_dialog.py
tests/test_crt_options.py
tests/test_failed_compile_keeps_objects.py
tests/test_fsr_uniform_ownership.py
tests/test_guest_imported.py
tests/test_hardware_report.py
tests/test_import_reach.py
tests/test_job_queue.py
tests/test_linux_preflight.py
tests/test_make_game_cache.py
tests/test_missing_nup.py
tests/test_pads_after_menu.py
tests/test_parallel_init_order.py
tests/test_pending_guest_import.py
tests/test_portable_builder_home.py
tests/test_portable_builder_startup.py
tests/test_release.py
tests/test_replay_write_order.py
tests/test_run_all_changed.py
tests/test_tested_configurations.py
tests/test_vk_occlusion_queries.py
tests/test_walk_key.py
tests/test_work_lock.py

Eleven intervening commits touch nx2/ or the reviewed high-FPS, frame-cap and FPS-counter paths (listed in EVIDENCE.md). The emitter, FP helpers, nx2/oot_patches.py, host/oot_high_fps.c/.h and host/frame_whole.h are unchanged. The host's nn_vi.c did change its 30-FPS pacing, limiter restoration and step selection; the FPS counter changed too. A new shadow-resolution hook changes generated code in another function. Code inspection supports expecting the same emitted steering body, but runtime timing is not asserted identical, and current-main generated output was not rebuilt or byte-compared. No new base build or game launch was made for this rebase.

Not tested: Gohma gameplay above about 100 fps; Linux, AMD and Intel; gameplay of the other callers (seven distinct AI files use this routine, measured census); builds with a hot list, custom aggressive FP emission, or guest FP exception/flush-to-zero behavior. The Builder's gcc.exe is a Clang wrapper, so there is no independent GNU GCC run. Current-main gameplay remains untested.

Must be tested:

  • Another setup, preferably Linux or AMD/Intel, at an actual game rate above 60 fps: by hand, play one complete Gohma fight through later ceiling cycles, expecting her to reach each phase normally without lowering the cap. Record OS, GPU, driver, actual rate and outcome.

Risks

What could break: This is a shared routine, not a Gohma-only override. Other callers have not had full gameplay testing. At a step of 1 or more the game's arithmetic is unchanged. The guard is step-based; a menu cap of 60 does not prove every sampled graph step equals one. Optional hot-list/custom emission shapes are outside the validated build scope.

Turning it off: No switch. Revert this commit.

Compatibility: No save format, options, shader/pipeline cache format or renderer ABI change. No new tool or runtime switch. The game's generated code is rebuilt normally when the source patch changes; this change does not require shader preparation.

Issues

Fixes #312
See #882 (closed, not merged; its frame-rate hold was not used).

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main (fetched 7045ca7c).
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled (only the minimal arithmetic anchors used by the patch/fixture, in the repository's existing patch style).

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers: Codex for implementation/tests/measurements; Claude for review.
  • A game-free test added for the fix, failing on main and passing here.
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md).
  • Docs updated.

The gameplay proof is for a behavioral fix, not an interleaved performance benchmark. No claim is made that static screenshots prove a ceiling cycle. No new gameplay measurements were collected on the rebased branch.

**Type:** fix · **Risk:** medium · **Tested on:** Windows 11, RTX 5090 · **Needs:** one manual fight above 60 fps on another setup All numerical results in this description are measured; caps, test inputs and hardware sizes are settings or configuration, and commits are identifiers. ## Why Above 60 fps, Gohma can keep circling the ceiling without reaching the next phase of the fight. Fixes #312. This corrects the saved steering rate without holding or lowering the frame rate. PR #882 investigated the climb and proposed a frame-rate hold; it was closed unmerged in favor of a proper fix. A probe build recorded the climb's requested velocity: median 6.96627 game units/s at unit step and 6.77738 at median step 0.615338, over 164 and 532 updates respectively. Those climbs completed. The later ceiling circuits continued after the climb update had ended. The other update named there, `f_827a87e0`, did not log in these fights. This points to the saved-rate loss below, not a need to hold the climb at 60 fps. ## How to reproduce **Seen on:** Windows 11, RTX 5090, NVIDIA driver 621.24. **Settings and switches:** Game frame rate cap 240 (setting; the room actually reached about 98-102 fps), Render resolution 100%, `HOS_DYNRES=0`, FPS counter on, frame generation off. Separate control at the 60 cap setting. No custom hot list or play profile. **Steps:** On main at `903549ee`, load a pre-boss Gohma save and play by hand. Let her complete several climbs without defeating her early. A normal first climb does not rule the problem out. Watch for prolonged perimeter circling without reaching the babies or vulnerable-eye phase; lowering the cap live to 60 rescued the reproduced state. **Expected:** She gets into position and the fight advances at frame rates above 60. **Actual:** She can keep moving around the perimeter without progressing. ## What changed The steering update saves a rate for the next frame. Its existing clamp multiplies a turn that has already been scaled by the frame step by that step again. For a rate-limited turn, the saved fraction becomes step squared. The change converts both clamp bounds back to a rate for positive steps below one. - `nx2/oot_patches.py`: an anchor replacement in `f_8263e8e0`, the saved steering-rate update, for every caller. Both signed bounds use the existing guest division helper only for `0 < step < 1`; otherwise the original multiply and operands remain. Missing or ambiguous anchors keep the original code and warn. - `tests/test_saved_turn_rate.py`: an authored, game-free fixture through the real patch function. It covers both signs, rate- and target-limited turns, repeated updates, steps 0.25, 0.42, 0.5, 0.66, 1 and 2 (test inputs), and scoping/idempotence/warning behavior. It reuses only the six necessary arithmetic anchor lines, not a lifted function body. - `README.md`: remove the fixed Gohma fault from the high-cap warning, retain the intro-narration warning, and state the tested rates. - `docs/tested/`: a separate self-contained record for each of PirateKingIsh's three fights on `903549ee` plus this change. ## Measurements **Verdict:** The reproduced ceiling-circling fault did not occur in the two complete fights on the patched build; the complete 60-cap control was normal. This is correctness evidence, not a performance improvement or a failure rate. Hardware: Windows 11, RTX 5090, NVIDIA 621.24, Ryzen 7 9800X3D, 64 GB installed RAM (hardware configuration). Scene: Gohma's room, same pre-boss save source, 100% render setting with `HOS_DYNRES=0`, 3416x1440 game picture, windowed, game's own upscaler, frame generation off, cap 240 or 60 as stated (settings). Method: Human-played fights, not identical scripted combat or interleaved performance pairs. Actual FPS is native frame count divided by summed frame time over fresh active boss-play bridge samples, excluding loading, pauses and cutscenes. Climb counts are external read-only bridge observations. Diagnostic probe rows are explicitly separated from production rows. How to reproduce: Repeat the fight by hand through later climbs, then defeat Gohma; use the actual FPS counter to confirm the game is above 60. Run `python -I -B tests/test_saved_turn_rate.py` for the game-free arithmetic reproduction. **Build identity:** Before gameplay was main at `903549ee` (the probe-build rows added diagnostics only). After gameplay was **`903549ee` plus this exact patch and test**, before the rebase. The current PR commit `e1023786044641fe17af5f4df49a595d13c1f77f` is based on `7045ca7c`; it was **not built or played**. Its source checks are reported separately below. The played patch and test are byte-identical to this commit's `nx2/oot_patches.py` and `tests/test_saved_turn_rate.py`. | Measurement | Before: main @ 903549ee | After: this PR @ e1023786 (change played on 903549ee) | |---|---|---| | Ceiling behavior; a probe build before / the patched build after | Three instrumented fights reproduced later ceiling circuits; live drops to 60 recovered them | Two complete higher-cap fights normal, Gohma defeated in both | | Actual active FPS; same diagnostic/production distinction | 102.2861, 99.1993, 101.0661 in those three probe fights | 99.1491 and 98.1682 in the two fights on the patched build; 59.9991 in the complete control | | Patched-build climb counts | No production-patch build | 2 and 4 at higher cap; 3 in the 60-cap control, all progressing normally | | Game-free production regression test on the played source revision | Compiles, then fails the short-step arithmetic | Passes; a deliberately broken lower bound fails | Probe-build mechanism evidence follows. These rows are local diagnostic builds at `903549ee`; the actor-limited experiment is **not** the production executable or this PR commit. Values are medians on selected rate-limited updates, not physical-angle measurements. | Probe-build selection | Samples | Step | Saved fraction | |---|---:|---:|---:| | Original arithmetic, higher-rate circuit | 7031 | 0.553993 | 30.691% | | Same original node after live cap drop | 128 | 1.000000 | 100.000% | | Actor-limited experimental correction | 650 | 0.620212 | 100.000% | The probe-only experiment had five normal climbs at 97.4941 fps. The patched build has no actor registration or native probe. Its external reads cannot atomically measure an instruction's input and output, so no production saved-fraction measurement is claimed. Game-free output excerpts (no game data): ```text Before, original arithmetic: FAIL: saved rate step=0.25 rate=-0.0199999996 applied=-0.00499999989 saved=-0.00124999997 expected=-0.0199999996 div=0 mul=2 After, production patch: PASS: saved turn rate (62 arithmetic checks and unrelated function) PASS: original arithmetic compiles and fails the same short-step checks PASS: scoped, idempotent, and missing or ambiguous anchor warns without a partial fix ``` ### Flags and settings None ## Testing **Tested:** Windows 11 / RTX 5090 / NVIDIA 621.24. The played build was `903549ee` plus this change: two complete fights at 99.1491 and 98.1682 fps, one complete control at 59.9991 fps, FPS counter on, fixed 100% rendering. The first higher-cap fight included post-boss dialogue; no repeated jump was observed once, and no fix for that separate report is claimed. All 31 teleport destinations arrived without device loss; their short windows ranged from 59.2753 to 109.0821 fps. Those windows are arrival checks, not sustained high-rate fight proof; Water Temple did not reach above 60. The three fight records are: - `docs/tested/2026-11-15-gohma-turn-rate-piratekingish-cap60.md` - `docs/tested/2026-11-15-gohma-turn-rate-piratekingish-high1.md` - `docs/tested/2026-11-15-gohma-turn-rate-piratekingish-high2.md` The catalogue renderer accepts all three records. `tests/test_tested_configurations.py` has the same single failure with and without them: `test_cli_ascii_pipe_emits_the_arrow_containing_source_as_utf8` compares Windows CRLF output against LF bytes. Its other 24 checks pass. The full-suite controls retain the new documentation and test on both sides and remove only the production correction. On current main `7045ca7c`, rechecked without and with the production fix, with the new regression test present on both sides: | Check | Without fix | With fix | |---|---|---| | New regression | Fails the saved-rate arithmetic after compiling | Passes | | Targeted checks | 6 pass, 1 expected new-test failure, 0 skip | 7 pass, 0 fail, 0 skip | | Full suite | 597 pass, 27 fail, 42 skip | 598 pass, 26 fail, 42 skip | The only status difference is the new test becoming a pass; skip reasons also match. The 26 failures common to both sides are: ```text tests/test_auto_handheld.py tests/test_bug_report.py tests/test_bug_report_defaults.py tests/test_crash_dialog.py tests/test_crt_options.py tests/test_failed_compile_keeps_objects.py tests/test_fsr_uniform_ownership.py tests/test_guest_imported.py tests/test_hardware_report.py tests/test_import_reach.py tests/test_job_queue.py tests/test_linux_preflight.py tests/test_make_game_cache.py tests/test_missing_nup.py tests/test_pads_after_menu.py tests/test_parallel_init_order.py tests/test_pending_guest_import.py tests/test_portable_builder_home.py tests/test_portable_builder_startup.py tests/test_release.py tests/test_replay_write_order.py tests/test_run_all_changed.py tests/test_tested_configurations.py tests/test_vk_occlusion_queries.py tests/test_walk_key.py tests/test_work_lock.py ``` Eleven intervening commits touch `nx2/` or the reviewed high-FPS, frame-cap and FPS-counter paths (listed in EVIDENCE.md). The emitter, FP helpers, `nx2/oot_patches.py`, `host/oot_high_fps.c/.h` and `host/frame_whole.h` are unchanged. The host's `nn_vi.c` did change its 30-FPS pacing, limiter restoration and step selection; the FPS counter changed too. A new shadow-resolution hook changes generated code in another function. Code inspection supports expecting the same emitted steering body, but runtime timing is not asserted identical, and current-main generated output was not rebuilt or byte-compared. No new base build or game launch was made for this rebase. **Not tested:** Gohma gameplay above about 100 fps; Linux, AMD and Intel; gameplay of the other callers (seven distinct AI files use this routine, measured census); builds with a hot list, custom aggressive FP emission, or guest FP exception/flush-to-zero behavior. The Builder's gcc.exe is a Clang wrapper, so there is no independent GNU GCC run. Current-main gameplay remains untested. **Must be tested:** - Another setup, preferably Linux or AMD/Intel, at an actual game rate above 60 fps: by hand, play one complete Gohma fight through later ceiling cycles, expecting her to reach each phase normally without lowering the cap. Record OS, GPU, driver, actual rate and outcome. ## Risks **What could break:** This is a shared routine, not a Gohma-only override. Other callers have not had full gameplay testing. At a step of 1 or more the game's arithmetic is unchanged. The guard is step-based; a menu cap of 60 does not prove every sampled graph step equals one. Optional hot-list/custom emission shapes are outside the validated build scope. **Turning it off:** No switch. Revert this commit. **Compatibility:** No save format, options, shader/pipeline cache format or renderer ABI change. No new tool or runtime switch. The game's generated code is rebuilt normally when the source patch changes; this change does not require shader preparation. ## Issues Fixes #312 See #882 (closed, not merged; its frame-rate hold was not used). ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main` (fetched `7045ca7c`). - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled (only the minimal arithmetic anchors used by the patch/fixture, in the repository's existing patch style). ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers: Codex for implementation/tests/measurements; Claude for review. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). - [x] Docs updated. The gameplay proof is for a behavioral fix, not an interleaved performance benchmark. No claim is made that static screenshots prove a ceiling cycle. No new gameplay measurements were collected on the rebased branch.
fix(oot): let Gohma reach her ceiling position above 60 fps
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 7s
Website / Website on Cloudflare (pull_request_target) Has been skipped
e102378604
The steering update f_8263e8e0 saves a turn already scaled by the frame step,
then scales its clamp bounds by that step again. At short steps this can
drain the rate and leave Gohma circling the ceiling without progressing.

Convert both bounds back to a rate for 0 < step < 1. Keep the original
arithmetic otherwise, for every caller, with no frame-rate hold or switch.
Add a game-free check through the real patch pipeline for signed, rate-
and target-limited turns, repeated updates, and unchanged long steps.

Played on 903549ee plus this exact change: two complete higher-cap fights
at measured 99.15 and 98.17 fps, and a control at measured 60.00 fps.
Rebased onto 7045ca7c without a new game build. The new test fails without
the fix and passes with it; the targeted checks pass and the full suite
has the same unrelated failures on both sides.

Fixes #312

Assisted-by: Codex (implementation, tests and measurements)
Assisted-by: Claude (review)
Co-Authored-By: Codex <[email protected]>
Author
Contributor

All numerical results below are measured; caps and render resolution are settings. Windows 11, RTX 5090, NVIDIA 621.24: Gohma was played by hand on main 903549ee plus the exact patch and test now in e102378604. Two complete higher-cap fights were normal at 99.1491 and 98.1682 fps (2 and 4 climbs); a complete 60-cap control was normal at 59.9991 fps (3 climbs). Render resolution was fixed at 100%, FPS counter on, no FPS hold. The first higher-cap fight included the following dialogue, with no repeated jump observed once. All 31 teleport destinations arrived without device loss. The rebase onto 7045ca7c was checked with the new test, targeted checks and full suite without/with the fix; it was not rebuilt or played. Another setup still needs one manual fight above 60 fps.

All numerical results below are measured; caps and render resolution are settings. Windows 11, RTX 5090, NVIDIA 621.24: Gohma was played by hand on main 903549ee plus the exact patch and test now in e1023786044641fe17af5f4df49a595d13c1f77f. Two complete higher-cap fights were normal at 99.1491 and 98.1682 fps (2 and 4 climbs); a complete 60-cap control was normal at 59.9991 fps (3 climbs). Render resolution was fixed at 100%, FPS counter on, no FPS hold. The first higher-cap fight included the following dialogue, with no repeated jump observed once. All 31 teleport destinations arrived without device loss. The rebase onto 7045ca7c was checked with the new test, targeted checks and full suite without/with the fix; it was not rebuilt or played. Another setup still needs one manual fight above 60 fps.
Member

Code-only review of e102378604; informational findings, with final approval left to another reviewer.

No confirmed introduced defect found in the six-file diff. The replacement updates both signed clamp bounds together, preserves the original multiply outside positive steps below one, and leaves missing/ambiguous anchors untouched with a warning. The regression exercises the real patch pipeline, repeated rate retention and unchanged/unrelated paths; it also checks that the original arithmetic fails, rather than merely matching source text.

Still waiting on the validation already identified in this PR: one complete Gohma fight on another setup at an actual game rate above 60 FPS, including later ceiling cycles. The recorded Windows/RTX 5090 fights used the exact correction on 903549ee; they do not establish gameplay on this rebased head. The fixture supplies the register setup and substitutes floating-point helpers, so it cannot establish the full shared steering routine's callers or guest floating-point exception/flush-to-zero behavior. Keep those limits explicit when another reviewer assesses the final gameplay evidence.

I read the patch integration, surrounding high-FPS handling, test and three fight records. The reviewed patch/high-FPS files have no intervening integration change on current main 623a0ca3 beyond this patch being absent. The other open changes sharing oot_patches.py target different hooks; no direct duplicate identified. No tests, builds, generated game code or gameplay were run or inspected for this review.

Code-only review of e1023786044641fe17af5f4df49a595d13c1f77f; informational findings, with final approval left to another reviewer. No confirmed introduced defect found in the six-file diff. The replacement updates both signed clamp bounds together, preserves the original multiply outside positive steps below one, and leaves missing/ambiguous anchors untouched with a warning. The regression exercises the real patch pipeline, repeated rate retention and unchanged/unrelated paths; it also checks that the original arithmetic fails, rather than merely matching source text. **Still waiting on the validation already identified in this PR:** one complete Gohma fight on another setup at an actual game rate above 60 FPS, including later ceiling cycles. The recorded Windows/RTX 5090 fights used the exact correction on `903549ee`; they do not establish gameplay on this rebased head. The fixture supplies the register setup and substitutes floating-point helpers, so it cannot establish the full shared steering routine's callers or guest floating-point exception/flush-to-zero behavior. Keep those limits explicit when another reviewer assesses the final gameplay evidence. I read the patch integration, surrounding high-FPS handling, test and three fight records. The reviewed patch/high-FPS files have no intervening integration change on current main `623a0ca3` beyond this patch being absent. The other open changes sharing `oot_patches.py` target different hooks; no direct duplicate identified. No tests, builds, generated game code or gameplay were run or inspected for this review.
Contributor

Checked on current main @ a413bf1c (Linux). The one commit cherry-picks cleanly: README auto-merged, no conflict markers. tests/test_saved_turn_rate.py passes: the 62 arithmetic checks, the original arithmetic failing the same short-step checks, and the missing-anchor warning. Not played in game here. The fight above 60 fps on this PC (RTX 4070 Ti) is still open.

Checked on current main @ a413bf1c (Linux). The one commit cherry-picks cleanly: README auto-merged, no conflict markers. `tests/test_saved_turn_rate.py` passes: the 62 arithmetic checks, the original arithmetic failing the same short-step checks, and the missing-anchor warning. Not played in game here. The fight above 60 fps on this PC (RTX 4070 Ti) is still open.
HumanBean deleted branch fix/gohma-saved-turn-rate 2026-11-16 22:36:29 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 7s
Website / Website on Cloudflare (pull_request_target) Has been skipped
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1098
No description provided.