WIP: fix(high-fps): Gohma's fight held at 60 fps, so she no longer climbs into the walls #882
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!882
Loading…
Reference in a new issue
No description provided.
Delete branch "bvtterbrot/Longshot:fix/gohma-hold-60"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Windows 11, AMD Radeon RX 7900 XTX, driver 26.10.1 (v3.0.0-rc.4 with this change) · Needs: the same fight on
mainwith this change; the comparison withHOS_FPS_BOSS_HOLD=0; LinuxWhy
With the Game frame rate cap above 60, Gohma, the Deku Tree's boss, climbs into the walls and stays inside them, so the
fight cannot be finished. Players have to know to set the cap to 60 before the fight. Fixes #312.
How to reproduce
Seen on: reported in #312; not reproduced here on Longshot (in Slingshot at a cap of 120: Windows 11, AMD Radeon RX 7900 XTX, driver 26.10.1)
Settings and switches: Game frame rate cap 120 (any cap above 60)
Steps: Enter Gohma's room in the Deku Tree and let her climb to the ceiling and come down again, a few times.
Expected: She climbs along the wall and drops back to the floor, as at 60.
Actual: She climbs into the wall and runs on inside it, or sticks on it.
What changed
Gohma's fight runs at 60 whatever the cap, and the cap comes back about 20 seconds after it. This is a hold, not a fix
of her climb: her climb node turns the distance to her next wall point into a velocity of 60 / step a frame, which her
character controller and the wall contacts do not follow at a step under 1. Making that keep time is still open.
patch_boss_hold()innx2/oot_patches.pyputs a call tohos_oot_boss_hold()at the head of her climbnode's update (
f_826ba2b0) and her turn node's update (f_827a87e0), in the supported build only, with a buildwarning when they are not found.
hos_oot_boss_hold()inhost/oot_high_fps.cstampshos_fps_hold_until(now +OOT_BOSS_HOLD_NS, 20 s);fps_refresh()inhost/nn_vi.canswers 60 for a cap above 60 while the stamp is ahead, one decision a present,beside the movie pacing. The limiter's restore and
realtime_step()then give the game its own limiter, rate andstep, as when the row comes down to 60 in play. Both changes are logged.
docs/development.md.Measurements
Verdict: Passed once: at a cap of 120 Gohma's fight played to its end as at 60 (the owner's report, 2026-11-15), on
v3.0.0-rc.4 with this change backported (rc.4 has no movie pacing, so
fps_refreshdiffers there). The run without thehold was not made in Longshot, so there is no before/after pair yet.
The game was closed before the hold ended, so the cap's return to 120 is not in that log.
Flags and settings
One new switch.
HOS_FPS_BOSS_HOLD=0off=0only for comparisonsTesting
Tested: The game-free checks on Windows 11:
tests/test_frame_rate_cap_step.py(a newboss holdmode: cap 120,a hold stamped, the game's limiter, rate and step at 60, then 120 again; it fails without the hold's line in
fps_refresh) andtests/test_high_fps_fixes.py(test_boss_hold_patch). The whole run (python -I -B tests/run_all.py --jobs 8): 515 passed, 20 failed, 77 skipped; the same 20 fail onmain@bbe7a07on this PC (test_appimage_player_build, test_auto_handheld, test_cpp_preflight, test_crash_dialog, test_crt_options, test_env_on, test_fpx_sticky, test_lift_cleanup_error, test_linux_preflight, test_make_game_cache, test_make_game_prepare, test_missing_nup, test_oot_state_tap, test_options_budget_once, test_readback_late, test_spawn_emit, test_tested_configurations, test_vk_occlusion_queries, test_vk_pgo, test_walk_key).In the game: Windows 11, AMD Radeon RX 7900 XTX, driver 26.10.1, v3.0.0-rc.4 with this change, a new file, cap 120, frame generation 2x: Gohma fought to
the end, climbing and dropping normally; the hold's log line appeared once.
Not tested:
mainwith this change in the game (only rc.4 with it). The fight withHOS_FPS_BOSS_HOLD=0. The cap'sreturn after the fight. Linux.
Must be tested:
the log line
vi: Gohma's fight: the frame rate cap is 60 while it lasts, and the cap's line again about 20 s afterthe fight (by hand: the FPS counter shows 60 in the fight and 120 after).
HOS_FPS_BOSS_HOLD=0, expecting the bug as on main,the comparison (by hand: she climbs into the wall or sticks on it).
Risks
What could break: The frame rate drops to 60 in her fight for players with a higher cap, by design. If another
actor shared either node update, the hold would start outside her fight; in Slingshot it was seen only there.
Turning it off:
HOS_FPS_BOSS_HOLD=0.Compatibility: A lift from before this PR has no call, so the fix needs the game built again by the builder.
Saves,
longshot_options.ini, the caches and the vk ABI do not change.Issues
Fixes #312
Checklist
Everyone
type(scope): description) of the status line's type.mainyet)main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.mainand passing here.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
Closing in favor of a proper fix instead of limiting the framerate.
Pull request closed