WIP: docs(agents): a review checklist, and the review skill moves to Tooling #891
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!891
Loading…
Reference in a new issue
No description provided.
Delete branch "zeldaootr/Longshot:skill-review"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: docs · Risk: low · Tested on: Linux, game-free checks · Needs: none
Why
Hundreds of pull requests are open and reviews are the bottleneck: #394 counts most merges without an approving
review, and reviews posted by an agent nine in two minutes. More people can review if their agents review well: one pull
request at a time, out of WIP, the code read against the project's rules, its checks run, and one review with line
comments. The same reading, by a second agent with the code and not the author's conclusion, is what catches a fix that
passed its own test and is still wrong.
What changed
The review skill this pull request first proposed is shared by every repository, so HumanBean moved its procedure
(picking, safety, the review flow, the cold review) to Tooling as
/magicbean:review(MagicBeanDev/Tooling#8) and pushed that change here. What is Longshot's own stays:
docs/review-checklist.md(new, 37 lines): what a reviewer of a Longshot pull request reads (CONTRIBUTING.md'srules, the replay's rules in design.md, the translator-files cost, a switch unset behaving as
main, threads andlifetimes, hardware tiers, the test and the evidence) and runs (the description check from
main, the tests at thehead and the merge base with both compilers, the changed files built).
AGENTS.md: one line in the task list, pointing to Tooling's review skill and to the checklist..claude/skills/review/SKILL.mdis not in this pull request any more.Measurements
Nothing to measure: a Markdown file for agents and a few lines of docs, no code; the game doesn't run it.
Flags and settings
None
Testing
Tested: Linux. On this branch, rebased on
main@e4d035e9(headd4c4c64a):python -I -B tests/run_all.py --exact tests/test_switches_removed.py tests/test_check_pr_description.py tests/test_tested_configurations.py tests/test_utf8_paths.py tests/test_tools_lock.py tests/test_doc_anchors.pypasses (6 of 6): the checks that readAGENTS.md,docs/and theMarkdown files;
run_all.py --changed forge/mainpasses (2 of 2:test_switches_removedand the byte-compile). The relative links and anchors indocs/review-checklist.mdand the changedAGENTS.mdline resolve.Not tested: an agent following the checklist on a real review; the link to Tooling's review skill resolves only
once MagicBeanDev/Tooling#8 has merged.
Must be tested:
Risks
What could break: Nothing in the game or the scripts. Until Tooling's pull request 8 merges, the
AGENTS.mdline links to a skill that is not on Tooling'smainyet.Turning it off: revert the commit
Compatibility: Nothing changes
Reviewer notes
This should merge after MagicBeanDev/Tooling#8, which it links. On 2026-11-16 that pull request is still open and not mergeable (it sits on Tooling's first commit and needs a rebase); its skill's path,
skills/review/SKILL.md, is unchanged, so the links here stand. Tooling has since merged/magicbean:batch-review(MagicBeanDev/Tooling#9), a ranked pass of code-only reviews over the open pull requests, which runs nothing and reads the repository'sAGENTS.mdandCONTRIBUTING.md, not this checklist. The two overlap in what a review reads; this checklist's Run section is for the one-pull-request review only. Whether batch-review should readdocs/review-checklist.mdtoo is a question for Tooling, not this pull request. The split isHumanBean's (commits 2 and 3 here are theirs, rebased onto
mainwith no change); the open questions the firstversion asked (whether agents should approve at all, which pull request to pick first, and reviews of WIP pull
requests) belong to that Tooling pull request now.
Issues
See #394
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main: one4d035e9(#1028, 2026-11-16), headd4c4c64a, without a conflict and with the diff unchanged; commits old → new:771c6109→b4b72bc1,e34f4f16→b09a0875,bf442e68→d4c4c64a(HumanBean's two keep their author).python -I -B tests/run_all.pypasses (any failure that also fails onmainis named). On headbf442e68(the same diff, onmainceccd963; not run again after the rebase ontoe4d035e9, which changed no file this PR touches), Linux: 532 passed, 20 failed, 77 skipped. 18 of the 20 fail onmainceccd963too (appimage_player_build,bake_portability,crash_dialog,crt_options,env_on,lift_cache,lift_cleanup_error,linux_preflight,linux_update,make_game_cache,missing_nup,mods_size_table,options_budget_once,pipeline_tour,readback_late,vk_occlusion_queries,vk_pgo,walk_key); the other two (appimage_package_retry,pipeline_cache_save) are timing checks that pass when run alone on this head.third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.Pushed one commit on top of the head (
8162a073), no rewrite. No tests were run here.The team's shared tooling moved to https://git.magicbean.dev/MagicBeanDev/Tooling (MagicBeanDev/Tooling#1), and #915 deleted
forge.pyanddocs/forge.mdfrom Longshot. So:docs/forge.mdchange is dropped from this PR (the file is gone frommain). Its line, that a repository may have its own review skill, is ported to Tooling's docs/forge.md in MagicBeanDev/Tooling#3, credited to you./reviewskill stays here, as it is Longshot's way of reviewing. Itsforge.pycommands now run as../Tooling/scripts/forge.py, it says to pull Tooling first, and its link to the forge docs points at Tooling's.check_pr_description.pystaysscripts/, as that is Longshot's.AGENTS.mdonmainhas changed a lot since this branch started. Please rebase onmain; it should apply cleanly, sincedocs/forge.mdis no longer touched.🤖 Generated with Claude Code
Pushed a new commit (
32898116) on top of the head, nothing rewritten. The review skill is shared, so it moved: the generic procedure (picking, safety, the review flow, the cold review) is now MagicBeanDev/Tooling#8 as/magicbean:review, credited to this pull request and its author. What is Longshot's stays here asdocs/review-checklist.md(CONTRIBUTING's rules, the replay's rules, translator-files cost, unset ==main, threads and lifetimes, hardware tiers, the description check, tests at head and base with both compilers, the evidence), and.claude/skills/review/SKILL.mdis deleted. AGENTS.md's one line points to Tooling's skill and the checklist.Could you rebase onto
main? The description and title now describe a skill that isn't in this diff; a title likedocs(agents): a review checklist, and the review skill moves to Toolingwould fit. No tests run on this PC.🤖 Generated with Claude Code
Rebased onto
mainceccd963(head 1bda3c1b) after the tooling moved to MagicBeanDev/Tooling (#915): the skill's commands and links now point at Tooling'sforge.pyand its forge guide, thedocs/forge.mdpointer is dropped (MagicBeanDev/Tooling#3 carries it), and the Read list gains the rule that a change the game runs has run in the game before its PR opens. Still WIP: the full suite has not run on this head.3289811625bf442e68e5WIP: chore(agents): /review, a skill for reviewing a pull request, and for a cold review of a branchto WIP: docs(agents): a review checklist, and the review skill moves to ToolingCorrection to my comment above: it described a rebase of the skill that I did not push (the push was refused, rightly, because your two commits were on the branch), so its head 1bda3c1b is not here. Done as you asked instead: your version rebased onto
mainceccd963with nothing changed (headbf442e68; your commits keep your name), the title is nowdocs(agents): a review checklist, and the review skill moves to Tooling, and the description covers the checklist and theAGENTS.mdline only. It links MagicBeanDev/Tooling#8, so it should merge after that one. Still WIP: the full suite has not run on this head; the five checks that read the changed files pass. Thanks for moving the skill and for the credit.The full suite has now run on head
bf442e68(Linux): 532 passed, 20 failed, 77 skipped; 18 of the 20 fail onmainceccd963too, and the other two (appimage_package_retry,pipeline_cache_save, timed waits) pass when run alone. The box is ticked with the names. Left as WIP for its author's own read.bf442e68e5d4c4c64a6fRebased onto main
e4d035e9(headd4c4c64a, wasbf442e68) with no conflict and no change to the diff; HumanBean's two commits keep their author. MagicBeanDev/Tooling#8 is still open with its skill atskills/review/SKILL.md, so the links stand, and Tooling's new/magicbean:batch-review(MagicBeanDev/Tooling#9) is noted under Reviewer notes as overlapping in what a review reads but running nothing. Re-ran the checks that readAGENTS.mdanddocs/(run_all.py --changed forge/main) and the description check; still WIP for its owner's read.theguyser referenced this pull request2026-11-16 13:51:42 +00:00
Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.