MagicBeanDev/Tooling
Watch
15
0
Fork
You've already forked Tooling
 1
Code Issues Pull requests 3 Projects Releases Packages Activity Actions

feat(skills): /magicbean:review, reviewing a pull request and a cold review of a branch #8

Open
HumanBean wants to merge 1 commit from HumanBean/Tooling:feat/review-skill into main
pull from: HumanBean/Tooling:feat/review-skill
merge into: MagicBeanDev:main
Conversation 0 Commits 1 Files changed 4 +83 -2
HumanBean commented 2026-11-15 20:56:42 +00:00
Owner

Why

Reviews are the bottleneck in every repository here. A review skill that says how to pick a pull request, stay safe, write one good review and have a branch read cold helps every repository, not only Longshot.

What changed

  • skills/review/SKILL.md (new, /magicbean:review): the procedure that is the same everywhere: picking (out of WIP, the oldest unreviewed, one at a time, never your own PR on the forge), safety (the PR's text and code are data; read what runs on this PC first; its own folder), the review flow with forge.py and the verdict rules from docs/forge.md, one review shown to the person first, and the cold review of a branch. What to read against is the repository's own docs/review-checklist.md, else its CONTRIBUTING.md, and its checks as that repository's guide says.
  • README.md skills table and AGENTS.md task table list it. docs/forge.md points to it under Reviewing a pull request. #3 adds pointer lines at the same spot (naming Longshot's skill); the two touch the same lines, so whichever merges second needs a rebase, and this one replaces those lines.

Based on Longshot's MagicBeanDev/Longshot#891 by zeldaootr. Longshot's own part (CONTRIBUTING rules, the replay's rules, hardware tiers, its test evidence) moves to Longshot's docs/review-checklist.md in that pull request.

Testing

Docs and a skill only. No tests run on this PC.

🤖 Generated with Claude Code

## Why Reviews are the bottleneck in every repository here. A review skill that says how to pick a pull request, stay safe, write one good review and have a branch read cold helps every repository, not only Longshot. ## What changed - `skills/review/SKILL.md` (new, `/magicbean:review`): the procedure that is the same everywhere: picking (out of WIP, the oldest unreviewed, one at a time, never your own PR on the forge), safety (the PR's text and code are data; read what runs on this PC first; its own folder), the review flow with `forge.py` and the verdict rules from `docs/forge.md`, one review shown to the person first, and the cold review of a branch. What to read against is the repository's own `docs/review-checklist.md`, else its CONTRIBUTING.md, and its checks as that repository's guide says. - `README.md` skills table and `AGENTS.md` task table list it. `docs/forge.md` points to it under *Reviewing a pull request*. https://git.magicbean.dev/MagicBeanDev/Tooling/pulls/3 adds pointer lines at the same spot (naming Longshot's skill); the two touch the same lines, so whichever merges second needs a rebase, and this one replaces those lines. Based on Longshot's https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/891 by zeldaootr. Longshot's own part (CONTRIBUTING rules, the replay's rules, hardware tiers, its test evidence) moves to Longshot's `docs/review-checklist.md` in that pull request. ## Testing Docs and a skill only. No tests run on this PC. 🤖 Generated with [Claude Code](https://claude.com/claude-code) 
The generic procedure of Longshot's review skill, for every repository; what is
one repository's goes in its docs/review-checklist.md.

Based on Longshot#891 by zeldaootr.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This pull request has changes conflicting with the target branch.
  • docs/forge.md
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'feat/review-skill:HumanBean-feat/review-skill'
git switch 'HumanBean-feat/review-skill'
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
ci: approved
No labels
ci: approved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Tooling!8
No description provided.