fix(ui): the area title card's frame reaches the HUD's sides on wider screens #1841

Open
PirateKingIsh wants to merge 4 commits from PirateKingIsh/Longshot:fix/title-card-hud-sides into main
Contributor

Summary

On a screen wider than 16:9, leave Link's house for the first time: the large area title card keeps its ornamental frame centred at the original width while the game fills the screen. This change extends the connecting lines to the HUD's sides and keeps the corner and middle ornaments at their original size. It draws the same artwork in three strips per quarter, including the shadows.

The frame follows the existing HUD reach: the screen's sides on supported ultrawide shapes, the middle 12:5 at 32:9, and the middle 16:9 at 48:9. Middle 16:9 HUD layout, 16:9 pictures and narrower pictures retain the original drawing. Narrower screens are not fixed by this change. Refs #1699.

The old RULE_WIDEN entries never acted on these eight panes: that rule accepts a horizontal midpoint near zero, while the quarter panes have midpoints at -960 and +960. Applying a whole-pane stretch would also stretch the baked ornaments. Read host/hos_wide_ui.c for the strip preparation and drawing, then nx2/oot_wide.py and its integration in nx2/oot_patches.py. The planner publishes the HUD choice once per frame; preparation records it for each pane, and drawing consumes that record even during a live HUD-layout change. Missing or changed lift anchors warn and restore preparation, drawing and arena reset before compilation. Records may be reused while their constants remain alive; the game's allocator-reset hook retires them before that memory can be recycled. Repeated fallback warnings are bounded per kind. The player guide explains the HUD reaches; the README remains a feature summary.

Testing

Tested: Windows 11, RTX 5090, NVIDIA 621.24. Review changes were played at 98178224, built with the committed hot list. The branch adds commits on reviewed head 707298e0; it has not been rebased. Main was fetched through 8f462db5 without moving the checkout. Comparisons use the retained main 068fb8eb executable and the identical renderer, as in the reviewed measurements.

At 5120×2160, Render resolution set and read back at 100%, frame generation off, FPS counter on and the 60 cap:

  • Game pause attempt during Kokiri's introductory card: 3,624 preparation/draw pairs. The game ignored Start; PirateKingIsh confirmed that no pause menu opened and the frame stayed wide. This is not a claim that an open game pause menu was exercised.
  • Insert menu opened and closed during the card by PirateKingIsh: 3,576 pairs; he confirmed no inward snap. A late automated attempt is excluded.
  • Screenshot-burst hitch: 3,448 pairs; four capture frames took 157.84–159.51 ms. PirateKingIsh saw a wide, joined frame throughout.

Each counted case had zero guard failures, unused preparations, missing slots and draw fallbacks, across all eight pane kinds. All recorded draws used three strips; no repeated draw of a preparation occurred in these runs. Captures while the menu was being exercised remain local. Capture-window rates were 59.373, 59.196 and 58.338 FPS respectively; they are not performance comparisons.

A further check on 98178224 used adult Forest Temple and child Kakariko, outside Kokiri's introduction. PirateKingIsh pressed Start during Forest Temple's large card and later in Kakariko's card; the game ignored it while both frames were visible, and both stayed wide. Forest Temple had 3,576 matched preparation/draw pairs (447 per pane kind), Kakariko 3,632 (454 per kind). Every kind had zero guard failures, unused preparations, missing slots and draw fallbacks; no preparation was drawn again. Capture-window rates were 59.341 and 59.676 FPS. The unchanged-main 068fb8eb Forest Temple control also ignored Start during the card. The game's pause menu could not be opened over the card on these entries, so an open pause menu over a card and the retained-preparation reuse path were not exercised. Adult Kakariko showed no large card and is excluded from the two-card result.

Earlier production 707298e0 checks remain labelled as such: Kokiri, Middle 16:9 and a live HUD change each way gave 7,248 matched pairs; Forest Temple's other frame art gave 3,616 matched pairs and PirateKingIsh's “Looked right throughout.” Earlier probe checks covered 21:9, 64:27, 32:9, 48:9, the full fade, Kakariko and the compact place-name banner, including an accepted centre-ornament overlay.

The real patch/host fixture fails on reviewed 707298e0 for repeated warnings and passes here. Removing the new reset call deliberately makes it fail. It checks repeated draws across long delays and layout changes, retirement despite identical recycled descriptors, picture-address reuse, narrow/idle fast paths with zero guest-memory reads, independent mirrored strips, and rollback when any of the three anchors is absent or changed. The original regression still fails on main for drawing one quarter. The complete changed host file built with llvm-mingw; generated output contains all three hooks and keeps their registers in context. A second agent reviewed ownership, counters and tests cold. Synthetic tests do not model the game's scheduler; the synchronous hooks rely on its existing exclusion of allocator reset from active allocation/drawing.

The Windows collection used the same compiler, permissions and platform skips: main 761 passed / 59 failed / 51 skipped; this change 762 / 58 / 51. No new failure. tests/test_job_queue.py remains isolated after it interrupted earlier unchanged-main commands; it is not a pass. tests/test_vbytes.py timed out on both sides. This was the direct tests/run_all.py collection, not a claimed all-green mise run test. Pinned lint tools were not installed.

Checks that fail on both main and this change
  • tests/test_appimage_player_build.py
  • tests/test_auto_handheld.py
  • tests/test_bug_report_defaults.py
  • tests/test_capture_read_once.py
  • tests/test_capture_readback_visibility.py
  • tests/test_crash_dialog.py
  • tests/test_crt_options.py
  • tests/test_damage_debug_menu.py
  • tests/test_dev_ab.py
  • tests/test_dev_build.py
  • tests/test_dev_migrate.py
  • tests/test_dev_packs.py
  • tests/test_display_startup_failure.py
  • tests/test_dlss_feature_size.py
  • tests/test_draw_stream_visibility.py
  • tests/test_failed_compile_keeps_objects.py
  • tests/test_frame_overlap.py
  • tests/test_fsr_image_retirement.py
  • tests/test_fsr_uniform_ownership.py
  • tests/test_game_menu_mouse_buttons.py
  • tests/test_guest_imported.py
  • tests/test_high_fps_fixes.py
  • tests/test_host_guest_writes.py
  • tests/test_hud_layout_row.py
  • tests/test_libc_hooks.py
  • tests/test_lift_cache.py
  • tests/test_linux_preflight.py
  • tests/test_linux_pressure.py
  • tests/test_make_game_ngx.py
  • tests/test_mise_build.py
  • tests/test_missing_nup.py
  • tests/test_mods_list.py
  • tests/test_ngx_sdk.py
  • tests/test_pads_after_menu.py
  • tests/test_parallel_init_order.py
  • tests/test_pending_guest_import.py
  • tests/test_pipeline_play_cache.py
  • tests/test_portable_builder_home.py
  • tests/test_portable_builder_startup.py
  • tests/test_prepare_cache_save.py
  • tests/test_present_queue_default.py
  • tests/test_present_source_crop.py
  • tests/test_present_thread.py
  • tests/test_profiling_mode.py
  • tests/test_psychov35_fsr3_fg.py
  • tests/test_readback_timeout_source.py
  • tests/test_replay_write_order.py
  • tests/test_sdiv_overflow.py
  • tests/test_slow_frames.py
  • tests/test_song_note_cue.py
  • tests/test_staging_burst.py
  • tests/test_texel_buffer_ownership.py
  • tests/test_upscaler_rows.py
  • tests/test_vbytes.py
  • tests/test_vcore_escape.py
  • tests/test_vk_occlusion_queries.py
  • tests/test_walk_key.py
  • tests/test_work_lock.py

Still to test:

  • Linux: after these commits are pushed, obtain CI's Ubuntu source-check results, including compilation of the host fixture with GCC, with maintainer approval where required; confirm the new head's results by hand. No Linux run is claimed here.
  • Windows: run the pinned lint tools and isolated queue test in the normal contributor environment, and investigate the shared failures and arithmetic timeout, by hand.
  • Retained-preparation reuse remains verified synthetically only. Start was ignored while the large card showed in Kokiri, Forest Temple and child Kakariko; unchanged main also ignored it in Forest Temple. If another entry allows an open game pause menu over its card, check that case by hand.

Measurements

All observational numbers are measured; aspect ratios, cap values, settings and test thresholds describe configuration. Tables give the median of two runs and their full range.

Verdict: The wider frame remained joined through the Insert menu and capture hitches. The four matched no-card runs below answer the generic-hook cost question. Main CPU changed by +0.050 ms/frame; the two-run ranges overlap. There is no clear slowdown in these samples. This capped comparison does not establish uncapped throughput or screen pacing.

No-card setup: main, patch, main, patch; 3840×2160 (16:9), Render 100%, 60 cap, no frame generation, same private save, unchanged renderer and warmed caches. Each 25-second window began 1,800 native presents after the same door input, after the title card. The window includes the tail of the introductory scene followed by idle play; it is not stationary throughout. Sampled positions and scene states matched across all four runs; the sampled camera differed by at most 0.1 degree. No screenshots or per-pane logging during these runs. Selection uses the frame trace's host clock. This measures the same no-card sequence, not uncapped throughput.

Before: main @ 068fb8eb After: this PR @ 98178224
Actual game FPS 59.994 (runs 59.993–59.995) 59.993 (runs 59.993–59.993)
Mean frame, ms 16.668 (runs 16.668–16.669) 16.669 (runs 16.668–16.669)
p99 frame, ms 18.790 (runs 18.650–18.930) 18.615 (runs 18.610–18.620)
Main CPU, ms/frame 2.579 (runs 2.522–2.636) 2.629 (runs 2.437–2.822)
Renderer record/submit, ms/frame 0.216 (runs 0.213–0.218) 0.216 (runs 0.212–0.221)
Frames over 50 ms 0.000 (runs 0.000–0.000) 0.000 (runs 0.000–0.000)

As a separate check of a stationary spot, the same recordings were also analysed from seconds 13 through 25 of every window. Scene-status samples, not performance values, selected this common interval: the introduction had ended and Link was still. These shorter samples are not extra runs or an isolated measure of the hooks. They show why a small CPU difference should not be presented as a reliable gain or loss.

Stationary tail only Main @ 068fb8eb This PR @ 98178224
Actual game FPS 60.000 (runs 59.995–60.005) 60.001 (runs 59.997–60.005)
Mean frame, ms 16.667 (runs 16.665–16.668) 16.666 (runs 16.665–16.667)
p99 frame, ms 18.491 (runs 18.469–18.513) 18.567 (runs 18.542–18.592)
Main CPU, ms/frame 2.658 (runs 2.647–2.668) 2.527 (runs 2.517–2.538)

With widening disabled (16:9/narrower or Middle 16:9) and no retained records, each generic preparation adds one atomic read after the game's original allocation, and each draw adds one atomic read before returning to the game's drawing. Arena resets also have an idle atomic check. On a wider screen between cards, drawing has that same idle fast path; preparation still identifies panes because widening is planned. While records exist, unrelated picture draws search the small host table without reading pane names from guest memory.

The earlier card-cost and pixel measurements below used reviewed 707298e0, not the new head. They remain evidence for geometry and the earlier cost; the new head's measurement above is specifically no-card.

Earlier card-cost setup: 5120×2160, Render 100%, cap 60, frame generation off, the same private save and renderer. Two warmed runs per arm, main/patch/main/patch; each 25-second window covered the door opening, entry and complete card, without screenshots or per-pane diagnostics. The earlier renderer recording/submission median increased by 0.015 ms/frame; both patched runs were above the main range. Those are not new-head card-cost measurements.

Before: main @ 068fb8eb After: this PR @ 707298e0
Vertical rail centres, pixels at 5120×2160 715 and 4404 75 and 5044
Middle ornament selected pixels, width × height 250 × 65 250 × 65
Actual game FPS 60.006 (runs 60.004–60.009) 60.005 (runs 60.004–60.005)
Mean frame, ms 16.665 (runs 16.664–16.666) 16.665 (runs 16.665–16.666)
p99 frame, ms 19.500 (runs 19.310–19.691) 19.592 (runs 19.563–19.622)
Main CPU, ms/frame 2.696 (runs 2.560–2.832) 2.859 (runs 2.541–3.176)
Renderer record/submit, ms/frame 0.247 (runs 0.244–0.249) 0.262 (runs 0.262–0.262)
Frames over 50 ms 0.000 (runs 0.000–0.000) 0.000 (runs 0.000–0.000)

Risks

The large card's eight frame/shadow panes use three independently allocated strips per visible quarter. Preparation records the choice; drawing does not reread the setting. A picture can retain its constants, so records are reusable until replacement, a descriptor/identity mismatch, or reset of the same allocator. A second preparation replaces the earlier record; if it was never drawn, the unused count increases with its warning bounded. Descriptor equality alone is insufficient because memory can be recycled. The reset hook introduces no asynchronous work and runs inside the game's original reset call. Incorrect ownership would risk stale constants; the tests cover retirement and reuse but not the entire game scheduler. The observed menu and hitch cases did not reuse an older preparation, and a loading transition cutting a card short was not tested. Guards retain the game's drawing, and each unexpected event logs only its first occurrence per kind; opt-in trace logging retains totals.

No new switch. Middle 16:9 retains the original frame, or revert the change. Saves, game assets and user settings are not migrated. The compact place-name banner remains outside the changed pane set. AMD/Intel-specific presentation tasks were removed as requested: this is host code using the unchanged renderer, with no GPU-specific change. Linux CI is still unverified here.

Checklist

Ready for review

  • One topic, on current review base 068fb8eb; the title is a Conventional Commit. Additive review commits remain on that reviewed base, without a rebase or force-push, as requested for this round.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named). Direct Windows runner results, shared failures, skips and the isolated check are disclosed above; no all-green claim.
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A fix: a game-free test that fails on main and passes here.
  • A check under tests/ that reads changed source is updated, not weakened.
  • Host code builds on Windows (llvm-mingw). Linux CI coverage is explicitly pending under Still to test.
  • Screenshots of the same spot on main and here, for a change that shows on screen.
  • Docs updated.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested.
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.
## Summary On a screen wider than 16:9, leave Link's house for the first time: the large area title card keeps its ornamental frame centred at the original width while the game fills the screen. This change extends the connecting lines to the HUD's sides and keeps the corner and middle ornaments at their original size. It draws the same artwork in three strips per quarter, including the shadows. The frame follows the existing HUD reach: the screen's sides on supported ultrawide shapes, the middle 12:5 at 32:9, and the middle 16:9 at 48:9. Middle 16:9 HUD layout, 16:9 pictures and narrower pictures retain the original drawing. Narrower screens are not fixed by this change. Refs #1699. The old RULE_WIDEN entries never acted on these eight panes: that rule accepts a horizontal midpoint near zero, while the quarter panes have midpoints at -960 and +960. Applying a whole-pane stretch would also stretch the baked ornaments. Read `host/hos_wide_ui.c` for the strip preparation and drawing, then `nx2/oot_wide.py` and its integration in `nx2/oot_patches.py`. The planner publishes the HUD choice once per frame; preparation records it for each pane, and drawing consumes that record even during a live HUD-layout change. Missing or changed lift anchors warn and restore preparation, drawing and arena reset before compilation. Records may be reused while their constants remain alive; the game's allocator-reset hook retires them before that memory can be recycled. Repeated fallback warnings are bounded per kind. The player guide explains the HUD reaches; the README remains a feature summary. ## Testing **Tested:** Windows 11, RTX 5090, NVIDIA 621.24. Review changes were played at `98178224`, built with the committed hot list. The branch adds commits on reviewed head `707298e0`; it has not been rebased. Main was fetched through `8f462db5` without moving the checkout. Comparisons use the retained main `068fb8eb` executable and the identical renderer, as in the reviewed measurements. At 5120×2160, Render resolution set and read back at 100%, frame generation off, FPS counter on and the 60 cap: - Game pause attempt during Kokiri's introductory card: 3,624 preparation/draw pairs. The game ignored Start; PirateKingIsh confirmed that no pause menu opened and the frame stayed wide. This is not a claim that an open game pause menu was exercised. - Insert menu opened and closed during the card by PirateKingIsh: 3,576 pairs; he confirmed no inward snap. A late automated attempt is excluded. - Screenshot-burst hitch: 3,448 pairs; four capture frames took 157.84–159.51 ms. PirateKingIsh saw a wide, joined frame throughout. Each counted case had zero guard failures, unused preparations, missing slots and draw fallbacks, across all eight pane kinds. All recorded draws used three strips; no repeated draw of a preparation occurred in these runs. Captures while the menu was being exercised remain local. Capture-window rates were 59.373, 59.196 and 58.338 FPS respectively; they are not performance comparisons. A further check on `98178224` used adult Forest Temple and child Kakariko, outside Kokiri's introduction. PirateKingIsh pressed Start during Forest Temple's large card and later in Kakariko's card; the game ignored it while both frames were visible, and both stayed wide. Forest Temple had 3,576 matched preparation/draw pairs (447 per pane kind), Kakariko 3,632 (454 per kind). Every kind had zero guard failures, unused preparations, missing slots and draw fallbacks; no preparation was drawn again. Capture-window rates were 59.341 and 59.676 FPS. The unchanged-main `068fb8eb` Forest Temple control also ignored Start during the card. The game's pause menu could not be opened over the card on these entries, so an open pause menu over a card and the retained-preparation reuse path were not exercised. Adult Kakariko showed no large card and is excluded from the two-card result. Earlier production `707298e0` checks remain labelled as such: Kokiri, Middle 16:9 and a live HUD change each way gave 7,248 matched pairs; Forest Temple's other frame art gave 3,616 matched pairs and PirateKingIsh's “Looked right throughout.” Earlier probe checks covered 21:9, 64:27, 32:9, 48:9, the full fade, Kakariko and the compact place-name banner, including an accepted centre-ornament overlay. The real patch/host fixture fails on reviewed `707298e0` for repeated warnings and passes here. Removing the new reset call deliberately makes it fail. It checks repeated draws across long delays and layout changes, retirement despite identical recycled descriptors, picture-address reuse, narrow/idle fast paths with zero guest-memory reads, independent mirrored strips, and rollback when any of the three anchors is absent or changed. The original regression still fails on main for drawing one quarter. The complete changed host file built with llvm-mingw; generated output contains all three hooks and keeps their registers in context. A second agent reviewed ownership, counters and tests cold. Synthetic tests do not model the game's scheduler; the synchronous hooks rely on its existing exclusion of allocator reset from active allocation/drawing. The Windows collection used the same compiler, permissions and platform skips: main 761 passed / 59 failed / 51 skipped; this change 762 / 58 / 51. No new failure. `tests/test_job_queue.py` remains isolated after it interrupted earlier unchanged-main commands; it is not a pass. `tests/test_vbytes.py` timed out on both sides. This was the direct `tests/run_all.py` collection, not a claimed all-green `mise run test`. Pinned lint tools were not installed. <details> <summary>Checks that fail on both main and this change</summary> - `tests/test_appimage_player_build.py` - `tests/test_auto_handheld.py` - `tests/test_bug_report_defaults.py` - `tests/test_capture_read_once.py` - `tests/test_capture_readback_visibility.py` - `tests/test_crash_dialog.py` - `tests/test_crt_options.py` - `tests/test_damage_debug_menu.py` - `tests/test_dev_ab.py` - `tests/test_dev_build.py` - `tests/test_dev_migrate.py` - `tests/test_dev_packs.py` - `tests/test_display_startup_failure.py` - `tests/test_dlss_feature_size.py` - `tests/test_draw_stream_visibility.py` - `tests/test_failed_compile_keeps_objects.py` - `tests/test_frame_overlap.py` - `tests/test_fsr_image_retirement.py` - `tests/test_fsr_uniform_ownership.py` - `tests/test_game_menu_mouse_buttons.py` - `tests/test_guest_imported.py` - `tests/test_high_fps_fixes.py` - `tests/test_host_guest_writes.py` - `tests/test_hud_layout_row.py` - `tests/test_libc_hooks.py` - `tests/test_lift_cache.py` - `tests/test_linux_preflight.py` - `tests/test_linux_pressure.py` - `tests/test_make_game_ngx.py` - `tests/test_mise_build.py` - `tests/test_missing_nup.py` - `tests/test_mods_list.py` - `tests/test_ngx_sdk.py` - `tests/test_pads_after_menu.py` - `tests/test_parallel_init_order.py` - `tests/test_pending_guest_import.py` - `tests/test_pipeline_play_cache.py` - `tests/test_portable_builder_home.py` - `tests/test_portable_builder_startup.py` - `tests/test_prepare_cache_save.py` - `tests/test_present_queue_default.py` - `tests/test_present_source_crop.py` - `tests/test_present_thread.py` - `tests/test_profiling_mode.py` - `tests/test_psychov35_fsr3_fg.py` - `tests/test_readback_timeout_source.py` - `tests/test_replay_write_order.py` - `tests/test_sdiv_overflow.py` - `tests/test_slow_frames.py` - `tests/test_song_note_cue.py` - `tests/test_staging_burst.py` - `tests/test_texel_buffer_ownership.py` - `tests/test_upscaler_rows.py` - `tests/test_vbytes.py` - `tests/test_vcore_escape.py` - `tests/test_vk_occlusion_queries.py` - `tests/test_walk_key.py` - `tests/test_work_lock.py` </details> **Still to test:** - Linux: after these commits are pushed, obtain CI's Ubuntu source-check results, including compilation of the host fixture with GCC, with maintainer approval where required; confirm the new head's results by hand. No Linux run is claimed here. - Windows: run the pinned lint tools and isolated queue test in the normal contributor environment, and investigate the shared failures and arithmetic timeout, by hand. - Retained-preparation reuse remains verified synthetically only. Start was ignored while the large card showed in Kokiri, Forest Temple and child Kakariko; unchanged main also ignored it in Forest Temple. If another entry allows an open game pause menu over its card, check that case by hand. ## Measurements All observational numbers are measured; aspect ratios, cap values, settings and test thresholds describe configuration. Tables give the median of two runs and their full range. **Verdict:** The wider frame remained joined through the Insert menu and capture hitches. The four matched no-card runs below answer the generic-hook cost question. Main CPU changed by +0.050 ms/frame; the two-run ranges overlap. There is no clear slowdown in these samples. This capped comparison does not establish uncapped throughput or screen pacing. No-card setup: main, patch, main, patch; 3840×2160 (16:9), Render 100%, 60 cap, no frame generation, same private save, unchanged renderer and warmed caches. Each 25-second window began 1,800 native presents after the same door input, after the title card. The window includes the tail of the introductory scene followed by idle play; it is not stationary throughout. Sampled positions and scene states matched across all four runs; the sampled camera differed by at most 0.1 degree. No screenshots or per-pane logging during these runs. Selection uses the frame trace's host clock. This measures the same no-card sequence, not uncapped throughput. | | Before: main @ 068fb8eb | After: this PR @ 98178224 | |---|---|---| | Actual game FPS | 59.994 (runs 59.993–59.995) | 59.993 (runs 59.993–59.993) | | Mean frame, ms | 16.668 (runs 16.668–16.669) | 16.669 (runs 16.668–16.669) | | p99 frame, ms | 18.790 (runs 18.650–18.930) | 18.615 (runs 18.610–18.620) | | Main CPU, ms/frame | 2.579 (runs 2.522–2.636) | 2.629 (runs 2.437–2.822) | | Renderer record/submit, ms/frame | 0.216 (runs 0.213–0.218) | 0.216 (runs 0.212–0.221) | | Frames over 50 ms | 0.000 (runs 0.000–0.000) | 0.000 (runs 0.000–0.000) | As a separate check of a stationary spot, the same recordings were also analysed from seconds 13 through 25 of every window. Scene-status samples, not performance values, selected this common interval: the introduction had ended and Link was still. These shorter samples are not extra runs or an isolated measure of the hooks. They show why a small CPU difference should not be presented as a reliable gain or loss. | Stationary tail only | Main @ 068fb8eb | This PR @ 98178224 | |---|---|---| | Actual game FPS | 60.000 (runs 59.995–60.005) | 60.001 (runs 59.997–60.005) | | Mean frame, ms | 16.667 (runs 16.665–16.668) | 16.666 (runs 16.665–16.667) | | p99 frame, ms | 18.491 (runs 18.469–18.513) | 18.567 (runs 18.542–18.592) | | Main CPU, ms/frame | 2.658 (runs 2.647–2.668) | 2.527 (runs 2.517–2.538) | With widening disabled (16:9/narrower or Middle 16:9) and no retained records, each generic preparation adds one atomic read after the game's original allocation, and each draw adds one atomic read before returning to the game's drawing. Arena resets also have an idle atomic check. On a wider screen between cards, drawing has that same idle fast path; preparation still identifies panes because widening is planned. While records exist, unrelated picture draws search the small host table without reading pane names from guest memory. The earlier card-cost and pixel measurements below used reviewed `707298e0`, not the new head. They remain evidence for geometry and the earlier cost; the new head's measurement above is specifically no-card. Earlier card-cost setup: 5120×2160, Render 100%, cap 60, frame generation off, the same private save and renderer. Two warmed runs per arm, main/patch/main/patch; each 25-second window covered the door opening, entry and complete card, without screenshots or per-pane diagnostics. The earlier renderer recording/submission median increased by 0.015 ms/frame; both patched runs were above the main range. Those are not new-head card-cost measurements. | | Before: main @ 068fb8eb | After: this PR @ 707298e0 | |---|---|---| | Vertical rail centres, pixels at 5120×2160 | 715 and 4404 | 75 and 5044 | | Middle ornament selected pixels, width × height | 250 × 65 | 250 × 65 | | Actual game FPS | 60.006 (runs 60.004–60.009) | 60.005 (runs 60.004–60.005) | | Mean frame, ms | 16.665 (runs 16.664–16.666) | 16.665 (runs 16.665–16.666) | | p99 frame, ms | 19.500 (runs 19.310–19.691) | 19.592 (runs 19.563–19.622) | | Main CPU, ms/frame | 2.696 (runs 2.560–2.832) | 2.859 (runs 2.541–3.176) | | Renderer record/submit, ms/frame | 0.247 (runs 0.244–0.249) | 0.262 (runs 0.262–0.262) | | Frames over 50 ms | 0.000 (runs 0.000–0.000) | 0.000 (runs 0.000–0.000) | ## Risks The large card's eight frame/shadow panes use three independently allocated strips per visible quarter. Preparation records the choice; drawing does not reread the setting. A picture can retain its constants, so records are reusable until replacement, a descriptor/identity mismatch, or reset of the same allocator. A second preparation replaces the earlier record; if it was never drawn, the unused count increases with its warning bounded. Descriptor equality alone is insufficient because memory can be recycled. The reset hook introduces no asynchronous work and runs inside the game's original reset call. Incorrect ownership would risk stale constants; the tests cover retirement and reuse but not the entire game scheduler. The observed menu and hitch cases did not reuse an older preparation, and a loading transition cutting a card short was not tested. Guards retain the game's drawing, and each unexpected event logs only its first occurrence per kind; opt-in trace logging retains totals. No new switch. Middle 16:9 retains the original frame, or revert the change. Saves, game assets and user settings are not migrated. The compact place-name banner remains outside the changed pane set. AMD/Intel-specific presentation tasks were removed as requested: this is host code using the unchanged renderer, with no GPU-specific change. Linux CI is still unverified here. ## Checklist ### Ready for review - [x] One topic, on current review base `068fb8eb`; the title is a Conventional Commit. Additive review commits remain on that reviewed base, without a rebase or force-push, as requested for this round. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [x] `mise run test` passes (any failure that also fails on `main` is named). Direct Windows runner results, shared failures, skips and the isolated check are disclosed above; no all-green claim. - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] A fix: a game-free test that fails on `main` and passes here. - [x] A check under `tests/` that reads changed source is updated, not weakened. - [x] Host code builds on Windows (llvm-mingw). Linux CI coverage is explicitly pending under Still to test. - [x] Screenshots of the same spot on `main` and here, for a change that shows on screen. - [x] Docs updated. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested. - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold.
Exercise the real lift integration and host drawing helpers with synthetic panes
and drawing constants. On main the first check fails because a quarter is still
prepared and drawn once. Cover mirrored strips, HUD reaches, byte preservation,
live choice pairing, repeated application and missing-anchor fallback.

Assisted-by: Codex (implementation, tests and measurements)
Assisted-by: Claude (review)
Co-Authored-By: Codex <[email protected]>
fix(ui): the area title card's frame reaches the HUD's sides on wider screens
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 5s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
707298e0dd
Prepare each frame quarter as three independent strips. Keep its corner and
middle ornaments at their own size and extend only the connecting line. Use the
HUD's existing reach and snapshot its layout choice once per frame so drawing
uses exactly what preparation made, including during a live HUD layout change.

Leave 16:9, narrower pictures and Middle 16:9 drawing unchanged. A missing lift
anchor restores both original paths. No renderer switch or game asset changes.

Refs #1699.

Assisted-by: Codex (implementation, tests and measurements)
Assisted-by: Claude (review)
Co-Authored-By: Codex <[email protected]>
Author
Contributor

Windows 11, RTX 5090, NVIDIA 621.24. Played production commit 707298e0dd, built with the shipped hot list. At 5120x2160, Render 100%, frame generation off and the 60 cap, the first Kokiri card extended to the HUD's sides with joined lines and unchanged ornaments. Middle 16:9 retained the original frame. Changed the HUD layout once each way while the card showed; matched all 7248 preparation/draw pairs with no fallback, unused set or mixed choice. Four screenshot-free runs alternated main 068fb8eb and this commit; actual rates and scatter are in the description. Earlier probe checks also covered 21:9, 32:9, 48:9, Kakariko and the compact place-name banner. Linux, AMD and Intel remain untested.

Windows 11, RTX 5090, NVIDIA 621.24. Played production commit 707298e0dd1619180111a18132ef2fb1babb9768, built with the shipped hot list. At 5120x2160, Render 100%, frame generation off and the 60 cap, the first Kokiri card extended to the HUD's sides with joined lines and unchanged ornaments. Middle 16:9 retained the original frame. Changed the HUD layout once each way while the card showed; matched all 7248 preparation/draw pairs with no fallback, unused set or mixed choice. Four screenshot-free runs alternated main 068fb8eb and this commit; actual rates and scatter are in the description. Earlier probe checks also covered 21:9, 32:9, 48:9, Kakariko and the compact place-name banner. Linux, AMD and Intel remain untested.
dyst left a comment

Verdict: Request changes. The fix works and is well guarded: on screens wider than 16:9 the area title card's frame reaches the HUD's sides, its ornaments keep their size, and every unexpected state falls back to the game's own drawing. One thing to change first: four of those fallbacks log a line on every prepare or draw of every frame pane, with no limit, so a fallback that keeps happening writes about 8 lines a frame for as long as the card shows.

For ultrawide players, the first area title card (and every one after) gets a frame that fits the picture instead of a 16:9 frame floating in the middle. It improves on the code it replaces: the old RULE_WIDEN entries for these eight panes never acted (their midpoints are at ±960), and a whole-pane stretch would have stretched the ornaments. The cost is two hooks on the generic picture prepare and draw (PicturePane_PrepareDraw, PicturePane_IssueDraw), which every UI picture now passes through, and those two functions now stay in context rather than locals.

Reviewed: 707298e0 against 068fb8eb (its merge base, the current base): all of the hos_wide_ui.c change and the planner around it (visit, hos_wide_ui_tick), oot_wide.py, the oot_patches.py change and how touches() keeps patched functions in context (nx2/lift.py), the tick's callers (do_present → wide_sides_tick → host_wide_menus), a64.h's GuestContext, the new test and the fixtures it imports (test_hud_layout.py, test_wide_ui.py, srccut.py), and the other callers of oot_patches.report. I also checked the anchors against the workspace's notes on the game's layout code (PicturePane_PrepareDraw / IssueDraw, f_8154f1c0 copying the uniform block to GPU memory). Only skimmed: the README line. Nothing run (a code review).
Fixed in this review: nothing.
Checked and fine:

  • Both patched functions stay in context: touches() runs patch_file on each function's text, and both anchors change it. So c->x[19], x[20], x[1], x[2] and x[31] hold live values at the prepare site, and the arguments are read before the original call.
  • hos_wide_title_prepare makes the game's own call first and copies Ctx after it. Each strip's call restarts from that copy with the original arguments, the copy is restored at the end, and the params and out buffers are written back. The game sees exactly the original call's result.
  • The epoch advances once per game present (wide_sides_tick in do_present), not per generated frame, so frame generation can't age a preparation beyond the one-frame allowance.
  • Strip geometry: the three widths sum to 1920 + E, the strips meet edge to edge in place and in source and effect coordinates, the right quarters are mirrored (out[2 - i], 1 - …), and E per shape matches hos_hud_reach (600 at 21:9, 640 at 64:27, 672 at 32:9, 0 at 48:9, Middle and 16:9 and narrower).
  • Prepare and draw are paired under the lock, checking pane, picture, layout, material, the 24-byte descriptor, and age. A live HUD-layout change can't split a pane. Draw restores picture + 0x48.
  • A missing or changed anchor leaves both halves original in every file (title_card_original), and the existing report() callers that pass counts without the title card print the warning and open no file.
  • The test fails on main by behaviour (one set allocated, one draw), not by a missing name, and covers all eight panes, three reaches, mirroring, restoration and the anchors split across files.
  • One topic, Conventional Commit title, the AI trailers present, no new switch, nothing from the game in the diff.

Blocking (to change before merge)

  1. host/hos_wide_ui.c:769, :804, :806, :832: "title guard failed", "title unused preparation", "title no state slot" and "title draw fallback" are plain hos_log lines on every prepare or draw. Each fires in exactly the cases the guards exist for (a card whose constants don't match the guard, a pane prepared and not drawn, or drawn twice), and each would then repeat every frame for all 8 panes while the card shows. A 4-second card at 60 fps is about 2,000 lines, in every log and bug report. Log the first occurrence per kind (as "unknown frame pane name" already does at :727), with a count, or let log_left budget them as the planner's own traces are, and log the per-pane traces behind log_each at trace level.

Suggestions (the author may take or leave)

  • host/hos_wide_ui.c:816: every picture draw in the game now runs title_kind (6 to 8 guest loads and a name compare), and every picture prepare does too, including at 16:9 and on the Steam Deck, where the plan is always 0. One atomic count of prepared-but-not-drawn strip sets would let the draw skip title_kind when it is zero, and prepare could skip it while the plan is 0 and nothing is pending, so most frames pay one atomic load.
  • README.md:78: the README's feature list is the project's summary; this level of detail (reaches per shape, which modes keep the original) fits better in the player guide, next to the HUD layout row in docs/user/graphics-and-controls.md.

Questions

  • Is a pane ever drawn without a prepare in the same or the previous frame, or prepared twice before a draw? For example, with the game's pause menu (or the Insert menu) opened while the card shows, or across a hitch. Your 7,248 pairs cover the card's normal course and HUD changes. If either case happens, the frame snaps back to 16:9 for those frames, and it's the case blocking 1 is about. A run of that, plus one other area's card on the production build, would settle it.
  • Main CPU is 2.696 ms against 2.859 ms (+6%), with overlapping two-run ranges. Most of that is probably noise, but the hooks and the two functions moved out of locals apply to every frame for every player, title card or not. Could you add matched numbers from a spot with no card (16:9 or the Deck's 16:10, where it all does nothing), or the fast path above, which would make the question moot?

Testing: Windows 11, RTX 5090, NVIDIA 621.24, by the author: 5120×2160 (64:27) on the production build, Middle 16:9, a live HUD-layout change each way during the card, 7,248 matched pairs, and four interleaved measured runs. The earlier probe builds covered 21:9, 32:9 and 48:9, a second area and the compact banner. AMD and Intel runs aren't needed for this change: it is host CPU code that issues the game's own draw three times through the unchanged renderer, so a GPU or driver can't make it behave differently; I'd drop them from Still to test. Linux: the new test compiles the whole new host block with GCC, so CI's Ubuntu source checks cover its portability once they run; they are waiting to be approved on this head. The pause and hitch case above is the run that's still missing.
Overlaps and merge order: #1855 (futondestroyer, WIP: live gameplay HUD placement) changes the same three files, hos_wide_ui.c's planner and tick included, and will conflict. This one is ready and smaller, so it goes first, and the HUD placement PR rebases over it, keeping title_plan_tick fed from the reach it computes. #1821 (hook sites, WIP, mine) touches oot_patches.py only, with no conflict; the two text anchors here are candidates to become hook sites once it lands.

**Verdict: Request changes.** The fix works and is well guarded: on screens wider than 16:9 the area title card's frame reaches the HUD's sides, its ornaments keep their size, and every unexpected state falls back to the game's own drawing. One thing to change first: four of those fallbacks log a line on every prepare or draw of every frame pane, with no limit, so a fallback that keeps happening writes about 8 lines a frame for as long as the card shows. For ultrawide players, the first area title card (and every one after) gets a frame that fits the picture instead of a 16:9 frame floating in the middle. It improves on the code it replaces: the old `RULE_WIDEN` entries for these eight panes never acted (their midpoints are at ±960), and a whole-pane stretch would have stretched the ornaments. The cost is two hooks on the generic picture prepare and draw (`PicturePane_PrepareDraw`, `PicturePane_IssueDraw`), which every UI picture now passes through, and those two functions now stay in context rather than locals. **Reviewed:** 707298e0 against 068fb8eb (its merge base, the current base): all of the `hos_wide_ui.c` change and the planner around it (`visit`, `hos_wide_ui_tick`), `oot_wide.py`, the `oot_patches.py` change and how `touches()` keeps patched functions in context (`nx2/lift.py`), the tick's callers (`do_present` → `wide_sides_tick` → `host_wide_menus`), `a64.h`'s `GuestContext`, the new test and the fixtures it imports (`test_hud_layout.py`, `test_wide_ui.py`, `srccut.py`), and the other callers of `oot_patches.report`. I also checked the anchors against the workspace's notes on the game's layout code (`PicturePane_PrepareDraw` / `IssueDraw`, `f_8154f1c0` copying the uniform block to GPU memory). Only skimmed: the README line. Nothing run (a code review). **Fixed in this review:** nothing. **Checked and fine:** - Both patched functions stay in context: `touches()` runs `patch_file` on each function's text, and both anchors change it. So `c->x[19]`, `x[20]`, `x[1]`, `x[2]` and `x[31]` hold live values at the prepare site, and the arguments are read before the original call. - `hos_wide_title_prepare` makes the game's own call first and copies `Ctx` after it. Each strip's call restarts from that copy with the original arguments, the copy is restored at the end, and the params and `out` buffers are written back. The game sees exactly the original call's result. - The epoch advances once per game present (`wide_sides_tick` in `do_present`), not per generated frame, so frame generation can't age a preparation beyond the one-frame allowance. - Strip geometry: the three widths sum to `1920 + E`, the strips meet edge to edge in place and in source and effect coordinates, the right quarters are mirrored (`out[2 - i]`, `1 - …`), and `E` per shape matches `hos_hud_reach` (600 at 21:9, 640 at 64:27, 672 at 32:9, 0 at 48:9, Middle and 16:9 and narrower). - Prepare and draw are paired under the lock, checking pane, picture, layout, material, the 24-byte descriptor, and age. A live HUD-layout change can't split a pane. Draw restores `picture + 0x48`. - A missing or changed anchor leaves both halves original in every file (`title_card_original`), and the existing `report()` callers that pass counts without the title card print the warning and open no file. - The test fails on `main` by behaviour (one set allocated, one draw), not by a missing name, and covers all eight panes, three reaches, mirroring, restoration and the anchors split across files. - One topic, Conventional Commit title, the AI trailers present, no new switch, nothing from the game in the diff. **Blocking** (to change before merge) 1. `host/hos_wide_ui.c:769`, `:804`, `:806`, `:832`: "title guard failed", "title unused preparation", "title no state slot" and "title draw fallback" are plain `hos_log` lines on every prepare or draw. Each fires in exactly the cases the guards exist for (a card whose constants don't match the guard, a pane prepared and not drawn, or drawn twice), and each would then repeat every frame for all 8 panes while the card shows. A 4-second card at 60 fps is about 2,000 lines, in every log and bug report. Log the first occurrence per kind (as "unknown frame pane name" already does at `:727`), with a count, or let `log_left` budget them as the planner's own traces are, and log the per-pane traces behind `log_each` at trace level. **Suggestions** (the author may take or leave) - `host/hos_wide_ui.c:816`: every picture draw in the game now runs `title_kind` (6 to 8 guest loads and a name compare), and every picture prepare does too, including at 16:9 and on the Steam Deck, where the plan is always 0. One atomic count of prepared-but-not-drawn strip sets would let the draw skip `title_kind` when it is zero, and prepare could skip it while the plan is 0 and nothing is pending, so most frames pay one atomic load. - `README.md:78`: the README's feature list is the project's summary; this level of detail (reaches per shape, which modes keep the original) fits better in the player guide, next to the HUD layout row in `docs/user/graphics-and-controls.md`. **Questions** - Is a pane ever drawn without a prepare in the same or the previous frame, or prepared twice before a draw? For example, with the game's pause menu (or the Insert menu) opened while the card shows, or across a hitch. Your 7,248 pairs cover the card's normal course and HUD changes. If either case happens, the frame snaps back to 16:9 for those frames, and it's the case blocking 1 is about. A run of that, plus one other area's card on the production build, would settle it. - Main CPU is 2.696 ms against 2.859 ms (+6%), with overlapping two-run ranges. Most of that is probably noise, but the hooks and the two functions moved out of locals apply to every frame for every player, title card or not. Could you add matched numbers from a spot with no card (16:9 or the Deck's 16:10, where it all does nothing), or the fast path above, which would make the question moot? **Testing:** Windows 11, RTX 5090, NVIDIA 621.24, by the author: 5120×2160 (64:27) on the production build, Middle 16:9, a live HUD-layout change each way during the card, 7,248 matched pairs, and four interleaved measured runs. The earlier probe builds covered 21:9, 32:9 and 48:9, a second area and the compact banner. AMD and Intel runs aren't needed for this change: it is host CPU code that issues the game's own draw three times through the unchanged renderer, so a GPU or driver can't make it behave differently; I'd drop them from Still to test. Linux: the new test compiles the whole new host block with GCC, so CI's Ubuntu source checks cover its portability once they run; they are waiting to be approved on this head. The pause and hitch case above is the run that's still missing. **Overlaps and merge order:** https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1855 (futondestroyer, WIP: live gameplay HUD placement) changes the same three files, `hos_wide_ui.c`'s planner and tick included, and will conflict. This one is ready and smaller, so it goes first, and the HUD placement PR rebases over it, keeping `title_plan_tick` fed from the reach it computes. https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1821 (hook sites, WIP, mine) touches `oot_patches.py` only, with no conflict; the two text anchors here are candidates to become hook sites once it lands.
README.md Outdated
@ -75,6 +75,9 @@ The player guide, also at [longshot.magicbean.dev](https://longshot.magicbean.de
which keeps the game and itself up to date (stable and nightly channels).
- **Modern graphics:** Vulkan, any resolution, ultrawide and 4:3 with the HUD kept in place, frame rates above 60, and
upscaling and frame generation with NVIDIA DLSS, AMD FSR 3.1 and FSR 4, and Intel XeSS.
On screens wider than 16:9, the area title card's frame follows the HUD layout and its reach: the screen's sides,
Member

Suggestion: this detail fits the player guide (docs/user/graphics-and-controls.md, by the HUD layout row) better than the README's feature summary.

Suggestion: this detail fits the player guide (`docs/user/graphics-and-controls.md`, by the HUD layout row) better than the README's feature summary.
@ -570,0 +766,4 @@
if (ext > 0 && alpha > 0) {
if ((flags & 7) != 3 || fabsf(title_float(original + 0xb0) - 1920) > .01f ||
fabsf(title_float(original + 0xb4) - 1080) > .01f) {
hos_log("wide UI: title guard failed kind %d; game's drawing retained", kind);
Member

Blocking 1: this line is written on every prepare of every frame pane while the guard fails, about 8 lines a frame for as long as the card shows. Once per kind with a count (as :727 does), or under log_left, would keep the signal without the flood.

Blocking 1: this line is written on every prepare of every frame pane while the guard fails, about 8 lines a frame for as long as the card shows. Once per kind with a count (as `:727` does), or under `log_left`, would keep the signal without the flood.
@ -570,0 +801,4 @@
}
title_leave();
if (unused)
hos_log("wide UI: title unused preparation seq %llu", (unsigned long long)unused);
Member

Blocking 1: the same for "unused preparation" and "no state slot" (:806). A pane prepared and not drawn repeats this every frame.

Blocking 1: the same for "unused preparation" and "no state slot" (`:806`). A pane prepared and not drawn repeats this every frame.
@ -570,0 +813,4 @@
}
int hos_wide_title_draw(Ctx *c, void (*draw)(Ctx *)) {
uint64_t picture = c->x[0], pane = recomp_load64(c, c->x[1] + 8), layout = 0;
int kind = title_kind(c, pane, &layout);
Member

Suggestion: every picture draw in the game reaches here, at 16:9 too. An atomic count of pending strip preparations would let this skip title_kind on almost every frame.

Suggestion: every picture draw in the game reaches here, at 16:9 too. An atomic count of pending strip preparations would let this skip `title_kind` on almost every frame.
@ -570,0 +829,4 @@
uint32_t now = title_plan_epoch(); /* frame age only; no option or extension is read here */
if (!state.valid || state.used || state.layout != layout || state.material != recomp_load64(c, picture + 0x30) ||
memcmp(original, state.original, 24) || (uint32_t)(now - state.epoch) > 1) {
hos_log("wide UI: title draw fallback kind %d pane %llx seq %llu prepared %u now %u valid %d used %d", kind,
Member

Blocking 1: the same for the draw fallback. A pane drawn without its prepare (or twice) writes this on each draw, every frame.

Blocking 1: the same for the draw fallback. A pane drawn without its prepare (or twice) writes this on each draw, every frame.
Assisted-by: Codex (implementation, tests and measurements)
Assisted-by: Claude (review)
Co-Authored-By: Codex <[email protected]>
fix(ui): retain title-card strips until their constants are retired
Some checks are pending
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
9817822462
Assisted-by: Codex (implementation, tests and measurements)
Assisted-by: Claude (review)
Co-Authored-By: Codex <[email protected]>
Author
Contributor

Thanks for the review. The follow-up commits are 8c52266a and 98178224, on top of the reviewed head; no rebase.

  1. Blocking logging: each of the four warning kinds logs only its first occurrence per pane kind, with its count. Totals remain available with the existing opt-in logging; per-pane lines are trace-level. The regression fails on the reviewed version for repeated warnings and passes here.
  2. Fast path: with no retained strip records, a draw adds one atomic read. With widening disabled and no records, preparation does too. Wide-screen preparation still identifies panes; I am not claiming that work disappeared. Reset has an idle atomic check.
  3. Documentation: the reach details moved beside the player guide's HUD settings. The README is back to its feature summary.
  4. Lifetime and menus: the code permits drawing retained constants. Records now survive repeated draws and are retired when replaced, mismatched or when the same allocator resets, before memory reuse. A regression exercises the real reset hook, identical recycled descriptors and a reused picture address. Work remains synchronous inside the game's existing calls. On 98178224, I pressed Start during Forest Temple's large card, then later during child Kakariko's large card: the game ignored Start both times while the frame was visible, and the frame stayed wide. Forest Temple had 3,576 preparation/draw pairs and Kakariko 3,632, with zero guard, unused, missing-slot or fallback counts for every pane kind. The unchanged-main 068fb8eb Forest Temple control also ignored Start during the card. So the game's pause menu could not be opened over the card on either entry; this is not a test with the pause menu open. No reused preparation occurred; that path remains covered synthetically, not demonstrated in a game run. The earlier Insert-menu repeat had 3,576 pairs and the hitch case 3,448, also with zero fallback categories and no visible snap. Four earlier capture frames took about 158–160 ms. Forest Temple's other frame art now has coverage on this head as well as the earlier 707298e0 run.
  5. No-card cost: four interleaved screenshot-free runs at 16:9, main 068fb8eb versus 98178224, after the same entrance/card. Main CPU: 2.579 (runs 2.522–2.636) → 2.629 (runs 2.437–2.822) ms/frame. Main CPU changed by +0.050 ms/frame; the two-run ranges overlap. There is no clear slowdown in these samples. This capped comparison does not establish uncapped throughput or screen pacing. FPS, mean/p99 frame time and full scatter are in the updated description. All numbers here are measured.
  6. Still to test: removed the AMD/Intel-specific tasks. Linux CI remains pending/unverified here. Start was ignored on both nonintroductory entries tested; retained-draw reuse still has no game-run coverage. Windows collection: main 761 passed / 59 failed / 51 skipped; patch 762 / 58 / 51; no new failure, with the shared failures and isolated queue check named in the description.
  7. Merge order: left this branch on its reviewed base. As requested, #1841 goes first; #1855 can rebase over it while keeping the title plan fed from its computed HUD reach. Nothing changed for #1821.
Thanks for the review. The follow-up commits are `8c52266a` and `98178224`, on top of the reviewed head; no rebase. 1. **Blocking logging:** each of the four warning kinds logs only its first occurrence per pane kind, with its count. Totals remain available with the existing opt-in logging; per-pane lines are trace-level. The regression fails on the reviewed version for repeated warnings and passes here. 2. **Fast path:** with no retained strip records, a draw adds one atomic read. With widening disabled and no records, preparation does too. Wide-screen preparation still identifies panes; I am not claiming that work disappeared. Reset has an idle atomic check. 3. **Documentation:** the reach details moved beside the player guide's HUD settings. The README is back to its feature summary. 4. **Lifetime and menus:** the code permits drawing retained constants. Records now survive repeated draws and are retired when replaced, mismatched or when the same allocator resets, before memory reuse. A regression exercises the real reset hook, identical recycled descriptors and a reused picture address. Work remains synchronous inside the game's existing calls. On `98178224`, I pressed Start during Forest Temple's large card, then later during child Kakariko's large card: the game ignored Start both times while the frame was visible, and the frame stayed wide. Forest Temple had 3,576 preparation/draw pairs and Kakariko 3,632, with zero guard, unused, missing-slot or fallback counts for every pane kind. The unchanged-main `068fb8eb` Forest Temple control also ignored Start during the card. So the game's pause menu could not be opened over the card on either entry; this is not a test with the pause menu open. No reused preparation occurred; that path remains covered synthetically, not demonstrated in a game run. The earlier Insert-menu repeat had 3,576 pairs and the hitch case 3,448, also with zero fallback categories and no visible snap. Four earlier capture frames took about 158–160 ms. Forest Temple's other frame art now has coverage on this head as well as the earlier `707298e0` run. 5. **No-card cost:** four interleaved screenshot-free runs at 16:9, main `068fb8eb` versus `98178224`, after the same entrance/card. Main CPU: 2.579 (runs 2.522–2.636) → 2.629 (runs 2.437–2.822) ms/frame. Main CPU changed by +0.050 ms/frame; the two-run ranges overlap. There is no clear slowdown in these samples. This capped comparison does not establish uncapped throughput or screen pacing. FPS, mean/p99 frame time and full scatter are in the updated description. All numbers here are measured. 6. **Still to test:** removed the AMD/Intel-specific tasks. Linux CI remains pending/unverified here. Start was ignored on both nonintroductory entries tested; retained-draw reuse still has no game-run coverage. Windows collection: main 761 passed / 59 failed / 51 skipped; patch 762 / 58 / 51; no new failure, with the shared failures and isolated queue check named in the description. 7. **Merge order:** left this branch on its reviewed base. As requested, #1841 goes first; #1855 can rebase over it while keeping the title plan fed from its computed HUD reach. Nothing changed for #1821.
Some checks are pending
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/title-card-hud-sides:PirateKingIsh-fix/title-card-hud-sides'
git switch 'PirateKingIsh-fix/title-card-hud-sides'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1841
No description provided.