fix(ui): the launcher's window is titled Longshot Launcher #224

Open
omgitsgela wants to merge 1 commit from omgitsgela/LongshotLauncher:fix/launcher-window-title into main
Member

Why this is needed

The launcher's window is titled "Longshot", the same as the game, while the words drawn in its own title bar already say "Longshot Launcher". Anything that lists windows by their title therefore shows two entries called "Longshot" once the game runs beside the launcher — seen in Steam's Switch Windows on the Deck with the Steam tile opening the launcher and its Play starting the game (#130), and a desktop taskbar or window list has the same problem. The AppImage's menu entry already says "Longshot Launcher" (and package.sh's does, for #118); the window title was the one place still calling the launcher by the game's name.

What it does

App/MainWindow.axaml: Title="Longshot" → Title="Longshot Launcher".

Nothing else moves. The Wayland app_id / X11 WM_CLASS (Shortcuts.LauncherEntryName, longshot-launcher) still pairs the window with the launcher's own menu entry, and no appid or art keyed on a file changes.

What was checked

launcher core: 2141 checks passed, with main's three red groups skipped locally (UnlistedChecks after #208, SavesChecks after #196, BuildReportChecks — the same aborts clean main shows on this host).

Not yet seen on screen: the next launcher build carrying this should show "Longshot Launcher" in Steam's Switch Windows beside the game's own "Longshot".

Not in this PR

The Steam tile itself (#130). The title bar's drawn text already said "Longshot Launcher"; this only makes the window's real title agree with it.

## Why this is needed The launcher's window is titled "Longshot", the same as the game, while the words drawn in its own title bar already say "Longshot Launcher". Anything that lists windows by their title therefore shows two entries called "Longshot" once the game runs beside the launcher — seen in Steam's *Switch Windows* on the Deck with the Steam tile opening the launcher and its Play starting the game (#130), and a desktop taskbar or window list has the same problem. The AppImage's menu entry already says "Longshot Launcher" (and `package.sh`'s does, for #118); the window title was the one place still calling the launcher by the game's name. ## What it does `App/MainWindow.axaml`: `Title="Longshot"` → `Title="Longshot Launcher"`. Nothing else moves. The Wayland app_id / X11 WM_CLASS (`Shortcuts.LauncherEntryName`, `longshot-launcher`) still pairs the window with the launcher's own menu entry, and no appid or art keyed on a file changes. ## What was checked `launcher core: 2141 checks passed`, with main's three red groups skipped locally (`UnlistedChecks` after #208, `SavesChecks` after #196, `BuildReportChecks` — the same aborts clean `main` shows on this host). Not yet seen on screen: the next launcher build carrying this should show "Longshot Launcher" in Steam's Switch Windows beside the game's own "Longshot". ## Not in this PR The Steam tile itself (#130). The title bar's drawn text already said "Longshot Launcher"; this only makes the window's real title agree with it.
fix(ui): the launcher's window is titled Longshot Launcher
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
62546c0479
The window's title was "Longshot", the same as the game's, while the words
drawn in its own title bar already say "Longshot Launcher" (so does the
AppImage's menu entry, and package.sh's, #118). Anything that lists windows
by their title therefore shows two entries called Longshot once the game
runs beside the launcher: Steam's Switch Windows does exactly that,
observed on the Deck with the Steam tile opening the launcher and its Play
starting the game, and a desktop's taskbar and window list have the same
problem.

Title="Longshot Launcher" in MainWindow.axaml. Nothing else moves: the
Wayland app_id / X11 WM_CLASS (Shortcuts.LauncherEntryName,
"longshot-launcher") still pairs the window with the launcher's own menu
entry, and the appid of anything keyed on the file is untouched.

Assisted-by: Hermes Agent
Author
Member

Evidence: the two windows, before this change

Steam's Switch Windows on the Deck, both entries reading "Longshot": the game selected, the launcher below it

Taken in Gaming mode on the Deck, with the Steam tile opening the launcher and its Play starting the game (#130). Both entries read "Longshot" because the launcher's window title is Title="Longshot", while the words drawn in its own title bar already say "Longshot Launcher".

That is the state this PR changes: once a launcher build carries it, the second entry should read "Longshot Launcher". That capture is still owed — it needs a build, not just this diff.

**Evidence: the two windows, before this change** ![Steam's Switch Windows on the Deck, both entries reading "Longshot": the game selected, the launcher below it](https://git.magicbean.dev/attachments/cf4947fa-b513-448b-94cf-4cca9885c31d) Taken in Gaming mode on the Deck, with the Steam tile opening the launcher and its Play starting the game (#130). Both entries read "Longshot" because the launcher's window title is `Title="Longshot"`, while the words drawn in its own title bar already say "Longshot Launcher". That is the state this PR changes: once a launcher build carries it, the second entry should read "Longshot Launcher". That capture is still owed — it needs a build, not just this diff.
madebyjordan left a comment

The code looks good at 62546c04, and I found nothing to change. This was a read-through: I did not build or run it.

  • The diff is the one Title line and matches the description. The Wayland app_id and X11 WM_CLASS still come from Shortcuts.LauncherEntryName, so the window stays paired with its menu entry.
  • Nothing depends on the old title. The launcher, Longshot and Tooling have no lookup of a window by its title, and the one test that reads MainWindow.axaml (PadChecks) only checks the Home button.
  • It merges cleanly with #202, #130 and #151. With the redesign in, the title and the drawn title bar both still say "Longshot Launcher".

Before approving: the after capture from the Deck. In the before shot the Steam tile, the game's window and the launcher's window are all named "Longshot", so it can't show that Switch Windows takes its label from the window title and not from the tile. If it uses the tile's name, this change is harmless but #130's duplicate entry stays. A Deck build of this branch showing "Longshot Launcher" in the list settles it.

The code looks good at 62546c04, and I found nothing to change. This was a read-through: I did not build or run it. - The diff is the one `Title` line and matches the description. The Wayland app_id and X11 WM_CLASS still come from `Shortcuts.LauncherEntryName`, so the window stays paired with its menu entry. - Nothing depends on the old title. The launcher, Longshot and Tooling have no lookup of a window by its title, and the one test that reads `MainWindow.axaml` (`PadChecks`) only checks the Home button. - It merges cleanly with https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/202, https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/130 and https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/151. With the redesign in, the title and the drawn title bar both still say "Longshot Launcher". **Before approving:** the after capture from the Deck. In the before shot the Steam tile, the game's window and the launcher's window are all named "Longshot", so it can't show that Switch Windows takes its label from the window title and not from the tile. If it uses the tile's name, this change is harmless but #130's duplicate entry stays. A Deck build of this branch showing "Longshot Launcher" in the list settles it.
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/launcher-window-title:omgitsgela-fix/launcher-window-title'
git switch 'omgitsgela-fix/launcher-window-title'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!224
No description provided.