fix(ui): the launcher's window is titled Longshot Launcher #224
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!224
Loading…
Reference in a new issue
No description provided.
Delete branch "omgitsgela/LongshotLauncher:fix/launcher-window-title"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why this is needed
The launcher's window is titled "Longshot", the same as the game, while the words drawn in its own title bar already say "Longshot Launcher". Anything that lists windows by their title therefore shows two entries called "Longshot" once the game runs beside the launcher — seen in Steam's Switch Windows on the Deck with the Steam tile opening the launcher and its Play starting the game (#130), and a desktop taskbar or window list has the same problem. The AppImage's menu entry already says "Longshot Launcher" (and
package.sh's does, for #118); the window title was the one place still calling the launcher by the game's name.What it does
App/MainWindow.axaml:Title="Longshot"→Title="Longshot Launcher".Nothing else moves. The Wayland app_id / X11 WM_CLASS (
Shortcuts.LauncherEntryName,longshot-launcher) still pairs the window with the launcher's own menu entry, and no appid or art keyed on a file changes.What was checked
launcher core: 2141 checks passed, with main's three red groups skipped locally (UnlistedChecksafter #208,SavesChecksafter #196,BuildReportChecks— the same aborts cleanmainshows on this host).Not yet seen on screen: the next launcher build carrying this should show "Longshot Launcher" in Steam's Switch Windows beside the game's own "Longshot".
Not in this PR
The Steam tile itself (#130). The title bar's drawn text already said "Longshot Launcher"; this only makes the window's real title agree with it.
Evidence: the two windows, before this change
Taken in Gaming mode on the Deck, with the Steam tile opening the launcher and its Play starting the game (#130). Both entries read "Longshot" because the launcher's window title is
Title="Longshot", while the words drawn in its own title bar already say "Longshot Launcher".That is the state this PR changes: once a launcher build carries it, the second entry should read "Longshot Launcher". That capture is still owed — it needs a build, not just this diff.
The code looks good at
62546c04, and I found nothing to change. This was a read-through: I did not build or run it.Titleline and matches the description. The Wayland app_id and X11 WM_CLASS still come fromShortcuts.LauncherEntryName, so the window stays paired with its menu entry.MainWindow.axaml(PadChecks) only checks the Home button.Before approving: the after capture from the Deck. In the before shot the Steam tile, the game's window and the launcher's window are all named "Longshot", so it can't show that Switch Windows takes its label from the window title and not from the tile. If it uses the tile's name, this change is harmless but #130's duplicate entry stays. A Deck build of this branch showing "Longshot Launcher" in the list settles it.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.