fix(windows): the launcher builds as one file again: the font check's DLL list takes the app's folder, not an assembly's Location (IL3000) #158
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!158
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix/single-file-il3000"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux,
dotnet publishof the Windows single file asscripts/package.shruns it · Needs: noneWhy
Every launcher Release run since #137 fails in The launcher, both systems:
So no launcher nightly has been made since #134, and v1.0.0-rc.10 (run 485) was not published.
What changed
App/FontCheck.cs,OtherModules(): the launcher's own folder isAppContext.BaseDirectory. In the shipped single fileAssembly.Locationwas always empty and the line already fell back to it, so the DLL list is the same.Checks
dotnet publish App/LongshotLauncher.csproj -c Release -r win-x64 --self-contained -p:PublishSingleFile=true -p:IncludeNativeLibrariesForSelfExtract=true -p:DebugType=nonesucceeds here (it failed with IL3000 on main in CI). No test suites were run locally.🤖 Generated with Claude Code
Post-merge note: this fix keeps
Path.GetDirectoryName(AppContext.BaseDirectory)as the "own folder" prefix.AppContext.BaseDirectoryalways ends with a directory separator (it's an app base directory), soGetDirectoryNameof it returns the parent folder — e.g./home/deckfor a launcher under/home/deck/.local/share/..., orC:\Users\xyz\AppData\Local\Programsfor an installed one.OtherModulesthen filters outown = <parent>, which drops every non-Windows module living under that parent: on the Deck that is essentially the whole home folder, so Wine/Proton-adjacent DLLs (the thing the check exists to notice) get silently excluded from the overlay-warning list.Path.GetFullPath(AppContext.BaseDirectory)gives the app's own folder (what the comment says it means) and the trailing separator doesn't matter for the StartsWith filter. Our #130 branch keeps that form and resolves the merge conflict to it deliberately. Small fix if you want it here too:var own = AppContext.BaseDirectory;(no GetDirectoryName at all) orPath.TrimEndingDirectorySeparator(AppContext.BaseDirectory).