fix(app): FontCheck asks where the launcher runs from, not where its assembly lies #144
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!144
Loading…
Reference in a new issue
No description provided.
Delete branch "omgitsgela/LongshotLauncher:fix/single-file-fontcheck-il3000"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
main has not built since #137 merged. The release job ("The launcher, both systems") fails on every push to main — actions run 448 and run 455, same line both times:
The last published nightling is
nightly-100-5f30eea3; nothing since has been built or published.What and why
#137addedApp/FontCheck.cs(the Windows no-fonts report). ItsOtherModules()takes the launcher's own folder asPath.GetDirectoryName(typeof(SKFontManager).Assembly.Location …). The launcher ships as a single-file app (package.shline 51 setsPublishSingleFile=true), and in a single-file app an embedded assembly has no path on disk —Assembly.Locationreturns "". Newer .NET 10 SDKs promoted that read to analyzer error IL3000, andDirectory.Build.propssetsTreatWarningsAsErrors=true, so the build dies in CI.This was latent from the day #137 merged: an SDK old enough not to flag it builds fine (
dotnet buildon my host passes even today), which is how it slipped through review. The runner'ssetup-dotnet 10.0.xpicked up an SDK that flags it, and both pushes to main since have been red.The fix is the one the analyzer itself points at: take the folder the launcher runs from (
AppContext.BaseDirectory), which is what the code's own fallback already meant. The report's meaning is unchanged —OtherModules()lists modules that are neither Windows' nor the launcher's own, and the process module list still carries complete paths for every loaded DLL in a single-file app. TheSkiaSharpimport is still used bySkiaFamilies()(line 116), so this commit does not touch the usings.Proven locally, not just argued
Reproduced the failure and the fix with the real packaging path on a clean
origin/main(5d86f319) worktree:scripts/package.shresultIL3000, zero artifacts produced (the Linux AppImage publish dies on the same error, so a Deck build is blocked too)Suites on the fixed tree:
launcher core: 1374 checks passed;test_release.pyRan 34 tests … OK. (The core count is main's, without #130's additions.)Scope
One expression, no behaviour intended to change — with one verified nuance, in this change's favour. In a single-file build the old expression's fallback always ran (
Locationis""), andGetDirectoryNameofBaseDirectoryyields the app folder without its trailing separator (probed, not assumed:GetDirectoryName("/dir/App/")→/dir/App, not/dir). The old prefix therefore swallowed sibling folders whose names start with the launcher's own:/dir/App2/injected.dllpassesStartsWith("/dir/App")but notStartsWith("/dir/App/"). The fix's trailing-separator form makes the filter a true directory boundary — it narrowsOtherModules' blind spot rather than widening it. If HumanBean meant the directory containing SkiaSharp specifically in a non-single-file build: that distinction is moot for whatOtherModulesreports — SkiaSharp ships in the launcher's folder, and its native library is separately excused two lines below.Delegated adversarial review ran (deepseek-flash route; the Astra subscription route was rate-capped at the time): verdict safe to merge as-is, no change requested. Its single novel mechanism claim (old code yielding the parent folder) is refuted by the probe above; the boundary improvement it gestured at is real and stated here in its verified form.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.