WIP: fix(mods): raise the size table entries of the files inside the packs mods serve #942

Draft
snaildev99 wants to merge 19 commits from snaildev99/Longshot:mods/pack-members into main
Contributor

Type: fix · Risk: low · Tested on: Windows 11, RTX 3090 (in the game, and the game-free checks) · Needs: Linux, any GPU: one game-free test

Why

The game loads each file inside an actor pack (Pack/Actor/*.pack.zs) as a resource of its own, with memory sized
by that file's own entry in the resource size table, and the game's entries leave no room to spare. #134's merge
sized loose files only. So a mod that changes a file inside a pack and ships no size table (or one made for an older
version of the mod) loads that file, runs out of room for what the game builds from it, and the game sits at a
loading screen for ever. Character Select hit exactly this once (the adult player's animation parameters, fixed by
hand in its own table since). Depends on #134.

How to reproduce

Seen on: Windows, an emulator and #134's merge alike (the hang is the game's, not the host's)
Settings and switches: defaults
Steps: a mod that adds a few fields to a member of Pack/Actor/Player_Adult.pack.zs (e.g. the adult's
AnimationParam) and ships no size table; play as adult Link through a load
Expected: the area loads
Actual: the loading screen never ends

What changed

At each start with mods, every pack a mod serves is compared with the game's copy, and the entry of each file in it
that grew, or that the game's pack does not have, is raised before the merged table is written.

  • size table: restbl_sarc_each and restbl_pack_raise in host/restbl.c (after valentderah/totk-pc-recomp
    runtime/restbl.c, MIT, credited in the header): grown members by restbl_grow, new ones by restbl_estimate.
  • mods: pack_members() in host/mods.c, called from fit_sizes() for every served .pack.zs; packs are read with
    host/zs.c, which already decodes frames made with the game's dictionaries. An unreadable pack is named in the
    log; the summary line counts members and packs.
  • size table: restbl_grow gives a grown BYML parameter file (.bgyml, .byml) at least 8 entry bytes for each byte it grew, plus 4 KiB: their list elements cost far more in the heap than in the file (fits over the game's own 5,772 files of two such types are in the commit message). In proportion, as for other types, was not enough in the game (Testing). This holds for loose files too; it only ever raises.
  • mods: the summary line gives the merge's time in parts (the mods' tables, the files, of which the packs, writing).
  • docs: the README's Mods section and docs/mods.md.

Measurements

Verdict: a few packs add 10 to 15 ms to the start (10 ms of 278 in the game); 200 packs about 40 ms. No entry is raised for packs as the
game's.

Hardware: Windows 11, the PC the checks ran on
Scene: none (a host-side step at the start)
Method: a local harness (not in this PR) running restbl_pack_raise with host/zs.c on real packs against the game's
copies and table, 3 runs after a warm-up, dictionaries loaded once before; the range
How to reproduce: build host/restbl.c, host/zs.c and zstd's decoder with a small main that reads each mod pack and
the game's copy and calls restbl_pack_raise

Before: #134 @ fb2a419c After: this PR @ c4399147
Character mod, 9 packs: entries raised 0 21 (both player AnimationParams among them)
Character mod, 9 packs: time 0 ms 14.6-15.3 ms
200 stock packs served unchanged: time / raised 0 ms / 0 38-42 ms / 0
In the game, the same mod with a stale table: the merge's line (169-258 ms on earlier runs) 278 ms (tables 58, files 217 of which packs 10, writing 2); 21 entries for the members of 5 packs

Flags and settings

None

Testing

Tested:

  • In the game, Windows 11, RTX 3090 (driver 610.88), a build of #134's head with this branch merged in, and a character mod (6,903 files, 5 actor packs) whose own size table had the entries of nine grown pack members put back to the game's (a stale table). With the first cut of this branch (growth in proportion) the game crashed while loading the adult player's pack: the grown phive__ControllerSetParam got 125,664 where 365,136 is known to load. With the BYML rule the same start raises it to 365,152 (the cloth parameters to 851,072), the adult save loads, and animations and cloth are normal in the field and in the menu.
  • Windows, game-free: tests/test_mods_packs.py (new): restbl_pack_raise on made-up packs (grown,
    equal, smaller, streamed, .zs and new members; a pack the game lacks; a larger entry kept; unreadable archives), and
    host/mods.c over a made-up game folder whose packs use a dictionary like the game's (trained by the test). It fails
    on the base and passes here. tests/run_all.py: no new failures against the base.

Not tested: the test's Linux half (host/posix, as tests/test_mods_size_table.py).

Must be tested:

  • Linux, any GPU: python -I -B tests/test_mods_packs.py (with the zstandard package), expecting PASS: the members of the packs mods serve (Test Farm: @Beanstalk linux, run tests/test_mods_packs.py)

Risks

What could break: a start with a mod that serves packs takes a little longer (above); a pack that cannot be read is
left as before and named in the log. A grown BYML file's heap is about twice what it needs (memory, a few hundred KiB for a large mod). A BYML file whose new elements are much smaller in the file than as objects could still need more than 8 a byte: such a mod's own table still wins when it is larger. A file new to a pack gets an estimate even when the game lists its path (its own copy is in another actor's pack, which is not read): larger than the game's entry, never smaller.

Turning it off: revert the commit.

Compatibility: Nothing changes for mods without packs; modcache/rsizetable.zs is written again at the next start.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main. (on #134's head)
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (Windows here; Linux by the test above)
  • Docs updated.

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Windows 11, RTX 3090 (in the game, and the game-free checks) · **Needs:** Linux, any GPU: one game-free test ## Why The game loads each file inside an actor pack (`Pack/Actor/*.pack.zs`) as a resource of its own, with memory sized by that file's own entry in the resource size table, and the game's entries leave no room to spare. #134's merge sized loose files only. So a mod that changes a file inside a pack and ships no size table (or one made for an older version of the mod) loads that file, runs out of room for what the game builds from it, and the game sits at a loading screen for ever. Character Select hit exactly this once (the adult player's animation parameters, fixed by hand in its own table since). Depends on #134. ## How to reproduce **Seen on:** Windows, an emulator and #134's merge alike (the hang is the game's, not the host's) **Settings and switches:** defaults **Steps:** a mod that adds a few fields to a member of `Pack/Actor/Player_Adult.pack.zs` (e.g. the adult's AnimationParam) and ships no size table; play as adult Link through a load **Expected:** the area loads **Actual:** the loading screen never ends ## What changed At each start with mods, every pack a mod serves is compared with the game's copy, and the entry of each file in it that grew, or that the game's pack does not have, is raised before the merged table is written. - size table: `restbl_sarc_each` and `restbl_pack_raise` in `host/restbl.c` (after valentderah/totk-pc-recomp `runtime/restbl.c`, MIT, credited in the header): grown members by `restbl_grow`, new ones by `restbl_estimate`. - mods: `pack_members()` in `host/mods.c`, called from `fit_sizes()` for every served `.pack.zs`; packs are read with `host/zs.c`, which already decodes frames made with the game's dictionaries. An unreadable pack is named in the log; the summary line counts members and packs. - size table: `restbl_grow` gives a grown BYML parameter file (`.bgyml`, `.byml`) at least 8 entry bytes for each byte it grew, plus 4 KiB: their list elements cost far more in the heap than in the file (fits over the game's own 5,772 files of two such types are in the commit message). In proportion, as for other types, was not enough in the game (Testing). This holds for loose files too; it only ever raises. - mods: the summary line gives the merge's time in parts (the mods' tables, the files, of which the packs, writing). - docs: the README's Mods section and `docs/mods.md`. ## Measurements **Verdict:** a few packs add 10 to 15 ms to the start (10 ms of 278 in the game); 200 packs about 40 ms. No entry is raised for packs as the game's. Hardware: Windows 11, the PC the checks ran on Scene: none (a host-side step at the start) Method: a local harness (not in this PR) running `restbl_pack_raise` with `host/zs.c` on real packs against the game's copies and table, 3 runs after a warm-up, dictionaries loaded once before; the range How to reproduce: build `host/restbl.c`, `host/zs.c` and zstd's decoder with a small main that reads each mod pack and the game's copy and calls `restbl_pack_raise` | | Before: #134 @ fb2a419c | After: this PR @ c4399147 | |---|---|---| | Character mod, 9 packs: entries raised | 0 | 21 (both player AnimationParams among them) | | Character mod, 9 packs: time | 0 ms | 14.6-15.3 ms | | 200 stock packs served unchanged: time / raised | 0 ms / 0 | 38-42 ms / 0 | | In the game, the same mod with a stale table: the merge's line | (169-258 ms on earlier runs) | 278 ms (tables 58, files 217 of which packs 10, writing 2); 21 entries for the members of 5 packs | ### Flags and settings None ## Testing **Tested:** - In the game, Windows 11, RTX 3090 (driver 610.88), a build of #134's head with this branch merged in, and a character mod (6,903 files, 5 actor packs) whose own size table had the entries of nine grown pack members put back to the game's (a stale table). With the first cut of this branch (growth in proportion) the game crashed while loading the adult player's pack: the grown `phive__ControllerSetParam` got 125,664 where 365,136 is known to load. With the BYML rule the same start raises it to 365,152 (the cloth parameters to 851,072), the adult save loads, and animations and cloth are normal in the field and in the menu. - Windows, game-free: `tests/test_mods_packs.py` (new): `restbl_pack_raise` on made-up packs (grown, equal, smaller, streamed, `.zs` and new members; a pack the game lacks; a larger entry kept; unreadable archives), and `host/mods.c` over a made-up game folder whose packs use a dictionary like the game's (trained by the test). It fails on the base and passes here. `tests/run_all.py`: no new failures against the base. **Not tested:** the test's Linux half (host/posix, as `tests/test_mods_size_table.py`). **Must be tested:** - Linux, any GPU: `python -I -B tests/test_mods_packs.py` (with the zstandard package), expecting `PASS: the members of the packs mods serve` (Test Farm: @Beanstalk linux, run tests/test_mods_packs.py) ## Risks **What could break:** a start with a mod that serves packs takes a little longer (above); a pack that cannot be read is left as before and named in the log. A grown BYML file's heap is about twice what it needs (memory, a few hundred KiB for a large mod). A BYML file whose new elements are much smaller in the file than as objects could still need more than 8 a byte: such a mod's own table still wins when it is larger. A file new to a pack gets an estimate even when the game lists its path (its own copy is in another actor's pack, which is not read): larger than the game's entry, never smaller. **Turning it off:** revert the commit. **Compatibility:** Nothing changes for mods without packs; `modcache/rsizetable.zs` is written again at the next start. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [ ] Rebased on current `main`. (on #134's head) - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. - [ ] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (Windows here; Linux by the test above) - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Mods that each grow files (HD texture packs) could not be combined: only one
resource size table was used. Hookshot now merges every enabled mod's table
into the game's at start (the button prompts' entries kept) and raises the
entry of every file a mod serves to fit its size (host/mods.c, host/restbl.c,
host/zs.c). #2270's merge of the prompts' entries into the winning mod's table
stays as the fallback when no merged table can be made.

The Insert menu gets a Mods tab (shown only when there are mods): each mod on
or off and its place in the list, kept in hookshot_mods.txt and applied at the
next start (the restart question names them), and the cheats of the enabled
mods, switched at once.

ExeFS patches (IPS, IPS32, IPSwitch .pchtxt) are applied to main's image when
the game is built (nx2/exefs_patches.py, nx2/image.py), so the code is
translated from the patched instructions; a write into the padding after the
code (a code cave) makes it code. exefs_patches.txt in the game folder lists
what a build applied; the Mods tab says when a patch waits for a build.

Atmosphere cheat-code files (separate from the Debug tab's built-in cheats)
run in a cheat VM after dmnt's (host/cheats.c), every presented frame, on
guest memory the game was given; cheats that write the game's code are
listed as not supported.

The list, order and switches, the size table's merge, the patch formats and
the cheat VM follow valentderah/totk-pc-recomp (MIT), whose notice is kept in
host/restbl.h and nx2/exefs_patches.py.

Co-authored-by: Valiantsin Dzerakh <[email protected]>
Co-authored-by: conongnang <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
The control bridge's bridge_fill names each MenuTab and checks the count: with the Mods tab
added before Debug, its table needs "mods" there.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
The compact bar (added to main after the Mods tab was written) draws the
selected row of the current tab. The Mods tab has no such rows: its lines come
from the host. With the bar asked for on the Mods tab the full page is drawn.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
- hos_mods_file gives prompts.c no table when the merged one is served.
- A mod that is off: its ExeFS files are not counted as waiting for a build
  (the Mods tab's text and the log's line).
- The Mods tab's texts and longshot_mods.txt's header say Longshot.
- A Restart or Quit waiting for its second press is cleared on the Mods tab.
- The merged size table: a mod file whose path is in another case than the
  game's takes the game's entry (looked up only when the mod's own case
  misses the table).
- exefs_patches.py: bytes into a relocated word are left out and the file's
  note says so; the comment on DT_RELR words says what happens.
- The compact bar on the Mods tab dims the game behind, as the full menu.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
Co-Authored-By: Claude Fable 5.2 <[email protected]>
The test cuts restart_values out of vk_menu.cpp; with the Mods tab that
function also fills the mods' slot, so the harness declares the slot (none
here), can_mods and the host's mods_changed beside its pad_raw.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
docs(mods): the file contract's document and its example follow the Mods tab, the merged table and ExeFS patches
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
5192b46f4b
docs/mods.md (from #93) describes the loader as it was: ExeFS left out, one
mod's size table, no Mods tab. With this branch an exefs folder's patches
belong to the build, the size table is merged at a start, and the Mods tab's
longshot_mods.txt can change the order and the switches; without that file
the order is the documented one. The example's check for the old ExeFS log
line now looks for the line that lists the mod with its ExeFS folder.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
The game loads each file inside an actor pack (Pack/Actor/x.pack.zs, a SARC
archive) as a resource of its own, in a heap sized by that file's own entry
in the resource size table, and the stock entries fit to the byte. The merge
sized loose files only (restbl.c said the packs are sized as a whole, which
is not so for this game: nearly every member has its own entry). A mod that
grows a file inside a pack and ships no table, or a stale one, kept the
game's entry: the file loads, the heap runs out for what is parsed out of
it, a loading thread fails on a null object and the game waits at a loading
screen for ever.

restbl.c gets restbl_sarc_each and restbl_pack_raise, after
valentderah/totk-pc-recomp runtime/restbl.c (MIT, the notice is in
restbl.h): a member that grew against the game's copy of the pack is raised
by restbl_grow, a member the game's copy lacks gets restbl_estimate, the
others are left alone. host/mods.c's fit_sizes calls it (pack_members) for
every pack a mod serves, reading both packs with host/zs.c, which already
decodes frames made with the game's dictionaries. A pack that cannot be read
is named in the log and its members keep their entries; the summary line
counts the members and packs raised, and up to 16 lines name them.

Measured on this game's own files (a local harness, nothing committed): the
nine packs of a character mod that grows the player's parameter files take
15 ms and raise 21 entries, among them the two whose growth once hung a
loading screen; 200 stock packs served unchanged take about 40 ms and raise
none.

tests/test_mods_packs.py checks restbl_pack_raise on made-up packs (grown,
equal, smaller, streamed, .zs and new members, a new pack, an entry already
larger, unreadable archives) and host/mods.c over a made-up game folder whose
packs use a trained dictionary as the game's do. It fails on the base (no
restbl_pack_raise; with it, the grown member keeps the game's entry) and
passes here.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
fix(mods): a grown BYML file's entry: at least 8 bytes a byte grown; the merge's time in parts
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
8b3e555cbe
A run in the game crashed with the previous commit: a character mod whose
own size table was set back to the game's entries for the files inside its
packs (the case this branch is for) loaded the adult player's pack and its
loading thread failed on a null object, the heap of the player's
ControllerSetParam run out. That file had grown from 15,256 to 56,116 bytes
by 555 cloth reactions and options; growth in proportion gave 125,664.

What a BYML parameter file adds is mostly list elements, which the game
builds into objects that cost far more than their bytes. Least squares over
the game's own files: ControllerSetParam (5,602 files) 6,619 + 1.04 a byte +
60 to 180 an element of each list, at most 319 off; ClothParam (170 files)
4,653 + 1.90 a byte + 289 a mesh + 31 a collision shape, at most 784 off. For
the crashed file the fit asks about 178,600 (3.5 a byte grown). restbl_grow
now gives a grown .bgyml or .byml file at least 8 entry bytes for each byte it
grew, plus 4 KiB: twice the fits' need for such growth, and the rule the
character mod's own builder uses, whose entries for these files load in the
game (365,136 for the crashed file; the new rule gives 365,152). Other types
(.ainb and the physics binaries, about 1 a byte in the game's table) keep
the proportion. This applies to loose BYML files that grow too; it only
ever raises an entry.

The merge's log line now gives its time in parts (the mods' tables, the
files, the packs among them, writing): a start with the 1 GB character mod
took 7 to 9 s in the game where a harness over the same folder takes 250 ms
(tables 53, files 195 of which packs 10), and the next run should say which
part the game's seconds are.

tests/test_mods_packs.py adds a member of the crashed file's shape (made-up
sizes) that must get at least 8 a byte grown plus 4 KiB and more than twice
the proportion, and an .ainb member that keeps the proportion; it fails with
the previous commit's restbl.c and passes here.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

Tested in game: Windows 11, RTX 3090 (driver 610.88), a build of #134's head 4f8b975d with this branch merged in, a character mod with 5 actor packs whose own size table had nine pack members' entries put back to the game's: the start's log raises 21 entries for the members of 5 packs (the adult player's ControllerSetParam 34160 -> 365152), the adult save loads, animations and cloth are normal; the merge took 278 ms, 10 of it the packs. The first cut (growth in proportion) crashed at that load, which is why BYML files grow by 8 a byte now. This branch is stacked on #134 (it depends on it), so the diff shows #134's commits too until that merges.

Tested in game: Windows 11, RTX 3090 (driver 610.88), a build of #134's head 4f8b975d with this branch merged in, a character mod with 5 actor packs whose own size table had nine pack members' entries put back to the game's: the start's log raises 21 entries for the members of 5 packs (the adult player's ControllerSetParam 34160 -> 365152), the adult save loads, animations and cloth are normal; the merge took 278 ms, 10 of it the packs. The first cut (growth in proportion) crashed at that load, which is why BYML files grow by 8 a byte now. This branch is stacked on #134 (it depends on it), so the diff shows #134's commits too until that merges.
Author
Contributor

The measurements table's columns name their commits now (#134 @ 5192b46f, this PR @ 8b3e555c; the numbers were taken on the heads before the rebase onto it, which changed nothing in these files).

The measurements table's columns name their commits now (#134 @ 5192b46f, this PR @ 8b3e555c; the numbers were taken on the heads before the rebase onto it, which changed nothing in these files).
snaildev99 force-pushed mods/pack-members from 8b3e555cbe
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 1b90cf203b
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-16 02:50:49 +00:00
Compare
snaildev99 force-pushed mods/pack-members from 1b90cf203b
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 2e2f9fb5a6
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
2026-11-16 02:51:05 +00:00
Compare
Author
Contributor

Moved onto #134's new head fafc7ab2 (it was rebased onto main @ 343a1dfa): head 2e2f9fb5. No conflict. One line more in tests/test_mods_packs.py: main's host/mods.c asks texts.c for a path now (#604), so the test's fixture has a stand-in for hos_texts_romfs beside the one for the prompts. The test passes; not built or played at this head; the measurements were taken on the heads before the move, which changed nothing in these files.

Moved onto #134's new head fafc7ab2 (it was rebased onto main @ 343a1dfa): head 2e2f9fb5. No conflict. One line more in tests/test_mods_packs.py: main's host/mods.c asks texts.c for a path now (#604), so the test's fixture has a stand-in for hos_texts_romfs beside the one for the prompts. The test passes; not built or played at this head; the measurements were taken on the heads before the move, which changed nothing in these files.
Author
Contributor

Moved onto #134's new head fb2a419c (rebased onto main @ e4d035e9; the Mods tab's functions are API version 25 there, after main's audio outputs): head c4399147. No conflict, no change in this branch's own files; its tests pass at this head. Not built or played at it.

Moved onto #134's new head fb2a419c (rebased onto main @ e4d035e9; the Mods tab's functions are API version 25 there, after main's audio outputs): head c4399147. No conflict, no change in this branch's own files; its tests pass at this head. Not built or played at it.
snaildev99 force-pushed mods/pack-members from 2e2f9fb5a6
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to c4399147f6
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 8s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-16 04:27:31 +00:00
Compare
snaildev99 force-pushed mods/pack-members from c4399147f6
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 8s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 6e5e80128a
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 14s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-16 10:12:51 +00:00
Compare
Author
Contributor

Moved onto #134's new head 3fbc327a (the list of mods is mods.json there now: #134 (comment)). Head 6e5e8012.

No conflict; the commits are unchanged. One commit on top: tests/test_mods_packs.py builds host/mods_list.c and has a stand-in for hos_options_file (and for Sleep in the Linux fixture).

tests/run_all.py on Windows: nothing fails that #134's head passes. Not built or played at this head; the Linux halves of the changed fixtures were read, not run.

Moved onto #134's new head 3fbc327a (the list of mods is `mods.json` there now: https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/134#issuecomment-34804). Head **6e5e8012**. No conflict; the commits are unchanged. One commit on top: `tests/test_mods_packs.py` builds `host/mods_list.c` and has a stand-in for `hos_options_file` (and for `Sleep` in the Linux fixture). `tests/run_all.py` on Windows: nothing fails that #134's head passes. Not built or played at this head; the Linux halves of the changed fixtures were read, not run.
snaildev99 force-pushed mods/pack-members from 6e5e80128a
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 14s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 28067b8fa1
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 8s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-16 11:19:36 +00:00
Compare
Author
Contributor

Moved onto #134's new head 2b52cd1b (#134 was rebased onto main @ 8a4aa282: the Mods tab's functions are API version 26, and the patches' hash is named in the lift's key after main's #22: #134 (comment)). Head 28067b8f.

No conflict; the commits are unchanged.

tests/run_all.py on Windows: nothing fails that #134's head passes. Not built or played at this head.

Moved onto #134's new head 2b52cd1b (#134 was rebased onto main @ 8a4aa282: the Mods tab's functions are API version 26, and the patches' hash is named in the lift's key after main's #22: https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/134#issuecomment-35102). Head **28067b8f**. No conflict; the commits are unchanged. `tests/run_all.py` on Windows: nothing fails that #134's head passes. Not built or played at this head.
snaildev99 force-pushed mods/pack-members from 28067b8fa1
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 8s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 7fb78c60e5
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 5s
2026-11-16 19:47:30 +00:00
Compare
Author
Contributor

Moved onto #134's new head c5cead8d (#134 was rebased onto main @ ac778751 and brings main's new players' mods guide in line with it: #134 (comment)). Head 7fb78c60.

No conflict; the commits are unchanged.

Nothing fails in tests/run_all.py on Windows that #134's head passes. Not built or played at this head.

Moved onto #134's new head c5cead8d (#134 was rebased onto main @ ac778751 and brings main's new players' mods guide in line with it: https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/134#issuecomment-37590). Head **7fb78c60**. No conflict; the commits are unchanged. Nothing fails in `tests/run_all.py` on Windows that #134's head passes. Not built or played at this head.
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 5s
This pull request is marked as a work in progress.
Some workflows are waiting to be reviewed.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'mods/pack-members:snaildev99-mods/pack-members'
git switch 'snaildev99-mods/pack-members'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!942
No description provided.