fix(vk): use vertex divisors only when vertexAttributeInstanceRateDivisor is supported #919

Open
jcabarca wants to merge 3 commits from jcabarca/Longshot:fix/vk-vertex-divisor into main
Contributor

Type: fix · Risk: low · Tested on: Windows, AMD Radeon RX 9070 XT · Needs: none

Why

On a GPU that has VK_EXT_vertex_attribute_divisor but reports the vertexAttributeInstanceRateDivisor feature as off, the pipelines still chained instance-rate divisors over 1, which breaks VUID-VkVertexInputBindingDivisorDescription-vertexAttributeInstanceRateDivisor-02229; what such a driver draws for those instances is undefined.

How to reproduce

Seen on: not seen in the game: found by reading create_device() in gpu/vk/vk_main.cpp; it happens on any device that exposes the extension with the feature off (the RX 9070 XT reports the feature, so it does not show there)
Settings and switches: defaults
Steps: game-free: python -I -B tests/test_vertex_divisor_feature.py on main (copy the test from this PR); it reads create_device() in vk_main.cpp and the divisor chain in vk_draw.cpp
Expected: dev.vertex_divisor is on only when the device reports vertexAttributeInstanceRateDivisor
Actual: on main it is on whenever the extension is there; the test fails

What changed

create_device() now turns dev.vertex_divisor off when the queried feature struct says vertexAttributeInstanceRateDivisor is not supported, the same way the lines around it already do for nullDescriptor and provokingVertexLast.

  • vk: create_device() in gpu/vk/vk_main.cpp: one line, dev.vertex_divisor = dev.vertex_divisor && vdiv.vertexAttributeInstanceRateDivisor;, after vkGetPhysicalDeviceFeatures2 and before vkCreateDevice.
  • tests: tests/test_vertex_divisor_feature.py (new): checks that line, its place between the feature query and vkCreateDevice, and that the pipelines chain divisors only under dev.vertex_divisor.

Second commit, "cap the vertex divisor at maxVertexAttribDivisor":

  • vk: dev.max_vertex_divisor in gpu/vk/vk_internal.h, read in gpu/vk/vk_main.cpp from VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT::maxVertexAttribDivisor (chained into vkGetPhysicalDeviceProperties2) when dev.vertex_divisor is set.
  • vk: gpu/vk/vk_draw.cpp: the binding's divisor is std::min(s.vstream[b].divisor, dev.max_vertex_divisor).
  • tests: tests/test_vertex_divisor_feature.py checks the query and the cap.

The divisor came from the game with no upper bound. VUID-VkVertexInputBindingDivisorDescription-divisor-01870: "divisor must be a value between 0 and VkPhysicalDeviceVertexAttributeDivisorProperties::maxVertexAttribDivisor, inclusive".

The bug, step by step:

  1. create_device() sets dev.vertex_divisor when VK_EXT_vertex_attribute_divisor is in the device's extension list, and chains its feature struct (vdiv) into the device as vkGetPhysicalDeviceFeatures2 filled it.
  2. It never reads vdiv.vertexAttributeInstanceRateDivisor back, so on a device with the extension and that feature off, dev.vertex_divisor stays on.
  3. The pipeline build in vk_draw.cpp then chains every vertex stream's divisor, also the ones over 1: if (dev.vertex_divisor) vdivs.push_back({b, s.vstream[b].divisor});.
  4. A divisor over 1 with the feature not enabled breaks the rule below.

The rule, from Khronos validusage.json:

  • VUID-VkVertexInputBindingDivisorDescription-vertexAttributeInstanceRateDivisor-02229: "If the vertexAttributeInstanceRateDivisor feature is not enabled, divisor must be 1"

Before:

    dev.provoking_vertex = dev.provoking_vertex && pv.provokingVertexLast;
    dev.conditional_rendering = dev.conditional_rendering && cond.conditionalRendering;

After:

    dev.provoking_vertex = dev.provoking_vertex && pv.provokingVertexLast;
    dev.vertex_divisor = dev.vertex_divisor && vdiv.vertexAttributeInstanceRateDivisor;   // (a divisor over 1 needs the feature, not only the extension)
    dev.conditional_rendering = dev.conditional_rendering && cond.conditionalRendering;

With the flag off, the existing path takes over: the divisor is logged as "(not supported: 1)" and no divisor struct is chained, so every instance reads with the default divisor 1.

Measurements

Verdict: it fixes the bug: test_vertex_divisor_feature fails on main and passes here. Both interleaved runs gave the same result. No speed change is expected.

Hardware: AMD Radeon RX 9070 XT, Windows; the tests are game-free (they read source or build a cut-out fixture, they do not use the GPU); Python 3.12
Scene: none, game-free
Method: the tests from this PR run against each side's checkout, 2 runs each, interleaved (main, PR, main, PR); the result is pass/fail, so the median is the result both runs gave
How to reproduce: python -I -B tests/<test>.py with --source <checkout> (and --cxx/--headers where the test asks for them) on each side

Before: main @ c167ec67 After: this PR @ c6c38854
tests/test_vertex_divisor_feature.py, run 1 fails passes
tests/test_vertex_divisor_feature.py, run 2 fails passes
tests/test_vertex_divisor_feature.py, median fails passes
run 1, main @ c167ec67:
test_vertex_divisor_feature          exit 1
dev.vertex_divisor is set by the extension alone, not by vertexAttributeInstanceRateDivisor
run 1, this PR @ c6c38854:
vertex divisors over 1 are used only with vertexAttributeInstanceRateDivisor, up to maxVertexAttribDivisor: ok
test_vertex_divisor_feature          exit 0
run 2, main @ c167ec67:
test_vertex_divisor_feature          exit 1
dev.vertex_divisor is set by the extension alone, not by vertexAttributeInstanceRateDivisor
run 2, this PR @ c6c38854:
vertex divisors over 1 are used only with vertexAttributeInstanceRateDivisor, up to maxVertexAttribDivisor: ok
test_vertex_divisor_feature          exit 0

Flags and settings

None.

Testing

Tested: on this branch, Windows, Python 3.12: test_vertex_divisor_feature passes (fails on main), and the other check that reads the divisor flag passes: test_fallback_pipeline_state.

Built and played: this commit builds on Windows (llvm-mingw back end) and on Linux (longshot_vk.so, without and with AMD FSR 4). Played on Windows, AMD Radeon RX 9070 XT: the game runs normally.

Not tested: a device with the extension and the feature off: none was at hand (the RX 9070 XT reports the feature, so the change does nothing there). Linux was built, not run.

Must be tested: None: the game-free test covers the change, and on devices that report the feature nothing changes.

Risks

What could break: on a device with the extension and the feature off, streams with a divisor over 1 now read with divisor 1, as they already do on devices without the extension. Before, the same pipelines broke the rule above, so what they drew was undefined anyway. Devices that report the feature are unchanged.

Turning it off: revert the commit.

Compatibility: Nothing changes.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched). (no issue fits)
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named). (the checks that read the changed code, on this PR, Windows: test_vertex_divisor_feature, test_fallback_pipeline_state, all pass)
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here. (tests/test_vertex_divisor_feature.py)
  • A check under tests/ that reads changed source updated in this PR, not weakened. (tests/test_vertex_divisor_feature.py added; no check removed)
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (built on Windows with llvm-mingw and on Linux, longshot_vk.so without and with AMD FSR 4)
**Type:** fix · **Risk:** low · **Tested on:** Windows, AMD Radeon RX 9070 XT · **Needs:** none ## Why On a GPU that has VK_EXT_vertex_attribute_divisor but reports the vertexAttributeInstanceRateDivisor feature as off, the pipelines still chained instance-rate divisors over 1, which breaks VUID-VkVertexInputBindingDivisorDescription-vertexAttributeInstanceRateDivisor-02229; what such a driver draws for those instances is undefined. ## How to reproduce **Seen on:** not seen in the game: found by reading `create_device()` in `gpu/vk/vk_main.cpp`; it happens on any device that exposes the extension with the feature off (the RX 9070 XT reports the feature, so it does not show there) **Settings and switches:** defaults **Steps:** game-free: `python -I -B tests/test_vertex_divisor_feature.py` on main (copy the test from this PR); it reads `create_device()` in `vk_main.cpp` and the divisor chain in `vk_draw.cpp` **Expected:** `dev.vertex_divisor` is on only when the device reports `vertexAttributeInstanceRateDivisor` **Actual:** on main it is on whenever the extension is there; the test fails ## What changed `create_device()` now turns `dev.vertex_divisor` off when the queried feature struct says `vertexAttributeInstanceRateDivisor` is not supported, the same way the lines around it already do for `nullDescriptor` and `provokingVertexLast`. - vk: `create_device()` in `gpu/vk/vk_main.cpp`: one line, `dev.vertex_divisor = dev.vertex_divisor && vdiv.vertexAttributeInstanceRateDivisor;`, after `vkGetPhysicalDeviceFeatures2` and before `vkCreateDevice`. - tests: `tests/test_vertex_divisor_feature.py` (new): checks that line, its place between the feature query and `vkCreateDevice`, and that the pipelines chain divisors only under `dev.vertex_divisor`. Second commit, "cap the vertex divisor at maxVertexAttribDivisor": - vk: `dev.max_vertex_divisor` in `gpu/vk/vk_internal.h`, read in `gpu/vk/vk_main.cpp` from `VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT::maxVertexAttribDivisor` (chained into `vkGetPhysicalDeviceProperties2`) when `dev.vertex_divisor` is set. - vk: `gpu/vk/vk_draw.cpp`: the binding's divisor is `std::min(s.vstream[b].divisor, dev.max_vertex_divisor)`. - tests: `tests/test_vertex_divisor_feature.py` checks the query and the cap. The divisor came from the game with no upper bound. VUID-VkVertexInputBindingDivisorDescription-divisor-01870: "divisor must be a value between 0 and VkPhysicalDeviceVertexAttributeDivisorProperties::maxVertexAttribDivisor, inclusive". The bug, step by step: 1. `create_device()` sets `dev.vertex_divisor` when VK_EXT_vertex_attribute_divisor is in the device's extension list, and chains its feature struct (`vdiv`) into the device as `vkGetPhysicalDeviceFeatures2` filled it. 2. It never reads `vdiv.vertexAttributeInstanceRateDivisor` back, so on a device with the extension and that feature off, `dev.vertex_divisor` stays on. 3. The pipeline build in `vk_draw.cpp` then chains every vertex stream's divisor, also the ones over 1: `if (dev.vertex_divisor) vdivs.push_back({b, s.vstream[b].divisor});`. 4. A divisor over 1 with the feature not enabled breaks the rule below. The rule, from Khronos `validusage.json`: - VUID-VkVertexInputBindingDivisorDescription-vertexAttributeInstanceRateDivisor-02229: "If the vertexAttributeInstanceRateDivisor feature is not enabled, divisor must be 1" Before: ```cpp dev.provoking_vertex = dev.provoking_vertex && pv.provokingVertexLast; dev.conditional_rendering = dev.conditional_rendering && cond.conditionalRendering; ``` After: ```cpp dev.provoking_vertex = dev.provoking_vertex && pv.provokingVertexLast; dev.vertex_divisor = dev.vertex_divisor && vdiv.vertexAttributeInstanceRateDivisor; // (a divisor over 1 needs the feature, not only the extension) dev.conditional_rendering = dev.conditional_rendering && cond.conditionalRendering; ``` With the flag off, the existing path takes over: the divisor is logged as "(not supported: 1)" and no divisor struct is chained, so every instance reads with the default divisor 1. ## Measurements **Verdict:** it fixes the bug: `test_vertex_divisor_feature` fails on main and passes here. Both interleaved runs gave the same result. No speed change is expected. Hardware: AMD Radeon RX 9070 XT, Windows; the tests are game-free (they read source or build a cut-out fixture, they do not use the GPU); Python 3.12 Scene: none, game-free Method: the tests from this PR run against each side's checkout, 2 runs each, interleaved (main, PR, main, PR); the result is pass/fail, so the median is the result both runs gave How to reproduce: `python -I -B tests/<test>.py` with `--source <checkout>` (and `--cxx`/`--headers` where the test asks for them) on each side | | Before: main @ c167ec67 | After: this PR @ c6c38854 | |---|---|---| | `tests/test_vertex_divisor_feature.py`, run 1 | fails | passes | | `tests/test_vertex_divisor_feature.py`, run 2 | fails | passes | | `tests/test_vertex_divisor_feature.py`, median | fails | passes | ``` run 1, main @ c167ec67: test_vertex_divisor_feature exit 1 dev.vertex_divisor is set by the extension alone, not by vertexAttributeInstanceRateDivisor run 1, this PR @ c6c38854: vertex divisors over 1 are used only with vertexAttributeInstanceRateDivisor, up to maxVertexAttribDivisor: ok test_vertex_divisor_feature exit 0 run 2, main @ c167ec67: test_vertex_divisor_feature exit 1 dev.vertex_divisor is set by the extension alone, not by vertexAttributeInstanceRateDivisor run 2, this PR @ c6c38854: vertex divisors over 1 are used only with vertexAttributeInstanceRateDivisor, up to maxVertexAttribDivisor: ok test_vertex_divisor_feature exit 0 ``` ### Flags and settings None. ## Testing **Tested:** on this branch, Windows, Python 3.12: `test_vertex_divisor_feature` passes (fails on main), and the other check that reads the divisor flag passes: `test_fallback_pipeline_state`. **Built and played:** this commit builds on Windows (llvm-mingw back end) and on Linux (`longshot_vk.so`, without and with AMD FSR 4). Played on Windows, AMD Radeon RX 9070 XT: the game runs normally. **Not tested:** a device with the extension and the feature off: none was at hand (the RX 9070 XT reports the feature, so the change does nothing there). Linux was built, not run. **Must be tested:** None: the game-free test covers the change, and on devices that report the feature nothing changes. ## Risks **What could break:** on a device with the extension and the feature off, streams with a divisor over 1 now read with divisor 1, as they already do on devices without the extension. Before, the same pipelines broke the rule above, so what they drew was undefined anyway. Devices that report the feature are unchanged. **Turning it off:** revert the commit. **Compatibility:** Nothing changes. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). (no issue fits) - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). (the checks that read the changed code, on this PR, Windows: `test_vertex_divisor_feature`, `test_fallback_pipeline_state`, all pass) - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. (`tests/test_vertex_divisor_feature.py`) - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. (`tests/test_vertex_divisor_feature.py` added; no check removed) - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (built on Windows with llvm-mingw and on Linux, `longshot_vk.so` without and with AMD FSR 4)
fix(vk): use vertex divisors only when vertexAttributeInstanceRateDivisor is supported
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
84a8230df1
Assisted-by: GitHub Copilot
jcabarca changed title from WIP: fix(vk): use vertex divisors only when vertexAttributeInstanceRateDivisor is supported to fix(vk): use vertex divisors only when vertexAttributeInstanceRateDivisor is supported 2026-11-15 20:45:03 +00:00
Member

Code-only review of 84a8230df1; informational findings, with final approval left to another reviewer.

No introduced correctness defect found. The feature struct is queried only when the extension is enabled, and the new assignment runs after that query and before device creation. The pipeline's existing dev.vertex_divisor guard then omits divisors greater than 1 when unsupported, matching Khronos's feature requirement and default-divisor rule.

Validation limit: the new test checks source strings and their order, rather than exercising extension absent / feature false / feature true cases and inspecting the resulting pipeline state. A behavioral fixture covering those three cases would strengthen the regression coverage. The reported Windows RX 9070 XT run covers the supported-feature path; the affected unsupported-feature path has not been run. Falling back to divisor 1 avoids the invalid Vulkan use but does not reproduce guest divisors greater than 1; that existing limitation is accurately disclosed in the PR.

Merge coordination: the dynamic vertex-input work also uses dev.vertex_divisor to select divisors, so retain this capability gate when combining the changes. It is complementary, not a duplicate.

Read the full diff, device feature-chain setup, static pipeline construction, existing pipeline-state fixture, and the relevant dynamic-input overlap. No tests, builds, or game runs performed in this review.

Code-only review of 84a8230df1dda47625b3dcd657c5a64ef4cb1553; informational findings, with final approval left to another reviewer. No introduced correctness defect found. The feature struct is queried only when the extension is enabled, and the new assignment runs after that query and before device creation. The pipeline's existing `dev.vertex_divisor` guard then omits divisors greater than 1 when unsupported, matching [Khronos's feature requirement and default-divisor rule](https://docs.vulkan.org/refpages/latest/refpages/source/VkVertexInputBindingDivisorDescription.html). Validation limit: the new test checks source strings and their order, rather than exercising extension absent / feature false / feature true cases and inspecting the resulting pipeline state. A behavioral fixture covering those three cases would strengthen the regression coverage. The reported Windows RX 9070 XT run covers the supported-feature path; the affected unsupported-feature path has not been run. Falling back to divisor 1 avoids the invalid Vulkan use but does not reproduce guest divisors greater than 1; that existing limitation is accurately disclosed in the PR. Merge coordination: [the dynamic vertex-input work](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/801) also uses `dev.vertex_divisor` to select divisors, so retain this capability gate when combining the changes. It is complementary, not a duplicate. Read the full diff, device feature-chain setup, static pipeline construction, existing pipeline-state fixture, and the relevant dynamic-input overlap. No tests, builds, or game runs performed in this review.
jcabarca force-pushed fix/vk-vertex-divisor from 84a8230df1
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to c6c38854b1
All checks were successful
PR description / Description follows the template (pull_request_target) Successful in 4s
2026-11-16 10:30:47 +00:00
Compare
Author
Contributor

New commit, "cap the vertex divisor at maxVertexAttribDivisor" (c6c38854); the branch is rebased onto main @ c167ec67.

The divisor came from the game with no upper bound. VUID-VkVertexInputBindingDivisorDescription-divisor-01870: "divisor must be a value between 0 and VkPhysicalDeviceVertexAttributeDivisorProperties::maxVertexAttribDivisor, inclusive".

  • vk: dev.max_vertex_divisor in gpu/vk/vk_internal.h, read in gpu/vk/vk_main.cpp from VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT::maxVertexAttribDivisor (chained into vkGetPhysicalDeviceProperties2) when dev.vertex_divisor is set.
  • vk: gpu/vk/vk_draw.cpp: the binding's divisor is std::min(s.vstream[b].divisor, dev.max_vertex_divisor).
  • tests: tests/test_vertex_divisor_feature.py checks the query and the cap.

test_vertex_divisor_feature fails on main and passes here. Run twice each side, interleaved; What changed and Measurements in the description are updated.

New commit, "cap the vertex divisor at maxVertexAttribDivisor" (c6c38854); the branch is rebased onto main @ c167ec67. The divisor came from the game with no upper bound. VUID-VkVertexInputBindingDivisorDescription-divisor-01870: "divisor must be a value between 0 and VkPhysicalDeviceVertexAttributeDivisorProperties::maxVertexAttribDivisor, inclusive". - vk: `dev.max_vertex_divisor` in `gpu/vk/vk_internal.h`, read in `gpu/vk/vk_main.cpp` from `VkPhysicalDeviceVertexAttributeDivisorPropertiesEXT::maxVertexAttribDivisor` (chained into `vkGetPhysicalDeviceProperties2`) when `dev.vertex_divisor` is set. - vk: `gpu/vk/vk_draw.cpp`: the binding's divisor is `std::min(s.vstream[b].divisor, dev.max_vertex_divisor)`. - tests: `tests/test_vertex_divisor_feature.py` checks the query and the cap. `test_vertex_divisor_feature` fails on main and passes here. Run twice each side, interleaved; What changed and Measurements in the description are updated.
Author
Contributor

This commit (both commits of the PR) builds on Windows (llvm-mingw back end) and on Linux (longshot_vk.so, without and with AMD FSR 4), and was played on Windows, AMD Radeon RX 9070 XT: the game runs normally. The description's Built and played line and the Host code builds box are updated.

This commit (both commits of the PR) builds on Windows (llvm-mingw back end) and on Linux (`longshot_vk.so`, without and with AMD FSR 4), and was played on Windows, AMD Radeon RX 9070 XT: the game runs normally. The description's Built and played line and the Host code builds box are updated.
Merge branch 'main' into fix/vk-vertex-divisor
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 10s
51d3b54c43
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 10s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/vk-vertex-divisor:jcabarca-fix/vk-vertex-divisor'
git switch 'jcabarca-fix/vk-vertex-divisor'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!919
No description provided.