WIP: perf(vk): programs with the same bindings share one set layout and pipeline layout, so a program change pushes only what changed #800

Draft
dyst wants to merge 1 commit from dyst/Longshot:perf/vk-shared-pipeline-layouts into main
Member

Type: perf · Risk: low · Tested on: Windows 11 (the game-free checks; the game A/B is next) · Needs: a game run on NVIDIA, AMD and Intel

Why

Each shader program had its own descriptor set layout and pipeline layout, and the replay pushes only the descriptors that changed only while the layout is the one it pushed with: every program change pushed every descriptor again, even between programs whose bindings are laid out the same way. Programs change often within a pass. Found in an audit of the renderer's per-draw path; no issue on the tracker.

What changed

Programs whose layouts' create infos are the same now share one set layout and pipeline layout, kept for the device's life, so a program change between them pushes only the writes that differ. Pipelines are made from the same create infos as before and no pipeline key holds a layout handle.

  • draw: layout_signature, layouts_for, SharedLayouts and ensure_layout; the preparation's compute warm leaves shared layouts alone (gpu/vk/vk_draw.cpp)
  • program cache: program_cache_borrow leaves shared layouts alone (gpu/vk/vk_progcache.cpp); Program::layout_shared (gpu/vk/vk_shader.h, not a stamped translator file)
  • docs: the RX_VK_LAYOUT_EACH=1 row in docs/development.md
  • tests: tests/test_shared_layouts.py

Measurements

Verdict: not measured yet: the measurements are pending from the RX_VK_BENCH A/B of this PR @ e2a24c1a against main @ b9e95173 (under way), which will replace this section.

Flags and settings

One switch for an A/B.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
RX_VK_LAYOUT_EACH=1 A set layout and pipeline layout for every program, as before - unset (shared) On: every program change pushes everything measurement pending leave unset; =1 for an A/B

Testing

Tested: Windows 11 (Ryzen 9 3900X), llvm-mingw and the Vulkan headers of the builder's v2.0.14 tools: rebased onto main @ b9e95173 (this PR @ e2a24c1a; it stands alone on main, on no other PR). The 135 checks that read this diff (listed below: those under tests/ and nx2/ that name a changed file, and the ones this PR adds or changes), not the whole suite: python -I -B tests/run_all.py --jobs 6 <those checks> with RX_CPM at the builder's CPM cache: 127 passed, 7 failed; each failure (tests/test_crash_dialog.py, tests/test_linux_driver_fault_guard.py, tests/test_oot_state_tap.py, tests/test_pipeline_tour.py, tests/test_vk_occlusion_queries.py, tests/test_vk_pgo.py, tests/test_walk_key.py) also fails on main @ b9e95173 in the same checks, on the same PC and the same day.

The 135 checks

nx2/test_cbuf_table_extent.py nx2/test_dump_ssbo_read.py nx2/test_mesh_dynamic_state.py tests/test_amd_fragment_warp.py tests/test_bake_ds.py tests/test_bank_gen.py tests/test_bc_raw_targets.py tests/test_check_pr_description.py tests/test_commit_room.py tests/test_crash_dialog.py tests/test_desc_clock.py tests/test_desc_counts.py tests/test_dev_packs.py tests/test_device_lost_exit.py tests/test_dispatch_clock.py tests/test_dlss_checks.py tests/test_draw_binds.py tests/test_draw_side_effects.py tests/test_draw_stream_visibility.py tests/test_drawn_page_map.py tests/test_driver_cache_room.py tests/test_driver_faults.py tests/test_dummy_views.py tests/test_equal_depth_margin.py tests/test_fallback_buffer_cleanup.py tests/test_fallback_depth_hold.py tests/test_fallback_loaded.py tests/test_fallback_pipeline_state.py tests/test_fallback_size_policy.py tests/test_flat_map.py tests/test_framegen_preset.py tests/test_fsr_uniform_ownership.py tests/test_global_table_loop.py tests/test_gpl_cold_library.py tests/test_gpl_library_cache.py tests/test_handle_lookup.py tests/test_handle_table_arrays.py tests/test_hold_gpu.py tests/test_intel_compiler_gate.py tests/test_intel_quick_compute.py tests/test_jobs_failure.py tests/test_jobs_wait_runs_queued.py tests/test_linux_driver_fault_guard.py tests/test_linux_pressure.py tests/test_load_default.py tests/test_masked_clear_failure.py tests/test_mem_trim.py tests/test_menu_env_on.py tests/test_mesh_args_cleanup.py tests/test_mesh_fallback.py tests/test_mesh_fallback_failed_once.py tests/test_mesh_query_feature.py tests/test_met_wait_capture.py tests/test_module_ids.py tests/test_native_float_atomic_add.py tests/test_oot_state_tap.py tests/test_parallel_dry_marks.py tests/test_parallel_rb_refresh.py tests/test_pass_hazard.py tests/test_pcache_fetch_lock.py tests/test_pcache_header_read.py tests/test_pcache_stamp.py tests/test_pipeline_cache_save.py tests/test_pipeline_notes_open.py tests/test_pipeline_play_cache.py tests/test_pipeline_share.py tests/test_pipeline_state_computes.py tests/test_pipeline_state_counts.py tests/test_pipeline_state_portable.py tests/test_pipeline_states.py tests/test_pipeline_tour.py tests/test_precompile_compute_guard.py tests/test_precompile_pipeline_cleanup.py tests/test_predict_resume.py tests/test_predict_sees_loaded.py tests/test_predict_types.py tests/test_predicted_check.py tests/test_prepare_cache_save.py tests/test_prepare_cpus.py tests/test_prepare_seed_stamp.py tests/test_prepare_stall.py tests/test_prepare_workers.py tests/test_prepared_stamps.py tests/test_prof_sampling.py tests/test_program_answer_domains.py tests/test_program_cache_cleanup.py tests/test_program_cache_format.py tests/test_program_cache_index.py tests/test_program_cache_one_variant.py tests/test_program_cache_reader.py tests/test_program_load_wait.py tests/test_program_record_head.py tests/test_program_stamp_knobs.py tests/test_psychov35_dlss.py tests/test_psychov35_taau.py tests/test_push_state.py tests/test_quick_pipelines.py tests/test_radv_mesh_optimizer.py tests/test_reactive_mask.py tests/test_recomplauncher_json.py tests/test_recorder_own_idle.py tests/test_recorder_sync.py tests/test_recording_admission.py tests/test_replay_copies.py tests/test_rumble_menu.py tests/test_same_draw.py tests/test_same_dyn.py tests/test_sampler_admission.py tests/test_seed_variant_cleanup.py tests/test_shader_module_guard.py tests/test_shader_stamp_cache.py tests/test_shader_stamp_inputs.py tests/test_shadow_mask_guard.py tests/test_shared_layouts.py tests/test_split_before_draw.py tests/test_startup_progress.py tests/test_state_list_plain.py tests/test_taau_env_lookup.py tests/test_taau_fxaa.py tests/test_taau_typed_dispatch.py tests/test_table_track.py tests/test_texture_handle_banks.py tests/test_texture_squeeze.py tests/test_third_party_objects.py tests/test_threaded_rendering.py tests/test_tls_objects.py tests/test_tree_shadow_mask.py tests/test_ub_threads.py tests/test_upscale_fallback.py tests/test_upscaler_rows.py tests/test_vertex_bind.py tests/test_vk_occlusion_queries.py tests/test_vk_pgo.py tests/test_walk_key.py tests/test_warm_bounded.py

Not tested: the game yet. This PR is WIP until its A/B is in: the RX_VK_BENCH A/B against main is running on an RTX 3080 with a Ryzen 9 3900X, Windows 11; AMD and Intel need other testers.

Must be tested:

  • Any OS and GPU, defaults and once with RX_VK_LAYOUT_EACH=1: Kokiri Forest and Castle Town a few minutes, expecting the same picture and, with RX_VK_PROF_FINE=1, fewer full pushes a draw (Test Farm: @Beanstalk any, those scenes with and without RX_VK_LAYOUT_EACH=1)

Risks

What could break: A push elsewhere in the same command buffer at the same bind point that does not mark the game's pushed descriptors as disturbed (the temporal actor pass, frame generation, FSR, ASTC decode): the next game draw's delta push would leave the other bindings as that push set them. Two draws of the same program already relied on this; shared layouts make it more frequent.

Turning it off: RX_VK_LAYOUT_EACH=1

Compatibility: Nothing changes: no caches, settings or vk ABI involved.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value.
  • A game-free test added for the fix, failing on main and passing here.
  • Docs updated.

🤖 Generated with Claude Code

**Type:** perf · **Risk:** low · **Tested on:** Windows 11 (the game-free checks; the game A/B is next) · **Needs:** a game run on NVIDIA, AMD and Intel ## Why Each shader program had its own descriptor set layout and pipeline layout, and the replay pushes only the descriptors that changed only while the layout is the one it pushed with: every program change pushed every descriptor again, even between programs whose bindings are laid out the same way. Programs change often within a pass. Found in an audit of the renderer's per-draw path; no issue on the tracker. ## What changed Programs whose layouts' create infos are the same now share one set layout and pipeline layout, kept for the device's life, so a program change between them pushes only the writes that differ. Pipelines are made from the same create infos as before and no pipeline key holds a layout handle. - draw: `layout_signature`, `layouts_for`, `SharedLayouts` and `ensure_layout`; the preparation's compute warm leaves shared layouts alone (`gpu/vk/vk_draw.cpp`) - program cache: `program_cache_borrow` leaves shared layouts alone (`gpu/vk/vk_progcache.cpp`); `Program::layout_shared` (`gpu/vk/vk_shader.h`, not a stamped translator file) - docs: the `RX_VK_LAYOUT_EACH=1` row in docs/development.md - tests: `tests/test_shared_layouts.py` ## Measurements **Verdict:** not measured yet: the measurements are pending from the RX_VK_BENCH A/B of this PR @ e2a24c1a against main @ b9e95173 (under way), which will replace this section. ### Flags and settings One switch for an A/B. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | `RX_VK_LAYOUT_EACH=1` | A set layout and pipeline layout for every program, as before | - | unset (shared) | On: every program change pushes everything | measurement pending | leave unset; `=1` for an A/B | ## Testing **Tested:** Windows 11 (Ryzen 9 3900X), llvm-mingw and the Vulkan headers of the builder's v2.0.14 tools: rebased onto main @ b9e95173 (this PR @ e2a24c1a; it stands alone on main, on no other PR). The 135 checks that read this diff (listed below: those under tests/ and nx2/ that name a changed file, and the ones this PR adds or changes), not the whole suite: `python -I -B tests/run_all.py --jobs 6 <those checks>` with `RX_CPM` at the builder's CPM cache: 127 passed, 7 failed; each failure (`tests/test_crash_dialog.py`, `tests/test_linux_driver_fault_guard.py`, `tests/test_oot_state_tap.py`, `tests/test_pipeline_tour.py`, `tests/test_vk_occlusion_queries.py`, `tests/test_vk_pgo.py`, `tests/test_walk_key.py`) also fails on main @ b9e95173 in the same checks, on the same PC and the same day. <details><summary>The 135 checks</summary> `nx2/test_cbuf_table_extent.py` `nx2/test_dump_ssbo_read.py` `nx2/test_mesh_dynamic_state.py` `tests/test_amd_fragment_warp.py` `tests/test_bake_ds.py` `tests/test_bank_gen.py` `tests/test_bc_raw_targets.py` `tests/test_check_pr_description.py` `tests/test_commit_room.py` `tests/test_crash_dialog.py` `tests/test_desc_clock.py` `tests/test_desc_counts.py` `tests/test_dev_packs.py` `tests/test_device_lost_exit.py` `tests/test_dispatch_clock.py` `tests/test_dlss_checks.py` `tests/test_draw_binds.py` `tests/test_draw_side_effects.py` `tests/test_draw_stream_visibility.py` `tests/test_drawn_page_map.py` `tests/test_driver_cache_room.py` `tests/test_driver_faults.py` `tests/test_dummy_views.py` `tests/test_equal_depth_margin.py` `tests/test_fallback_buffer_cleanup.py` `tests/test_fallback_depth_hold.py` `tests/test_fallback_loaded.py` `tests/test_fallback_pipeline_state.py` `tests/test_fallback_size_policy.py` `tests/test_flat_map.py` `tests/test_framegen_preset.py` `tests/test_fsr_uniform_ownership.py` `tests/test_global_table_loop.py` `tests/test_gpl_cold_library.py` `tests/test_gpl_library_cache.py` `tests/test_handle_lookup.py` `tests/test_handle_table_arrays.py` `tests/test_hold_gpu.py` `tests/test_intel_compiler_gate.py` `tests/test_intel_quick_compute.py` `tests/test_jobs_failure.py` `tests/test_jobs_wait_runs_queued.py` `tests/test_linux_driver_fault_guard.py` `tests/test_linux_pressure.py` `tests/test_load_default.py` `tests/test_masked_clear_failure.py` `tests/test_mem_trim.py` `tests/test_menu_env_on.py` `tests/test_mesh_args_cleanup.py` `tests/test_mesh_fallback.py` `tests/test_mesh_fallback_failed_once.py` `tests/test_mesh_query_feature.py` `tests/test_met_wait_capture.py` `tests/test_module_ids.py` `tests/test_native_float_atomic_add.py` `tests/test_oot_state_tap.py` `tests/test_parallel_dry_marks.py` `tests/test_parallel_rb_refresh.py` `tests/test_pass_hazard.py` `tests/test_pcache_fetch_lock.py` `tests/test_pcache_header_read.py` `tests/test_pcache_stamp.py` `tests/test_pipeline_cache_save.py` `tests/test_pipeline_notes_open.py` `tests/test_pipeline_play_cache.py` `tests/test_pipeline_share.py` `tests/test_pipeline_state_computes.py` `tests/test_pipeline_state_counts.py` `tests/test_pipeline_state_portable.py` `tests/test_pipeline_states.py` `tests/test_pipeline_tour.py` `tests/test_precompile_compute_guard.py` `tests/test_precompile_pipeline_cleanup.py` `tests/test_predict_resume.py` `tests/test_predict_sees_loaded.py` `tests/test_predict_types.py` `tests/test_predicted_check.py` `tests/test_prepare_cache_save.py` `tests/test_prepare_cpus.py` `tests/test_prepare_seed_stamp.py` `tests/test_prepare_stall.py` `tests/test_prepare_workers.py` `tests/test_prepared_stamps.py` `tests/test_prof_sampling.py` `tests/test_program_answer_domains.py` `tests/test_program_cache_cleanup.py` `tests/test_program_cache_format.py` `tests/test_program_cache_index.py` `tests/test_program_cache_one_variant.py` `tests/test_program_cache_reader.py` `tests/test_program_load_wait.py` `tests/test_program_record_head.py` `tests/test_program_stamp_knobs.py` `tests/test_psychov35_dlss.py` `tests/test_psychov35_taau.py` `tests/test_push_state.py` `tests/test_quick_pipelines.py` `tests/test_radv_mesh_optimizer.py` `tests/test_reactive_mask.py` `tests/test_recomplauncher_json.py` `tests/test_recorder_own_idle.py` `tests/test_recorder_sync.py` `tests/test_recording_admission.py` `tests/test_replay_copies.py` `tests/test_rumble_menu.py` `tests/test_same_draw.py` `tests/test_same_dyn.py` `tests/test_sampler_admission.py` `tests/test_seed_variant_cleanup.py` `tests/test_shader_module_guard.py` `tests/test_shader_stamp_cache.py` `tests/test_shader_stamp_inputs.py` `tests/test_shadow_mask_guard.py` `tests/test_shared_layouts.py` `tests/test_split_before_draw.py` `tests/test_startup_progress.py` `tests/test_state_list_plain.py` `tests/test_taau_env_lookup.py` `tests/test_taau_fxaa.py` `tests/test_taau_typed_dispatch.py` `tests/test_table_track.py` `tests/test_texture_handle_banks.py` `tests/test_texture_squeeze.py` `tests/test_third_party_objects.py` `tests/test_threaded_rendering.py` `tests/test_tls_objects.py` `tests/test_tree_shadow_mask.py` `tests/test_ub_threads.py` `tests/test_upscale_fallback.py` `tests/test_upscaler_rows.py` `tests/test_vertex_bind.py` `tests/test_vk_occlusion_queries.py` `tests/test_vk_pgo.py` `tests/test_walk_key.py` `tests/test_warm_bounded.py` </details> **Not tested:** the game yet. This PR is WIP until its A/B is in: the RX_VK_BENCH A/B against main is running on an RTX 3080 with a Ryzen 9 3900X, Windows 11; AMD and Intel need other testers. **Must be tested:** - Any OS and GPU, defaults and once with `RX_VK_LAYOUT_EACH=1`: Kokiri Forest and Castle Town a few minutes, expecting the same picture and, with `RX_VK_PROF_FINE=1`, fewer `full pushes` a draw (Test Farm: @Beanstalk any, those scenes with and without RX_VK_LAYOUT_EACH=1) ## Risks **What could break:** A push elsewhere in the same command buffer at the same bind point that does not mark the game's pushed descriptors as disturbed (the temporal actor pass, frame generation, FSR, ASTC decode): the next game draw's delta push would leave the other bindings as that push set them. Two draws of the same program already relied on this; shared layouts make it more frequent. **Turning it off:** `RX_VK_LAYOUT_EACH=1` **Compatibility:** Nothing changes: no caches, settings or vk ABI involved. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
perf(vk): programs with the same bindings share one set layout and pipeline layout, so a program change pushes only what changed
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 5s
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Workflow lint (actionlint) (pull_request) Successful in 6s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 5s
Third-party parts / As their notes say (pull_request) Successful in 9s
Website / Website on Cloudflare (pull_request_target) Has been skipped
67156a1f65
ensure_layout made a VkDescriptorSetLayout and a VkPipelineLayout for every program, and bind_descriptors pushes only the
changed writes only while the layout is the one pushed with (ps.layout == p.layout): every program change pushed every write,
even between programs whose sets are laid out the same way.

The two create infos are now turned into a signature (layout_signature: the set layout's flags and bindings with their numbers,
types, counts and stages, and the pipeline layout's flags and push-constant ranges), and programs with the same signature get
the same pair from a cache kept for the device's life (layouts_for, under its own mutex: the preparation's workers make layouts
too). Immutable samplers, a pNext chain or another set count are never shared; a failed create is not cached. The two places
that destroyed a program's layouts (the preparation's compute warm, program_cache_borrow) leave shared ones alone
(Program::layout_shared). The pipelines are made from the same create infos, and no pipeline key holds a layout handle.
RX_VK_LAYOUT_EACH=1: a pair for every program, as before (docs/development.md). A log line at each power of two from 1,024
programs says how many layouts they have between them.

tests/test_shared_layouts.py compiles the real layout_signature and layouts_for: the same signature shares, any one field changed
does not, the exclusions, and every destroy of a program's layouts guarded.

Assisted-by: Claude Opus 5.5
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Author
Member

The checks on this PC (Windows 11, RTX 3080, Ryzen 9 3900X, llvm-mingw from the builder's v2.0.14 tools): python -I -B tests/run_all.py on main @ aa95d35f fails these 19 here, and so does this branch: test_appimage_player_build.py, test_bake_portability.py, test_cpm_discovery.py, test_cpp_preflight.py, test_crash_dialog.py, test_env_on.py, test_fpx_sticky.py, test_lift_cleanup_error.py, test_linux_preflight.py, test_make_game_cache.py, test_make_game_prepare.py, test_missing_nup.py, test_oot_state_tap.py, test_options_budget_once.py, test_readback_late.py, test_spawn_emit.py, test_tested_configurations.py, test_vk_pgo.py, test_walk_key.py. Any other failure in a full run on this branch was rerun on its own and passed (the full runs shared the PC with dev_packs builds: timing checks).

Next: an interleaved A/B in the game against main on one dev_packs base of aa95d35f; the numbers will replace the Measurements section.

The checks on this PC (Windows 11, RTX 3080, Ryzen 9 3900X, llvm-mingw from the builder's v2.0.14 tools): `python -I -B tests/run_all.py` on main @ aa95d35f fails these 19 here, and so does this branch: `test_appimage_player_build.py`, `test_bake_portability.py`, `test_cpm_discovery.py`, `test_cpp_preflight.py`, `test_crash_dialog.py`, `test_env_on.py`, `test_fpx_sticky.py`, `test_lift_cleanup_error.py`, `test_linux_preflight.py`, `test_make_game_cache.py`, `test_make_game_prepare.py`, `test_missing_nup.py`, `test_oot_state_tap.py`, `test_options_budget_once.py`, `test_readback_late.py`, `test_spawn_emit.py`, `test_tested_configurations.py`, `test_vk_pgo.py`, `test_walk_key.py`. Any other failure in a full run on this branch was rerun on its own and passed (the full runs shared the PC with dev_packs builds: timing checks). Next: an interleaved A/B in the game against main on one dev_packs base of aa95d35f; the numbers will replace the Measurements section.
dyst force-pushed perf/vk-shared-pipeline-layouts from 67156a1f65
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 5s
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Workflow lint (actionlint) (pull_request) Successful in 6s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 5s
Third-party parts / As their notes say (pull_request) Successful in 9s
Website / Website on Cloudflare (pull_request_target) Has been skipped
to e2a24c1a90
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 6s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 6s
Third-party parts / As their notes say (pull_request) Successful in 11s
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
2026-11-15 19:28:12 +00:00
Compare
Author
Member

Rebased onto main @ b9e95173 (now e2a24c1a; stands alone on main, not stacked); the 135 checks that read this diff, not the whole suite: 127 passed, 7 failed, each failure also failing on main @ b9e95173 in the same checks. Stays WIP: measurements pending from the RX_VK_BENCH A/B.

Rebased onto main @ b9e95173 (now e2a24c1a; stands alone on main, not stacked); the 135 checks that read this diff, not the whole suite: 127 passed, 7 failed, each failure also failing on main @ b9e95173 in the same checks. Stays WIP: measurements pending from the RX_VK_BENCH A/B.
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 6s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 6s
Third-party parts / As their notes say (pull_request) Successful in 11s
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
This pull request has changes conflicting with the target branch.
  • docs/development.md
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'perf/vk-shared-pipeline-layouts:dyst-perf/vk-shared-pipeline-layouts'
git switch 'dyst-perf/vk-shared-pipeline-layouts'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!800
No description provided.