feat(debug): add transition autosave control and quick menu shortcut #614

Merged
HumanBean merged 12 commits from Tommy/Longshot:codex/debug-autosave into main 2026-11-16 00:08:08 +00:00
Contributor

Type: feat · Risk: medium · Tested on: Windows 11, RTX 4090 · Needs: Windows and Linux, any GPU

Why

Debug tools can change progression, and an automatic save can persist those changes during testing. Players need a way to suppress transition autosaves and a shortcut to reach the debug controls in-game. See #578.

What changed

The Debug menu lets players opt out of transition autosaves. A keyboard shortcut opens the compact debug menu during play.

  • The Debug tools prompt offers Cancel and Enable Debug Tools. Confirming turns autosave off, and players can turn it back on in Debug.
  • The Autosave: setting is near the top of Debug and displays On or Off. The saved choice applies with Debug tools on or off. The host filters the verified transition and both map-arrival requests before they are queued. Manual saving remains available.
  • F10 and Home open the compact debug menu. Home also keeps its navigation behavior in open lists.

Measurements

Verdict: Windows in-game pass for the tested route. Off blocked both autosaves after the fix, On wrote one at each crossing, and System → Save still worked with Off.

Hardware: Windows 11 build 26200, RTX 4090 (Vulkan driver ID 0x9b438000), Ryzen 7 7700X, 32 GB RAM.
Scene: Hyrule Field and Kakariko Village, 2560x1440, Debug tools Off.
Method: One round trip per toggle state from the same disposable starting save. Checked progress-file hashes and cross-checked save requests in the trace log.
How to reproduce: Set Transition autosave Off, load the Hyrule Field save at the Kakariko entrance, wait 75 seconds before each crossing, then compare progress slots. Repeat from the same starting save with the toggle On. With Off, use System → Save to verify manual saving separately.
Baseline: Earlier PR build 3b54a58d with Off reproduced the bug. Main has no toggle, so the matched On and Off runs use the fixed build.

Short runs could produce no save even with On. With the wait, suppressing reason 2 alone still let both saves through. The final filter covers reason 1, 2 and 6 at the observed transition call sites.

Progress-save writes Before: earlier PR @ 3b54a58d, Off After: this PR @ 8fd316cd, Off After: this PR @ 8fd316cd, On
Hyrule Field → Kakariko Village → Hyrule Field 2 0 2
System → Save with Off 1 1 Not applicable

The earlier build reproduced the issue. The paired final runs used identical settings and waits apart from the toggle. See docs/tested/ for Codex run02 and run03.

Flags and settings

This PR adds a saved Debug menu toggle and a diagnostic trace switch.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
Autosave / transition_autosave Debug menu row and saved option Transition autosaves enabled On by default Off blocks the verified transition save independently of Debug tools Verified for the tested area transitions on the earlier build Leave On for normal play
HOS_OOT_TRACE_SAVES Diagnostic environment switch Unavailable Off by default Logs save request classification and suppression Used locally during the warp sweep Enable only while investigating save triggers

Testing

Tested: The paced Windows A/B and manual-save check on 8fd316cd passed. On the earlier Windows RTX 4090 build, the user confirmed F10 and Home, walked between Hyrule Field and Kakariko Village with transition autosave off, and made a manual save afterward. The crossings left six monitored progress files unchanged and the manual save changed one. A later warp sweep logged seven blocked transition requests alongside other save requests. The local build was based on 7ff5256e with Vulkan driver ID 0x9b438000. On rebased commit 1f0a276d, the keyboard menu, preset exemption, and option-ID checks passed. The updated Debug row fixture on 9a5b94f4 verifies the toggle is visible and effective with Debug tools on or off. The upscaler round-trip fixture also passed after its update.

Final game-free Windows suite: 506 passed, 16 failed, 72 skipped. The exact upstream base e090cc48 had 505 passed, the same 16 failures, and 72 skipped: tests/test_appimage_player_build.py, tests/test_cpm_discovery.py, tests/test_cpp_preflight.py, tests/test_crash_dialog.py, tests/test_env_on.py, tests/test_lift_cleanup_error.py, tests/test_linux_preflight.py, tests/test_make_game_cache.py, tests/test_make_game_prepare.py, tests/test_missing_nup.py, tests/test_oot_state_tap.py, tests/test_readback_late.py, tests/test_tested_configurations.py, tests/test_vk_pgo.py, tests/test_vram_budget_row.py, tests/test_walk_key.py. The new save-filter test passed on Windows and Ubuntu WSL and caught the missed request on the earlier branch.

On 3b54a58d (based on e090cc48), I used a disposable save on Windows 11 build 26200, RTX 4090 (Vulkan driver ID 0x9b438000), Ryzen 7 7700X and 32 GB RAM, at 2560x1440. With Debug tools Off, I set Transition autosave Off, restarted, and verified both settings were still Off. Walking Hyrule Field → Kakariko Village → Hyrule Field produced a new progress slot at each crossing despite four logged suppressions. The same trace also showed additional request reasons 1 and 2. The follow-up runs above isolated both arrival requests. System → Save then updated one progress slot with the toggle still Off. I set the toggle On and walked back into Kakariko. The transition requests went through and a new progress slot appeared. The game closed cleanly. See docs/tested/2026-11-15-transition-autosave-codex-run01.md.

Additional Windows boundary tests: Rebased on aa95d35f and rebuilt at c2e30565. Each test waited 75 seconds after staging, then walked through the exit with Debug tools Off. The staging teleports were tracked separately.

Walk into Hyrule Field from Off: progress writes On: progress writes
Gerudo Valley 0 1
Castle Town Market 0 1
Kokiri Forest 0 1

Each walk issued the same four requests at the three already covered call sites. Off suppressed all four on every crossing. On suppressed none. No additional save path appeared during these walks. Market and Kokiri staging teleports also wrote progress with On and did not write with Off. Gerudo staging did not write in either run. The first Gerudo Off staging attempt timed out and was repeated in a fresh run before measuring the walk. See Codex runs 04–06 under docs/tested/.

The rebased game-free Windows suite returned 506 passes, 16 failures and 72 skips. The focused save-hook and Debug menu tests passed. The newly appearing options-budget check reports a duplicate gpu_device_id setting on both the PR and upstream aa95d35f.

Retest on ceccd963: Windows build 05e45da9 repeated the Castle Town Market exit into Hyrule Field, with Debug tools Off and a 75-second wait after staging. Off suppressed all four known requests and wrote zero progress saves. On allowed all four and wrote one progress save. Both runs closed cleanly. See Codex runs 07–08 under docs/tested/.

On the latest tested rebase, the Windows suite returned 529 passes, 21 failures and 80 skips. The same run on main at ceccd963 returned 528 passes, the same 21 failures, and 80 skips. The added transition autosave regression passed. The common failures were tests/test_appimage_player_build.py, tests/test_auto_handheld.py, tests/test_bug_report.py, tests/test_cpp_preflight.py, tests/test_crash_dialog.py, tests/test_crt_options.py, tests/test_env_on.py, tests/test_hardware_report.py, tests/test_lift_cleanup_error.py, tests/test_linux_preflight.py, tests/test_make_game_cache.py, tests/test_make_game_prepare.py, tests/test_missing_nup.py, tests/test_oot_state_tap.py, tests/test_options_budget_once.py, tests/test_pads_after_menu.py, tests/test_readback_late.py, tests/test_tested_configurations.py, tests/test_vk_occlusion_queries.py, tests/test_vk_pgo.py, tests/test_walk_key.py.

Wording update (71e37883): The Windows Vulkan renderer built successfully with llvm-mingw. The Debug menu and save-filter checks passed. The same-environment Windows suite returned 520 passes, 30 failures, and 80 skips. Main at ceccd963 returned 519 passes, the same 30 failures, and 80 skips. The extra pass is the save-filter regression. The shared failures were nx2/test_nup_paths.py, tests/test_appimage_player_build.py, tests/test_auto_handheld.py, tests/test_bug_report.py, tests/test_control.py, tests/test_copy_writable.py, tests/test_cpm_discovery.py, tests/test_cpp_preflight.py, tests/test_crash_dialog.py, tests/test_crt_options.py, tests/test_dev_packs.py, tests/test_env_on.py, tests/test_hardware_report.py, tests/test_lift_cleanup_error.py, tests/test_linux_preflight.py, tests/test_make_game_cache.py, tests/test_make_game_prepare.py, tests/test_missing_nup.py, tests/test_oot_state_tap.py, tests/test_options_budget_once.py, tests/test_pads_after_menu.py, tests/test_pipeline_cache_file.py, tests/test_portable_builder_home.py, tests/test_portable_builder_startup.py, tests/test_readback_late.py, tests/test_release.py, tests/test_tested_configurations.py, tests/test_vk_occlusion_queries.py, tests/test_vk_pgo.py, tests/test_walk_key.py.

Two-button dialog (b770e2b7): The Windows Vulkan renderer built with llvm-mingw. Game-free checks verified that Cancel preserves the settings and Enable Debug Tools turns autosave off and saves both settings. The menu-key and autosave filter checks passed. Full Windows run had 520 passes, 30 failures, and 80 skips. All 30 failures also appeared on the same-environment main baseline. The updated dialog still needs a visual check in-game.

Not tested: A native Linux game build and run, physical F10/Home on the rebased Windows build, and autosave events outside the tested areas remain to be verified.

Must be tested:

  • Windows and Linux, any GPU: With Debug tools off, set Autosave to Off, restart to verify it persists, and cross between Hyrule Field and Kakariko Village, expecting the transition save to be skipped. Repeat with the toggle on, expecting the usual transition save. With the toggle off, manually save and confirm it works (by hand, check the save indicator and reload the save).
  • Windows and Linux, any GPU: Try other situations that normally autosave with the toggle off, expecting the known transition trigger to stay suppressed (by hand, report any other autosaves with the area, steps and matching trace lines if available). Some triggers may still fire, so volunteers are greatly appreciated before merge.
  • Windows and Linux, any GPU: Press F10 and Home during gameplay and press Home in an open list, expecting the compact menu to open from gameplay and Home to retain its list-navigation behavior (by hand, check both results).

Risks

What could break: Other autosave triggers can still persist progression changes while the toggle is off. Additional maps and non-transition autosaves still need coverage. The filter matches the observed call sites and leaves unrelated requests alone.

Turning it off: Set Autosave back to On to restore normal transition autosaving. Turning Debug tools off keeps the saved autosave setting.

Compatibility: Existing options files default to transition autosave On when the new setting is absent. The renderer uses the existing option callback, and neither renderer interface struct changes.

Issues

See #578.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main. The Windows build was tested on ceccd963. Main advanced to c64e864f during testing and merges cleanly.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value.
  • Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen.
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md).
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths.
  • Docs updated.
**Type:** feat · **Risk:** medium · **Tested on:** Windows 11, RTX 4090 · **Needs:** Windows and Linux, any GPU ## Why Debug tools can change progression, and an automatic save can persist those changes during testing. Players need a way to suppress transition autosaves and a shortcut to reach the debug controls in-game. See #578. ## What changed The Debug menu lets players opt out of transition autosaves. A keyboard shortcut opens the compact debug menu during play. - The Debug tools prompt offers Cancel and Enable Debug Tools. Confirming turns autosave off, and players can turn it back on in Debug. - The **Autosave:** setting is near the top of Debug and displays On or Off. The saved choice applies with Debug tools on or off. The host filters the verified transition and both map-arrival requests before they are queued. Manual saving remains available. - F10 and Home open the compact debug menu. Home also keeps its navigation behavior in open lists. ## Measurements **Verdict:** Windows in-game pass for the tested route. Off blocked both autosaves after the fix, On wrote one at each crossing, and System → Save still worked with Off. Hardware: Windows 11 build 26200, RTX 4090 (Vulkan driver ID 0x9b438000), Ryzen 7 7700X, 32 GB RAM. Scene: Hyrule Field and Kakariko Village, 2560x1440, Debug tools Off. Method: One round trip per toggle state from the same disposable starting save. Checked progress-file hashes and cross-checked save requests in the trace log. How to reproduce: Set Transition autosave Off, load the Hyrule Field save at the Kakariko entrance, wait 75 seconds before each crossing, then compare progress slots. Repeat from the same starting save with the toggle On. With Off, use System → Save to verify manual saving separately. Baseline: Earlier PR build 3b54a58d with Off reproduced the bug. Main has no toggle, so the matched On and Off runs use the fixed build. Short runs could produce no save even with On. With the wait, suppressing reason 2 alone still let both saves through. The final filter covers reason 1, 2 and 6 at the observed transition call sites. | Progress-save writes | Before: earlier PR @ 3b54a58d, Off | After: this PR @ 8fd316cd, Off | After: this PR @ 8fd316cd, On | |---|---|---|---| | Hyrule Field → Kakariko Village → Hyrule Field | 2 | 0 | 2 | | System → Save with Off | 1 | 1 | Not applicable | The earlier build reproduced the issue. The paired final runs used identical settings and waits apart from the toggle. See docs/tested/ for Codex run02 and run03. ### Flags and settings This PR adds a saved Debug menu toggle and a diagnostic trace switch. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | Autosave / `transition_autosave` | Debug menu row and saved option | Transition autosaves enabled | On by default | Off blocks the verified transition save independently of Debug tools | Verified for the tested area transitions on the earlier build | Leave On for normal play | | `HOS_OOT_TRACE_SAVES` | Diagnostic environment switch | Unavailable | Off by default | Logs save request classification and suppression | Used locally during the warp sweep | Enable only while investigating save triggers | ## Testing **Tested:** The paced Windows A/B and manual-save check on 8fd316cd passed. On the earlier Windows RTX 4090 build, the user confirmed F10 and Home, walked between Hyrule Field and Kakariko Village with transition autosave off, and made a manual save afterward. The crossings left six monitored progress files unchanged and the manual save changed one. A later warp sweep logged seven blocked transition requests alongside other save requests. The local build was based on 7ff5256e with Vulkan driver ID 0x9b438000. On rebased commit `1f0a276d`, the keyboard menu, preset exemption, and option-ID checks passed. The updated Debug row fixture on 9a5b94f4 verifies the toggle is visible and effective with Debug tools on or off. The upscaler round-trip fixture also passed after its update. Final game-free Windows suite: 506 passed, 16 failed, 72 skipped. The exact upstream base e090cc48 had 505 passed, the same 16 failures, and 72 skipped: tests/test_appimage_player_build.py, tests/test_cpm_discovery.py, tests/test_cpp_preflight.py, tests/test_crash_dialog.py, tests/test_env_on.py, tests/test_lift_cleanup_error.py, tests/test_linux_preflight.py, tests/test_make_game_cache.py, tests/test_make_game_prepare.py, tests/test_missing_nup.py, tests/test_oot_state_tap.py, tests/test_readback_late.py, tests/test_tested_configurations.py, tests/test_vk_pgo.py, tests/test_vram_budget_row.py, tests/test_walk_key.py. The new save-filter test passed on Windows and Ubuntu WSL and caught the missed request on the earlier branch. On 3b54a58d (based on e090cc48), I used a disposable save on Windows 11 build 26200, RTX 4090 (Vulkan driver ID 0x9b438000), Ryzen 7 7700X and 32 GB RAM, at 2560x1440. With Debug tools Off, I set Transition autosave Off, restarted, and verified both settings were still Off. Walking Hyrule Field → Kakariko Village → Hyrule Field produced a new progress slot at each crossing despite four logged suppressions. The same trace also showed additional request reasons 1 and 2. The follow-up runs above isolated both arrival requests. System → Save then updated one progress slot with the toggle still Off. I set the toggle On and walked back into Kakariko. The transition requests went through and a new progress slot appeared. The game closed cleanly. See docs/tested/2026-11-15-transition-autosave-codex-run01.md. **Additional Windows boundary tests:** Rebased on `aa95d35f` and rebuilt at `c2e30565`. Each test waited 75 seconds after staging, then walked through the exit with Debug tools Off. The staging teleports were tracked separately. | Walk into Hyrule Field from | Off: progress writes | On: progress writes | |---|---:|---:| | Gerudo Valley | 0 | 1 | | Castle Town Market | 0 | 1 | | Kokiri Forest | 0 | 1 | Each walk issued the same four requests at the three already covered call sites. Off suppressed all four on every crossing. On suppressed none. No additional save path appeared during these walks. Market and Kokiri staging teleports also wrote progress with On and did not write with Off. Gerudo staging did not write in either run. The first Gerudo Off staging attempt timed out and was repeated in a fresh run before measuring the walk. See Codex runs 04–06 under `docs/tested/`. The rebased game-free Windows suite returned 506 passes, 16 failures and 72 skips. The focused save-hook and Debug menu tests passed. The newly appearing options-budget check reports a duplicate `gpu_device_id` setting on both the PR and upstream `aa95d35f`. **Retest on ceccd963:** Windows build 05e45da9 repeated the Castle Town Market exit into Hyrule Field, with Debug tools Off and a 75-second wait after staging. Off suppressed all four known requests and wrote zero progress saves. On allowed all four and wrote one progress save. Both runs closed cleanly. See Codex runs 07–08 under docs/tested/. On the latest tested rebase, the Windows suite returned 529 passes, 21 failures and 80 skips. The same run on main at ceccd963 returned 528 passes, the same 21 failures, and 80 skips. The added transition autosave regression passed. The common failures were `tests/test_appimage_player_build.py`, `tests/test_auto_handheld.py`, `tests/test_bug_report.py`, `tests/test_cpp_preflight.py`, `tests/test_crash_dialog.py`, `tests/test_crt_options.py`, `tests/test_env_on.py`, `tests/test_hardware_report.py`, `tests/test_lift_cleanup_error.py`, `tests/test_linux_preflight.py`, `tests/test_make_game_cache.py`, `tests/test_make_game_prepare.py`, `tests/test_missing_nup.py`, `tests/test_oot_state_tap.py`, `tests/test_options_budget_once.py`, `tests/test_pads_after_menu.py`, `tests/test_readback_late.py`, `tests/test_tested_configurations.py`, `tests/test_vk_occlusion_queries.py`, `tests/test_vk_pgo.py`, `tests/test_walk_key.py`. **Wording update (71e37883):** The Windows Vulkan renderer built successfully with llvm-mingw. The Debug menu and save-filter checks passed. The same-environment Windows suite returned 520 passes, 30 failures, and 80 skips. Main at ceccd963 returned 519 passes, the same 30 failures, and 80 skips. The extra pass is the save-filter regression. The shared failures were `nx2/test_nup_paths.py`, `tests/test_appimage_player_build.py`, `tests/test_auto_handheld.py`, `tests/test_bug_report.py`, `tests/test_control.py`, `tests/test_copy_writable.py`, `tests/test_cpm_discovery.py`, `tests/test_cpp_preflight.py`, `tests/test_crash_dialog.py`, `tests/test_crt_options.py`, `tests/test_dev_packs.py`, `tests/test_env_on.py`, `tests/test_hardware_report.py`, `tests/test_lift_cleanup_error.py`, `tests/test_linux_preflight.py`, `tests/test_make_game_cache.py`, `tests/test_make_game_prepare.py`, `tests/test_missing_nup.py`, `tests/test_oot_state_tap.py`, `tests/test_options_budget_once.py`, `tests/test_pads_after_menu.py`, `tests/test_pipeline_cache_file.py`, `tests/test_portable_builder_home.py`, `tests/test_portable_builder_startup.py`, `tests/test_readback_late.py`, `tests/test_release.py`, `tests/test_tested_configurations.py`, `tests/test_vk_occlusion_queries.py`, `tests/test_vk_pgo.py`, `tests/test_walk_key.py`. **Two-button dialog (b770e2b7):** The Windows Vulkan renderer built with llvm-mingw. Game-free checks verified that Cancel preserves the settings and Enable Debug Tools turns autosave off and saves both settings. The menu-key and autosave filter checks passed. Full Windows run had 520 passes, 30 failures, and 80 skips. All 30 failures also appeared on the same-environment main baseline. The updated dialog still needs a visual check in-game. **Not tested:** A native Linux game build and run, physical F10/Home on the rebased Windows build, and autosave events outside the tested areas remain to be verified. **Must be tested:** - Windows and Linux, any GPU: With **Debug tools** off, set **Autosave** to Off, restart to verify it persists, and cross between Hyrule Field and Kakariko Village, expecting the transition save to be skipped. Repeat with the toggle on, expecting the usual transition save. With the toggle off, manually save and confirm it works (by hand, check the save indicator and reload the save). - Windows and Linux, any GPU: Try other situations that normally autosave with the toggle off, expecting the known transition trigger to stay suppressed (by hand, report any other autosaves with the area, steps and matching trace lines if available). Some triggers may still fire, so volunteers are greatly appreciated before merge. - Windows and Linux, any GPU: Press F10 and Home during gameplay and press Home in an open list, expecting the compact menu to open from gameplay and Home to retain its list-navigation behavior (by hand, check both results). ## Risks **What could break:** Other autosave triggers can still persist progression changes while the toggle is off. Additional maps and non-transition autosaves still need coverage. The filter matches the observed call sites and leaves unrelated requests alone. **Turning it off:** Set Autosave back to On to restore normal transition autosaving. Turning Debug tools off keeps the saved autosave setting. **Compatibility:** Existing options files default to transition autosave On when the new setting is absent. The renderer uses the existing option callback, and neither renderer interface struct changes. ## Issues See #578. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [ ] Rebased on current `main`. The Windows build was tested on ceccd963. Main advanced to c64e864f during testing and merges cleanly. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [ ] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. - [ ] Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [ ] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. - [x] Docs updated.
Add transition autosave control and a compact debug shortcut
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
4fd44d3b05
Tommy force-pushed codex/debug-autosave from 4fd44d3b05
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 1f0a276dfb
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-15 00:24:13 +00:00
Compare
Author
Contributor

Rebased onto main at 6c9edffe. The keyboard menu, preset exemption, and option-ID checks passed on 1f0a276d. The description now lists the remaining autosave and shortcut checks needed before merge.

Rebased onto main at 6c9edffe. The keyboard menu, preset exemption, and option-ID checks passed on 1f0a276d. The description now lists the remaining autosave and shortcut checks needed before merge.
feat(debug): make transition autosave independent of debug tools
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
9a5b94f45a
Assisted-by: OpenAI Codex
Author
Contributor

Transition autosave now lives in the general Debug tab and applies with Debug tools off. The Debug row test covers both modes, and the option and trace flag are documented.

Transition autosave now lives in the general Debug tab and applies with Debug tools off. The Debug row test covers both modes, and the option and trace flag are documented.
fix(debug): keep the menu implementation in its namespace
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
67bd926492
Assisted-by: OpenAI Codex
Author
Contributor

The Windows renderer builds on 67bd9264. The Windows suite comparison is in the description, including the failures also reproduced on main and the Builder timeout that passed on rerun.

The Windows renderer builds on 67bd9264. The Windows suite comparison is in the description, including the failures also reproduced on main and the Builder timeout that passed on rerun.
Tommy force-pushed codex/debug-autosave from 67bd926492
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 3b54a58de1
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-15 05:23:14 +00:00
Compare
docs(test): record Windows transition autosave results
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 14s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
5239f44b3b
Assisted-by: OpenAI Codex
Author
Contributor

Rebased on e090cc48 and tested the Windows game build at 3b54a58d. Off persisted with Debug tools disabled and blocked the known transition requests, but both crossings still wrote progress saves. Manual Save worked with Off, and the On comparison also wrote a save. The test result is recorded in docs/tested; keeping this draft open for the remaining autosave investigation.

Rebased on e090cc48 and tested the Windows game build at 3b54a58d. Off persisted with Debug tools disabled and blocked the known transition requests, but both crossings still wrote progress saves. Manual Save worked with Off, and the On comparison also wrote a save. The test result is recorded in docs/tested; keeping this draft open for the remaining autosave investigation.
Assisted-by: OpenAI Codex
Assisted-by: OpenAI Codex
Assisted-by: OpenAI Codex
docs(test): verify both autosave settings in game
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
aae1e9334d
Assisted-by: OpenAI Codex
Author
Contributor

Fixed both map-arrival autosave requests. With 75 seconds before each crossing, Off wrote zero autosaves, On wrote two, and manual saving worked with Off. The new regression check passes on Windows and Ubuntu. The full Windows suite has the same 16 failures as the exact upstream base.

Fixed both map-arrival autosave requests. With 75 seconds before each crossing, Off wrote zero autosaves, On wrote two, and manual saving worked with Off. The new regression check passes on Windows and Ubuntu. The full Windows suite has the same 16 failures as the exact upstream base.
Tommy force-pushed codex/debug-autosave from aae1e9334d
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to c2e30565c9
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-15 14:02:19 +00:00
Compare
docs(test): verify autosaves on three more map boundaries
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
68456184af
Assisted-by: OpenAI Codex
Author
Contributor

Rebased onto aa95d35f and tested three more natural exits into Hyrule Field on c2e30565: Gerudo Valley, Market and Kokiri Forest. Each wrote zero progress saves with Off and one with On. All walking traces matched the existing filter, and no additional save path appeared.

Rebased onto aa95d35f and tested three more natural exits into Hyrule Field on c2e30565: Gerudo Valley, Market and Kokiri Forest. Each wrote zero progress saves with Off and one with On. All walking traces matched the existing filter, and no additional save path appeared.
HumanBean force-pushed codex/debug-autosave from 68456184af
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 3d04415d7f
Some checks failed
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 5s
Third-party parts / As their notes say (pull_request) Successful in 9s
Website / Website on Cloudflare (pull_request_target) Has been skipped
2026-11-15 18:45:10 +00:00
Compare
Owner

Rebased onto main @ bbe6fdf2: no conflicts. No tests were run here; the test boxes stay yours.

Rebased onto `main` @ bbe6fdf2: no conflicts. No tests were run here; the test boxes stay yours.
Tommy force-pushed codex/debug-autosave from 3d04415d7f
Some checks failed
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 5s
Third-party parts / As their notes say (pull_request) Successful in 9s
Website / Website on Cloudflare (pull_request_target) Has been skipped
to 999f40478d
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 8s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-15 21:17:59 +00:00
Compare
HumanBean approved these changes 2026-11-15 23:50:12 +00:00
Dismissed
fix(debug): clarify the autosave setting
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
71e37883ab
Assisted-by: OpenAI Codex
Tommy dismissed HumanBean's review 2026-11-15 23:56:27 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Tommy changed title from WIP: feat(debug): add transition autosave control and quick menu shortcut to feat(debug): add transition autosave control and quick menu shortcut 2026-11-15 23:58:31 +00:00
fix(debug): turn off autosave when enabling debug tools
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Failing after 3s
b770e2b720
Assisted-by: OpenAI Codex
HumanBean deleted branch codex/debug-autosave 2026-11-16 00:08:09 +00:00
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Failing after 3s
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!614
No description provided.